GitLab

After (ms) - 14238
Before (ms) - 59160

BUG=989569

Change-Id: Idc6372fcab314f13cbfd63b471ac916b932a16d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504634
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821795}

*Allow optionally enforcing that the name ends with a zero-length label
 (the root label).
*Add additional validation that the name doesn't use DNS name
 compression, and that the name is within the max DNS name length.
*Add an overload that takes a BigEndianReader as input. Better supports
 parsing within a DNS message when the name needs to be parsed to know
 its total length and where the next data starts after the name.

These improvements should be useful in parsing HTTPS records.

Bug: 1138620
Change-Id: Ice66aa880a8c5407af3bfd9a14d720d518ae2136
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493153
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821794}

Specifically disabling:
 - LeaveSiteStillWarnsAfter
 - TimeOpenHistogram

These tests seem to rely on subtle timing of the NewTabPage initial
loading and are flaking on multiple platforms.

Bug: 1142769,1139955
Change-Id: I848acd8ac9c4bd65945cb5070a87ecea46b27885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502771
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821793}

Sample failure:
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9457

TBR=dtrainor@chromium.org

Bug: 1128033
Change-Id: Ib7696c28e273f5762fe5718c429d8b1ec82e3444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505793Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821792}

This creates an empty directory to be used to write the liburlpattern
code.  This library will be the URL pattern matching engine for the
URLPattern web API being developed in:

  https://github.com/wicg/urlpattern

The pattern syntax is based on the populat path-to-regexp library:

  https://github.com/pillarjs/path-to-regexp

This is being developed as a separate library so that it can be a
derivitive work of path-to-regexp using an MIT license.  No code from
path-to-regexp will be directly included here.

Bug: 1141510
Change-Id: Ia695bf927c40723b3d5adc171fd2b8d3bb879772
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486388Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821791}

This change makes it so that all tests in database_unittest.cc now run
both with WAL mode on and off. Better test coverage will help us
transition to using WAL mode by default in the future.

Bug: 78507
Change-Id: I116a8151c1ab4919a78657e46df98b26eddb7f11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490664
Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821790}

And update all consumers to pass one in.

Bug: 1082280
Change-Id: I97e2559616f01d600848025a16b916d583759504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497463Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821789}

This CL fixes the action sheet anchor position to the leading button of
the top toolbar of the tab grid view controller.
Previously the anchor could be attached to the bottom toolbar which was
a problem when the screen size changed.



Bug: 1140982
Change-Id: I9ea7646002f5a2be9c9b35bd9e3b3ec53e2751b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502378
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821788}

Previously, any isolated script test that ran on a bot
required the `--isolated-script-test-output` flag to be
passed to it.

This CL makes that flag optional.

This was made mandatory originally in order to ensure that
it was being called correctly; however, making it mandatory
means that devs have to set it when using the script locally,
even if they don't care about the output. Fixing the latter
problem seems worth not catching the former at this point;
it seems unlikely we'll introduce a bug in the recipes that
the mandatory flag check would catch.

Also, if you wanted to use a generated bin/run_ script
that contained an argument that would otherwise be expanded
by swarming (something like `--system-log=$ISOLATED_OUTDIR/system.log`),
this CL will allow that to now be embedded into the bin/run_
wrapper. If ISOLATED_OUTDIR is not set locally (and it usually
won't be), then the arg will be dropped.

These two changes in conjunction should allow us to move
all of the command line arguments that are essentially
compile-time-static into the bin/run_ wrapper (thus further
simplifying what is configured in gn_isolate_map.pyl and the
//testing/buildbot/*.pyl files) while still preserving dev-friendliness.

That said, this CL itself should introduce no functional changes
other than the --isolated-script-test-output flag no longer being required.

Bug: 816629
Change-Id: Ic02d2acc44c4a305dceff1fcab50cfe48d515b8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462070
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821787}

I'd like to use this lib to upload Chrome OS tests to rdb as well. Some
of the tests have some artifacts that should be attached to their
results.

So this CL lets the caller of result_sink.Post() specify custom
artifacts.

Bug: 1129654
Change-Id: I35bc4009020d724e38adebb4af3cebd12a7b44be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504579Reviewed-by: benjamin joyce <bjoyce@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821786}

The keychain item creation is failing on Mac. Creating a feature flag so
that we could debug this issue on official release without affecting
normal users.

Bug: 1142956
Change-Id: I186089676683d01a862a961f88a494886f6d30a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503632
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821785}

This patch allows a NGBlockLayoutAlgorithm to "shift" its content, in
order to perform vertical-alignment within table-cells.

Previously this was done by intrinsic-padding.

And the end of layout, we "finalize" for the table cell, shifting
the content to the desired alignment location.

Within the caching logic for the common case where we don't have an
alignment baseline (for the "measure" pass), then we do (for the
"layout" pass), we hit the cache if the alignment-baseline, and the
actual baseline are the same.

Bug: 958381
Change-Id: I4a9edd3dd8ecc6e8ec90f6b7042f7af644bd0be0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500981
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821784}

The parent widget returned by this method is captured at widget
construction and reparenting.

This CL intentionally does not expose the underlying
NativeWidget/NativeView hierarchy to the widget level, because that
hierarchy is platform dependent and not consistent in various ways.

For examples of NativeWidget inconsistency on Aura,
- Usually, the root aura::Window of a NativeWidget has a parent.
- Yet, NativeWidgetAura will override parent to nullptr when
  params.child is false. The parent-child relationship is instead
  managed by TransientWindowManager.
- DesktopNativeWidgetAura will not attach child to its parent widget.
  Yet, the actually os window (e.g. HWND) will keep the relationship.

Bug: None
Change-Id: Id8bf0d393af4132b30f712e3274a100bfa5e8a85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500461
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821783}

 - Add custom css vars that can be updated at different
   breakpoints to conform to the spec.
 - Align scan preview and dropdown section.
 - Update html markup to support panel layout.

Screenshot: http://shortn/_vmZWXoAuiQ

Bug: 1059779
Test: browser_tests --gtest_filter=ScanningUIBrowserTest.All
Change-Id: I36927a2c2b9e7370916aa8d1010083bf2f6d601e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504209
Commit-Queue: Michael Checo <michaelcheco@google.com>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821782}

Bug: 1099916
Change-Id: I1fc5b170dc879a191e96eea03366366a55234655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505832
Auto-Submit: Haiyang Pan <hypan@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821781}

Specify in the histogram README and presubmit checks that the primary
owner of a histogram needs to be a Googler, not just someone with an
@chromium.org email address.

Bug: 1142896
Change-Id: I39e522430d6cacb44c39645efb31499394e8d218
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504631
Commit-Queue: Mario Bianucci <mabian@microsoft.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821780}

Sync down local-device, contact, and certificate data from the Nearby
server when the sending or receiving flow starts, making our best effort
at freshness. We do not wait for these calls to finish. The periodic
server requests will typically be sufficient, but we don't want the user
to be blocked for hours waiting for a periodic sync.

Manually verified that the download is performed once during a sending
flow and once during a receiving flow.

Fixed: b/168834197
Change-Id: Id35e097ce09cfe7c5a85f079074943788d2359b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505009
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821779}

When enabled, the holding space tray will have an icon representative of
the holding space model contents.

As holding space items are added to the model, the icon is updated to
include a new visual representation of the added item. As holding space
items are removed from the model, stale representations are removed.

The visual representations for items are rendered using ui::Layers added
to the holding space tray icon which only exist when visible in the
viewport. This is to limit the number of layers if the user happens to
have a large number of holding space items.

Note that this CL just roughs things in. Still TODO:
- Animate bounds changes.
- Animate icon visibility changes.
- Render ImakeSkia's for items to their layers.
- Handle side shelf.

Changes are guarded by a new FeatureParam and disabled by default.

Screenshot: https://screenshot.googleplex.com/6g64LPbEUNc8o8U

Bug: 1142572
Change-Id: I3eada919a6d28ccfb208d1b15b8990d4762f3dd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499882Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#821778}

To be used in MostVisitedSites and related services in components/

Change-Id: Icba6dbd470c4bf226726b808c671edba9838a7a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500521
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821777}

Android Appliance reuses the Android Things product
type instead of falling through to Android TV.

Bug: b/171569831
Test: local product build/manual test
Change-Id: I4161ba6555bb4471677a0a6da4c9eb3129c7f285
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496193
Auto-Submit: Brett Kilty <brettk@google.com>
Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821776}

This CL ensures that the colors used by the multipaste menu are
consistent with the specs. In detail, this CL does the following jobs:
(1) Correct the image border color.
(2) Modify the menu item highlight color.
(3) Change the menu text's style and color.

Bug: 1141694, 1131729
Change-Id: I5a55b66cbf9bc0abc97160b4fb7ca2cd030363e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493833
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#821775}

Changes "vield" to "field".

Bug: b:171722197
Change-Id: Ieb9bc10dcc090486e48afa560bb836c335e0c5ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498853
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821774}

This is a revert of the changes of DeskNameView at crrev.com/c/2486781.
Since Textfield::OnThemeChanged SetBackground, we should override it
at DeskNameView::OnThemeChanged to have our own background.

Bug: 1142692
Change-Id: I24b78bd730b010a60180782d646c9b88772123f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501066Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821773}

For the exception section shown in settings -> content settings ->
pop-ups, if there are exceptions set by the policy(AllowedPopupsForUrls)
when pop-ups is blocked, they shouldn't be editable. At the same time,
if there are some exceptional allowed popups set by the user, they
remain editable. If all allowed popups urls are set by the policy, then
the "edit" button on the top right of the page should be disabled.

The UI and behaviour of the exception section is the same with above if
DefaultPopupsSetting is set to "2" (block).

Bug: 1142620
Change-Id: I0948acccc3bdf78be277b818a8f01a119a51856a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500252Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821772}

https://skia.googlesource.com/skia.git/+log/270b5c04c234..71f12666647b

2020-10-28 mtklein@google.com Revert "SkPathView for ownerless (can live on stack) SkPaths"
2020-10-28 egdaniel@google.com Fix variable name in new uma macro.
2020-10-28 johnstiles@google.com Split the SkSL pool into small and large sections.
2020-10-28 fmalita@chromium.org [svg] Convert text-anchor to a presentation attribute
2020-10-28 tdenniston@google.com Add support for arc-length metric in variable width stroke sample

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1141332
Tbr: jcgregorio@google.com
Change-Id: Ibe8a16f0af07e493d5b2153fdce327b2b41b0439
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506009Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821771}

This patch unifies creates the constraint-space for table-cells. Before
we had two different code-paths leading to subtle differences in
construction causing various types of cache misses.

This unifies the code-paths ensuring that they can remain as similar as
possible.

Bug: 958381
Change-Id: I59d7252ba3db52c36b2118d9695cea106326a1e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498836
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821770}

This would be useful to understand if there is a strong correlation
between high memory usage and UTEs. And if there is then what is the
watermark.

Bug: 1103752
Change-Id: I6792ae6837f4912225d5908d56fd751d6ce51843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500941
Auto-Submit: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821769}

Add the first set of unit tests for LorgnetteManagerClient. These
tests cover the ListScanners() and GetScannerCapabilities() methods, as
well as several failure cases for the kScanStatusChangedSignal. Still to
be done are tests for the StartScan method. Also do some minor cleanup
of lorgnette_manager_client.cc.

Bug: b:169573779
Change-Id: I64ff7f31430db62fe21e7632db3bd2bb7be8547e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495514Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Paul Moy <pmoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821768}

Bug: 1087263
Change-Id: I6ca16d0a3037262ea03169bb582f3f67f4c62e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505829Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821767}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010280700_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/bvq8h_3qcpwsdxTwUG4X0xotu2aez7gKp0cfE2xFsewC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: b/162704716,b/170681582,b/171154696,b/171154801,b/171773997
Tbr: media-app@grotations.appspotmail.com
Change-Id: I3fa47328d64a264bf51e71052d79a9d06de40c85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505592Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821766}

- Add overview of how perf builders, testers, and processors work
- Add tip on how to debug tests

Bug: chromium:1143048
Change-Id: Iebb8c72b47a5ef1dbc5c9171e3fa7148ebb202b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503652
Commit-Queue: Ryan Heise <heiserya@google.com>
Auto-Submit: Ryan Heise <heiserya@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821765}

Bug: 1015841
Change-Id: Ib301161e8011a60e8edd2be90933dae22ab0a43e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504316Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821764}

Extend HardwareDisplayControllerTest to make sure every assigned
prop has been correctly committed at modeset/disable for crtc, connector and plane.

BUG=1082882,1136610
TEST=HardwareDisplayControllerTest.{CrtcPropsAfterModeset,
ConnectorPropsAfterModeset, PlanePropsAfterModeset,
CheckDisableResetProps}

Change-Id: Ifc9a00c5d5991f0d5dea5190865aaeccdd0f5537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488363
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Reviewed-by: Gil Dekel <gildekel@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821763}

Change Log:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/4b915e7092..962b067540
Full diff:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/4b915e7092..962b067540

Bug: None
Change-Id: Ib9b244cd3642c1a839febd591fc84f95cdf7bc81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504235
Commit-Queue: Danil Chapovalov <danilchap@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Auto-Submit: Danil Chapovalov <danilchap@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821762}

There's one more refactoring that I'm doing to color and css-var swatches
in DevTools frontend that require one more web test to be disable in order
to land.

Once landed, I'll write a new E2E test in devtools-frontend to cover
what this test was doing instead of just re-enabling it.

Bug: 1137438
Change-Id: I44f8ca212ab7f230c73665befff7c8334d7b91b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505619Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#821761}

The compiler needs additional flags `-isystem ...` and `-iframework ...`
to point to the iOS support headers and libraries to build iOS apps with
the macOS SDK (which is how "catalyst" builds work).

The app build for "catalyst" environment have the same bundle structure
as a regular macOS app, so the linker flag for `-rpath ...` needs to be
adjusted to work in that environment.

Bug: 1138425
Change-Id: I4cb8126d111a825408d5a63f248e56cfca99de8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498546
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821760}

It was not possible to change the login screen profile's default
bluetooth preference through settingsPrivate. This cl enables that
behavior.

Bug: b:161902990
Change-Id: Ib0f0f798994182a19ee01562d7d5899667b58525
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500445Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Billy Zhao <billyzhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821759}

The variable ios_sdk_platform_abs_path is always set to the value
of ios_sdk_platform_path. There is no need for two variables with
the same value, remove the less used one.

Bug: 1015730
Change-Id: Ie4903ff9e857be8032770c9732db105fe49829c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505812
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821758}

their default value in a machine readable way.

Add presubmit check to ensure new policies that should have defaults
specify their defaults.

Added the new default field to one of each of the types that should
have defaults to ensure the validation code works.

Default were added to:
 MaxConnectionsPerProxy
 AbusiveExperienceInterventionEnforce
 AssistantOnboardingMode
 CACertificateManagementAllowed

Bug: 1139046
Change-Id: I456d45bb98e6ffeb5447d03117f429df8936f8a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476585Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821757}

This addresses a performance regression where histograms
presubmits were taking > 2 minutes after:
https://chromium-review.googlesource.com/c/chromium/src/+/2450734

This CL adds memoization to dirmd invocations because only a few
distinct OWNERS files are specified as owners of histograms, so
we can reduce the amount of subprocess invocations significantly.

On my machine, ./tools/metrics/histograms/validate_format.py
goes from 2m8s to 25s with this change with Python 2.

Bug: 1142714
Change-Id: I1f60c60b7e6014008244c214ec7302f40e58517a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505593Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821756}