GitLab

Per UX request (see bug).
See also screenshots (Googlers only):
https://docs.google.com/presentation/d/1IeyKg22nSbt8aDkvCGrHx1SBg7UBQIqymWDj2sLJ9JQ/edit#slide=id.g3fd38cc212_0_5

Bug: 876291
Change-Id: I8c782d42a5901286ee2c657b7625fbdab4dd62a2
Reviewed-on: https://chromium-review.googlesource.com/1184057Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585016}

Bug: 866337
Change-Id: I316fa8be8ce10f638f67fbc7e1eb28d05f1c0ab3
Reviewed-on: https://chromium-review.googlesource.com/1183321
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585015}

Update visual viewport unit tests for blink gen property trees. BGPT
still creates layers in the compositor so the changes are fairly
limited. In places where we check layer properties, this patch also adds
checks for the equivalent paint properties.

Bug: 836915
Change-Id: I3d821cea1021b28d87ceff188931eaae3fa3b7c4
Reviewed-on: https://chromium-review.googlesource.com/1184963Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585014}

This reverts commit ba40c8a2.

Reason for revert: Causing failure on Linux Tests (dbg) bot.

See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/52253

Sample logs:
[ RUN      ] AXPlatformNodeAuraLinuxTest.TestAtkText
../../ui/accessibility/platform/ax_platform_node_auralinux_unittest.cc:871: Failure
Value of: ATK_IS_TEXT(root_atk_object)
  Actual: false
Expected: true
Stack trace:
#0 0x000008299a59 StackTraceGetter::CurrentStackTrace()
#1 0x0000082be414 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#2 0x0000082bd86e testing::internal::AssertHelper::operator=()
#3 0x00000821fe0c ui::AXPlatformNodeAuraLinuxTest_TestAtkText_Test::TestBody()
#4 0x0000082f91eb testing::internal::HandleSehExceptionsInMethodIfSupported<>()
[  FAILED  ] AXPlatformNodeAuraLinuxTest.TestAtkText (2 ms)


Original change's description:
> Expose the basic AtkText interface for text elements
> 
> AtkText is the proper way to expose static text to accessibility agents.
> This change adds initial support for the interface, but there is quite a
> bit of work left to properly expose hypertext as well as implement the
> rest of the required interface functionality.
> 
> Bug: 866337
> Change-Id: Iab121b1b18bc00bcbdd35bfa310e7a1a2b141e18
> Reviewed-on: https://chromium-review.googlesource.com/1179752
> Commit-Queue: Martin Robinson <mrobinson@igalia.com>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584989}

TBR=dmazzoni@chromium.org,mrobinson@igalia.com

Change-Id: Idb25bb0c8bd494b10f6eed2fd213552178a5f62b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 866337
Reviewed-on: https://chromium-review.googlesource.com/1184924Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585013}

I changed the metric name in
https://chromium-review.googlesource.com/c/catapult/+/1181702.

This CL comments out the test for that metric so that the Catapult
roller is unblocked. After Catapult is rolled to after the renaming
CL the test should be re-enabled.

Bug: 876276
Change-Id: Ie83b3cd86c6324ea00cdad0da5f9b1c082fd558a

NOTRY=true # CQ flake

Change-Id: Ie83b3cd86c6324ea00cdad0da5f9b1c082fd558a
Reviewed-on: https://chromium-review.googlesource.com/1183694Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#585012}

Bug: 875544
Change-Id: I8d2b81e6131df537fbea872753e08cf8f638783f
TBR: huayinz@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1184910Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585011}

This CL makes sure that it is possible to exit fullscreen by tapping the
collapsed toolbar.
For now, it is possible to exit it by tapping the steady view.

Bug: 862557
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I31667dd679d1b38f41d819197aedc54c76024ab4
Reviewed-on: https://chromium-review.googlesource.com/1184912Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585010}

Adds the new icon for addresses and for keyboard.

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I775b06b39a8f797c16669511ab8aa057bdd14133
Reviewed-on: https://chromium-review.googlesource.com/1183223Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585009}

Currently there are some more people actively working on determinism things.

Derived from
https://chromium-review.googlesource.com/c/chromium/src/+/1183999#message-173c888fec19d325b8f1c8b4a1e8d835b82b52aa

Change-Id: I0306ad04dc0e7cb71592daa5a5005eb423ea4236
Reviewed-on: https://chromium-review.googlesource.com/1184124
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585008}

The method CreateMimeHandlerViewGuestIfNecessary() has an implementation
in mime_handler_view_container_base.cc. It is marked as abstract by
mistake.

TBR=wjmaclean@chromium.org

Bug: 659750
Change-Id: If4751752f05ff120f47c7d65a5a6c3189aa08ac3
Reviewed-on: https://chromium-review.googlesource.com/1184119Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585007}

If the sandbox target process is very short-lived (as in some multiprocess
tests), and also takes long enough to spawn that the first TimedWait on the
init done notifier times out, then there's a race between the target process
exiting and the parent process calling TimedWait again. Instead of polling in a
loop, use WaitForMultipleObjects to wait for both the init done notifier and
process exit.

TBR=csharp
TBR_REASON=Already reviewed in internal repo.

Bug: 874387
Change-Id: I86af661bbe43f3fc044fb5afd6bcbd9f9d7b297c
Reviewed-on: https://chromium-review.googlesource.com/1184214Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585006}

Skia's mask-filter occlusion rect feature has been defunct since the Skia CL:

https://skia-review.googlesource.com/c/skia/+/147561 (Remove occluder feature from blur mask filter)

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iaa5656f0ff9e4b99500389651789f549f4352846
Reviewed-on: https://chromium-review.googlesource.com/1183623Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#585005}

Add a function to conver the data returned by test-results server about
known masters, builders, and test_types into a DataFrame for more
convenient querying of the data on it.

Also add a corresponding unit test.

NOTRY=true

Bug: 875251
Change-Id: Ifa03250669fe3b661f093ff0e1ca172db85fade6
Reviewed-on: https://chromium-review.googlesource.com/1179888
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#585004}

This CL adds a python schema validator that can validate JSON schemas.
The schema validator is used in a presubmit to validate all the schemas
in policy_templates.json. The schema validator itself supports the
minimal set of features needed for our current policies.

Bug: 873641, 856903, 856901
Change-Id: Ie577e825807e4438eca6921722b88af7c8d1781c
Reviewed-on: https://chromium-review.googlesource.com/1172433
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585003}

Bug: 876623
Change-Id: I086440a188e915894393805a9973d1419efc3d06
TBR: tapted@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1185010Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585002}

This is a temporary patch to merge back to 69 while we figure out the root cause.

Bug: 876201
Change-Id: Id87ac81f16b1cd3102c8605691421e8bc53dc401
Reviewed-on: https://chromium-review.googlesource.com/1183991Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585001}

Bug: 8766133
Change-Id: I8e6656d381de3db9add7fc99b0ac091db816d59f
TBR: ccameron@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1185005Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585000}

Document all steps. Use ArrowDown key to select a file list item (Ctrl
is not needed) and check its fakeKeyDown return value. Also rename the
helper to selectFirstFileListItem, and use class and id selectors when
querying for file list row item selection.

Test: browser_tests --gtest_filter="CreateNewFolder/FilesApp*"
Bug: 876267
Change-Id: I230ca4a54069c79169eac7a44003d81cd57d3c64
Reviewed-on: https://chromium-review.googlesource.com/1183271
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584999}

https://chromium-review.googlesource.com/c/chromium/src/+/1184510 is
the most recent failure to import due to this test.

This test fails passes on try bots but fails in CQ for Linux and
Win. Include timeout in expectations too since that is the current
state.

TBR=robertma

Bug: 875622
Change-Id: I24662da5bf918941e59bd331a7871050c798d177
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1184904Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584998}

This test is flaky on Linux TSAN.

Bug: 876561
Change-Id: Ie389a8cf31a40513057d32d6ce89e44765e7c0ee
TBR: erikchen@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1184908Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584997}

Before this change the button was OFF when the window appears and then
updated with animation after that.

Test: manual
Bug: 868307
Change-Id: Iac019198518415ae5c98cc716d85c90f014d8fae
Reviewed-on: https://chromium-review.googlesource.com/1177220Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584996}

We have hidden the lock icon badge in the status tray to avoid visual
clutter, but the logic was not applied on dark color icons in OOBE.


Test: manual test by connecting to an encrypted wifi access point at OOBE
Bug: 874012
Change-Id: I529591faeba8febfce918dd400cc3d230da58658
Reviewed-on: https://chromium-review.googlesource.com/1177081Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584995}

Bug: 876362
Change-Id: I0365a4e466c49b8cb05eec5b808a81ce83f9c58c
TBR: alemate@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1185004Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584994}

The color of disabled icons are different from the inactive ones.
Disabled means the function is not available, whereas inactive means
the toggle state is turned to OFF.

Bug: 853695,875459
Change-Id: I0f4115483f5477720e65b7a0d25c7f5f79a184e5
Reviewed-on: https://chromium-review.googlesource.com/1181015Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584993}

Using wpt-import in Chromium 385952ee.
With Chromium commits locally applied on WPT:
2160c22c "Modify source path for wpt test of Accept-CH"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23128

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
ericwilligers@chromium.org:
  external/wpt/css/motion
kojii@chromium.org:
  external/wpt/css/css-scoping
meade@chromium.org:
  external/wpt/web-animations
rouslan@chromium.org, mathp@chromium.org:
  external/wpt/payment-request
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=foolip

No-Export: true
Change-Id: I9740569ef2c1edab2be41615fe7ad625cb052abd
Reviewed-on: https://chromium-review.googlesource.com/1184961
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584992}

OwnedMailbox is ref counted and can outlive the GLES2Interface* it
holds. This is because the callback has a scoped_refptr<OwnedMailbox>
which prevents destroyed the OwnedMailbox.

The ownership model for OwnedMailbox should probably be reworked, but
the class will be replaced fairly soon anyways. Change callback to hold
a WeakPtr instead of scoped_refptr so that OwnedMailbox gets destroyed
at the correct time.

OwnedMailbox is also no longer used with GLHelper and the shared main
thread context, so it doesn't need to be a ContextFactoryObserver to
find out about losing the shared main thread context. Delete
ImageTransportFactoryTearDownBrowserTest.LoseOnTearDown which tested the
now deleted functionality.

Bug: 874616
Change-Id: Iab95a906c4006427e0a0046c56fe20f75d9788a6
Reviewed-on: https://chromium-review.googlesource.com/1178221
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584991}

kGestureDoubleTap is used by Android only, and page scale animations
should only be iniitated in the main frame renderer. WebViewImpl has
special handling logic that avoids sending this event to EventHandler,
but the current (incomplete) implementation for OOPIFs in
WebFrameWidgetImpl does forward it to EventHandler, hitting a variety
of NOTREACHED points along the way.

This CL modifies WebFrameWidgetImpl to drop this event without sending
it to EventHandler, and return the same status as WebViewImpl does.

Bug: 734209
Change-Id: I900111df370a70b1db418660135e7e00e0f2508e
Reviewed-on: https://chromium-review.googlesource.com/1183942
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584990}

AtkText is the proper way to expose static text to accessibility agents.
This change adds initial support for the interface, but there is quite a
bit of work left to properly expose hypertext as well as implement the
rest of the required interface functionality.

Bug: 866337
Change-Id: Iab121b1b18bc00bcbdd35bfa310e7a1a2b141e18
Reviewed-on: https://chromium-review.googlesource.com/1179752
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584989}

This makes sure close button is always visible when
Picture-in-Picture window is focused or hovered (even
when video ends).

Bug: 875736

Change-Id: I4c9a35d1e985eee4c7e869d2559032d303e51307
Reviewed-on: https://chromium-review.googlesource.com/1181133
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584988}

Fake implementation still reads configuration provided
via command line.

Bug: 854101
Change-Id: I88cb4466cbc5118218251e14b20c92f2806acf30
Reviewed-on: https://chromium-review.googlesource.com/1183497
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584987}

This test is flaky on Linux TSAN.

TBR: enne@chromium.org
Bug: 707711
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I88e4510fd3fc151de8f69b5b9632e6d5709ccd81
Reviewed-on: https://chromium-review.googlesource.com/1184845Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584986}

Document all steps, Also verify the subtree contains the child name we
expect: 'photos' since the tests use BASIC_*_ENTRY_SETS. Move the vars
EXPAND_ICON and EXPANDED_SUBTREE internal to the helper where they are
used.

Test: browser_tests --gtest_filter="CreateNewFolder/FilesApp*"
Bug: 876267
Change-Id: I43548e39dc0be408a503ebacc19765c3db424afe
Reviewed-on: https://chromium-review.googlesource.com/1183270
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584985}

This CL ensures that loads which never finish do not stall the pending
task queue. Tests are added to ensure the timer functions as expected.

BUG=876172

Change-Id: I65477d202a846de2687f9ccf48dd243f26a7d80a
Reviewed-on: https://chromium-review.googlesource.com/1184732
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584984}

TouchIdAuthenticator currently fails a DCHECK when GetAssertion or
MakeCredential get invoked multiple times. Using the Back button (and
then proceeding to Touch ID again) can trigger a second call to
DispatchRequest and therefore the DCHECK fail.

Clicking the back button on the Touch ID sheet would not dismiss the
native Touch ID dialog, which would then hover over the welcome screen
sheet. So simply disabling the button seems like the right thing to do.

Bug: 678128,847985
Change-Id: I90dbf5ab016a177811575a4db61ca12d15e43841
Reviewed-on: https://chromium-review.googlesource.com/1184236
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584983}

Use the xcode_extra_attributes attribute of create_bundle to set
IPHONEOS_DEPLOYMENT_TARGET, BUNDLE_LOADER and TEST_HOST variables
in the generated Xcode project.

With this change, the deployment target and the host are correctly
set when a project is generated with "gn gen --ide=xcode" and it
is no longer necessary to set the values in convert_gn_xcodeproj.py
script.

Bug: 619072
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iae74ce96a188c45553ba7f26357ea29bc081b395
Reviewed-on: https://chromium-review.googlesource.com/1183666Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584982}

The positioning of the LayoutGuide named kTabStripTabSwitcherGuide in
the TabStrip was wrong because the frame wasn't converted to the layout
guide owning view.
It leads to an incorrect positioning, as the width of the button and the
height of the status bar weren't taken into account.

Bug: 876642, 875760
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I537976c049508e3f0ac4a2e52ef654333a9ce1b3
Reviewed-on: https://chromium-review.googlesource.com/1184706Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584981}

* 'label' and 'error' attributes of gaia-input moved to slots.
* added 'invalid-state-cleared' event.
* set aria-label for input inside gaia-input container.

BUG=chromium:865474,chromium:853571
TEST=manual

Change-Id: Ia14de60ad90f3055a3f0e2b2bcfe84ca1502b114
Reviewed-on: https://chromium-review.googlesource.com/1183240Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584980}

This CL adds a protected getTitleTextId() method to SigninFragmentBase.
This method is overridden in ConsentBumpFragment to use a different
title text there.

Bug: 869426
Change-Id: I15547bfe3ea8f5de97045a9e66465dd63e58f294
Reviewed-on: https://chromium-review.googlesource.com/1183185Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584979}

This CL plumbs UnifiedCosentService::IsUnifiedConsentGiven and the
corresponding setter through UnifiedCosentServiceBridge and wires up
SyncAndServicesPreferences and sign-in/consent bump screens to these
methods.

Bug: 814728
Change-Id: I2a3452576a813b89dbe3143b7996c0d1d76a4147
Reviewed-on: https://chromium-review.googlesource.com/1183901Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584978}

Inheriting a set of custom properties without modifying that set should
be very cheap. At the time of writing, it is _not_ cheap: for every child
element, we keep iterating though the set of inherited variables to check
if they need to be resolved (i.e. have their var()-references replaced).

There is a separate :root version of the test, because we have a special
optimization for custom properties at :root (see StyleInheritedVariables),
and I wish to track both :root-optimized performance and non-:root-
optimized performance.

R=futhark@chromium.org

Bug: 875123
Change-Id: I25167713083b0fc0c70cad14a17f3992424526a6
Reviewed-on: https://chromium-review.googlesource.com/1181126Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584977}