GitLab

safe_browsing_service.cc.  Hopefully this will fix the "pure virtual method
called" errors seen in various ExtensionService tests that use safe browsing;
both those reverted as part of bug 233290, and the ones that are still live.

BUG=233290
R=jyasskin@chromium.org
TBR=shess@chromium.org

Review URL: https://codereview.chromium.org/60833007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233426 0039d316-1c4b-4281-b951-d872f2087c98

Ifdefs weren't quite right.

BUG=315195
TEST=run chrome (aura) in metro mode, touch the tabstrip and move tabs
     around, make sure tabs enter stacked mode.

R=ben@chromium.org

Review URL: https://codereview.chromium.org/60353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233425 0039d316-1c4b-4281-b951-d872f2087c98

Move mergesession from SigninManager to reconcilor.
Implement ListAccounts.
Start implementing reconcile action, but still a noop for now.

This CL depends on https://codereview.chromium.org/57103002/

Alan: here is an implementation of the ListAccounts.  I also added lots of
DVLOG() to the code.  Let me know if you'd rather I took those out and put
in a separate CL.

Hui: please review.  This CL adds more functionality to the reconcilor but
its still not complete.  However, it enables AC behind the flag for merge
session so you don't need to do that manually.

BUG=305249

Review URL: https://codereview.chromium.org/57363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233424 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314799
NOTRY=true

Review URL: https://codereview.chromium.org/55293006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233423 0039d316-1c4b-4281-b951-d872f2087c98

In order to avoid an ugly flash of white pixels when a new app window is
shown, this patch defers showing a window until a non-empty backing
store update has completed.

The feature is behind the "enable-apps-show-on-first-paint" flag.

BUG=225843, 254152

Review URL: https://codereview.chromium.org/55293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=308191

Review URL: https://codereview.chromium.org/27563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233421 0039d316-1c4b-4281-b951-d872f2087c98

BUG=307107

Review URL: https://codereview.chromium.org/54053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233420 0039d316-1c4b-4281-b951-d872f2087c98

Added EphemeralAppThrottle, which will launch ephemeral apps for
links to Chrome Web Store detail pages instead of opening the page in
the browser. This will only occur if the enable-ephemeral-apps switch
is enabled.

For experimental purposes only. The extension will currently be
installed in Chrome.

BUG=312460

Review URL: https://codereview.chromium.org/51943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233419 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313468, 313823

Review URL: https://codereview.chromium.org/49983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233418 0039d316-1c4b-4281-b951-d872f2087c98

R=nduca@chromium.org
BUG=264308

Review URL: https://codereview.chromium.org/29423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233417 0039d316-1c4b-4281-b951-d872f2087c98

> x11: Move XInput2 availability information out of the message pump.
> 
> BUG=302696
> R=darin@chromium.org, derat@chromium.org
> 
> Review URL: https://codereview.chromium.org/52823002

TBR=sadrul@chromium.org

Review URL: https://codereview.chromium.org/63443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233416 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302696
R=darin@chromium.org, derat@chromium.org

Review URL: https://codereview.chromium.org/52823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233414 0039d316-1c4b-4281-b951-d872f2087c98

BUG=293678
R=jyasskin@chromium.org

Review URL: https://codereview.chromium.org/61393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233413 0039d316-1c4b-4281-b951-d872f2087c98

We don't need to call BookmarkModelFactory::GetProfile(...) again as we already
have a data member |model_| for which we have already called
BookmarkModelFactory::GetProfile().

BUG=None
TEST=In Bookmarks Bar, right click a folder that is not the "Other bookmarks",
make sure that folder has only one children, for that folder the menu should
not close when deleting the child node. Now do the same for the "Other bookmarks"
folder, it should close if it has only one children. No regressions observed.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/60253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233412 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315046
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/59743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233411 0039d316-1c4b-4281-b951-d872f2087c98

- Move Params class to anonymous namespace
- Roll private class definitions into declarations
- Remove unnecessary namespace references

BUG=None
TEST=None
R=darin@chromium.org, darin

Review URL: https://codereview.chromium.org/61833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233410 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=291271

Review URL: https://codereview.chromium.org/59113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233409 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239107
TEST=everything still builds
R=jamesr@chromium.org
TBR=darin

Review URL: https://codereview.chromium.org/54583005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233408 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/62523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233407 0039d316-1c4b-4281-b951-d872f2087c98

This prevents an issue where the variations seed not changing
in a while will result in studies not actually expiring.

Also, removes an unused header include.

BUG=315177
TEST=New unit test.

Review URL: https://codereview.chromium.org/59953005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233406 0039d316-1c4b-4281-b951-d872f2087c98

It's a layering violation (and has crazy side effects when instantiating those
in the browser).

BUG=None

Review URL: https://codereview.chromium.org/57543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233405 0039d316-1c4b-4281-b951-d872f2087c98

It was originally in nacl_file_host_unittest.
Move it to components/ and consider it the "base" test
version. In nacl_file_host_unittest, provide slimmer version
that overrides just what we need for the unittest.

This means that we can reuse the TestNaClBrowserDelegate for
other tests. E.g., I'll be adding one for checking that
the "abi-version" matters for translation caching, and
to test that we need to do a similar trick of having a 
Get/SetPnaclDirectory pair, so as not to modify the PNaCl
files inline.

It also means that we don't need to modify the test file
every time something is added to the NaClBrowserDelegate.


BUG=none
NOTRY=true
(already tried)

Review URL: https://codereview.chromium.org/51323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233404 0039d316-1c4b-4281-b951-d872f2087c98

[Refactor] Move the non-browser specific logic of ImmersiveModeControllerAsh into ash part 2. The goal of the refactor is to allow CustomFrameViewAsh to use ash::ImmersiveFullscreenController so that v2 apps can be put into immersive fullscreen too.

BUG=307622
TEST=ImmersiveFullscreenControllerTest.*, ImmersiveModeControllerAshTest.*

Review URL: https://codereview.chromium.org/48963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233403 0039d316-1c4b-4281-b951-d872f2087c98

I believe this gives us the behavior we're after.

BUG=289535
TEST=see bug
R=dimich@chromium.org, mpcomplete@chromium.org, stevenjb@chromium.org

Review URL: https://codereview.chromium.org/58873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233402 0039d316-1c4b-4281-b951-d872f2087c98

1) Consolidate WinXP and Vista blacklist entries
2) Get rid of 2007-2009 driver range for supported Windows

This is mostly relanding jbaumann's CL:
https://codereview.chromium.org/58343007

Plus adding an exception for bots (using "osmesa")

BUG=315199,315205
TEST=bots
R=jbauman@chromium.org, kbr@chromium.org

Review URL: https://codereview.chromium.org/63143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233401 0039d316-1c4b-4281-b951-d872f2087c98

The original fix stopped working with the new style of dialogs, since they're not parented to the WebContents anymore but instead to its parent. It also turns out we don't need to watch out for transient windows, as they're now top level ones with their own HWND so clipping works through the OS and we don't need to do anything special.

BUG=299224
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233297

Review URL: https://codereview.chromium.org/53153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233398 0039d316-1c4b-4281-b951-d872f2087c98

Also added PS_EXIT_MESSAGE to ppapi_simple; this will prevent exit() from being called when the main() function returns. Instead, it will PostMessage to JavaScript.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/61213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233397 0039d316-1c4b-4281-b951-d872f2087c98

This cl cleans up the video receiver from handling the raw
frames, and will align the frame handling of the cast vp8
decoder and the chromium/ffmpeg h264 decoder (to be added).

Review URL: https://codereview.chromium.org/59753007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314959
TEST=unit_tests
R=groby@chromium.org

Review URL: https://codereview.chromium.org/58913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233395 0039d316-1c4b-4281-b951-d872f2087c98

Needed to create new class, mimicking SimpleAPIPermission, as opposed to inheriting from SetDisjunctionPermission, since we just needed to construct strings dynamically with extension properties.

BUG=306128

Review URL: https://codereview.chromium.org/55533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233394 0039d316-1c4b-4281-b951-d872f2087c98

TBR=antrim@chromium.org
BUG=279307,312751

Review URL: https://codereview.chromium.org/33173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233393 0039d316-1c4b-4281-b951-d872f2087c98

Part of moving ExtensionProcessManager to src/extensions

BUG=313481
TEST=compiles
R=yoz@chromium.org
TBR=finnur@chromium.org for chrome/browser/ui/webui/extensions

Review URL: https://codereview.chromium.org/61823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233391 0039d316-1c4b-4281-b951-d872f2087c98

r232311 was reverted due to a crash bug at shutdown. This is simply a
reland because the crash bug has been fixed by r233015. See also
crbug.com/314567

BUG=312365, 314567
TBR=xiyuan@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/59283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233390 0039d316-1c4b-4281-b951-d872f2087c98

The M32 has branched. This patch enables suggest-an-apps dialog by reverting r232715.

BUG=313877
TEST=none
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/59223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233389 0039d316-1c4b-4281-b951-d872f2087c98

PushIfNeeded was pushing unconditionally when either the source or destination directory included a symbolic link it its path. This CL fixes that.

NOTRY=True
BUG=314578

Review URL: https://codereview.chromium.org/57633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233387 0039d316-1c4b-4281-b951-d872f2087c98

In the current implementation, DomDistillerDatabase cannot be
deleted on the main thread, instead the user must call ::Destroy(),
and then let the database delete itself on its task runner. This is
awkward and sort of leaks implementation details out of that class.

Second, currently the parts of DomDistillerDatabase on each thread
are doing some ad hoc method of checking their thread restrictions.
Using ThreadChecker is better, though it loses some flexibility
from checking TaskRunner::RunsTasksOnCurrentThread (maybe there
should be something like a TaskRunnerChecker for that).

Now:
1. no functions are called on DomDistillerDatabase off of the main
thread
2. DomDistillerDatabase::LevelDB enforces that function calls and
destructor all run on the same thread
3. DomDistillerDatabase can be deleted on the main thread

Review URL: https://codereview.chromium.org/56193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233386 0039d316-1c4b-4281-b951-d872f2087c98

Align the interface of TestHarness defined in gpu_tests/webgl_conformance.py with that in third_party/webgl_conformance.

This is a re-submit of https://codereview.chromium.org/58833003, which was
reverted due to bot failures.

BUG=314997
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/63243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233384 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/56123010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233383 0039d316-1c4b-4281-b951-d872f2087c98

This CL also fixes gfk::NativeRegion leaks in DesktopRootWindowHost for Windows & X11.

BUG=310932

Review URL: https://codereview.chromium.org/54983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233382 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
Test=None, Cleanup.

Review URL: https://codereview.chromium.org/54303009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233381 0039d316-1c4b-4281-b951-d872f2087c98