- 20 Oct, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This change prolongs a few password manager histograms that are expiring in M88 and are still useful. jdoerrie@ replaces battre@ as an OWNER where approriate. R=chromium-metrics-reviews@google.com Fixed: 1138301, 1138303, 1138307 Change-Id: Id4ef858e6ac546640575d889307c66613abde8bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485051 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#818811}
-
Rakib M. Hasan authored
This CL adds a builder for x86 binaries and a tester that will run skew tests on an Android 10 emulator. Bug: 1114563 Change-Id: Iad27586eab96287c3a7f7657067f14a1bc352558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476730Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#818810}
-
Alex Rudenko authored
common.css will be contained in the main resource after the following frontend CL gets merged: crrev.com/c/2484719 so direct references can be removed in the backend code. Bug: 1139862 Change-Id: I756c8ba56368f27016453220610c98623a19f1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484429 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#818809}
-
Jarryd authored
This patch adds an interface at DevTools>Application to allow users to override the quota size for the current origin. At the backend, the QuotaManager maintains a map from origins to emulated quota size. Bug: 945786 Doc: https://docs.google.com/document/d/1gSZRjwgz4T0Dl8GSrN8BTFKVvw8-dCehIQOJsBVsOgc Change-Id: Ic1928e9058f514fe60e509a6b1f5a887ec14231a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122473 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
Joel Hockey authored
Do not show the move-to-windows-files dialog for files which are already in that folder. When the VM has not yet started, this folder is not yet shared so we must check for it. Bug: 1140331 Change-Id: I4cd735f192845ebe118a6e1e2b6e85e2c76b49d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486902 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#818807}
-
calamity authored
This reverts commit be611a0e. Reason for revert: Suspected of causing Linux ChromiumOS MSan failures Example failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20989 Original change's description: > Enable Suggested Content by default. > > The Suggested Content toggle has been approved in > https://bugs.chromium.org/p/chromium/issues/detail?id=990279#c148. This > CL enables the feature by default, and updates tests that need to take > this into account. > > Bug: 990279 > Change-Id: Icc2c8bdf72cff8734aa5941f3fbc2774b38e4c98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462752 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Commit-Queue: Rachel Wong <wrong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818758} TBR=xiyuan@chromium.org,jiameng@chromium.org,wrong@chromium.org Change-Id: I242dae70abcb45a723c10302ead38929fe530e89 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 990279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486530Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#818806}
-
Luciano Pacheco authored
Bug: 1133198 Change-Id: Idd34346986ab6157713792b218400a096cc5f435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474314 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#818805}
-
Rune Lillesveen authored
We did not schedule a visual update for dirty slot assignments. If adding a host child is the only thing that happened for a frame, we would not run the lifecycle update. Bug: 1137711 Change-Id: Icd3fe88999129e56c7c6eaa5174f4a89ac4df6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485099Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#818804}
-
Victor Vianna authored
Change-Id: I03bee41d435955db48f4d2251af2b960bf5f3d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484718Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a670782ed315..ac1ded033136 2020-10-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b1938273e405 to c4593127cbdd (14 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: I4cacab26499ad66a1dcf66d309b1603cd09efc33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486408Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818802}
-
Luciano Pacheco authored
This is a preparation to migrate to JS modules. Bug: 1133186 Change-Id: I7d40a8b8ad4a066737a5e8601532b7b914caad43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470284Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#818801}
-
Noel Gordon authored
Add NavigateToTestFile helper: used to navigate chrome/test/data files in-test with usage NavigateToTestFile("test.html"). CanCollectCodeCoverage uses content::ExecJs() to inject/run test JS on the test page. This causes the script to be eval()-ed by ExecJS helper JS code, which adds it to the JS coverage results. Ideally, that would not be case. Denote the test script by kEvalScript as a reminder that it's included in JS coverage results. Some upcoming tests will give examples of controlling a page in-test, that leaves no trace in the coverage results. Tbr: benreich Bug: 1113941 Change-Id: I8df81ded20bc2d67b12f8ee83d9674b48db47065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484040 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: -
Jan Krcal authored
This CL addresses opening external links in the sign-in flow for profile creation. Because there is no browser window in this step, all such links are open in a new browser popup window. Bug: 1126913 Change-Id: Ib7c137bbda1e1ad7cc0e1291b0a5e8a3468aa806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485056 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#818799}
-
Tony Price authored
Add a timeout when starting video capture for a local device, to gracefully handle the case where a device never starts. Deadline initially picked at 10s, and able to be disabled by a Feature flag in the unlikely case that this has negative effects. Tested locally by inserting an artificial delay in the VideoCaptureHost handling. Bug: 1121470 Change-Id: I1e46b1d00ae860386a34f5704554bf7cfa8972db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475914 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#818798}
-
Dmitry Torokhov authored
Dispatcher API has been changed to pass native Parallels error codes to allow better handling of errors, let's start using them. Bug: b/168829032 Change-Id: Ic422ddf4848059e0e85121268696ea98796b3f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486701Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#818797}
-
Jan Krcal authored
This CL adds error handling for the sync consent in signed-in profile creation flow. All the special cases are handled by closing the creation flow, opening a browser window for the new profile and showing standard error dialogs in the actual browser window. The only case left for a later CL is when sync is disabled by the admin. Namely, this case needs more refactoring which will be easier to understand in a standalone CL. Bug: 1126913 Change-Id: I604d03ea101219f69bb6b2a20b311de4fb75366d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435349 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Kent Tamura authored
The feature still has one unit test failure and three web test failures. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Bug: 1040826, 1137666, 1138820, 1140302, 1140307 Change-Id: I1c149d21af31a89dbed5a97e5c274c338a1bb932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454579 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818795}
-
Thomas Lukaszewicz authored
This CL removes the bespoke implementation of a WebUI bubble from Tab Search and switches to using the WebBubbleDialogView. Bug: 1099917 Change-Id: I5550761c2a98a2f6af5689fa699346eb3911e776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462344 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#818794}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6bc78433f44f..8f4c6aa05d54 2020-10-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie13a49d9b7df0a6e5fe3965ac3212ad51061769a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486812Reviewed-by:
-
Ryan Heise authored
Change-Id: I56eec3ca11785a6d796d28ca07220f4aa6ff1212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486542 Auto-Submit: Ryan Heise <heiserya@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#818792}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/afab06b2..38f7cc8c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8e1f1665f4701b088d2726d46f41d9183d14125f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486880Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818791}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f7dcbb7b3498..6e3107eb1fb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC calamity@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085115,chromium:1134209 Tbr: calamity@google.com Change-Id: I1f3442f62a59976f1c5c994ce463c758d5e60288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486659Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818790}
-
Chong Gu authored
Create integration_tests.test-cmx, apply to Fuchsia's runner integration tests. Use run-test-component to run runner integration tests on builders. Bug: 1132147 Change-Id: I8b0c11dc1c6813bb7395f7259954049b6025f67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476896Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#818789}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e15fb15035fe..d273ed0320fc 2020-10-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 581ea988..5939e063 (818521:818652) 2020-10-19 terelius@webrtc.org Add test for logging of large compound RTCP packets. 2020-10-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision cb51eef7..581ea988 (818409:818521) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134107 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia46606fe87a919edbe31a24190a8f566fa4f69df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486803Reviewed-by:
-
Regan Hsu authored
This reverts commit 4e4fb60d. Reason: The pointer-events need to be set to none so that clicking on a menu item will not cause the settings window to refresh. Bug: 1139875 Change-Id: Idffd2e8e74277e970f7bf0531303bcb410060099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486453Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#818787}
-
Yuichiro Hanada authored
Some UI elements assume that InputMethodManager's allowed input method list is used for the policy enforcement exclusively. Using that mechanism to restrict ARC IMEs in clamshell mode breaks them. This CL stops using it for ARC IMEs and uninstalls the fake input method entry from InputMethodManager instead of disallowing it if no ARC IME is allowed. Bug: 1139332 Test: unit_tests Change-Id: I9952b1f99a8215d5f3a0ee0165d143e4ac62557f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485651Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#818786}
-
Jinsuk Kim authored
This CL handles web contents that is not viewable in the preview tab such as those supposed to be downloaded instead. Shows a toast message about the occasion and closes the tab. Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/b77f7e044e4dec1b76791882126fc33e673e7f17 Bug: 981258 Change-Id: I144f953b14638901cf3846273a2c70e393066500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483546Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#818785}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/61ab38196942..babce049d02e 2020-10-20 jdarpinian@chromium.org iOS: Disable worker contexts, and use sized formats 2020-10-19 jdarpinian@chromium.org Build fixes for MacCatalyst 2020-10-19 jdarpinian@chromium.org No need to check for Catalyst in the iOS build 2020-10-19 jonross@chromium.org Disable TransformFeedbackTest.SwitchProgramBeforeDraw/ES3_OpenGL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1140113 Tbr: jonahr@google.com Test: Test: TransformFeedbackTest.SwitchProgramBeforeDraw/ES3_OpenGL Change-Id: Ide4594746104480e4bb6a863e21677ea4297751d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486640Reviewed-by:
-
Noel Gordon authored
Add a file with a runTests() method that signals the end of testing by the window.domAutomationController present in chrome test environments (browser tests, content browser tests). Also signal the end of testing with a document.title change to "DONE", chrome.test.send("DONE") for extensions, and console.log("DONE"). Tbr: benreich Bug: 1113941 Change-Id: I269322e6d646b511644b1048be8d97fe4ca48e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483949Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d384f3643dbe..1078618d07a0 2020-10-19 dberris@chromium.org pinpoint: Use correct attribute in serialisation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: If93d1060f373d9542b0aa1af868228da47b57418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486451Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603130327-dbd07cac207addae1d1c691d346f030844c1739d.profdata to chrome-linux-master-1603151856-6eb5756dcc723ec6d37bc459a0cd70533fdc40e5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9239bb3200b35942d3cff700af2433edf1bac53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486657Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e3a54217. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/cookies NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ib10d71ee9c09633879a75d3328b509d679800a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485761Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818780}
-
Evan Stade authored
Instead of using a command line flag, the feature is toggled by an AndroidManifest entry. This is more ergonomic for developers as they don't need to use a debug build of Android to toggle the feature. Bug: 1057100 Change-Id: Icdc6676d1b15e43a46ebb6d14276cef89ff4942f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480705 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#818779}
-
calamity authored
This reverts commit ed0b0d99. Reason for revert: Consistently failing on linux-chromeos-chrome First failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9267 Original change's description: > Emit a UKM event on client connection to a ServiceWorker > > Whenever an execution context (whether a window or worker) becomes a > client of a service worker, the renderer will now inform the respective > ServiceWorkerContainerHost of the client's ukm::SourceId once it is > execution ready. This id will be passed to SWIdentifiabilityMetrics, a > new SWContextCoreObserver. This observer will them emit a UKM event > (Worker.ClientConnected) in order to associate the ServiceWorker's > ukm::SourceId with the client's. DedicatedWorkers' ukm::SourceIds are > not included as they exactly match that of their parent execution > context. > > This association is required both for attributing entropy consumption of > workers to sites, but will also help to gain insight into the cross- > connectivity between first-party contexts via shared and service > workers. Design doc (internal-only): > https://docs.google.com/document/d/1mx4-zI53cskB8j75Mis2q3rVrO8uHeJpwGuT8psbURA/edit?usp=sharing > > Bug: 1085645, 1134193 > Change-Id: I7d1728ebe15d162b980dd2e552622e4c4f91edc3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321059 > Commit-Queue: Alex Turner <alexmt@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818555} TBR=falken@chromium.org,rkaplow@chromium.org,nhiroki@chromium.org,shimazu@chromium.org,asanka@chromium.org,alexmt@chromium.org Change-Id: I2ebcaa9e70fd3347b71fac297436569166e2af79 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085645 Bug: 1134193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486901Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7411aeba4d3b..e6f794f1dc5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9dd6e5039558bf716432d58647a45d2bb9a45719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486289Reviewed-by:
-
Aaron Leventhal authored
Make [de]serialization errors fatal for any kind of build used to debug Chromium errors. This also restores the fail fast behavior in ADDRESS_SANITIZER, which was removed in CL:2468238, because it was mistakenly believed the address sanitizer builds had DCHECks on. TBR=dmazzoni@chromium.org,sadrul@chromium.org AX-RelNotes: n/a Bug: None Change-Id: I3a3651bf8732071cfb25f25eb4fc88ffa6a13855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486119Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#818776}
-
Sylvain Defresne authored
In preparation of adding support for target_environment="catalyst" replace all uses of `use_ios_simulator` with the corresponding check of the value of `target_environment`. Bug: none Change-Id: I23b0e9c05c6a427de0e5cb82d7937905b64028c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476278 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#818775}
-
Gyuyoung Kim authored
This is a reland of 6ddff235 This CL fixes the build error caused by exceeding the max token limit using the function overloading in text_link_colors.h. This CL makes the file include forward.h files instead of shared.h using below change. FooColor(ColorScheme color_scheme = ColorScheme::kLight) const; => FooColor() const; FooColor(ColorScheme color_scheme) const; Original change's description: > Use blink::mojom::ColorScheme instead of blink::ColorScheme > > This CL replaces the existing uses of native ColorScheme > with ColorScheme Mojo enum type defined in frame_owner_properties.mojom > in order to remove unnecessary type conversion. > > Bug: 919392 > Change-Id: Iebc2cf4a2094293027a07c643e75e57d75651e91 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473739 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#817773} Bug: 919392 Change-Id: Iaac4bec9df6ee4e68b682658c996618571eb3523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476695Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#818774}
-
Aaron Colwell authored
This function primarily relied on internal details of SiteInfo and didn't really depend on anything in RenderProcessHostImpl so it seemed reasonable to move this to SiteInfo. Also created a helper method with the same name on SiteInstanceImpl to reduce some code duplication. There are no behavior changes in this CL. Bug: 1085275 Change-Id: Idfed5bbbffbe2eeb7621b6e285c1a28f08d1a76c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482426Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#818773}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5b99b448b3db..3ead01191215 2020-10-19 johnkslang@users.noreply.github.com Merge pull request #2422 from ben-clayton/gn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I5428b6ad7b23d863c7196a94eccbaaa3969ee010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486055Reviewed-by:
-
