- 14 Oct, 2019 40 commits
-
-
Chris Davis authored
This change sets is_multi_dll_chrome to false by default thus merging chrome.dll and chrome_child.dll to a single dll. This saves disk space and improves startup performance. It is also consistent with all other platforms (windows was the only platform the split was enabled by default). Bug: 726150 Change-Id: Iade2c7f1bbe696d45ebac7483072f7e2e7e84ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850272Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#705667}
-
Ian Kilpatrick authored
... instead of VisualSelfOverflowRect. Children wouldn't have painted if enabled with FragmentItems, or BoxPainting enabled. Originally added in: https://chromium-review.googlesource.com/c/chromium/src/+/1628634 Bug: 988015 Change-Id: I4925f51b66f67f74504d2a4e1fb25b157aa060ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859681Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#705666}
-
Matthew Mourgos authored
Bug: 1012917 Change-Id: Ifd02e7d6b0331e54cf2839b26b9e8bec521d3c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857094Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705665}
-
Manas Verma authored
Changing "on-click" to "on-change" for the settings-page-button for enabling/disabling FIDO authentication for card unmasking. This makes the toggle a lot more responsive. Bug: 949269 Change-Id: Id8b986c0d74ca9459a40e3a1ba1e287b78bfdee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857547Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#705664}
-
Christoph Schwering authored
CL 1388111 / Commit b2020be3 removed timestamps from OnFormSubmitted(), the reason being that they were always Now(). They weren't always Now() in the unit test. This commit re-adds the non-Now() timestamps to the unit test. Bug: 1009364 Change-Id: I1204ee2e6d43685c0ac7a2e77c93236cceadf42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860340 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Christoph Schwering <schwering@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#705663}
-
Dan Beam authored
R=mahmadi@chromium.org Fixed: 1013833 Change-Id: I3eac331445d5e76917506f52886a461db484fef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857377Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#705662}
-
Alex Chau authored
- Derive ECPrivateKey from secret deterministically using EC_KEY_derive_from_secret - Will be used for VapidKeyManager to generate a ECPrivateKey from 256-bit secret from Chrome Sync, as illustrated in https://crrev.com/c/1848171 Bug: 1010968 Change-Id: Id2445ff802e9598ad3b454dc42972a6812713885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844961 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#705661}
-
Nico Weber authored
...now that this is easy to do after #705630. Bug: 961769 Change-Id: Icfecf48eda96f94f548c1e1d2e772caf9bcfe9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860522 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#705660}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9bc8545214f9..bb3e02a14bb9 git log 9bc8545214f9..bb3e02a14bb9 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 vapier@chromium.org toolchain_util_unittest: do not use __builtin__ Created with: gclient setdep -r src/third_party/chromite@bb3e02a14bb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4dddd9dcf9560df6525544e5f9cc84e0d5dd9028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859818Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705659}
-
Jacques Newman authored
Previously the ui::AXPosition methods, GetText and CreatePositionAtTextBoundary did not correctly ignore ignored nodes. This change ensures that ignored nodes do not contribute to the text specified in "GetText". This change also ensures ignored nodes are not incorrectly identified as text boundaries for all but paragraph and format. Paragraph and format boundary behavior in regards to ignored nodes will be fixed in a follow-up change. To ensure that Movement and ExpandToEnclosingUnit have the same behavior for word and character navigation, ExpandToEnclosingUnit is called after word and character movement where the endpoints are not on the same anchor. Change-Id: Ieacf955435205e194bdd1f937678b84f8728bff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810244 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#705658}
-
Nate Fischer authored
This persists the install date pref, so this will now log the install date of the WebView-embedding application. For existing clients, this will log the first startup in a milestone of WebView which persists this pref. This also includes logic to look up the install date if it's not already logged, otherwise the install_date field would just log the date users updated to a version of WebView which supports this field. This logic is meant to be temporary. I've added a histogram to track when we can safely remove this workaround, and added a tests to verify the logic and that the histogram is logged. Bug: 1012025 Test: startup webview shell multiple times, log install_date inside Test: AwMetricsLogUploader::UploadLog, verify it stays consistent Test: run_android_webview_unittests --gtest_filter=AwMetricsServiceClientTest.* Change-Id: I2d9238120b6bab2e08c116bf8f57e541b905534d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846812Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#705657}
-
Kevin Marshall authored
Chromium's log output to the Fuchsia logging service has a lot of header boilerplate because each log line has concatenated prefixes from both Chromium and Fuchsia. This makes syslog data hard to read because each line is very likely to wrap around on an 80-100col terminal. This CL strips the Chromium logging prefix from the logging data and provides log lines' source location as log "tags". Sample log line prefix, before this CL (146 chars): [00582.348425][130450][130452][ui_base_unittests__exec] ERROR: \ [130450:3944750047:1007/220315.685215:582348409:ERROR:base_paths_fuchsia.cc(21)] ... Sample log line prefix, after this CL (89 chars): [00517.527091][108865][108867][ui_base_unittests__exec] ERROR: base_paths_fuchsia.cc(21) ... Bug: 1012037 Change-Id: Ia51442711ca8575246170b5090a4abafc45fcc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846395 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#705656}
-
Alexander Timin authored
Ensure that RenderFrameHostTester::SimulateLoadingCompleted fires DocumentAvailable / DOMContentLoaded / OnLoadCompleted / DidStopLoading callbacks in addition to DidStopLoading to simulate real-world loading callback sequence more accurately. This patch also adds a browser test to ensure that the loading callback order is the same in the real world. This patch is a prerequisite for exposing the loading stages from RenderFrameHost / WebContents as the tests need these callbacks to be dispatched to work correctly. R=clamy@chromium.org,arthursonzogni@chromium.org,ahemery@chromium.org TBR=jianli@chromium.org,pasko@chromium.org,dbeam@chromium.org,mastiz@chromium.org,drubery@chromium.org CC=bfcache-bugs@chromium.org BUG=1011770 Change-Id: Ibe59b1b131f3911fe9c4bf641e8ea1c6bb1ba545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834343 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#705655}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ifdf602ca013d604dc4fccd270798f70c85d63e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860316Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#705654}
-
Elly Fong-Jones authored
This change removes overrides from: * ChooserDialogView & ChooserBubbleUiViewDelegate, which ask a controller for button text but the text never changes after construction of the controller * DeviceChooserContentView, which is not actually an override, but was used to shim between the two classes listed above and their controller * CloudServicesDialogView, which used static strings * MediaRemotingDialogView, which used static strings * RelaunchRecommendedButtonView, which used a static string * RelaunchRequiredDialogView, which used static strings * SettingsResetPromptDialog & its controller, which returned a static string * SimpleMessageBoxViews, which used a string passed in at construction time Bug: 1011446 Change-Id: I325ba416cf4ad185e1036b02b3e94316f241b41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860687Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705653}
-
Elly Fong-Jones authored
Not doing this causes the object's internal mutex to be uninitialized which causes unit test failures on macOS 10.15. Which initializer to use was determined through experimentation from the list of available initializers. Bug: 1014095 Change-Id: I6a193b89f1d8d7b0ea68f36cde2bc6975c61c733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860100 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Daniel Hosseinian authored
Follow up a previous CL that stores scaling settings as enums. To keep the backend consistent with the frontend, pass that enum value to the backend. Bug: 989978 Change-Id: I29712bcb715e98b434e747c86dd8f2042f8b2949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848938 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#705651}
-
Rakib M. Hasan authored
This dictionary can then be used to derive the web tests specific failure types for the results viewer. After we update the results viewer to get the specific failure type from the artifacts, then we can remove the web tests specific results from the test expectations and JSON results. Bug: chromium:1014196 Change-Id: Ic78c97f8dbfdf1669d38fd6ba5b0ab11489b5c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842753 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#705650}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fede5cb664d9..da1f90aa77b4 git log fede5cb664d9..da1f90aa77b4 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 bsheedy@chromium.org Add .yapfignore file Created with: gclient setdep -r src/third_party/angle@da1f90aa77b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: None Change-Id: Ibd24330c151b1ef5866c8756946952af31eeea27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860325Reviewed-by:
-
Xianzhu Wang authored
TBR=tkent@chromium.org Bug: 1013779 Change-Id: Iebff0c2e49c0ea74444a51a345449f46567ee145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860148Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705648}
-
Dan Beam authored
Noticeably, this breaks removing suggestions. Probably also other things. R=mahmadi@chromium.org Fixed: 1012994 Change-Id: Ie1f71c01be4dbc2f1b73074bff058d2aaf00130e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857607 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
We already had code that copied to the block-offset from the spanner placeholder to the actual spanner layout object, but we also need to make sure that it actually gets laid out. See test: In the initial layout pass we'd set the block-size of the first column row (with the empty DIV) to the block-size of the multicol container. Then we'd bump into the spanner, and realize that this block-size wouldn't do, since we need to balance columns in front of a spanner. Because of this initial block-size of the column row, the initial layout pass of the spanner would put the spanner below that, tricking the machinery into believing that we need a break inside the spanner. In the next layout pass the block-size of the column row would be corrected, and also the position of the spanner. But we wouldn't re-lay out, and thus incorrectly keeping a pagination strut in the middle of the spanner. Bug: 1006249 Change-Id: If7ec10389ba5f6e78d9ecb5fd4ad7fd113c128bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859977 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#705646}
-
Kevin Bailey authored
Remove unused reverse-tab-switch-logic flag, but extend life of normal tab-switch feature flag. Also remove an unused declaration. Change-Id: Ia2367b7078fb4fdb524d0dfc4ca95087a04b745e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859675Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f98ffad2..e20a46d9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id53f90e16c8a9d6955e6f8bca510d9a56193ab52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860574Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705644}
-
John Lee authored
Bug: 1011064 Change-Id: If407517819759f380cd8fc2a2b74338f96902f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854821Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#705643}
-
Elly Fong-Jones authored
This change removes the concept of "extra view padding" from DialogDelegate. This concept predates the Harmony width-snapping dialog design, and is used only in one place (BookmarkBubbleView), where it has no effect because of width snapping. As such, it can be removed. Bug: 1011446 Change-Id: I6e107013635cd1973cdc550b561e61a8ea29e5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856299 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#705642}
-
Egor Pasko authored
The code has stabilized, the failure rates are low. Stop tracking this. Bug: 988785 Change-Id: If3e33e46177973bf4cbad05a2e239b12565d5ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845971Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
Tarun Bansal authored
Curretly, client configs are not fetched if data saver holdback is enabled AND lite page redirect preview is not enabled. This CL changes the logic to allow client configs to be fetched for all data saver users. This is expected to ensure that the client config is available to lite page redirect users when they switch from control finch arm to enabled arm. Change-Id: I95184e9d377386434a605afe37cdfb96a6c385f5 Bug: 1012299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857713Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#705640}
-
Xianzhu Wang authored
TBR=wangxianzhu@chromium.org Change-Id: Icedf0b2b72b24d8b45b39b027ab37f60c6ac4a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860689Reviewed-by:
-
Asanka Herath authored
Bug: None Change-Id: I37729941b4e3ca3837d259c6064d236635dd8b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857399Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Auto-Submit: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#705638}
-
chrome://sync-confirmationdpapad authored
- Only updating the DICE enabled codepath (sync_confirmation.html), and related tests. - Forking signin_shared_css.html so that the old (Polymer2) version of it can still be used by the pages that are not migrated yet. - Drive-by: Added type-checking target for sync_disabled_confirmation.js which was missing. Bug: 965770 Test: Page still works, no more HTML imports warnings in DevTools. Change-Id: I714e4d539316f21d7f45c8516c0c4175c267c149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848348Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#705637}
-
Bettina authored
Create a new metric that will log when information of a URL that matches the allowlist on a password reuse or on a password field focus event is sent to Safe Browsing. Bug: 953106 Change-Id: I1bfe040db792f3f8e13b1905b4bd570ad11e3516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817177Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#705636}
-
Thomas Lukaszewicz authored
Ensured that functionality that runs tests + launcher in a single process is consistently referred to with the switch --single-process-tests rather than previous content:: specific --single_process in both code and documentation. Performed basic cleanup to ensure that unused declarations were removed and made sure switches in content:: are more consistently declared in the appropriate headers. Bug: 460513 Change-Id: Ic901d7af972ad43c9e0e2d31e34cc778d388d34a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848365Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#705635}
-
Kevin Marshall authored
* Adds support for isolated CastRunner instances, which run without networking capabilities and only have access to resources served by local ContentDirectoryProviders. * Defers web.Context creation to WebComponent creation time, so that CastRunner can defer shared Context creation until it's actually needed. Bug: 1004505 Change-Id: I4af9ca7c04b9c86e93c30b2d0aaa7f39ee3f8d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808159 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
Adam Kallai authored
Windows ARM64 build bot is broken on copying runtime dlls. A recent change switches the MSVC version to VS 2019 as preferred ( https://chromium-review.googlesource.com/c/chromium/src/+/1836195 ). This affects the search of runtime dlls, since currently VC141 toolset is selected. As a workaround select the proper toolset directory based on VS version. Bug: 1013508 Change-Id: Iaebee100be727f60d7bd651202af725abf4726d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855966Reviewed-by:
-
Raphael Kubo da Costa authored
This is another big update to the implementation, which now follows the API proposed in https://github.com/w3c/wake-lock/issues/226. From a Blink/Chromium internals perspective, things have not changed much, and we still perform the same permission checks and connect to the wake lock service via WakeLockStateRecord. The biggest change is that WakeLockController was merged into WakeLock itself. From an end-user perspective, though, the API now looks like a mix of the old, navigator-based API and the one we implemented a few months ago: * The main idea is that WakeLock.request() no longer returns a promise that does not resolve while the lock is held, as that is not very intuitive. Instead, it returns a new WakeLockSentinel object. * WakeLockSentinel is a new interface that can release() a lock and receive "release" events. * We do go back to a Navigator-based API, but we also support WorkerNavigator. * There is no WakeLockRequest interface or state tracking in the WakeLock interface. * WakeLock.requestPermission() was removed. * Consequently, we now have a WakeLockEvent interface. The changes to the spec still need to land, but there is some rough consensus on what the API should look like, and we do not want to miss the M79 branch cut. Bug: 257511, 1010162 Change-Id: If1baed914ccd9eb7103a1bb71a40529976777ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849683Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#705632}
-
Lei Zhang authored
SitePerProcessAutoplayBrowserTest.PropagateUserGestureFlag is flaky. TBR=mlamouri@chromium.org Bug: 1014175 Change-Id: I0de4853597b0c6b1060218838c3278a43a67efc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860678Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705631}
-
Nico Weber authored
Microsoft rc.exe has its built-in preprocessor that has a limit of 32 characters for macro names. We already use clang-cl's preprocessor for our own rc that we use in cross builds. That works well, so feed the output from that into Microsoft rc.exe too. This allows removing some workarounds for BUILDFLAG() use in .rc files and shouldn't change behavior. Bug: 961769 Change-Id: I21ea2e62323a27c61f8c79c267814ed2f522eded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860097 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Klaus Weidner authored
Currently, WebXR's immersive-ar mode requires Android O due to using SharedBuffer image transport which needs AHardwareBuffer support. On Android N, use a Surface/SurfaceTexture pair instead. This is based on the existing XR frame transport method SUBMIT_AS_MAILBOX_HOLDER that's also used by the GVR immersive-vr backend. Bug: 1012972 Change-Id: I87759daf7d317873dea0fb569fffaee379783ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854802Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#705629}
-
Jan Krcal authored
This CL makes sure ToolbarIconContainerView destroys its children before its own observer list (this is needed so that childred that observe ToolbarIconContainerView can remove themselves from the observer list). Bug: 1013418 Change-Id: Ica6b8c89b9d0683933c84d65faf6f9a4641e55b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860339Reviewed-by:
-
