- 02 Aug, 2017 12 commits
-
-
Adrienne Walker authored
Also, consolidate all PaintOp validation into new IsValid functions. Bug: 749023, 750010 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1f5b695fe71c50d5ae126937c15a8957285a5487 Reviewed-on: https://chromium-review.googlesource.com/590749Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#491171}
-
nick authored
The problem with DoReplaceSubstringsAfterOffset was that the following search would not terminate: ReplaceSubstringsAfterOffset(std::string("aaabaa"), 0, "aa", "ccc"); The root cause of this is an algorithmic bug, where it was assumed that string::rfind and string::find would return the same matches in reversed order. The fix is to only scan forward using find(). For the length-expansion case, if capacity is insufficient, we swap with a temporary and build the result into new memory. If existing capacity suffices, we'll shift the tail of the string down to the new size, and then use left-to-right memmove loop of the length- contraction case, with the shifted tail as the src. BUG=749228 Review-Url: https://codereview.chromium.org/2979393002 Cr-Commit-Position: refs/heads/master@{#491170}
-
Dmitry Gozman authored
BUG=402805,596968,734762 Change-Id: I05a0b54423a5e6acdd5052e734cfd01e3ed49822 Reviewed-on: https://chromium-review.googlesource.com/597013 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#491169}
-
Steven Holte authored
Change-Id: I4a0a05dec6b7b768250889199775d6bc8b951ef4 Reviewed-on: https://chromium-review.googlesource.com/580522 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#491168}
-
Christopher Lam authored
Bug: 748445 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5d10fdd84b302a3064056f73544d8c214aace2bd Reviewed-on: https://chromium-review.googlesource.com/584558Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#491167}
-
Nicolas Pena authored
This CL drops clamping for long tasks to improve accuracy. Discussion at https://github.com/w3c/longtasks/issues/29 Bug: chromium:681718 Change-Id: If6df344f0203f7b6347f54ffa49be8d6689b7d71 Reviewed-on: https://chromium-review.googlesource.com/587590Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#491166}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/249ee1f985b4..5a9a981edf54 $ git log 249ee1f98..5a9a981ed --date=short --no-merges --format='%ad %ae %s' 2017-08-01 fmalita Tiling support for SkSweepGradient 2017-08-01 bsalomon Make ProcessorCloneTest more robust, fix matrix conv. onIsEqual 2017-08-01 robertphillips Fix cleanup on program creation failure 2017-08-01 ethannicholas Revert "support for 'half' types in sksl, plus general numeric type improvements" 2017-08-01 ethannicholas fixed missing INT_MAX definition Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I43efa8eeb5e612e3ce9bcbae3d90bbcdb58efa2a Reviewed-on: https://chromium-review.googlesource.com/597011Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491165}
-
Bin Zhao authored
We are turning on 50% on beta. Got a finch warning that we must add a field trial config for it. Bug: 718154 Change-Id: I480d390acf1f9f903a00345169d270d6ca01b428 Reviewed-on: https://chromium-review.googlesource.com/596627Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491164}
-
Jinho Bang authored
The CanMakePaymentEvent is used to check whether the payment handler is able to respond to a payment request. Related spec change: https://github.com/w3c/payment-handler/pull/170 Bug: 736745 Test: payment_app_provider_impl_unittest.cc, payment_app_browsertest.cc Change-Id: Ib4073d26fd8e24e1bcbf1b113c3fd3fd3451c609 Reviewed-on: https://chromium-review.googlesource.com/574992 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#491163}
-
Chris Harrelson authored
1. Remove an unused method from PaintLayerClipper. 2. Don't conditionally set cache slots which are ignored anyway for PaintLayerClipper use-cases that use GeometryMapper. 3. Remove unnecessary pagination_clip parameter in PaintLayerFragment. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6cd7b8646ac68873a245c76813ec3723d48858c9 Reviewed-on: https://chromium-review.googlesource.com/595109 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491162}
-
Emily Stark authored
While adding Expect-CT support for chrome://net-internals, I noticed that a crash can occur if the report URL results in a net error. This appears to be due to accessing the response code before checking the request status is success. Unfortunately, I can't reproduce the crash in a browser or unit test, perhaps because it's a race. Bug: 751197 Change-Id: I60c2b4debe19da9ef98f838ce2013747644a39d8 Reviewed-on: https://chromium-review.googlesource.com/596514Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#491161}
-
Evan Stade authored
Bug: none Change-Id: Ib8fdd720512dd134abd1d46b7c6276f3c0f8cccd Reviewed-on: https://chromium-review.googlesource.com/596468Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#491160}
-
- 01 Aug, 2017 28 commits
-
-
Adrienne Walker authored
Instead of having to serialize SkRegion (as clipRegion is the only call that needs a region), instead add a top level "clip device rect" that takes two parameters. This is to support the use case that the RasterSource canvas setup preamble uses to clear the canvas efficiently. Bug: 737629 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icfb41557c716d5c52ef44454b8791e29c36d5bda Reviewed-on: https://chromium-review.googlesource.com/590950Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#491159}
-
Victor Vasiliev authored
Update feature flags https://chromium-review.googlesource.com/c/596150/ Deprecate quic_reloadable_flag_quic_faster_bandwidth_sampler. Merge internal change: 163489610 https://chromium-review.googlesource.com/c/595337/ Remove unused methods Merge internal change: 163472196 https://chromium-review.googlesource.com/c/595336/ Adding two new QUIC BBR ack aggregation modes. The modes are requested with the BBR1 and BBR2 connection options and protected by quic_reloadable_flag_quic_bbr_ack_aggregation4, which replaces quic_reloadable_flag_quic_bbr_ack_aggregation3. Merge internal change: 163344044 https://chromium-review.googlesource.com/c/595335/ Deprecate quic_reloadable_flag_quic_bbr_ack_aggregation2 in the false state. Merge internal change: 163252118 https://chromium-review.googlesource.com/c/595333/ Change QUIC ack type byte to match IETF 101NLLMM format As specified by https://github.com/quicwg/base-drafts/commit/fac7f9d91f781602d8425ccd1fa6aa521f78243a. Merge internal change: 163211775 https://chromium-review.googlesource.com/c/594855/ R=rch@chromium.org Bug: Change-Id: I7c7e1af913f98c8c8dfd4d98551ae320c0febf5d Reviewed-on: https://chromium-review.googlesource.com/596227 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#491158}
-
Tien-Ren Chen authored
NO_TRY=true Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia08770feb6daae4844d50713271e19b5a2a8394b Reviewed-on: https://chromium-review.googlesource.com/596770Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#491157}
-
Tommy C. Li authored
It's been enabled by default for a long time. We're just removing the feature flag now. Bug: 749174 Change-Id: I6cad01d596855c4320e219597789347c63a5b9a6 Reviewed-on: https://chromium-review.googlesource.com/587428Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#491156}
-
Cooper Knaak authored
Add ARC guard to bubble_util.mm so it can only be compiled with Automatic Reference Counting enabled. Although it currently only contains C++ symbols, it is convention to include the ARC guard on all new files. If in the future Objective-C symbols were added to the file, not having the ARC guard could cause memory leaks. R=edchin@chromium.org, gchatz@chromium.org Bug: none Change-Id: I0b72bd93a904f04034ca85f9f21b969f9a358e07 Reviewed-on: https://chromium-review.googlesource.com/596587 Commit-Queue: Cooper Knaak <cooperknaak@google.com> Reviewed-by:
Ed Chin <edchin@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491155}
-
Yuwei Huang authored
Previously when the user taps "Hide Keyboard" from the session menu, the keyboard will immediately show then hide itself. This CL prevents the keyboard from showing between (alert is shown, action is executed) and manually shows it again only when necessary. This CL also includes some refactoring to reduce redundant common code. Bug: 750956 Change-Id: I545e1880352e279ebf324676f7680600761b78f3 Reviewed-on: https://chromium-review.googlesource.com/595016Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#491154}
-
Weiliang Chen authored
Add a function to replace existing quad with a solid color draw quad to reduce duplicate code in overlay. R=danakj@chromium.org Bug: 739429 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6ea4df426dde50122b73923d970ea3e6429dd8aa Reviewed-on: https://chromium-review.googlesource.com/596647 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
John Bauman <jbauman@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491153}
-
Gauri Manikpure authored
Bug: chromedriver:1878 Change-Id: I1ae14a5e3700e442ca1507db5c2f51e9e1005044 Reviewed-on: https://chromium-review.googlesource.com/596531Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Gauri Manikpure <gmanikpure@chromium.org> Cr-Commit-Position: refs/heads/master@{#491152}
-
Matt Menke authored
In particular, add suppressions for some new bluetooth/characteristic/ tests, an inspector-protocol test that's seen recent work, and a scrollbar test that's falking for unknown reasons. TBR=rdsmith@chromium.org NOTRY=true Bug: 729849 Change-Id: Ib26bad25b705c9e05c57f588362bcbc9233f5ae5 Reviewed-on: https://chromium-review.googlesource.com/596795 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#491151}
-
Tommy C. Li authored
This CL prevents the match part of the URL from being elided by the experimental URL formatting flags. Bug: 732582 Change-Id: Ic08a8cad845f4d4581d8f6310e59423191d4bd28 Reviewed-on: https://chromium-review.googlesource.com/594722 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#491150}
-
Aleksandr Derbenev authored
Make clang build use msvs_use_absolute_paths gn argument to get same behavior in msvc & clang builds. https://chromium-review.googlesource.com/c/558871/#message-7a8946793945959784b225c192588fa4bb5f26b1 Follow-up: https://chromium-review.googlesource.com/c/558871/ Bug: Change-Id: I9c35d83b0f163356aac0fd2c94f4c56c02a794a5 Reviewed-on: https://chromium-review.googlesource.com/585467Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491149}
-
Tom Anderson authored
This CL reverts the changes in sysroot-creator.sh and rolls the sysroots forward to reflect the change. BUG=749077 R=thestig@chromium.org Change-Id: Ia9ba4427666dbf9268138f7ec7a2f77df70a172f Reviewed-on: https://chromium-review.googlesource.com/596419 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#491148}
-
Anantanarayanan Iyengar authored
This is to ensure that we can provide functionality to update the AppCache using the URLLoader. The plan is to implement the URLLoaderClient part of the update job in a subsequent patch. This patch has the following changes: 1. We have a new class AppCacheUpdateRequestBase which provides the interface which is implemented by the URLRequest and URLLoaderClient subclasses. This interface is used by the URLFetcher and the AppCacheUpdateJob. 2. Subclasses AppCacheUpdateURLRequest and AppCacheUpdateURLLoaderRequest. These implement the URLRequest and URLLoaderClient portion of the update functionality. The URLRequest one is fully functional at this point. 3. I have left most of the reading and updating logic unchanged in URLFetcher unchanged. Will revisit this when I start working on the URLLoaderClient functionality. 4. The AppCacheUpdateURLRequest subclass maintains a pointer to the URLFetcher base and invokes its methods when it receives a response/redirect notification/data, etc. BUG=715632 Change-Id: I16497e41aa5dbfab0c06c1ab0fc114945dd279e8 Reviewed-on: https://chromium-review.googlesource.com/592809Reviewed-by:
Michael Nordman <michaeln@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ananta Iyengar <ananta@chromium.org> Cr-Commit-Position: refs/heads/master@{#491147}
-
Aaron Leventhal authored
Bug: 748318 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieec84f84713dafde7e6186367032a09eb18af3f6 Reviewed-on: https://chromium-review.googlesource.com/584169 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#491146}
-
Tom Anderson authored
R=dpranke@chromium.org CC=thakis@chromium.org Change-Id: I6ed223a1fe08fa95837156ae9f4800acf7396524 Reviewed-on: https://chromium-review.googlesource.com/592512Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#491145}
-
Danyao Wang authored
Transient URL rewriters do not make sense for lazily synced navigation items. Refactoring them out of CreateNavigationItemWithRewriters allows GetItemAtIndex() to maintain its const contract. There is no behavior change for LegacyNavigationManager or CRWSessionController. The new behavior only affects WKBasedNavigationManager. Bug: 734150 Change-Id: Id39ef8151b268f44b2179977da5cc8ace10fafbe Reviewed-on: https://chromium-review.googlesource.com/590150 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#491144}
-
Dave Schuyler authored
This CL removes the i18n-content on the <title> (afaik it was not being set so I removed it rather than converting to $i18n{title}). Also removes strings.js and i18n_template.js which should be unneeded at this point. Bug: 677338 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iab29f07c23d200ed824f4207199853d982eefff2 Reviewed-on: https://chromium-review.googlesource.com/585769Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#491143}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/a53b8db56039..bcaa25858745 $ git log a53b8db56..bcaa25858 --date=short --no-merges --format='%ad %ae %s' 2017-07-31 dalecurtis [mov] Bail when invalid sample data is present. Created with: roll-dep src/third_party/ffmpeg Bug: 750009 Test: asan test case now passes Tbr: wolenetz Change-Id: I565568cdabf61533b5a0527ab73e9d2c8ba3fdc2 Reviewed-on: https://chromium-review.googlesource.com/595167Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491142}
-
Eric Roman authored
Netscape Server Gated Crypto (2.16.840.1.113730.4.1) is a deprecated mechanism that is still in use by some unexpired (intermediate) certificates. It is not part of the RFC 5280 profile for internet PKI. This change adds a warning for the chain(s) in the certificate that are relying on nsSGC in place of server auth. Bug: 733403 Change-Id: I2994f7f5e2981eecf24bb9839e266d4292cad7f8 Reviewed-on: https://chromium-review.googlesource.com/593207Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491141}
-
Marijn Kruisselbrink authored
Pass a mojo BlobPtr in addition to the uuid in all the IPCs/mojo calls for the cache and fetch APIs to make sure the blobs stay alive long enough. Since the cache and fetch APIs largely pass around their parameters in a copyable struct (mostly passed by const reference) this also required introduction of a storage::BlobHandle type, a ref-counted wrapper around a BlobPtr. The BlobPtr passed along in IPCs/mojo messages isn't actually used for anything other than lifetime management at this point. The browser side code still uses the UUID to actually look up the blob and get its data. Also add service worker and fetch tests to the mojo blobs virtual test suite to make sure this all works correctly. Bug: 740744 Change-Id: I6bfcda977cd605099bd6c04d9f079ce7783b43f4 Reviewed-on: https://chromium-review.googlesource.com/567549Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#491140}
-
Joy Yu authored
Add a new member variable LayoutTableCell::is_spanning_collapsed_row_ so that there is no need to access LayoutTableSection::RowHasVisibilityCollapse in LayoutTableCell. This avoids using the memory that has already been freed. Bug: 750016 Change-Id: I1838a775f3b45315b2dee3e15942af0dff0c5955 Reviewed-on: https://chromium-review.googlesource.com/594935Reviewed-by:
Morten Stenshorne <mstensho@opera.com> Commit-Queue: Joy Yu <joysyu@google.com> Cr-Commit-Position: refs/heads/master@{#491139}
-
Yuly Novikov authored
conformance/extensions/oes-texture-float-with-video.html conformance/textures/image_bitmap_from_video/* conformance/textures/video/* On Win10 NVIDIA Quadro P400 D3D9 BUG=750896 TBR=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I56d7e5e5b052d351fe30b0d775da9bf431be8d23 Reviewed-on: https://chromium-review.googlesource.com/595158 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#491138}
-
rdevlin.cronin authored
Migrate the ActivityLog and related classes away from posting tasks to and checking that they are currently on the content::BrowserThread::DB thread, and replace this with a singleton SequencedTaskRunner to be used in the activity log. BUG=689520 Review-Url: https://codereview.chromium.org/2980503002 Cr-Commit-Position: refs/heads/master@{#491137}
-
Matt Menke authored
There are also some suppressions for tests with the same test fixture. TBR=rdsmith@chromium.org NOTRY=true Bug: none Change-Id: I8b15460c0725525b1d6510c6f00852a3afb59f6f Reviewed-on: https://chromium-review.googlesource.com/596798Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#491136}
-
Raymond Toy authored
Keep nodes alive when there are no input connections so that the node has time to flush out any internal memory. When the output of the node is going to be disabled (because there are no inputs), place the node on a list, without disabling the output. The list is processed every rendering quantum to see if the tail time of node has passed. If the tail time has not passed, nothing is done; otherwise, the output is disabled, and the node is removed from the list. This allows the node to be collected, if possible. Bug:357843 Test:AudioNode/tail-processing.html,DynamicsCompressor/dynamicscompressor-clear-internal-state.html, internals/cycle-connection-gc.html Change-Id: Iab28ec749ee532cbb2ee9631501a6dac0ceb0afb Reviewed-on: https://chromium-review.googlesource.com/583587Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#491135}
-
Helen Yang authored
Previously, unit tests for bubble_util overrode the ICU default locale in order to test methods in LTR/RTL. This caused CardStackLayoutManagerTest to fail on bots. This CL fixes the issue by removing default locale overrides from bubble_util unit tests, and instead adds an |isRTL| parameter to the relevant util method to make it more testable. Bug: 750865 Change-Id: Ia53f92c8a08636c8c56519306b9347e8b425a37f Reviewed-on: https://chromium-review.googlesource.com/596673 Commit-Queue: Helen Yang <helenlyang@google.com> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491134}
-
Adithya Srinivasan authored
The OmniboxViewTests are currently flaky, see the associated issue for more details. TBR=jdonelly@chromium.org Bug: 751031 Change-Id: I051f5ad400b4ab729c45e7b2c77365d1dba45356 Reviewed-on: https://chromium-review.googlesource.com/596927Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#491133}
-
Bret Sepulveda authored
Restores the OnFocus > SetChecked line in RadioButton removed in https://chromium-review.googlesource.com/c/547075, which is required to let the user move the radio selection with the arrow keys. Bug: 749014 Change-Id: I861f64b3abbcaac2ec762c7014e5b5e6bee8965b Reviewed-on: https://chromium-review.googlesource.com/595231Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#491132}
-