- 05 Aug, 2020 40 commits
-
-
My Nguyen authored
Bug: 1045266 Change-Id: I7021f830ee53c1c86f1149b10133cb1329d13218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308549 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#794956}
-
Alex Rudenko authored
Bug: 1106681 Change-Id: Ib61221e7847c71db4c27ae74524c44cb16a2fea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332445Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#794955}
-
Yunke Zhou authored
Show parental controls is not eligible for managed(edu/enterprise) account. Show different subtitle for newly created child account and existing child account. Update strings. Bug: 1101318 Change-Id: Ia4ec05cd27f1517abb27ddc728ea1bd252b2fdc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332264 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794954}
-
Javier Ernesto Flores Robles authored
Bug: 1112785 Change-Id: I99a228547d7907c2e9825d72da70a9d96b1f2206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335195Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#794953}
-
Friedrich Horschig authored
This CL completes the wiring between bridge and mediator. It makes the mediator observe the PasswordCheck for finished fetches (and additional credentials) and queries already known issues. Bug: 1106726, 1101256 Change-Id: Id3dd8b0a18e6d6d4d0eeef30242f65c0e59c7340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336835 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#794952}
-
Aya Elsayed authored
This reverts commit 26f4c62b. Reason for revert: chromeos-eve-chrome build failures Original change's description: > Re-add field trial testing config for DisableLatencyRecoveryDesktop > > Based on the data gathered from running the experiment on canary/dev and > beta, it seems that the disabling latency recovery for both main and > impl threads is an overall performance win. So, we are going to > re-enable the (now-expired) experiment on stable and move forward with > its gradual rollout. > > Bug: 993895 > Change-Id: I5c45c3cb469d14cf53193d0af6a560842ce02be2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309188 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Mohsen Izadi <mohsen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790549} TBR=mohsen@chromium.org,rkaplow@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993895, 1113101 Change-Id: Ibfebd16583e4f4670d808b80eb00360f0e744ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338214Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#794951}
-
Omer Katz authored
We use a snapshot of the hash table key to check whether a bucket is empty or deleted, but we don't use the snapshot for the actual tracing. This leads to a time-of-check vs. time-of-use issue where a bucket can become deleted while we are checking the snapshot. This CL refactors the TractTraits for KeyValuePair so that concurrent marking can use the snapshotted key as the traced key. Bug: 1110416 Change-Id: Icd758886e9e51a8af4e727ae6b853b958723fb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336073 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#794950}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d5eb7e06f156..d84b21c3f04c 2020-08-05 fancl@chromium.org chromeperf: Temporarily disable SimulateAlertProcessing 2020-08-05 fancl@chromium.org chromeperf: Formatting all python code under dashboard If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: Ib4a8aa917635c6561bf8c6455c63c4e88326e77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338257Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794949}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4e40fda83f28..171aaf4db08f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ayaelattar@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ayaelattar@google.com Change-Id: Id221f91c97d1eb24ffab02bc884b9d767f8518c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338476Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794948}
-
dizg authored
Screenshot for light mode: https://drive.google.com/file/d/1cVocXW7_qV-OsW-RC5Q9_8oIc0UgAyZw/view?usp=sharing Screenshot for dark mode: https://drive.google.com/file/d/1uG2qP8ZwzqPA1NHdvtt4rgpd9vX1aY-8/view?usp=sharing The current image is temporary, it will be changed in a separate CL once it will be ready. Bug: 1105865 Change-Id: Ifea158663fa85147677c2ee0920c5a2aa2fa0bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332660 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#794947}
-
Tsuyoshi Horo authored
This reverts commit 6772afd3. Reason for revert: Caused test failures of PDFExtensionAccessibilityTreeDumpTest. Bug: 1113093 Original change's description: > Stops computing an artificial accessible name from inner text on Mac > > When an object on Mac is focusable but has no value or name, we compute its accessible description > from its inner text. > Unfortunately, we were adding a space between the concatenation of each piece of text coming from each child object > which creates a mismatch between the text offsets returned by AXPosition and text markers vs. the actual text contents. > If extra spaces are needed, they should be added by Blink, not by the browser. > This patch removes the code that computes the inner text completely since > no other screen reader announces focusable items unless they have an accessible name, > and it is not proper to add an accessible name if there is none. > > AX-Relnotes: On Mac and same as on all other platforms, navigating by tab now does not announce > the text contained in a large container such as a table row if that container is focusable. > > R=dmazzoni@chromium.org > > Change-Id: Iac5f321113595a2372df03bb119ab1c7a6f1bbf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308649 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794574} TBR=dmazzoni@chromium.org,nektar@chromium.org Change-Id: I10d7260e2d8be39f632213925164679f1982b3d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338694Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#794946}
-
Mark Brand authored
This NOTREACHED was a poor decision, as fuzzer can directly reach this code, so it will produce spurious check failures during fuzzing. Return a 0 tag in this case instead - this will lead to the fuzzer trying to deserialize a type which is not stored in the proto, which will fail quietly instead. Bug: 1076336 Change-Id: Ie6eb826c026f0e157fe71a030a4cd612dfa794e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302630 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#794945}
-
Kent Tamura authored
NGFieldsetPainter::PaintFieldsetDecorationBackground() re-computed the legend offset without position:relative from scratch. Instead, this CL change the function so that it unapplies position:relative to |legend->Offset()|. This CL has no behavior changes. Bug: 875235 Change-Id: I933b1e6c97e1f913e0d9f1aa9525af881dbe2240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332198 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#794944}
-
Aya ElAttar authored
Step "browser_tests" failing on builder "Linux Tests" because of this test. TBR: jdeblasio@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113105 Change-Id: I506498638aba27447ad5f06b1bb83caa8158c96e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335196 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a1d72d581076..807ce12a0c4f 2020-08-05 tmathmeyer@chromium.org Add support for displaying text track information in the Media tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1090022 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I05ce441749075223b13b68cc5b0d5075d0487e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338475Reviewed-by:
-
Ryan Harrison authored
Roll src/third_party/tint/src/ 88f0ae369..f18d737b4 (27 commits) https://dawn.googlesource.com/tint.git/+log/88f0ae369fef..f18d737b4e93 $ git log 88f0ae369..f18d737b4 --date=short --no-merges --format='%ad %ae %s' 2020-08-04 rharrison Rolling 7 dependencies and fix BUILD.gn 2020-07-30 dsinclair [ast] Add texture types to the AST. 2020-07-30 dsinclair Add SamplerType to AST. 2020-07-30 dsinclair [hlsl-writer] Add loop support. 2020-07-30 dsinclair [hlsl-writer] Add if/else statements. 2020-07-30 dsinclair [hlsl-writer] Emit variable declarations. 2020-07-30 rharrison Add SPIR-V Reader Fuzzer 2020-07-30 rharrison Remove _exe suffix from sample program 2020-07-30 rharrison Change the default for BUILD.gn to build all the modules 2020-07-30 rharrison Simplify fuzzer targets to ease adding additional targets 2020-07-30 dsinclair Fixup build warnings 2020-07-30 dsinclair [wgsl-reader] Add stride support. 2020-07-30 dsinclair [wgsl-writer] Emit array stride decoration. 2020-07-30 idanr Add BlockStatement insert and non-const global_variables 2020-07-30 sarahmashay [Validator] Using pointers instead of refs 2020-07-29 dsinclair [hlsl-writer] Add member accessor emission. 2020-07-29 dsinclair [hlsl-writer] Add AsExpression to the HLSL backend. 2020-07-29 dsinclair [hlsl-writer] Add BlockStatement support. 2020-07-29 dsinclair [hlsl-writer] Emit discard. 2020-07-29 dsinclair [hlsl-writer] Emit array accessors. 2020-07-29 dsinclair [hlsl-writer] Add alias type support. 2020-07-29 dsinclair [hlsl-writer] Add constructor emission. 2020-07-29 dsinclair Add hlsl writer tests to BUILD.gn 2020-07-29 dsinclair [hlsl-writer] Add type emission. 2020-07-29 dsinclair Update some language usage. 2020-07-29 dneto [spirv-reader] Only support column-major matrices 2020-07-28 rharrison Remove binutils from DEPS and pull in changes to build.gni from Dawn Created with: roll-dep src/third_party/tint/src Roll src/third_party/SPIRV-Tools/src/ c6e6597c4..8bc27a1cf (11 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c6e6597c4f51..8bc27a1cfbc1 $ git log c6e6597c4..8bc27a1cf --date=short --no-merges --format='%ad %ae %s' 2020-08-04 vasniktel spirv-fuzz: Remove OpFunctionCall operands in correct order (#3630) 2020-08-04 vasniktel spirv-fuzz: Handle capabilities during module donation (#3651) 2020-08-04 vasniktel spirv-fuzz: Refactor boilerplate in TransformationAddParameter (#3625) 2020-08-03 vasniktel spirv-fuzz: TransformationMoveInstructionDown (#3477) 2020-07-31 jaebaek Remove DebugDeclare only for target variables in ssa-rewrite (#3511) 2020-07-31 vasniktel Fix typo in ASAN CI build (#3623) 2020-07-30 stefanomil spirv-fuzz: Transformation to add loop preheader (#3599) 2020-07-30 stefanomil spirv-fuzz: Pass to replace int operands with ints of opposite signedness (#3612) 2020-07-30 jaebaek Debug info preservation in loop-unroll pass (#3548) 2020-07-30 alanbaker Validator support for non-semantic clspv reflection (#3618) 2020-07-30 vasniktel spirv-fuzz: Fix memory bugs (#3622) Created with: roll-dep src/third_party/SPIRV-Tools/src Roll src/third_party/spirv-headers/src/ 979924c8b..3fdabd0da (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/979924c8bc83..3fdabd0da293 $ git log 979924c8b..3fdabd0da --date=short --no-merges --format='%ad %ae %s' 2020-08-03 44190824+mmerecki Reserve SPIR-V token range for upcoming Intel extensions. (#165) 2020-07-29 alanbaker Update BUILD.bazel and BUILD.gn (#166) 2020-07-29 alanbaker Publish the headers for the clspv embedded reflection non-semantic extended instruction set (#164) 2020-07-29 johnkslang Update the registry in spir-v.xml to modernize and split out opcodes. (#156) Created with: roll-dep src/third_party/spirv-headers/src Roll src/third_party/dawn/ 0a4342793..076a4e582 (1 commit) https://dawn.googlesource.com/dawn.git/+log/0a4342793e0e..076a4e58205d $ git log 0a4342793..076a4e582 --date=short --no-merges --format='%ad %ae %s' 2020-08-04 rharrison Roll 6 dependencies and bypass changed API usage Created with: roll-dep src/third_party/dawn Change-Id: I4a6dc63352de60cc422e0dea496487401dc28802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330303 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#794941}
-
Christian Dullweber authored
This reverts commit 978386ba. Reason for revert: Enable the test again to see if it still failing. Original change's description: > [Sheriff] Disable PageInfoViewTest > > These render tests are failing on different building bots. > TBR=dullweber@chromium.org > > Bug: 1112985 > Change-Id: I1590c2bad3c0042ecfd73ac46c6edbffb2f683fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337290 > Reviewed-by: Wenyu Fu <wenyufu@chromium.org> > Commit-Queue: Wenyu Fu <wenyufu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794795} TBR=dullweber@chromium.org,wenyufu@chromium.org Change-Id: Ida3ca24ffb5c6567941a1a4093071fc5721b167d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332728Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#794940}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I07b44e432816387cfa7d63ab2b8137ef6d06cd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337581Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794939}
-
Ewann authored
On iOS 13.1 the whole TOS string responds to a TAP. On iOS 13.5, it works as expected. Bug: 1102996 Change-Id: I8f72200964ed28dad7de52d9029fb14f97725e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336609Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#794938}
-
Maxim Kolosovskiy authored
UI mocks: https://docs.google.com/presentation/d/1jsRsqvW8ZasT2iJGu-_8ebY3bPDe6ic8x8touqeNjuo/edit#slide=id.g8de4a3b916_55_6 Screenshot: https://screenshot.googleplex.com/97hV2heWU15 TODO: Add the icon for the regular change button. https://screenshot.googleplex.com/XzOB9tPeV2X Bug: 1086114, 1092444 Change-Id: I7164bf6f6f01a3bdc2cde3bfacc5817774661611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336608 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#794937}
-
My Nguyen authored
Doesn't matter too much but it bugs me when adding new files No-Bug: drive-by Change-Id: I5ecbe0d869a5742cbb94c1eac2c2f90a0febff22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331989 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
-
Victor-Gabriel Savu authored
Add the DeviceShowLowDiskSpaceNotification policy to control the suppression of the low disk space notification on enrolled devices. Currently no notification is shown if multiple users are present on the device. The policy will give administrators control over the notification instead. No change of behaviour if the policy is not present. Design doc: https://docs.google.com/document/d/1_mblglRZlPeWpc1cn9T8vb97rnLEmjA7waiSLp-qKcE Bug: chromium:1099604 Change-Id: I53bbed664e0f05f8f33a5cd659f0c36e51fbd21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270297 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#794935}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596592719-2068cb1d91dadb54c39df6d59c975d7a57a508b2.profdata to chrome-win32-master-1596596349-2982a3aa1ac388b8b69893b6dd544749d7f1a2d0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I8263a9e01e91836c876359758133d589ca0b8611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338254Reviewed-by:
-
Nicholas Verne authored
interfaces. This should prevent annoying notifications for docking stations which have HID and vendor-specific interfaces. Also, forbid sharing of HUB devices (an oversight in the original impl) Suppress notifications for BILLBOARD devices (external monitors connected through USB) Bug: 1109407 Change-Id: I896b12ec1b2572fdf4f37ed4dc811f655682f7dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338155 Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#794933}
-
Alan Cutter authored
This CL adds a "web_app_migration_flag" field to external extension config dicts. This is part of migrating default installed hosted apps over to replacement default web apps. When the flag specified by "web_app_migration_flag" is active the extension config will behave like "keep_if_present" is enabled. The extension will not be installed if it is not already on the machine but it will also not be uninstalled if it is on the machine. This will allow the web app migration process to migrate user preference data from the extension app over to the replacement web app and uninstall the extension when complete. Incidentally the changes made to test this feature fixes ExternalProviderImplTest.InAppPayments which had an out of date version string. Bug: 1104696, 1083959 Change-Id: Ie793e7c7b48e821d09855ac9cf09f7972f2b7bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316967 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794932}
-
Nidhi Jaju authored
In order to avoid retrieving all service worker registrations in DevTools, we removed the "other origins" UI[1] and added a link to chrome://serviceworker-internals[2] if developers still want to see registrations from other origins. This UMA is added to check how many people are actually using that link in the Application Panel in DevTools to view other origin registrations. This is done by checking the query string of the url. [1] https://crrev.com/c/2308615 [2] https://crrev.com/c/2324268 Bug: 807440 Change-Id: If6204792478352a65a0c30fa689d69ada7a00507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325537 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794931}
-
Oleh Lamzin authored
Remove leftover event handler from trusted.js after experimenting with Mojo interceptor for tests. Bug: b:153371185 Change-Id: I5de49538203ef9401ec727a667e93dcac475c7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335281 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#794930}
-
Tanmoy Mollik authored
This cl creates two render tests to check personalized signin promo and sync promo in Bookmark page. Bug: 1095628 Change-Id: I25c27afe1db0ef9445478121baa4767eb251f8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302889 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#794929}
-
Nina Satragno authored
This patch follows-up on crrev.com/c/2320075 to clean up lottie tests: * Enable closure compilation. * Re-enable a test that was missed in the previous CL. * Delete a redundant test that was verifying private behaviour. Bug: 1000989, 1103865 Change-Id: I3754eb1ebb060179e6a652028751110f9da792f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317854 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#794928}
-
arthursonzogni authored
Add WPT tests for accesses made from an iframe toward a window that would have been in a different browsing context group if Cross-Origin-Opener-Policy-Report-Only was enforced. Branch: [1/M] https://chromium-review.googlesource.com/c/chromium/src/+/2332257 [2/M] This patch. Bug: 111169 Change-Id: Id42f728fbcc90b10feab2e22c216e29d6546509d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332258 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#794927}
-
Zufeng Wang authored
The URL inside the help app's iframe changes as the user navigates the app, but the URL outside the frame always stays the same after launching. Forcing a navigation makes the help app refresh when the content inside the frame doesn't match the launch URL. Bug: b/147786001 Change-Id: I92427fc90f146061022f08b969662c655f30e28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337200 Commit-Queue: Zufeng Wang <zufeng@google.com> Reviewed-by:
-
Stefan Wallner authored
Bug: 1088706 Change-Id: I31d2e28fbd53e2db989adf151d7e492cbe73645c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333192Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Stefan Wallner <sawallner@chromium.org> Cr-Commit-Position: refs/heads/master@{#794925}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/90bf66075426..a1d72d581076 2020-08-05 tmathmeyer@chromium.org Add "Hide all others" to right click menu on media player list 2020-08-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1104376 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1c7f1e7bee0ae613e0b794a1340317293b72cc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337841Reviewed-by:
-
Varun Khaneja authored
I'm hoping that the logs here would help better understand the reason for the linked bug. I've added a TODO to remove these log statements once the bug is fixed. Bug: 1104919 Change-Id: I6404463565c9480732481a645e024d56f6803805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336543 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#794923}
-
My Nguyen authored
As part of adding assistive autocorrect, we want to get the markers when cursor is at the boundary of the words, and there is a possibility that there are multiple markers so adding "MarkersAroundPosition" to support the call. Related CL: https://crrev.com/c/2326556 Design-doc: http://go/cros-get-autocorrect-range Bug: 1109074 Change-Id: Id0f784e94258f5799c8c09e153b30bd52d4d30fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336430 Commit-Queue: My Nguyen <myy@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794922}
-
Marc Treib authored
Bug: none Change-Id: Iaf76342e4984d94b2cfbc1b95a340f93c07bfb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336838 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#794921}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8076f2289388..4e40fda83f28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC horo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: horo@google.com Change-Id: I2756d0f16cd66f858e2dbc70f1fb12279a07ba55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332524Reviewed-by:
-
Jing Wang authored
As part of task success metrics, add these to make sure users can accept emoji efficiently or not distracted by the suggestions. Bug: 1110740 Change-Id: I9fba1383dbadf5ba6b1fd9ff5be735244d3ec05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336098Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794919}
-
Rachel Wong authored
This CL extracts the logic for handling actions into separate methods. This allows the handlers to be called when handling KeyEvents, rather than being directly tied to the view listeners. This is also in preparation for https://chromium-review.googlesource.com/c/chromium/src/+/2269385/ Bug: 1112714 Change-Id: I06e8dbb3c4dfb4725342af9a34787a8fcb3ac041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336319Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#794918}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/adc250c38976..25b0de6bd00f 2020-08-05 jmadill@chromium.org Vulkan: Squash Texture+ImageView Serial and improve caching. 2020-08-05 nguyenmh@google.com Batch capture run + change how results are logged 2020-08-05 xinyi.he@arm.com Disable RobustBufferAccessWebGL2ValidationStateChangeTest on Mali 2020-08-05 jmadill@chromium.org Vulkan: Redo Sampler Serials. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Idd7a445f9f83d05280433c62daf956154edc7ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337996Reviewed-by:
-
