- 09 Oct, 2020 3 commits
-
-
Liviu Tinta authored
In web tests there is no compositor_task_runner. In this case we need to use the main_thread_task_runner. Bug: 1047198 Change-Id: I23cf2f46543eff84d11e694e81b2ce2e74b96b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451324Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#815389}
-
Jesse Schettler authored
Add a new Polymer element, color-mode-select, to display color modes (e.g. color, black and white, etc.) in a dropdown. Bug: 1059779 Change-Id: I9bda4b992b0a3a1120a6332c0f3d91c614807b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453109Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#815388}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2a472f6edd47..660580a68ad0 2020-10-08 andoli@chromium.org [ts] Typecheck data_grid/ViewportDataGrid.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I35e422e95c7b574c80d73e6f06cc84e392f9ed6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462360 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815387}
-
- 08 Oct, 2020 37 commits
-
-
Alan Cutter authored
This CL adds two new UMAs for when the user sets a web app to open in a window or a browser tab: - WebApp.SetWindowMode.Window - WebApp.SetWindowMode.Tab This is includes adding the new variable |is_user_action| to WebAppRegistryController::SetAppUserDisplayMode(), which allows the metric to be recorded only if the switch was triggered by a user action (and not, say, migration code). This CL also removes the bookmark apps variant of AppServiceShelfContextMenuWebAppBrowserTest because the new tests fail under bookmark apps which we no longer support anyway (https://crbug.com/1065748). Bug: 1135941, 1065748 Change-Id: Ib32e0996a2c126d5ca622e6292593edb57f6c559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454436Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#815386}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/33a0deb815ce..19899becb76e 2020-10-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from c169506c9e6e to f600d3aa9f26 (1 revision) 2020-10-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from eb5d3e147d39 to c169506c9e6e (2 revisions) 2020-10-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 71d69e5ed3f4 to eb5d3e147d39 (1 revision) 2020-10-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 5118c0726106 to 71d69e5ed3f4 (1 revision) 2020-10-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 1a63c49b4e86 to 5118c0726106 (1 revision) 2020-10-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 007dc42cbb43 to 1a63c49b4e86 (1 revision) 2020-10-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from fc5c5ab60b22 to 007dc42cbb43 (1 revision) 2020-10-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 66377ce9be54 to fc5c5ab60b22 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: If9e0670d767589f9924acca4dd74a862e2ff2e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462358Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815385}
-
Curt Clemens authored
Before, the NearbyShareDelegate was turning off high visibility mode by invoking the settings page with ?stop_receiving. That wasn't working because it was causing the settings page to reload and the state was lost. Instead, we go directly to the NearbySharingService and remove the foreground receivers. Bug: 1133799 Change-Id: I6cb35799dc8ee39db3d20cdd8865b45fccccf4e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441114Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#815384}
-
Andrei Pascovici authored
Although Android devices have the GPU service, certain Android Things devices don't (e.g. display-less Speakers). This places the respective Mojo service in a process that actually exists on such devices. Further to note, that such devices don't have enable_cast_renderer enabled (unlike their brethren in CastOS [non-Android] devices). Bug: internal b/169782727 Test: on [undisclosed] device see bug Change-Id: I94d19ebaa4a3e0113a89bc96ec684f159ab6be3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460829Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Andrei Pascovici <apascovici@chromium.org> Auto-Submit: Andrei Pascovici <apascovici@chromium.org> Cr-Commit-Position: refs/heads/master@{#815383}
-
Yulun Wu authored
This addresses changes in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2400240 Other functions in app_list_color_provider_impl will be updated later. Bug: 1134800 Change-Id: I21b7448cc5a9805a6991622f912041b7ffb04258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459310Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815382}
-
minch authored
Bug: 1131543 Change-Id: I9c1cb61c48033625ecdc0f05e5188ab1ac2e7783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454389 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815381}
-
Yulun Wu authored
This CL addresses the changes in: https://chromium-review.googlesource.com/c/chromium/src/+/2392949 Bug: 1134854 Change-Id: Ie8f39aa562595bed9f66006b68e3b20b2e29b538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460307Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815380}
-
Tom Anderson authored
The generated stubs use dlsym()ed functions, so must not be instrumented with CFI-icall. BUG=1136413 R=sky Change-Id: I698e6b3ed96349a2bb477767d54aeb9b3ad9096f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462216 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#815379}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/823a6df243c3..02a7aa75bb24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic56d9f657980f761fe9b266c35048a0c4f9d4893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460873Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815378}
-
Kenichi Ishibashi authored
ServiceWorkerStorageDiskTest::RegisteredOriginCount depended on both internal state of ServiceWorkerStorage (i.e. `registered_origins_`) and in-memory representation like ServiceWorkerRegistration. We need to eliminate either of them so that storage can be moved to the Storage Service. The test simulates browser shutdown and restart. It is better simulated in ServiceWorkerRegistryTest. This CL moves the test to ServiceWorkerRegistryTest. Bug: 1016064 Change-Id: I82363aedac7a2df5b72a21ac551e19c20d7b89fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460706Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815377}
-
Joel Hockey authored
Bug: b/170414561 Change-Id: I365f19d33a671db88f5275f68d1a720b24159aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461907Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Jason Lin <lxj@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#815376}
-
Gyuyoung Kim authored
This CL replaces the existing uses of native PreferredColorScheme with PreferredColorScheme Mojo enum type defined in preferred_color_scheme.mojom in order to remove unnecessary type conversion. Bug: 919392, 1097943 Change-Id: I9de6cb809b8dacfecdded4a499d3cfebd43ff2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461606Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#815375}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ibcb2638e12595d6023ff382c61983ca1f6d951cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461216Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#815374}
-
Gayane Petrosyan authored
Bug: 1136464 Change-Id: Ibfae772d5d289a74b1cffdb83f74ba8a370c08b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461118Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#815373}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e1589a1e19da..30378382aa3e 2020-10-08 michaelludwig@google.com Clip perspective bounds by device clip in SkPDFDevice 2020-10-08 jvanverth@google.com Revert "Merge GrContext::init into GrDirectContext ..." 2020-10-08 jvanverth@google.com Add push constant support to GrCaps. 2020-10-08 adlai@google.com Merge GrContext::init into GrDirectContext ... 2020-10-08 bsalomon@google.com Expose ManagedBackendTexture from BackendTextureImageFactory. 2020-10-08 kjlubick@google.com [canvaskit] Attempt to turn off rtti 2020-10-08 johnstiles@google.com Use SkSTArray to track CFG exits instead of std<set>. 2020-10-08 ethannicholas@google.com add missing <atomic> include 2020-10-08 egdaniel@google.com Rename GrStencilAttachment class to generic GrAttachment 2020-10-08 jlavrova@google.com Changing the way we select a grapheme If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I5f24556b8ed54b99fc86653f2c0a07ed108a4cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462366Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815372}
-
Caitlin Fischer authored
The feature was added here: https://codereview.chromium.org/2882013002. Bug: 1126640 Change-Id: Ie5d20b449c5144b1fbf163a6e0947cdd52dca56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427030Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#815371}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I4bb96d93b8c8bd01a67c5d2f62cdefc4842afdc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462363Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815370}
-
Chris Thompson authored
Adds an entry to chrome://flags for enabling SCT auditing and a set of variations to pick from for different sampling rates (0%, 0.01%, or 0.1%). This will allow for manual testing and fishfooding without needing to specify parameters on the command line. Bug: 1136620 Change-Id: I3d8c0e3f6dbe5d77704b1d64dd40b5243c20182f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462237Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#815369}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/02a7aa75bb24..628c64d7a14c 2020-10-08 treehugger-gerrit@google.com Merge "Add missing beginPath when drawing instant event arrows" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iebaed726a6276f30f5af9bc4e8e95297773560f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462154Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815368}
-
Karandeep Bhatia authored
Don't expose the capability to specify an isolated world CSP to manifest V3 extensions. Instead use a strict default CSP which disallows remotely hosted code. We might look at adding this back again if we see there's demand for this and are confident at the robustness of the IsolatedWorldCSP implementation. BUG=896041 Change-Id: I7a314c94c03651e90ff76437478d4f3982bf79cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439421 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815367}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //docs. Bug: 1113033 Change-Id: Ibd798892dcc522ce2363f85e53860259194eaa7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454498 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#815366}
-
Chong Gu authored
Add fuchsia-board-qemu-x64 filter for all video tests. Enable tests working locally New bugs to track remaining flakes/failures. Bug: 1096431,1096746 Change-Id: I7540ebc4695f47ce54164ce98dfe04f7065495a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458885 Commit-Queue: Chong Gu <chonggu@google.com> Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#815365}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/1a63c49b4e86..f600d3aa9f26 2020-10-08 rharrison@chromium.org Add --dawn-validation flag to sample app 2020-10-08 dsinclair@chromium.org [wgsl-reader] Allow global variable decorations to have multiple blocks. 2020-10-08 dsinclair@chromium.org [spirv-writer] Remove push_preamble 2020-10-08 dsinclair@chromium.org [wgsl-reader] Allow array decorations to have multiple blocks. 2020-10-08 dsinclair@chromium.org Update struct member decorations to allow multiple blocks. 2020-10-08 rharrison@chromium.org Add In/Out variables to returned EntryPoint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: kainino@google.com Change-Id: If64293afc31fd72835b9e7f327a55fdd6ffd78b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815364}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2a63e856..82430d69 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I43d1e870407d0a13fa4c0eb1af8ac8f0e8f21754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461594Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815363}
-
Alexander Timin authored
Delete URLLoader (which in this case is CachedNavigationURLLoader) when restarting a back-forward cache navigation as a non-cached one to cancel associated tasks and prevent to-be-cancelled navigation from making further progress. R=arthursonzogni@chromium.org,rakina@chromium.org BUG=1122935 Change-Id: Ice6a9ada33e575517bbbe8da07e3034e5c371b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461328 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#815362}
-
Bettina Dea authored
|mSignInPromo| may not be null but can be not visible. If the SigninPromo is either not null or visible, the Enhanced Protection promo should show. Bug: 1136272 Change-Id: Ib159dbbb3d40b6420bbd670321913b12b283e12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459395Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#815361}
-
Yulun Wu authored
This addresses changes in: https://chromium-review.googlesource.com/c/chromium/src/+/2406934 not addressed in: https://chromium-review.googlesource.com/c/chromium/src/+/2459206 Bug: 1134854 Change-Id: I44dc9cf7782f7dbe692d95659e84dd00062df19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460248Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815360}
-
Stephen Chenney authored
When creating textures for WebGL, always orient images with EXIF orientation data. This change also corrects the transposed size reported by ImageBitmap. And it removes superfluous arguments from CopyImageData. Bug: 1100470, 1125337 Change-Id: I79aa798327a3582939aa574723926b3325c80e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459400Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#815359}
-
Shimi Zhang authored
With crrev/c/2453270, we can remove the raw jobject version now. Bug: None Change-Id: I1a89666afb7f485570061678c5353b18888f9208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161780Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#815358}
-
Scott Violet authored
If a11y is enabled, then Tab creation may trigger calling some code paths that assume mBrowser was non-null. BUG=1136596 TEST=TabPrivateTest.testCreateTabWithAccessibilityEnabledCrashTest Change-Id: I500fd70cb56b7d16c22284acb677c06ec57b536d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461714Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#815357}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metatada from OWNERS files for //sandbox. R=rsesek@chromium.org Bug: 1113033 Change-Id: I2f065eb72e6f42f840ada0da5972c181c2f50265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454255 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#815356}
-
Marc Treib authored
Bug: 991510 Change-Id: I447e99f11c322478f007557ab268823ed2616042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455446 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#815355}
-
ckitagawa authored
Found out that setMatrix() is broken, but concat() is a viable alternative. https://stackoverflow.com/questions/17100355/canvas-is-offset-by-setting-identity-matrix-in-ondraw-of-custom-view Bug: 1126541 Change-Id: I30f4e37dd488385c2f024ac9ae8aa0de8277aa6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461214Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#815354}
-
Xi Han authored
The bug happens when the instant start startup code path is called in a warm start, i.e., ChromeTabbedActivity is recreated when the dark/light theme is changed. We add a check of warm start to prevent this from happening. Bug: 1117226 Change-Id: I65b48afd03137c33b5ed1a726aac23f9dffd7e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454254Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815353}
-
Wez authored
Bug: 1038786, 1132032 Change-Id: I1c78e60428604cc7c9d720e69cb4cb9175fa6593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461735 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815352}
-
David Van Cleve authored
We're investigating some failed Trust tokens Issuance operations executed via the Fetch API. We previously landed logging to get a better understanding of why these fetches fail, but the logging groups together fetches that fail for a couple of distinct reasons that can make ResourceError::GetResourceRequestBlockedReason() return ResourceRequestBlockedReason::kOther: (1) Explicit ResourceRequestBlockedReason::kOther returns by logic in Blink (2) net::ERR_BLOCKED_BY_CLIENT and net::ERR_BLOCKED_BY_RESPONSE errors from downstream services that do *not* have associated network::mojom::BlockedByResponseReasons. (If they had associated BlockedByResponseReasons, these reasons would be mapped to non-kOther ResourceRequestBlockedReasons.) This CL adds some additional logging for failed Trust Tokens operation-bearing fetches' net errors, which will help resolve this particular ambiguity as well, in general, provide richer information than just the ResourceRequestBlockedReason. Bug: 1128174 Change-Id: I84cd9e4f3551a364d1b80179a2c8f6b4085f8a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451729Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#815351}
-
Eugene But authored
The uptime is only estimate and updated when app gets backgrounded, battery level changes or similar system notification is posted. It might be useful to add a timer, which updates up time every few seconds, but that change will be done in a separate CL. Bug: 1103752 Change-Id: Ie12af0a259f915181199bd58aa1dbc57758ab60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459307 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815350}
-