- 17 Oct, 2012 32 commits
-
-
toyoshim@chromium.org authored
BUG=136950 Review URL: https://chromiumcodereview.appspot.com/11174006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162327 0039d316-1c4b-4281-b951-d872f2087c98
-
toyoshim@chromium.org authored
WorkerWebSocketHttpLayoutTest was disable. Actually, shared-worker-simple.html is the only test which is useful to run now. Also, providing fixed port for WebSocket test server is not so easy. So, I decided to remove existing WorkerWebSocketHttpLayoutTest, then introduce WorkerTest.WebSocketSharedWorker as a compatible test with shared-worker-simple.html. BUG=155014, 137639 TEST=content_browsertests --gtest_filter='WorkerTest.WebSocketSharedWorker' Review URL: https://chromiumcodereview.appspot.com/11028111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162326 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162325 0039d316-1c4b-4281-b951-d872f2087c98
-
nduca@chromium.org authored
BUG=155425 TBR=nduca@chromium.org Review URL: https://chromiumcodereview.appspot.com/11188026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162324 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
Add new HISTORY_DELETE_DIRECTIVE model type. Update everything that depends on model type. Rename SyncCryptographer test to Cryptographer (since it's already in sync_unit_tests). Add EncryptableUserTypes() function and use that instead of UserTypes() for encryption-related stuff. BUG=141245 TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10855037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162323 0039d316-1c4b-4281-b951-d872f2087c98
-
loislo@chromium.org authored
It broke python automation on DevTools perf bot. This reverts commit 8a429d0f. BUG=none TBR=yurys@chromium.org, pfeldman@chromium.org Review URL: https://codereview.chromium.org/11190017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162322 0039d316-1c4b-4281-b951-d872f2087c98
-
binji@chromium.org authored
BUG=none TBR=binji@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11183023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162321 0039d316-1c4b-4281-b951-d872f2087c98
-
toyoshim@chromium.org authored
TBR=wtc@chromium.org BUG=136950 Review URL: https://codereview.chromium.org/11192028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162320 0039d316-1c4b-4281-b951-d872f2087c98
-
kochi@chromium.org authored
The link was unconditionally associated with browser restart on Chrome OS, which made users think the browser crashed. The action was intended for the case when auth error happened and needs relogin to refresh the authentication credentials when the message is "Sign out then sign in again". For the message "Please update your sync passphrase", don't restart the browser but just show the dialog to prompt sync passphrase. Instead of assigning a fixed handler for the element ($(sync-action-link)), change the action according to whether the message is caused by auth error or anything else. BUG=150740 TEST=repro the issue described in 150740, open chrome://settings and click on "Please update your sync passphrase" message. Review URL: https://codereview.chromium.org/11178004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162319 0039d316-1c4b-4281-b951-d872f2087c98
-
nduca@chromium.org authored
My last megachange to crc, I promise. - Rename replay_server to wpr_server because replay implied replaying mode - Move WebPageReplay to be more core to the Browser object, splitting up "boot up the browser in a replay or record mode" from "what archive is being used for record" state. - Make browser_backend track its options object - Centralize argument handling on browser_backend.GetBrowserStartupArgs() - Make temporary http server handling more browser-centric in order to simplify page runner - Move some credentials logistics to the browser credentials object, also to simplify page_runner - Add some testability hooks to credentials object for tests. Not used, yet, but used in followup patch. - Pull page out of page_set. Its getting bigger. - Fix cyclic dependency on browser_gone_exception R=tonyg@chromium.org NOTRY=True Review URL: https://codereview.chromium.org/11115006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162318 0039d316-1c4b-4281-b951-d872f2087c98
-
karen@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162313 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162310 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
Rather than calling PK11_GetBestSlot, which requires enumerating all connected tokens, use PK11_GetInternalSlot, which explicitly uses the internal NSS key database. On Linux, this will ignore any user preferences regarding what tokens should be used for which mechanisms, but for internal/temporary operations, this is an acceptable tradeoff. BUG=chrome-os-partner:14707 Review URL: https://chromiumcodereview.appspot.com/11186004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162309 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
views::Label control first calculates the size of the text, and then tries to render the text in the exact size of rectangle. If < is used instead of <= in the patched line, the control flows to the BreakIterator mode, that sometimes computes a larger width value and causes truncation. BUG=155663 Review URL: https://codereview.chromium.org/11150013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162308 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
don't reference an element that doesn't exist. A button was removed in r160703, but it was still listed as an "associated control" for search, so that during search NULL was derefed. BUG=155364 Review URL: https://codereview.chromium.org/11193013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162307 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
I don't know what has caused the recent regression, but this fixes it. The position of the close button is not consistent between windows and mac, I chose to follow mac. BUG=none Review URL: https://codereview.chromium.org/11034002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162306 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
TBR=bruening@chromium.org Review URL: https://codereview.chromium.org/11186015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162305 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=139258 Review URL: https://codereview.chromium.org/10920084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162304 0039d316-1c4b-4281-b951-d872f2087c98
-
nduca@chromium.org authored
BUG=154343 NOTRY=True Review URL: https://chromiumcodereview.appspot.com/11142035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162303 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
We can't enable DEP at launch prior to Win7, but we can queue an APC to enable immediately after the loader finishes. BUG=147752 Review URL: https://chromiumcodereview.appspot.com/10944015 TBR=jschuh@chromium.org Review URL: https://codereview.chromium.org/11194027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162300 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Split the existing GoogleURLTrackerInfoBarDelegate into two classes by adding a MapEntry class. The MapEntry represents all the metadata about a pending search. This means that the infobar delegate itself can now be created only when it's going to actually be added to a tab, just like other infobars. This is necessary for some cleanup I'm doing to infobar calling conventions and ownership. This also makes each individual class simpler than the old unified class. There are some other miscellaneous changes in here, like switching the test code magic numbers from int to intptr_t (safer for portability). BUG=none TEST=none TBR=sky Review URL: https://codereview.chromium.org/11114009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162298 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
This reverts commit 162296. (https://chromiumcodereview.appspot.com/11048044) TBR=danakj@chromium.org Review URL: https://codereview.chromium.org/11196014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162297 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
We can't compile-guard code and use DCHECK since it can be enabled at runtime. This removes all compile-time guards, and makes use of DCHECK instead of ASSERT. We use DCHECK_IS_ON() to early out and avoid extra work just for DCHECK where possible as well. This also replaces use of LOG_ERROR("Foo") with LOG(ERROR)<<"Foo"; R=enne,jamesr Review URL: https://chromiumcodereview.appspot.com/11048044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162296 0039d316-1c4b-4281-b951-d872f2087c98
-
cpu@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162295 0039d316-1c4b-4281-b951-d872f2087c98
-
jschuh@chromium.org authored
We can't enable DEP at launch prior to Win7, but we can queue an APC to enable immediately after the loader finishes. BUG=147752 Review URL: https://chromiumcodereview.appspot.com/10944015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162293 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
intended) instead of the upper left corner. TEST=see bug BUG=152727 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/11189002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162292 0039d316-1c4b-4281-b951-d872f2087c98
-
cpu@chromium.org authored
BUG=143646 TEST= mini_installer (with branding=chrome) builds Here is the error: t0\src>ninja -C out\Debug mini_installer [1/9] CXX obj\chrome_frame\npchrome_frame.chrome_tab.obj FAILED: ninja -t msvc -r . -o obj\chrome_frame\npchrome_frame.chrome_tab.obj -e environment.x86 -- cl.exe ... .. microsoft visual studio 11.0\vc\atlmfc\include\atlbase.h(2845) : error C2338: 'CAtlDllModuleT<T>' must be used with either _WINDLL or _USRDLL defined ..\microsoft visual studio 11.0\vc\atlmfc\include\atlbase.h(3298) : see reference to class template instantiation 'ATL::CAtlValidateModuleConfiguration<isDllModule,T>' being compiled with [ isDllModule=true, T=`anonymous-namespace'::ChromeTabModule ] t0\src\chrome_frame\chrome_tab.cc(98) : see reference to class template instantiation 'ATL::CAtlDllModuleT<T>' being compiled with [ T=`anonymous-namespace'::ChromeTabModule ] Review URL: https://codereview.chromium.org/11189018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162291 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
Attempt to reuse an existing Browser instance for application launches in Chrome on Windows 8 Metro mode. BUG=155388 R=mihaip Review URL: https://codereview.chromium.org/11191017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162290 0039d316-1c4b-4281-b951-d872f2087c98
-
phoglund@chromium.org authored
BUG= NOTRY=True Review URL: https://chromiumcodereview.appspot.com/11192013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162289 0039d316-1c4b-4281-b951-d872f2087c98
-
binji@chromium.org authored
Two scripts for now, one that lets you view the gstore directory structure (cribbed from Chrome), and another that lets you view the current naclsdk_manifest file (cribbed from OmahaProxy). They are installed to http://commondatastorage.googleapis.com/nativeclient-mirror/nacl/nacl_sdk/... BUG=none TBR=noelallen@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11192021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162288 0039d316-1c4b-4281-b951-d872f2087c98
-
rouslan@chromium.org authored
BUG=148615 TBR=jhawkins Review URL: https://chromiumcodereview.appspot.com/11044020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162287 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
BUG=155413 TEST=cc_unittests R=enne@chromium.org,jamesr@chromium.org Review URL: https://codereview.chromium.org/11145033 TBR=tfarina@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162286 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Oct, 2012 8 commits
-
-
tfarina@chromium.org authored
BUG=155413 TEST=cc_unittests R=enne@chromium.org,jamesr@chromium.org Review URL: https://codereview.chromium.org/11145033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162284 0039d316-1c4b-4281-b951-d872f2087c98
-
binji@chromium.org authored
BUG=none TBR=noelallen@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11185016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162283 0039d316-1c4b-4281-b951-d872f2087c98
-
binji@chromium.org authored
BUG=122229 NOTRY=true Review URL: https://codereview.chromium.org/11066105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162282 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=154451 TEST=cc_unittests R=enne@chromium.org,jamesr@chromium.org Review URL: https://codereview.chromium.org/11191018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162281 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@google.com authored
Just removing condition because 2008 is toast. BUG=143646 R=cpu@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/11184012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162280 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
If chrome in desktop mode on Windows 8 defers to Windows 8 metro chrome, then we only want to create a new window/incognito window is one does not exist. To achieve this we look at the startup url being opened and if it is the new tab page, then we attempt to find an existing browser window and activate it. For non Windows platforms and Windows desktop mode the behavior is unchanged. BUG=155134,155281 R=sky Review URL: https://codereview.chromium.org/11137031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162279 0039d316-1c4b-4281-b951-d872f2087c98
-
newt@chromium.org authored
These stubs are no longer needed. BUG=145783 Review URL: https://chromiumcodereview.appspot.com/11155027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162278 0039d316-1c4b-4281-b951-d872f2087c98
-
ericu@chromium.org authored
Error: /b/build/slave/Mac/build/src/remoting/base/resources_unittest.cc:8:10: fatalerror: 'remoting/base/string_resources.h' file not found #include "remoting/base/string_resources.h" ^ 1 error generated. The new common_resources.grd will be used for non-loalizeable resources, such as images. Review URL: https://chromiumcodereview.appspot.com/11087059 TBR=sergeyu@chromium.org Review URL: https://codereview.chromium.org/11194022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162277 0039d316-1c4b-4281-b951-d872f2087c98
-