GitLab

Relands parts of https://chromium-review.googlesource.com/c/chromium/src/+/1088754

headless tests can't run on the memory waterfall yet because of bug 844865.
This adds them to the linux clang tot bots. (They already run on the mac and win
clang tot bots, and on the main waterfall.)

TBR=kbr

Bug: 843511,843732
Change-Id: Iec20d59c425b9d847fa2d3f076f907b69ba0e795
Reviewed-on: https://chromium-review.googlesource.com/1093051Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565640}

The static member variable to keep track of whether the black overlay
is added can fail when we switch Activities while entering VR when the
black overlay is added.

In practice without other bugs this should be borderline impossible to
make happen, but it crops up now and again, like in the linked bug.

We should instead just track the overlay per-activity.

Bug: 850741
Change-Id: I8849786972f216d7b628e2c8938579261ecd66b6
Reviewed-on: https://chromium-review.googlesource.com/1091699Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565639}

This reverts commit 5a797379.

Reason for revert: Relanding without making lld failures critical for now (see https://crbug.com/849904).

Original change's description:
> Revert "Make generate_breakpad_symbols.py not silently ignore subprocess errors."
>
> This reverts commit 924c8465.
>
> Reason for revert: This appears to break the Android WebView bots.
>
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20WebView%20N%20%28dbg%29
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20WebView%20O%20(dbg)
>
> Traceback (most recent call last):
>   File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 327, in <module>
>     sys.exit(main())
>   File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 316, in main
>     deps = GetSharedLibraryDependencies(options, queue.pop(0), loader_path)
>   File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 151, in GetSharedLibraryDependencies
>     deps = GetSharedLibraryDependenciesLinux(binary)
>   File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 67, in GetSharedLibraryDependenciesLinux
>     ldd = subprocess.check_output(['ldd', binary])
>   File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/subprocess.py", line 219, in check_output
>     raise CalledProcessError(retcode, cmd, output=output)
>
> Original change's description:
> > Make generate_breakpad_symbols.py not silently ignore subprocess errors.
> >
> > GetCommandOuput() used to pipe stderr to /dev/null, and it ignored
> > the command's return code. Use check_output() to check the return
> > code, and keep stderr attached to parent's stderr.
> >
> > Also make breakpad_integration_test.py a bit simpler (this part is
> > supposed to be behavior-preserving.)
> >
> > Bug: 813163
> > Change-Id: I8c55d3da9fff3b944111c3e868121ac34bf65c17
> > Reviewed-on: https://chromium-review.googlesource.com/1086981
> > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#564531}
>
> TBR=thakis@chromium.org,jochen@chromium.org
>
> Change-Id: Iee5a81e9b7e9db21f1dda9bdc272d3392438f481
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 813163
> Reviewed-on: https://chromium-review.googlesource.com/1087871
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564707}

TBR=thakis@chromium.org,tedchoc@chromium.org,jochen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 813163,850055
Change-Id: I3b241dffac522af75c46dc1a7554bd954b2a8f57
Reviewed-on: https://chromium-review.googlesource.com/1092671
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565638}

Bug: 821815
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifc9c196dc725cda6e4b369473aefdfea284fd36f
Reviewed-on: https://chromium-review.googlesource.com/1089050Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Elodie Banel <lod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565637}

This is a follow-up to crrev.com/c/964448, which was committed before
a comment around this was addressed.

Bug: 849323
Change-Id: I5c6de00476424a566081a55b5bb2f2ef787c4cb6
TBR: tapted@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1092857
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565636}

- Removed cc::OrderedSimpleTaskRunner.
- Removed redundant test fixture.
- WTF::Bind --> base::BindOnce.

Bug: 841735
Change-Id: Iada37d1c7ad60149eb9a933b5968b6101a76bebc
Reviewed-on: https://chromium-review.googlesource.com/1092864
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565635}

Mark three tests as flaky:
http/tests/devtools/tracing/timeline-time/timeline-usertiming.js
http/tests/devtools/tracing/console-timeline.js
http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js

The underlying reason ist still unknown. More details and timeline in
the linked bug.

TBR=kozyatinskiy@chromium.org

Bug: 850892
Change-Id: I7fba9de0c12fc124ca3dd84875e796de677f976b
Reviewed-on: https://chromium-review.googlesource.com/1092854
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565634}

Bug: 841735
Change-Id: I3b3e808fc2537da93cdf460cbc1da2c0cdbe35d7
Reviewed-on: https://chromium-review.googlesource.com/1092743Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565633}

The stack indicates PrerenderManager::PeriodicCleanup() is being
called. PeriodicCleanup() is deleting a PrerenderContents. Deleting the
PrerenderContents is triggering a call PrerenderManager::GetPrerenderContents().

My suspicion is PeriodicCleanup() is calling clear() on a vector. The vector
contains std::unique_ptr<PrerenderContents>. It would appear the implementation
of vector::clear() destroys the entries, and *then* resets the size.
This means during destruction PrerenderManager::GetPrerenderContents() is
iterating over the vector that now contains deleted objects and we get a crash.

BUG=850489
TEST=none

Change-Id: I8472c577bfd583105abaebe32cec2d39b6fbcca1
Reviewed-on: https://chromium-review.googlesource.com/1091189Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565632}

Move key_silk_cases into the rendering folder and refactor classes to
inherit from RenderingStory.

Bug: 849392
Change-Id: Ibc4c5289c3c14b1dc8a990cc7e2156a45e93fce0
Reviewed-on: https://chromium-review.googlesource.com/1087569
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#565631}

It is not cancelable in the spec:
https://html.spec.whatwg.org/#history-traversal

Investigating behavior in Chrome, Edge, Firefox and Safari, it was
only cancelable in Chrome and Safari:
https://github.com/web-platform-tests/wpt/pull/11355#issuecomment-394696654

It doesn't actually make any sense to cancel it, so this is most
likely an historical accident.

Change-Id: I3982d4414d1214784a6d8af3b03ea7264ff93b48
Reviewed-on: https://chromium-review.googlesource.com/1087047
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565630}

This reverts commit eb3da872.

Reason for revert: Breaks downstream builder. See https://crbug.com/850916.

Original change's description:
> Android: Remove BuildHooksAndroidImpl from the main dex.
> 
> Removing the reference to BuildHooksAndroidImpl from BuildHooksAndroid
> shrinks the main dex by ~2000 methods for downstream targets.
> 
> Bug: 820570
> Change-Id: If4051f7a85e387129c65a7a5b927183b5b36bf65
> Reviewed-on: https://chromium-review.googlesource.com/1089625
> Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565305}

TBR=agrieve@chromium.org,estevenson@chromium.org

Change-Id: I2d5c807f6b4dfa0639a75ec665af4e494b765a48
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 820570, 850916
Reviewed-on: https://chromium-review.googlesource.com/1092971Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565629}

This CL is the first step: create new imagesets + 1 function to return the
correct image name.

Bug: 821815
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia2ce8dc327226857b3105605b23b5b220edb9ff6
Reviewed-on: https://chromium-review.googlesource.com/1088912
Commit-Queue: Elodie Banel <lod@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565628}

This CL hooks up the pieces to be able to read changes in team
drives as well as the users default change list.

Changes in this CL:
- Add team_drive_change_list_loaders when OnTeamDriveListLoaded is
  received.
- Poll all team drives when CheckForUpdates() is called.
- Fix fake_drive_service to read team drive lists correctly.
- Re-order default_corpus_change_list_loader to load resource metadata
  before loading team drives. This is to support the offline scenario
  where users can still browse the file system if it was already loaded.
- Enable team drives in file_system_unittest.
- Add the first test for reading from team drives in
  file_system_unittest. More to come in a followup to keep this CL
  a reasonable size.

Bug: 723955
Change-Id: I7dfab6549241d8a50b54461b41dcd8312875eb56
Reviewed-on: https://chromium-review.googlesource.com/1085667
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565627}

TBR=hinoka@chromium.org,efoo@chromium.org

Change-Id: I221e4bf2a14f2aa4b2d7cdefa4f210b7fdaa468e
Reviewed-on: https://chromium-review.googlesource.com/1092875Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565626}

KSV app registers ash specific window properties and sets up to
use MusPropertyMirrorAsh. ShelfWindowWatcher is then able to take
care of the rest.

Also make InternalAppWindowShelfController to ignore visibility
change for windows it does not observe. Otherwise, it crashes
when it attempts to manage the content window from KSV app.

Bug: 848884
Change-Id: Ib9c1e46eb3f39bdda4e66529d0497a4ef775b80f
Reviewed-on: https://chromium-review.googlesource.com/1091799Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565625}

When a method has the @TraceEvent annotation, it will be transformed to include
TraceEvent.begin() and TraceEvent.end() at the start and end of the method.
The function body is moved to a new helper method, while the old function's new
body looks like the following:
```
TraceEvent.begin("Foo.bar");
try {
    wrappedByTraceEvent$bar();
    TraceEvent.end("Foo.bar");
} catch (Throwable e) {
    TraceEvent.end("Foo.bar");
    throw e;
}
```

Used the following code to test building various methods:
```
@TraceEvent
public static void basic() {}

@TraceEvent
public void takesArguments(boolean arg1, long arg2, float arg3) {}

@TraceEvent
public int returnsPrimitive(int arg1, byte arg2, Object arg3, TraceEvent arg4) {
    return 10;
}

@TraceEvent
public Object returnsObject(char arg1, short arg2, double arg3) {
    return null;
}

@TraceEvent
public int throwsError() throws Exception {
    throw new Exception();
}
```

Bug: 818267
Change-Id: I11127203662bf84de4a890da29a09676e760e621
Reviewed-on: https://chromium-review.googlesource.com/1066173
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565624}

Password Manager keeps the map from WebFormControlElement to last
non-JavaScript value in FieldValueAndPropertiesMaskMap. That's bad from
memory consumption perspective since it keeps input elements in memory
even if they were removed from DOM (and WebFormControlElement keep
s whole WebForm). Now we have reliable mechanism - unique renderer ids,
which might be used instead of WebFormControlElement. This CL replaces
usages of WebFormControlElement with unique renderer ids.

Also this CL contains small clean-up in password_autofill_agent.h:
removing not used typedef and typedef to using conversion.

Bug: 831123, 734427
Change-Id: I12a7b53859fccb9c5398997c61250ccf1a4f5c89
Reviewed-on: https://chromium-review.googlesource.com/1085460
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565623}

Opening omnibox context menu when clipboard contains over 32K characters caused chrome to freeze up for ~1 minute.
Other performance issues remain outside of the 'is paste & go allowed' checking and large clipboard sizes (.5 - 1 million characters) still cause freezing for ~10 seconds.

Bug: 277732
Change-Id: I7d130ef4e1668f6e73b2c670143ed69f7309cc6d
Reviewed-on: https://chromium-review.googlesource.com/1089193
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565622}

With https://crrev.com/c/1070158, base::Bind() supports
block via base::RetainBlock(). Converts uses of the now
deprecated base::BindBlock().

Bug: 701275
Change-Id: I759e9bc6d62b933463602ccc3b574be3b47c918b
Reviewed-on: https://chromium-review.googlesource.com/1092572Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565621}

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I24309dd123c90af3ca4ca94edd9bdedf932d22d4
Reviewed-on: https://chromium-review.googlesource.com/1090994Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565620}

BUG=chromium:843177
TEST=FakeAuthPolicyClientTest.WaitForServiceToBeAvailableCalled
TBR=alemate@chromium.org,pmarko@chromium.org

Change-Id: I83004c7a4910d96dd9b71849326dd2c92186692a
Reviewed-on: https://chromium-review.googlesource.com/1060053
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565619}

This CL replaces ApiCompatibilityUtils.getColorStateList with
AppCompatResources.getColorStateList from Android support library.

Bug: 727723
Change-Id: I26f4fa3149a9b87bfd150c0d3eb93b16568bfd0d
Reviewed-on: https://chromium-review.googlesource.com/1087052
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565618}

EventTiming cares about the following types, according to
https://github.com/wicg/event-timing.

* MouseEvents
* PointerEvents
* TouchEvents
* KeyboardEvents
* WheelEvents
* InputEvents
* CompositionEvents

For this reason, this CL is to filter out events other than these.

Bug: 823744
Change-Id: I5491d15256ca72ac7d22f1e547ce65851c0493a0
Reviewed-on: https://chromium-review.googlesource.com/1087798
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565617}

Bug: 841735
Change-Id: I0c385ce6bdd147b859a553e0bcf820adf379fd71
Reviewed-on: https://chromium-review.googlesource.com/1092742Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565616}

One of IdentityProvider's clients' use cases is to invalidate access
tokens for the active account. IdentityProvider currently provides no
explicit mechanism for this, instead letting clients directly interact
with the underlying OAuth2TokenService instance via GetTokenService().
However, it's necessary to decouple IdentityProvider from
OAuth2TokenService at an interface level in order to allow for porting
ProfileIdentityProvider to be backed by IdentityManager.

This CL adds an explicit interface for clients of IdentityProvider to
invalidate access tokens for the active account. This interface is
currently implemented directly in IdentityProvider itself, as it is
common to ProfileIdentityProvider and DeviceIdentityProvider. Before
porting ProfileIdentityProvider to be backed by IdentityManager we
will move this implementation out into those two derived classes,
temporarily duplicating it. However, we will only do that when we are
just at the point of porting ProfileIdentityProvider away from using
ProfileOAuth2TokenService.

This CL finishes eliminating the exposure of OAuth2TokenService to
IdentityProvider clients. The next step is to decouple the
IdentityProvider implementation itself from the token service.

Bug: 809452
Change-Id: Idf3d2b35fa88b5b96dfb7204268e298222032d3d
Reviewed-on: https://chromium-review.googlesource.com/1089056Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565615}

The example value formatting code in ADML writer only depends on the
example value itself right now. However, depending on the UI the user
is shown, example values should be shown in different ways. In
particular, it depends if the user is shown a listbox, or a textbox.
This CL shows different example values in different ways,
depending on the UI that the user is shown. Details follow:

If the user needs to input the following list of dicts:
[
  {"key1": "value1" },
  {"key2": "value2" },
  {"key3": "value3" }
]

Then that is exactly what they should type if they are shown a
textbox. But if they are shown a listbox, they should instead type:
{"key1": "value1" }
{"key2": "value2" }
{"key3": "value3" }

And each entry should be in its own listbox field. In other words,
when a user uses a listbox, they don't need to describe the outermost
list because the listbox takes care of it. So, we don't need to show
it in the example value either.

Similarly if the user needs to input the following list of strings:
[
  "value1",
  "value2",
  "value3"
]

They would also type that into a textbox, but would only need to
type the following into a listbox:
value1
value2
value3

So the string quotes are also made unnecessary by the listbox, and
so also should not be shown in the example value.

Bug: 829329
Change-Id: Iea994c219f1399d83a64af86f3679f991e46f5a6
Reviewed-on: https://chromium-review.googlesource.com/1090918
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565614}

ListMarker won't be shown under these two situation:
1. We update marker text in WillCollectInlines(), it won't be called
when ListItem isn't ChildrenInline. Call WillCollectInlines() manually
if ListItem only has block children.
2. If marker isn't the child of LI, both LI and marker_parent won't paint
marker. So make marker as a direct child of LI.

Bug: 715288
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I994fc9980c73cf00f983142d86b4ba49687d72f6
Reviewed-on: https://chromium-review.googlesource.com/1088333Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: cathie chen <cathiechen@tencent.com>
Cr-Commit-Position: refs/heads/master@{#565613}

This CL brings consistency to "http://schemas.android.com/apk/res-auto"
XML namespace declarations. Before, these declarations used different
prefixes: 'xmlns:app', 'xmlns:chrome', 'xmlns:settings' and
'xmlns:tools' (sorted in decreasing popularity order). This CL changes
all these declarations to use 'app' prefix.
Presubmit check to enforce this consistency will be added in
subsequent CL.

Bug: 850616
Change-Id: Icc1e1305c583906a8bb0b47965c0c5dcd3e3612c
Reviewed-on: https://chromium-review.googlesource.com/1091192
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565612}

Now LocalDOMWindow::event_queue_ is no longer used by IndexedDB, the
task type doesn't have to be 'kUnthrottled'. This was the last one usage
of kUnthrottled and we can remove this now.

Bug: 836410, 846618
Change-Id: Ifb5913d93a36cc6f8a5f645c6ecbf0016e424ad4
Reviewed-on: https://chromium-review.googlesource.com/1092225Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565611}

Probably an unintentional paste.
Introduced by https://chromium-review.googlesource.com/1080985

TBR=atotic@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ie937b6886ed2ff0301d192354f0e7bc64b012453
Reviewed-on: https://chromium-review.googlesource.com/1092691
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565610}

This CL is needed to make the preconnect predictor work with the Network
Service. The CL removes the LoadingPredictorObserver class that has been
notified by the ChromeResourceDispatcherHostDelegate and introduces instead the
LoadingPredictorTabHelper which implements the WebContentsObserver to notify
the predictor about resource loads.

All uses of the net::URLRequest and predictors::URLRequestSummary was replaced
by using the predictors::NavigationID or the content::mojom::ResourceLoadInfo.

The WebContentsObserver::ResourceLoadComplete() should work with and
without the Network Service, so we don't have to keep the old path.

Bug: 809583
Change-Id: I05c0aa97cfab1d773285633e6c5c3ef6a91367ca
Reviewed-on: https://chromium-review.googlesource.com/1039526
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565609}

This reverts commit c6e6fea4.

Reason for revert: Breaks WebRTC tests.

Original change's description:
> Setting dcheck_always_on for all chromium.webrtc.fyi bots.
> 
> We recently discovered DCHECK errors when WebRTC was rolling into
> Chromium, but they should have been caught by the chromium.webrtc.fyi
> waterfall.
> 
> Using dcheck_always_on in chromium.webrtc.fyi seems a good idea to
> reduce this kind of failures.
> 
> Bug: None
> Change-Id: Ibab78987f83cbacf2583c2a081b28082171c105b
> Reviewed-on: https://chromium-review.googlesource.com/1065733
> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Patrik Höglund <phoglund@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565580}

TBR=phoglund@chromium.org,dpranke@chromium.org,mbonadei@chromium.org

Change-Id: Ibf20c38a4e79ea5a21264bd5c6d09440044eb1c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/1092713Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565608}

Implement an initial MVP of the modal dialog that is shown during
WebAuthn requests. See the screenshot here: crbug.com/849323#c2.

The dialog is not yet interactive, even the `x` button does not yet
cancel the WebAuthn request (it does hide the dialog).

Bug: 849323
Change-Id: I3e1d9148f0727e33fb54e9bd1b747b84caa3c827
Reviewed-on: https://chromium-review.googlesource.com/964448
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565607}

https://chromium.googlesource.com/angle/angle.git/+log/81970bc..4b06c1e


git log 81970bc..4b06c1e --date=short --no-merges --format='%ad %ae %s'
2018-06-08 jiajia.qin@intel.com Add a test to expose boolean uniform bug on Intel windows


Created with:
  gclient setdep -r src/third_party/angle@4b06c1e

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:843369
TBR=geofflang@chromium.org

Change-Id: Idd424c050f3de1bd4b8bc9ae1c5330c210b67bba
Reviewed-on: https://chromium-review.googlesource.com/1092590Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565606}

Currently, you get CSSUnparsedValues when iterating entries on the
.computedStyleMap(), even for properties which are registered with a
type. However, if you do .computedStyleMap().get(...) with a registered
property, you _do_ get the correct type.

This is because ComputedStyleCSSValueMapping::Get properly looks up the
typed values on the ComputedStyle, but ::GetVariables does not; instead it
directly returns the CSSVariableData for everything, regardless of
registrations.

This patch changes the behavior of iteration to use the same code path
as .get(). This ensures that we either create a CSSCustomProperty-
Declaration on the fly for unregistered properties, or we re-use the
existing (and typed) CSSValue for registered properties.

Note: I initially wanted to do a nested iterator thing here, but dropped
      it because we would anyway need a temp HashSet to avoid potential
      duplicates from the StyleInheritedVariables-root.

Note: One caller of GetVariables() just wants the size. It's possibly a
      little overkill to create entire HashMap just to count something,
      but I don't want to resolve that here in the same patch.

R=futhark@chromium.org, haraken@chromium.org

Bug: 850072
Change-Id: I64bfb3cc22a377cf956420a9e64d47ca3daac1e2
Reviewed-on: https://chromium-review.googlesource.com/1090848Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565605}

Using wpt-import in Chromium 0798fbc3.
With Chromium commits locally applied on WPT:
e8832df8 "webrtc wpt: remove test_state_change_event"
fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests."
c220be7c "Fire RTCPeerConnection.onsignalingstatechange in the correct order."
4049f639 "[LayoutNG] Orthogonal flows need available inline size for min/max calculation."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19206

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=foolip

No-Export: true
Change-Id: I6ce9e1a0602b15eb19b18ac6609b447597be7753
Reviewed-on: https://chromium-review.googlesource.com/1092512
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565604}

Verified fix using a BrowserTest.

Verifying the fix properly meant fleshing out FakeConciergeClient with
settable response protos for all methods.

Found an invalid DCHECK of |state_| in CrostiniInstallerView when testing.

Guard CrostiniRestarterService::Abort.
There used to be a DCHECK, but it shouldn't be. It is a legitimate possibility
to cancel the install flow right when the the container startup was complete.

Bug: 850281
Change-Id: I0cf6bcef1f4f043d9c7e40f3a8baa458fb6f6ba7
Reviewed-on: https://chromium-review.googlesource.com/1089600Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565603}

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I67ba4fa23bebfb13d48791e089618907350c96e1
Reviewed-on: https://chromium-review.googlesource.com/1085061
Commit-Queue: Eric Noyau <noyau@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565602}

The remapping is no longer needed after
https://chromium-review.googlesource.com/1074750, which guarantees that
session IDs do not collide across restarts of the browser.

This reduces the number of IO operations, makes the sync protocol itself
more robust, and greatly simplifies a code that is believed to be
problematic.

Bug: 823798
Change-Id: I6f9192bdb1c2860136279d918e575748dd4e48af
Reviewed-on: https://chromium-review.googlesource.com/1086944
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565601}