GitLab

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/571373002

Cr-Commit-Position: refs/heads/master@{#295093}

Blink now has methods that don't take the rect out-param so use those.
Then we can delete the old methods with the out-param in blink.

R=vmpstr
BUG=413479

Review URL: https://codereview.chromium.org/572873005

Cr-Commit-Position: refs/heads/master@{#295092}

For apps v1, authentication involves navigating away from the app and
then back again, so loading browser_test.js before authentication doesn't
work. I don't know why this is a recent regression though--AFAICT it should
have been failing from day 1.

BUG=414498

Review URL: https://codereview.chromium.org/571273002

Cr-Commit-Position: refs/heads/master@{#295091}

Blink CL https://codereview.chromium.org/559423002/ depends on this.

BUG=406094

Review URL: https://codereview.chromium.org/564423002

Cr-Commit-Position: refs/heads/master@{#295090}

NESTABLE_ASYNC APIs
(https://codereview.chromium.org/536503002/) to log NetLog
entries in Tracing. This CL is a part of the effort to get
NetLog data into Tracing.

Design Doc:
https://docs.google.com/document/d/1Z2uqj59UEts5IiXX78mkdU4kd6e7kE3JUKPoDK97bVs/edit?usp=sharing

BUG=399701

Review URL: https://codereview.chromium.org/468083004

Cr-Commit-Position: refs/heads/master@{#295089}

While installing on non-ubuntu systems, the shell script,
build/install-build-deps.sh has an option '--unsupported' to override
the system checks. The same is not applied while installing the android
deps. The parameters to install-build-deps-android.sh should be passed
on to install-build-deps.sh.

R=thakis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/578503002

Cr-Commit-Position: refs/heads/master@{#295088}

This refactor will allow some manifest tests running in Chrome's unit_tests
suite to move to the extensions_unittests suite.

* Rename ExtensionManifestTest to extensions::ManifestTest and move it into
  src/extensions.
* Introduce ChromeManifestTest to load manifests from Chrome's test data dir.
* Eliminate some unnecessary use of chrome::VersionInfo::Channel.
* Move SharedModuleManifestTest to extensions_unittests as an example.

FileHandlerManifestTest and ExternallyConnectableManifestTest will be next,
but require more refactoring (e.g. of permissions).

BUG=397165
TEST=unit_tests, extensions_unittests

Review URL: https://codereview.chromium.org/572813002

Cr-Commit-Position: refs/heads/master@{#295087}

BUG=411260

Review URL: https://codereview.chromium.org/578593002

Cr-Commit-Position: refs/heads/master@{#295086}

This can be used from the renderer process or the browser
process. Requesting the manifest can be done via one call, a
callback has to be passed and will run with the manifest
passed as parameter. A failure will return the empty
manifest.

Some more logic could be added like caching the manifest in
the browser process or keeping track of the manifest dirty
state in the browser process but those things can be added
transparently later.

BUG=366145

Review URL: https://codereview.chromium.org/537053002

Cr-Commit-Position: refs/heads/master@{#295085}

Changing in the intialization order of WeakPtrFactory in src/components module
such that all member variables should appear before the WeakPtrFactory
to ensure that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/573623002

Cr-Commit-Position: refs/heads/master@{#295084}

Partial revert of android_webview: stop using system ICU. (patchset #1 id:1 of https://codereview.chromium.org/541753002/)

Reason for revert:
We can't accept this size increase at present; revert until we've worked out what to do about it.

Original issue's description:
> android_webview: stop using system ICU.
>
> To support unbundled updates we need to stop depending on system
> libraries. Disable using the system version of ICU and instead link
> Chromium's copy.
>
> This increases binary size by ~7MB.
>
> BUG=409851
>
> Committed: https://crrev.com/48e43572c0bfef2b1434d7f330da86cc7770b592
> Cr-Commit-Position: refs/heads/master@{#293510}

BUG=409851

Review URL: https://codereview.chromium.org/570383002

Cr-Commit-Position: refs/heads/master@{#295083}

BUG=none
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/574023002

Cr-Commit-Position: refs/heads/master@{#295082}

BUG=414120
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/564353002

Cr-Commit-Position: refs/heads/master@{#295081}

R=asvitkine@chromium.org,hpayer@chromium.org
BUG=397026
NOTRY=true

Review URL: https://codereview.chromium.org/556953005

Cr-Commit-Position: refs/heads/master@{#295080}

Pardon the dust. This is a large, huge, massive CL. This puts gitiles
in a mostly working state with auth. A hard requirement for this is
to make the periodic content update process work, and because gitiles
is so drastically slow compared to SVN, this meant breaking up the
Cron tasks into many small subtasks.

More work to follow, but this should allow us to get a live server
up and running ASAP.

BUG=404239
NOTRY=True
TBR=ahernandez.miralles@gmail.com

Review URL: https://codereview.chromium.org/575613003

Cr-Commit-Position: refs/heads/master@{#295079}

BUG=414433

Review URL: https://codereview.chromium.org/566233004

Cr-Commit-Position: refs/heads/master@{#295078}

BUG=371692

Review URL: https://codereview.chromium.org/563773003

Cr-Commit-Position: refs/heads/master@{#295077}

It likely shows at startup and we have complaints about people not being able to read it before it goes away (probably due to the focus-storm at startup).

BUG=None

Review URL: https://codereview.chromium.org/573963004

Cr-Commit-Position: refs/heads/master@{#295076}

BUG=355572

Review URL: https://codereview.chromium.org/544173006

Cr-Commit-Position: refs/heads/master@{#295075}

This test verifies that the build and patch directives in the
Chrome-Proxy header are used as expected by the data reduction
proxy.

BUG=409936

Review URL: https://codereview.chromium.org/544463002

Cr-Commit-Position: refs/heads/master@{#295074}

This CL moves a bit of translate logic from chrome/ to the translate
component.

Some IPC messages are still forwarded to chrome (through
ContentTranslateDriver::Observer) because of translate notifications.
This is temporary though, because once translate notifications are
removed, ChromeTranslateClient will no longer need to be an Observer.

Another motivation for this change is that the renderer-side of translate
IPC (TranslateHelper) is moving to the component (in another CL),
and thus the browser-side has to move too for consistency (this CL).

BUG=335087
TBR=msw

Review URL: https://codereview.chromium.org/564743002

Cr-Commit-Position: refs/heads/master@{#295073}

https://chromium.googlesource.com/chromium/blink/+log/66ed8adeb9fe3f69835e1eaa53048146e3a6b4de..8cc576a35676fa4829ee37d9d40e791354e16df1
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/570363002

Cr-Commit-Position: refs/heads/master@{#295072}

Blink is about to use blink_resources.grd for the inline resources of user agent stylesheets.
This removes the dependency upon using make-file-arrays.py which embeds these resources as strings.

This patch instantiates TestContentClient which does all the plumbing required for various test targets in content.
As the resources are being moved into blink_resources.grd, this generates blink_resources.pak.
This pak doesn't exists as a separate pak file but its repacked into "content_shell.pak".

This blink side changes were reverted here https://codereview.chromium.org/567073004/

The reason for reverting: Breaking quite a few browser_tests and content_browsertests across multiple platforms.

BUG=312586

Review URL: https://codereview.chromium.org/567153002

Cr-Commit-Position: refs/heads/master@{#295071}

BUG=414675
TBR=nasko@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/571403003

Cr-Commit-Position: refs/heads/master@{#295070}

BUG=407853
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/566423002

Cr-Commit-Position: refs/heads/master@{#295069}

https://skia.googlesource.com/skia/+log/9564ce60a657acce89fb956deb8645b324eaad1e..8ddbe8b9366c8c59c4fb55f01f253de8a0b37d6e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/572313002

Cr-Commit-Position: refs/heads/master@{#295068}

Delete support for TYPE_MALWARE_AND_PHISHING, since the warning now
always shows the malware warning if it's both.

BUG=
R=mattm@chromium.org

Review URL: https://codereview.chromium.org/572023003

Cr-Commit-Position: refs/heads/master@{#295067}

This will make sure that the handlers are set at the correct point
during v8::Isolate construction

BUG=none
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/567343002

Cr-Commit-Position: refs/heads/master@{#295066}

The phishing warning no longer supports error reporting. This CL deletes
the dead code associated with the error reports.

BUG=
R=mattm@chromium.org

Review URL: https://codereview.chromium.org/575723002

Cr-Commit-Position: refs/heads/master@{#295065}

This is something I missed in https://codereview.chromium.org/532023003

BUG=413116
TEST=Go to chrome://settings and create a new profile. You should not be
able to save a name that's all spaces.

Review URL: https://codereview.chromium.org/562233002

Cr-Commit-Position: refs/heads/master@{#295064}

BUG=411010
TEST=build/android/test_runner.py instrumentation --test-apk=CronetSampleTest -f *Quic*

Review URL: https://codereview.chromium.org/544223003

Cr-Commit-Position: refs/heads/master@{#295063}

BUG=379943
TBR=pilgrim@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/579433003

Cr-Commit-Position: refs/heads/master@{#295062}

https://chromium.googlesource.com/chromium/blink/+log/26493148691a7a4789d195c90a2ad49f8b098ba5..66ed8adeb9fe3f69835e1eaa53048146e3a6b4de
TBR=loislo@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/572263002

Cr-Commit-Position: refs/heads/master@{#295061}

BUG=400490
TBR=ananta@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/550393003

Cr-Commit-Position: refs/heads/master@{#295060}

This is an alternate way of achieving the same as https://crrev.com/568093002.
In this version, instead of calling ToEventParametersCallback to get a
callable, then passing it around, then calling it, the body of
SourceEventParametersCallback is duplicated in NetLogSpdyInitializedCallback.
This yields faster, simpler, more direct code, at the expense of code
duplication.

Only one of this CL and https://crrev.com/568093002 should be committed.

BUG=413369

Review URL: https://codereview.chromium.org/567403002

Cr-Commit-Position: refs/heads/master@{#295059}

https://skia.googlesource.com/skia/+log/49005bf8929dd8ca86431e13414d683b509cd538..9564ce60a657acce89fb956deb8645b324eaad1e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/578553003

Cr-Commit-Position: refs/heads/master@{#295058}

Add a PRESUBMIT check to verify that all prebuilts are actually
deployed to GCS (i.e. the committer didn't forget to run
upload_to_google_storage.py).

BUG=340294
NOTRY=true

Review URL: https://codereview.chromium.org/562553003

Cr-Commit-Position: refs/heads/master@{#295057}

UI state of the elements related to channel switcher should depend only on update status, current and target channels, not on the internal state which is reset each time chrome://help is reloaded.

BUG=323530
TEST=manual tests on a falco device

Review URL: https://codereview.chromium.org/565903002

Cr-Commit-Position: refs/heads/master@{#295056}

The account reconcilor uses the canonicalized emails to look up accounts
in the ProfileOAuth2TokenService.
This CL canonicalizes the authenticated username when the sign-in manager
initializes for backward compability.

TEST=Also regression test to check that nothing breaks for pre-SSO signed
in users.

BUG=394355

Review URL: https://codereview.chromium.org/413453002

Cr-Commit-Position: refs/heads/master@{#295055}

- mark obsolete histograms as such
- update descriptions and owners for current histograms
- add missing histograms

BUG=none
R=asvitkine@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/563853003

Cr-Commit-Position: refs/heads/master@{#295054}