- 15 Mar, 2019 40 commits
-
-
Rune Lillesveen authored
Also add the plumbing to pass it into blink. Bug: 889087, 925935 Change-Id: I5027a1fc30b14f77423b33ac9e85ba5697a95b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522246Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#641115}
-
Cathy Li authored
and allow the new touchless suggestions files to depend on TileView Bug: 936050 Change-Id: Ib611b788b532a72a8fce6e8b982c4e288b91408b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518251Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#641114}
-
Takashi Toyoshima authored
CORS preflight cache wasn't skipped regardless of the load_flags, but with this change, it is skipped if the original request has one of flags that want to skip caches. Also, we do not store results to the cache if net::LOAD_DISABLE_CACHE is specified. Bug: 941297 Change-Id: Ibf356949dd6267eb65faf650d76b0c5e58ce5d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520427Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#641113}
-
Christopher Lam authored
This CL extracts System Web App launch utilities into its own file as suggested in https://chromium-review.googlesource.com/c/chromium/src/+/1370239. It also changes the launch disposition for System Web Apps to CURRENT_TAB to correctly provide singleton behavior. Bug: 836128 Change-Id: Iefd691ed3a5c1f1858197599cff5282e22a254ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504603Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#641112}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddc3e674c3c0..824201d8b700 Created with: gclient setdep -r src-internal@824201d8b700 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:885919,chromium:885407,chromium:790659,chromium:790657,chromium:790654 TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: I879a1d976a1d86275f8c5c6044ab61ca3470c5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525460Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641111}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/58f92a13bcd8..5d06c3522353 git log 58f92a13bcd8..5d06c3522353 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 bpastene@chromium.org cros_test: Point Tast to the specified SSH key when running outside the chroot. 2019-03-15 dhanyaganesh@chromium.org GetSlaveStatuses: Split some callers off to GetBuildStatuses Created with: gclient setdep -r src/third_party/chromite@5d06c3522353 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I6abe9a1411ea4458a6f2c4aa6fede53f7f63063e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525459Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641110}
-
Yoshifumi Inoue authored
This patch changes to |NGAbstractInlineText::GetOrCreate()| to take only |NGPaintFragment| to avoid to create |NGAbstractInlineText| having |NGPaintFragment| not to associated to |line_layout_item_| member variable. These invalid |NGAbstractInlineText| causes crash by referring destructed |LayoutObject| in |NGAbstractInlineText::Detach()|. This crash can be happend in following scenario: 1. Create |NGAbstractInlineText| by |LayoutText::FirstAbstractInlineText()| with layout object L1 and fragment F1_1 then get A1(L1, F1) 2. Create |NGAbstractInlineText::NextOnLine()| with L1 and F2 then get A2(L1, F2) where F2 is associated to L2. 3. Destroy L1 then call Detach() for A1(L1, F1) => no problem 4. Destroy L2 then call Detach() for A2(L1, F2) => crash since L1 is destroyed Bug: 928925 Change-Id: Ic0a55b4e15723e1988d0727aba45723aed4d3a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525257 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#641109}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9284a7cf9ba6..bcb9892d16d3 git log 9284a7cf9ba6..bcb9892d16d3 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 tsepez@chromium.org Better bounds check in CFGAS_StringFormatter::GetCategory() 2019-03-14 tsepez@chromium.org Remove stringviews in cfgas_stringformatter.cpp, part2. 2019-03-14 tsepez@chromium.org Cache pattern span in xfa/fgas/crt/cfgas_stringformatter.h Created with: gclient setdep -r src/third_party/pdfium@bcb9892d16d3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0c57571b0ed4907cb09043a56f2fd4eead0c1998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525458Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/26b4a64918d4..04600b4f26bd git log 26b4a64918d4..04600b4f26bd --date=short --no-merges --format='%ad %ae %s' 2019-03-15 yyanagisawa@chromium.org Expose gclient_paths via InputAPI. 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@04600b4f26bd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:939959 TBR=agable@chromium.org Change-Id: If95206c72c9ede5ea741929d60535cd7e604a6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525457Reviewed-by:
-
Jan Krcal authored
This CL fixes a speculative bug in interaction between the wallet data bridge and the wallet metadata bridge. The bug occurs when the bridge deletes and re-creates a particular entity (because it is different than before). If these notifications are sent out in the wrong order (first ADD, then DELETE), we end up without the metadata entity. It is speculative because I am not sure that it can happen in reality that payments sends the same card with different data. Anyway, it feels safer to assume less. Bug: 928758 Change-Id: I74a2d6c68107fffdde18a69810828d629ca4e50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518575 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#641106}
-
Nico Weber authored
This is a reland of 889a9665 Original change's description: > Use DWARF4 for mac and ios simulator builds, use DWARF3 for ios device builds. > > Removes some special-case code and potentially makes debug info a bit smaller. > > Also stop passing -g2 to (non-pnacl) nacl compiles on mac, like already the case > on linux -- this helps with build determinism. > > Bug: 942155,899438,906741,429358 > Change-Id: Ic4c7138d232813e12426de2c161c78121bd3fc80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525041 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640963} TBR=mark Bug: 942155, 899438, 906741, 429358 Change-Id: I382c93c02eefd3cbbcf1d8df0670297319f3ac31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525415Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641105}
-
Hajime Hoshi authored
This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. The callback of GC in extensions executes JavaScript, but this callback is now executed on the default task runner. This CL replaces this with a per-frame task runner. Some tests hit this: e.g. extensions_browsertests --gtest_filter=WebViewAPITest.TestDialogConfirmDefaultGCCancel Bug: 870606 Change-Id: Ic1c2968a2e9e07629e7c117e1e1c4e97c2df0457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514516Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641104}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2fb6563bf503..de52ca373d98 git log 2fb6563bf503..de52ca373d98 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 syoussefi@chromium.org Vulkan: Fix GraphViz dump in presence of queries and fences Created with: gclient setdep -r src/third_party/angle@de52ca373d98 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Idf3d1a755fe66d8df1ceda4c9d5105a21c2da579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525456Reviewed-by:
-
Fergus Dall authored
This fixes a regression introduced by crrev.com/c/1472013, which leaves the flag that decides to show/hide the uninstaller uninitialized. Depending on the build, this may end up in the hiding state initially, rather then the showing state. This CL fixes the regression and adds automated testing to prevent reoccurence. Bug: 941865 Change-Id: I7dc2c3c770fc5fbef838d82c82f46c0717fb7ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522061 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
David Bokan authored
This early-out was added in: https://crrev.com/ce8ea3446283965c7eabab592cbffe223b1cf2bc Back then, we applied fragment focus in LayoutUpdated() which could cause this issue. This got cleaned up in: https://crrev.com/45236fd563e9df53dc45579be1f3d0b4784885a2 so that focus is no longer applied after layout. +Cleanup: Goto considered harmful Bug: 795381 Change-Id: Ifeb4d2e03e872fd48cca6720b1d4de36ad1ecbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524417 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#641101}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e545522146af..2ac348b5c0a5 git log e545522146af..2ac348b5c0a5 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 dneto@google.com Repair test for unused storage buffer with descriptor (#2436) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@2ac348b5c0a5 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I16aa5cb80a3747d3da5e2ab796951cb6bc65dbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525347Reviewed-by:
-
Adam Rice authored
Calling enqueue() on a TransformStream that was closed or errored would throw an exception with the message "Cannot read property 'Symbol(bit field for [[started]], [[closeRequested]], [[pulling]], [[pullAgain]])' of undefined". Fix the message. Also add a Chromium-specific test that the message is correct. BUG=941970 Change-Id: I690bfb909efe72a6ba6859dc886b37b2bda71ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523211Reviewed-by:
-
Xianzhu Wang authored
This is a reland of 54b17c7e The original CL called MutatorHost::InitClientAnimationState() before updating animations. The new CL calls it after updating animations. Not sure why the original CL caused flakiness of virtual/threaded/animations/hit-testing/composited-with-hit-testing.html, but the test is no longer flaky with this new CL. Original change's description: > [BGPT] Let cc initialize animation states in property nodes > > In this way, blink::PropertyTreeManager no longer needs to care about > the animation states. Now we initialize and change the states from a > single source to avoid duplicate code and inconsistency. > > Bug: 935770 > Change-Id: I7f98d66677f557213fd4559895e9c2069de196e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513922 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640892} TBR=flackr@chromium.org, pdr@chromium.org Bug: 935770 Change-Id: Icd7ec59b9e5b95f2c268baf88732788cde5da9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525449Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641098}
-
Antonio Gomes authored
Previously, the success and error callbacks in the various classes in [1] were either invoked immediately or scheduled to run depending on the execution context's task runner. Lately, according to offline conversations with mek@chromium.org, it is possible to get rid of the scheduling logic altogether because an earlier, change made it so that things like FilesystmeDispatcher::DidReadMetadata already run on a per-execution context task runner, and presumably they would already be scheduled properly. This CL implements that idea, as part of the effort to clean FileSystemCallbacks's implementation. It also greatly simplifies FileSystemCallbacksBase, which can be eliminated in a follow up CL with minimal effort. [1] //third_party/blink/renderer/modules/filesystem/file_system_callbacks.h R=mek@chromium.org CC=blink-reviews-vendor@chromium.org, dgozman@chromium.org BUG=933878 Change-Id: Ib446249bab8ac1c9d9f2e4d11340d258cbac1751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525101 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#641097}
-
Alexey Baskakov authored
This folder is an output for an experimental `-background-index` command line argument. Bug: None Change-Id: Iaa1db62f54d844d271b2c56a686cdad5117ebe74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524392Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#641096}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f4438d56e989..5366a45c6103 git log f4438d56e989..5366a45c6103 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9b156615197d..1b8cd2d9ce2c (1 commits) 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 brianosman@google.com Ganesh: Clamp blend inputs when using F16_Clamped pixel config 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader becb44f1177a..9b156615197d (1 commits) 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a2749f39f47d..becb44f1177a (1 commits) 2019-03-14 jvanverth@google.com Fix cached perspective shadows 2019-03-14 michaelludwig@google.com Blacklist compositor_quads_filter on chromecast 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader af973b67141e..a2749f39f47d (1 commits) 2019-03-14 bsalomon@google.com Clamp override color to bytes in GrFillRectOp when half float vertex 2019-03-14 kjlubick@google.com [canvaskit] Fallback to CPU more gracefully 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 37b996425a0e..979f3bbe2c50 (5 commits) 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@5366a45c6103 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/123261126 TBR=benjaminwagner@chromium.org Change-Id: Idff8f55d51703b5bf63f6ba0948b349c84dceedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525455Reviewed-by:
-
Abhijeet Kandalkar authored
The primary motivation is that the data member names are not following proper naming conventions within probe_sink.h.tmpl and instrumenting_probes_impl.cc.tmpl. This CL add to_snake_case function in make_instrumenting_probes.py to convert data members to snake case format. Bug: 936684 Change-Id: I9934aec12dfd85094335078f7c1784f56d6aafac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524801 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#641094}
-
Xianzhu Wang authored
- Skip virtual/binary-for-devtools/http/tests/devtools - Mark css3/masking/mask-composite-missing-image.html failing - Rebaseline 5 tests: - gradient, rounded edges and anti-alias differences - invalidation rect changes (no image failure) All because of base test rebaselines TBR=pdr@chromium.org Bug: 524134 Change-Id: I171f3eaff7e78649903441c142ebc9c25171ad2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525681Reviewed-by:
-
Kenichi Ishibashi authored
According to the flakiness dashboard it could take more than 10 sec on dbg build and 3 sec on release build. Mark it slow. Bug: 937378 Change-Id: I14fcd04a6d315a61f559fbc7a3cadf8ce2914dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525255 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641092}
-
Yoshisato Yanagisawa authored
Since we don't have "client"s in canary, let me remove that from the name. Also let me add an ios rule for the iOS latest builder. Bug: 874754 Change-Id: I46e1ec5d33f30caaa723184fdc7dea46f372de67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502892 Commit-Queue: smut <smut@google.com> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
smut <smut@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#641091}
-
Maksim Ivanov authored
These enums haven't been used by any code for a while. Also remove the corresponding dead histogram definitions. BUG=chromium:690733 TEST=existing tests Change-Id: I93b00807807e1869e5a7ab8daae277a07b6cf1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1425724Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#641090}
-
Jinsuk Kim authored
Preview (a.k.a Sneak Peek) panel needs to be closed on various events such as when a new tab is opened, or its base panel navigates, etc. This CL adds a couple of tab model observers to detect those events, and invokes |closePanel| accordingly. Bug: 940919 Change-Id: Ieee694db214ded1f031ac24db3586496d19bee42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519966 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#641089}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b58fe2ab9436..ddc3e674c3c0 Created with: gclient setdep -r src-internal@ddc3e674c3c0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:942176 TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: Id383f2517feb021d79065d9a527de04c7a36f81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525303Reviewed-by:
-
Luciano Pacheco authored
Re-sending CL: 1514005 based in the new strategy to make it non-flaky. Add more explicit waiting on checkContextMenu to wait for each entry to be displayed before trying to expand or click. Change-Id: Id7a6f9ea27d5bade800837480df79721dcab4329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524749 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#641087}
-
Pavel Feldman authored
Routes each message type into its own method. Change-Id: I8dacbc37d614794f6757d6b9c669fa751de5ab4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525263Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641086}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8f30a2e7. With Chromium commits locally applied on WPT: 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 2b037bdc "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ib7511d306d305de610cf7479d5f49531ba7c6d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524973Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641085}
-
kylechar authored
1. Remove all viz related tests from FYI bots on Linux, Windows and Mac. The feature has launched on those platforms and no longer needs special testing. 2. Remove all viz related tests from FYI bots on Android. The feature is default enabled on Android and will be launched before M75. Fixing regressions in the viz disabled case is no longer necessary. Bug: 730193, 732555 Change-Id: Idd01543bb059971152a168a279a2ebe56fcfa325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524870Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
-
Eliot Courtney authored
If the set bounds event was meant to be animated, and occurred during a drag, then it would trigger the DCHECK in SetMaximizedOrFullscreenBounds. Bug: 941017 Test: No DCHECK on finishing dragging a PIP window. Change-Id: I9ced916fa8f7eafbac2df232b3abe242a704a329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523126Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#641083}
-
Kelvin Jiang authored
This CL shows web request info for activities in the stream if provided (also shown in Chrome Apps & Extensions Developer Tool). The web request info is a JSON object and is found in chrome.activityLogPrivate.ExtensionActivity.other.webRequest Screenshot: https://imgur.com/a/ZdxqfBC Note: I'm not using any fancy styling/formatting here, as the keys in the web request object can be somewhat long and are variable in length. The objects don't seem to be very large and so the entire web request object is shown as a JSON string (see screenshot). Bug: 932768 Change-Id: Idc14b337e6cb953331a1988bf1cd675f381c30f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517142 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641082}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b271c06e57ba..9284a7cf9ba6 git log b271c06e57ba..9284a7cf9ba6 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 tsepez@chromium.org Avoid WideStringViews from constant strings in cfgas_stringformatter.cpp 2019-03-14 thestig@chromium.org Rename some variables in fpdf_edittext.cpp. 2019-03-14 thestig@chromium.org Split CFFL_InteractiveFormFiller::GetFormFiller() in two. 2019-03-14 thestig@chromium.org Use "bs" prefix for ByteStrings in cfxjse_formcalc_context.cpp. 2019-03-14 thestig@chromium.org Fix two XFA JS calls that trigger fatal errors in v8::FromJust(). 2019-03-14 tsepez@chromium.org Specify CFGAS_StringFormatter format at creation time. 2019-03-14 thestig@chromium.org Remove extra slashes in fxjs/BUILD.gn. 2019-03-14 thestig@chromium.org Mark CPDF_FontEncoding::Realize() as a const method. Created with: gclient setdep -r src/third_party/pdfium@9284a7cf9ba6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8dbaeebcedd68b9f5c472778f2b0b7ca8497cc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524970Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/69d4958ee9b3..58f92a13bcd8 git log 69d4958ee9b3..58f92a13bcd8 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 pprabhu@chromium.org config: Move {quawks,octopus,sentry}-paladin to Skylab 2019-03-14 dgarrett@google.com chromeos_config: Make buildspec builders internal. 2019-03-14 chrome-bot@chromium.org Update config settings by config-updater. 2019-03-14 dhanyaganesh@chromium.org PreCQLauncher: Revert the 1505981 CL 2019-03-14 saklein@chromium.org Build API: Add update sdk endpoint. Created with: gclient setdep -r src/third_party/chromite@58f92a13bcd8 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I97837336910a68acd7414b8b902ea4a530617c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525454Reviewed-by:
-
Charlie Reis authored
These should be removed once we have some data indicating how it is occurring in practice. BUG=931895 Change-Id: Ic8977b194892328a32d1db6f4492f9bb84938ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524835Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641079}
-
Adam Rice authored
The V8 extras TransformStream implementation will always produce a V8 extras ReadableStream and WritableStream, even if the StreamsNative feature is turned on. Since this breaks the expectation that a ReadableStream is always a ReadableStreamNative when we are using the new implementation, it can cause crashes. Prevent constructing a TransformStream when StreamsNative is enabled to prevent this issue. BUG=902633 Change-Id: I718b493f19db7a47bea9db0c5ffb7dd1d6d12e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523209Reviewed-by:
-
Chris Lu authored
optionalTextLabel always exists, but it does not always have text. Currently adds that empty string to the array used to construct the accessibilityValue. Now only add it to the returned string if there is text. Bug: 937016 Change-Id: I43d28777ed9ee872bebf741db985d49280b21c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525272Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#641077}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1c2fa0fdda12..26b4a64918d4 git log 1c2fa0fdda12..26b4a64918d4 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@26b4a64918d4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I39c632b13063d4aca963ef58c5182b16df45546a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525032Reviewed-by:
-
