- 29 Aug, 2019 40 commits
-
-
Khushal authored
There seems to be a race condition in the framework which results in a crash if we transition between SurfaceViews too soon at app startup. This change removes that to verify the theory. It was initially added to avoid additional color layers when we use video overlays with SurfaceControl, but its unclear what the cost of this is. For now, just remove the transition altogether and if it turns out that this is an issue we can try delaying the transition after startup. R=dtrainor@chromium.org Change-Id: I422a396aa3616773629933657dd1a5baf1341ce7 Bug: 998311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776906 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#691863}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/eb56ee5a28b4..565f1b848215 git log eb56ee5a28b4..565f1b848215 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 misterg@google.com Merge pull request #2398 from kuzkry:custom-type-traits-iterator_traits 2019-08-29 misterg@google.com Merge pull request #2420 from kuzkry:remove-autotools-section Created with: gclient setdep -r src/third_party/googletest/src@565f1b848215 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/googletest-chromium-autoroll Please CC isamsonov@google.com,staphany@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official TBR=isamsonov@google.com,staphany@google.com Bug: None Change-Id: I64aa93681d28db0a120f61c79000c7072a195fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775810Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691862}
-
Jenny Blessing authored
Button: https://screenshot.googleplex.com/QomEiR3L6as.png Confirmation dialog: https://screenshot.googleplex.com/txvwbkxyFBe.png Bug: 987177 Change-Id: Ib869fba73ea266f50bb0ea2fed0900c0e9268f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762210Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Jenny Blessing <jblessing@google.com> Cr-Commit-Position: refs/heads/master@{#691861}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68cb8b023920..165ca3f85b7a git log 68cb8b023920..165ca3f85b7a --date=short --no-merges --format='%ad %ae %s' 2019-08-29 fmalita@chromium.org [skottie] Text selector ease-high/ease-low support Created with: gclient setdep -r src/third_party/skia@165ca3f85b7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: Ib5f1996dc561236927f3cdf38fc4ec415a14b810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775835Reviewed-by:
-
Matt Mueller authored
By default, NetworkChangeNotifier creates a global SystemDnsConfigChangeNotifier which has a task_runner_ handle that ends up pointing to the base::test::TaskEnvironment that was created in the first NetworkChangeNotifierPosixTest which ran, and then the next such test ran in the same process crashes due to UAF. Bug: 999313 Change-Id: I497d6ab4a3a8c97f57ee935b83f1d5d0e17a1d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776724 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#691859}
-
K Moon authored
Refactors PDFiumEngine::AppendBlankPages() to leverage the layout code in LoadPageInfo(), instead of using a separate copy. AppendBlankPages() now ensures |PDFiumEngine::pages_| is in the right state for a later layout pass, rather than trying to compute all the layout up front when the new PDFiumPage instances are created. This duplication is particularly harmful because AppendBlankPages() is only called from print preview code paths, and so may be overlooked if not testing print previewing specifically. Also inlined PDFiumEngine::LoadPagesInCurrentLayout(), since this method is only used in one place (and we're trying to centralize layout), has simple logic, and will become much shorter once the two "compute layout" methods are merged together. Bug: 885110 Change-Id: Ic0ae2410ca930794beeb28983b9d0cc5e89284f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769708Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: K Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#691858}
-
Etienne Bergeron authored
This CL is adding the font_name to track the resulting font when performing an FontLink falllback. TRACE_EVENT_INSTANT1("ui", "RenderTextHarfBuzz::FallbackFont", TRACE_EVENT_SCOPE_THREAD, "font_name", TRACE_STR_COPY(font_name.c_str())); The goal is to determine when the FontLink is used and why. R=oysteine@chromium.org Bug: 995789 Change-Id: Ic47dfdd82e669f1ac38c04cef6ffdb2e9d02ecd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776879Reviewed-by:oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#691857}
-
Sergey Ulanov authored
Now WebEngine will enable Vulkan only when ContextFeatureFlags::VULKAN is specified for web::Context. Also Context process now explicitly disables hardware-accelerated compositing when VULKAN is not enabled (otherwise it restarts the GPU process several times before it falls back to software compositing). Bug: 962617, fuchsia:35009 Change-Id: I74a463a1514df99134d929981fe44151c1d9dd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774967 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#691856}
-
Kyle Horimoto authored
This CL loads the carrier page and handles any errors which may occur while interacting with it. Note that this CL makes use of a <webview>, so it modifies two JSON files to provide permission to chrome://cellular-setup to use that element. Bug: 991826 Change-Id: I6a3872dc5544ca387c01b9b4cb97bd7d1f4e9bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767601Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#691855}
-
Nigel Tao authored
The disk cache format (e.g. file names) is really a private implementation detail of the ArcAppListPrefs and ArcAppIcon classes. ArcAppIcon already consults the disk cache. The ArcApps class has been recently changed to use ArcAppIcon's, via an ArcIconOnceLoader. This commit is a small behavior change when the App Service is enabled, if the icon file was already in the cache. Before, there will be no icon ("an empty, transparent rectangle") until the file was decoded. After, there will be a placeholder icon (IDR_APP_DEFAULT_ICON) until the file was decoded. Either way, the "until the file was decoded" time (involving file I/O) can be visible to the naked eye, as a flash of the empty or placeholder icon until the real icon is loaded. But it isn't as long as e.g. the time taken to spin up an Android VM. If the icon file wasn't in the cache, IDR_APP_DEFAULT_ICON would be shown either way. Whether or not the "empty icon before real icon" or "IDR_APP_DEFAULT_ICON before real icon" behavior is preferable, the behavior after this commit (IDR_APP_DEFAULT_ICON) is more consistent when comparing the Android app icon behavior with the App Service enabled or disabled, although when enabled, less consistent when comparing Android and Linux (Crostini) app icon behavior. Anyway, keeping it an ArcAppIcon implementation detail is also arguably cleaner code. It's certainly a little less code (this commit is mostly deletion), and removes a "mapped app id" TODO. BUG=826982 Change-Id: I11f9f5d27061896005def458fe89f890e338e348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774005Reviewed-by:Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#691854}
-
Tricia Crichton authored
Refactor to remove duplicate code that connects to a page for several session types. Bug: chromedriver:2126 Change-Id: I37713cce11082fd28761018c71c69f3b400b1071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776798 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#691853}
-
Olivier Yiptong authored
One of the features SafeBrowsing requires for checks is whether or not there was user activation for the payload being scrutinized. This implements the retrieval of the User Activation Status at the time a FileWriter creation is requested from the renderer. Bug: 995974 Change-Id: I403723261f24787f7bd86aba2e54ad1bc088f323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771949 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#691852}
-
rajendrant authored
When the image is fully deferred (2kb range request is not fetched) the image is shown as broken image with ALT text, for a brief moment until the image is fetched. This CL shows a 1x1 translucent placeholder in that case. Bug: 999019 Change-Id: I523785ba7f4f4151a324895a4f8f7f612a7141cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773869Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#691851}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/324b391559e7..aae21ef6adf6 git log 324b391559e7..aae21ef6adf6 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 tobine@google.com Revert "Reland "Vulkan: Use VK repos' internal BUILD.gn files"" 2019-08-29 tobine@google.com Reland "Vulkan: Use VK repos' internal BUILD.gn files" 2019-08-29 geofflang@chromium.org Expand the TextureGL::releaseTexImage size reset workaround to Win AMD. 2019-08-29 syoussefi@chromium.org Vulkan: DispatchIndirect in graph dump output Created with: gclient setdep -r src/third_party/angle@aae21ef6adf6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: Ide88f6819ec4eaa9bd5b1dc0f7f75e6e0f170995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776960Reviewed-by:
-
Yusuf Sengul authored
Bug: 999020 Change-Id: If681cf59fba880b50a7f0c9e20603ad5704edc88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775232 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#691849}
-
Jamie Walch authored
https://chromium-review.googlesource.com/c/chromium/src/+/1773861 changed the top-level bundle name to end in .app, since .bundle names are not supported by the accessibility prefpane. However, it didn't go far enough, as although ChromeRemoteDesktopHost is the bundle named in the permissions prompt, it is the nested bundle, RemoteAssistanceHost, that needs to be whitelisted. This CL fixes this by renaming both the remote assistance and remote access native messaging components to end in .app (the latter is not necessary to fix this bug, but it shouldn't cause any problems and it makes them consistent). Users who upgrade Chrome to M78 and attempt to use remote assistance before installing this CRD update will end up in a broken state because the system will fail to whitelist the old RemoteAssistanceHost.bundle, but will remember prompting the user and so will not do so again when it is renamed to RemoteAssistanceHost.app. To avoid this, this CL also changes the signing identity for RemoteAssistanceHost.app, which will cause the system to ask for approval again. The signing identity for the remote access native messaging component is not changed, because it doesn't do anything that would cause it to be put onto any permissions list. Bug: 996993 Change-Id: If11ad4d2559e5a40f2f2b8c5ee98b630a976ac02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776699 Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#691848}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/28b633cd961b..3dd9de12f761 git log 28b633cd961b..3dd9de12f761 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 oysteine@google.com Merge "Added cpu_profile_stack_samples table to the trace_processor" Created with: gclient setdep -r src/third_party/perfetto@3dd9de12f761 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I369ddc3eddac73cb30448f14391498f27a4dc7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776958Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d28bb6a6a5c4..6431d3a8dd5f git log d28bb6a6a5c4..6431d3a8dd5f --date=short --no-merges --format='%ad %ae %s' 2019-08-29 saklein@chromium.org api/router.py: Cleanup unused methods, add tests. 2019-08-29 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@6431d3a8dd5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I781d0b739d729e4b0d7843931044740039c8a1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775817Reviewed-by:
-
Erik Chen authored
This makes goma cache hits more likely. This will break debugging unless people follow the new instrucitons at https://chromium.googlesource.com/chromium/src/+/HEAD/docs/lldbinit.md. The test runner now prints a message pointing to the new instructions, and I'll send an email heads-up to chromium-dev once this lands. This has no effect if enable_dsym is set, so this doesn't affect official builds. Bug: 330262 Change-Id: I1d829215f1a8ff3d4f071959e7c0364011799519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774272 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#691845}
-
Etienne Bergeron authored
This CL is changing the behavior of the ScopedThreadMayLoadLibraryOnBackgroundThread which is used to change the thread priority on a background thread when a library can be loaded. The previous implementation was boosting the priority for the scope of the class for each execution. This is overkill since the library is only loaded once. The proposition is to keep track of the executed program counters and to avoid to boost priority twice. R=gab@chromium.org, fdoray@chromium.org Bug: 973868 Change-Id: I8c2e9e18ac7e2b922437132051eb6702f83cefaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775730Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#691844}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8a6f1eb1b962..961b4af1ff28 git log 8a6f1eb1b962..961b4af1ff28 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 simonhatch@chromium.org Pinpoint - Add bisect menu w/ retry+edit Created with: gclient setdep -r src/third_party/catapult@961b4af1ff28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:992492 Change-Id: If85633108981220da04426287e05a187a04faba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775816Reviewed-by:
-
Ian Struiksma authored
autofill captured sites tests are flaky for 2 sites: Pandora, Payless These have varying cache requests keys, and need to fix cache key match behavior. Setting to expect FAIL for now. Bug: 996478 Change-Id: Iba1f7305c1f98e93d54bb8a8f7cd6cac42e13247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776607 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#691842}
-
Xing Liu authored
This test is failing on multiple builders. TBR=bajones@chromium.org Bug: 994720 Change-Id: I656c207acc63e5ee03d44422ff17ad47de8afccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776862Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691841}
-
Zhongyi Shi authored
Change-Id: I2e5d19d6cc3b87d9aa041b208ad1bde58f6fcbbd BUG: 999285 Change-Id: I2e5d19d6cc3b87d9aa041b208ad1bde58f6fcbbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772357Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#691840}
-
Erik Chen authored
The original CL would hit a DCHECK(false) even if the process was not being debugged. This caused unit tests to fail on bots. This CL fixes VerifyDebugger() to early return if there is no debugger. > Add support for lldbinit to macOS. > > The build-flag `strip_absolute_paths_from_debug_symbols = 1` produces > deterministic outputs and has better goma caching, but breaks lldb. This CL adds > machinery to help users get functional symbols in lldb while still using that > compile flag. > > Bug: 330262 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775227 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Auto-Submit: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691393} Change-Id: I4d4bd4412f78c68220a376af4b0260f7191e367a Bug: 330262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776604 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Lei Zhang authored
Use it in PrintBackendWin to simplify callers that do exactly the same thing. Change-Id: I8ffad95b1581d01f18b00122280c4dac5d0cfe5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769593Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#691838}
-
Nick Harper authored
Bug: 980654 Change-Id: I035f4edf159c9d949edd60118ac09c32bc3976dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772373 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Lucas Furukawa Gadani authored
These tests were broken by https://github.com/web-platform-tests/wpt/commit/38be30e734ea5afcdc5801613f197d17d716674d. Bug: 759184 Change-Id: I39a9bc3da1d5a955975ce35a3201613c4efba010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776600Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#691836}
-
Jinsuk Kim authored
The last item of gesture navigation sheet needs more space to match the UI guideline. This CL gives extra bottom padding to address it. A bit more value (navigation_sheet_content_wrap_padding) is necessary when the sheet wraps around the content (as opposed to when clipping the height to the half of the screen). Bug: 993036 Change-Id: I729a82866105d2c159f1597558c88d5ecda0d0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775681Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#691835}
-
rbpotter authored
- Autogenerate Polymer 3 version of cr-radio-button and its style and behavior - Add closure targets - Autogenerate and run cr-radio-button automated tests with Polymer 3 - Add to demo page Bug: 965770 Change-Id: Ie625c10ad8776d4875dd1202bca8a0b788bf3bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773746Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#691834}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e26413128902..68cb8b023920 git log e26413128902..68cb8b023920 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 jvanverth@google.com Switch to new IOS windowing system. Created with: gclient setdep -r src/third_party/skia@68cb8b023920 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: Ie9d167f775165c7f08c1b462327a92f84823f77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776722Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b56e461a7ced..bad3985ba95f Created with: gclient setdep -r src-internal@bad3985ba95f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4a0060de53c62a4baa3e4d409de5614608df35ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775812Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691832}
-
siyua authored
Uploaded new screenshot in bug comment 8 Bug: 991037 Change-Id: Id794f6b666a7cc07f4d4f13b278f3639b9ad4e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772390 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#691831}
-
Max Moroz authored
Bug: 539572, 997940 Change-Id: Id50533d93acbd60c47cf3dd185a2d0c40d8d2149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776487 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#691830}
-
Ella Ge authored
This CL adds the PointerLockOptions and unadjustedMovement and related flags. The usage of the options is going to be added in the following CLs. spec proposal: https://github.com/w3c/pointerlock/pull/49/ I2I: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/qZ_STHiTDzU Bug: 982379 Change-Id: I4662b72005b99bf5775b3e68363b0b2ebb8a2c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764943Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#691829}
-
Sergey Ulanov authored
Now WebRunner and CastRunner send appropriate feature flags when initializing web::Context. WebEngine currently ignores that field, but that will change in the future. Bug: 962617, fuchsia:35009 Change-Id: I1e5b417fb883d6bfb5ebdd3a68e38a59a23a5db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769713 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Sergey Poromov authored
The histogram is needed to track success of rollout from non-zipped to zipped log upload. Bug: 940648 Test: Unit test updated. Change-Id: Ib5645a72cb1fbf56bdebf6364151d945b2505e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766129Reviewed-by:
Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#691827}
-
Oleg Davydov authored
ShouldBeVerified and ShouldBeChecked methods add a bit of confusity, as it might not be clear what verify/check means here. Now they are combined into one GetVerifyMode, which returns enum with clear values (do not check anything, check hashes in computed_hashes.json, but trust them, or check and verify that hashes are correct using Chrome Web Store signature (in verified_contents.json). Bug: 958794 Change-Id: Ia32bb0140f38ad89ff410fd365e30631b514e267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760908 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Johannes Henkel authored
This PR separates the messages into three different log streams. I'm thinking this should be the simplest way to avoid flakiness. Context: yurys@chromium.org's report of flakiness at https://chromium-review.googlesource.com/c/chromium/src/+/1762823 Bug:991325 Change-Id: I0eab13a6e5edd046bb3301c872ae2eaa959abe3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772257 Commit-Queue: Johannes Henkel <johannes@chromium.org> Auto-Submit: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#691825}
-
Ted Meyer authored
I'll follow this up with a new version of the canary experiment to replace MojoVideoDecoderWin::* Change-Id: Ia064fd5d40295f742b2e82f021e96bf77d816924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776404 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#691824}
-
