- 01 Oct, 2018 40 commits
-
-
Sahel Sharify authored
This cl converts middleClickAutoscroll.js and the middle click autoscroll layout tests that are using it to use gpu benchmarking. Bug: 875945 Change-Id: Ic5acb4367dd406de3e5897063bfe6b1b44e7daa6 Reviewed-on: https://chromium-review.googlesource.com/1251901Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595596}
-
Brian White authored
Try to narrow down where the ranges are getting corrupted by verifying the internal checksum in places. Bug: 836238 Change-Id: I05493e86d74c820c6dfe2dbe30759c04cdfb3f28 Reviewed-on: https://chromium-review.googlesource.com/1255322Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#595595}
-
Min Qin authored
SystemNetworkContextManager already takes a PrefService in its ctor. As a memeber variable of SystemNetworkContextManager, ProxyConfigMonitor should do the same. This CL also fixes an issue that ProxyServiceFactory is using BrowserThread::UI to create the system proxy service. It is possible that BrowserThread is not created if ServiceManager is started alone. Switching to use base::ThreadTaskRunnerHandle::Get() instead. BUG=866028 Change-Id: I6a33310e94a6050ca0bd22bdd716660aea790b58 Reviewed-on: https://chromium-review.googlesource.com/1255144Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595594}
-
David Trainor authored
Two files were redundantly listed in base/BUILD.gn which caused a compile error. NOTRY=true No-trying because this is blocking junit test compilation and has (should have) no effect on the mac builder. Change-Id: I98da40cfa877a3665a03cf4f879dd228574392ec Reviewed-on: https://chromium-review.googlesource.com/1255049 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#595593}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8dfa5c869e08..1b448050d611 Created with: gclient setdep -r src-internal@1b448050d611 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9f0de92dc70411b48d98df5b7345b27d7c25ceef Reviewed-on: https://chromium-review.googlesource.com/1255562Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595592}
-
Shimi Zhang authored
There is no need to keep this function since printing/units.h has such conversion already. R=thestig Bug: None Change-Id: Ib6164b40d5f8a6b812b7ebc2f81942403eb3926a Reviewed-on: https://chromium-review.googlesource.com/1255604Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#595591}
-
Tsuyoshi Horo authored
Bug: 890199 Change-Id: Idd9d01735d1a922692de63fc7b99e1154b13e7e9 Reviewed-on: https://chromium-review.googlesource.com/1250764Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595590}
-
Joshua Bell authored
As a follow on to https://crrev.com/c/1248328, wrap conversions between base::Time and the particular format used for persistence in the quota database (int64_t) in methods, instead of inlining the conversion steps at every point. Bug: 889242 Change-Id: I8d5b7b6a6e7bf9ccf507cd8c3ad750dae9e30206 Reviewed-on: https://chromium-review.googlesource.com/1254744 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#595589}
-
Weidong Guo authored
Changes: Make app list respect work area instead of display bounds. Bug: 889334 Change-Id: I861b2d652ce432dbccb16f36b90aae6cc90e328b Reviewed-on: https://chromium-review.googlesource.com/1255583 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#595588}
-
Eric Stevenson authored
This CL introduces the badging api. The badging API will eventually allow developers to set and clear badges for installed PWAs. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Fw764MVF5nI Explainer: https://github.com/WICG/badging/blob/master/explainer.md Bug: 719176 Change-Id: I68aa5a9310469bd3a38b1029f2141be335121b06 Reviewed-on: https://chromium-review.googlesource.com/1166603Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#595587}
-
Raymond Toy authored
It is valid to set the buffer attribute more than once. As resolved in https://github.com/WebAudio/web-audio-api/issues/1762, setting the buffer more than once is allowed. This is a revert (mostly) of https://chromium-review.googlesource.com/c/chromium/src/+/1077713 Bug: 882211 Test: the-convolvernode-interface/convolver-setBuffer-already-has-value.html Change-Id: Ie7f170883e6a6b2bfa7f14d89c74b72eebde3dac Reviewed-on: https://chromium-review.googlesource.com/1249275Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595586}
-
gogerald authored
src/chrome/test:browser_tests will be added later on Desktop since it is not available on Android (crbug.com/611756). Bug: 806868 Change-Id: I1f0896057d3a3608ff72e1205c4c4f372ea56c71 Reviewed-on: https://chromium-review.googlesource.com/1239440Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#595585}
-
Kristi Park authored
Before: https://screenshot.googleplex.com/VTEZEnvP8Ac.png After: https://screenshot.googleplex.com/QpJWqkymMe8.png Bug: 879502 Change-Id: I4a37757b19297c3507b55d8506446dd1f58ecbc5 Reviewed-on: https://chromium-review.googlesource.com/1252854 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#595584}
-
Yue Cen authored
Bug: 881083 Change-Id: Ia8aa5753b1170983b0081c7de85c4b197743f7a6 Reviewed-on: https://chromium-review.googlesource.com/1253066 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595583}
-
David Roger authored
This CL clears all Chrome authentication tokens when the user clears their cookie, except in one edge case: when the user is clearing both their cookie and their synced data at the same time, the token for the Sync account is not deleted, because it would prevent the data to be correctly deleted on the Sync server. The UI of the "Clear Browsing Data" dialog will be updated in a followup CL, to surface this behavior change to the user. Bug: 889137 Change-Id: I495a57b52a39832c30474973b4619de646a79bc3 Reviewed-on: https://chromium-review.googlesource.com/1250966Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#595582}
-
Mihai Sardarescu authored
When DICE is disabled or DICE fix auth error is enabled, the token service should only manage the token of the primary account. This means that token service should clear all tokens from DB in these modes to avoid leaving tokens on disk when the user changes from DICE disabled to DICE enabled modes. The change in crypauth service is needed as to avoid an assumption that pref changes can only happen after primary account was set. This is not the case in browser tests. Bug: 890758 Change-Id: I63a8ae3ac0f00271c0031cd090d1cf9dad50905c Reviewed-on: https://chromium-review.googlesource.com/1254210Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#595581}
-
Robert Ogden authored
If the user has IPH_DemoMode set in their about:flags, the previews IPH may appear even if the page is not a preview. This CL puts in a small check to ensure this can't happen. Bug: 886949 Change-Id: Ib0af8adcdefef0dba7dd8441d1a0d0189ea2581b Reviewed-on: https://chromium-review.googlesource.com/1255422Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#595580}
-
Tommy Steimel authored
This CL updates the styling for the volume slider for larger videos. Bug: 890092 Change-Id: I1b410b7318f10247457c46cadbbb081801e19acf Reviewed-on: https://chromium-review.googlesource.com/1250206Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595579}
-
Tatiana Buldina authored
Bug: chromedriver:2600 Change-Id: I2d4ebdcfac43b27f2d443c82583a288d2570207b Reviewed-on: https://chromium-review.googlesource.com/1255623Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#595578}
-
chrome://omniboxmanuk authored
[chrome://omnibox]: create BrowseryProxy class to encapsulate communication with OmniboxPageHandler. BrowseryProxy is responsible for sending requests to and receiving responses from the omnibox page handler c++ code. In this cl, all communication with the c++ code are migrated to this class, but it is not yet fully isolated with the remaining js code; e.g. it directly reads inputs from the HTML DOM when making a request. This will be addressed in a separate CL to isolate js <-> HTML communication. Change-Id: I5aaa363a6614c8120c05cc4923c032a0d79a6157 Reviewed-on: https://chromium-review.googlesource.com/1252324 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#595577}
-
Chris Harrelson authored
[PE] Don't consider "unclipped_descendants" from being conditioned on having a composted scrolling ancestor. Also, scrollers which NeedCompositedScrolling count as a composited scrolling ancestor, not just ones with direct reasons. This fixes cases such as a fixed-position element under a scroller with an in-flow sibling, on high-DPI screens: <div style="overflow: scroll"> : This is composited due to high-DPI <div style="position: fixed; background: white"></div> : This is composited due to high-DPI <div style="position: relative; top: 500px"></div> : This is not composited because it is not overlapping the fixed position element unless scroll is applied. Once scrolled, it will not be visible because it is overlapped by the positon: fixed element. </div> There is already a code pattern to handle composited promotion for this flavor of case. However, the fixed position element does not have a non-root composited scroller above it. This is why the code was wrong before this patch. Bug: 889492 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I650408cb3bc7c2b7fac932f7e968863bcdcd41d5 Reviewed-on: https://chromium-review.googlesource.com/1253063 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595576}
-
Peter Kotwicz authored
The goal of this "CL set" (1-3) is to: - Force people to update template_shell_apk_version when code which is compiled into WebApk.apk is updated - Don't require additional reviewers for updating template_shell_apk_version. This CL: - Moves template_shell_apk_version into into a new file in a directory where it is the only file. - Adds an OWNERS file to allow anyone to update template_shell_apk_version. - Renames template_shell_apk_version and expected_shell_apk_version so that the GN variable names are more intuitive BUG=884444 Change-Id: Ic7a15506511f2bbffe2beea04d51e1a6e6d1aed5 Reviewed-on: https://chromium-review.googlesource.com/1243669 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595575}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/prefs. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=pam@chromium.org Bug: 874080 Change-Id: I7ca5bf1e7d05dafa3ba1b2d96ff5d6af1278df17 Reviewed-on: https://chromium-review.googlesource.com/1191137Reviewed-by:Robert Liao <robliao@chromium.org> Reviewed-by:
Pam Greene (Please send IM for reviews) <pam@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#595574}
-
Fabrice de Gans-Riberi authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5d532182b97b6d849ac6ba9ccec45ed032da5927 Reviewed-on: https://chromium-review.googlesource.com/1255046Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#595573}
-
Dmitry Titov authored
This will be used in Explore Sites to track breadth of web usage. It'll be called from ExplreSitesService, on a schedule, approximately once a week. Bug: 867488 Change-Id: If535dfead7f11dbaf501472dc42eaa882cbd94c4 Reviewed-on: https://chromium-review.googlesource.com/1248128Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#595572}
-
Weilun Shi authored
Change the height limit for truncateTitleText function to 24 according to the largest minimum font size in the setting. Screencast: https://screencast.googleplex.com/cast/NTY0Mzc2NjE5OTIyMjI3MnxlNDZjMjRlZi0yMA Bug: 881288 Change-Id: I1f9a6e60269acbe1756f22911410f85b29249e03 Reviewed-on: https://chromium-review.googlesource.com/1255602 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#595571}
-
Joshua Bell authored
Bug: 714018 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2cb2aba8e1f8460f0dedc25fdeba1df702e845fb Reviewed-on: https://chromium-review.googlesource.com/1244369Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#595570}
-
Alex Clarke authored
Bug: 863341, 872372 Change-Id: I19405b9061b3dc677d1f06e16564eb9aed133f79 Reviewed-on: https://chromium-review.googlesource.com/1251546 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#595569}
-
Xiaohan Wang authored
This was added accidentally in the original CDM, not initialized, and not used. Then in a late CL it's used assuming it's initialized, which was wrong. This CL removes |weak_this_| from MojoCdmService to fix the issue. Bug: 432998 Change-Id: Ifcda68e79c7ca5f2203cad9e77765b7f8c3d1971 Reviewed-on: https://chromium-review.googlesource.com/1255464Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#595568}
-
Robert Ogden authored
This CL is the first of 3 for this bug. This CL adds a boolean pref to the lite page decider which tracks whether or not the user needs to see a new UI for privacy reasons when this preview is enabled. The user only needs to be notified if they are an existing DataSaver user. Non-users will never be notified. Once a notification is triggered on a page load finish, the decider will never again require it to be shown. Bug: 889124 Change-Id: Ice3fc9344bc50a2633e09e011c313a192b742c5f Reviewed-on: https://chromium-review.googlesource.com/1248182 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#595567}
-
Yue Cen authored
I created a syncable pref in crrev.com/c/1213521 to check if a user has gone through OOBE before. Now that the server side will conduct the check so the syncable pref is no longer necessary. Please see b/114134918 for more details. Bug: 835029 Change-Id: Iab53007458ecd4f42915571fba96c91b894625a5 Reviewed-on: https://chromium-review.googlesource.com/1252851 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#595566}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3ad86d0c8bc4..8ef78eae9311 git log 3ad86d0c8bc4..8ef78eae9311 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 halcanary@google.com SkPDF: encode all bitmap images as Type3 2018-10-01 brianosman@google.com Towards removing GrColor4f 2018-10-01 michaelludwig@google.com Add input/output image logging to processor tests 2018-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a78092cb2557..996628a4a1fd (2 commits) 2018-10-01 reed@google.com delete textonpath code -- not used anywhere 2018-10-01 allanmac@google.com SKC group improvements 2018-10-01 halcanary@google.com SkPDF: Device methods setGraphicState and drawFormXObject 2018-10-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 876760bb27d0..810f3db8264a (1 commits) 2018-10-01 kjlubick@google.com Open non-perf Quadro bots to rack 2 Created with: gclient setdep -r src/third_party/skia@8ef78eae9311 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:784662 TBR=mtklein@chromium.org Change-Id: Ifef165d4c20ddce1c71e32c10613186f301b2724 Reviewed-on: https://chromium-review.googlesource.com/1255504Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595565}
-
Xiaohan Wang authored
This CL replaces ffmpeg/libvpx video decoders implemented in ClearKeyCdm with media::FFmpegVideoDecoder and media::VpxVideoDecoder. This removes duplicate code which is hard to maintain, and make it a lot easier to support new features like VP9 profile 2, HDR, AV1 etc. Since media VideoDecoder operations are asynchronous while CDM video decoder operations are synchronous, we need to do async -> sync conversion. This is done by running the RunLoop manually after each VideoDecoder call. Currently we still have FFmpegCdmAudioDecoder in ClearKeyCdm, which should also be replaced in the future. Bug: 169203 Test: Existing tests still pass. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I10808c03b6e802c3e18f3b70cdd0413d5204009c Reviewed-on: https://chromium-review.googlesource.com/1247228Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#595564}
-
Alexander Shah authored
Ctrl+Shift+H to trigger. Requires --enable-viz-hit-test-debug flag and logging level of 1 on hit_test_debug_key_event_observer. Adds observer to render_widget_host_impl to act on OnInputEventAck. Example: https://pastebin.com/pcxrZv6A R=riajiang@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I1c9a0867debe5b4aa670a51f85fe24909073374c Reviewed-on: https://chromium-review.googlesource.com/1226099 Commit-Queue: Alexander Shah <zandershah@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#595563}
-
Dmitry Gozman authored
This entity manages the blink::mojom::DevToolsAgent pointer exposed by the renderer, it's process id and frame host for different DevToolsAgentHostImpl subclasses. Putting it into a single entity simplifies the lifetime management, and will also aid with blink::mojom::DevToolsAgentHost when we'll add one. Bug: 775132 Change-Id: Ifc8e55995bff2eac813bb694ddc55ed7d0c9400c Reviewed-on: https://chromium-review.googlesource.com/1247702 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#595562}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3ff52ffa22ae..5f45e6651864 git log 3ff52ffa22ae..5f45e6651864 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 ilnik@webrtc.org Fix temporal layers pattern checker for VP8 video 2018-10-01 phensman@webrtc.org Tidy up and increase exception handling in compare_videos 2018-10-01 terelius@webrtc.org Prepare RtcEventLog parser for new wire format. Created with: gclient setdep -r src/third_party/webrtc@5f45e6651864 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If7b1aec511353d46cbad2823ed304b81798c47e4 Reviewed-on: https://chromium-review.googlesource.com/1254684Reviewed-by:
-
Sahel Sharify authored
This cl calls stopFling after navigation to make sure that flinging does not continue after navigation when the new page is using the same renderer. Bug: 835289 Test: BrowserSideFlingBrowserTest.FlingingStopsAfterNavigation Change-Id: I9f43689ec375605ab1c3ba38adf1df9d46b3efa5 Reviewed-on: https://chromium-review.googlesource.com/1244374Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595560}
-
rbpotter authored
(1) Fixing attached bug (2) Fixing issue reported by namratakannan@ that system dialog link should be enabled in an error state on non-Windows platforms (3) Fixing issue discovered while testing, that setting an invalid value while fit to page is checked should un-check fit to page, but not result in the preview regenerating with the last valid value. Similarly clearing this invalid value should also not result in a preview regeneration (unless the user blurs the input). Bug: 889386 Change-Id: I1afaafe1f9a13b6ed00be712ae7966ce37d62222 Reviewed-on: https://chromium-review.googlesource.com/1250161Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL introduces the Blink.ImageDecoders.Jpeg.ColorSpace which tracks the color space of JPEG images. When the color space is YCbCr, we also record the chroma subsampling (e.g., 4:2:0). Bug: 886914 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1d5c9cbc893907c1352fa7c845d58aa9116c4f6a Reviewed-on: https://chromium-review.googlesource.com/1235214 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595558}
-
Theresa authored
BUG=890947 TBR=huayinz@chromium.org Change-Id: I4cb9f74c57e016f237ae530c4e68bab525b8ce0d Reviewed-on: https://chromium-review.googlesource.com/1255593Reviewed-by:
-
