- 12 Dec, 2018 40 commits
-
-
Doug Arnett authored
If both Lite Page Redirect previews and Resource Loading Hint previews are enabled, the first one hides the second one currently due to different triggering point in the code. This CL is a bug fix to avoid that hiding via heuristic that favors the PageHint based optimizations if there are known to be PageHints for the host. This assumes we should not add PageHints for hosts where we don't think their treatment is better than Lite Page Redirect previews. Also adds a Finch controllable parameter to favor Lite Page Redirect (ie, switch back) so we can experiment with both. Bug: 913680 Change-Id: I6aa0aacc24b1e3f338a42f76d56cad94b34f5f01 Reviewed-on: https://chromium-review.googlesource.com/c/1371081 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#615948}
-
Max Morin authored
The amount of mirroring streams far outnumber the number of microphone streams, which causes these histograms to poorly represent microphone streams. This change ensures that the AudioInputDevice histograms keeps measuring the same thing when the mirroring service is enabled. Also fix lint. Bug: 912926 Change-Id: Ib08b9a5a452d0ece9494b30aa23c02d0d18e1bd1 Reviewed-on: https://chromium-review.googlesource.com/c/1370166 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615947}
-
Yoav Weiss authored
User timing's mark() was throwing when called with a well-known name inside a worker. According to the spec and tests, it should only throw in such a case on the main thread. This CL aligns our implementation with the spec. Change-Id: Idb43038105301a41cd7d2c676ca1fc401a684058 Reviewed-on: https://chromium-review.googlesource.com/c/1373830Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#615946}
-
Matthew Jones authored
This patch turns the omnibox results adapter into a generic utility that can conceivably be used by any list represented by models. Since the view type returned by getView is not guaranteed to return a view of that type, we need a means of checking it. This patch adds a tag to views in that list that identify what type it is. This should allow lists that aren't necessarily recycler views to work correctly with heterogeneous lists. This patch also removes some unneeded property reset logic that was specific to omnibox suggestions. Bug: 901952 Change-Id: Ic4e51bd527849c9177eedc18389d7ff7f70cde84 Reviewed-on: https://chromium-review.googlesource.com/c/1366484 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#615945}
-
Steven Bennetts authored
Chrome should not specify the kShellWindowId_AlwaysOnTopContainer, instead it should set InitParams.keep_on_top. Ash will then put the widget in the correct container and set kAlwaysOnTop correctly (expected by TabletModeWindowManager and potentially other code). Additionally, on Chrome OS, unparented dialogs should be associated with the user that opened the dialog so that the dialogs do not appear when switching user. (MultiUserWindowManagerClient::SetWindowOwner). This CL also cleans up some remaining calls to chrome::ShowWebDialogInContainer, instead setting the container id in chrome::ShowWebDialog for system modal dialogs only. Bug: 888711 Change-Id: I3ca16d3094ec632c834eec27ce4e9545c38b9308 Reviewed-on: https://chromium-review.googlesource.com/c/1367086Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Mitsuru Oshima (gardener - slow) <oshima@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#615944}
-
Tobias Sargeant authored
This allows us to implement new WebSettings APIs downstream. Bug: 891743 Change-Id: Iba5ba659afd6b65c4101398b7964b10ae0379bb2 Reviewed-on: https://chromium-review.googlesource.com/c/1373755Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#615943}
-
Stephen White authored
This reverts commit 10edbbe8. Reason for revert: Causing purple on FYI bots: <The executable does not exist or a dependent library is missing> <Check for missing .so/.dll in the .isolate or GN file> e.g., https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Release%20(Intel)/9078 Original change's description: > Dawn: use Dawn's temporary test targets for isolates. > > The plan is to move the actual test targets in Dawn to Dawn's > src/test directory. This change makes Chrome temporarily point at > some intermediate proxy targets, so we can move the real ones > without breaking Chrome. > > Bug: dawn:61 > Change-Id: I27a66a0daffe212da3fe2a0aaba7d4a250a376ea > Reviewed-on: https://chromium-review.googlesource.com/c/1373892 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615895} TBR=thakis@chromium.org,senorblanco@chromium.org,cwallez@chromium.org Change-Id: Ic5f3778259e37d3818e7dee1a04bb49a66bff27a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:61 Reviewed-on: https://chromium-review.googlesource.com/c/1374369Reviewed-by:
Stephen White <senorblanco@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#615942}
-
Eric Orth authored
When ResolveHostParameters::dns_query_type is set to TXT, a relevant DNS/MDNS query will be made with text record results in ResolveHostRequest::GetTextResults(). Will always use DNS or MDNS resolver as the System/Proc resolver only supports address queries. Lots of necessary changes to MockDnsClient. Rules now allow specifying a full DnsResponse rather than just IPAddresses, and added a couple helper methods to create such response objects. Rewrote and cleaned up all the response generation code to support the changes. Bug: 846423 Change-Id: I7298c73e7293ed4415eaa57c8d750111295dfbda Reviewed-on: https://chromium-review.googlesource.com/c/1352529Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#615941}
-
Tien Mai authored
- The GCPW installer will now try to find the first 'gaia' user name that is not used in order to create the account used to run the GLS for GCPW. - Once a username is determined it will stored in the LSA for fetching when needed. - Added a maximum number of attempts for finding a valid username. Bug: 896391 Change-Id: Iad7da2dc011ba76bee0cb3b2fdcf4f1195c425a1 Reviewed-on: https://chromium-review.googlesource.com/c/1370718 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#615940}
-
Jan Krcal authored
This is a speculative fix of rare flakiness. Before this CL, in rare cases, each client would have a different fake time value. Combined with another rare race condition in converting server addresses to local addresses, it would result in initial sync never converging. Bug: 911953 Change-Id: Ic628cac80b0ffd8977bb29fa5948109366801803 Reviewed-on: https://chromium-review.googlesource.com/c/1373843 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615939}
-
Xiyuan Xia authored
Testing of message loop idle seems not relevant to the tests and is bound to be flaky in browser_tests. Bug: 914380, 883680 Change-Id: Iac6862c995ae105b8451f0cbcb544f64473c0d85 Reviewed-on: https://chromium-review.googlesource.com/c/1374199Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615938}
-
Lan Wei authored
In ExecutePerformActions function, we add the code to handle touch inputs. However, right now we are using EventTarget.dispatchEvent() to send touch events, we should use another way to dispatch the touch events. Bug: chromedriver:1897 Change-Id: Idbecb39270d3abf80a30e5fd13fc0f5ff2ba5b3f Reviewed-on: https://chromium-review.googlesource.com/c/1372663Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#615937}
-
Cary Clark authored
Switch chrome to use interface that does not expose internal Skia concept. R=fmalita@chromium.org, danakj@chromium.org Bug: 913930 Change-Id: I3373c791095d4eeb3590f23f474e9c5a3f88a207 Reviewed-on: https://chromium-review.googlesource.com/c/1371924Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Cary Clark <caryclark@chromium.org> Cr-Commit-Position: refs/heads/master@{#615936}
-
Jeffrey Cohen authored
Happiness Tracking Surveys is a Googles internal web based survey provider This Change paves the way to display a survey inside a bubble. and allows a survey to be viewed at chrome://hats Bug: 807714 Change-Id: I056c824881fd484cde6355e697f98062b4710221 Reviewed-on: https://chromium-review.googlesource.com/c/1271414Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Avi Drissman authored
BUG=914393 Change-Id: Ia9813b162121de8c3763ccafc6525a628370f5ac Reviewed-on: https://chromium-review.googlesource.com/c/1371936 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#615934}
-
Min Chen authored
Bug: None Change-Id: I5386437fb075291a49d0e1aeb08c780fc23bcda3 Reviewed-on: https://chromium-review.googlesource.com/c/1372562Reviewed-by:
-
Mohamed Heikal authored
NativeBackgroundTask now allows subclasses to indicate if they support lite mode. If they do, the EmptyBrowserParts that it creates would also signal the same to native. Bug: 913480 Change-Id: I85bf27e9edd5b01cee7756c7a951cd95d3e9520e Reviewed-on: https://chromium-review.googlesource.com/c/1370580Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#615932}
-
Emircan Uysaler authored
As the crash stack in the bug below shows, V4L2CaptureDevice may be destructed on a different thread than where it was constructed. Therefore, we should use RefCountedThreadSafe instead of RefCounted. Bug: 899203 Change-Id: I71c3f08d65852f34ee44a20032d2f3a3b403eb44 Reviewed-on: https://chromium-review.googlesource.com/c/1374151Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615931}
-
Christopher Cameron authored
This will be queried in ExtensionAppShimHandler::OnProfileLoaded, where we will check that the pid's signature. Bug: 913362 Change-Id: I6fd144b26fad182d040f302f078a343cd2ab6cd9 Reviewed-on: https://chromium-review.googlesource.com/c/1373433 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#615930}
-
Yoav Weiss authored
This change implements the processing model from PR 168[1], when it comes to setResourceTimingBufferSize(), clearResourceTimings() and the firing of the resourcetimingbufferfull event. This is a reland of [2] which is a reland of [3] (but with nicer tests). [1] https://github.com/w3c/resource-timing/pull/168 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1350950 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1345269 Bug: 908181, 908414 Change-Id: I3a6c6e9d6a9aa5b5f907d1e86bec701ff2fa022d Reviewed-on: https://chromium-review.googlesource.com/c/1373819Reviewed-by:
-
Ken Rockot authored
This tears down all running per-profile Service instances for a specific BrowserContext within NotifyWillBeDestroyed rather than waiting until BrowserContext destruction, ensuring that it's safe for Service instances to refer to other BrowserContext state (e.g. keyed services) all the way up until their destruction. Bug: 913400 Change-Id: I75321476aebd954d1e5768dc2b5d4d81784a55b2 Reviewed-on: https://chromium-review.googlesource.com/c/1372318Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#615928}
-
Dominic Battre authored
This CL contains two minor cleanups ins the password manager: 1. Rename ClearPasswordValues to MaybeClearPasswordValues because the function only clears password values in some cases which was not reflected in the function name and confused me a lot. 2. Delete some unused local variables. I hope that they are intentionally unused. Bug: 831123 Change-Id: Iba308f48d13f6755b9cc1e6fb2cde19c5dc911f6 Reviewed-on: https://chromium-review.googlesource.com/c/1373761Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#615927}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8aca9026..c5def5f3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0d45c4b8772e88a586bcad9e7b107b0046ae2f8a Reviewed-on: https://chromium-review.googlesource.com/c/1374090Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615926}
-
danakj authored
This is a reland of 573f4675 Was reverted because SitePerProcessBrowserTouchActionTest.EffectiveTouchActionPropagatesAcrossNestedFrames failed when it landed. But the test went back to green for a few runs before this was reverted, so I don't think it was at fault. We'll see if it starts failing again on reland, and I'll watch the mac bots here in the CQ. TBR=dcheng Original change's description: > Remove code to store the last popup transiently in WebFrameWidgetImpl > > This code was copied over from WebViewImpl when adding the HidePopups > call in order to have a pinch zoom or scroll tap outside the current > popup in a non-main-frame-local-rooted iframe hide the current popup. > > This is modifying state on WebViewImpl meant to track between TapDown > and Tap, to avoid the Tap showing a popup that was hidden by TapDown. > > WebFrameWidgetImpl does not show popups on Tap, and if it did, it > should track this transient state locally not on WebViewImpl. > > Also remove the undocumented FALLTHROUGH which was not explained > in 671732 as it now goes to nothing. > > R=dcheng@chromium.org > > Change-Id: I9d67539cf0afbb9db239b73bf83418e1a877e6db > Bug: 912193, 671732 > Reviewed-on: https://chromium-review.googlesource.com/c/1372539 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615708} Bug: 912193, 671732 Change-Id: I18e8e146b5b525239d1667e267d44fa8a295599d Reviewed-on: https://chromium-review.googlesource.com/c/1374193Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615925}
-
Nicolas Pena authored
Blink intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XZU_DhQ9ZGs Bug: 911314 Change-Id: I4a79d6d3a81ec260c7db5c2bea7b2d533a1285b2 Reviewed-on: https://chromium-review.googlesource.com/c/1359480Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#615924}
-
Matthew Jones authored
Bug: 901952 Change-Id: I54bf2e5679b57d2780310272fbdf4d5defe06dcc Reviewed-on: https://chromium-review.googlesource.com/c/1366322Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This test has a history of flakiness (see linked bug). Although the failure happens on Windows as well, the retry seems to succeed reliably enough. Flakiness Dashboard shows flakiness on linux-chromeos-rel as well, so disabling for all of linux. TBR=ekaramad@chromium.org Bug: 914098 Change-Id: Idfd3680040c0dba5b52504d5808c2840611dd1c4 Reviewed-on: https://chromium-review.googlesource.com/c/1373768Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615922}
-
Jinsong Fan authored
During restoring from the old cache, RestoreFromListValue always traverses all entries and sets the size of the entries to restore_size_. The CL adds check if the cache is full during restoring for performance, and sets restore_size_ to the number of cache entries that were restored. Change-Id: I40f33f326e8aa92a2b8897879c652b8b3b41e825 Reviewed-on: https://chromium-review.googlesource.com/c/1369747 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615921}
-
Joe Mason authored
Change-Id: I046ae0849fcaf1810979e019f18d3cb6f1b9785e Reviewed-on: https://chromium-review.googlesource.com/c/1374195Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#615920}
-
Steven Valdez authored
Bug: 914373 Change-Id: I31f9e3801fdc4a82497c6d2c4af6a26952c348a1 Reviewed-on: https://chromium-review.googlesource.com/c/1374150Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#615919}
-
Friedrich Horschig authored
This test was failing frequently, see linked bug for details. TBR=javierrobles@chromium.org Bug: 914374 Change-Id: I6cf9df559992c594258314fbb7e736a6da9c023d Reviewed-on: https://chromium-review.googlesource.com/c/1373766Reviewed-by:
-
Peter Mayo authored
Update the files of links post blink rename. Tweak some of the verb agreements. Bug:None Change-Id: Ia18ed363b4d3a7c100ed676f89cf8c4f5833bd0b Reviewed-on: https://chromium-review.googlesource.com/c/1372476Reviewed-by:
Peter Mayo <petermayo@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#615917}
-
David Tseng authored
Reland: Remove hard coded accessibility desktop tree id and make RenderFrameHost implement AXHostDelegate Account for Mac codepath in AutomationInternalApi::PerformActionFunction. Original change: This change is part of the effort to move AutomationManagerAura into ui/. This change in particular removes deps on content/ inside of AutomationManagerAura. Highlights: - removes usage of hard-coded desktop tree id in automation api (native and js bindings) - makes all known tree managers implement AXHostDelegate TBR=servolk@chromium.org,jamescook@chromium.org,sky@chromium.org,dmazzoni@chromium.org Bug: 888152 Test: existing browser_tests (Automation Api tests, ChromeVox tests). Change-Id: Ia81220ad90c9a0f3177d66a71e6b6e3afc67ce22 Reviewed-on: https://chromium-review.googlesource.com/c/1372482Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#615916}
-
Harald Alvestrand authored
This reverts commit 68c1d92a. Reason for revert: Fixed an issue that fits the symptoms Original change's description: > Revert "Create RTCDtlsTransport objects in the blink layer" > > This reverts commit d7d59c5b. > > Reason for revert: virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCRtpSender-transport.https.html fails in "WebKit Linux Trusty MSAN". > > Original change's description: > > Create RTCDtlsTransport objects in the blink layer > > > > This CL does on-demand creation of blink-layer transport > > objects. It also introduces a way to get at the webrtc::PeerConnection > > object from the WebPeerConnectionHandler API. > > > > Bug: chromium:907849 > > Change-Id: Ic86a5a66289c31d1f939a47d58bc194c32471cbd > > Reviewed-on: https://chromium-review.googlesource.com/c/1358060 > > Commit-Queue: Harald Alvestrand <hta@chromium.org> > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Henrik Boström <hbos@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#615072} > > TBR=hta@chromium.org,haraken@chromium.org,hbos@chromium.org,guidou@chromium.org > > Change-Id: Ie9c8d2e3dc5f97fc94ca5bf43cc30a9407d9fa4c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:907849 > Reviewed-on: https://chromium-review.googlesource.com/c/1369719 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615115} Change-Id: Ic0dcb6851d725eec31fb4203770cd21b88ce3e88 Bug: chromium:907849 Reviewed-on: https://chromium-review.googlesource.com/c/1371890Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#615915}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/069664e58b9d..b59d04f79ee3 git log 069664e58b9d..b59d04f79ee3 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 cwallez@chromium.org Run linux-dawn-rel on the CQ 2018-12-12 hao.x.li@intel.com Roll Chromium build to fix undeclared argument in mac toolchain Created with: gclient setdep -r src/third_party/dawn@b59d04f79ee3 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:901830 TBR=cwallez@chromium.org Change-Id: If4b9dabc9a7d49cf0d9311d7d9b793440c1e1c88 Reviewed-on: https://chromium-review.googlesource.com/c/1374129Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615914}
-
Annie Sullivan authored
Bug: 914390 Change-Id: Ib8d55b5782dd17b280440e87117654b5ede876be TBR: charliea@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/1374198Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615913}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/50dd0e1a15cc..6f7831a8afd6 Created with: gclient setdep -r src-internal@6f7831a8afd6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I336dc01a3c6eaae5e9581d9553901c0ca1b831e6 Reviewed-on: https://chromium-review.googlesource.com/c/1374130Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615912}
-
Daniel Bratell authored
ChromeOS cryptauth unittest use cryptauth_api.pb which moved from components/cryptauth to chromeos/services/device_sync in bug 912743. A file still included that file from the old path (and the new path) which worked in trees where an earlier tree had generated it but didn't work in a clean tree. The files presumably had the same include guards so that is was ok to include both. TBR=khorimoto@chromium.org Bug: 912743 Change-Id: I6708c674f5fd99c94e233df5ec9b9c462c7814ad Reviewed-on: https://chromium-review.googlesource.com/c/1373826Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#615911}
-
Keiichi Watanabe authored
video.WebRTC* tasts tests are disabled on chrome bot by CL:1363805 because of a bug reported at crbug.com/909975. Since this bug was fixed by CL:1367388, we can run these tests now. Bug: 909975 Change-Id: I74b719988470552fe5abc39f217dda0086e15e71 Reviewed-on: https://chromium-review.googlesource.com/c/1367333 Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#615910}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7cfbbc30ae1c..ff2d54966a03 git log 7cfbbc30ae1c..ff2d54966a03 --date=short --no-merges --format='%ad %ae %s' 2018-12-12 lalitm@google.com Merge "trace_processor: change CreateSchema -> Init and return base::Optional" Created with: gclient setdep -r src/third_party/perfetto@ff2d54966a03 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I70cb4c7d206c41f2b94f820526489cb60466c2a5 Reviewed-on: https://chromium-review.googlesource.com/c/1374069Reviewed-by:
-
