- 18 Oct, 2019 40 commits
-
-
Armando Miraglia authored
When applyConstraints is called on a track, the capabilities are limited to what the settings already set on the track. This also means that the constraints algorithm needs to guarantee that the same processing-properties type is selected. So far, we have done so by allowing a single processing-properties group to be initialized when the capabilities are set. This approach is, however, incompatible with applyConstraints reconfiguration. This CL guarantees the same requirements, but simplifying the logic and always initializing all the processing-based groups for processing. It also adds the possibility to inspect the processing type selected by returning the extra field when the select-settings algorithm is run. BUG=796964 Change-Id: Ib34f7d33eb3aa8e1460aebcda20941df0503fa62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847275 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#707385}
-
Eric Stevenson authored
This CL was partially created by //base/android/jni_generator/jni_refactorer.py. The conversion also required converting unit tests to use the new JNI mocking approach provided by JniMocker. Bug: 929661 Change-Id: I57cc3e19641af73e745ea1b224947586ba2287bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834035 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#707384}
-
Matt Menke authored
Also add NetworkService API to enable partitioning auth cache entries by NetworkIsolationKey, and a field trial to set it to true. All done in one CL to allow integration testing. Bug: 993806 Change-Id: I323826847cda68e0e1acd776dc6ba260743d3952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865411 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#707383}
-
Derek Beckett authored
Adding an API that will refresh (refetch) Enterprise Policies when called. This will remove the need for automated testing to go to the chrome://policy page, and "click" the refresh button via a js call. Bug=chromium:1012712 Test=Locally deployed and tested and basic unittest. Change-Id: Iedc3c2e349cceb7f8b076259877d548b9f4babda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683103 Commit-Queue: Derek Beckett <dbeckett@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#707382}
-
Mikel Astiz authored
Some of the SyncEncryptionHandler APIs are about decrypting pending keys, but the keys themselves should NOT be added directly to the main cryptographer, to avoid leaking keys accidentally (or wrong ones). Instead, let's use temporary keybags to decrypt pending keys. Bug: 922900 Change-Id: Ie7af21ce7dccdc1422e3b4375f9519b5835ea379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866829Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707381}
-
Luke Zielinski authored
This will fix the breakage of go/wpt-waterfall and resume running tests. Bug: 996842 Change-Id: I1df7072de6f344c846cffa044b87ed57e3bdd51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864563Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707380}
-
Dan Harrington authored
This change simply avoids using RunUntilIdle. I found that RunUntilIdle was taking 10 seconds for every invocation -- but not on every test run. I'm not sure of the cause, but using RunUntilIdle is bad practice anyway. Where possible, I'm using QuitClosure, but we can't do that in all cases. Bug: 1014706 Change-Id: Icf538182c9572eaa26aa8d5dd6365981555ee1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864418 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#707379}
-
Olivier Li authored
This is done to be able to prepare tests before eventually submitting a CL that flips the experiment to ENABLED_BY_DEFAULT. Bug: 661143 Change-Id: I6b614bb4400478a7e90de78562a54083af1b3bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865596 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#707378}
-
Randy Rossi authored
The ConvertToAXActionData() function in automation_internal_api.cc was leaving the horizontal_scroll_alignment and vertical_scroll_alignment fields in AXActionData to their default value of ax::mojom::ScrollAlignment::kNone. When the target was a blink object, web_ax_object.cc would then use 'no scroll' values for both hidden and partially hidden cases for its converted blink::ScrollAlignment struct. This was causing the SCROLLTOMAKEVISIBLE action to not scroll the view to make the object visible. Bug: 1015144 Test: Manual test with display assistant screen reader Change-Id: I20dcd48587704ba42a33c7d27fb81c7d8a8a4ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864824Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707377}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/299bea643826..7f418fc2677a git log 299bea643826..7f418fc2677a --date=short --no-merges --format='%ad %ae %s' 2019-10-18 courtneygo@google.com Vulkan: lineloop support for DrawArrayIndirect Created with: gclient setdep -r src/third_party/angle@7f418fc2677a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: None Change-Id: If1a7fee2a720728e61bc0db22e366d631524546c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869369Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707376}
-
David Benjamin authored
Bug: none Change-Id: Iadcb1b111922a417e09293e2e73bec7b464e9c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869031 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#707375}
-
Yuki Shiino authored
I guess that this breakage was caused by https://crrev.com/c/1834142 or related patches. Change-Id: I1b93bd71743474432de38e86e6384f4b76b575eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869230Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#707374}
-
Lowell Manners authored
Before this CL, calling BackForwardCacheImpl::Flush would immediately destroy all frames in the cache. If Flush was called during a navigation to a cached page, this could cause Chrome to crash, as it tried to navigate to a deleted frame. By calling RenderFrameHostImpl::EvictFromBackForwardCache instead of directly deleting frames, the above edge case is handled, and calling Flush at any time becomes safe. TBR=clamy@chromium.org Change-Id: I9cb8aa7348868e6bc3089894a7a71cffb7d1fa33 Bug: 1003745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807321 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707373}
-
Nicolás Peña Moreno authored
Change-Id: I9f45508bb229a809e15423c5d9f48271702719af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866558 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707372}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a68a80a4dbf9..26c6c4a5eb83 git log a68a80a4dbf9..26c6c4a5eb83 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 amaiorano@google.com Fix Win32SurfaceKHR resize issues Created with: gclient setdep -r src/third_party/swiftshader@26c6c4a5eb83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139372840 Change-Id: If651fc82698b69104e3b02e8aa42de852aba9d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868508Reviewed-by:
-
Yi Gu authored
This reverts commit f69623b2. Reason for revert: Unnecessary tests were disabled on unnecessary platforms. Given that the tests are critical to hit testing. Revert this patch for now and disable the one that may actually flake later. Original change's description: > [Sheriff] Disable flaky test NestedSurfaceHitTestTest > > SitePerProcessNonIntegerScaleFactorHitTestBrowserTest > ::NestedSurfaceHitTestTest is flaky. > > TBR=kenrb@chromium.org > > Bug: 1014602 > Change-Id: If7c69bcf4a50c8e7b2646ec8826ea0115018cca6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862663 > Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> > Reviewed-by: Parastoo Geranmayeh <parastoog@google.com> > Cr-Commit-Position: refs/heads/master@{#706161} TBR=parastoog@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1014602 Change-Id: Ife838c1e96c501d91559051fdcf7cf499bb9090e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869390Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#707370}
-
Vladislav Kaznacheev authored
This feature is not launching in M79. Temporarily disabled two tricky tests, filed bugs to fix: http://crbug.com/1015638 http://crbug.com/1015641 Bug: 973481 Test: ash_unittests Change-Id: I17b2bda3fd383f76dbdf81f86ab638604d923582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865712Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#707369}
-
Marina Ciocea authored
Add tests to verify tab sharing UI elements: infobars, contents border and tab sharing indicator. Bug: 996722 Change-Id: I5fa5ec7e4a48a66c1ba9b08ff76b84a105961352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847287Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c66e004edcf3..55d19e590d9a git log c66e004edcf3..55d19e590d9a --date=short --no-merges --format='%ad %ae %s' 2019-10-18 gustaf@webrtc.org Add gustaf to audio/OWNERS 2019-10-18 danilchap@webrtc.org Remove redundant fields in PacketBuffer 2019-10-18 sprang@webrtc.org Fix use of unitialized value in test Created with: gclient setdep -r src/third_party/webrtc@55d19e590d9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:1015256 Change-Id: I6034e4a4232abb6442dd912bac5f7e99716183e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868974Reviewed-by:
-
Fredrik Söderquist authored
The main gist is that timing and animation should be essentially independent - i.e the former only feeds into the latter by means of the progress state. Based on this we can perform some cleanups: * Any change to the animation target will also invalidate the animation parameter state via WillChangeAnimationTarget(), so any such change (SetTargetElement, SetAttributeType and SetAttributeName) needn't be followed by a call to AnimationAttributeChanged(), so remove those. * Any change to timing state (such as 'dur', 'repeatDur', 'repeatCount', 'min', 'max', 'begin' and 'end') will only influence the timing and not animation state, so we can drop calls to AnimationAttributeChanged() in those cases as well. * Since changing animation state should not affect timing, drop the call to SetInactive() from AnimationAttributeChanged() - this will be handled by timing updates when needed. This also means that SetInactive() is no longer used so it can be removed. After the above changes AnimationAttributeChanged() no longer needs to be virtual, and can reside in SVGAnimationElement alone. Also fold InvalidatedValuesCache() into AnimationAttributeChanged() since it is the only caller. Take this opportunity to move some state updates from the SvgAttributeChanged() override (which is for attributes which have an SVG DOM representation - and 'href' attributes because of how the dependency notifications work) to ParseAttribute(). Bug: 998526 Change-Id: Id50407cb5fb59601fea573e5963a7d4e1158a317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869210Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#707366}
-
Anton Bikineev authored
Before this patch, in order to support finalization of classes in a hierarchy, the base class must have had a destructor declared as virtual. This hurt sweeping time as the sweeper had to execute finalizers for classes that didn't really have any finalization logic. The patch adds support for non-virtual destructors in Oilpan that provides the basis for reduction of finalizers in the followup CLs. In the backend the logic remained the same for classes that have either - virtual Base::~Base or - trivial Base::~Base and trivial Derived::~Derived or - Base::FinalizeGarbageCollectedObject. The new logic is: - if all of the conditions above don't satisfy, separate GCInfo entries will be created for Derived classes. Bug: 1015427 Change-Id: I99481f0508d99668558283417a15cdf0bfe1ae6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866712 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#707365}
-
danakj authored
The main frame RenderWidget has page scale and pinch zoom determined in the renderer by blink. Only child frames hear about it through the VisualProperties waterfall propagation down the RenderWidget tree. So stop explicitly sending (default) values to the main frame RenderWidget (which it will not use) from RenderWidgetHostImpl. R=avi@chromium.org, wjmaclean@chromium.org Bug: 419087 Change-Id: I78a03df4d82cd1bb3765db8dffd92ea0e8bed812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865530 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707364}
-
Olivier Li authored
This is ground work for having ProfileSyncService's backend task runner use the ThreadPool. This class in particular affects LocalSynctTest.Shouldstart when work is done fully on the Threadpool. Bug: 1014464 Change-Id: Id91c6b1682648a6fdb38efef5145ab4d6af0b2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865427 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#707363}
-
Eric Willigers authored
The test DetachToBrowserTabDragControllerTest no longer relies on extensions to launch a web app. Bug: 1865741 Change-Id: Iee6850e33c06639e6b6bf4efa533c3cba85c4df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866223 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#707362}
-
Marc Treib authored
Bug: none Change-Id: I8c605899ca10c4482390f8250bc79de35501fc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869224 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#707361}
-
Alex Turner authored
The not-site-per-process isolated-code-cache web tests currently assume that cross-origin resources are cached when code cache site isolation is not active. This causes them to fail when the HTTP Cache is partitioned by Network Isolation Key. We thus disable the partitioned HTTP Cache for those tests and add a new test for when site isolation is not active, but the HTTP Cache is still partitioned. Bug: 1009628 Change-Id: I0d5d438d9564d3f659b93484a5bcc8aa56d2cd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865421Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#707360}
-
Vasilii Sukhanov authored
Bug: 1015447 Change-Id: I252d93ab9269b83402300d9835797d5399a40a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868995Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#707359}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72d92573ab57..1f4ca326d0db Created with: gclient setdep -r src-internal@1f4ca326d0db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If68a6c7964a868ca7c4516b4c2df9d7798bd6e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869070Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707358}
-
behdad authored
This is a reland of 2fcffb28 The cause of crashes on webview_instrumentation_test_apk was that reporter was terminated without a termination status (instance being destroyed) in TerminateReporter method of compositor_frame_reporter. Original change's description: > Record latency for Impl thread in case of no begin main frame. > > This CL reports the latency in case of no begin main frame. > This can happen in any of the scenarios below: > > 1) WillBeginImplFrame -> DidFinishImplFrame -> DidSubmitCompositorFrame > > 2) WillBeginImplFrame -> WillBeginMainFrame -> BeginMainFrameAborted -> > DidFinishImplFrame -> DidSubmitCompositorFrame > > 3) WillBeginImplFrame -> WillBeginMainFrame -> DidFinishImplFrame -> > BeginMainFrameAborted -> DidSubmitCompositorFrame > > In these cases there will be no latency to report for stages of: > - SendBeginMainFrameToCommit > - Commit > - EndCommitToActivation > But the latency will be reported for the remaining stages. > > Bug: chromium:1003038 > Change-Id: Id0d6a65603b2b15a0ee04a6974a4bd0b2a5a803b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799026 > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705964} Bug: chromium:1003038 Change-Id: I95651557c6e50b9f2e8ee3ae1043616fff8c88ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865535 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#707357}
-
Vlad Tsyrklevich authored
Enable GWP-ASan for malloc and PartitionAlloc by default for Windows and macOS and delete the former field trial config used to launch GWP-ASan. Bug: 896019, 912286, 956824 Change-Id: Icd146bc63dd6e50e6c5319905ed2f761ebff1bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866604 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
Several tests are crashing because FilterInterfacesImpl() is called when starting a dedicated worker in a process that was never initialized or is dead, and process->GetChildIdentity() has a DCHECK against that. There is already an early return for a null process, so also check if it's alive. Bug: 1010866 Change-Id: I397e493456f1d61abfe3e247d7bc7d4c29cc6954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868769Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Parastoo Geranmayeh authored
I was on a long leave and would need to take care of this in the coming days. Meanwhile, extending the flags to avoid expiry. Change-Id: I06449f52c74f8d8d32d1f57bd1b2f302bb2b50ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866088 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#707354}
-
Stepan Khapugin authored
Creates a new protocol to expose MainController internals to SceneController. Makes a bunch of ivars in MainController properties. Bug: 1012697 Change-Id: Ia1607c7ed75cb0b2edf99252d9c0342237e92b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848695 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#707353}
-
Mihai Sardarescu authored
There was significant confusion about the name of the function AuthenticationService::HaveAccountsChanged as it was not clear that it was only tracking if the accounts changed while Chrome was in background. This CL attempts to rename the variable and all the corresponding functions to make more clear its semantics. Bug: None Change-Id: Ic5a609de5ab04e60e9acadedbf72c1b978125e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827157 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#707352}
-
Marc Treib authored
Bug: 1004777 Change-Id: I6d0afbdac381e3d1b02535a98205e740860af89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865171Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#707351}
-
Colin Blundell authored
This CL adds a browsertest that a navigation to a URL of type HTTPS succeeds by default and fails if the site has a mismatched certificate. We're adding this test now in anticipation of implementing SSL interstitials, at which point we'll expand the test to test the interstitial behavior. This CL also adds necessary infrastructure to enable navigations to URLs supplied by embedded test servers of type HTTPS: - A ContentUtilityClient implementation whose registration of network binders can be overridden. - An installation of content::NetworkServiceTestHelper::RegisterNetworkBinders() for weblayer browsertests. Note that I first tried a simpler mechanism for the above: Invoking the relevant parts of the body of content::NetworkServiceTestHelper::RegisterNetworkBinders() directly from browsertests_main.cc:main() when in utility processes. However, this appears to be too early to invoke these functions, as it resulted in the following: [223377:223377:1015/171544.292381:ERROR:sandbox_linux.cc(367)] InitializeSandbox() called with multiple threads in process utility. Try waiting for /proc to be updated. [223377:223377:1015/171544.327809:FATAL:thread_helpers.cc(104)] Current process is not mono-threaded! (iterations: 25) 0 0x7ff318df263f base::debug::CollectStackTrace() 1 0x7ff318b217ed base::debug::StackTrace::StackTrace() 2 0x7ff318b217a8 base::debug::StackTrace::StackTrace() 3 0x7ff318b73559 logging::LogMessage::~LogMessage() 4 0x7ff2f3401232 sandbox::(anonymous namespace)::RunWhileTrue() 5 0x7ff2f3400f71 sandbox::ThreadHelpers::AssertSingleThreaded() 6 0x7ff2f34012d1 sandbox::ThreadHelpers::AssertSingleThreaded() 7 0x7ff3067300e4 service_manager::SandboxLinux::InitializeSandbox() 8 0x7ff30672929b service_manager::Sandbox::Initialize() 9 0x7ff313276abf content::UtilityMain() Change-Id: I1c89b7b77b028aca06c28d0b83ab1a7dbcf9f117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859993 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#707350}
-
Henrique Ferreiro authored
Convert the implementation and all users of the chrome_cleaner::mojom::Parser interface. Bug: 955171 Change-Id: I244eda469c157da15ea5015f3af5ac554ca48734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833463 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#707349}
-
Marc Treib authored
Bug: none Change-Id: I7202497b938141a0488d99329733e478e07a1b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869216Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#707348}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5c7866ef4586..87ede8895026 git log 5c7866ef4586..87ede8895026 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 eseckler@google.com processor: Extract ftrace parsing into FtraceModule/Parser Created with: gclient setdep -r src/third_party/perfetto@87ede8895026 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:141459049 Change-Id: I8b3d6d3e175fb3063c9c48c5d0c74cd9bd39ad2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868506Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I11d12f24f9a10116755d66f1471aee5c69000cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869071Reviewed-by:
-
