GitLab

https://github.com/whatwg/html/pull/224

R=domenic@chromium.org
BUG=495801

Review URL: https://codereview.chromium.org/1471283002

Cr-Commit-Position: refs/heads/master@{#361412}

Reland of Use sysroot by default for all linux builds (patchset #1 id:1 of https://codereview.chromium.org/1473363002/ )

Reason for revert:
Couldn't reproduce the failure.

Original issue's description:
> Revert of Use sysroot by default for all linux builds (patchset #7 id:120001 of https://codereview.chromium.org/1464983003/ )
>
> Reason for revert:
> Seems to have caused issues with goma: https://code.google.com/p/chromium/issues/detail?id=560973
>
> Original issue's description:
> > Use sysroot by default for all linux builds
> >
> > Using a sysroot was already the default for official
> > build and when cross compiling (e.g. arm, mips, x86-32).
> > This change makes it the default in all cases.
> >
> > The old behavior of building against local
> > system libraries can still be achieved by
> > setting use_sysroot=0
> >
> > BUG=504446
> >
> > Committed: https://crrev.com/a931efd5dc8d8783ce73a64fc641627866b6869d
> > Cr-Commit-Position: refs/heads/master@{#361197}
>
> TBR=dpranke@chromium.org,thestig@chromium.org,thakis@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=504446
>
> Committed: https://crrev.com/05373dc078f0d5d3f2fb1398db9a4008a55d9016
> Cr-Commit-Position: refs/heads/master@{#361405}

TBR=dpranke@chromium.org,thestig@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504446

Review URL: https://codereview.chromium.org/1472873004

Cr-Commit-Position: refs/heads/master@{#361411}

For zips that failed to parse completely, send a ping if
we see an exe/zip in it or if the user is in safe browsing extended-reporting.

BUG=53595

Review URL: https://codereview.chromium.org/1441243002

Cr-Commit-Position: refs/heads/master@{#361410}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0164a63f..43a72166

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1476503002

Cr-Commit-Position: refs/heads/master@{#361409}

BUG=442514

Review URL: https://codereview.chromium.org/1468803002

Cr-Commit-Position: refs/heads/master@{#361408}

This introduces some very simple timers as a starting point for
benchmarking WebUI pages.

BUG=560432

Review URL: https://codereview.chromium.org/1470133002

Cr-Commit-Position: refs/heads/master@{#361407}

Subclass DialogFragment classes to get notified about the dialog being cancelled and dismissed.
Don't call dismiss() from the onDismiss() handler.

BaseMediaRouteDialogManager:
- expose mDialogFragment to avoid calling closeDialog() from onDismiss()
- add SystemVisibilitySaver to handle the dialogs showing when in FS mode
  (before was handled by ChromeMediaRouteDialogFactory).

MediaRouteChooserDialogManager:
- use subclassed MediaRouteChooserDialogFragment
- use SystemVisibilitySaver and handle onCancel() and onDismiss()

MediaRouteControllerDialogManager:
- use subclassed MediaRouteControllerDialogFragment
- use SystemVisibilitySaver and handle onDismiss() as onCancel() isn't called.

ChromeMediaRouteDialogController:
- exit onDialogCancelled() early if onRouteClosed() was called before (see the comment).

BUG=551184

Review URL: https://codereview.chromium.org/1463693002

Cr-Commit-Position: refs/heads/master@{#361406}

Revert of Use sysroot by default for all linux builds (patchset #7 id:120001 of https://codereview.chromium.org/1464983003/ )

Reason for revert:
Seems to have caused issues with goma: https://code.google.com/p/chromium/issues/detail?id=560973

Original issue's description:
> Use sysroot by default for all linux builds
>
> Using a sysroot was already the default for official
> build and when cross compiling (e.g. arm, mips, x86-32).
> This change makes it the default in all cases.
>
> The old behavior of building against local
> system libraries can still be achieved by
> setting use_sysroot=0
>
> BUG=504446
>
> Committed: https://crrev.com/a931efd5dc8d8783ce73a64fc641627866b6869d
> Cr-Commit-Position: refs/heads/master@{#361197}

TBR=dpranke@chromium.org,thestig@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504446

Review URL: https://codereview.chromium.org/1473363002

Cr-Commit-Position: refs/heads/master@{#361405}

Reland of lemetry: Fix startup benchmarks so that all metrics get recorded. (patchset #2 id:70001 of https://codereview.chromium.org/1438533003/ )

Reason for revert:
Looks like my changes were still required to get the metric:

foreground_tab_request_start

https://code.google.com/p/chromium/issues/detail?id=560760&q=owner%3Aerikchen%40chromium.org&sort=-modified&colspec=ID%20Pri%20M%20Iteration%20ReleaseBlock%20Cr%20Status%20Owner%20Summary%20OS%20Modified

Original issue's description:
> Revert of telemetry: Fix startup benchmarks so that all metrics get recorded.
>
> Reason for revert:
> Theoretically, these changes should no longer be required, now that
> https://code.google.com/p/chromium/issues/detail?id=529340#c7 has landed.
>
> Original issue's description:
> > telemetry: Fix startup benchmarks so that all metrics get recorded.
> >
> > *PERF SHERRIF: if startup benchmarks become red, this CL is to be reverted.
> >
> > The lack of a page navigation was preventing the metric
> > Startup.FirstWebContents.NonEmptyPaint from being emitted. The addition of the
> > RAF logic check is to prevent theoretical race conditions - it may be overkill.
> >
> > BUG=513364
> > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
> >
> > Committed: https://crrev.com/0bc400e1c96da5a05379bc1b634ec278f36d3417
> > Cr-Commit-Position: refs/heads/master@{#347402}
>
> TBR=nednguyen@google.com
> BUG=513364
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
>
> Committed: https://crrev.com/359e8b1514eba38cb34d72443c223f49d1a55656
> Cr-Commit-Position: refs/heads/master@{#359024}

TBR=nednguyen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=513364

Review URL: https://codereview.chromium.org/1475773003

Cr-Commit-Position: refs/heads/master@{#361404}

This CL changes the buttons from being side-by-side (old style)
to being vertically listed (new mocks).

BUG=517564

Review URL: https://codereview.chromium.org/1465393002

Cr-Commit-Position: refs/heads/master@{#361403}

The chrome://tcmalloc page has been superseded by the memory-infra
category of chrome://tracing. The page no longer provides enough value
to justify its complexity in the codebase, so unlaunch it in the light
of Project Eraser.

Furthermore, this allows removing |base::allocator::GetStats|, which is
not used anywhere except in chrome:://tcmalloc. Detailed information
about memory allocators is available in the memory-infra category of
chrome://tracing. Unlike |GetStats|, which was implemented for tcmalloc
only, memory-infra provides detailed information about all allocators.

BUG=560250

Review URL: https://codereview.chromium.org/1468993003

Cr-Commit-Position: refs/heads/master@{#361402}

Should produce INVALID_OPERATION, not INVALID_VALUE, when number of
buffers != 1 when default back buffer is bound.

BUG=559359

Review URL: https://codereview.chromium.org/1473103002

Cr-Commit-Position: refs/heads/master@{#361401}

According to specification in media_pipeline_backend.h, GetCurrentPts is
only allowed to be called when backend is in playing/paused state. Thus
we shouldn't call the function after backend is stopped.

BUG=internal b/25852465

Review URL: https://codereview.chromium.org/1474573002

Cr-Commit-Position: refs/heads/master@{#361400}

The toggle buttons are enabled/disabled based on the appropriate
setting. The buttons currently toggle properties that will control the
collapsible sections. The collapsible sections will be added in
follow-up CLs.

BUG=546836

Review URL: https://codereview.chromium.org/1474473003

Cr-Commit-Position: refs/heads/master@{#361399}

This is not used and entirely dead-code-stripped by the linker (sadly this change doesn't make the binary any smaller).

Review URL: https://codereview.chromium.org/1466423003

Cr-Commit-Position: refs/heads/master@{#361398}

BUG=559362
TEST=conformance/textures/misc/cube-incomplete-fbo.html

Review URL: https://codereview.chromium.org/1465173002

Cr-Commit-Position: refs/heads/master@{#361397}

This adds several settings menu entries for sections that
were added without menu entries.

BUG=425627

Review URL: https://codereview.chromium.org/1474513004

Cr-Commit-Position: refs/heads/master@{#361396}

In a few places in the code, we have an HTML control and a label element,
and we want to know if that label is providing the name for that control.

It seems clean to call axObject.name() and check the returned nameFrom,
but computing the whole name has side effects (creating AXObjects of
descendants) so it caused a crash. Instead, nameFromLabelElement is simpler
and computes just what's needed.

This unfortunately duplicates a small amount of logic. I added comments to
hopefully avoid introducing more errors in the future.

BUG=558689

Review URL: https://codereview.chromium.org/1467423002

Cr-Commit-Position: refs/heads/master@{#361395}

BUG=508970

Review URL: https://codereview.chromium.org/1461553002

Cr-Commit-Position: refs/heads/master@{#361394}

The Physical Web Service should not have to send a results key if there
are no results (and it currently doesn't).  This change does a better
job of tolerating such responses.

BUG=556988

Review URL: https://codereview.chromium.org/1465923004

Cr-Commit-Position: refs/heads/master@{#361393}

This CL enabled toggling both the "Autofill settings" and "Manage
passwords" sections under "Passwords and Forms".

BUG=546836

Review URL: https://codereview.chromium.org/1457713007

Cr-Commit-Position: refs/heads/master@{#361392}

One of the assumptions of the newly added tests was violated under a sanitizer
build. This is not particularly surprising, so I disabled that check for
sanitizer builds.

> I added two tests for memory leaks in the attachment brokering process. The
> first checks memory usage after brokering a single, large, shared memory object.
> The second checks memory usage after brokering a thousand, smaller memory
> objects.
>
> BUG=557387
> Committed: https://crrev.com/a519e56d03e1f6d69b7475bdd006f5e47b4f581e
> Cr-Commit-Position: refs/heads/master@{#360935}

BUG=557387

Review URL: https://codereview.chromium.org/1464413002

Cr-Commit-Position: refs/heads/master@{#361391}

This is an optional CL.  There was a question from Micael about using named keys
for the menu options rather than an array index.  This CL shows what that would
look like.

Performance side-effect: inconsequential (measured by hand).

BUG=531786

Review URL: https://codereview.chromium.org/1420533011

Cr-Commit-Position: refs/heads/master@{#361390}

Or is it the other way around...

Review URL: https://codereview.chromium.org/1477433002

Cr-Commit-Position: refs/heads/master@{#361389}

Without these tooltips, there's no way to read long folder names.

BUG=551259

Review URL: https://codereview.chromium.org/1471003005

Cr-Commit-Position: refs/heads/master@{#361388}

https://chromium.googlesource.com/skia.git/+log/0a0605d4de31..0f6cca8a2070

$ git log 0a0605d4d..0f6cca8a2 --date=short --no-merges --format='%ad %ae %s'
2015-11-24 cdalton Optimize visualbench offscreen blits
2015-11-24 herb Change XPS to use find and place glyph.
2015-11-24 robertphillips Sniff out rects, ovals & rrects in SkGpuDevice::drawPath
2015-11-24 kkinnunen Generate list of GPU contexts outside ImageTest tests
2015-11-24 msarett Cherry pick one more commit into libjpeg-turbo
2015-11-24 robertphillips Upgrade debugger to print more SkPath info (isOval & isRRect)
2015-11-24 hendrikw skia: Holding onto the image in the benchmark causes issues
2015-11-24 robertphillips Clarify when oval & rrects get devolved to paths in SkGpuDevice/GrDrawContext boundary
2015-11-24 mtklein Add SK_BEGIN_REQUIRE_DENSE / SK_END_REQUIRE_DENSE.
2015-11-24 djsollen Whitespace change to trigger android automerger

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1469373002

Cr-Commit-Position: refs/heads/master@{#361387}

All Lo-Fi directives for the "Chrome-Proxy" header should be added by the
ContentLoFiDecider. This includes "q=low" and "exp=lofi_active_control".

BUG=539934

Review URL: https://codereview.chromium.org/1463583003

Cr-Commit-Position: refs/heads/master@{#361386}

This change affects E2ETests only, the test is still enabled
on chromium waterfalls.

BUG=559250

Review URL: https://codereview.chromium.org/1460923004

Cr-Commit-Position: refs/heads/master@{#361385}

Just have callers call ContextUtils.initApplicationContext instead, the
extra indirection isn't useful.

BUG=552419
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/1471273002

Cr-Commit-Position: refs/heads/master@{#361384}

Most Unix files end in newline, so by having the contents of
/proc/<pid>/cgroup by newline with SPLIT_WANT_ALL, the last entry was
always blank, triggering a NOTREACHED() and polluting the log. This
change uses SPLIT_WANT_NONEMPTY instead to get rid of empty lines.

BUG=548818
TEST=base_unittests --gtest_filter=ProcessTest.TestIsProcessBackgroundedCGroup

Review URL: https://codereview.chromium.org/1474483002

Cr-Commit-Position: refs/heads/master@{#361383}

This CL matches the GYP changes done in crrev.com/1462853002 for gn
build files.
In gn version, browser_extension, web_cache/browser already do not
depend on allocator.
chrome_child target already depends on allocator.
test_support_gpu does not exist in gn and content_browsertests directly
includes those dependencies.

All executables that are affected depend on allocator after this patch:
  browser_tests, chrome, chrome_app_unittests, interactive_ui_tests,
  performance_browser_tests, sync_integration_tests,
  sync_performance_tests, unit_tests, chromevox_tests

BUG=

Review URL: https://codereview.chromium.org/1469123002

Cr-Commit-Position: refs/heads/master@{#361382}

This CL does a refactoring of the dependencies and do not change any
behavior. The diff between the ninja files is presented in link:
http://pastebin.com/aG6eq5cb.

The test_support_gpu.gypi included allocator.gyp for no reason, and the
only other target that uses this file is content_browsertests, which
already includes allocatpor.gyp with same conditions. So, removing
this dependency here.

target:browser_ui - depends on allocator.gyp in windows
targets that depend on browser_ui:
  chrome_android_core: not used in windows

  Dependency on allocator.gyp exists already for:
  All, browser (explained below)

target:browser - depends on allocator.gyp in windows
targets that depend on browser:
  chrome_android_core: only android
  chromevox_tests: added dependency to allocator.gyp for windows

  Dependency on allocator.gyp exists already for:
    All, interactive_ui_tests, browser_tests, performance_browser_tests
    chrome_main_dll, chrome_initial, unit_tests, chrome_app_unittests

    test_support_sync_integration's executables:
      sync_integration_tests, browser_tests, sync_performance_tests

    test_support_common's executables:
      interactive_ui_tests, browser_tests, performance_browser_tests

    test_support_unit's executables:
      unit_tests

target:renderer - depends and exports dependency on allocator.gyp in
windows
targets that depend on renderer:
  chrome_android_core: not used in windows
  chromevox_tests: added dependency to allocator.gyp for windows
    chrome_child_dll - added dependency.

  Dependency on allocator.gyp exists already for:
    interactive_ui_tests, browser_tests, performance_browser_tests
    sync_integration_tests, chrome_main_dll, chrome_initial, unit_tests
    chrome_app_unittests

    test_support_common - explained earlier.

target:browser_extensions - depends on allocator.gyp in windows
targets that depend on browser_extensions:
  apps - browser (explained above)
  browser_ui (explained above)
  browser_chromeos
    browser (explained above)
    browser_tests
    apps - browser (explained above)

target:web_cache_browser - depends on allocator.gyp in windows
All the targets that depend on web_cache_browser already have
dependency on allocator.gyp:
  browser*, components_unittests

  extensions_browser
    extensions_unittests, browser_extensions*, apps*

    media_router
      browser_ui*, browser*, native_app_window - browser_ui*
      javascript_dialog_extensions_client - browser_ui*
      media_router_test_support
        browser_tests, test_support_unit*, unit_tests

    app_shell_lib
      extensions_browsertests, app_shell, app_shell_unittests

    extensions_test_support
      extensions_unittests, extensions_browsertests, app_shell_unittests
      test_support_common*

* - see previous sections for why it is fine for the target to not
depend on allocator.gyp

BUG=

Review URL: https://codereview.chromium.org/1462853002

Cr-Commit-Position: refs/heads/master@{#361381}

Deprecate FLAGS_quic_read_packets_full_recvmmsg.

Merge internal change: 107932700
https://codereview.chromium.org/1467453007/

removing a redundant way of checking if QUIC has pending crypto data.

Merge internal change: 107932405

Make QuicPacketCreator be able to serialize packet itself when it does not have room for next stream frame. No functional change expected.

For QuicPacketCreator, add DelegateInterface class, Flush function, move SerializePacket from public to private.
For QuicPacketGenerator, add OnSerializedPacket function, remove SerializeAndSendPacket.

Merge internal change: 107814957
https://codereview.chromium.org/1459343009/

These packets got reformatted at some point, maybe before the clang-format off annotation was added.

Merge internal change: 107790487

Get rid of unnecessary CompareSpdyHeaderBlocks method, use
operator== instead. No behavior change.

Merge internal change: 107784612

minor changes to batched write to make DCHECK happy.  Behind FLAGS_quic_batch_writes

Also includes a test fix to update bytes on the correct stream to get the no-op
we intended (rather than a no-op we didn't intend)

Merge internal change: 107783952
https://codereview.chromium.org/1472573002/

Deprecate FLAG_reset_cubic_epoch_when_app_limited.

Merge internal change: 107711408
https://codereview.chromium.org/1467453006/

Add ConsumeData method to QuicPacketCreator, ConsumeData wraps both CreateStreamFrame and AddFrame. No functional change expected.

Also move CreateStreamFrame from public to private in QuicPacketCreator.

Merge internal change: 107709890
https://codereview.chromium.org/1464153002/

Add WritePushPromise() method in QuicHeadersStream for server push.

Merge internal change: 107699435
https://codereview.chromium.org/1471583002/

Clear the connection's send alarm when a new ack is received.  Flag protected by FLAGS_quic_respect_send_alarm.

Merge internal change: 107697347
https://codereview.chromium.org/1466153002/

Remove the LOG(DFATAL) from QuicTestClient::address(), since it appears to be implemented.

Changing from QuicPriority to SpdyPriority.

Merge internal change: 107687942
https://codereview.chromium.org/1468773002/

Replacing EffectivePriority with Priority for QUIC.

The only place we had changing priority was "if the response headers were
serialized and not sent"  After we moved to having a separate headers stream
we never utilized the QuicWriter's header buffer, instead passing
headers directly to the QUIC layer which serialized them and sent them with
their own special priority.

Removing the idea of mutable priority enables having the write blocked list
track stream priorty, removing SPDY-specific logic from our shared code and
moving us closer to the new H2 style write scheduler logic.

Merge internal change: 107610692
https://codereview.chromium.org/1471573002/

Let QUIC streams write 16k before ceding. Behind FLAGS_quic_batch_writes.

Changing our round robin logic to prompt a given stream until it has finished
~16k (rounding up to the max quic packet payload).

Merge internal change: 107595145
https://codereview.chromium.org/1472563002/

Removing unused code to convert QUIC from SPDY3 to SPDY4

Now that QUIC version 24 is gone, we shouldn't need to worry about converting
headers from SPDY3 to SPDY4 as it should all be SPDY4

Merge internal change: 107581674
https://codereview.chromium.org/1463303002/

Cleanup: clang-formatting gfe/quic/quic_framer* to comply with Chromium style guide.

 clang-format -i --style="{BasedOnStyle: Chromium, Standard: Cpp11}"
 ./quic_framer*

Merge internal change: 107514106
https://codereview.chromium.org/1466693002/

QUIC proof source: allow construction with an |SSLContext| provider.

To support |SSLContext| swaps, the long-lived |ProofSourceChromium|
object must have a means of retrieving the new context.  The simplest
way to do that seems to be to pass in a getter method: the alternative
of calling |SSLGlobalData::ssl_context| is unavailable due to circular
dependencies.

n/a (Refactor. No functional change expected.)

Merge internal change: 107509393
https://codereview.chromium.org/1463603002/

Convert QuicPathIdPacketNumber struct to std::pair. Not used in production, no behavior change.

Chromium doesn't have the same support for custom hash functions. Makes it hard to port cl/106938391.

Merge internal change: 107505890
https://codereview.chromium.org/1465583002/

Fix bug in ReliableQuicStream::WritevData() where if the write failed and the connection was closed, the stream would attempt to mark itself write blocked leading to a crash in debug mode.

Merge internal change: 107452913
https://codereview.chromium.org/1458003004/

Deprecate FLAGS_quic_count_unfinished_as_open_streams.

Merge internal change: 107422215
https://codereview.chromium.org/1457233003/

Convince ASAN we're really not touching the factory pointers at the same time by adding explicit locks

n/a (test only)

Merge internal change: 107412764
https://codereview.chromium.org/1459163002/

R=rch@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1470713003

Cr-Commit-Position: refs/heads/master@{#361380}

Revert of Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking() (patchset #1 id:1 of https://codereview.chromium.org/1469823004/ )

Reason for revert:
This is incorrect. We missed setNeedsRepaint() of the PaintLayers between the object's enclosingLayer and paintInvalidationContainer's layer.

Original issue's description:
> Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking()
>
> To ensure layer is set needsRepaint().
>
> BUG=536999
> TEST=scrollbars/scrollbar-added-during-drag.html etc with sync painting enabled
>
> Committed: https://crrev.com/4c9d4570c68eddbc58f73b1fb4f4c95614bcf9d3
> Cr-Commit-Position: refs/heads/master@{#361179}

TBR=chrishtr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=536999

Review URL: https://codereview.chromium.org/1475483003

Cr-Commit-Position: refs/heads/master@{#361379}

|using| directives should not be global, but they should be used on a per-file bases.  Therefore they should not be placed in header files.

Review URL: https://codereview.chromium.org/1458163002

Cr-Commit-Position: refs/heads/master@{#361378}

Check for the isolate-extensions flag as well as --site-per-process.

BUG=532666

Review URL: https://codereview.chromium.org/1469153003

Cr-Commit-Position: refs/heads/master@{#361377}

Also using a no_sanitize list for SANITIZER_HOOK_ATTRIBUTE instead of
separate attributes per tool.

BUG=
R=glider@chromium.org

Review URL: https://codereview.chromium.org/1474733002

Cr-Commit-Position: refs/heads/master@{#361376}

https://pdfium.googlesource.com/pdfium.git/+log/8840ec9..3647692

R=thestig@chromium.org
BUG=555784,558840

Review URL: https://codereview.chromium.org/1466223003

Cr-Commit-Position: refs/heads/master@{#361375}

Re-enable conformance2/textures/misc/tex-storage-compressed-formats.html. This test is now passing.

Suppress const-array-init, tex-image-and-sub-image-3d*,
and floor-div-cos-should-not-truncate failures.

BUG=295792, 560555, angleproject:1179, angleproject:1198
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/1471943002

Cr-Commit-Position: refs/heads/master@{#361374}

BUG=295792
NOTRY=true

Review URL: https://codereview.chromium.org/1465993003

Cr-Commit-Position: refs/heads/master@{#361373}