- 28 Feb, 2020 40 commits
-
-
Shuangshuang Zhou authored
This modification changes two trace operations for "GetDecodedImageForDraw()" and "DrawWithImageFinished()" from "cc"to "cc.debug" category. While running Canvas 2D workloads with quite a lot canvas elements to be drawn, excessive trace operations introduce expensive performance overheads, especially for those hardware platforms with integrated graphics cards or old graphics drivers. Bug: 1051385 Change-Id: I7cb1b7a3afcb207ac6b7791f21dc621a20e42864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059771Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#745468}
-
Oriol Brufau authored
LayoutObject::AnonymousHasStylePropagationOverride is only called from LayoutObject::PropagateStyleToAnonymousChildren, but only for anonymous layout objects with a kPseudoIdNone style type. However, LayoutListMarkers are no longer anonymous and they have a kPseudoIdMarker style type. So the override is not used. BUG=457718 Change-Id: Iae2bee6e9f68cdba1cd17529ecae73938f162c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080264Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#745467}
-
Peter Kasting authored
Bug: none Change-Id: Ieb7be7b5f7f257d1bc9631153d5cf8f0b5d8f482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079939 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#745466}
-
Justin Cohen authored
Change-Id: I2cd296f3a8b4e0af505331200ef9cbb531ada878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079171 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#745465}
-
Thomas Tellier authored
Change-Id: I178594815e130a335ee2f23d420556cd7e1a14ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080426Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#745464}
-
Toni Barzic authored
On certain devices, the user will have an option to swipe from the shelf on the last OOBE/first user run screen to end OOBE and enter the session. This adds a hook to login_screen interface that OOBE screen implementation can use to enable gesture detection on login shelf, and through which to get notified when the user swipes up. Also, implements upward fling detection for login shelf (done by login_shelf_gesture_controller, owned by shelf_widget) - when the gesture detection is active, login shelf shows a drag handle with a "contextual nudge" text above it. Updates DragHandle API to support color/opacity changes, so the drag handle appearance can be updated to match the login shelf controls on OOBE and login screen. BUG=976949 Change-Id: I670358c97de58c3f75ada9103df8098cc5074908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073541Reviewed-by:
-
Henrique Nakashima authored
CachedFeatureFlags deals with caching generic flags to SharedPrefs. Bug: 1012975 Change-Id: Ibe5912622a73e7a6b984b1dc3746dd775a0b711b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079341Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#745462}
-
Miguel Casas authored
This CL adds code for populating the necessary gfx::DisplayColorSpaces in CreateManagedDisplayInfo for supporting SDR and HDR target color spaces (depending on the monitor capabilities and the big hdr flag). It needs a sibling CL to allow AR/B30 FBs on CrOs crrev.com/c/2078655, Tested with that CL and by playing an HDR video: the primary framebuffer format in /sys/kernel/debug/dri/0//state correctly changes to XB30, whereas when there are not HDR quads in the BufferQueue, it's XR24. Bug: 958166 Change-Id: I94638436c079b03ef9f6200b77697b1d3da9337e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072621Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#745461}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bfa4dadb..6045fb83 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie15452d9c38f5bd0b006e9879d23c177969de8e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079634Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745460}
-
Liviu Tinta authored
When there is text that overflows an input element, the scroll event is not fired when the text scrolls into view. The input element never receives the scroll event from the user agent shadow DOM internal editor element. The fix is to change the scroll event's target to the shadow host element when the event is generated. Bug: 989937 Change-Id: Iff4aeae6adb931d681a2ade72eb8032c5a23067c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064818 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#745459}
-
Henrique Nakashima authored
Bug: 1012975 Change-Id: Ic57e9d4aff392373c0ec9b5bf178b3e1701fea79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079541Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#745458}
-
Juan Pablo de Lima authored
Change-Id: Ie9413eeba4879b97ac9493e7d4a7d7e1bb0a0ff8 Bug: b:132772120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047377 Commit-Queue: Juan Pablo De Lima <jpdelima@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Auto-Submit: Juan Pablo De Lima <jpdelima@chromium.org> Cr-Commit-Position: refs/heads/master@{#745457}
-
Mark Cogan authored
Changes RecentTabsViewController to accept a Browser instead of separate WebStateList and BrowserState inputs. This will make future refactoring more straightforward. (There remains a great deal of work to do to fully refactor Recent Tabs to properly factor responsibilities into a mediator and coordinator). Bug: 845192 Change-Id: I068b0a343752dba602d2a2226cd0bcf327873446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078452 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/05f5e0b34ac8..3e5fe285a7ef git log 05f5e0b34ac8..3e5fe285a7ef --date=short --first-parent --format='%ad %ae %s' 2020-02-28 jonahr@google.com Add missing attribute to eglGetConfigAttrib Created with: gclient setdep -r src/third_party/swiftshader@3e5fe285a7ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1015454 Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie235d20c90ac5d35a4769566be6b2f1307a19a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080300Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745455}
-
Peng Huang authored
Bug: None Change-Id: I78552786fa44682bea1b0e0f0d386aa582bc97f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072926Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#745454}
-
kylechar authored
The tests were still occasionally timing out when marked slow so mark as Timeout Pass instead. TBR=jonross@chromium.org Bug: 1026375 Change-Id: I1631b5ee9a4826fb4382eb9088de1288b919c346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080431Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#745453}
-
Fredrik Söderquist authored
Missing negation in the "d presentation attribute not supported on other elements" subtest in ...-special-cases.html test. Set 'irrelevantElement' to null for 'd', 'height', 'r', 'rx', 'ry', 'transform', 'width', 'x' and 'y' since they are all mentioned in the table in the spec[1] as being special. They are also covered by the ...-special-cases.html test. The definition of 'Applies to' for the 'transform' attribute varies slightly between the SVG specification and CSS transforms specifications, so this applies essentially the intersection of those two. [1] https://svgwg.org/svg2-draft/styling.html#PresentationAttributes Bug: 1056055 Change-Id: Id7a6e604d4f48abbd601bdc09ec9f7ff795b86ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078581Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#745452}
-
Alexander Timin authored
At the moment we are accidentally marking kBackForwardCache feature and associated trial as active even when it is disabled by low-memory config. Add a test to ensure that it does not regress in the future. R=arthursonzogni@chromium.org,sreejakshetty@chromium.org BUG=1057081 Change-Id: I057ca3a942704eab139c1846dfa87b86e2daedec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080416Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745451}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/141da028168e..216e077600a5 git log 141da028168e..216e077600a5 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 bungeman@google.com [truetype] Add better checks for loading `gvar' table (#57905). Created with: gclient setdep -r src/third_party/freetype/src@216e077600a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: 1055577 Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I4f5556f97d3914f5682fc89258e27f217a57763b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080043 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
-
Stepan Khapugin authored
Adds a check before dereferencing self.webState. Bug: 1055334 Change-Id: Iaa046b5975d72cb7632783289ed9fdb9088a15f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080418 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#745449}
-
Bruce Long authored
WindowsSpellChecker::GetSupportedWindowsPreferredLanguages is only used in a unit test. The plan to support toggling on spellchecking for languages such as Arabic that have Windows spellcheck dictionaries but not Hunspell dictionaries has changed. We will now use the ISpellCheckerFactory::get_SupportedLanguages spellchecker API to get a list of installed Windows dictionaries, which will supplement the hardcoded list of Hunspell languages (future CL). See following for discussion: Windows Spellcheck: Should only be performed for the preferred languages listed in Windows settings https://bugs.chromium.org/p/chromium/issues/detail?id=1000443#c20 Bug: 1000443 Change-Id: I49c220ca76ff2991ee79b6184bc0616724a97267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079651Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Bruce Long <brlong@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745448}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a3900fb33dc..bde9fcce155f git log 0a3900fb33dc..bde9fcce155f --date=short --first-parent --format='%ad %ae %s' 2020-02-28 kjlubick@google.com [canvaskit] Precise font measuring Created with: gclient setdep -r src/third_party/skia@bde9fcce155f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I4a8c19492e25c3bd50a6de7dd74f98dc59f85ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080302Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I8aed766371f6422df1ac671e8a6a0d12fdea8a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079729Reviewed-by:
-
Sam Sebree authored
This change uses the -internal-light-dark-color css property to set correct dark mode styling on text input and text area native controls. It also modifies the dark-color-scheme virtual test suite to run with the updated flag "CSSColorSchemeUARendering" Bug: 929098 Change-Id: Id3a632ac19b3705a74b7c098b64773fb98436e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071488Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745445}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/29c52f9cafce..4eca785b40e3 git log 29c52f9cafce..4eca785b40e3 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 aerotwist@chromium.org [e2e] Ensures console messages are populated 2020-02-28 tvanderlippe@chromium.org Fix copy-paste error on dir check 2020-02-28 aerotwist@chromium.org Updates boot perf timing to be 2 decimal places 2020-02-28 aerotwist@chromium.org [e2e] Migrate http/tests/devtools/search/sources-search-scope.js to e2e 2020-02-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-28 tvanderlippe@chromium.org Fix clicking on labels for checkboxes 2020-02-28 jacktfranklin@chromium.org Ensure we import `errno` in ts_library.py 2020-02-28 jacktfranklin@chromium.org Remove `String.prototype.computeLineEndings` 2020-02-28 jacktfranklin@chromium.org Typecheck EventTarget.js 2020-02-28 jacktfranklin@chromium.org TypeScript CharacterIdMap_test into Ninja 2020-02-28 aerotwist@chromium.org [perf] Updates boot perf test 2020-02-28 jacktfranklin@chromium.org Typecheck Common.UIString 2020-02-28 tvanderlippe@chromium.org Reland "Typescriptify FormattedContentBuilder + move tests" 2020-02-28 szuend@chromium.org Prepare BreakpointManager.js for asynchronous source mapping 2020-02-28 mathias@chromium.org Revert "Typescriptify FormattedContentBuilder + move tests" 2020-02-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-27 tmathmeyer@chromium.org Switch the Media tab to ES Modules 2020-02-27 joselea@microsoft.com Fix Grid accessibility name. 2020-02-27 jacktfranklin@chromium.org Move Trie test to being built with Ninja 2020-02-27 jacktfranklin@chromium.org Typescriptify FormattedContentBuilder + move tests 2020-02-27 kahinds@microsoft.com Remove transparent border-top from Elements tree rows 2020-02-27 tvanderlippe@chromium.org Run TypeScript without building mode 2020-02-27 jacktfranklin@chromium.org Update screenshot testing to enable element screenshots Created with: gclient setdep -r src/third_party/devtools-frontend/src@4eca785b40e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1011811,chromium:1032016,chromium:1032561,chromium:1046784,chromium:1048378,chromium:1050549,chromium:1051458,chromium:1054925,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I03cdc3a9812b25c683bf9ddb415064f5a260ef8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080301Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5f999a777d92..0fb07f8c90ae git log 5f999a777d92..0fb07f8c90ae --date=short --first-parent --format='%ad %ae %s' 2020-02-28 hta@webrtc.org Deprecate use of cricket::MediaContentDescription::Copy Created with: gclient setdep -r src/third_party/webrtc@0fb07f8c90ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3ce2eb3b58bfc238a4044f7deb26c673469ce3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080298Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a165d9d1. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 98c33104 "[webauthn] WPT: Clean up virtual authenticators" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I8b546e412689c0d5a2de39cfde19bdb878855774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079633Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745442}
-
Stephen McGruer authored
This diff was generated by running: find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*"[A-Za-z_]*") *(, *.)/assert_throws_dom(\1\2/gs' Then manually correcting some whitespace errors and one expectation file. Bug: 1051932 Change-Id: Ie6beffd8e61d2dfeaa480eb6024d6dea33fefb72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079046 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#745441}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/70ba66cdbc23..82da15f4f07e git log 70ba66cdbc23..82da15f4f07e --date=short --first-parent --format='%ad %ae %s' 2020-02-28 cepheus@frii.com Fix #2091, remove incorrect assert for division by 0.0. Created with: gclient setdep -r src/third_party/glslang/src@82da15f4f07e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I6212b870287e1399e303322eef4b3be09d496f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080297Reviewed-by:
-
Pavel Yatsuk authored
Currently InfoBarIdentifier class generated from enum in infobar_delegate.h is only available as a source file to be included through srcjar_deps. This makes it impossible to refer to it from both chrome/android and chrome/browser. This CL adds an android_library target for the generated file, allowing it to be referred from multiple targets through deps. BUG=1056346 R=pkasting@chromium.org,twellington@chromium.org Change-Id: I054fb864c7503006e6aa8bf3fc0aedc22d3c8d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079833Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Nazerke authored
This CL modernizes the IdentityChooserCoordinator to use |browser| in the initializer. Bug: 1029346, 1048410 Change-Id: I6b5440e2124c9d62060bc6eba70446c7fcb1ae5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078476Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#745438}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d33ca0263565..c1503990b2d3 Created with: gclient setdep -r src-internal@c1503990b2d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I42be4d943b1eaf9ccaa3d0d04ea6bf3939a5d151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080296Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745437}
-
Simon Zünd authored
String#trimURL is moved into a utility function upstream. The web test is already replaced by an existing Karma unit test, so it's safe to remove this web test. Frontend change: https://crrev.com/c/2078930 R=mathias@chromium.org Bug: chromium:1050549 Change-Id: Idfcd14c200cfa74ef9240041700d127b614cc2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080263Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#745436}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I672a6329f45383f078780f345ee93c59996c52d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079460Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745435}
-
Oriol Brufau authored
LayoutListMarker used to have a list_item_ member that was a pointer to the LayoutListItem that originated the marker. Now that markers are tree-abiding psedudo-elements, we can just get the pseudo-element node of the LayoutListMarker, retrieve its parent node, and obtain is associated LayoutObject. So this patch removes the no longer needed list_item_. This should have no effect in practice. BUG=457718 Change-Id: Ic4c4b1262feae32474fb279f2da7017ab081eeb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079112 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Rushan Suleymanov authored
This patch fixes the case when the sync service is restarted while device info bridge is loading. Check that the device info provider was actually initialized, IsTrackingMetadata does not guarantee that because the code right after calling ModelReadyToSync might not run yet. Bug: 1055584 Change-Id: Id0c8252bde40ba8814a48a3c06f8e628612b0f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072377Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#745433}
-
Jose Lopes authored
This callback is used to report that the DecodeFrame operation is complete, therefore it's a once callback. Documentation: * https://cs.chromium.org/chromium/src/media/cast/receiver/audio_decoder.h?rcl=292ee8149fd602c22de27e034db2fd7b1113cb8d&l=21 The callback is executed via PostTask: * https://cs.chromium.org/chromium/src/media/cast/receiver/audio_decoder.cc?rcl=292ee8149fd602c22de27e034db2fd7b1113cb8d&l=67 * https://cs.chromium.org/chromium/src/media/cast/receiver/audio_decoder.cc?rcl=292ee8149fd602c22de27e034db2fd7b1113cb8d&l=81 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Id6822683089aa7547171d97a33aa14c0842f97d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074480 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#745432}
-
David Roger authored
TBR=ganesh Bug: 1055470 Change-Id: Iece9e9d0f62739ead1c32b529b0bf2f80761e7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080356Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#745431}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8c6e40d2264e..1e1d74467e0d git log 8c6e40d2264e..1e1d74467e0d --date=short --first-parent --format='%ad %ae %s' 2020-02-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 07e1a0a67aee..f13d38f3cd3c (1 commits) 2020-02-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 38f68cce445b..8c312ef4c7a9 (5 commits) Created with: gclient setdep -r src/third_party/angle@1e1d74467e0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I33e4f4f5ff225857687f552ae9c5070b1043d6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080294Reviewed-by:
-
Tim van der Lippe authored
These tests were ported in https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2074760 and https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2077665 and run on the DevTools CQ. Bug: 1044632 Change-Id: Ie68e4ffc2d1a1145d08e564e9d6e0aad79d4509f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077737 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#745429}
-
