- 22 Jul, 2014 40 commits
-
-
chrishtr@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/401053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284634 0039d316-1c4b-4281-b951-d872f2087c98
-
jungjik.lee@samsung.com authored
1. android uses stlport in ndk library, and this library does not have same demangled name with libc++ stl. so we can get rid of tc-std-* from android policies. 2. tc-stl-node and tc-stl-vector have same stackstrace. so I changed std-node to std-other to hook all other std mallocs. 3. tc-toplevel-string regex has changed. Bug=None NOTRY=True Review URL: https://codereview.chromium.org/387313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284633 0039d316-1c4b-4281-b951-d872f2087c98
-
hans@chromium.org authored
It needs to depend on the allocator gyp target to pick up the /NODEFAULTLIBS flags for libcmt.lib and libcmtd.lib and avoid link errors about multiple definitions of allocation related symbols. BUG= TEST=extensions_unittests links in non-components Debug build on Win Review URL: https://codereview.chromium.org/394353008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284632 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
The file names now match the class name. BUG=none TEST=none R=estade@chromium.org Review URL: https://codereview.chromium.org/404553008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284631 0039d316-1c4b-4281-b951-d872f2087c98
-
rouslan@chromium.org authored
VisualStudio does not understand it \u escape sequences like \u00E8 in UTF8 strings. The fix is to use Wide strings and convert them into UTF8 using base::WideToUTF8() utility. BUG=395401 Review URL: https://codereview.chromium.org/403233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284629 0039d316-1c4b-4281-b951-d872f2087c98
-
owenlin@chromium.org authored
BUG=None TEST=Run the vda_unitest on GLX and EGL machines. Review URL: https://codereview.chromium.org/400353007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284628 0039d316-1c4b-4281-b951-d872f2087c98
-
horo@chromium.org authored
[ServiceWorker] Propagates ServiceWorker fetched response's URL and wasFetchedViaServiceWorker flag. If the request was fetched via a ServiceWorker, the URL of the response could be different from the URL of the original request. The URL must be checked in the renderer process for CSP and CORS. So in this patch I introduce was_fetched_via_service_worker flag and original_url_via_service_worker which are set in ServiceWorkerURLRequestJob and propagated to the renderer process. This change depends on http://crrev.com/370733002 and http://crrev.com/378473002. BUG=373120 Review URL: https://codereview.chromium.org/375513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284627 0039d316-1c4b-4281-b951-d872f2087c98
-
ksakamoto@chromium.org authored
Revert of Disable exceptions on Windows also in the shared_library build (https://codereview.chromium.org/404853002/) Reason for revert: Speculative revert to try to fix chrome_elf_unittests on Win7 x64. http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%282%29/builds/18370 AddDllsFromRegistryToBlacklist LoadBlacklistedLibrary I'll reland if that's not it. Original issue's description: > Disable exceptions on Windows also in the shared_library build > > They were previously only disabled in static_library builds. This is believed > to have been due to problems with old MSVC versions, but it should work now. > > This change is relevant for Clang, which currently doesn't support exceptions > on Windows. > > Last time I attempted to do this, it broke some tests due to a debug assertion. > Gtest had previously been catching the exception, but with exceptions disabled > it crashed. Those tests were actually broken in static_library Debug builds > too, but we don't seem to have bots for that. After Blink r176189, we no longer > hit that debug assertion, so the tests now pass. > > BUG=82385 > TEST=blink_platform_unittests --gtest_filter=DateTimeFormatTest.CommonPattern, > content_browsertests --gtest_filter=RenderViewImplTest.SetEditableSelectionAndComposition > webkit_unit_tests > > R=thakis@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284519 TBR=maruel@chromium.org,thakis@chromium.org,hans@chromium.org NOTREECHECKS=true NOTRY=true BUG=82385 Review URL: https://codereview.chromium.org/410613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284626 0039d316-1c4b-4281-b951-d872f2087c98
-
cpu@chromium.org authored
On Windows the message pump code tried to manage the systemwide timer resolution to fire delayed tasks with better than 15ms resolution but it was buggy: 1- A short task that was not followed by any other task will leave the systemwide timer pegged to 1ms 2- After we decided to crank up the timer we would 'lease' the timer for 1 second, for no good reason. Both issues are detrimental to battery power. The source of both problems is that we tried to decide with incomplete information. This patch solves that by having 1 bit for each pending task that requires a high resolution timer and a sum of the number of tasks that require high res timers. BUG=153139 TEST=included here, also see the bug for manual testing. Review URL: https://codereview.chromium.org/395913006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284625 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
Subsequent calls to EmbedRoot are now delegated to the window manager. This allows an application that was not created via the embed flow to obtain a connection to the view manager by asking the view manager init service to embed it somewhere. The init service just forwards this to the window manager. This is effectively like asking the window manager to create a toplevel window. R=sky@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284322 Review URL: https://codereview.chromium.org/403083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284624 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
invalidation_util.cc has the following include: invalidation_util.cc is in the target sync_internal_api. sync_internal_api doesn't depend on cacheinvalidation_proto_cpp which is what generates types.pb.h. BUG=395846 TEST=none R=tim@chromium.org Review URL: https://codereview.chromium.org/410503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284623 0039d316-1c4b-4281-b951-d872f2087c98
-
jackhou@chromium.org authored
Since hiding Chrome hides all apps, this informs the shims that their app is hidden. This ensures that a unhide is fired when the shim is next focused. BUG=355397 Review URL: https://codereview.chromium.org/403743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284622 0039d316-1c4b-4281-b951-d872f2087c98
-
lambroslambrou@chromium.org authored
Ensure that the members are fully cleaned up during disconnection, before the object gets destroyed (which can happen on a random thread). Otherwise the members may be destroyed on the wrong thread, triggering DCHECKs. BUG=395312 Review URL: https://codereview.chromium.org/406123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284621 0039d316-1c4b-4281-b951-d872f2087c98
-
benchan@chromium.org authored
https://chromium-review.googlesource.com/207610 modified cros-disks to report, via the GetDeviceProperties DBus method, if a disk is on a removable device. This CL updates the CrosDisksClient to make sure of that. BUG=393345 TEST=Unit tests and manually tested a few removable USB/SD media. Review URL: https://codereview.chromium.org/391783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284620 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284613 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
BUG=395357 Review URL: https://codereview.chromium.org/404613007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284611 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
These crept in from a changelist written before the refactor which landed after it. BUG=394944 Review URL: https://codereview.chromium.org/400673006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284610 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
Both BULID files and source code were checking for a Chrome-branded build, but not also an Official build type. BUG=388419 TBR=piman@chromium.org Review URL: https://codereview.chromium.org/406523006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284609 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284608 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/ad1df153a16b7723d2d4afd13627919fc3ee87ce..b85a0aab6905af8b329539b7573a7555b727d5e5 CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel TBR=robertphillips@google.com BUG= Review URL: https://codereview.chromium.org/408073003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284607 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
Without PurgePluginListCache(), the plugin list info in existing renderer processes is not updated. User has to close the original tab and open a new tab to be able to load the plugin. BUG=394988 TEST=CDM loaded after refreshing tab after CDM update now. Review URL: https://codereview.chromium.org/400273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284606 0039d316-1c4b-4281-b951-d872f2087c98
-
huangs@chromium.org authored
This CL does 2 things: 1. The setting of App Launcher dr=1 is now only used for GOOGLE_CHROME_BUILD. 2. Refactoring: In r273321, we extracted AppRegistrationData from BrowserDistribution, and make it part of BrowserDistribution by composition. In this CL, we use this new flexibility, and cut the dependence of app_list_service_win.cc on ChromeAppHostDistribution by just giving it the AppRegistrationData part it needs. The required const kAppLauncherGuid now lives in chrome_launcher_support. BUG=297647 Review URL: https://codereview.chromium.org/374413004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284605 0039d316-1c4b-4281-b951-d872f2087c98
-
ksakamoto@chromium.org authored
Revert of cc: Change TileManager iterators to be queues. (https://codereview.chromium.org/406543003/) Reason for revert: TileManagerTilePriorityQueueTest.EvictionTilePriorityQueueWithOcclusion consistently times out on Win7 bot http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/29899 Original issue's description: > cc: Change TileManager iterators to be queues. > > This patch is mostly just moving code around. It moves the iterators > from tile manager to be in separate files, renames them to be queues. > > It also adds a tile manager client interface for building the queues. > > The rest is just fix ups for the tests. > > R=reveman > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284506 TBR=reveman@chromium.org,vmpstr@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/406183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284604 0039d316-1c4b-4281-b951-d872f2087c98
-
noms@chromium.org authored
Before: https://drive.google.com/file/d/0B1B1Up4p2NRMLTQ1ZFc0blIwbzA/edit?usp=sharing After: https://drive.google.com/file/d/0B1B1Up4p2NRMVUloNWhYY1luQjg/edit?usp=sharing BUG=NONE TEST=Start Chrome with --new-profile-management. Click on the avatar button. The bubble's right edge should be perfectly aligned to the button's edge. Review URL: https://codereview.chromium.org/404443008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284603 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Instead, just use plain gdb, which should be able to handle 32-bit binaries. NOTRY=true Review URL: https://codereview.chromium.org/404303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284602 0039d316-1c4b-4281-b951-d872f2087c98
-
dcheng@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/409673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284601 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=160586 Review URL: https://codereview.chromium.org/385263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284600 0039d316-1c4b-4281-b951-d872f2087c98
-
fmeawad@chromium.org authored
Adding an Init method to the Broadcaster, that gets invoked while initializing the host. The Init method broadcasts the original on_power_battery value to the new processes. BUG=153139 Review URL: https://codereview.chromium.org/401083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284599 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
Mostly mechanical change to finish migrating time-related methods from AudioRenderer to TimeSource. BUG=370634 Review URL: https://codereview.chromium.org/403723006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284598 0039d316-1c4b-4281-b951-d872f2087c98
-
ericzeng@chromium.org authored
This CL applies the default system font style to extension pages. Extensions that specify their own fonts will still override these styles. BUG=141703, 395319 Review URL: https://codereview.chromium.org/400343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284597 0039d316-1c4b-4281-b951-d872f2087c98
-
zhaoqin@google.com authored
R=bruening@chromium.org NOTRY=TRUE BUG=NONE Review URL: https://codereview.chromium.org/406853003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284596 0039d316-1c4b-4281-b951-d872f2087c98
-
bolian@chromium.org authored
Review URL: https://codereview.chromium.org/398823010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284595 0039d316-1c4b-4281-b951-d872f2087c98
-
rucifer1217@gmail.com authored
BUG=none Review URL: https://codereview.chromium.org/396273004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284594 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
src/extensions depends on chrome::NOTIFICATION_PROFILE_CREATED to support deferred loading of extension background pages when the profile isn't ready yet. This is a layering violation. * Remove Chrome concepts like "browser window ready" and "profile created" from ProcessManager. Introduce ProcessManagerDelegate with a general concept of deferring background page loading. * Consolidate all the tricky Chrome-specific background page loading rules into ChromeProcessManagerDelegate. This keeps all the rules in one place. Annotate each block of special case code with the bug that inspired it. * Extend unit test coverage for ProcessManager. This will make it easier to eliminate chrome::NOTIFICATION_PROFILE_DESTROYED in ProcessManager in a later CL. (Original CL https://codereview.chromium.org/381283002 broke valgrind bots because it was initializing left-over BrowserContextKeyedServices from tests running earlier in the same process.) BUG=392658 TEST=unit_tests ProcessManagerTest, browser_tests ProcessManagerBrowserTest, manual Review URL: https://codereview.chromium.org/408523005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284593 0039d316-1c4b-4281-b951-d872f2087c98
-
chrishtr@chromium.org authored
This makes lookups of a WebPreferences field fast. In order do this, add code to listen to all preferences updates in order to recompute the cache. BUG=390799 Review URL: https://codereview.chromium.org/373323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284592 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
Frameworks destroys the underlying EGLContext on after certain levels of onTrimMemory, so webview must also release its hardware draw resources to avoid using stale references. Factor out release hardware resource code in aw_contents.cc and browser_view_renderer.cc, and call it in onTrimMemory. BUG=395657 Review URL: https://codereview.chromium.org/408803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284591 0039d316-1c4b-4281-b951-d872f2087c98
-
jamescook@chromium.org authored
The previous version of this test could create up to 4 TestingProfiles: 1. TestingProfile from BrowserWithTestWindowTest::CreateProfile 2. TestingProfileWithHostZoomMap in the test body 3. An incognito version created by (2) via GetOffTheRecordProfile(). 4. An incognito version created in the test body Also the master/incognito relationships between these profiles are unclear. Reduce this to the 2 needed instances: 1. TestingProfileWithHostZoomMap owned by BrowserWithTestWindowTest 2. An incognito version in the test body BUG=395329 TEST=unit_tests OffTheRecordProfileImplTest.* Review URL: https://codereview.chromium.org/403103003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284590 0039d316-1c4b-4281-b951-d872f2087c98
-
aiguha@chromium.org authored
This CL contains the implementation of PortAllocatorFactoryInterface in peerconnectioninterface.h. It bridges the gap in port allocation objects between WebRTC and Chromium. The factory produces a ChromiumPortAllocator that can successfully be used by the PeerConnection API. Review URL: https://codereview.chromium.org/398813003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284589 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
With compositing enabled by default this UMA always reports "active". Review URL: https://codereview.chromium.org/405963004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284588 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
BUG=381484 TEST=Tested on Windows. Review URL: https://codereview.chromium.org/404613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284587 0039d316-1c4b-4281-b951-d872f2087c98
-