GitLab

Adjust underline positions so the lines won't get clipped. I
think that the inaccuracy may be occurring due to our
conversion from PangoFontDescriptions (usually containing a
point-based size) to a rounded pixel-based size and then
back to a PangoFontDescription. Luckily, RenderTextPango
will be replaced by RenderTextHarfBuzz soon.

Also delete some dead code in PlatformFontPango for
computing underline metrics.

BUG=393117
TEST=manual: checked that the "Import bookmarks now..."
     underline is visible after setting my UI font to
     "Ubuntu 11"

Review URL: https://codereview.chromium.org/509093004

Cr-Commit-Position: refs/heads/master@{#292537}

BUG=408251
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/519523002

Cr-Commit-Position: refs/heads/master@{#292536}

In [[Install]] algo. of the latest spec, register() resolves a promise
with a registration object after the worker enters the installation
process. This means the registration needs to set its .installing field
before the register promise is resolved.

But, before this patch, the registration cannot do so before resolving
the register promise because its proxy is set when the registration is
passed to the blink.

This change makes the registration queue notifications of worker version
and 'updatefound'. Once the proxy becomes ready, the registration handles
them.

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#installation-algorithm

BUG=399533,406240
TEST=content_unittests --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py http/tests/serviceworker

Review URL: https://codereview.chromium.org/516873002

Cr-Commit-Position: refs/heads/master@{#292535}

Any thoughts?

BUG=

Review URL: https://codereview.chromium.org/510203002

Cr-Commit-Position: refs/heads/master@{#292534}

BUG=110610

Review URL: https://codereview.chromium.org/511183002

Cr-Commit-Position: refs/heads/master@{#292533}

Revert of Fix the Copresence permission. (patchset #1 of https://codereview.chromium.org/523433002/)

Reason for revert:
This change causes a test failure:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/48008/steps/unit_tests/logs/stdio

Error:

[ RUN      ] PermissionsTest.PermissionMessages
../../chrome/common/extensions/permissions/permission_set_unittest.cc:781: Failure
Value of: permission_info->message_id()
Actual: 65
Expected: PermissionMessage::kNone
Which is: 1
unexpected message_id for copresence

Looks like this change is the cause.

Original issue's description:
> Fix the Copresence permission.
>
> The initializer for the Copresence permission is malformed. It specifies the
> message id instead of the flag.
>
> R=kalman@chromium.org
> BUG=408843
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/c2a41e8

TBR=kalman@chromium.org,rkc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=408843

Review URL: https://codereview.chromium.org/520493002

Cr-Commit-Position: refs/heads/master@{#292532}

This value was added to the code in commit position 292033.

R=isherman@chromium.org
CC=robertshield@chromium.org
BUG=394352
NOTRY=true

Review URL: https://codereview.chromium.org/515313004

Cr-Commit-Position: refs/heads/master@{#292531}

This CL fixes two issues.
. It brings up a scroll bar if the text in the feedback window doesn't fit in
  the space available on screen (this happens when the user sets the page zoom
  too 120% or above)
. Sets the focus to the description field when the feedback app starts.

R=xiyuan@chromium.org
BUG=295999,330139

Review URL: https://codereview.chromium.org/511393002

Cr-Commit-Position: refs/heads/master@{#292530}

If we're running a test image or have the --disable-demo-mode flag specified
we should not be launching demo mode. The channel check doesn't exist for the
HID screen. This CL moves the check into the main demo mode detector so if it
is called from anywhere, the check is always performed.

R=xiyuan@chromium.org
BUG=398271

Review URL: https://codereview.chromium.org/514273003

Cr-Commit-Position: refs/heads/master@{#292529}

Test is flaky. See bug for details.

NOTRY=true
TBR=nkostylev@chromium.org
BUG=408867

Review URL: https://codereview.chromium.org/522453004

Cr-Commit-Position: refs/heads/master@{#292528}

Nest a QUIC SerializedPacket inside a QUIC QueuedPacket.

Merge internal change: 74239145
https://codereview.chromium.org/509203003/

Remove PacketType from QUIC because the QUEUED type is not used and the
other types can be reduced to a bool.

Merge internal change: 74148481
https://codereview.chromium.org/515003003/

Don't send a QUIC SCUP message until after handshake confirmed.

A server config update was occasionally being sent before the crypto
handshake was complete, causing the client to close the connection.

Merge internal change: 74132773
https://codereview.chromium.org/516713002/

Change TransmissionInfo's all_transmissions SequenceNumberSet* to
default to NULL, and only be present if there are multiple transmissions.

Estimated to save ~2% of CPU.

Merge internal change: 74076012
https://codereview.chromium.org/509073004/

Log the quic version for internal server tracing.
Not used in production.

Merge internal change: 74069715
https://codereview.chromium.org/514043002/

Optimize QuicUnackedPacketMap by changing from a LinkedHashMap to a
deque.

Estimated to save ~3% of CPU based on pprof profiling of 100 large gets
on tools/quic/end_to_end_test.cc.

Merge internal change: 74054196
https://codereview.chromium.org/514033002/

Unit test for empty packet closes QUIC connection bug.

Merge internal change: 74041239
https://codereview.chromium.org/495423011/

Log the QUIC transmission type in QUIC internal server trace visitor.
Not used in production.

Merge internal change: 73895739
https://codereview.chromium.org/514023002/

Not used in production. Log whether a QUIC packet sent was a crypto
packet or not for internal server side tracing.

Merge internal change: 73894063
https://codereview.chromium.org/515003002/

Fix a QUIC bug in which PING frames were not being ACK'd.

Merge internal change: 73837644
https://codereview.chromium.org/512933005/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/515303003

Cr-Commit-Position: refs/heads/master@{#292527}

https://skia.googlesource.com/skia/+log/60cc7d353b2adc8fcc1712e1f7a965e70121ebcc..088f4b8eb31b2af26e66dcbaae062f40b3955059

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/516973003

Cr-Commit-Position: refs/heads/master@{#292526}

BUG=407994
TEST=as in bug

Review URL: https://codereview.chromium.org/518443003

Cr-Commit-Position: refs/heads/master@{#292525}

unittest produces a suite._ErrorHolder object in these cases. We can parse its description to figure out what class/module it is and what tests we have in that class/module.

BUG=405766
TEST=Make a TestCase fail setUpClass, run it with --retry-limit=3 and check for retries.
R=dpranke, tonyg

Review URL: https://codereview.chromium.org/515263003

Cr-Commit-Position: refs/heads/master@{#292524}

BUG=366603

Review URL: https://codereview.chromium.org/469523003

Cr-Commit-Position: refs/heads/master@{#292523}

Revert of Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update. (patchset #5 of https://codereview.chromium.org/471233003/)

Reason for revert:
Test is failing on a Blink bot on ChromeOS

Original issue's description:
> Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update.
>
> Add more checks to test to detect that the resource type of
> the URL request is indeed OBJECT.
> Would like to get this merged to the M38 branch.
>
> BUG=401755
>
> Committed: https://chromium.googlesource.com/chromium/src/+/bfc3e122d6721ccc93f0f8b19dac4a3c2a0c947d

TBR=teravest@chromium.org,ncbray@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=401755

Review URL: https://codereview.chromium.org/524483002

Cr-Commit-Position: refs/heads/master@{#292522}

Also switch harfbuzz to internal by default to minimize deps.

BUG=178543
TEST=run the tool
TBR=bashi1

Review URL: https://codereview.chromium.org/509323004

Cr-Commit-Position: refs/heads/master@{#292521}

The operations would get routed to the viewer process under the assumption that it was Windows 8
which would eventually crash while trying to open the metro dialogs which don't work on Windows 7.

Fix is to return false from the ShellDialogsDelegateWin::IsWindowInMetro function for anything below
Windows 8.

BUG=356475

Review URL: https://codereview.chromium.org/510223002

Cr-Commit-Position: refs/heads/master@{#292520}

NOTRY=true

Review URL: https://codereview.chromium.org/522483002

Cr-Commit-Position: refs/heads/master@{#292519}

This CL add a ChannelProxy equivalent of the Channel benchmark
to ipc_perftests.

To use it in the benchmark, TestIOThread is extracted from
mojo/system/ to base/test

TEST=IPChannelPerfTest.ChannelProxyPingPong
R=viettrungluu@chromium.org,brettw@chromium.org,darin@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/488003003

Cr-Commit-Position: refs/heads/master@{#292518}

BUG=308692

Review URL: https://codereview.chromium.org/513803005

Cr-Commit-Position: refs/heads/master@{#292517}

BUG=355227
TEST=visual

Review URL: https://codereview.chromium.org/515973003

Cr-Commit-Position: refs/heads/master@{#292516}

This initial version still returns ENOSYS.

Review URL: https://codereview.chromium.org/512603008

Cr-Commit-Position: refs/heads/master@{#292515}

BUG=110610

Review URL: https://codereview.chromium.org/511173002

Cr-Commit-Position: refs/heads/master@{#292514}

While debugging flaky browser_tests, it was revealed that a
WebContentsVideoCaptureMachine could actually outlive the tear-down of
the BrowserThreadImpl for the UI thread.  Not having been explicitly
stopped first, destructors in the object graph would execute clean up
code that would attempt operations that are invalid after the
BrowserThreadImpl for the UI thread has been torn down.

This change also includes a bunch of minor clean-ups.

BUG=396413

Review URL: https://codereview.chromium.org/514073002

Cr-Commit-Position: refs/heads/master@{#292513}

https://chromium.googlesource.com/chromium/blink/+log/5d3187faa8b0dc282ac6f16311c8ba96bfb91bd8..78d2b11092668ed42fc97d9a81290a3e226bed43
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/518573002

Cr-Commit-Position: refs/heads/master@{#292512}

Currently, if |compositor_needs_continuous_invalidate_| is unset before
PostFallbackTick or FallbackTickFired, then the fallback ticks are
cancelled, but we never unset |block_invalidates_|, which will block
invalidates indefinitely.

Fix is simply always unset |block_invalidates_| even if we skip
the fallback tick.

BUG=408779

Review URL: https://codereview.chromium.org/512403002

Cr-Commit-Position: refs/heads/master@{#292511}

BUG=None
TEST=athena_unittests run again

Review URL: https://codereview.chromium.org/517053002

Cr-Commit-Position: refs/heads/master@{#292510}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610

Review URL: https://codereview.chromium.org/506773002

Cr-Commit-Position: refs/heads/master@{#292509}

BUG=402934

Review URL: https://codereview.chromium.org/515803002

Cr-Commit-Position: refs/heads/master@{#292508}

Finding the root cause of display configuration bugs is harder without
knowing which displays were reported as connected.

BUG=none

Review URL: https://codereview.chromium.org/518553002

Cr-Commit-Position: refs/heads/master@{#292507}

In this case the code below will ack the frame immediately anyway.

TEST=BrowserTest.ShouldShowLocationBar

Review URL: https://codereview.chromium.org/515373003

Cr-Commit-Position: refs/heads/master@{#292506}

BUG=408688
Test=Launch chrome://extensions with --enable-embedded-extension-options, open SPDY options, navigate to www.google.com, the "Options: SPDY Proxy Extension Options" entry should disappear from the Task Manager.

Review URL: https://codereview.chromium.org/514653003

Cr-Commit-Position: refs/heads/master@{#292505}

BUG=377978

Review URL: https://codereview.chromium.org/493633003

Cr-Commit-Position: refs/heads/master@{#292504}

Moving the Preload out of the content namespace and into BufferedDataSource
since that class is the primary reason this enum exists.

BUG=408338

Review URL: https://codereview.chromium.org/512413002

Cr-Commit-Position: refs/heads/master@{#292503}

This brings in:
f105b19 No need to release resources in destructor of CPDF_ShadingObject
fdcc874 Restrict index not be greater than row_size in TIFF_PredictLine
405478d Use valid bpc value in LoadPalette() and ContinueToLoadMask()
a67da71 Fix a bug when looping through m_pCompData
96f8786 Bounds check before fixed-size memcmp() in CJPX_Decoder::Init().

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/515983005

Cr-Commit-Position: refs/heads/master@{#292502}

Removed win_pdf_metafile_for_printing gyp option.
Removed WIN_PDF_METAFILE_FOR_PRINTING define.

BUG=170859
TBR=yzshen

Review URL: https://codereview.chromium.org/516823002

Cr-Commit-Position: refs/heads/master@{#292501}

Previously "component" was a built-in function that forwarded to source_set, static_library, or shared_library depending on the value of component_mode. And test was a built-in function that forwarded to executable.

These can be expressed as templates instead. This patch removes the built-in versions and implements the templates in the master build config file.

Forwarding all of the variables for these is somewhat tedious, but I still prefer not to add a new concept for this, since it will be rarely used and less clear what is happening.

With the updated BUILDCONFIG.gn file, the build will work with both the old and new GN version (the built-in version of component and test take precedence). When the new GN binary is pushed, we can remove the references to component_mode.

BUG=
R=hclam@chromium.org

Review URL: https://codereview.chromium.org/516703005

Cr-Commit-Position: refs/heads/master@{#292500}

BUG=381007

Review URL: https://codereview.chromium.org/517023002

Cr-Commit-Position: refs/heads/master@{#292499}

Instead of requesting a layer, a copy of the entire surface is requested. Actually handling the request isn't implemented yet.

BUG=397730

Review URL: https://codereview.chromium.org/509193002

Cr-Commit-Position: refs/heads/master@{#292498}