GitLab

Having to manually set mac_sdk was a FAQ when Xcode 4 was released. Now
we're using the 10.6 SDK by default, but Xcode 4.4 ships only with the
10.7 and 10.8 SDKs, so it'll likely become a FAQ again. Automatically
set mac_sdk to something sensible.

(People who explicitly say "mac_sdk=10.6" will have to stop doing so
when they switch to Xcode 4.4.)

BUG=121162
TEST=Build without mac_sdk in GYP_DEFINES. Something useful happens
with Xcode 3.2.6, Xcode 4, Xcode 4.4.


Review URL: https://chromiumcodereview.appspot.com/10824055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148817 0039d316-1c4b-4281-b951-d872f2087c98

The main Windows core printer driver has several different guids associated with it.  Windows 8 removes all but 1 of these guids.
This CL switches to use the guid that is still supported.  AFAICT this should continue to work on all of the platforms we support.
My testing is blocked at the moment due to a problem with internal software.


BUG=139156
TEST=Try to install driver (all supported Windows versions)


Review URL: https://chromiumcodereview.appspot.com/10830037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148816 0039d316-1c4b-4281-b951-d872f2087c98

In unrelated work, I found that the group addition formula used in p224.cc
doesn't work when one of the arguments is the point at infinity. This change
catches that case and simplifies the ScalarMult loop as a consequence.

In the course of doing this, I found a couple of bugs in Contract that would
have produced the wrong answer is very rare cases.

I also added a catch for a+a. This can't happen in the ScalarMult loop, but it
could happen from SPAKE2 at a rate of 1 in ~2**220 evaluations.

BUG=none
TEST=crypto_unittests


Review URL: https://chromiumcodereview.appspot.com/10822019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148815 0039d316-1c4b-4281-b951-d872f2087c98

A follow-up to https://chromiumcodereview.appspot.com/10808078

This way, cleaning up existing style issues in inner classes doesn't
have to block a clang roll.

BUG=139346

Review URL: https://chromiumcodereview.appspot.com/10828057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148814 0039d316-1c4b-4281-b951-d872f2087c98

They payoff for the last month of refactoring: We now use the LinuxUI interface
to generate gtk file selection dialogs from the shim library. We could
theoretically make a Qt or EFL shim and get those desktops' native open
dialogs.

BUG=136909, 134167
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10829021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148813 0039d316-1c4b-4281-b951-d872f2087c98

We were only ever performing a meaningful cleanup on reconfigurations
or restart, so we make that explicit by purging from within the SyncManager's
loading and configuration methods.

BUG=131433, 90868
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10541079

TBR=zea@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10823061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148812 0039d316-1c4b-4281-b951-d872f2087c98

MessageLoopProxy::current() may not work properly on plugin
threads unless the plugin is compiled into the browser.

BUG=134216

Review URL: https://chromiumcodereview.appspot.com/10830017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148811 0039d316-1c4b-4281-b951-d872f2087c98

Adds functionality to signal an offset to be applied to the
buffers in ChunkDemuxer. Is not triggerable from Chrome yet.

BUG=139044
TEST=media_unittests

Review URL: https://chromiumcodereview.appspot.com/10803019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148810 0039d316-1c4b-4281-b951-d872f2087c98

GetCookie, SetCookie, DeleteCookie, SetDownloadShelfVisible,
IsDownloadShelfVisible, GetDownloadDirectory

BUG=132794
TEST=PyAuto CONTINUOUS suite


Review URL: https://chromiumcodereview.appspot.com/10804038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148809 0039d316-1c4b-4281-b951-d872f2087c98

Also rename registry to preferences.


BUG=NONE


Review URL: https://chromiumcodereview.appspot.com/10835016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148808 0039d316-1c4b-4281-b951-d872f2087c98

BUG=Debug browser_tests occasionally crash with failed DCHECK in ExtensionDownloadsEventRouter.


Review URL: https://chromiumcodereview.appspot.com/10829058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148807 0039d316-1c4b-4281-b951-d872f2087c98

Reasons to deprecate:
1) This function is unused in production.
2) The directionality code was wrong:
2a: Used Unicode control character wrapping.
2b: DCHECKing URL validity precludes invalid schemes with RTL leading substrings anyway.
3) The only tangible benefit (calling ui::ElideURL) is minimal.
4) It's easy to restore (or re-impl better) if needed.

BUG=NONE
TEST=NONE

Review URL: https://chromiumcodereview.appspot.com/10829047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148806 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:32702


Review URL: https://chromiumcodereview.appspot.com/10825040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148805 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135179
TEST=Run chrome with --force-device-scale-factor=2 and ensure that high DPI images are used on these pages (i.e. the logo on chrome://chrome/help/)


Review URL: https://chromiumcodereview.appspot.com/10830051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148804 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137140

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148418

Review URL: https://chromiumcodereview.appspot.com/10808094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148803 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/10821072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148802 0039d316-1c4b-4281-b951-d872f2087c98

Previosly plugin code was using PluginMessageLoopProxy that implements
MessageLoopProxy interface. We no longer need MessageLoopProxy.
Replacing PluginMessageLoopProxy with PluginThreadTaskRunner that
implements SingleThreadTaskRunner interface


Review URL: https://chromiumcodereview.appspot.com/10830016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148801 0039d316-1c4b-4281-b951-d872f2087c98

We get sub-DIP damage from the renderer with --ui-enable-partial-swap. When we convert to DIP in RWHVA::AccelerateSurfacePostSubBuffers, we trancate that damage (an shrink the rect). The straightforward solution is to assume that the damage was truncated and dilate the DIP damage rect.

BUG=139208
TEST=by hand on device that supports --ui-enable-partial-swap


Review URL: https://chromiumcodereview.appspot.com/10821054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148800 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10833038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148799 0039d316-1c4b-4281-b951-d872f2087c98

Pull out a generic TabModel class for Android.  It owns SyncedWindowDelegate
like Browser owns a corresponding instance.  This will allow us to eventually
implement TabModelAndroid.

We no longer need to keep SyncedWindowDelegateRegistry, as we were using that
in non-sync related places to reach the TabModel methods.

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10701030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148798 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124087
TBR=sky
TEST=NONE

Review URL: https://chromiumcodereview.appspot.com/10820060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148797 0039d316-1c4b-4281-b951-d872f2087c98

WebKit change: https://bugs.webkit.org/show_bug.cgi?id=92132

BUG=

Review URL: https://chromiumcodereview.appspot.com/10830055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148796 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the find elements command when used on pages with prototype JS lib.
BUG=chromedriver:102
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10829048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148795 0039d316-1c4b-4281-b951-d872f2087c98

Removing create/manage dialog shortcuts checkbox for M22. Checkbox will be added back in during M23 when support for windows desktop shortcuts is finished.

Review URL: https://chromiumcodereview.appspot.com/10832038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148794 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139311


Review URL: https://chromiumcodereview.appspot.com/10831048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148793 0039d316-1c4b-4281-b951-d872f2087c98

We were only ever performing a meaningful cleanup on reconfigurations
or restart, so we make that explicit by purging from within the SyncManager's
loading and configuration methods.

BUG=131433, 90868
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10541079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148792 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112525
TEST=unittests, manual 

Review URL: https://chromiumcodereview.appspot.com/10827060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148791 0039d316-1c4b-4281-b951-d872f2087c98

Now requires you to specifically change the GYP_GENERATORS to specify Ninja. The original change broke because gyp ran for both make and ninja and the webkit bot determines whether to use ninja by the presence of build.ninja (thanks to Peter for figuring this out)

BUG=137569,136693


Review URL: https://chromiumcodereview.appspot.com/10827073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148790 0039d316-1c4b-4281-b951-d872f2087c98

Also expanded scope of ScopedAllowIO in
SQLiteServerBoundCertStore::Backend::Load() to cover SQLite functions.
And added ScopedAllowIO to PasswordStoreFactory::BuildServiceInstanceFor() --
it calls LoginDatabase::Init() which should be executed on DB thread.

This is a reland of
https://src.chromium.org/viewvc/chrome?view=rev&revision=147309
which was reverted because of missing ScopedAllowIO in PasswordStoreFactory.

Patch from Pavel Ivanov <paivanof@gmail.com>

BUG=75232, 52909, 137961, 138903
TEST=no test fails with message "Function marked as IO-only was called from a thread that disallows IO!"

Review URL: https://chromiumcodereview.appspot.com/10824008
Patch from Pavel Ivanov <paivanof@gmail.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148788 0039d316-1c4b-4281-b951-d872f2087c98

xp-release-dual-core/moz/total_byte_r/IO_r:
xp-release-dual-core/moz/total_op_r/IO_op_r:

TBR=cmp
BUG=139382

Review URL: https://chromiumcodereview.appspot.com/10825061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148787 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rtenneti
BUG=138877

Review URL: https://chromiumcodereview.appspot.com/10826051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148786 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148785 0039d316-1c4b-4281-b951-d872f2087c98

This is a speculative fix for the failure in crbug.com/139136.
It's not clear why we get WSAEADDRNOTAVAIL from sendto(), but it should
be safe to ignore that error.

BUG=137140

Review URL: https://chromiumcodereview.appspot.com/10827064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148784 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10829059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148783 0039d316-1c4b-4281-b951-d872f2087c98

Currently, MockRead and MockWrite are defined as the same type by using
typedef. However, these types are different types and should not be used
interchangably.

This change gives MockRead and MockWrite distinct types by using templates
so the compiler can cause an error when these types are used interchangably.
Some misuses of MockRead and MockWrite were found, so these are fixed in this
change, too.

BUG=none
R=mmenke@chromium.org,akalin@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10796085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148782 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10833022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148779 0039d316-1c4b-4281-b951-d872f2087c98

Horizontal slider is implemented with image resources, and it changes UI based the on/off state.

Vertical slider is kept in the old way, since I don't have the UI resources for drawing the vertical slider. I wonder if I should remove the vertical slider bar supporting code, or leave it as it which is what I choose to do currently.

BUG=124097
TEST=Audio and brightness slider control should be in new UI, and audio slider bar should dim when muted.
TBR=oshima@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10830027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148778 0039d316-1c4b-4281-b951-d872f2087c98

This CL does the following:
* Move AudioDevice, AudioInputDevice out of content, into media/audio.
* ...and a couple of dependent classes: AudioDeviceThread and ScopedLoopObserver.
* ...and the unit test.
* Renamed AudioDevice -> AudioOutputDevice
* Moved the classes into the media namespace.
* Updated the unit test code as necessary.

Aside from the unit test*, there are minimal code changes.  Only what was required to make things build and work as before - mostly just adding or removing "media::".

* The unit test changes were to add expectations for AddDelegate/RemoveDelegate since previously a mock class was inheriting from AudioMessageFilter and not the IPC interface.
Review URL: https://chromiumcodereview.appspot.com/10834033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148777 0039d316-1c4b-4281-b951-d872f2087c98

deferred canvas rendering

BUG=139174
TEST=none.
Review URL: https://chromiumcodereview.appspot.com/10826034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148776 0039d316-1c4b-4281-b951-d872f2087c98

The pattern may seem overly broad, but actually, it covers exactly the set of
files that affect Chrome Instant.

R=nirnimesh@chromium.org
BUG=none
TEST='depot_tools/watchlists.py chrome/common/instant_types.h' lists sreeram@chromium.org.

Review URL: https://chromiumcodereview.appspot.com/10833054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148775 0039d316-1c4b-4281-b951-d872f2087c98