- 11 Dec, 2019 40 commits
-
-
Dana Fried authored
Adds better output for EXPECT/DCHECK/ASSERT around common layout types including SizeBounds, as well as providing ToString() methods for ProposedLayout and ChildLayout used by all LayoutManagerBase-derived layout managers. Change-Id: If9c5c99ac3aec2db4969038739fea6118e893191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958695 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#723657}
-
Chih-Yu Huang authored
This CL adds tests for duplicateFD() function. BUG=b:136716638 TEST=components_unittests --gtest_filter=ArcVideoAcceleratorUtil.* Change-Id: Iae61b51fe7f5af5ca021ac11ff5e0764dff37044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828675Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#723656}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/be497359b6c9..aecaa6fb3c8f git log be497359b6c9..aecaa6fb3c8f --date=short --first-parent --format='%ad %ae %s' 2019-12-10 primiano@google.com build(deps): bump lodash in /infra/perfetto-site.appspot.com Created with: gclient setdep -r src/third_party/perfetto@aecaa6fb3c8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I450e0610005a9dd92f16b6226493af873c0f2b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961000Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723655}
-
Zhenyao Mo authored
This CL import/export RenderPass data from/to DictionaryValue. Most fields are iterated through, so they are readable/modifiable in the JSON file. However, filters are saved as a encoded string. It will be implemented in the future if needs arise. The issue not to iterate through filters data is that whenever we update the data structure, it invalidates previously recorded data. A followup CL will add recorded render pass list JSON files from top sites, and use them for renderer_perftests. R=sunnyps@chromium.org Change-Id: Ieff731ca5558bc5647ff1d8d1f0e06d103dbaab0 Bug: 1026447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889114 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#723654}
-
Esmael El-Moslimany authored
Change-Id: I33d929e5f8292c97961d5c524d58be57c703d004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960780 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#723653}
-
Sadrul Habib Chowdhury authored
Explicitly notify the FrameSequenceTracker instances when handling a frame terminates. This is used to validate that the expected sequence of calls happen correctly, e.g. a new frame does not start before the earlier frame has completely been processed. BUG=1021963 Change-Id: I9465148c7478545723e2b3657fdd9b49cdc79d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902069 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#723652}
-
Jiajun Ou authored
Details: - Implement CWVBackForwardList: a equivalent of https://developer.apple.com/documentation/webkit/wkbackforwardlist - Implement CWVBackForwardListItem: a equivalent of https://developer.apple.com/documentation/webkit/wkbackforwardlistitem - Implement |backForwardList| property in CWVWebView and -[CWVWebView goToBackForwardListItem:] Bug: 1021830 Change-Id: Ia04f5197fb1eb03b1f59955068f00af1022fc2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928460 Commit-Queue: Jiajun Ou <garzonou@google.com> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#723651}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2e1437ca. With Chromium commits locally applied on WPT: a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." eb00b4d6 "LazyLoad: move invisible-image.html test to WPT" d1886d3c "[PW] Implement setTransform with DOMMatrix" 4b1bc203 "Remove totalFrameDelay test for getVideoPlaybackQuality()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ibeb8a805f5bb325541f3a7a851d25db2b5fc238d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960531Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723650}
-
Sergey Ulanov authored
1. ConnectContextProvider() was returning InterfaceHandle<ContextProvider> and also taking InterfaceRequest<ContextProvider> argument. The result wasn't actually used. Removed the request argument. 2. Renamed the function to StartWebEngineForTests() - this name reflects what this function does. Change-Id: Iede1b040a13a96860a2946e8addcf15b8dbba35c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960668Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#723649}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/351307eba332..caa6eccde3ee git log 351307eba332..caa6eccde3ee --date=short --first-parent --format='%ad %ae %s' 2019-12-10 hckim.kim@samsung.com Vulkan: Implement Transform Feedback support via extension 2019-12-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src d519167d2ecb..6c479796f6e4 (3 commits) 2019-12-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src f34b9fb086b3..a749c31b749b (3 commits) 2019-12-10 ianelliott@google.com Vulkan: Update bugs for multisample texture failures 2019-12-10 syoussefi@chromium.org Vulkan: EXT_gpu_shader5 support: fma Created with: gclient setdep -r src/third_party/angle@caa6eccde3ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliot@google.com Change-Id: Iddacd11a6c1573aac3b2fb8c40ee2d0b517465fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960993Reviewed-by:
-
Sunny Sachanandani authored
crrev.com/c/1939845 accidentally removed ANGLE D3D11 backend coverage for webgl conformance tests because of a naming confusion. This CL restores that coverage by undoing the removal of the default variant (D3D11 on Windows) of webgl_conformance_telemetry_tests and webgl2_conformance_telemetry_tests. Bug: 1028850, 1032768 Change-Id: I04f8542fcb124c0082af97cca6d0487af7803e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961129Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#723647}
-
Bruce Dawson authored
This reverts commit 85f2f960. Reason for revert: The compiler bug which necessitated this is believed to be fixed now. Original change's description: > Turn off CFG when not needed > > Control Flow Guard is a security feature that can help stop exploits. It > is primarily need on our official builds. On the debug and component > builds where Chromium is primarily developed it just adds a bit of > extra size to the object files. > > This was fine until it triggered a spurious link error in component > builds when symbol_level=2 was selected. This wasn't caught by the bots > because most (all?) of them build with symbol_level=1, or non-component. > > This turns off CFG for debug and component builds, thus getting those > builds working again for developers. > > Bug: 1019970 > Change-Id: I7a56af177452e62a5f3ad1daa608970cb9518d4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891991 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Auto-Submit: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711083} TBR=thakis@chromium.org,rnk@chromium.org,brucedawson@chromium.org,tikuta@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1019970 Change-Id: I3e1d605d4532286f4ccfb0b6b4797a5d30e614a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961207Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#723646}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0582c36727b..71bfaa4d93ba Created with: gclient setdep -r src-internal@71bfaa4d93ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I3f023880b6b2db0fbbf8838520b1fbf6864c739e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960994Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723645}
-
gogerald authored
Screenshot: https://drive.google.com/a/google.com/file/d/1OATymD07R7hE_8RDMACLCzlUHRSZjW1o/view?usp=sharing Bug: 1032780 Change-Id: I7c3e859d6b49074e0d2998ae8d2565342d6e411c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960968Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#723644}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f15fc26d5bf5..d1db0e94b0df git log f15fc26d5bf5..d1db0e94b0df --date=short --first-parent --format='%ad %ae %s' 2019-12-10 enga@chromium.org docs: Add section about dawn_perf_tests 2019-12-10 rharrison@chromium.org Use correct Initialize call to spvc for Metal backend Created with: gclient setdep -r src/third_party/dawn@d1db0e94b0df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ic2149df74ca3b8dbe5738fcae8d28a02d8c640f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960999Reviewed-by:
-
Xida Chen authored
We have identified that the reason of not getting throughput UKM is due to the sampling logic, via this debug CL: https://chromium-review.googlesource.com/c/chromium/src/+/1946872 This CL changes the sampling logic. Bug: 1029964 Change-Id: Icf5fc750102d0e3631047913d77adb4e37589721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958195Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#723642}
-
Bo Liu authored
Some new implementations missed calling the workaround. Change-Id: Ice6d8a1b662ae1ed113f4c68bb1b37c7b15ea1ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959940 Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#723641}
-
tby authored
Change-Id: I88779743e8ac04ea0883a91fc9b61297c758e67f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950375Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#723640}
-
Matt Menke authored
This reverts commit f8389da6. Reason for revert: Findit is borked TBR=davidben@chromium.org Bug: 469957, 821811 Change-Id: Ie59ada373cb9690901ebbc19b373f9b467fe9cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960720Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#723639}
-
nancy authored
When the browser is closed/removed, update the related Chrome window in AppService InstanceRegistry as destroyed to delete the Chrome window instance. BUG=1011235 Change-Id: I67327279423ae0b9ade0e089f1a615e91bb87ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959919 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#723638}
-
Varun Khaneja authored
This would reduce the time a user has to wait for the initial few page loads to proceed if they can't reach the Safe Browsing backend. Bug: 963165 Change-Id: Ie90f41b129208b04fd19614192ee79030b9a9f83 Fixed: 1032317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961083 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#723637}
-
Jack Lynch authored
This CL disables a test that will be broken by [1] and reenabled by [2]. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1889352 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1644461 Bug: 963183 Change-Id: I0eb88ae2c5a5aa49ba0886fc9077320f77057ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893960 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#723636}
-
Jeffrey Cohen authored
Bug: 1024586 Change-Id: I7b4331bdfd8d81d0a8b422894297d7e7d0f9a4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959663 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#723635}
-
Brian Sheedy authored
Improves WebGL conformance test sharding by applying the --read-abbreviated-json-results-from argument everywhere instead of only on Android on some test definitions. This should improve shard runtime by using a different algorithm using historical runtime results. Additionally, increases the number of shards used for WebGL conformance tests on chromeos-amd64-generic-rel since some of the shards can take a long time and hold the entire build up. Bug: 1028298 Change-Id: I71225845abd798cfd7655583b2a5269be5e247e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960829Reviewed-by:
-
Mike Wasserman authored
Update the "File editing" svg, used in Site Settings Web UI. eg: chrome://settings/content/siteDetails?site=https%3A%2F%2Fwww.google.com Update the vector icon for the page action icon and site info bubble. Use https://www.gstatic.com/images/icons/material/system/svg/file_save_24px.svg Sanitize with jakearchibald.github.io/svgomg and evanstade.github.io/skiafy See the bug for before/after pictures. Bug: 995901 Test: Native File System icons appear as expected Change-Id: I3d60c704af962307dd4e32098b2d79fc7735386c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884584 Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#723633}
-
Gyuyoung Kim authored
There is no use of mojo::Binding in Blink. So, we don't need to keep unnecessary binding.h includes. Bug: 955171 Change-Id: I1262eb5052f8f5ed468c137cc2c13162b269a463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958266Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#723632}
-
Demetrios Papadopoulos authored
Also adding a test to cover this case. Fixed: 1031551 Change-Id: If4ea5b40e33fe9b21dbed78c665fcb60a43aadd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959467Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#723631}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c1c5bec5ed00..04a5a7689362 git log c1c5bec5ed00..04a5a7689362 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 brgoddar@microsoft.com Console: Add Expand/Collapse aria label for stack trace messages Created with: gclient setdep -r src/third_party/devtools-frontend/src@04a5a7689362 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7750e131c3ddfd5aed578189de859d7a1478f102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960997Reviewed-by:
-
Donn Denman authored
We've recently had all of our tests in this file fail on P+, so disabling them until we can figure out what's going wrong. BUG=1032760 Change-Id: Ibe6a3be3dcdfde61696f53513bfe2b98e42aba83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961077 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#723629}
-
Gyuyoung Kim authored
This CL cleans up unnecessary binding.h includes in //content. Bug: 955171 Change-Id: I20968eecb210e0f60d0ac0d89db28d6cbbbf92c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959194Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#723628}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/modules/picture_in_picture only when it meets the policy of removing Create(). Then, this CL makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below factory functions, - PictureInPictureControllerImpl::Create Bug: 939691 Change-Id: I9b0fb7af883c19bccb5fe5466186b5e560a02285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958267Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#723627}
-
Caroline Rising authored
This change increases the delay before a hover card will appear. Bug: 910739 Change-Id: I1bfc24b6ab56316fd3d05147e1c46fd6add5169d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961078Reviewed-by:
-
Shakti Sahu authored
We should show NTP entry point only when 1 - There are prefetch or content indexed articles available 2 - Show only once per session. If user dismissed in one tab, don't show it on another new tab when opened Bug: 1031796 Change-Id: I229fa4ecfa1b58ffcfe281af5c732f168268ed36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956162 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#723625}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ad994cd8941d..9d1cb79e7718 git log ad994cd8941d..9d1cb79e7718 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-10 mtklein@google.com test for c++17 w/ c++14 stdlib 2019-12-10 scroggo@google.com SkWebpCodec: enable a loop count of 1 2019-12-10 herb@google.com Move luminance calculation to GrTextBlob::Make() 2019-12-10 egdaniel@google.com Add GrSurfaceProxyView to the various draw atlas ops. Created with: gclient setdep -r src/third_party/skia@9d1cb79e7718 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I604c656482a3d05775a674d4fd2da2d94890c8a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961001Reviewed-by:
-
Ben Pastene authored
This reverts commit 008b7265. Reason for revert: causing ARC-related tast tests to fail eg https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome/2 Original change's description: > Move Ash off Service Manager > > This removes all dependences on the Service Manager from within Ash and > clients of Ash. The "Ash Service" is deleted, and the few interfaces > which the browser bound through it are now bound through a handful of > public helper functions that route through Shell. > > The only service interfaces used from within Ash are from the > Device Service, and those are now acquired through ShellDelegate. > > Bug: 977637 > Change-Id: Ia117241f4adddd14303176af78075d0df6c5b563 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956160 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#723475} TBR=sky@chromium.org,rockot@google.com,tsepez@chromium.org Change-Id: I60bd3b9803f7017e44f2adc41b3304beee5fddd2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977637, 1032816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961271Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#723623}
-
Simon Que authored
CI: -GPU FYI Win Builder -GPU FYI Win Builder (dbg) -GPU FYI Win dEQP Builder -Win Builder -Win Builder (dbg) -Dawn Win10 x86 DEPS Builder -Dawn Win10 x86 Builder Try: -win-angle-rel-32 -gpu-fyi-try-win7-amd-rel-32 -gpu-fyi-try-win7-nvidia-rel-32 -gpu-fyi-try-win10-nvidia-rel-32 -gpu-fyi-try-win7-amd-dbg-32 -gpu-fyi-try-win7-amd-dqp-32 -win-angle-deqp-rel-32 -win_chromium_compile_rel_ng -win7-rel -win_chromium_compile_dbg_ng -win_chromium_dbg_ng -dawn-win10-x86-deps-rel Migration schedule: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: Ib0356f986b1c09d5a2692b443c3aca2f06443be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924183Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#723622}
-
Chris Blume authored
Previously, we were creating temporary ColorSpaces just to see if the transfer ID would require color correction. This was rather roundabout. Now that a .GetTransferId() function is available in ColorSpace, use that to avoid the unnecessary temporaries. Change-Id: Ia1680b25da8d9ae83dd5555cb84a84b1692f90b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924703 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#723621}
-
Ben Pastene authored
And update references to them in public consoles. Bug: 1032272 Change-Id: Ie40e34dd6d9cc9d0025a5361bb62a3ae0b93b96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960578Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Kurt Horimoto authored
This is a minimum InfoBarDelegate subclass to use for tests. Bug: none Change-Id: Iee4ea0d819ac436ea64b471a166c6399df3cebbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959664 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#723619}
-
Fergus Dall authored
BUG=none TEST=none Change-Id: If7961a42629d2217b6ae2581247dce577eb0299f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957944Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#723618}
-
