- 17 Jul, 2020 40 commits
-
-
Vladimir Levin authored
This patch adds AggregatedFrame as a return value of SurfaceAggregator::Aggregate. The reason for this is twofold: 1. It type checks the usage and ensures that we only forward the minimum set of things that we populate (one field for example was used although never initialized by anything except the ctor). 2. It allows us to separate CompositorFrame::render_pass_list from AggregatedFrame::render_pass_list with hopes of (in the future) type checking that RenderPassId post aggregation is remapped into a global space, whereas RenderPassId in CompositorFrame is local to the associated SurfaceId. R=kylechar@chromium.org, weiliangc@chromium.org Bug: 1106418 Change-Id: Ie6728d010c2f15171fc74616f064446df752f16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302710Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#789479}
-
Maria Kazinova authored
Bug: 918846 Change-Id: Ida4d623da78879d9f739243131ceffbc7f7c60c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302994 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#789478}
-
Gayane Petrosyan authored
Rename and add user action to xml. Initially introduced by https://chromium-review.googlesource.com/c/chromium/src/+/2295779 Bug: 1102382 Change-Id: I4b45358e4dd89bf12a73260afa474ea956a68a55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303549Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#789477}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f50a0fb8a663..c0f23a129f67 2020-07-17 lalitm@google.com docs: add clarification on how to choose where to add diff tests 2020-07-17 lalitm@google.com Merge "Revert "tp: move completition of dangling sched events from C++ to SQL"" 2020-07-17 rsavitski@google.com Merge "profilers: stop parsing extraneous libs for managed processes" 2020-07-17 lalitm@google.com Merge "shell: fix hiding real cause of failure with dcheck" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia4981989dcd637dcdb897966b24562d83fb234a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304670Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789476}
-
Chris Sharp authored
This text was incorrectly removed in https://chromium-review.googlesource.com/c/chromium/src/+/2217873 Bug: 1018157 Change-Id: Id78aa3cf5012076780bc678c5106aa2a112284e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302830Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#789475}
-
Antonio Gomes authored
... into MediaStreamRendererFactory. The implementation will now reside in media_stream_renderer_factory.cc|h. BUG=704136, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I6d254aaca5b42ed170ca84218770f80843ef7e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302918 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#789474}
-
Olivier Robin authored
New windows are created with an NSUserActivity to load a URL (that can be chrome://newtabpage) in a new tab. 1. Use openOrReuseTab function to open such activities to reuse the current tab if it is an NTP 2. avoid opening the default NTP if such an activity exists as the NTP would flash before the target URL is loaded. Bug: 1106738 Change-Id: Ib034d54dc596b9ca5a69046fd71234831f35bd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302616 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#789473}
-
WangHui authored
Move the logic of frame token check into RWHVA since the RWHVA maybe reused with create a new compositor. Bug:1103530 Change-Id: I69c5bbb7713e6054309d8d9a50188f48c6cbd74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288714 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789472}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e810d53b527e..45fb1f2ebb99 2020-07-17 tvanderlippe@chromium.org Stop building formatter_worker-entrypoint with build_release_applications 2020-07-17 janscheffler@chromium.org [WebAuthn] Add owners file for webauthn 2020-07-17 tvanderlippe@chromium.org Move acorn entrypoint to front_end/third_party/acorn 2020-07-17 szuend@chromium.org Don't add sourceURL comments to HTML and Markdown files 2020-07-17 szuend@chromium.org Build 'marked' module with TypeScript infrastructure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099162 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia8535a7c13d0979068461199dd64951ef5778884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304672Reviewed-by:
-
Jose Dapena Paz authored
This breaks GCC (but it should break any platform, a destructor specification should never have a return value. Bug: 819294 Change-Id: I2741ce5c10526a8e11914882449d0b207e755201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304573Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#789470}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1769f267f216..086c75fa39cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mkwst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106715 Tbr: mkwst@google.com Change-Id: I865b6e4efc68b6d04a8e1b08860df97ea6634b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304405Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789469}
-
Robert Sesek authored
Bug: 1097376, 949535 Change-Id: I50caa1db4ff41bb8de5ebc98eb137ec80d410faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302811 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#789468}
-
Steven Bingler authored
Determine which cookie context, schemeless vs schemeful, to use based on the LegacySameSiteCookieBehaviorEnabled and LegacySameSiteCookieBehaviorEnabledForDomainList enterprise policies. This functionality may also be triggered if SameSiteByDefaultCookies is disabled. This seems acceptable because it's odd to decrease SameSite protections by disabling SameSiteByDefaultCookies but also want to increase those protections by having Schemeful Same-Site. Also update the documentation for the policies. Bug: 1101037 Change-Id: I6f74f6448147b451bbf8ae5aa0157277dd00639c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283505Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#789467}
-
Nicholas Verne authored
UX review always required a preliminary, low impact prompt for upgrade rather than going straight to the large format Upgrade Dialog. This CL implements the prompt as a notification. It also removes logic for prompting on the first Crostini app launch attempt per session. Instead, the notification is shown at session start if appropriate. Because of this a large amount of complexity for the continuation of the app launch action can be removed (in a subsequent CL). Bug: 1103505 Change-Id: Icbfe744ef9c5264e2d2e022e91a90a2600339962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297072Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789466}
-
Nodir Turakulov authored
The correct OS is "LINUX" not "OS_LINUX" Proto: https://source.chromium.org/chromium/infra/infra/+/master:go/src/infra/tools/dirmd/proto/dir_metadata.proto;l=49?q=dir_metadata.proto Bug: 1106176 Change-Id: If66b4e4c0f12315c428ebb2c73268b6e92e1955a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303467 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#789465}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1a09faed62a4..d74c0e600a7f 2020-07-17 mbonadei@webrtc.org Add presubmit test to use RTC_OBJC_TYPE on RTC_OBJC_EXPORT types. 2020-07-17 handellm@webrtc.org Rename CriticalSection to RecursiveCriticalSection. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I33e28e647a7ac5510be945e47118d7cec438bdf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304408Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id2b7cbade3a4c0a95eb035bf55ad52567555e05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304406Reviewed-by:
-
Kevin Ellis authored
Adds documentation for the Animation interface. Change-Id: I64934a9adc4d2f63fac65bbb3977e7f5f10b8375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300259Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#789462}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594963977-810cedbe35bd1c6db444ce1374d5ffa7453d77c9.profdata to chrome-mac-master-1594987060-434c51fdab164717c1b94e12633f94a30a81dd52.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia0cc306928fe4fe50822a58d2121bf81d6a0e7f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304669Reviewed-by:
-
Dominic Mazzoni authored
Bug: 1102937 Change-Id: Ib4ac8700bf147ec6aeff696c47f39592503f0447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303455 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789460}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibe846a5c7b0c857e7373036be0a207c30797bd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304650Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I91dcbe3eef687d3138f322f589b35498d3937221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304649Reviewed-by:
-
stkhapugin authored
Disables testDeleteCustomSearchEngineSwipe[AndTap] tests. Bug: 1106735 Change-Id: Ib89ae2e11d8ce68f44eeee7352ad107c19fe2b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303395 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789457}
-
Michael van Ouwerkerk authored
Screenshot: https://screenshot.googleplex.com/QRFx2waLZvJ.png Bug: 1103190 Change-Id: I0f8eb5e3135db9e1ebd762ede8ce80765b2d69ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302615Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#789456}
-
Himanshu Jaju authored
- Connects signaling messenger from utility process to browser process - Connects ice config fetcher from utility to browser. - Implements webrtc medium on top of chrome's network stack. Change-Id: I741cc83a1863745fe381c9a653658fde1da945bd Bug: 1082375, 1082376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260779 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#789455}
-
Ewann authored
This Cl makes the bottom toolbar visible when initiating a drag down to close a modal setting view. Bug: 1106665 Change-Id: I519fac84a18c36c6838384241af01f1c57a824b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302633Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a74cd08cb159..e810d53b527e 2020-07-17 tvanderlippe@chromium.org Move lit-html entrypoint to front_end/third_party 2020-07-17 tvanderlippe@chromium.org Remove empty script arrays from module.json files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1105476 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5331f571a59d4d15daf58ffd1efb101508f112f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304404Reviewed-by:
-
Maria Kazinova authored
One of the obstacles for recording the FillingAssistance metric on iOS is that it's not always possible to recoved autofilled values. Now they are stored in FieldDataManager as well. Bug: 918846 Change-Id: Ic2bbbd5b5bc5ea61230ab8844a2278d8adc64168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302112 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
-
Matthias Körber authored
Currently, the utils only contain functions to parse/match regular expressions and a cache for compiled regular expressions. I kept the RE2 engine since the support for named capture groups is very limited in ICU: You can have named capture groups but there seems to be no method to acquire the the group names. Change-Id: I664c4ce548d35971e43881c70a3849a5b09bbf33 Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279980 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#789451}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d9b254b474d3..f50a0fb8a663 2020-07-17 lalitm@google.com Merge "tp: organize all tp tests and remove legacy folder" 2020-07-17 lalitm@google.com Merge "tp: merge test/metrics into test/trace_processor" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I936cfc2b8cc8da8dcf6545dc160be935bfdbda58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304403Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594878809-f70bebc20790ac0846ac45f570a81eb656b74862.profdata to chrome-win64-master-1594943787-7f5d9753ae33a53104b9969d76a646b53f10ccce.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I08f4f2ff4e22ff5e2198bcd9f48c94907d948e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304140Reviewed-by:
-
Ioana Pandele authored
Bug: 1100694 Change-Id: I25bc5e12cdc5d956b759f99fa2813d564a5c02cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302695Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#789448}
-
sandromaggi authored
Before this change, when the Autofill Assistant was dismissed with the cancel button showing the Snackbar, and changing from CCT to Browser during the time the Snackbar was open, Autofill Assistant would revive in the browser. This happens, because the UI gets destroyed and recreated, losing all knowledge about the Snackbar. Now, if a Snackbar is showing when the switch happens, we execute the callback immediately, which might shut down Autofill Assistant. Bug: b/159784978 Change-Id: I600bc0de4796c9f65533d1627030963a83b02865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302196Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#789447}
-
Maksim Ivanov authored
Refactor the CertificateProviderService to return an error when the supplied sign request ID is unknown. This will be used in a follow-up CL to implement returning an error to the extension when the new reportSignature() function is called with a bad ID. Bug: 1078761 Change-Id: I51dd4cee5237ea240d504be67079ebc2a4b15e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250200 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#789446}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/13fbc08b938e..1a09faed62a4 2020-07-17 nisse@webrtc.org Delete SignalDataChannelTransportNegotiated 2020-07-17 nisse@webrtc.org Delete unused enum values for DataChannelType If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie6c911562c98e26543c716fc72eb10248cda4c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304402Reviewed-by:
-
Side Yilmaz authored
This CL replaces deprecated |createImageFecther| function by passing profile to the function. Since assistant is only available in regular mode, |AutofillAssistantUiController#getProfile| returns |Profile#getLastUsedRegularProfile|. Then, the caller classes creates image fecther using |AutofillAssistantUiController#getProfile|. Previous discussions are in crrev.com/c/2276422. Bug: 1041781, 1083923, 1075562 Change-Id: I339c4e69f01de8a855a6353614adc26c1cac6439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301769 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#789444}
-
Luke Seunghoe Gu authored
In order to prevent crashes due to unchecked uses of GetWindowAndroid(), this CL creates dialog instance only if window is successfully retrieved. Plus, null-checks for dialog instance are needed before using it. Bug: 1051035, 1049090 Change-Id: Icae3747474398b09c73372a0879f3df7a2afa978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294761 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#789443}
-
Mike West authored
TBR: nifong@google.com Bug: 1106590 Change-Id: I669d42c97d98de839c62140df4b3ca90829211cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302635Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#789442}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c648f63ca9e2..1769f267f216 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mkwst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mkwst@google.com Change-Id: I4b215086b752c074e5861ee60e36b45c4d7370c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304398Reviewed-by:
-
Aya ElAttar authored
Change-Id: I9fe9f01c3550a329c8eae2ecec574cfa98965016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302611 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#789440}
-
