GitLab

The in-process DeltaUpdateOps don't require content/ and can be eventually used on iOS, whereas the out-of-process version needs to stay in chrome/.

Part 1d in design doc here: https://docs.google.com/document/d/1F76yNZCnPnGzgNXhI-sCFKlXulwx_s_OKTGbJS5NhbA/edit?usp=sharing

BUG=371463

Review URL: https://codereview.chromium.org/420503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287484 0039d316-1c4b-4281-b951-d872f2087c98

We want to be able to ask for the current benchmark's name when generating results. This threads the benchmark through so that it will be available to results objects.

Review URL: https://codereview.chromium.org/386943007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287483 0039d316-1c4b-4281-b951-d872f2087c98

BUG=306341
NOTRY=True

Review URL: https://codereview.chromium.org/417163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287482 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/442493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287481 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes three arguments from the RequireAdditionalModules method
since only the ScriptContext is needed to get those values.

BUG=todo

Review URL: https://codereview.chromium.org/442553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287480 0039d316-1c4b-4281-b951-d872f2087c98

I checked that gcc also expands NULL to just 0 here, so
this no longer seems like a clang bug.

BUG=162818

Review URL: https://codereview.chromium.org/437373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287479 0039d316-1c4b-4281-b951-d872f2087c98

Remove weak pointers from CastSocket by explicitly tracking and resetting callbacks created inside the class.

Ensure all sockets are closed and callbacks reset in all relevant code paths: Close(), CloseWithError(), and the dtor.

Review URL: https://codereview.chromium.org/417403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287477 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394085

Review URL: https://codereview.chromium.org/397793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287476 0039d316-1c4b-4281-b951-d872f2087c98

You can't Quit() the MessageLoop of a base::Thread. This CL makes
BackgroundServiceLoader use DelegateSimpleThread and run a MessageLoop
instead of using base::Thread, so that applications can safely Quit()
their current MessageLoop as usual to signify that they are done.

This shouldn't be necessary for the desktop shell once services are moved
out (network, NVS), but we'll likely continue to use this loader on android.

Note: the quit_on_shutdown() method is being removed in https://codereview.chromium.org/394903005/

BUG=

Review URL: https://codereview.chromium.org/437493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287475 0039d316-1c4b-4281-b951-d872f2087c98

This function in Aura is intended to be used for layer damage (not
window damage), so make the Mac version do the same.

BUG=none

Review URL: https://codereview.chromium.org/427393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287474 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287473 0039d316-1c4b-4281-b951-d872f2087c98

The FileDownloader refactor caused callbacks to be more tightly bound to
PnaclCoordinator than they were previously. Before the refactor, callbacks that
were invoked as the pexe was downloaded (or the cached translated nexe was
received) were generated through the CompletionCallbackFactory interface, which
would cause them to be cancelled when PnaclCoordinator was destroyed.

This change checks that the plugin instance is still alive before calling any
of the callbacks in the PPP_PexeStreamHandler interface.

I tried conducting some local testing, but didn't manage to hit quite the same
codepath as the one reported in the bug.

BUG=400171

Review URL: https://codereview.chromium.org/433633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287472 0039d316-1c4b-4281-b951-d872f2087c98

* lazy_background_task_queue_unittest.cc uses keyed_service/content directly
so make dependency explicit.
* I missed the GN build file when adding extensions_test.h/cc

BUG=none
TEST=compiles

Review URL: https://codereview.chromium.org/432433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287471 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True

Review URL: https://codereview.chromium.org/441753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287470 0039d316-1c4b-4281-b951-d872f2087c98

This refactor deletes AppWindow::Delegate, to simplify the arrangement
of classes relating to AppWindow. AppsClient has been moved from apps to
apps/ui, and ChromeAppsClient has been moved from chrome/browser/apps to
chrome/browser/ui/apps, for DEPS reasons.

This is a follow-up to r286514, which saw the rest of
AppWindow::Delegate's methods moved into another class.

BUG=391137
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/436503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287469 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Migrate TestCommon to Chromium c++ style and remove un-used header. (https://codereview.chromium.org/436133002/)

Reason for revert:
This patch removed some touch event logging in TestPlugin.cpp which broke the following layout tests

plugins/touch-events-details.html
plugins/touch-events-synthesized.html
plugins/transformed-events.html

Reverting.

Original issue's description:
> Migrate TestCommon to Chromium c++ style and remove un-used header.
> 
> Changes:
> 1) Run clang-format through source and header files.
> 2) Rename data member variables to use unix_hacker_ style.
> 3) Rename methods to use CamelCase style.
> 4) Rename file name to test_common.
> 5) Removed un-used test_common header.
> 
> BUG=331299
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287382

TBR=jochen@chromium.org,abhishek.a21@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=331299

Review URL: https://codereview.chromium.org/439973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287468 0039d316-1c4b-4281-b951-d872f2087c98

The paste PopupMenu was getting clipped by the status bar when the insertion
handle was brought close to the status bar. Update the position of the PopupMenu
 using the height of the status bar.

BUG=397915

Review URL: https://codereview.chromium.org/421173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287467 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the lint warns at:
Error: Field requires API level 19 (current min is 14):
    android.view.View#SYSTEM_UI_FLAG_IMMERSIVE_STICKY [InlinedApi]

So we need to add @SuppressLint to suppress this lint error.

BUG=327768

Review URL: https://codereview.chromium.org/420393006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287466 0039d316-1c4b-4281-b951-d872f2087c98

This should make it run in the ChromiumOS config on the Main Waterfall.

BUG=399315
TEST=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/437693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287465 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/432053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287464 0039d316-1c4b-4281-b951-d872f2087c98

 ToolkitDelegateViews will be moved to components/renderer_contenxt_menu in a separate CL so that athena can use it.

BUG=397320

Review URL: https://codereview.chromium.org/417063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399362
NOTRY=true

Review URL: https://codereview.chromium.org/434403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287462 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/437313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287461 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375497

Review URL: https://codereview.chromium.org/440703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287460 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287459 0039d316-1c4b-4281-b951-d872f2087c98

Revert 287325 because it breaks smoothness benchmarks on windows: "ValueError: LatencyInfo has no begin component"

> Implement scroll handler latency tracking
> 
> Since scroll handlers do not block composited scrolling, the existing
> input latency metric will only report the response time for the
> compositor when scrolling a page with a handler. This is not accurate
> for pages that implement scroll-synchronized effects, because the
> scroll handler needs to be invoked so that the page contents are
> updated with the new scroll offset.
> 
> This patch fixes the problem by forwarding latency information from the
> impl to the main thread when we are scrolling a layer that has an active
> scroll event handler.
> 
> In the case the scroll handler is no-op, the latency information will be
> terminated as a failed commit.
> 
> Sample trace:
> https://drive.google.com/file/d/0ByyxMXB38gLDRE40bkU5TVd0U00/edit?usp=sharing
> 
> BUG=347366
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282117
> 
> Review URL: https://codereview.chromium.org/365463003

TBR=skyostil@chromium.org

Review URL: https://codereview.chromium.org/436413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287458 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179480:179488&mode=html
TBR=pdr@chromium.org,enne@chromium.org,rjwright@chromium.org
BUG=

Review URL: https://codereview.chromium.org/433163008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287457 0039d316-1c4b-4281-b951-d872f2087c98

DnsTCPAttempt doesn't handle when read returns 0, which is EOF.
It keeps reading over and over, which will peg the CPU.

Fix it so it stops reading with ERR_CONNECTION_CLOSED,
and add unit tests for both ways the connection can close.

BUG=393923

Review URL: https://codereview.chromium.org/422323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287456 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes some minor issue on error handling: ignoring error and a bug on error handling.

BUG=none
TEST=none
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/439223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287455 0039d316-1c4b-4281-b951-d872f2087c98

TCMalloc is very slow in debug mode. Testing this out on Linux demonstrates
clear wins, so I'm hopeful Windows will similarly improve. This change mostly
copies the same configuration from ffmpeg, which unifies the setting of the
optimization level variables in target_defaults.

BUG=388949

Review URL: https://codereview.chromium.org/437163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362679

Review URL: https://codereview.chromium.org/435463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287453 0039d316-1c4b-4281-b951-d872f2087c98

The flag itself will be removed in a separate patch.

BUG=305511
TEST=manually tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/442613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287452 0039d316-1c4b-4281-b951-d872f2087c98

This adds translation from Annex B to AVCC format along with decoding
frames and binding them to textures.

It seems that kVTDecodeFrame_EnableTemporalProcessing is just a
suggestion to VideoToolbox, and one that it ignores. That means that,
for now, this code only outputs frames in the correct order for I-frame
only video.

BUG=133828

Review URL: https://codereview.chromium.org/397883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386033

Review URL: https://codereview.chromium.org/437113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287450 0039d316-1c4b-4281-b951-d872f2087c98

Use overlay scrollbars in athena, for both views and content.

BUG=398883
R=oshima@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/428583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287449 0039d316-1c4b-4281-b951-d872f2087c98

Before this CL, to check if the window is minimized, !IsActive() was
used. This function returns false when the bubble window is focused on
Windows or Chrome OS. Therefore, the bubble was not updated when the
bubble is already shown.

This CL fixes this bug by replacing !IsActive() with IsMinimize() to
check the state of Window properly.

BUG=393136, 389014 (the original CL about the bug around minimized window)
TEST=manual

Review URL: https://codereview.chromium.org/428583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287448 0039d316-1c4b-4281-b951-d872f2087c98

There are three main changes being made with the overall goal of
improving the smoothness of the video coming out of the tab capture
pipeline:

1. A new AnimatedContentSampler has been added that identifies which
frames were rendered due to animated content (e.g., a video or Flash
widget).  VideoCaptureOracle is then informed of exactly which subset of
frames should be captured from the compositor and provided near-perfect
frame timestamps for downstream consumers.

2. Additional plumbing in the FrameSubscriber interface to provide the
damage region of each frame.  This is used by AnimatedContentSampler.
Also, impls now provide true vsync-based presentation timestamps.

3. Raised the VideoCaptureController buffer pool count from 3 to 5.
This value is based on the logical capacity of the capture pipeline, and
not on hardware performance.  Testing revealed that more buffers are
needed to account for both multiple pipelined GPU readbacks as well as
those frames undergoing video encoding dowstream.

Testing: Tested mirroring using the usual self_mirroring.zip test
extension as well as the Google Cast extension to a Chromecast device.
Tested lock-in/out scenarios with a number of well- and ill- behaving
video playbacks.  Observed dramatic improvement in end-to-end smoothness
scores in the lab.  New unit tests to cover new code, and made sure all
relevant existing unit tests still pass.

BUG=258630

Review URL: https://codereview.chromium.org/418283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287447 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287435 0039d316-1c4b-4281-b951-d872f2087c98

Revert of sync: Add non-blocking type encryption support (https://codereview.chromium.org/423193002/)

Reason for revert:
Both LSAN and Valgrind complains about leaks in the tests.

Original issue's description:
> sync: Add non-blocking type encryption support
> 
> Introduces the framework for dealing with sync encryption in
> non-blocking types.  Unlike directory sync types, non-blocking type
> encryption only encrypts data before it is sent to the server.
> Encrypting the data on-disk is a separate problem.
> 
> Adds code to the ModelTypeSyncWorker so it can access the directory's
> cryptographer (through a CryptographerProvider interface) and use it to
> encrypt entities before it sends them to the server.  If the
> cryptographer is unable to encrypt with the desired key, the worker will
> not commit until the cryptographer returns to a good state.
> 
> Adds the concept of a "desired encryption key" to the data type state.
> When the cryptographer key to be used to encrypt a type changes, this
> will be reflected in the data type state.  The ModelTypeSyncProxy is
> responsible for ensuring that all items which have not yet been
> encrypted with this desired key are enqueued for commit.
> 
> Makes the ModelTypeSyncWorker, EntityTracker, and ModelTypeSyncProxy
> collaborate on the management of undecryptable (inapplicable) updates.
> The EntityTracker keeps track of their version numbers and content, and
> prevents the committing of new items to the server until the
> inapplicable update has been dealt with.  The ModelTypeSyncProxy is
> responsible for saving inapplicable updates across restarts.
> 
> This CL alone is not enough to enable encryption support for
> non-blocking types.  It requires additional code to hook up the
> ModelTypeSyncWorkers to receive cryptographer events.  This will be
> added in a future commit.  In the meantime, this CL includes plenty
> of unit tests to verify the functionality that's being added.
> 
> BUG=351005
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287428

TBR=zea@chromium.org,stanisc@chromium.org,rlarocque@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=351005

Review URL: https://codereview.chromium.org/442623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287433 0039d316-1c4b-4281-b951-d872f2087c98

BUG=299804,400547
NOTRY=true
TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/441803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287432 0039d316-1c4b-4281-b951-d872f2087c98