- 15 Mar, 2011 40 commits
-
-
caseq@chromium.org authored
Unreviewed. Swap two calls to setMonitoringXHREnabled to get rid of side effects on other tests. * inspector/protocol/console-agent-expected.txt: * inspector/protocol/console-agent.html: git-svn-id: svn://svn.chromium.org/blink/trunk@81131 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
caseq@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: further extension API cleanup (removed inspectedPage, add experimental prefix) https://bugs.webkit.org/show_bug.cgi?id=56327 * inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI): * inspector/front-end/ExtensionAPISchema.json: git-svn-id: svn://svn.chromium.org/blink/trunk@81130 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
yurys@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: when console.groupEnd calls twice https://bugs.webkit.org/show_bug.cgi?id=56114 * inspector/console/console-nested-group-expected.txt: Added. * inspector/console/console-nested-group.html: Added. 2011-03-15 Yury Semikhatsky <yurys@chromium.org> Reviewed by Pavel Feldman. Web Inspector: when console.groupEnd calls twice https://bugs.webkit.org/show_bug.cgi?id=56114 Test: inspector/console/console-nested-group.html * inspector/ConsoleMessage.h: (WebCore::ConsoleMessage::type): * inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addConsoleMessage): do not coalesce adjacent EndGroup messages. git-svn-id: svn://svn.chromium.org/blink/trunk@81129 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Adam Barth. Initializing several member variables that were not initialized in their constructors. These values were all read prior to initialization as reported by Valgrind. No new tests: No feature additions/removals. * accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink): * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): * xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult): git-svn-id: svn://svn.chromium.org/blink/trunk@81128 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
hayato@chromium.org authored
Reviewed by Shinichiro Hamaji. [NRWT] Add support for reftests to new-run-webkit-tests. https://bugs.webkit.org/show_bug.cgi?id=55457 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/dryrun.py: * Scripts/webkitpy/layout_tests/port/test.py: * Scripts/webkitpy/layout_tests/port/test_files.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: git-svn-id: svn://svn.chromium.org/blink/trunk@81127 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=56255 Fix build on Solaris 10/Sun Studio 12 C++ No new tests. This is to fix compilation on Solaris 10 with Sun Studio 12 C++ * bridge/runtime_array.h: (JSC::RuntimeArray::getConcreteArray): git-svn-id: svn://svn.chromium.org/blink/trunk@81126 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
philn@webkit.org authored
Unreviewed, skip failing media test on GTK. * platform/gtk/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@81125 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
apavlov@chromium.org authored
[Chromium] Unreviewed, update test expectations * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81124 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
alex@webkit.org authored
Reviewed by Martin Robinson. [GTK] Fix compilation warning after r80892 https://bugs.webkit.org/show_bug.cgi?id=56302 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::originsWithLocalStorage): git-svn-id: svn://svn.chromium.org/blink/trunk@81123 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
robert@webkit.org authored
Reviewed by Adam Barth. Document the qmakearg argument, and hint how to build webkit2 on Qt https://bugs.webkit.org/show_bug.cgi?id=56326 * Scripts/build-webkit: add --qmakearg to build-webkit --help git-svn-id: svn://svn.chromium.org/blink/trunk@81122 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by David Levin. Update Chromium test expectations for fast/forms/onchange-setvalueforuser https://bugs.webkit.org/show_bug.cgi?id=56365 * platform/chromium/fast/forms/onchange-setvalueforuser-expected.txt: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@81121 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
aroben@apple.com authored
We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably give it a few more days of greenness first. Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder Reviewed by Sam Weinig. * Scripts/webkitpy/common/net/buildbot/buildbot.py: (BuildBot): Added a regexp to match Windows 7 Release (Tests). * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org. Updated the core regexps to match the buildbot module. Updated the expected results to match the current set of core builders. git-svn-id: svn://svn.chromium.org/blink/trunk@81120 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rniwa@webkit.org authored
Another Chromium rebaseline for r81095. * platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81119 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
laszlo.1.gombos@nokia.com authored
Unreviewed build fix. Buildfix when JIT is not enabled after r81079 https://bugs.webkit.org/show_bug.cgi?id=56361 * runtime/Executable.cpp: git-svn-id: svn://svn.chromium.org/blink/trunk@81118 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
aroben@apple.com authored
* TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@81117 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
weinig@apple.com authored
<rdar://problem/9108119> https://bugs.webkit.org/show_bug.cgi?id=56357 Source/WebCore: Reviewed by Adam Roben Test: AboutBlankLoad * platform/network/cf/ResourceResponse.h: * platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::cfURLResponse): Create a CFURLResponseRef if one does not exist yet as we do for NSURLResponses on the mac. Tools: Reviewed by Adam Roben. * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added. (TestWebKitAPI::decidePolicyForResponse): (TestWebKitAPI::TEST): Add test that loads of about:blank have a response with a MIMEType of text/html. * TestWebKitAPI/PlatformUtilities.h: * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: (TestWebKitAPI::Util::MIMETypeForWKURLResponse): * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: (TestWebKitAPI::Util::MIMETypeForWKURLResponse): Add helper to get the MIMEType from a WKURLResponse. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/win/TestWebKitAPI.vcproj: Add new files. git-svn-id: svn://svn.chromium.org/blink/trunk@81116 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ap@apple.com authored
Reviewed by Darin Adler. REGRESSION: Print preview is blank when selecting multiple pages per sheet https://bugs.webkit.org/show_bug.cgi?id=56341 <rdar://problem/8991382> * UIProcess/API/mac/WKPrintingView.mm: (pageDidDrawToPDF): Don't reset latest expected callback number after receiving a different one. We only update preview after receiving the latest expected page data (and the assumption is that AppKit will ask for pages in natural order for N-up). git-svn-id: svn://svn.chromium.org/blink/trunk@81115 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Seeking videos using the timeline bar does not work properly and stop the video playback. https://bugs.webkit.org/show_bug.cgi?id=56145 We do not need seekTimeout and queuedSeekTimeout anymore. setPosition on QMediaPlayer is good enough. positionChanged() will be emitted when the data is buffered. On Linux the signal was not emitted because of a bug in QtMultimedia. * platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): (WebCore::MediaPlayerPrivateQt::seek): (WebCore::MediaPlayerPrivateQt::stateChanged): (WebCore::MediaPlayerPrivateQt::positionChanged): * platform/graphics/qt/MediaPlayerPrivateQt.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81114 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Kenneth Russell. Graphics Context is not properly recovered if the GPU process dies. https://bugs.webkit.org/show_bug.cgi?id=56148 Split context recreation into two steps. * src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::doComposite): (WebKit::WebViewImpl::reallocateRenderer): * src/WebViewImpl.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81113 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
morrita@google.com authored
Unreviewed, skipped tests that uses an unsupported DRT API. * platform/qt/Skipped: * platform/win/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@81112 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
ap@apple.com authored
Reviewed by Adam Roben. https://bugs.webkit.org/show_bug.cgi?id=44138 Crashes beneath SocketStreamHandle::readStreamCallback when running WebSocket tests. * platform/win/Skipped: Unskipped tests that should be fixed now. I couldn't verify that locally, becasue most WebSocket tests time out on my machine. 2011-03-14 Alexey Proskuryakov <ap@apple.com> Reviewed by Adam Roben. https://bugs.webkit.org/show_bug.cgi?id=44138 Crash beneath SocketStreamHandle::readStreamCallback when running websocket/tests/workers/worker-handshake-challenge-randomness.html https://bugs.webkit.org/show_bug.cgi?id=55375 http/tests/websocket/tests/reload-crash.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows https://bugs.webkit.org/show_bug.cgi?id=56185 http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows * platform/network/cf/SocketStreamHandle.h: Made SocketStreamHandle ThreadSafeShared, so that a pointer can be passed across threads when wrapped in a RefPtr. * platform/network/cf/SocketStreamHandleCFNet.cpp: Make sure that an object still exists when executing a method on main thread by using RefPtr. git-svn-id: svn://svn.chromium.org/blink/trunk@81111 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rniwa@webkit.org authored
Chromium rebaselines for r81095. * platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt: * platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt: * platform/chromium-linux/editing/pasteboard/smart-drag-drop-expected.txt: * platform/chromium-linux/editing/pasteboard/smart-paste-003-expected.txt: * platform/chromium-linux/editing/pasteboard/smart-paste-004-expected.txt: * platform/chromium-linux/editing/selection/fake-drag-expected.txt: Removed. * platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt: * platform/chromium-win/editing/deleting/smart-delete-001-expected.txt: * platform/chromium-win/editing/deleting/smart-delete-002-expected.txt: * platform/chromium-win/editing/pasteboard/smart-drag-drop-expected.txt: * platform/chromium-win/editing/pasteboard/smart-paste-001-expected.txt: * platform/chromium-win/editing/pasteboard/smart-paste-003-expected.txt: * platform/chromium-win/editing/pasteboard/smart-paste-004-expected.txt: * platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt: * platform/chromium-win/editing/selection/after-line-break-expected.txt: * platform/chromium-win/editing/selection/expanding-selections-expected.txt: * platform/chromium-win/editing/selection/expanding-selections2-expected.txt: * platform/chromium-win/editing/selection/fake-drag-expected.txt: * platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt: * platform/chromium-win/editing/selection/triple-click-in-pre-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81110 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rniwa@webkit.org authored
GTK and Qt rebaselines for r81095. * platform/gtk/editing/deleting/smart-delete-001-expected.txt: * platform/gtk/editing/deleting/smart-delete-002-expected.txt: * platform/gtk/editing/pasteboard/smart-paste-001-expected.txt: * platform/gtk/editing/pasteboard/smart-paste-003-expected.txt: * platform/gtk/editing/pasteboard/smart-paste-004-expected.txt: * platform/gtk/editing/pasteboard/smart-paste-007-expected.txt: * platform/gtk/editing/pasteboard/smart-paste-008-expected.txt: * platform/gtk/editing/selection/expanding-selections-expected.txt: * platform/gtk/editing/selection/expanding-selections2-expected.txt: * platform/gtk/editing/selection/fake-drag-expected.txt: * platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt: * platform/gtk/editing/selection/triple-click-in-pre-expected.txt: * platform/qt/editing/deleting/smart-delete-001-expected.txt: * platform/qt/editing/pasteboard/smart-paste-001-expected.txt: * platform/qt/editing/pasteboard/smart-paste-003-expected.txt: * platform/qt/editing/pasteboard/smart-paste-004-expected.txt: * platform/qt/editing/pasteboard/smart-paste-007-expected.txt: * platform/qt/editing/selection/expanding-selections-expected.txt: * platform/qt/editing/selection/expanding-selections2-expected.txt: * platform/qt/editing/selection/triple-click-in-pre-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81109 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser https://bugs.webkit.org/show_bug.cgi?id=56006 * QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView): * QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions): git-svn-id: svn://svn.chromium.org/blink/trunk@81108 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
weinig@apple.com authored
* WebCore.exp.in: git-svn-id: svn://svn.chromium.org/blink/trunk@81107 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Ojan Vafai. Add method to make BuildBot return test outputs https://bugs.webkit.org/show_bug.cgi?id=54374 The Builder.latest_cached_build will be used by the new rebaseline script to determine the build to use baselines from. * Scripts/webkitpy/common/net/buildbot/buildbot.py: * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: git-svn-id: svn://svn.chromium.org/blink/trunk@81106 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
aroben@apple.com authored
Reviewed by Sam Weinig. Source/WebKit2: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::canHandleRequest): Return true for any URL schemes that are handled as empty documents, and defer to the platform for everything else. * WebProcess/WebPage/WebPage.h: Added platformCanHandleRequest. * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::platformCanHandleRequest): * WebProcess/WebPage/qt/WebPageQt.cpp: (WebKit::WebPage::platformCanHandleRequest): * WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::WebPage::platformCanHandleRequest): Renamed from canHandleRequest. Tools: Test that WKBundlePageCanHandleRequest returns true for empty document URLs * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added. (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test. (TestWebKitAPI::setInjectedBundleClient): Hook up our callback. (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to ensure the web process is initialized, then ask the bundle to run the test and assert that it succeeded. * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added. (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class. (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to handle a given URL. (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown URL type cannot be handled). (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the result. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * TestWebKitAPI/win/TestWebKitAPI.vcproj: * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Added new files to the project. git-svn-id: svn://svn.chromium.org/blink/trunk@81105 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
joepeck@webkit.org authored
Reviewed by Eric Carlson. Stalled media elements don't stop delaying the load event https://bugs.webkit.org/show_bug.cgi?id=56316 * http/tests/media/video-play-stall-before-meta-data-expected.txt: Added. * http/tests/media/video-play-stall-before-meta-data.html: Added. 2011-03-14 Joseph Pecoraro <joepeck@webkit.org> Reviewed by Eric Carlson. Stalled media elements don't stop delaying the load event https://bugs.webkit.org/show_bug.cgi?id=56316 We should stop delaying the load event when the load has stalled naturally, or if we require a user gesture to continue the load. Test: http/tests/media/video-play-stall-before-meta-data.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): when suspending, stop delaying. (WebCore::HTMLMediaElement::progressEventTimerFired): when stalling, stop delaying. git-svn-id: svn://svn.chromium.org/blink/trunk@81104 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
mrowe@apple.com authored
Roll out r81097. It broke the 32-bit Mac build and caused assertion failures on the Windows Debug bots. git-svn-id: svn://svn.chromium.org/blink/trunk@81103 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Martin Robinson. [GTK] Possible leaks after splitting TextCheckerClientEnchant. https://bugs.webkit.org/show_bug.cgi?id=55989 Convert gchar* to GOwnPtr<gchar> and refactor the code. * WebCoreSupport/TextCheckerClientEnchant.cpp: (WebKit::TextCheckerClientEnchant::checkSpellingOfString): git-svn-id: svn://svn.chromium.org/blink/trunk@81102 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
morrita@google.com authored
Reviewed by Tony Chang. Crash when dragging and dropping in a document with an invalid XHTML header https://bugs.webkit.org/show_bug.cgi?id=48799 * editing/pasteboard/drop-file-svg.html: Added. * editing/pasteboard/resources/drop-file-svg.svg: Added. 2011-03-13 MORITA Hajime <morrita@google.com> Reviewed by Tony Chang. Crash when dragging and dropping in a document with an invalid XHTML header https://bugs.webkit.org/show_bug.cgi?id=48799 DragController tried to dispatch textInput event even when the drag destination is not the editable area. This change skips the event dispatching on that case. Test: editing/pasteboard/drop-file-svg.html * page/DragController.cpp: (WebCore::DragController::dispatchTextInputEventFor): (WebCore::DragController::concludeEditDrag): git-svn-id: svn://svn.chromium.org/blink/trunk@81101 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
ggaren@apple.com authored
Reviewed by Oliver Hunt. Made the global object moving-GC-safe https://bugs.webkit.org/show_bug.cgi?id=56348 SunSpider reports no change. * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren): Removed a dubious comment that suggested we do not need to visit all our references during GC, since that is not true in a moving GC. Re-sorted data members by type, removed one duplicate, and added back the one missing mark I found. * runtime/JSGlobalObject.h: Re-sorted data members by type. git-svn-id: svn://svn.chromium.org/blink/trunk@81100 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
levin@chromium.org authored
http://trac.webkit.org/changeset/81094 https://bugs.webkit.org/show_bug.cgi?id=56355 Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-03-14 Broke the chromium DRT related build. (Requested by dave_levin on #webkit). Source/WebCore: * WebCore.exp.in: * WebCore.order: * page/Frame.cpp: (WebCore::Frame::layerTreeAsText): * page/Frame.h: * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText): * rendering/RenderLayerCompositor.h: Source/WebKit/chromium: * public/WebFrame.h: * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::renderTreeAsText): (WebKit::WebFrameImpl::layerTreeAsText): * src/WebFrameImpl.h: Tools: * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::layerTreeAsText): * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest): (TestShell::dump): * DumpRenderTree/chromium/TestShell.h: (TestParams::TestParams): git-svn-id: svn://svn.chromium.org/blink/trunk@81099 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@webkit.org authored
Apparently we need to exclude DefaultSharedWorkerRepository.cpp from the Chromium build, otherwise the objects visible in the global scope change. * WebCore.gyp/WebCore.gyp: git-svn-id: svn://svn.chromium.org/blink/trunk@81098 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by David Hyatt. bug 56052: percentages are incorrectly rounded in WebKit https://bugs.webkit.org/show_bug.cgi?id=56052 * platform/mac/fast/css/percentage-non-integer-expected.txt: 2011-03-14 Rik Cabanier <cabanier@adobe.com> Reviewed by David Hyatt. bug 56052: percentages are incorrectly rounded in WebKit https://bugs.webkit.org/show_bug.cgi?id=56052 test: fast/css/percentage-non-integer.html * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): * page/PrintContext.cpp: (WebCore::PrintContext::pageProperty): * platform/Length.h: (WebCore::Length::Length): (WebCore::Length::operator*=): (WebCore::Length::value): (WebCore::Length::percent): (WebCore::Length::setValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::isUndefined): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative): * rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::computePreferredLogicalWidths): (WebCore::AutoTableLayout::calcEffectiveLogicalWidth): (WebCore::AutoTableLayout::layout): * rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::layout): * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows): * rendering/style/BorderData.h: (WebCore::BorderData::hasBorderRadius): git-svn-id: svn://svn.chromium.org/blink/trunk@81097 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
abarth@webkit.org authored
Attempted Chromium build fix. Exclude AllInOne harder. * WebCore.gyp/WebCore.gyp: git-svn-id: svn://svn.chromium.org/blink/trunk@81096 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rniwa@webkit.org authored
Reviewed by Darin Adler. EventHandler calls shouldChangeSelection needlessly https://bugs.webkit.org/show_bug.cgi?id=56324 Extracted setSelectionIfNeeded and setNonDirectionalSelectionIfNeeded and avoided calling shouldChangeSelection and setSelection when the existing selection is identical to that of new selection. * page/EventHandler.cpp: (WebCore::setSelectionIfNeeded): Extracted. (WebCore::setNonDirectionalSelectionIfNeeded): Extracted. (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls a helper function above. (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto. (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto. (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto. (WebCore::EventHandler::updateSelectionForMouseDrag): Ditto. (WebCore::EventHandler::handleMouseReleaseEvent): Ditto. 2011-03-14 Anton Muhin <antonm@chromium.org> Reviewed by Adam Barth. [v8] Rework object group building. https://bugs.webkit.org/show_bug.cgi?id=55399 Instead of going top-down (from owner to owned elements), go up---from objects to their group ids. That fits better to v8's object grouping model and guarantees that each wrapper belongs to the single group. Alas, this cannot be implemented for one kind of objects---CSSProperties. Part of core GC algorithm and tested extensively by exisiting layout tests. * platform/chromium/test_expectations.txt: Temporary suppress text differences. git-svn-id: svn://svn.chromium.org/blink/trunk@81095 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Simon Fraser. [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline https://bugs.webkit.org/show_bug.cgi?id=56139 * WebCore.exp.in: * WebCore.order: * page/Frame.cpp: (WebCore::Frame::layerTreeAsText): * page/Frame.h: * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText): * rendering/RenderLayerCompositor.h: 2011-03-14 Daniel Sievers <sievers@google.com> Reviewed by Simon Fraser. [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline https://bugs.webkit.org/show_bug.cgi?id=56139 * public/WebFrame.h: * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::renderTreeAsText): (WebKit::WebFrameImpl::layerTreeAsText): * src/WebFrameImpl.h: 2011-03-14 Daniel Sievers <sievers@google.com> Reviewed by Simon Fraser. [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline https://bugs.webkit.org/show_bug.cgi?id=56139 * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::layerTreeAsText): * DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShowDebugLayerTree): * DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest): (TestShell::dump): * DumpRenderTree/chromium/TestShell.h: (TestParams::TestParams): git-svn-id: svn://svn.chromium.org/blink/trunk@81094 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
abarth@webkit.org authored
Reviewed by Dimitri Glazkov. Add remaining files to WebCore.gypi https://bugs.webkit.org/show_bug.cgi?id=56351 Adding the remaining files to WebCore.gypi required updating the include/exclude lists in WebCore.gyp. These lists aren't overly elegant, but we can try to improve them in the future. * WebCore.gyp/WebCore.gyp: * WebCore.gypi: * bindings/v8/ScriptCachedFrameData.cpp: - Added ifdefs to this file to match the header. * platform/graphics/WOFFFileFormat.cpp: - Fixed build error when compiling without ENABLE(OPENTYPE_SANITIZER). git-svn-id: svn://svn.chromium.org/blink/trunk@81093 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
antonm@chromium.org authored
Reviewed by Adam Barth. [v8] Rework object group building. https://bugs.webkit.org/show_bug.cgi?id=55399 Instead of going top-down (from owner to owned elements), go up---from objects to their group ids. That fits better to v8's object grouping model and guarantees that each wrapper belongs to the single group. Alas, this cannot be implemented for one kind of objects---CSSProperties. Part of core GC algorithm and tested extensively by exisiting layout tests. * platform/chromium/test_expectations.txt: Temporary suppress text differences. 2011-03-14 Anton Muhin <antonm@chromium.org> Reviewed by Adam Barth. [v8] Rework object group building. https://bugs.webkit.org/show_bug.cgi?id=55399 Instead of going top-down (from owner to owned elements), go up---from objects to their group ids. That fits better to v8's object grouping model and guarantees that each wrapper belongs to the single group. Alas, this cannot be implemented for one kind of objects---CSSProperties. Part of core GC algorithm and tested extensively by exisiting layout tests. * bindings/scripts/CodeGeneratorV8.pm: * bindings/scripts/test/V8/V8TestInterface.cpp: * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: * bindings/scripts/test/V8/V8TestObj.cpp: * bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId): (WebCore::calculateRootStyleSheet): (WebCore::GrouperVisitor::visitDOMWrapper): (WebCore::GrouperVisitor::applyGrouping): (WebCore::V8GCController::gcPrologue): * bindings/v8/WrapperTypeInfo.h: (WebCore::WrapperTypeInfo::isSubclass): * css/CSSRuleList.h: (WebCore::CSSRuleList::styleList): * css/StyleSheetList.h: (WebCore::StyleSheetList::document): git-svn-id: svn://svn.chromium.org/blink/trunk@81092 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-