- 17 Oct, 2017 40 commits
-
-
Keishi Hattori authored
Removes support for the no longer used OwnPtr Bug: Change-Id: I38faf4aedb9bbc335c9f61bb5e38771338f1a187 Reviewed-on: https://chromium-review.googlesource.com/720861Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#509337}
-
Alex Clarke authored
Bug: Change-Id: I09a31dcf632c8150cd1fc6f5560af826aed89bd1 Reviewed-on: https://chromium-review.googlesource.com/721360Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#509336}
-
Takashi Toyoshima authored
This does nothing interesting now, but can be the base of coming unit tests for CORSURLLoader. This test is based on following hintzed's patch, but modified to be in more common style in chromium. https://chromium-review.googlesource.com/c/chromium/src/+/558226 Bug: 736308 Change-Id: I93a5a4eccdb3d2379ff4e5a29fab874f9cc8ca7b Reviewed-on: https://chromium-review.googlesource.com/704419Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#509335}
-
Sylvain Defresne authored
Code is compiled but never used, so as a first step before deleting the code, stop compiling it (this proves that it is really unused). Bug: 775332 Change-Id: Ie38fba7c8f27bf10301c0e37187d1ee69df0ca86 Reviewed-on: https://chromium-review.googlesource.com/722358 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#509334}
-
Piotr Swigon authored
This patch contains a test for the change in crrev.com/c/722384, which has been extracted out for easier merging. Bug: 771984 Change-Id: I22ef843febc297a4f2a85a2d0957e7619981e781 Reviewed-on: https://chromium-review.googlesource.com/722488 Commit-Queue: Piotr Swigon <piotrs@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#509333}
-
Xiaohan Wang authored
This CL updates EncryptedMediaSupportedTypesTest (and related tests classes) to test persistent license support. BUG=767941 TEST=Add new test cases Change-Id: Iece24005316ce1e4f09cd807756499d69e4c7821 Reviewed-on: https://chromium-review.googlesource.com/719384 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#509332}
-
nikhil authored
Auto fill should work in cases where iframe domain is different but have same public suffix and the next lower subdomain. For example, on the homepage of schwab.com, the login form is hosted in an iframe on a different domain. (main page: https://www.schwab.com/, iframe: https://lms.schwab.com). This patch relaxes auto filling only when eTLD+1 is the same for both the iframe and the main frame. BUG=770181 Change-Id: Idd44aa5a31aaf8ea159e1f7149043ace657be6b0 Reviewed-on: https://chromium-review.googlesource.com/704435Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#509331}
-
Jaebaek Seo authored
When enabling --use-zoom-for-dsf, inspecting Android chrome using devtool has three problems: 1. screencast is zoomed in, 2. the size of selected DOM element to inspect it is bigger than correct one, 3. a mouse click points weird position. See crbug.com/737777#c35. The root cause of those problem is that --use-zoom-for-dsf multiplies the page zoom by the device scale factor (DSF), so scaling some lengths by the page zoom factor makes them DSF scale. To solve it, this CL scales down the page zoom factor and the top control height by DSF. Bug: 737777 Change-Id: I367b7e5cf4c485263f905857ed947977dd44a4ee Reviewed-on: https://chromium-review.googlesource.com/715080 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#509330}
-
Edward Lemur authored
As it is, it's always zipped into 'test_artifacts.zip', so if there are multiple devices, they'll all write to the same file, and there might be a race condition. Bug: webrtc:8391 Change-Id: I490e0678c3ba8558dc7ce9ea9a620b5b7f008a80 Reviewed-on: https://chromium-review.googlesource.com/718704Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Henrik Kjellander <kjellander@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#509329}
-
Hiroki Nakagawa authored
This CL does 2 things: (1) The Worklet spec defines WorkletGlobalScope must have a unique opaque origin: "3. Let origin be a unique opaque origin." https://drafts.css-houdini.org/worklets/#script-settings-for-worklets However, our current impl doesn't obey this requirement. PaintWorklet inherits its owner document's SecurityOrigin. AnimationWorklet and AudioWorklet create a SecurityOrigin based on their script URL. This CL replaces them with SecurityOrigin::CreateUnique(). (2) Our current impl checks CORS etc based on ExecutionContext's SecurityOrigin associated with Modulator. For Worklets, these are WorkletGlobalScope and WorkletModulatorImpl. However, Worklets need to fetch their scripts as sub-resources of the owner Document, so the security checks are conducted based on the owner Document's SecurityOrigin. After changes for (1), SecurityOrigin is a unique opaque origin and it fails a bunch of tests because of CORS check failures. To fix this, WorkletModulatorImpl overrides GetSecurityOrigin() to provide the owner Document's SecurityOrigin for module fetch. Bug: 773772, 773778 Change-Id: I451999ef09b943c480e907e6536ca8819f446d5b Reviewed-on: https://chromium-review.googlesource.com/714499 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Sergei Datsenko authored
Change-Id: Ia593a25d8d305f8df7d0f9647a9f7f328b7897eb Reviewed-on: https://chromium-review.googlesource.com/717216Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#509327}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b83707f4..f4579b90 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I30ccd8527e19c7788f658cbf2d1e7e9e3ac0bcb2 Reviewed-on: https://chromium-review.googlesource.com/721941Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#509326}
-
Klemen Kozjek authored
Before the CL, in case when external removable drive had '#' character in its name it caused that disk was not accessible through Files App. The user was able to select the drive, but no content was displayed neither they were able to add new files to the drive. This CL sanitizes and suggests mount point names for all mountable drives to prevent mounting a device with '#' in its name. Bug: 774241 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I90e5808bb0d8b4a26becaf9ba30b538ce580b3dd Reviewed-on: https://chromium-review.googlesource.com/720639Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Klemen Kozjek <klemenko@google.com> Cr-Commit-Position: refs/heads/master@{#509325}
-
Ke He authored
The HidCollectionInfo and HidUsageAndPage were defined in mojom, so the duplicated definitions in C++ should be removed. The hid.typemap and struct traits are also removed. BUG=728223 Change-Id: Id53d19ebb930b9b60910c8b23a145dbf058a7f8a Reviewed-on: https://chromium-review.googlesource.com/708775 Commit-Queue: Ke He <ke.he@intel.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509324}
-
Klemen Kozjek authored
This CL removes translation strings for external drive rename notifications, because they are no longer in use. BUG=775018 CQ-DEPEND=CL:722140 Change-Id: Ia85cc845302f0db83e6dcad88445d2f774bb704a Reviewed-on: https://chromium-review.googlesource.com/722460Reviewed-by:
-
tzik authored
DeletionSentinel may fail to detect TaskQueueManager deletion on a nested message loop: If there's a nested message loop that spins in task_annotator_.RunTask() at line 531, ProcessTaskFromWorkQueue() is reentered. As both outer and inner PTFWQ hold a ref to the DeletionSentinel instance, protect->HasOneRef() at line 534 doesn't hit even when the TaskQueueManager is gone. This CL replaces it with WeakPtr that covers the reentered case. Change-Id: Ia15947fcac399dc45994b0df7514a3872c6ba25c Reviewed-on: https://chromium-review.googlesource.com/721219 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#509322}
-
Daniel Bratell authored
There are 5 different kFilteredMessages arrays in content/browser and some of them collide in jumbo (chromium unity builds) build experiments. This patch renames them to: kCacheFilteredMessageClasses kFileApiFilteredMessageClasses kPepperFilteredMessageClasses kRenderFilteredMessageClasses kServiceWorkerFilteredMessageClasses Bug: 746953 Change-Id: I3fc1b6f6ea3d0e5ccbb2ff47d4d476e02f5c2344 Reviewed-on: https://chromium-review.googlesource.com/721279Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Michael Nordman <michaeln@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#509321}
-
Daniel Bratell authored
In the jumbo build experiment (chromium unity builds) there is a collision between the two different kDataFile strings. This patch renames them kNetworkErrorDataFile and kTargetsDataFile which also matches their intended values. Bug: 746953 Change-Id: Ib9f47fa4d358303c7cdbb65b54b40080521a915d Reviewed-on: https://chromium-review.googlesource.com/721299Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#509320}
-
Will Chen authored
This eliminates a lot of the code duplication between the new and legacy integration test frameworks by making the legacy test helper files small wrappers to load the new *test_runner modules. * Fixes data_grid_test_runner because the legacy test helpers had two data grid implementations, one of which was not actually used anymore. Bug: 667560 Change-Id: I2ad21ec7b50be89a44f643858cec3b9348d8d857 Reviewed-on: https://chromium-review.googlesource.com/722112 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
-
Marc Treib authored
For a long while now, this method always returns true on desktop and false on mobile, so any code that's either desktop-only or mobile-only doesn't need to check it. Bug: 627747 Change-Id: I6d1b25ad0e6f2c76a0013725b675e5d059f6cff0 Reviewed-on: https://chromium-review.googlesource.com/720922Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#509318}
-
Daniel Cheng authored
The original code used a different way to check that the extension is an image extension (and not something else, like .exe), but this depended on being able to directly access the blink::Image class. When the name calculation was moved into the browser, blink::IsSupportedImageType was used instead to ensure that a user doesn't drag out an image and get something surprising like an executable instead. However, it turns out that blink::IsSupportedImageType doesn't consider SVG an image type--since it's actually an XML file. To get around this, just simply check that the MIME type begins with image/. This is safe enough, since the filename calculation only takes well-known MIME types into consideration. Bug: 767775 Change-Id: I5c71d8ae2daa9a413beab9c3c1cb393760383323 Reviewed-on: https://chromium-review.googlesource.com/721615 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Christopher Cameron authored
Bug: 775202 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9565ee77b276fe14ecbdfaf17ec18d348a80cb85 Reviewed-on: https://chromium-review.googlesource.com/722034Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#509316}
-
Klemen Kozjek authored
This CL removes notifications to indicate successfully completed and pending operation of an external drive rename. Related strings will be removed in CL:722460. Bug: 775018 Test: browser_tests --gtest_filter=FileManagerJsTest.DeviceHandlerTest Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3eb43a6f4cc4f53214e074813e04f561262d7767 Reviewed-on: https://chromium-review.googlesource.com/722140 Commit-Queue: Klemen Kozjek <klemenko@google.com> Reviewed-by:
-
Lucas Garron authored
The committed interstitial project will use a navigation throttle [1] to watch for requests that failed due to cert errors. WillFailRequest() will allow it to decide how to respond, and provide custom error HTML for SSL interstitials. [1] crrev.com/c/621236 Bug: 751941 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I9a597851d018e3e42d884c185ba2c619b9d31923 Reviewed-on: https://chromium-review.googlesource.com/621873 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#509314}
-
Iris Uy authored
Bug: Change-Id: Icb5351bb6112fc89e36dab82c15f32887dab9217 Reviewed-on: https://chromium-review.googlesource.com/720594Reviewed-by:
-
erikchen authored
The existing code for views::ScrollView and views::TableView contains a layout-dependency cycle. * The size of the TableView depends on whether scrollbars are present. * Whether scrollbars are present is dependent on the size of the TableView. This causes the following problem: The TableView sets its height to ScrollView::content_viewport_'s height. But the TableView's width is wider than the viewport's width. This causes the ScrollView to add a horizontal scrollbar. But now horizontal scrollbar + content's height > viewport's height, so a vertical scrollbar is also necessary. A full fix to this problem would require a large refactor to avoid layout-dependency cycles. Instead, I will extend an existing workaround. Prior to invoking layout for the TableView, the contents_viewport_ will be artificially shrunk to make space for both a vertical and horizontal scrollbar. Previously, it was only shrunk to make space for a vertical scrollbar. This way, if the contents chooses to take up the full height, there's enough space for a horizontal scrollbar to appear without causing a vertical scrollbar to appear. Bug: 771502 Change-Id: Ib97ddd8f5619d16342ee85e7ad280c049a1566e5 Reviewed-on: https://chromium-review.googlesource.com/719380 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#509312}
-
Blake O'Hare authored
This is a small first step towards the floating keyboard, although the changes here are pre-emptive refactorings independent of any floating keyboard functionality or UX (and are probably reasonable de-couplings to do anyway). Unit tests that are coupled to the current animation behavior are still valid and pass, although those should be decoupled when more container behaviors are added. Bug: Change-Id: Ifbd8e4125fe4be89e03a2fec813714edc0036996 Reviewed-on: https://chromium-review.googlesource.com/720541 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Keigo Oka <oka@chromium.org> Cr-Commit-Position: refs/heads/master@{#509311}
-
Yuichiro Hanada authored
Also clean up some obsolete paths. Change-Id: I843dba25f99dbae12b3e420317d1259b54b1b1d3 Reviewed-on: https://chromium-review.googlesource.com/713034Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#509310}
-
Albert J. Wong authored
Prior to this CL, DecommitSystemPages() performed 2 conceptually different operations that callers cared about depending on which platorm it was called on. There are 2 operations: * return storage from ram or swap to the OS * make the page inaccessible. On Windows, "Committed memory" is a first-class concept in the OS Memory Subsystem API. A region returned via VirtualAlloc() when MEM_COMMIT is specified is guaranteed to be touchable without causing the program to crash due to out of memory. Since it is a first class concept, decommitting is directly supported and calling this function resulted in the both operations above. In the POSIX memory API, there is no such thing as "Committed memory." Until the first touch of an anonymous mmap()ed region, it is unknown if the pointer deference for that address may crash. Therefore this API had unclear semantics and was implemented to ONLY return allocated ram and swap to the OS. Page permissions were left the same meaning subsequent touches would just reallocate the memory instead of fault. This divergence in page accessibility caused callers to manually execute SetSystemPagesAccess() after calling DecommitSystemPages() to ensure uniform behavior across all platforms which resulted in a wasted syscall on Windows and confusing API semantics. This CL changes the contract of DecommitSystemPages() so that it provides the guarnatees that can be enforced on all platforms. The naming is still somewhat incorrect as "commit" is not a well defined concept in POSIX...baby steps... Bug: 766882 Change-Id: Ib5c8f1c712e080f1003fad628f60012e0feaf9d8 Reviewed-on: https://chromium-review.googlesource.com/696292 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#509309}
-
Yuichiro Hanada authored
Also remove several people who are no longer working in chromium. Bug: None Change-Id: I8221077bd2aa0d1e0e271dc19c48b5e4a5ad627d Reviewed-on: https://chromium-review.googlesource.com/701877Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#509308}
-
Piotr Swigon authored
POST requests should not get opened in CCT, as: 1) Request might not require redirecting the user. 2) CCT will issue the request as GET and drop the request body. Test for this change has been extracted to crrev.com/c/722488 for easier merging. Bug: 771984 Change-Id: I1f49409ec3de20c9c29352e5e23c571a365e515b Reviewed-on: https://chromium-review.googlesource.com/722384Reviewed-by:
-
tzik authored
scoped_refptr.h is allowed in Blink, and ref_counted.h is allowed only on wtf now. This CL updates existing ref_counted.h inclusion to scoped_refptr.h. Bug: 763844 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3837118b1cb4176c427ad9e39e43ade2769aeaf9 Reviewed-on: https://chromium-review.googlesource.com/712274Reviewed-by:
-
mariannet authored
Add more margin to quick viewing text files in order to improve readability. Bug: 742944 Test: manually Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icc25905d01eba4e266b949ddde075d10e1ad93ed Reviewed-on: https://chromium-review.googlesource.com/720656Reviewed-by:
-
mariannet authored
Keep the focus on the files table when long pressing the header. Bug: 752389 Test: manually Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic9833320e728cb64767741b88c43d6c8a22fc733 Reviewed-on: https://chromium-review.googlesource.com/716077Reviewed-by:
-
Leo Zhang authored
Original check will load the whole accepted language code list, then check whether the given code is in the list or not. But in Android client, loading a list of codes will trigger 100+ JNI calls which costs 30~60 ms (based on the local testings on my Nexus 6). This change will call only one JNI to check whether a given language is accepted in Chrome. It matters in Clank, because the JNI is very expensive. It will save 30~60 ms for each check in my local testing. Bug:771835 Change-Id: If2f3838492521373a139a4220c843fc7bc3b1f8b Reviewed-on: https://chromium-review.googlesource.com/708097 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#509303}
-
Victor Costan authored
The crash can only occur when the "Enable Experimental Web Platform Features" flag is turned on. Bug: 774626 Change-Id: I4e8170d2c82db53d8bacd5c8586ef4cce3000be4 Reviewed-on: https://chromium-review.googlesource.com/722038Reviewed-by:
-
junweifu authored
Shape Detection will use WRL to access Windows Runtime components, wrapped GetActivationFactory, CreateIBufferFromData and GetPointerToBufferData function also need to be used in CL[1], so move these common functions to winrt util. [1] https://chromium-review.googlesource.com/c/chromium/src/+/708336 BUG=767021 Change-Id: I054e273dc14fea648d1fed444d189ecd5e4292ca Reviewed-on: https://chromium-review.googlesource.com/715656 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#509301}
-
Henrik Boström authored
trackSwitchingStream: 1. SRD: "stream1 with track1 created." 2. SRD: "track1 is moved to stream2." trackAddedToSecondStream: 1. SRD: "stream1 with track1 created." 2. SRD: "stream2 with track1 created, track1 still belonging to stream1." Bug: 769743 Change-Id: I64f5c0790c17c2c396f38be39580da495844c749 Reviewed-on: https://chromium-review.googlesource.com/711135Reviewed-by:
Taylor Brandstetter <deadbeef@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#509300}
-
Xiaocheng Hu authored
This patch adds ::first-letter handling to the following functions by adding LayoutTextFragment overrides: - LayoutText::CaretMinOffset - LayoutText::CaretMaxOffset - LayoutText::ResolvedTextLength Bug: 771398 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5309e706a5161498b9e909b9d2098a232e328020 Reviewed-on: https://chromium-review.googlesource.com/719410 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#509299}
-
Katie Dektar authored
Don't highlight whitespace-only nodes. Bug: 753022 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iaac62b135512ba95ea6dfaabc9450802e939e621 Reviewed-on: https://chromium-review.googlesource.com/719763 Commit-Queue: Katie Dektar <katydek@google.com> Reviewed-by:
-
