- 20 Dec, 2017 40 commits
-
-
Jérôme Lebel authored
When the user taps on the "Continue as ..." button in the sign-in promo, of the Other Devices tab, the user is signed in at the beginning of the sync confirmation animation. Therefore the TabSwitcherModel receives the sign-in notification and send a notification to the TabSwitcherController to reload before the end of the animation. While reloading the TabSwitcherController removes the current TabSwitcherPanelOverlayView that contains the sign-in promo view and its SigninPromoViewMediator. The issue is that SigninPromoViewMediator is supposed to live until the end of the sign-in to handle correctly the metrics (histograms and user actions). To avoid that, the SigninPromoViewMediator is now owned by the TabSwitcherController. And TabSwitcherModel asks its delegate if a sign-in is in progress. In that case, the sign-in notification is ignored. Therefore the UI is not updated while the sign-in interaction is appearing (see crbug.com/725925) Once the sign-in is finished (cancel or success), the TabSwitcherController is notified by SigninPromoViewMediator and then the TabSwitcherModel can be reloaded. Bug: 795895, 725925 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iefff5975bc251ea39cb06c5d73a4adc135ce317b Reviewed-on: https://chromium-review.googlesource.com/832391 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#525309}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/acd59ef08512..59c19a3877cb $ git log acd59ef08..59c19a387 --date=short --no-merges --format='%ad %ae %s' 2017-12-20 angle-deps-roller Roll skia/third_party/externals/angle2/ ffd27d853..37385e11d (2 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Icc1871c584ccd8372343509c2a5eb14a6fde58e3 Reviewed-on: https://chromium-review.googlesource.com/836409Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#525308}
-
Julien Isorce authored
GLImageAHardwareBuffer: bool Initialize(AHardwareBuffer* buffer, bool preserved) GLImageNativePixmap: bool Initialize(uint32_t texture_id) Not keeping the same signature as GLImageEGL::Initialize to indicate how it is used. And if needed, more initialisers can be added. This prevents the user from doing mistakes when instantiating a subclass of GLImageEGL but calling the parent's initialiser. For consolidation this CL also moves GLImageEGL::Initialize from public to protected. Note that GLImageEGL cannot be instantiated directly because it does not implement a few pure virtual functions it got from its parent, gl::GLImage. Bug: 785201 Test: gl_unittests --gtest_filter=*NativePixmap* Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ida5834bbf964893680f449f1f5da7371e46075bc Reviewed-on: https://chromium-review.googlesource.com/817563 Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Reviewed-by:David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#525307}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/29ec7059..6a279326 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic255093d75ff23c739d41ac059435aaf5c41325a Reviewed-on: https://chromium-review.googlesource.com/836268Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#525306}
-
Shanmuga Pandi M authored
Bug: 771800 Change-Id: Id28d95a3afac31ee33711f99857f7af0b9d5e1d7 Reviewed-on: https://chromium-review.googlesource.com/836328Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#525305}
-
Eric Seckler authored
All known clients use certificate error overrides to ignore all certificates, so we're planning to replace it with a simpler "ignore all cert errors" mode instead. This patch deprecates the old override command in favor of a new setIgnoreCertificateErrors command. It also exposes the Security domain on the browser target to facilitate applying this override globally for the whole browser. Bug: 721739, 792468 Change-Id: I89bd929247877f43abac7c31a420d0756a8fdf89 Reviewed-on: https://chromium-review.googlesource.com/817443 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#525304}
-
Colin Blundell authored
This CL adds an interface on IdentityManager to create a PrimaryAccountAccessTokenFetcher instance. In this way, clients of IdentityManager can create PrimaryAccountAccessTokenFetchers without needing to know about the core signin classes on which it depends. This interface will facilitate moving clients of PrimaryAccountAccessTokenFetcher to depend on IdentityManager rather than depending on these core signin classes directly. Bug: 654990 Change-Id: I15217dabf60a8dada17ce54f76406c011d011f5c Reviewed-on: https://chromium-review.googlesource.com/832647Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#525303}
-
Hidehiko Abe authored
To catch up c++17 definition, this CL updates the signature and implementation of comparator operators. BUG=784732 TEST=Ran base_unittests --gtest_filter=OptionalTest. Change-Id: I4a21f8af1ec5ca0af9946250f3855f198077d52c Reviewed-on: https://chromium-review.googlesource.com/832547 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#525302}
-
Balazs Engedy authored
Align the behavior of navigator.credentials.store() with the spec [1] when deciding if the |iconURL| of the passed in PasswordCredential or FederatedCredential is an `a priori authenticated URL`. [1]: https://www.w3.org/TR/mixed-content/#a-priori-authenticated-url Bug: 740081 Change-Id: I2d9ae6c61cc0f3cf3687dfe99aec09b08b078efd Reviewed-on: https://chromium-review.googlesource.com/833913Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#525301}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/d4529f304be7..37385e11d383 $ git log d4529f304..37385e11d --date=short --no-merges --format='%ad %ae %s' 2017-12-19 oetuaho Emulate tanh on HLSL Created with: roll-dep src/third_party/angleBUG=795269 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Iaf877a7cb9c63d65eda8e8d33149e90a0fb17774 Reviewed-on: https://chromium-review.googlesource.com/836408Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#525300}
-
Hannes Payer authored
Bug: Change-Id: Ia4a87a4fa6e98902bca8b3328399dcd4de79af3a Reviewed-on: https://chromium-review.googlesource.com/833938 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#525299}
-
Alexander Shalamov authored
The device_features target has definitions for base::Feature constants, and as the target type is source_set, for component builds, constants are being defined in multiple binaries. As a result, when feature flag is checked from browser and services code, FeatureList::IsFeatureEnabled will assert, as the constants have different addresses. This CL changes device_features target type from source_set to component, and exports declared constants. Bug: Change-Id: Ife09ba3141da360c08e4f26c24735c9fc552c7bb Reviewed-on: https://chromium-review.googlesource.com/833920Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com> Cr-Commit-Position: refs/heads/master@{#525298}
-
Matthew Cary authored
The REPONSE_START and RESPONSE_END page load metrics reported from custom tabs should be named SEND_START and SEND_END to be consistent with the navigation timing API. Bug: Change-Id: Id6d5de07d1c3748ed2921fc94bfa7ac8dcf72252 Reviewed-on: https://chromium-review.googlesource.com/832481Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#525297}
-
Sylvain Defresne authored
The flag #contextual-search is flipping a command-line switch that is never read (the code is kept to run the unit tests but not build in production). Remove the flag and move the switches to the target //ios/chrome/browser/ui/contextual_search:switches. Bug: none Change-Id: I121acb25fb98b599f109abd827a763253fd1e1c1 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/833937Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#525296}
-
Tom Anderson authored
R=derat@chromium.org Change-Id: Idbb641f8c5b522db79b6852a0c4c456176c4b672 Reviewed-on: https://chromium-review.googlesource.com/835418 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#525295}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/ffd27d85371b..d4529f304be7 $ git log ffd27d853..d4529f304 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 oetuaho Define symbol classes in a separate file Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I75248cce855dc824dacbcb0716e91d3bb7391d8c Reviewed-on: https://chromium-review.googlesource.com/836148Reviewed-by:
-
Mikhail Pozdnyakov authored
This patch implements the upcoming specification changes: https://github.com/w3c/sensors/pull/328 The sensors API can be used inside nested browsing contexts in a secure way. Bug: Change-Id: Ia6353d5a0d9a7c8817666a04aa859ed2c13b0520 Reviewed-on: https://chromium-review.googlesource.com/789040 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Bhagirathi Satpathy authored
Modified document.open testcase to more accurate for url as USVString type. Merging this test in external/wpt where all URL-related test were added for USVString type. Bug: Change-Id: Ie00b677984d973b547b43f6efd47b490ad697fcd Reviewed-on: https://chromium-review.googlesource.com/836287Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Ryo Hashimoto authored
Speculative fix for crbug.com/794878 IIUC this is the only SessionManagerObserver implementation which doesn't call RemoveObserver() when being destructed. BUG=794878 Change-Id: I876f3f7b24e39097208578a11515bd565c469c64 Reviewed-on: https://chromium-review.googlesource.com/826911 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#525291}
-
Hannes Payer authored
Bug: Change-Id: I4f492623358849f6a296bfe7d6c85ffb52b85c73 Reviewed-on: https://chromium-review.googlesource.com/833936 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#525290}
-
Michael Lippautz authored
Move away from WTF DataLogF to VLOG Usage: chrome --enable-logging=stderr --vmodule=*/heap/*=1 Change-Id: I379bb4fffa42986ce3efe593bd63547d12afef6e Reviewed-on: https://chromium-review.googlesource.com/834509Reviewed-by:
-
Devlin Cronin authored
Currently, Extension::version() returns a pointer to a constant base::Version. However, all extensions are required to have a valid version (if it does not, the Init() call fails). It's perfectly sufficient to return a const base::Version& here and avoid callers from having to dereference the return value (which is mostly just cognitive load). TBRing for mechanical changes: TBR=jdufault@chromium.org (c/b/chromeos/login) TBR=apacible@chromium.org (c/b/media/router) TBR=atwilson@chromium.org (c/b/policy) TBR=proberge@chromium.org (c/b/safe_browsing/incident_reporting) TBR=bauerb@chromium.org (c/b/supervised_user) Bug: None Change-Id: I233c5822bf32d10a9a1ad0c009b6b566a80a5fd8 Reviewed-on: https://chromium-review.googlesource.com/828580 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#525288}
-
Jochen Eisinger authored
It looks like HTML parsing on win dbg is so slow that the final task that will end the test might get delayed for more than 30s resulting in flaky timeouts. Test this theory by opening the new tabs in new processes, so the tasks has a higher likelihood of being executed on time. R=mkwst@chromium.org BUG=753691 Change-Id: Ia745e531a9a3f01851af199344b6863ca41758fa Reviewed-on: https://chromium-review.googlesource.com/833939 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
This reverts commit f07e903f. Reason for revert: This CL makes net/ depend on Blink, and it makes build time of net/ very long. Original change's description: > net: Make net/ work with v8_context_snapshot.bin > > We are planning to replace snapshot_blob.bin with v8_context_snapshot.bin. > This CL makes net/ code to load v8_context_snapshot.bin to work with it. > > Bug: 789964, 764576 > Change-Id: Ifcbe58d632dd76fd4bcc02182044d1e111f4267a > Reviewed-on: https://chromium-review.googlesource.com/810347 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522648} TBR=peria@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 789964, 764576, 794234 Change-Id: I1e92c339914a6e2b1f33d280e4b41207213688b9 Reviewed-on: https://chromium-review.googlesource.com/836247Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#525286}
-
Noel Gordon authored
MSVC noted the unsigned |n| = size_t |blocks| could be a possible loss in precision. No loss in precision occurs since (n > blocks) at this point: |blocks| fits in an unsigned type. To silence compiler warnings, first update BUILD.gn for the adler SIMD code to use chromium compiler:chromium_code rule (more error checking), rather than the permissive "compiler:no_chromium_code" rule. Then cast |blocks| to unsigned on assigment to |n| (this is safe to do as mentioned above). No change in behavior, no new tests. Tbr: cblume@chromium.org Bug: 762564 Change-Id: Ia97120bcca206287fd42b97674f8a6215283e4a5 Reviewed-on: https://chromium-review.googlesource.com/835927 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#525285}
-
Yuki Shiino authored
This might be a similar issue to https://crrev.com/c/824322 . An idle task (callback function) is removed from the target of wrapper-tracing during its use. This might be a cause of crashes at ScriptedIdleTaskController. This patch fixes it to hold the object until the end of its use. Bug: 792604 Change-Id: I2ec7f7a78f13334778575c96708f45a4cf8da3b5 Reviewed-on: https://chromium-review.googlesource.com/824008 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Geolocation::HandleError discards TraceWrapperMembers (notifiers) in the middle of their use, so wrapper-tracing stops working. If V8 GC runs while the callbacks are running, as TraceWrapperMembers are already cleared, the underlying V8 objects will be gone. This patch fixes the issue making Geolocation hold TraceWrapperMembers during the invocation of the callbacks. Bug: 792604 Change-Id: I6eedc5bc3d82806b1ab0ee2cf2fc3d7a8a018e14 Reviewed-on: https://chromium-review.googlesource.com/824322Reviewed-by:
-
Kouhei Ueno authored
Bug: None Change-Id: I4e94511f39c2d55806a2827b19a6801ee29dce19 Reviewed-on: https://chromium-review.googlesource.com/835931Reviewed-by:
-
Kouhei Ueno authored
Before this CL, "base URL" was tracked only for ModuleScript (which map to spec concept "module script"). In the latest spec, it says that the "base URL" is now "script"-level concept (concept-script-base-url) which both ClassicScript and ModuleScript should track. This CL aligns Blink implementation to the spec. No behavioral change is expected from this CL. Bug: 796034 Change-Id: I86b8efe1f3980e3b6ab4743a35eeefaef639f0fd Reviewed-on: https://chromium-review.googlesource.com/833434 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#525281}
-
Tsuyoshi Horo authored
To know whether the test has a bug or the test is just slow. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=service-worker-v8-cache.js Bug: 789111 Change-Id: I7aa771ca9712882c261e46d6af48241dac465a0c Reviewed-on: https://chromium-review.googlesource.com/835967Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#525280}
-
François Degros authored
This removes a minor code duplication. AddRef is now only called in one place, ie the constructor taking a raw pointer. Note that Release is already called in one place only, ie the destructor. Change-Id: I4fcd72ec0bcf4eb9269f593e171304223ef1dc0a Reviewed-on: https://chromium-review.googlesource.com/835288Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#525279}
-
Chris Watkins authored
See the bugs for details. This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md Where the tool replaces a member initializer list it leaves behind commas (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 R=haraken@chromium.org Change-Id: I522434dc0d25d1e6c4b04fbc6e17a95f5de1febc Reviewed-on: https://chromium-review.googlesource.com/835747 Commit-Queue: Chris Watkins <watk@chromium.org> Reviewed-by:
-
Blake O'Hare authored
This also makes the lock screen UIs floating-keyboard-friendly. It seems that the obscuring bounds and workspace displacing bounds don't quite fit the behavior pattern that is needed here, but at the same time, I would like to remove all instances of "keyboard bounds getter + some caller-specific conditional logic" throughout the codebase. So I had to add another getter called GetKeyboardLockScreenOffsetBounds(). Specifically, it seems that WebLoginUi is temporarily overriding the overscroll enable state independent of whether the keyboard is locked. This makes the current bounds getters not 100% applicable. I'd like to revisit this and clean it up a bit, but for now, I'd like to get the one-off logic out of the layout manager and into the KeyboardController so that I can add the floating keyboard condition as well. Bug: 787713 Change-Id: I556941b0fa1e060349c3030a0e08eefb7693314f Reviewed-on: https://chromium-review.googlesource.com/828421 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#525277}
-
Thomas Anderson authored
This reverts commit 60fffac6. Reason for revert: Causing failures in the linux dbg testers (32 and 64) https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20(dbg)(1)(32)/46826 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20(dbg)(1)/69081 Original change's description: > Add GeoLanguage in fieldtrial testing > > > > Bug: 76915 > Change-Id: Ia0f05256c85eb67daae13c20b96a067a06cfb2ba > Reviewed-on: https://chromium-review.googlesource.com/816574 > Commit-Queue: Renjie Liu <renjieliu@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525216} TBR=holte@chromium.org,renjieliu@chromium.org,amoylan@chromium.org Change-Id: Ie6e9eef0f4b7266eda44d14b3a70ef580103d430 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 76915 Reviewed-on: https://chromium-review.googlesource.com/835808Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#525276}
-
Tom Anderson authored
R=sky@chromium.org Change-Id: I0aacea25b1a962450f496e88b3506a4895a09494 Reviewed-on: https://chromium-review.googlesource.com/822989Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#525275}
-
Scott Graham authored
8742051c6099 mac: Drop apple_cctools and getsectiondata()/getsegmentdata() wrappers 3650d565709f gn: Build gtest and gmock tests 6e0f15b8f5a7 gn: Add “system” as a zlib source, used for standalone non- Win/Fuchsia 1764594bff5f gn, mac: Work without a sysroot b51adda8d29c Build certain gtest/gmock tests with -Wno-unused-private- field 457cc6a34fde gn: Refactor build files to avoid build/secondary 1bc07b76ed2c gn: Use mini_chromium_is_posix in preference to global is_posix a0bd3fee55ea fuchsia: Support referencing the Fuchsia tree's third_party/zlib 99b00306162d gn, linux: Build for Linux with GN 9b2ba587f618 linux: Add ExceptionHandlerServer and ExceptionHandlerClient 3a41c51668cf gn, linux: Update build after 9b2ba587f618 ab153f7e1bf6 gn: Avoid depending on BUILDCONFIG.gn globals 41c7ace7e85a linux: Add missing build_config.h include e7ebdf019ee0 gn: Add missing testonly for chromium and fuchsia styles cd7428971f0d gn: Fix symbol_level use in chromium style c86779fd96dd gn: Remove duplicated listing of crashpad_handler_test.cc ab0b9438b994 gn: Fix reference to test_support in chromium style e9d2ca60f732 gn: Mark base_test_support as testonly=true Updates .gn for new value of default_args. Bug: crashpad:30, crashpad:79, crashpad:196 Change-Id: Ibcad118a72f8c96f5f1b764ce8643314f798105a Reviewed-on: https://chromium-review.googlesource.com/835435 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#525274}
-
Hiroki Nakagawa authored
This reverts commit 715a1c5f. Reason for revert: This causes compile failures on some bots. Original change's description: > Worker: Implement WorkerGlobalScope::ImportModuleScript() > > This CL implements WorkerGlobalScope::ImportModuleScript() that imports module > scripts using WorkerModulatorImpl, and wires up DedicatedWorkerMessagingProxy > via WorkerThread. > > Note that module workers are still not available because WorkerOptions is not > exposed on the ctor of Worker and WorkerModulatorImpl is not fully implemented > yet. > > Design doc: https://docs.google.com/a/chromium.org/document/d/1IMGWAK7Wq37mLehwkbysNRBBnhQBo3z2MbYyMkViEnY/edit?usp=sharing > > Bug: 680046 > Change-Id: I0c616b7a1b79abb02c1085be356293510dd4c04b > Reviewed-on: https://chromium-review.googlesource.com/807675 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525270} TBR=kinuko@chromium.org,kouhei@chromium.org,nhiroki@chromium.org Change-Id: I253df9d13bbb8bc63cae7bb018fd10c4ee311d25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 680046 Reviewed-on: https://chromium-review.googlesource.com/836187Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ad7b878c..29ec7059 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5a40570899169e7b3eb32cfc7891e7ea9ddbdca6 Reviewed-on: https://chromium-review.googlesource.com/835827Reviewed-by:
-
Sandra Sun authored
This patch does the following: 1. Moves the data structure of SnapPoints from blink to cc and shares it back with blink. 2. Use the coordinate of ScrollPosition and the type of FloatPoint to do calculations in SnapCoordinator instead of ScrollOffset, as gfx::ScrollOffset uses ScrollPosition. 3. Update the logic in SnapCoordinator to work with vertical-rl writing-mode. 4. Use LocalToAncestorQuad() for the snap_area to ensure transforms are properly dealt with. Bug: 795404 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I538327e169ebee4d3e03ec2ddd0d5b282e36f5de Reviewed-on: https://chromium-review.googlesource.com/825994Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#525271}
-
Hiroki Nakagawa authored
This CL implements WorkerGlobalScope::ImportModuleScript() that imports module scripts using WorkerModulatorImpl, and wires up DedicatedWorkerMessagingProxy via WorkerThread. Note that module workers are still not available because WorkerOptions is not exposed on the ctor of Worker and WorkerModulatorImpl is not fully implemented yet. Design doc: https://docs.google.com/a/chromium.org/document/d/1IMGWAK7Wq37mLehwkbysNRBBnhQBo3z2MbYyMkViEnY/edit?usp=sharing Bug: 680046 Change-Id: I0c616b7a1b79abb02c1085be356293510dd4c04b Reviewed-on: https://chromium-review.googlesource.com/807675Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#525270}
-
