- 01 Nov, 2018 40 commits
-
-
Sam McNally authored
When DiskMountManager refreshes its list of mounts, it notifies its observers of mount events for each mount. If already mounted, DriveFsHost::MountState reports a successful mount again. DriveIntegrationService attempts to create the DriveFS mount point again, fails and records a spurious mount failure. Bug: 900817 Change-Id: Iff28a26e266115c0754f9fc559fe404a865c77e2 Reviewed-on: https://chromium-review.googlesource.com/c/1312433 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#604521}
-
Ted Choc authored
The padding depends on the text size/paint metrics of the textview itself, so it makes sense to calculate it based on the state of the view. This also fixes RTL and a bug introduced in a previous cleanup that was applying tail suggest padding to all suggestions when showing a single tail suggest item. BUG=898522 Change-Id: I9b4a7be75b153948e6b53b8fcf3fcc804de1273a Reviewed-on: https://chromium-review.googlesource.com/c/1310715 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#604520}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/48d4db6e70c4..34d730fce981 Created with: gclient setdep -r src-internal@34d730fce981 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic357e5ffcad0ae2cb4eae875849abc07b3c4ebba Reviewed-on: https://chromium-review.googlesource.com/c/1312262Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604519}
-
Jia authored
This cl contains the following changes - Check whether initial personal curve satisfies min/max slope constraints. - Add two params high_log_lux_threshold and min_grad_high_lux. - Simplified trainer interface by removing status. - Simplified modeller impl so that personal curve is kept by trainer only. Bug: 881215 Change-Id: Iad8a16df3c14440ee9086124cfc8e3e2d890e5ca Reviewed-on: https://chromium-review.googlesource.com/c/1303317 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604518}
-
James Cook authored
For lock screen app windows the window manager needs to specify the initial show state of the window. Ensure the client (chrome) does not overwrite the aura window show-state property in ash if the client window has ui::SHOW_STATE_DEFAULT. Fixes LockScreenNoteTakingTest.Launch pass under SingleProcessMash Bug: 899055 Test: added to views_mus_unittests Change-Id: Ib7b6f9a060835ebf3e017737e4b98387a31831c8 Reviewed-on: https://chromium-review.googlesource.com/c/1303273Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#604517}
-
Sam McNally authored
The first DriveFS mount can be slow, especially on a slow or unreliable connection. Add a fake Google Drive entry when Drive is enabled, but not yet mounted with a progress bar but no contents to indicate that some work is still in progress. Bug: 889732 Change-Id: I10335fbf3ce813985fe4eadb7da88d1387131b3f Reviewed-on: https://chromium-review.googlesource.com/c/1309386 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604516}
-
David Grogan authored
Bug: 895682 Change-Id: I8bf9b2cfa31031ee603e365b2023d6f9000e521e Reviewed-on: https://chromium-review.googlesource.com/c/1311834Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604515}
-
Ted Choc authored
This prevents the need to pull values from the view to calculate the contents of the data. This will allow a better abstraction between model and view. BUG=898522 Change-Id: I1030e03d1e12c416c78c4d28cf469a0ff7ad842f Reviewed-on: https://chromium-review.googlesource.com/c/1306495 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0db62fcf9c7e..a870c9698af1 git log 0db62fcf9c7e..a870c9698af1 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 yyanagisawa@chromium.org recipe_modules/depot_tools: export autoninja_path Created with: gclient setdep -r src/third_party/depot_tools@a870c9698af1 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/77176746 TBR=agable@chromium.org Change-Id: Iadaceec0525d982feb925924f74fde530a8b5f2d Reviewed-on: https://chromium-review.googlesource.com/c/1312261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604513}
-
Koji Ishii authored
This patch changes NGPaintFragment::FragmentRange to use the generic range/iterator in NGPaintFragment::List/iterator. Also changed the naming to match to std iterator. No behavior changes. Bug: 714962 Change-Id: I0df61e989949dff1e404928b23e124227cafec3c Reviewed-on: https://chromium-review.googlesource.com/c/1309953 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604512}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/838643550f0c..be142178aaf6 git log 838643550f0c..be142178aaf6 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 ouj@fb.com Use the factory instead of using the builtin code path in `VideoCodecInitializer`. Created with: gclient setdep -r src/third_party/webrtc@be142178aaf6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I389723f5bb89203ee086ac0caa3ff73fcce32b2e Reviewed-on: https://chromium-review.googlesource.com/c/1312256Reviewed-by:
-
Ken Rockot authored
This releases HANDLE ownership *before* sending any handle in a message to a remote process, rather than after. Avoids an extremely subtle race between DuplicateHandle+DUPLICATE_CLOSE_SOURCE in the receiving process racing with ScopedHandle release in the sending process. The trade-off is the introduction of potential leaks which turn out to not really matter in any practical scenarios. Bug: 900655 Change-Id: Ieec82bb062bc66cdb3c732c920a220ea2aa2f8d0 Reviewed-on: https://chromium-review.googlesource.com/c/1310505 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#604510}
-
Ken Rockot authored
Usage of the old bindings required loading about 185 kB of JS, including 155 kB from the common bindings library (mojo_bindings.js) as well as another ~30 kB from the JS generated by omnibox.mojom. With the new bindings, the common library is only 21 kB compiled and the generated JS for omnibox.mojom 16 kB (uncompiled, with lots of Closure annotations). Net mojom-supporting code size reduction of 80%, with room to improve once we compile generated code too. Also fixes a long-standing bug in the omnibox JS where the selected page classification value was not being used. Bug: 894376 Change-Id: Ie6c5450b7df3b7e7ac29cf68d9a1532c9365046c Reviewed-on: https://chromium-review.googlesource.com/c/1289701 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#604509}
-
Esmael El-Moslimany authored
Bug: 870460 Change-Id: I0fa1762ca2f7054ab86116ce406b9acf9b8b37a7 Reviewed-on: https://chromium-review.googlesource.com/c/1311803Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#604508}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/378f5ac017f8..48d4db6e70c4 Created with: gclient setdep -r src-internal@48d4db6e70c4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I88175d6d38fe28d05ce45301b1da8b4251fc041e Reviewed-on: https://chromium-review.googlesource.com/c/1312257Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f3b8abe13293..f9b30833b099 git log f3b8abe13293..f9b30833b099 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 primiano@google.com minor fix to trace_to_text (json escape) and UI record page Created with: gclient setdep -r src/third_party/perfetto@f9b30833b099 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I2947d12223e6ba9ad931b15fac8dc7bcfdf4460a Reviewed-on: https://chromium-review.googlesource.com/c/1312258Reviewed-by:
-
Sunny Sachanandani authored
This reverts commit 30e36bcc. Reason for revert: Display compositor doesn't cause mid-frame flushes any more, so workaround isn't needed. Original change's description: > Bump WebGL stream to high-priority on Adreno 3xx. > > WebGL has performance issues on Adreno 3xx when we switch contexts > from/to the WebGL context mid-frame. > > To avoid this issue, we can bump scheduler priority for the WebGL stream > to high, avoiding most mid-frame interruptions. In local testing this > (in combination with a backpressure fix) addresses known issues. > > Bug: 879649, 835353 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I896456b29f3b80e3e443720b9ce444e6825c1c03 > Reviewed-on: https://chromium-review.googlesource.com/1200242 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588287} TBR=nasko@chromium.org,sunnyps@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 879649, 835353 Change-Id: I0e0c75f5162789b457c2a4cdfa29dc8557972208 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1311658 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#604505}
-
Hiroki Nakagawa authored
This CL implements off-the-main-thread top-level worker classic script loading for dedicated workers behind the flag. This flag is enabled only when virtual tests run or the command line flag is explicitly specified. According to the HTML spec[1], a top-level worker classic script should be loaded with an outside fetch client settings object. However, current implemention doesn't support the outside fetch client settings object for off-the-main-thread script loading and then some tests are failing. This should be fixed once ResourceFetcher/FetchContext separation is implemented (see https://crbug.com/880027). Subsequent CLs will run more tests (e.g., wpt/fetch, wpt/service-workers, and wpt/content-security-policy) with the flag in order to reveal which features are affected by lack of the implementation. [1] https://html.spec.whatwg.org/multipage/workers.html#worker-processing-model Bug: 835717 Change-Id: I73a2db48b9df44b87df395ce86c8beb8103def8f Reviewed-on: https://chromium-review.googlesource.com/c/1293432 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#604504}
-
Maks Orlovich authored
(Same as in MojoAsyncResourceHandler) This requires using somewhat lower-level API that actually reports it. Chances are, we will still OOM, but that would at least hit the proper paths for that, and hopefully the leak detection infra would help chase those down. Also removes debug aliases added in https://chromium-review.googlesource.com/c/chromium/src/+/1298296 since those revealed that the resource problem isn't here. Bug: 893971 Change-Id: I462546fabf47cbb927e8d5918185c125671d98dd Reviewed-on: https://chromium-review.googlesource.com/c/1309119Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#604503}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ib4878c92255a84bac7f1fceda59bf73f0bd93694 Reviewed-on: https://chromium-review.googlesource.com/c/1312154Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#604502}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d7a7586b0d2f..628f0a57d102 git log d7a7586b0d2f..628f0a57d102 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@628f0a57d102 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I921aaaf48309d698337c5085f6b13061a773c4a7 Reviewed-on: https://chromium-review.googlesource.com/c/1312259Reviewed-by:
-
Zhuoyu Qian authored
This patch moves CreateVisiblePosition() out of VisiblePositionForContentsPoint() to the callers. Rename VisiblePositionForContentsPoint() to PositionForContentsPointRespectingEditingBoundary(). Bug: 657237 Change-Id: I00c60a783c35d5e5a59b9163eb3e42b7e9fa2b38 Reviewed-on: https://chromium-review.googlesource.com/c/1307315 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604500}
-
Fergus Dall authored
Bug: 896540 Change-Id: I9bcd94d33825804d64a1cd59f88eaea5ae4996e8 Reviewed-on: https://chromium-review.googlesource.com/c/1301093Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#604499}
-
Mao Huang authored
Currently the safe search component always uses the API key gotten from google_apis. This limits the usage of the safe search component for projects using content shell but not Chrome directly. This patch allows the URL checker to take a custom API key so projects other than Chrome could also benefits from the safe search component. Bug: b/110951484 Change-Id: Ic2aa3fea758b4dc6d43d54a582c460df1b892b91 Reviewed-on: https://chromium-review.googlesource.com/c/1309557Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mao Huang <littlecvr@chromium.org> Cr-Commit-Position: refs/heads/master@{#604498}
-
sangwoo.ko authored
Replace old API with new API. This CL is a refactor and has no intended behavior change. To keep TabStrip UI consistent with model, make tabstrip UI the first observer. Bug: 842194 Change-Id: Icba9481d41ba32a7910593198cebd313ad531e5d Reviewed-on: https://chromium-review.googlesource.com/c/1249461 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9d88af8f4ebe..f2f7c2a92321 git log 9d88af8f4ebe..f2f7c2a92321 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 tsepez@chromium.org Add |k| to CPDF_ContentMarkItem::ParamType enum constants Created with: gclient setdep -r src/third_party/pdfium@f2f7c2a92321 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I831d43b333fcb550ec75f65159bcd91322d3f5bc Reviewed-on: https://chromium-review.googlesource.com/c/1312255Reviewed-by:
-
Dmitry Gozman authored
This simple struct is being used to initialize DevTools in workers. Bug: 882467 Change-Id: I4d7fa582913b3be9a8466de24d727289a34f6ce0 Reviewed-on: https://chromium-review.googlesource.com/c/1308073 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#604495}
-
yoshiki iguchi authored
This CL adds ash window type (WindowStateType::PIP) to Chrome PIP window only in Chrome OS. This window type is used for distinguish PIP windows and manages them in Chrome OS ash shell. Bug: b/112060145 Change-Id: I9fb51e50577b8ebe9d690b6c2d83e300951d9846 Reviewed-on: https://chromium-review.googlesource.com/c/1242726 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#604494}
-
Nektarios Paisios authored
This is a reland of cb9c3091 Two things needed to be changed to fix the compilation failures: 1. Add build file entries for ui/accessibility/platform/ax_platform_node_base.* and ax_-platform_node_delegate_base.* so that these files would be compiled on platforms that don't have native accessibility support, such as Chrome OS. 2. Implement all the unimplemented methods in ui/accessibility/platform/ax_platform_node_base and ax_platform_node_delegate_base. R=dmazzoni@chromium.org,aleventhal@chromium.org TBR=afakhry@chromium.org,ellyjones@chromium.org,sky@chromium.org Bug: 811277 Original change's description: Adds code in ViewAccessibility to manage the focus of AXVirtualView descendants Also renamed some methods to make interface more consistent. In preparation for more changes in AXVirtualView. Change-Id: Ic83e231c0fd3bdf45e68f4e6279e705ce22b2aa7 Reviewed-on: https://chromium-review.googlesource.com/c/1304815 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#604493}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/861640f6c89b..0db62fcf9c7e git log 861640f6c89b..0db62fcf9c7e --date=short --no-merges --format='%ad %ae %s' 2018-11-01 yyanagisawa@chromium.org autoninja: don't set -l. Created with: gclient setdep -r src/third_party/depot_tools@0db62fcf9c7e The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/117810340 TBR=agable@chromium.org Change-Id: If3835943744d8ceaa356d95465509e8d0e1af4df Reviewed-on: https://chromium-review.googlesource.com/c/1312254Reviewed-by:
-
Xida Chen authored
This CL parameterize some tests using this flag. It does 2 things: 1. Move the kCompositorTouchAction flag from content/ to ui/events/blink. This is because InputHandlerProxy will need to have access to this flag, and that content/ depends on ui/events/blink. 2. Parameterize necessary tests based on this flag. Tests include: InputRouterImplTest, TouchActionFilterTest, InputHandlerProxyTest, TouchActionBrowserTest. In order to pameterize the InputRouterImplTest, we have to extract a InputRouterImplTestBase. The reason is that InputRouterImplTest has a subclass "TouchpadPinchInputRouterImplTest", which is already a parameterized test depending on another flag. Bug: 900202 Change-Id: I07e30739ee86aaf8b1840d6e0dccfc504a16b075 Reviewed-on: https://chromium-review.googlesource.com/c/1307833 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Maks Orlovich authored
The former will have some problems with some proxy setups once the Network Service is on, so this introduces a replacement. This CL doesn't hook it up to anything, just builds & tests it. Next steps would require an equivalent to FakeSSLClientSocket, and then actually hooking those up and wiring the different injected config from Chrome. To ease the review of this somewhat, this CL was split in two, with https://chromium-review.googlesource.com/c/chromium/src/+/1237214 just copying over ChomeAsyncSocket and its tests to new files, to produce something of a meaningful diff. (Thanks to lassey@ for the idea) Bug: 875032 Change-Id: Ic5d4e4276c993e0e70f059d485b9d34aeab41e6d Reviewed-on: https://chromium-review.googlesource.com/c/1232034 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#604490}
-
Yuichiro Hanada authored
InputConnectionImpl waits for text input state updates by observer methods. However, some IME operations (like deleting '0' character) don't update the state. Also this CL stops ArcInputMethodManagerService observing OnCompositionBoundsChanged() because it's often called before text input state is updated. Bug: 900707 Test: Ran on DUT. Change-Id: Ib4c79ae19f0175d46e9ecf3cf0cac909f02fac3e Reviewed-on: https://chromium-review.googlesource.com/c/1311313Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#604489}
-
James Hawkins authored
R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I2c85ce8fcd794998583c7b5bb63a51b3e90ce450 Reviewed-on: https://chromium-review.googlesource.com/c/1312295Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#604488}
-
David Staessens authored
The TextureRef class will also be used by video encode tests, so it doesn't make sense to keep it in a decode-specific helper file. No code was added or changed, this CL is only moving the class to a separate file. TEST=ran VDA unittests on eve BUG=900433 Change-Id: Id104701554ea0bd1e12c10221346e946ff1b9c50 Reviewed-on: https://chromium-review.googlesource.com/c/1309381 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604487}
-
Oystein Eftevaag authored
This caused trace events for these threads to go missing as Perfetto was not able to recover them from the shared memory chunks. Also: * Removed an unused variable from TraceEventDataSink, * Read the same member out of a TraceEvent union as the one we write to (thread_id vs process_id). R=primiano@chromium.org Bug: 900669 Change-Id: I80d4e39b154b138a540770e227f1006fec0a91b2 Reviewed-on: https://chromium-review.googlesource.com/c/1311125Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#604486}
-
Joel Hockey authored
Bug: 860355 Change-Id: I73b7eb298cf462c5e981f0cfb3a0132499b0083c Reviewed-on: https://chromium-review.googlesource.com/c/1312134Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#604485}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/46155299edb9..9a227bed7a0f $ git log 46155299e..9a227bed7 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 junyer Make Prefilter::Info::Walker::PostVisit() handle kRegexpAnyByte too. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Bug: 900671 Change-Id: Iad2dd959bdda48eeef6c5a4f6d7aa028c9c79538 Reviewed-on: https://chromium-review.googlesource.com/c/1311494Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604484}
-
Christian Biesinger authored
When a flex item has a definite specified height (e.g. height: 100px), then percentages in children of the flex item should resolve even if the flexbox does not have an explicit height, ie. does not match the condition in https://drafts.csswg.org/css-flexbox/#definite-sizes Bug: 885185 Change-Id: Iba226f30e1e02e3a11273fa45fcdf1cef897120c Reviewed-on: https://chromium-review.googlesource.com/c/1311534 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#604483}
-
Livvie Lin authored
Metrics show that the Superfish interstitial shows up effectively 0% of the time, and we rarely receive Superfish certificate reports. This cl deletes the code for the Superfish interstitial. Bug: 899987 Change-Id: Ice48aad16fd06d74d1150c306fb5caf62c119022 Reviewed-on: https://chromium-review.googlesource.com/c/1306773 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#604482}
-
