GitLab

As a result, Pipeline now handles prerolling and underflow/rebuffering
by listening for BUFFERING_HAVE_NOTHING/ENOUGH callbacks. Preroll() is
renamed StartPlayingFrom() and no longer accepts a completion callback.
In this new model, AudioRenderers immediately enter and remain in
the "playing" state and fire buffering state callbacks to let Pipeline
know when to start/stop the clock.

BUG=144683

Review URL: https://codereview.chromium.org/284763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272465 0039d316-1c4b-4281-b951-d872f2087c98

Forward-declare AndroidHistoryProviderService in history_service.h
instead of including android_history_provider_service.h since the
type is only used for a friendship declaration.

BUG=371820

Review URL: https://codereview.chromium.org/285763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272464 0039d316-1c4b-4281-b951-d872f2087c98

Compilation on Mac Builder (dbg)
FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/mojo/spy/mojo_spy.websocket_server.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=206824 -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -DMOJO_USE_SYSTEM_IMPL -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -O0 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene -Wno-c++11-narrowing -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-deprecated-register -Wno-selector-type-mismatch -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /Volumes/data/b/build/slave/Mac_Builder__dbg_/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -fno-strict-aliasing -fstack-protector-all  -c ../../mojo/spy/websocket_server.cc -o obj/mojo/spy/mojo_spy.websocket_server.o
../../mojo/spy/websocket_server.cc:30:16:error: no member named 'SetClient' in 'mojo::spy_api::SpyServer'
  spy_server_->SetClient(this);
  ~~~~~~~~~~~  ^

> Adding more guts to the mojo spy.
> 
> This CL fleshes out the basic architecture of the spy. Introducing SpyServerImpl and enough code to operate the "start" and "stop" commands of the front-end.
> 
> Still a quite a few loose ends, specially on teardown.
> 
> I updated the design doc to reflect this CL:
> https://docs.google.com/a/chromium.org/document/d/11FKYXf9mSohlsgl4JmGlyWE1ScX3DKdssdjub63tkwA/edit?usp=sharing
> 
> 
> BUG=360188
> TEST=manual via test/spy_repl_test.html
> 
> Review URL: https://codereview.chromium.org/284743002

TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/296453021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272463 0039d316-1c4b-4281-b951-d872f2087c98

Also changes ProvideStabilityMetrics() to take a SystemProfileProto* instead
of the stability section, since the plugin provider needs to inspect things
in the system profile when writing its stability data.

Also, cleans up some header includes.

BUG=374220
R=isherman@chromium.org, thestig@chromium.org
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/299783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272462 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/299833009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272461 0039d316-1c4b-4281-b951-d872f2087c98

msg_handled_ should only be set if ref is this is still valid.

BUG=374320
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/296993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272460 0039d316-1c4b-4281-b951-d872f2087c98

R=brianderson@chromium.org
BUG=376463
TEST=SchedulerTest.TestTriggerDeadlineEarlyForLoseOutputSurface

Review URL: https://codereview.chromium.org/294473014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272459 0039d316-1c4b-4281-b951-d872f2087c98

This CL fleshes out the basic architecture of the spy. Introducing SpyServerImpl and enough code to operate the "start" and "stop" commands of the front-end.

Still a quite a few loose ends, specially on teardown.

I updated the design doc to reflect this CL:
https://docs.google.com/a/chromium.org/document/d/11FKYXf9mSohlsgl4JmGlyWE1ScX3DKdssdjub63tkwA/edit?usp=sharing


BUG=360188
TEST=manual via test/spy_repl_test.html

Review URL: https://codereview.chromium.org/284743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272458 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=369521
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/296513020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272457 0039d316-1c4b-4281-b951-d872f2087c98

L bots need OpenJDK 7 and OpenJDK 7 works when building with older SDK's.
Also, this removes the awkward way we had to install Oracle's JDK.

BUG=353155

Review URL: https://codereview.chromium.org/294093006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272456 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/290173011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272455 0039d316-1c4b-4281-b951-d872f2087c98

Guests can exhibit un-intended behavior otherwise.

BUG=None
Test=Internal

Review URL: https://codereview.chromium.org/298913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272454 0039d316-1c4b-4281-b951-d872f2087c98

Since GCMDriver is going to be moved into component, it cannot access
chrome build info. So we now let GCMProfileService retrieve and pass
it.

Also change to define build info in GCMClient, instead of relying on
the one defined in proto buffer generated file.

BUG=356716
TEST=existing tests

Patch

Review URL: https://codereview.chromium.org/293053014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272453 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272449 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174434:174635&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/296983011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376695
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/299153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272447 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements the readDescriptorValue function of the
bluetoothLowEnergy API.

BUG=265663
TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.*

Review URL: https://codereview.chromium.org/297003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272445 0039d316-1c4b-4281-b951-d872f2087c98

The test is supposed to ensure that the breakpad component is correctly
hooked up to content_shell, and that the surrounding tools can actually
convert a crash into a symbolized stack dump.

This version is currently Linux-only, other platforms will be added.

The test is based on
http://www.chromium.org/developers/testing/webkit-layout-tests/using-breakpad-with-content-shell

This would have caught e.g. a call to base::GetLinuxDistro() being added
on the UI thread, or dump_syms not supporting debug fission yet.

The test needs to be executed like this:

 $ content/shell/tools/breakpad_integration_test.py \
      --build-dir=out/Debug --binary=out/Debug/content_shell
 # Generate symbols.
 # Run content_shell and make it crash.
 # Retrieve crash dump.
 # Symbolize crash dump.
 PASS: Breakpad integration test ran successfully.

BUG=372928
R=thestig@chromium.org, rsesek@chromium.org

Review URL: https://codereview.chromium.org/293993017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272444 0039d316-1c4b-4281-b951-d872f2087c98

as broken unless the main job succeeds, do not mark Alternate-Protocol
broken in the QuicStreamFactory unless the session was a failed 0-RTT
connection (in which case the Job already "succeeded").

Review URL: https://codereview.chromium.org/293063013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272442 0039d316-1c4b-4281-b951-d872f2087c98

Instead, we have InterfacePtr::set_client(..) and InterfaceImpl getting a
client set on it internally. This simplifies InterfaceImpl quite a bit.

BUG=374436

Review URL: https://codereview.chromium.org/289063015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272441 0039d316-1c4b-4281-b951-d872f2087c98

Since ExtensionRegistry::AddObserver replaces it.

This CL is the result of below script, and 'git cl format'.

find -regex '.*/.*\.\(mm\|cc\|h\)$' |
xargs sed -i s/NOTIFICATION_EXTENSION_INSTALLED/NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED/g

BUG=376293

Review URL: https://codereview.chromium.org/298883006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272440 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367029

Review URL: https://codereview.chromium.org/293033009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272439 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272437 0039d316-1c4b-4281-b951-d872f2087c98

TBR=slamm@chromium.org
BUG=

Review URL: https://codereview.chromium.org/299043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272436 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354775
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/291833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272435 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267773

Review URL: https://codereview.chromium.org/294113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272434 0039d316-1c4b-4281-b951-d872f2087c98

This should simplify ifdefs and ensure flexibility as we move to new platforms.

BUG=370071

Review URL: https://codereview.chromium.org/294173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272433 0039d316-1c4b-4281-b951-d872f2087c98

This allows the creator of the DistillerFactory to set the
DomDistillerOptions for all pages distilled by Distillers from that
factory.

Add an option to the content_extractor to extract just the text from the
page.

DEPENDSON= https://codereview.chromium.org/270663005/ https://codereview.chromium.org/286453002/

Review URL: https://codereview.chromium.org/286583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272431 0039d316-1c4b-4281-b951-d872f2087c98

Chrome requires video streams to have even width and height, so
MediaSource renderer didn't work properly for streams with odd width or
height. Fixed it to round up dimensions and crop one column or one row
when screen size is odd, using Matroska's CropRight and CropBottom
attributes.

BUG=321825

Review URL: https://codereview.chromium.org/291193008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272430 0039d316-1c4b-4281-b951-d872f2087c98

Also enable mmap'ing the main nexe, which may help a bit
in subsequent runs as well (first run the validator needs
page in all of the text anyway).

pnacl-llc.nexe, etc will be handled separately:
https://codereview.chromium.org/224803002/

TEST=NaClBrowserTestVcacheExtension.ValidationCacheOfMainNexe

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3421

Review URL: https://codereview.chromium.org/263683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272429 0039d316-1c4b-4281-b951-d872f2087c98

Most tests (not having state) are converted to a table-driven form,
so that multiple test operations can be done on the same test data.
Additional tests based on X11 native events are done on these cases.

The fallback X11 keycode to keysym mapping is expanded, because the
X server used by some automated tests does not support some of the
keycodes used by ChromeOS top-row special keys.


R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/270633012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272428 0039d316-1c4b-4281-b951-d872f2087c98

This CL also removes 	BrowserPluginHostTest.HiddenBeforeNavigation, that was disabled under TSAN v2.

BUG=368077, 370240
Test=None, internal only change.

Review URL: https://codereview.chromium.org/281833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272427 0039d316-1c4b-4281-b951-d872f2087c98

This class provides Chrome-specific stability metrics, enabling moving code
related to these metrics out of MetricsLog and MetricsService. It also
eliminates all notification listening from MetricsService. As part of the
latter change, ThreadWatcherObserver now registers explicitly for the
notifications it is concerned with rather than going through MetricsService for
this purpose.

BUG=375237

Review URL: https://codereview.chromium.org/289283011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272426 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374235
TEST=none
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/291843008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272425 0039d316-1c4b-4281-b951-d872f2087c98

Command buffer command decoder is missing few early returns.  Add early
returns after error handling in glVertexAttribDivisorANGLE if no
extension is present and glCopyTexImage2D if texture is immutable.

BUG=373159

Review URL: https://codereview.chromium.org/285703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272424 0039d316-1c4b-4281-b951-d872f2087c98

There's not much we can do about this, and ignoring the exception is
better than hanging the thread.

The minidump_stackwalk binary will just ignore modules for which it
can't find symbols so not having some symbols isn't tragic.

BUG=none
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/294203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272423 0039d316-1c4b-4281-b951-d872f2087c98

The main change here is that web_app::GetWebAppDataDirectory
is now being called on the UI thread.

BUG=356889

Review URL: https://codereview.chromium.org/286933012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272422 0039d316-1c4b-4281-b951-d872f2087c98

Change sheet repositioning to be based on NSWindowDidResizeNotification,
because it tracks window resizing much better than
NSViewFrameDidChangeNotification.
The modal sheet should now track the parent window's resizing much more
smoothly.

BUG=358627

Review URL: https://codereview.chromium.org/299573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272421 0039d316-1c4b-4281-b951-d872f2087c98

This is caused by the problem that the minimized panel could still become a key window. We found out a way to deactivate a NSWindow correctly.

BUG=365758

Review URL: https://codereview.chromium.org/275693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272420 0039d316-1c4b-4281-b951-d872f2087c98

Store the service worker script and its imports on first load, read them on subsequent loads. The list of resource ids is stored with registration data. As registrations are deleted the old resources are also deleted.

BUG=364247,364318

Review URL: https://codereview.chromium.org/293483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272418 0039d316-1c4b-4281-b951-d872f2087c98