GitLab

Bug: 1054425
Change-Id: I9365f76d33657c1208f735769a8b482a89d346f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066741
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743144}

To support the "stop" event generated by the Bluetooth devices with
AVRCP (Audio/Video Remote Control Profile), add handling for the stop
key.

BUG=b/147367020

Change-Id: I4bc9efa74173d8ffeab0affb4d685bc587f07616
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063809Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Michael Sun <michaelfsun@google.com>
Cr-Commit-Position: refs/heads/master@{#743143}

Cause analysis:
We are trying to enable two test suites for BottomSheet(BS)
PaymentHandler (PH) UI - PaymentRequestServiceWorkerPaymentAppTest and
PaymentHandlerChangePaymentMethodTest. Currently the two tests would
fail (BS PH enabled) because they are both timeout on waiting for
PaymentRequestUI#onDismiss() to be called. The reason why it's never
invoked is because when mDialog.isShowing(), not only
mDialog.dismiss() is bypassed (in DimmingDialog), but mDialog's dismiss
listener callback is bypassed as well (in Android's Dialog.java).

Why dimming dialog is not showing in BS PH UI is
because of scrim. For CCT PH UI, the scrim is provided by PR UI; for
BottomSheet PH UI, it's by BottomSheet. As a result, DimmingDialog (the
scrim) is showing in CCT and not showing in BS PH UI.

Before change:
PaymentHandlerChangePaymentMethodTest and
PaymentRequestServiceWorkerPaymentAppTest fails on some tests.

After change:
All tests are green.

Change:
* Replace DialogInterface.onDismissListener with
DimmingDialog.onDismissListener.
* Add onDismissListener invocation for DimmingDialog's dismissal.

Bug: 1045088

Change-Id: Iaedebfb1e9250eeb1974c63083c33cf8a89149df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047344
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743142}

Now that proguarded builds set sourcefile to a recognisable string, we
can use that to determine if a stack frame references Chromium code.

Also add the prefixes of other Chromium packages so that this continues
to work in the un-proguarded case.

Bug: 1044585
Change-Id: I6ce03c09da4de8942cd2db6436700f83ab93b141
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059970Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743141}

SharedWorkerServiceImpl was using a SiteForCookies based on the URL of
the worker being loaded, but a NetworkIsolationKey based on the URL of
the RenderFrameHost. In practice, these are always the same...except for
the case of extensions loading a SharedWorker of some site. This CL
fixes the issue.

Bug: 1052148
Change-Id: I53d37354defdcca5fe0ea3f1412ee7a638016a5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057525
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743140}

Bug: 1036426
Change-Id: I86c0dc4e22ae620b0b085b0683f8ccd2c06c3f67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066453
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743139}

When OOBE dialog is hidden, the login shelf should be notified, so it
can clear its cached dialog_state_. Otherwise, it will keep using the
cached dialog state when calculating shutdown button visibility, and
the button will remain hidden if the lock screen is shown later in the
session.

BUG=1051826

Change-Id: Id3fba45fd912a3eca2cc5b62b0e66f787d6e91d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058999Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743138}

This reverts commit df399aaa.

Reason for revert: The dependency CL got reverted. Reland after the dependency CL is relanded.

Original change's description:
> Revert "Replace param |disposition| with |should_report| on IsFeatureEnabled"
>
> This reverts commit ccf8b883.
>
> Reason for revert: To revert https://chromium-review.googlesource.com/c/chromium/src/+/2028666
>
> https://chromium-review.googlesource.com/c/chromium/src/+/2028666 seems to cause LinuxCFI tests failures.
>
> LinuxCFI tests start failing at
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16433
> 16433 contains https://chromium-review.googlesource.com/c/chromium/src/+/2028666
>
> Original change's description:
> > Replace param |disposition| with |should_report| on IsFeatureEnabled
> >
> > Previously |disposition| on IsFeatureEnabled have an awkward type
> > base::Optional<mojom::FeaturePolicyDisposition>*, which has 3 states
> > correspond to FeatureEnabledState:
> > - base::nullopt <= kEnabled
> > - FeaturePolicyDisposition::kReport <= kReportOnly
> > - FeaturePolicyDisposition::kEnforce <= kDisabled
> >
> > This CL simplifies the representation of this piece of information to
> > |should_report|, and removes FeatureEnabledState enum.
> >
> > The mapping of FeatureEnabledState to new logic:
> > kEnabled: enabled=true; should_report=false
> > kReportOnly: enabled = true; should_report=true
> > kDisabled: enabled = false; should_report=true
> >
> > Change-Id: I1fa82fb5e9924b8eed448853b139772e024bd531
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037326
> >
> Change-Id: Id6531935bbc777662fc3af2af65612495cb5a803
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059555

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I016c9280e74db35d35d04dcbcf4dfe93ee022836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061397
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743137}

Bug: 778317
Change-Id: I9d9ab96a40d9ba664428d7e514ba3fcc314a9a0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065317
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743136}

Distribute a little more logic from the shelf layout manager to
individual shelf components where it belongs. Now that most coordinates
are calculated within the screen, moving this logic around is a lot
easier.

Change-Id: Ib682350c7bcea935ddea21918b8ba09e3903a367
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066107
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743135}

Bug: 1053143
Change-Id: Id2ab9ef1d311f2565f4247644a0f677ed049841c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065028Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743134}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f0a082ec3466..bf2de16258dc

git log f0a082ec3466..bf2de16258dc --date=short --first-parent --format='%ad %ae %s'
2020-02-20 aerotwist@chromium.org [screenshot] Makes screenshots platform-specific
2020-02-20 yangguo@chromium.org Roll upstream changes

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@bf2de16258dc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1051458
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I3cc3af6baf4e11126bfe46661002279452080c97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066798Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743133}

Check for the installed apps, then return an empty list if in incognito
mode, to prevent the ability to use this API for detecting incognito mode.

Bug: 1045506
Change-Id: I83c4611947990af470d64ac723fc6695893e2a23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066778
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Auto-Submit: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743132}

Lint is no longer incorrectly generating errors for valid v27 usages of
these navbar APIs, so we can now remove these suppressions.

Bug: 856861
Change-Id: If211e8446ad2eb13634b7134b778e2e5b5a0b2f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065848
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743131}

https://android.googlesource.com/platform/external/perfetto.git/+log/c2ca38da431c..df5f7f9e4e1a

git log c2ca38da431c..df5f7f9e4e1a --date=short --first-parent --format='%ad %ae %s'
2020-02-20 treehugger-gerrit@google.com Merge "test: log gtest onto logcat"
2020-02-20 taylori@google.com Merge "perfetto-ui: Correct resolution upon loading"
2020-02-20 treehugger-gerrit@google.com Merge "Add some benchmarks for data sources and track events"

Created with:
  gclient setdep -r src/third_party/perfetto@df5f7f9e4e1a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Id2faa2c572cbde8f12fcb9d2c7861629161cdaa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066797Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743130}

See discussion thread at
https://groups.google.com/a/chromium.org/g/cxx/c/h4bdRqbduNY/m/O8Blk8SoEQAJ

The recommendation style is as follows:

class Foo : public IComIsFun {
  IFACEMETHODIMP IsFun(BOOL* fun) override;
};

HRESULT Foo::IsFun(BOOL* fun) { *fun = false; return S_OK; }

Change-Id: I3209682f14489d9c1b31cf5f563a50cccf42a05e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065857Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743129}

https://chromium.googlesource.com/external/github.com/material-components/material-components-ios.git/+log/8c3afe370288..559a3893cb58

$ git log 8c3afe370..559a3893c --date=short --no-merges --format='%ad %ae %s'
2020-02-19 featherless Revert "Temporarily use the `develop` .gitattributes."
2020-02-19 featherless Update snapshot tests.
2020-02-19 featherless Remove checked in files.
2020-02-19 featherless Temporarily use the `develop` .gitattributes.
2020-02-19 featherless Bump the version correctly.
2020-02-19 featherless Bump the release.
2020-02-19 featherless Update changelog.
2020-02-19 featherless Revert "Revert "merge release-candidate""
2020-02-19 featherless Revert "Revert all commits to stable since v104.0.1."
2020-02-19 featherless Revert all commits to stable since v104.0.1.
2020-02-19 featherless Revert "merge release-candidate"
2020-02-18 yarneo update changelog
2020-02-17 yarneo Bumped version number to 105.0.0.
2020-02-17 yarneo Hand-modified CHANGELOG.md API diff.
2020-02-17 yarneo Automatic changelog preparation for release.
2020-02-16 56741989+copybara-service[bot] [Dialogs] Add snapshot tests for additional dialog configurations. (#9646)
2020-02-16 56741989+copybara-service[bot] [Dialogs] Refactor title-icon, title-icon-view frames calculations to accommodate adjustable insets (#9657)
2020-02-16 56741989+copybara-service[bot] [Dialogs] Refactor action frame calculations to accommodate adjustable insets (5 seconds ago) (#9656)
2020-02-15 galiak [Dialogs] Refactor content frame calculations to accommodate adjustable insets  (#9710)
2020-02-15 galiak [Dialogs] Refactor title frame calculations to accommodate adjustable insets (#9709)
2020-02-14 galiak [Dialogs] Update adjustable insets values (#9695)
2020-02-14 galiak [Dialogs] Update adjustable insets comments (#9694)
2020-02-14 andrewoverton Remove unneeded subspec (#9748)
2020-02-14 galiak [Dialogs] Fix custom title icon view layout - top inset (#9721)
2020-02-14 bryanoltman Fix invalid podspec (#9745)
2020-02-14 randallli [Material][Availability] Migrates cards to MDCAvailability. (#9728)
2020-02-14 randallli [Material][Availability] Migrates Tabs to MDCAvailability. (#9716)
2020-02-14 randallli [Material][Availability] Migrates Chips to MDCAvailability. (#9713)
2020-02-14 randallli [Material][Availability] Migrates Bottom Navigation to MDCAvailability. (#9717)
2020-02-14 andrewoverton [Dialogs] Migrate dialogs to availability (#9743)
2020-02-14 randallli Add @jakerockland to CODEOWNERS: NavigationDrawer (#9715)
2020-02-14 bryanoltman [Material][Availability] Migrates Flexible Header to MDCAvailability. (#9744)
2020-02-14 andrewoverton [Material][Availability] Migrates Schemes to MDCAvailability (#9736)
2020-02-14 bryanoltman [Material][Availability] Migrates Ink to MDCAvailability. (#9741)
2020-02-14 bryanoltman [Material][Availability] Migrates Snackbar to MDCAvailability. (#9739)
2020-02-14 andrewoverton [private] Make private/color use availability  (#9738)
2020-02-14 bryanoltman [Material][Availability] Migrates activity indicator to MDCAvailability. (#9735)
2020-02-14 bryanoltman [Material][Availability] Migrates Action sheet to MDCAvailability. (#9733)
2020-02-14 andrewoverton Move static const assignment to MDCTextControl.m (#9701)
2020-02-14 randallli [Material][Availability] Migrates Slider to MDCAvailability. (#9704)
2020-02-13 andrewoverton [Material][Availability] Migrates Text Controls to MDCAvailability (#9720)
2020-02-13 andrewoverton Remove test spec (#9718)
2020-02-13 andrewoverton [TextControls] Changes from text-area-feature-branch with additional podspec and BUILD file changes (#9711)
2020-02-13 randallli Delete Dialogs OWNERS file (#9697)
2020-02-13 randallli Delete NavigationDrawer OWNERS file (#9696)
2020-02-13 galiak [Dialogs] Adding accessory view vertical inset to private header (#9692)
2020-02-12 56741989+copybara-service[bot] [Component] MDCButton. (#9667)
2020-02-11 56741989+copybara-service[bot] [Dialogs] Adding an adjustable insets feature flag. Flag default is NO. Clients must enable flag if they want to customize the inset. This flag has no effect yet in this CL. Adjustable layout logic will be introduced in followup CLs. (#9648)
2020-02-11 bryanoltman [TextFields] Delete deprecated MDCTextFieldTypographyThemer (#9689)
2020-02-11 bryanoltman [Buttons] Delete deprecated MDCOutlinedButtonThemer (#9688)
2020-02-19 yarneo snapshots
2020-02-19 yarneo updated changelog
2020-02-18 bryanoltman [Dialogs] Add reference images for MDCAlertControllerConfigurationsTests (#9757)
2020-02-18 yarneo update changelog
2020-02-17 yarneo Bumped version number to 105.0.0.
2020-02-17 yarneo Hand-modified CHANGELOG.md API diff.
2020-02-17 yarneo Automatic changelog preparation for release.
2020-02-16 56741989+copybara-service[bot] [Dialogs] Add snapshot tests for additional dialog configurations. (#9646)
2020-02-16 56741989+copybara-service[bot] [Dialogs] Refactor title-icon, title-icon-view frames calculations to accommodate adjustable insets (#9657)
2020-02-16 56741989+copybara-service[bot] [Dialogs] Refactor action frame calculations to accommodate adjustable insets (5 seconds ago) (#9656)
2020-02-15 galiak [Dialogs] Refactor content frame calculations to accommodate adjustable insets  (#9710)
2020-02-15 galiak [Dialogs] Refactor title frame calculations to accommodate adjustable insets (#9709)
2020-02-14 galiak [Dialogs] Update adjustable insets values (#9695)
2020-02-14 galiak [Dialogs] Update adjustable insets comments (#9694)
2020-02-14 andrewoverton Remove unneeded subspec (#9748)
2020-02-14 galiak [Dialogs] Fix custom title icon view layout - top inset (#9721)
2020-02-14 bryanoltman Fix invalid podspec (#9745)
2020-02-14 randallli [Material][Availability] Migrates cards to MDCAvailability. (#9728)
2020-02-14 randallli [Material][Availability] Migrates Action sheet to MDCAvailability. (#9732)
2020-02-14 randallli [Material][Availability] Migrates Tabs to MDCAvailability. (#9716)
2020-02-14 randallli [Material][Availability] Migrates Chips to MDCAvailability. (#9713)
2020-02-14 randallli [Material][Availability] Migrates Bottom Navigation to MDCAvailability. (#9717)
2020-02-14 andrewoverton [Dialogs] Migrate dialogs to availability (#9743)
2020-02-14 randallli Add @jakerockland to CODEOWNERS: NavigationDrawer (#9715)
2020-02-14 bryanoltman [Material][Availability] Migrates Flexible Header to MDCAvailability. (#9744)
2020-02-14 andrewoverton [Material][Availability] Migrates Schemes to MDCAvailability (#9736)
2020-02-14 bryanoltman [Material][Availability] Migrates Ink to MDCAvailability. (#9741)
2020-02-14 bryanoltman [Material][Availability] Migrates Snackbar to MDCAvailability. (#9739)
2020-02-14 andrewoverton [private] Make private/color use availability  (#9738)
2020-02-14 bryanoltman [Material][Availability] Migrates activity indicator to MDCAvailability. (#9735)
2020-02-14 bryanoltman [Material][Availability] Migrates Action sheet to MDCAvailability. (#9733)
2020-02-14 andrewoverton Move static const assignment to MDCTextControl.m (#9701)
2020-02-14 randallli [Material][Availability] Migrates Slider to MDCAvailability. (#9704)
2020-02-13 andrewoverton [Material][Availability] Migrates Text Controls to MDCAvailability (#9720)
2020-02-13 andrewoverton Remove test spec (#9718)
2020-02-13 andrewoverton [TextControls] Changes from text-area-feature-branch with additional podspec and BUILD file changes (#9711)
2020-02-13 randallli Delete Dialogs OWNERS file (#9697)
2020-02-13 randallli Delete NavigationDrawer OWNERS file (#9696)
2020-02-13 randallli [buttons] Fix tvOS target bug. (#9705)
2020-02-13 galiak [Dialogs] Adding accessory view vertical inset to private header (#9692)
2020-02-12 56741989+copybara-service[bot] [Component] MDCButton. (#9667)
2020-02-12 56741989+copybara-service[bot] [FlexibleHeader] Added property for minimumHeaderViewHeight (#9649)
2020-02-12 yarneo fix snapshot tests for CI (#9698)
2020-02-12 bryanoltman [TextFields] Update snapshot goldens (#9691)
2020-02-11 56741989+copybara-service[bot] [Dialogs] Adding an adjustable insets feature flag. Flag default is NO. Clients must enable flag if they want to customize the inset. This flag has no effect yet in this CL. Adjustable layout logic will be introduced in followup CLs. (#9648)
2020-02-11 bryanoltman [TextFields] Delete deprecated MDCTextFieldTypographyThemer (#9689)
2020-02-11 bryanoltman [Buttons] Delete deprecated MDCOutlinedButtonThemer (#9688)

Created with:
  roll-dep src/ios/third_party/material_components_ios/src

Change-Id: Ia980199891d4d55704b8d616505b74adacf417d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066757
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743128}

https://skia.googlesource.com/skia.git/+log/9d4e31d6cda5..0cd68ab14a08

git log 9d4e31d6cda5..0cd68ab14a08 --date=short --first-parent --format='%ad %ae %s'
2020-02-20 robertphillips@google.com Add private GrContext::compile API
2020-02-20 robertphillips@google.com Add new gpu sink for DDLs

Created with:
  gclient setdep -r src/third_party/skia@0cd68ab14a08

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: lovisolo@google.com
Change-Id: I21ab9161176530b9bd02e30bbf4fa8a3fed1e2ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065907Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743127}

They were using typedefs that should have used the actual symbol.
Required for
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2060290

TBR=aerotwist@chromium.org

Bug: 1006759
Change-Id: I3f1433de7e472d7877729132278b581540665cd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064942Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743126}

Previously "0" was always passed as the user-id to LibAssistant.
This now causes issues when trying to introduce marble,
as marble actually relies on the user-id being a real Gaia-id.

Another change I've made here is introduce a |ScopedAshSessionObserver|
class which is used inside the Assistant |Service|.
This simplifies the house-keeping inside the |Service| class.

Note: This requires crrev.com/i/2556323 to land first
(and be uprevved into Chromium).

Bug: b/143984405
Change-Id: I28b6801a598de1b7f76c19af272d3fc18efa47e9
Tests: New chromeos_unittests that are covered by the filter "*Assistant*"
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055428
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743125}

This patch adds three button styles for the confirmation button
depending on the user sign-in state: 'More', 'Confirmation', and 'Add Account'.

See go/chrome-ios-signin-migration for more information.

Bug: 971989
Change-Id: I4b98eea8bb260267c6ee0d9621059a7c1138649f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062991Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743124}

Bug: 958893
Change-Id: Ife077c62be1c98073cab9a216b4870fcf768c4f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042301
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743123}

filter_terrain_svg has been flaky on Win10 FYI x86 Release (NVIDIA).

TBR=sadrul@chromium.org

Bug: chromium:1053614
Change-Id: I71392b8b9e9e212d5f5cb5c54cbab9278fed6a2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066449Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743122}

According to design, on iPad the spacing between buttons (not text
fields) and an adajcent edge should be greater.

Fixed: 1053988
Change-Id: Id061603e32e184864cba61ee11c6e6a946b41e49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066541Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#743121}

The flag itself was already removed in r735677, this removes the
metadata from the json file.

Bug: 1046131
Change-Id: Id54ebfcd472e06f1bbfb870fa60e62bb97555ff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064815Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743120}

The HostZoomLevelContext class was refcounted, but only ever owned by
a StoragePartitionImpl so remove the refcounting. It also had a custom
deleter doing basically the same work as DeleteOnUIThread so use that
instead. De-virtualize the destructor, too.

Change-Id: I75bf780953e6420e00d488af1560262ca4ed7188
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028934
Auto-Submit: Joshua Bell <jsbell@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743119}

* Wire PeopleHandler::TurnOffSync to the IdentityManager.
* Clean up PeopleHandler unit tests. Re-enable some tests on Chrome OS,
  delete unused helper methods, make signin step more explicit.
* Add initial implementation of RevokeSyncConsent to IdentityManager.
  For now this is only supported on Chrome OS because Chrome OS is the
  only platform that needs to exercise it.

Bug: 1050677
Test: Enable SplitSettingsSync, enable sync in browser first-run flow,
      go to Settings, turn sync off, chrome://sync-internals shows
      browser sync feature enabled is false
Test: added unit_tests and components_unittests

Change-Id: I5b2afa49ffa71aac155f93b9abb504c14c4f6b80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982186Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743118}

Child user will see the notification with the details of time
limit change in the following cases:
* App did not have the limit and new limit was set.
* App had time limit set and it was removed.
* The value of time limit changed.
There are no notifications displayed for web apps, as they
share the limit with Chrome and notification will be shown
for Chrome.

Bug: 1052011
Test: AppTimeControllerTest
Change-Id: I662773969b4668c73bc3d6a9d572f8a11d147ae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065411Reviewed-by: Yilkal Abe <yilkal@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743117}

https://chromium.googlesource.com/angle/angle.git/+log/b0e9cd6645e1..2156c444568a

git log b0e9cd6645e1..2156c444568a --date=short --first-parent --format='%ad %ae %s'
2020-02-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src f155ccfd202d..6112b121e104 (8 commits)

Created with:
  gclient setdep -r src/third_party/angle@2156c444568a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I7ed398a158660559225f7443f328b468b6adbb82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065906Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743116}

On some websites multiple redirects occur straight after login
but on iOS they are not treated as redirects, but rather as form
submissions, so the infobar should not expire not only on redirects,
but on form submission navigation as well.

Bug: 720090, 720154
Change-Id: I766ee66749d0f4942206cc44a6d5d1e50a2a672b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066617Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maria Kazinova <kazinova@google.com>
Cr-Commit-Position: refs/heads/master@{#743115}

NetworkIsolationKey and site-for-cookies are related, in such a way as
that we shouldn't be sending same-site-cookies for requests when the
NIK doesn't indicate the top-frame origin (and frame origin, if
present) are for that site. We want to add DCHECKs that this is always
the case.  This CL fixes a couple NetworkContext unit tests where
the two values don't agree.

Bug: 1052148
Change-Id: Ibd7118310ac01b19f60001a1296f3e76af091c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055426Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743114}

Change-Id: Iaadce70c24f55fe5bb68ffdd6963c7812f25e271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065273Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743113}

Fixed: 1054402
Change-Id: I4e07f98bf365f0adbbf51680d913af91b0e81859
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066448
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743112}

https://webrtc.googlesource.com/src.git/+log/1282babe6621..2e161c4dd654

git log 1282babe6621..2e161c4dd654 --date=short --first-parent --format='%ad %ae %s'
2020-02-20 mbonadei@webrtc.org Revert "Remove ResourceAdaptationModule::OnMaybeEncodeFrame"
2020-02-20 phoglund@webrtc.org Fix required property for iOS tests.
2020-02-20 jakobi@webrtc.org Update target rates if stable target has changed.
2020-02-20 sprang@webrtc.org Lazy conversion to i420 buffer in SimulcastEncoderAdapter
2020-02-20 danilchap@webrtc.org Delete legacy DataSize and DataRate factories
2020-02-20 danilchap@webrtc.org Parse DependencyDescriptor rtp header extension
2020-02-20 phoglund@webrtc.org Whitespace change to kick bots.
2020-02-20 elrello@microsoft.com Rollback transport created by data channel
2020-02-19 philipp.hancke@googlemail.com loosen ice-ufrag/ice-pwd ice-char restrictions
2020-02-19 titovartem@webrtc.org Add YUV to IVF video converter util
2020-02-19 mbonadei@webrtc.org Remove wildcard ownership for build files.
2020-02-19 danilchap@webrtc.org Refactor parsing generic descriptor extension into own function
2020-02-19 mbonadei@webrtc.org Remove inactive OWNERS.
2020-02-19 titovartem@google.com Remove unused compile-dep from sdk/android:base_java target
2020-02-19 phoglund@webrtc.org Fix dead link.
2020-02-19 mbonadei@webrtc.org Make error message more actionable.
2020-02-18 deadbeef@webrtc.org Make CNAME optional.
2020-02-18 deadbeef@webrtc.org Add constants for allowed network_priority values
2020-02-18 jamiewalch@chromium.org Add missing interface methods.

Created with:
  gclient setdep -r src/third_party/webrtc@2e161c4dd654

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1032987,chromium:1044521,chromium:1052352,chromium:1053756,chromium:1053891
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ibf46e5e39407babffe40e4cf83b35a9e7134aaf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065905Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743111}

The screen reader's focus rings have outsets around the bounding box
from the semantics tree info.  However, when the bounding box is for
a full screen item (like the background image, for example) the
focus ring becomes invisible because it renders outside the screen
area.  This CL clips the points to the screen's dimensions.

Bug: 1052121
Test: Local build display assistant with screen reader enabled
Change-Id: Icf4ad68f59c23e503bc3baf9ec7763e175095853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055668Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743110}

While here, also remove some references to GYP.

Bug: 1031169
Change-Id: Ibb00ea755454be02b366f344d9bae8b693dbd581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066060
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743109}

The current algorithm first finds a |prefix|, then checks if the
immediate following text is the |search_text|. If it is it'll advance
|search_start| to the end of the |search_text| so it can confirm it's
followed by the |suffix| text. However, this means that if the |suffix|
text doesn't match, the next iteration of the algorithm will start
searching for the |prefix| at the end of the |search_text|. This is a
problem if the |search_text| == |prefix| because we've now skipped the
|search_text| part of the range for prefix matching.

E.g. With prefix=foo search_text=foo suffix=bar we'll fail to match:

foo foo foo bar

Because the first iteration of the loop will use the first "foo" as
the prefix, and the next iteration will use the third "foo" as the
prefix; we skip the second.

Bug: 1054243
Change-Id: I62b8a32f89c987e5bed8ea439ae1b7d53d12436d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065979Reviewed-by: Nick Burris <nburris@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743108}

This reverts commit 7a9ca38d.

Reason for revert: It appears all the browserlist observers are
busted after closing the last incognito tab.

Original change's description:
> [iOS] Create WebStateList observation registrar.
> 
> This CL creates AllWebStateListObservationRegistrar, which can be used
> in any case when an object needs to observe all web state lists for a
> given BrowserState.
> 
> This is a generalized version of the snapshot cache tab model observer,
> which this replaces.
> 
> For cases where only regular or OTR browsers' WebStateLists should be
> observed, AllWebStateListObservationRegistrar has an optional param that
> can be set at creation time.
> 
> To avoid circular dependencies, one target in web_state_list/ had to
> be split from the main target (hence the scattershot BUILD.gn updates).
> 
> Change-Id: Ic3977b709d5b089ebf31afd0fa868067833f2249
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997306
> Commit-Queue: Mark Cogan <marq@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742172}

TBR=rohitrao@chromium.org,marq@chromium.org,justincohen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: If97541ae3196c04da57c8a49896e8c55d5646949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063918Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743107}

Enable whitelist policy wrapper to graciously handle
empty or incorrect values.

Bug: 1051201
Change-Id: I1e94af89e60106b7eedbd0e65c2b1138055ba5e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065983Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743106}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/71d0f777fcf6..e1cd8b3dcc1d


Created with:
  gclient setdep -r src-internal@e1cd8b3dcc1d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1040143
Tbr: jbudorick@google.com
Change-Id: I331dde0bcc0b63c9888e06acb1346421beb0c2da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065904Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743105}