- 27 Mar, 2020 40 commits
-
-
Etienne Bergeron authored
Simplify the code by inlining the common values in the nitialisation list. This CL has no functional change. R=morlovich@chromium.org, gab@chromium.org Bug: 1065004 Change-Id: Ib52c6f910975ef109901171d499eee870826cc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121765Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754016}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/48f3f6cb2acb..14b1e3f3d10a git log 48f3f6cb2acb..14b1e3f3d10a --date=short --first-parent --format='%ad %ae %s' 2020-03-27 sugoi@google.com Update SPIR-V Tools to fd773eb50 2020-03-27 sugoi@google.com Update SPIR-V Headers to f8bf11a02 Created with: gclient setdep -r src/third_party/swiftshader@14b1e3f3d10a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If2ced46e8698a25c1b609302e6a50c3a40620312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124415Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754015}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7fa53f2a9685..a27ec02e9e1e git log 7fa53f2a9685..a27ec02e9e1e --date=short --first-parent --format='%ad %ae %s' 2020-03-27 szuend@chromium.org Move 'issues' module from 'shell' to 'devtools_app' and 'worker_app' 2020-03-27 szuend@chromium.org [issues] Clicking on affected requests will open the details view 2020-03-27 tvanderlippe@chromium.org Remove unused global exports from common-legacy.js 2020-03-27 changhaohan@chromium.org add check to ensure style pane update 2020-03-27 tvanderlippe@chromium.org Remove unused global references in workspace-legacy.js 2020-03-27 aerotwist@chromium.org [e2e] Adds support for logs and errors 2020-03-27 aerotwist@chromium.org [e2e] Adds support for setting a timeout 2020-03-27 tvanderlippe@chromium.org Add test that verifies Ninja does not do any work when no changes are made Created with: gclient setdep -r src/third_party/devtools-frontend/src@a27ec02e9e1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1060267,chromium:1062614,chromium:1064287,chromium:1064958 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I45465867a265cbeedc8550cdc2f1dd8bc2c152f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123871Reviewed-by:
-
Lukasz Anforowicz authored
This CL migrates BackgroundXhrWebstoreTest.PolicyContentScriptXHR to the CrossOriginReadBlockingExtensionAllowlistingTest test suite (into new tests, called ContentScriptVsHostBlockedByPolicy_NoSniffXml and ContentScriptVsHostBlockedByPolicy_AllowedTextResource). This way the tests covers the following setup aspects: - CorbAllowlistAlsoAppliesToOorCors feature is enabled or disabled - Extension is allowlisted or not - OOR-CORS vs InBlinkCors After this CL the old test can be deleted. Note that the old test always tested with: - CorbAllowlistAlsoAppliesToOorCors disabled - Non-allowlisted extension - The default OOR-CORS state (enabled by default since r728462) Bug: 1061567 Change-Id: Ic76ac9e48510953fd130141776e66b1fde11c404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107431 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754013}
-
Benoit Lize authored
The orderfile build doesn't prefetch the native library, creating unreached code, which is a compile time error with the flags we use. Move the unreached code out of the build in this case. See the linked bug for the detailed error message. Bug: 1065182 Change-Id: Ic8c5b17e6077c4639a82b9caf574a7ae4018e64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124258Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754012}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I18ad203905c3dfa511d0a5cc9b9fefc5616a4e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123873Reviewed-by:
-
Gauthier Ambard authored
When a navigation is cancelled, the NTP should still be presented. Currently, as the navigation starts, the NTP is hidden and it is not restored when the navigation is cancelled. Fixed: 1063154 Change-Id: I0844fa735ae4e0f9e184d46ac6c96e809b873807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120352Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#754010}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/651fc45d3a29..fd3480d22624 git log 651fc45d3a29..fd3480d22624 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src acbf316040c3..cc481ef27631 (1 commits) Created with: gclient setdep -r src/third_party/angle@fd3480d22624 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Ia3fdc2e2a6d2b9fb748f8e67693970071c330bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124411Reviewed-by:
-
Mikhail Khokhlov authored
The target will wrap the uploader script with path to trace_processor_shell as an argument. The Perfetto revision will be determined automatically by the script itself. This target is intended to be built by perfetto-uploader CI bots. Bug: 1050517 Change-Id: I57a93f8268181250a85400b5899e845b5cfa9d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120427 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#754008}
-
Yaron Friedman authored
They passed 20/20 times locally. BUG=1062568, 727310, 999361 Change-Id: I3741560e7195d7d19f4bd17d97374d540b83fc24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122851 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#754007}
-
Antonio Gomes authored
As part of this move, the test was renamed to flexbox-overflow-auto-002.html. BUG=1063749 R=dgrogan@chromium.org Change-Id: I35b258bed47050051139020a1fc3147d08333fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120544 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#754006}
-
Hans Wennborg authored
Looks like the space between the two right angle brackets is gone with recent Clang. The test expectation is already a regex, so insert a '?' to make the space optional. TBR=tzik Bug: 1064986 Change-Id: I3075116ff2b344a5e13658cd2fd6b92522d58aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124453Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#754005}
-
Eric Kuo authored
Add a routine to calculate prime number repeatedly and validate the calculation results are correct in a duration. Bug: b:146513388 Test: chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* Change-Id: I29c3d71d2b0f9d86043e552e135bc9178c95014f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049986 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#754004}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7e40936b1d81..42f548873cf8 git log 7e40936b1d81..42f548873cf8 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 treehugger-gerrit@google.com Merge "client API: Add missing PERFETTO_EXPORT definitions" 2020-03-27 treehugger-gerrit@google.com Merge "profilers: treat unset and =0 persist props the same" Created with: gclient setdep -r src/third_party/perfetto@42f548873cf8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I24627c657f96315dd311bf12914fdefdbe676f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124040Reviewed-by:
-
Fredrik Söderqvist authored
The |bounding_box| argument isn't actually used, so drop it. Also turn the check at the beginning of StrokeShape() into a DCHECK since the (only) caller already checks it. Change-Id: Ib5ff5d462c440a55361f9051e91e528ac3b82a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124373Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#754002}
-
Mark Cogan authored
Removes direct use of the BVC in MainController. The most common uses of the BVC through the interface provider are (a) access to the dispatcher, and (b) marking the BVC as the primary one. (This CL doesn't address whether the notion of a BVC as "primary" is still useful). The dispatcher can be accessed through an interface's Browser. This CL adds the -setPrimary: API to BrowserInterface for cases where it is needed. Additionally, updates removeBrowsingDataForBrowserState: to handle -- possibly correctly -- multiple connected scenes. This just repeats all of the setInteractionEnabled/showActivityOverlay calls for each scene. Change-Id: Ia6bebf86a991a977f83f3f3a8da086fe5de519e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124447Reviewed-by:
-
Benoit Lize authored
Scheduler group detection doesn't work on Android P x86 (see bug), but isn't used anyway on M and above. Disable the tests for these releases. Bug: 1061173 Change-Id: Ic0982c68387e9c77a9e55182b4ab059708ffc33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124379Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754000}
-
Nico Weber authored
The code looks like the break should be inside the if, so that the loop has a chance of running more than once. I tried reaching out to the author of this code, but didn't hear back. But with this change, header_exist should become true more often and the test code is stricter when it's true. So since tests still pass with this, this might help catch problems in the future. Bug: 346399,686247 Change-Id: I25e8c1a38043af09936e35c58e87db3bee103e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120048 Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#753999}
-
Richard Townsend authored
Adds a temporary fix to vs_toolchain.py to use the previous version of MSVC's header files and documents how to install the previous version alongside 19.25. Bug: 1058860 Change-Id: I6e96af3c71b23e5c5430237d00125a5830c37855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117732 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#753998}
-
Colin Blundell authored
This CL adds test coverage of WebLayer's handling of browser fallback URLs in external intents: - If the intent is launched, then the presence of a browser fallback URL doesn't change anything. - If an intent can't be launched with no browser fallback URL, there is a failed navigation. - If an intent can't be launched with a browser fallback URL, there is a successful navigation to the browser fallback URL. Bug: 1029710, 1031465 Change-Id: I6386ab44d6ffc9a58e93966c00516cb360fbdcc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121266Reviewed-by:
-
Hans Wennborg authored
Bug: none Change-Id: I87c0dd47fef41e9ada7dfc192bae3a1aff55897b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124380 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#753996}
-
Anders Hartvoll Ruud authored
Not resetting this didn't lead to any bugs, because it's just a performance optimization. Even if a given bit is set, nothing will happen if the corresponding property is missing from the cascade. Also, we only really Reset for DCHECK_IS_ON. Still it's proper to actually reset the value. Change-Id: I57b023316c46c8f8def9c634319116d63c4503f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124250 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753995}
-
Nicolas Ouellet-Payeur authored
This refactors the InstallationTracker, and splits it into 2 classes: - InstallationTracker: listen for pref changes, and keep track of force-installed extensions' installation state. Fire `OnAllExtensionsLoaded()' when they're all done. - InstallationMetrics: listen for `OnAllExtensionsLoaded()', and report metrics to UMA when it fires. With this refactor, other classes can listen to this event to get notified when force-installed extensions are done loading. Bug: 1057999 Change-Id: Ib3ff409b460411020b3dee586aba3413a3e1d93f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088295 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#753994}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4ff1b1de0e8d..7fa53f2a9685 git log 4ff1b1de0e8d..7fa53f2a9685 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 petermarshall@chromium.org [ui] Fix color picker switcher style for dark-mode 2020-03-27 aerotwist@chromium.org [e2e] Migrate selection-after-delete layout test 2020-03-27 szuend@chromium.org Prepare IssuesModel for 1:n mapping between backend and frontend issues Created with: gclient setdep -r src/third_party/devtools-frontend/src@7fa53f2a9685 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I942f257ad1747868fcf457f39beae26097a9cc1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124408Reviewed-by:
-
Sebastien Lalancette authored
Bug: 1064990 Change-Id: Ia865919514d57b4e7611bdfe7fa5828035b9ec26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122750Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#753992}
-
Huanzhong Huang authored
This change is to align with the corresponding Finch config Bug: 1045348 Change-Id: Ia5cceb550520cb31127057e5be61e84998b017e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121120Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#753991}
-
Abigail Klein authored
Make it possible to drag the caption bubble by clicking any part of it. To do this, introduce a CaptionBubbleFrameView which overrides the NonClientHitTest to return HTCAPTION whenever the hit point is inside of the bubble and is not on the close button. Bug: 1055150 Change-Id: I9ee8cdd064b87210ea05599cb01f7d42d64451e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095881Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#753990}
-
Jan Wilken Dörrie authored
This change adds logic to handle simultaneously phished and leaked credentials in the Password Check UI. These credentials should be surfaced with their own string, have a timestamp corresponding to the more recent compromise event and be ordered within the other phished credentials. Fixed: 1064952 Change-Id: Ibef4b0785957d44a61936797f43aee2fe690da0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122353 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753989}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I63636d765697143f102b7d71ea4f27ef0a95b17f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124039Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium aeb4b3df. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I999eec24f9be33f8bb93e7cce4a9fefc1652d523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123809Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753987}
-
Eric Seckler authored
To verify whether this causes crashes in SharedMemoryABI::TryAcquireChunk. Bug: 1064020 Change-Id: Ia00ca5ef8fabdfad7a6fc5c1c86ba0c25b7c982f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124310 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#753986}
-
Eric Kuo authored
Add two routines, disk linear read and random read routines, which will simulate disk linear read and random read by creating a file with checksum, read it randomly or linearly, and validate the checksum of read back in a duration. --gtest_filter=CrosHealthdServiceConnectionTest.* Bug: b:146513388 Test: chromeos_unittests Change-Id: Ide8b1ccaf353186c9f96b49e089a2648ef10b40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046804 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
-
Jochen Eisinger authored
Change-Id: I1910e309ceae7816f0a8bc1ddda5cd44672ab681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124251Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Maksim Sisov authored
Currently, NativeViewGLSurfaceEGL has a bunch of code guarded by USE_X11. This should be unified and placed under X11 interfaces managed in compile time. What is more, this code must be shared with ozone/x11 as well. Thus, to avoid confusions in names of the classes/files, rename gl_surface_egl_x11 to gl_surface_egl_x11_gless and rename the class NativeViewGLSurfaceEGLX11 to NativeViewGLSurfaceEGLX11GLES2 as that is always used when --use-gl=egl is passed. In the next CL, I will extract all the x11 code from NativeViewGLSurfaceEGL and place it to NativeViewGLSurfaceEGLX11. The reason why this is going to be managed in such a way is that currently when Angle is used with X11, NativeViewGLSurfaceEGL is used instead of NativeViewGLSurfaceEGLX11. And, thus, all the code that is guarded by USE_X11 is compiled and executed. Thus, when --use-gl=angle is passed (this is default for x11/linux now), NativeViewGLSurfaceEGLX11 will be used. And when --use-gl=egl is passed, NativeViewGLSurfaceEGLX11GLES2 will be used (it initializes native platform window as well, which is not required in case of angle). Bug: 1036285 Change-Id: I9bfe89a24c36ce80061137eae05f3c4dc00aa1c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116629 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#753983}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/49f8e0d4..5851deb6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib290929c0740fdfd0216a941c27bd4edf575493b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123810Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753982}
-
Nohemi Fernandez authored
Adds a flag to the user sign-in and reauthentication flows to use the new sign-in architecture. Updates the add account sign-in coordinator to present on the base view controller. Bug: 971989 Change-Id: I092e88a917573e869b38efc53a5089215077db60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120356 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/02e15b249b12..48f3f6cb2acb git log 02e15b249b12..48f3f6cb2acb --date=short --first-parent --format='%ad %ae %s' 2020-03-27 digit@google.com Remove two minor compiler warnings/errors: Created with: gclient setdep -r src/third_party/swiftshader@48f3f6cb2acb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2c2ded784652d82782b33cde69c13dee9d060139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124216Reviewed-by:
-
Yuki Shiino authored
Adds v8_color_page_popup_controller.{cc,h}. Bug: 839389 Change-Id: Icd8b75effe0001c7cee8161eabfeed995dd32458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124330Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#753979}
-
Anastasiia Nikolaienko authored
Send login params together with credentials to C++. Params contain obfuscated Gaia id and Reauth Proof Token of the parent who is approving EDU login flow. We are getting this information on 'parent signin' step and passing it to the last ('EDU account signin') step. The params will be used to log parent consent for secondary account addition. Bug: 1054798 Change-Id: If1f1fcfc7bdb0ec9ba05c98add764fd51cd373c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096636 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#753978}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/123c8191bc01..7e40936b1d81 git log 123c8191bc01..7e40936b1d81 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 ilkos@google.com Merge "Improve the heap graphs ui" Created with: gclient setdep -r src/third_party/perfetto@7e40936b1d81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I11127f40128ed4f929a6418aa23b00bdab82a6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124214Reviewed-by:
-
