- 28 Jun, 2018 16 commits
-
-
Chris Lu authored
Before: https://drive.google.com/file/d/1lkH7kzBhoc02yFuqiJFkArO5XGoRkgv4/view?usp=sharing After: https://drive.google.com/file/d/1HVNhe0k4rWch1oO6TFFLQkU17SL9fqLg/view?usp=sharing Bug: 856626 Change-Id: I022b5d8b54828855f836e0428d29d0ffde6bcdfd Reviewed-on: https://chromium-review.googlesource.com/1117743Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#570967}
-
Amy Qiu authored
Rename pages in key_noop_cases.py to be consistent with rendering page sets Bug: 847857 Change-Id: I432509b893a0943fd59ee40813fac520eaa59f9a Reviewed-on: https://chromium-review.googlesource.com/1117444Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#570966}
-
Oriol Brufau authored
These properties provide the author with the ability to control borders through logical, rather than physical, direction and dimension mappings. Intent to Implement and Ship: CSS flow-relative margins, paddings and borders https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tkN-r119eNc Spec: https://drafts.csswg.org/css-logical/#border-properties BUG=850000 TEST=external/wpt/css/css-logical/logical-box-border-color.html TEST=external/wpt/css/css-logical/logical-box-border-style.html TEST=external/wpt/css/css-logical/logical-box-border-width.html The tests still have some failures because sideways writing modes have not been implemented yet (http://crbug.com/680331). Change-Id: Ide70c65777ed42e9ef34fbcb2f58ef85f62bad4c Reviewed-on: https://chromium-review.googlesource.com/1092695Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#570965}
-
Tom Anderson authored
BUG=856868 R=sky Change-Id: I4a1059e88aee7d6dadbb277742c770a11c1e7042 Reviewed-on: https://chromium-review.googlesource.com/1117274 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#570964}
-
Khushal authored
R=backer@chromium.org, sunnyps@chromium.org Bug: 854416 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1fef0f0a8468c08fc03500a13ed13f7776466e4f Reviewed-on: https://chromium-review.googlesource.com/1115721Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#570963}
-
Amy Qiu authored
Rename pages in key_idle_power_cases to be consistent with rendering page sets Bug: 847957 Change-Id: I17618ed7d144f657fdd0a7b0503fb3a9376519cc Reviewed-on: https://chromium-review.googlesource.com/1117442Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#570962}
-
Kyle Horimoto authored
Previously, this class was located within the service implementation; however, it should be able to be shared outside (e.g., so that MultiDeviceNotificationPresenterTest can use it). Bug: 824568 Change-Id: Ic59f12b9c0d21597f3ed57d683ae30e98ad99ec5 Reviewed-on: https://chromium-review.googlesource.com/1117774Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#570961}
-
Philip Rogers authored
This patch fixes two bugs where popups were not painted: 1) Popups were not hooked up because the BGPT/SPV2 AttachRootLayer function was not implemented on WebPagePopupImpl. This has been implemented. 2) Popup layers were not painted. Popups are not attached to the viewport layers and were not found via the recursive paint walk. Popups are now special-cased so they are painted. A DCHECK has been added in layer_tree_host to make this sort of bug easier to debug. Instead of NPE in some random layer code, we now DCHECK. Bug: 853951 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia7bbcd4c27f860ada232d28c89ab672d60995aec Reviewed-on: https://chromium-review.googlesource.com/1117216Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570960}
-
Ted Choc authored
Downloaded an offline page, clicked the infobar, and it crahsed using this code path. BUG=789732 Change-Id: I55e18d8b3ab5abe17743f25fe0b090140cb0530f Reviewed-on: https://chromium-review.googlesource.com/1117213Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#570959}
-
Christopher Cameron authored
Tighten the scope of the ScopedCAActionDisabler and add early-outs to avoid creating it when we will not actually change the CALayer tree. This is a speculative fix for leaked blocks, which may be related to CATransactions. Bug: 853438 Change-Id: I6b6985d6b44c33a53021d3af43ebedd0ffd254b9 Reviewed-on: https://chromium-review.googlesource.com/1115869 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#570958}
-
Xianzhu Wang authored
The previous cache skipping mechanism supported cache skipping for some display items of a client while keeping other display items cacheable. Now simplify by making all display items of a client non-cacheable once the client creates some display item that skips cache. Other changes that are required: - PaintRecordBuilder needs a transient-mode PaintController (which doesn't support caching) to avoid the PaintController from altering the cache flags of the painted display items and clients which may be cached in other PaintControllers. - PaintController::AppendDebugDrawingAfterCommit() needs a dedicated client to avoid its cache skipping affect the normal caching of the client. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0baf248074334198a5b8dce889d566bf75cdbf2b Reviewed-on: https://chromium-review.googlesource.com/1115619 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570957}
-
Tiger Oakes authored
Small convenience feature so we don't need to run mkdir first. Also backported to old supersize UI. Change-Id: I96a462ff584992e3b7bff52d43be5706c5f12b31 Reviewed-on: https://chromium-review.googlesource.com/1117713 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#570956}
-
Matthew Jones authored
The overflow menu is no longer necessarily in the top control container. This patch removes the assert and the handle to the button in the control container since it isn't actually used. Bug: 857124 Change-Id: I6d0d7d913c9743f773a8e1a2b563a38c3d9096d9 Reviewed-on: https://chromium-review.googlesource.com/1117306Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#570955}
-
Theresa authored
Add an experimental toolbar button that triggers the contextual suggestions bottom sheet. Currently the auto-peek behavior for the contextual suggestions bottom sheet is not disabled when the toolbar button is enabled. This will be handled in a follow-up CL. BUG=856403 Change-Id: Ic56aeb44f8ce9dc29606a902553d9d25803df40e Reviewed-on: https://chromium-review.googlesource.com/1115352 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#570954}
-
Christian Biesinger authored
This is mostly straightforward, except that on Mac, we may have to compute intrinsic sizes outside of layout. So this patch also adds special code to avoid layout calls in such cases (for orthogonal flows). However, this also required me to change some tests to have the correct "inside of layout" state. Notes on tests: fast/dynamic/012.html Had an incorrect rebaseline; rendering matches legacy modulo text splitting (positioning is the same) css2.1/20110323/table-height-algorithm-023.htm css2.1/20110323/table-height-algorithm-024.htm Parts of these tests were already using the smaller size due to 1px text rendering differences; this rebaseline just makes us more consistent. tables/mozilla/bugs/bug57828.html Also a trivial 1px difference tables/mozilla/bugs/bug60992.html Probably an issue of bug 40634; legacy takes the whitespace before <br> (here, a linebreak) into account for calculating the width of the cell and NG does not. tables/mozilla_expected_failures/bugs/bug1010.html Also 1px and 2px text rendering difference virtual/layout_ng_experimental/external/wpt/css/css-flexbox/flexbox_stf-table-caption.html Fails for an unrelated reason, see newly filed bug 857185 Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia11317acd777aec201702fce28ebab74dba99b4f Reviewed-on: https://chromium-review.googlesource.com/508293 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#570953}
-
Robert Ma authored
The test behaves differently on try bots and CQ bots so it can't be rebaselined automatically. TBR=raphael.kubo.da.costa@intel.com No-Try: True Bug: 857271 Change-Id: I8a1fe9f524cca6cf73370b76bba3d64557ab33f8 Reviewed-on: https://chromium-review.googlesource.com/1117842 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#570952}
-
- 27 Jun, 2018 24 commits
-
-
Nasko Oskov authored
Error page isolation was introduced in https://crrev.com/c/762520 but it had some function bugs (e.g. https://crbug.com/840485). There have been multiple fixes since then and it should be in a shape to try and enable it again. Bug: 838161 Change-Id: Ic3815e26eca9850c14e2cd925ed037223f4ded11 Reviewed-on: https://chromium-review.googlesource.com/1115203 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#570951}
-
Paul Jensen authored
I haven't used the histograms recently. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icb824d66b747f53466c8006ba087003ecd2c7d9b Reviewed-on: https://chromium-review.googlesource.com/1115360Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#570950}
-
Stefan Zager authored
PLSA is the only ScrollableArea subclass that ever gets a non-zero scroll origin. Push all the logic down into PLSA. BUG=823365 R=skobes@chromium.org,bokan@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I163b409a66c8b6d1dd248e51aae843cba109395e Reviewed-on: https://chromium-review.googlesource.com/1114460 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#570949}
-
Chris Blume authored
The existing generate_bindings.py has some duplicate code. This patch will refactor it to reduce duplication. BUG=856360 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9776b291f9d984f252c3223d15e755a41156827a Reviewed-on: https://chromium-review.googlesource.com/1116184 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570948}
-
Ken Rockot authored
Moves all Mach port brokering stuff into the Channel implementation, making it a bit easier to understand. Previously relevant logic was spread over Channel, NodeChannel, and NodeController. This is in preparation for introducing a new PlatformHandleInTransit type to encapsulate a PlatformHandle + ScopedProcessHandle, as a replacement for the weird and sort of unsafe ScopedInternalPlatformHandle usage we have today. Bug: 753541 Change-Id: I7c17fb75d5930d8a8816a2927c8529d75c8b7675 Reviewed-on: https://chromium-review.googlesource.com/1112926 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#570947}
-
edchin authored
This CL implements these additional metrics: Entering/Exiting tab switcher: MobileTabSwitcherPresented MobileTabSwitcherDismissed Selecting panels: MobileTabSwitcherHeaderViewSelectIncognitoPanel MobileTabSwitcherHeaderViewSelectNonIncognitoPanel MobileTabSwitcherHeaderViewSelectDistantSessionPanel Creating, opening, closing tabs: MobileTabSwitcherCreateIncognitoTab MobileTabSwitcherCreateNonIncognitoTab MobileTabSwitcherOpenIncognitoTab MobileTabSwitcherOpenNonIncognitoTab MobileTabSwitcherCloseIncognitoTab MobileTabSwitcherCloseNonIncognitoTab Bug: 818452 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1352eb8e99fb6c044d954a0690f6a2f00c511572 Reviewed-on: https://chromium-review.googlesource.com/1117130 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570946}
-
Amy Qiu authored
Rename pages in tough_compositor_cases to be consistent with rendering page sets. In tough_compositor_cases.json, remove unused pages. Bug: 847857 Change-Id: Iaa697acd52da6389f6367f02910bf92759af606f Reviewed-on: https://chromium-review.googlesource.com/1117467Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#570945}
-
Amy Qiu authored
Rename page names in key hit test cases to be consistent with rendering page sets Bug: 847857 Change-Id: I8f67d1efe34218c01e1d7e3e4a57c6d08e0553d5 Reviewed-on: https://chromium-review.googlesource.com/1117441Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#570944}
-
Stephen Martinis authored
This CL changes the run_gtest_perf_test.py script to output well formed test results json. Bug: 855234 Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796 Reviewed-on: https://chromium-review.googlesource.com/1112635 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#570943}
-
Tarun Bansal authored
Currently, Chromium honors Accept-CH-Lifetime (ACL) header on all responses as long as the origin of the response matches the main frame origin. This CL changes the behavior to honor the ACL header on main frame responses only. Change-Id: I480e7faf3d060ddc9d31220f368d6c2f8b02221f Bug: 856700 Reviewed-on: https://chromium-review.googlesource.com/1115960Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570942}
-
Ryan Hamilton authored
Change-Id: Ib604fe8527aaef33495e5184593a87f47baadab6 Reviewed-on: https://chromium-review.googlesource.com/1115866 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#570941}
-
Pedro Amaral authored
A generic button component to be used in the bottom toolbar. Also migrated the home button to use the generic button component to illustrate how it would be used. Change-Id: Ic02a7c7412ecf3e7ae580396c09ebba39ef96a30 Reviewed-on: https://chromium-review.googlesource.com/1115812Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#570940}
-
Tao Bai authored
Bug: 850652 Change-Id: Ib170181ac3e0d52a0494de2b2ce01662e975e4af Reviewed-on: https://chromium-review.googlesource.com/1117652Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#570939}
-
Weidong Guo authored
Bug: 857195 Change-Id: Id469b5609cde17cf379c421142cedb66fca8e059 Reviewed-on: https://chromium-review.googlesource.com/1117562 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#570938}
-
danakj authored
Use a RenderWidgetCompositor, which is the thing that holds the LayerTreeHost instead of using a replicated test-only thing. This will help to remove the WebLayerTreeView interface. Later RenderWidgetCompositor will move to blink/renderer/platform/graphics, as it is the compositor interface for blink core. Later later maybe we could collapse it into cc::LayerTreeHost maybe. R=dcheng@chromium.org Bug: 838693 Change-Id: I848e13c751cfd11106393efe12e75ac01e4377e0 Reviewed-on: https://chromium-review.googlesource.com/1117463Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#570937}
-
Mugdha Lakhani authored
This event is dispatched when the user taps/clicks on the UI while the fetch is active, has succeeded or has failed. It is not sent when the fetch has been cancelled, or is aborted. Bug: 843081 Change-Id: I86f0cfef6ba4186063c1b5870ea36827972d1d30 Reviewed-on: https://chromium-review.googlesource.com/1112245 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#570936}
-
Sergey Ulanov authored
FIDL is being updated to return status code instead of bool result from sync interface proxies. The new interfaces and classes are suffixed with '2'. Updated code in //base and //net to use the new version. Change-Id: Ic8f59cca996f73b496065e9f1972cf5b8a8240ae Reviewed-on: https://chromium-review.googlesource.com/1117699Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#570935}
-
Giovanni Ortuño Urquidi authored
Adds docs that point to the code that validates the schemas in policy_templates.json and that valides JSON Objects against the schemas in policy_templates.json Bug: 856901 Change-Id: I534c0bf58f4ff581ada4f704fc7ae0b6223f3337 Reviewed-on: https://chromium-review.googlesource.com/1116407Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#570934}
-
Justin Cohen authored
Bug: 844332 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I10b4797e9e189dd03d783642b20352a546a449c2 Reviewed-on: https://chromium-review.googlesource.com/1070515 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#570933}
-
Gayane Petrosyan authored
Change-Id: Iec70e81ccfa00b56cc67c2934ea4df0a9505b0ac Reviewed-on: https://chromium-review.googlesource.com/1117207Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#570932}
-
Tao Bai authored
This patch only fix one violation caused by WebViewChromiumFactoryProvider.initialize() Bug: 857121 Change-Id: Ida7d2b3df4e0e7c96f69e42e0b766dde976b2c3a Reviewed-on: https://chromium-review.googlesource.com/1117268 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#570931}
-
Matthew Cary authored
Where the old UnalignedSharedMemory type is created from a legacy SharedMemoryHandle, this new type is created from a new shared memory API instance of UnsafeSharedMemoryRegion. This changes both the ownership semantics and mapping details from UnalignedSharedMemory: the new UnalignedWritableMapping does not own the region backing the shared memory, and only owns the mapping itself. Because of this, the region is mapped upon construction rather than with a later MapAt call. These changes do not seem to affect behavior in a practical manner. This change also removes the read-only bit. This is no longer meaningful, as only the mapping is owned; in addition the original use of this variable was not correct, as explained in detail in https://goo.gl/HmBYy6. (TL;DR: on some platforms, being read-only is a characteristic of the underlying OS region, and cannot be set in some processes without affecting the protection in all processes. As this behavior is incompatible with usage, this means that sometimes shared memory which has been declared read-only is not, in fact, read-only, and could be exploited by rouge processes). Finally, a the new UnalignedWritableMapping contains a shim constructor which takes a legacy SharedMemoryHandle. The ownership semantics are the same a the region-created version, that is, the handle is *not* owned by the UnalignedWritableMapping instance. This shim allows us to convert all users of this class one-by-one, and confirm that the new ownership semantics are correctly handled. After this is done, the BitstreamBuffer class, which is at the heart of the IPCs involved, can be converted to the new API without needing to change ownership semantics at the same time. See the bug for an overview of the entire process. Bug: 849207 Change-Id: Ibe4bbb48f7bea3fb31728bf98133ede0228b9801 Reviewed-on: https://chromium-review.googlesource.com/1116703Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#570930}
-
Donn Denman authored
Relands this previous CL that had a flaw, with the flaw fixed. Updates the Status Bar to match the scrim color when Contextual Search shows the Overlay Panel. Also updates the FadingBackgroundView to allow no anchor view. BUG=848922,856571 Change-Id: I397ba09dce5aa7be87ecf98ba9faf14293306467 Reviewed-on: https://chromium-review.googlesource.com/1115207Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#570929}
-
Adolfo Victoria authored
Refactor DeviceAutoUpdateTimeRestrictions to use a JSON string instead of a proto. BUG=chromium:852860 TEST=None Change-Id: Ic5174ad705b3cf59dfbbfc5713c231bf7f057a0f Reviewed-on: https://chromium-review.googlesource.com/1109264Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#570928}
-