- 15 Jun, 2020 40 commits
-
-
Kyle Horimoto authored
Bug: 1094896 Change-Id: Ic8e08cca22aa18b607a2aaac0e60974e6913fab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246235 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#778416}
-
Arthur Wang authored
Use WPR binaries from CIPD via gclient sync. Use WPR archives from GCS via gclient runhook. Bug: 1060399 Change-Id: Ice6baa39fd538902545e1125a0ac9fb85d78012f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212790Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#778415}
-
Rakib M. Hasan authored
We were incorrectly looking for the test file's relative path to web_tests/. The test files from test expectations are already relative to the web_tests/ directory. The CL also adds the --only-cleanup-test-expectations command line argument to the wpt_expectations_updater.py script which causes it to exit after cleaning the test expectations. Bug: 1050760, 1050754 Change-Id: I9ca3eefff524151525e50675db1a311872b9e320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243832 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#778414}
-
Etienne Pierre-doray authored
To investigate jank found in UMA sampling profiler. Change-Id: I0579d200c1dd42360cab210fe06886fbd366ace8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241636Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#778413}
-
Devlin Cronin authored
Flip the Extensions Menu to be enabled by default. Since the feature is still controlled via Finch, this won't turn it on for everyone if they are part of different experiment groups, and we'll still have a safety hatch if we need it. Bug: 943702 Change-Id: Iae0029bce006e2bb0506f91664696dc7c457fd8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238514Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#778412}
-
Robert Flack authored
This reverts commit d0332c34. Reason for revert: Introduced failure on browser_tests DiscardsTest.All First failure here: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19162 [9313:9313:0615/094609.344774:INFO:CONSOLE(1065)] "Running TestCase DiscardsTest.All", source: file:///b/s/w/ir/chrome/test/data/webui/test_api.js (1065) [9313:9313:0615/094609.353925:WARNING:CONSOLE(34)] "Error: Assertion failed: Unsupported sort key: canFreeze at assert (chrome://resources/js/assert.m.js:26:19) at assertNotReached (chrome://resources/js/assert.m.js:64:3) at compareTabDiscardsInfos (chrome://discards/discards_tab.js:73:3) at chrome://test/discards/discards_test.js:42:22 at Array.forEach (<anonymous>) at Context.<anonymous> (chrome://test/discards/discards_test.js:41:10) at callFn (file:///b/s/w/ir/third_party/mocha/mocha.js:5342:21) at Test.Runnable.run (file:///b/s/w/ir/third_party/mocha/mocha.js:5334:7) at Runner.runTest (file:///b/s/w/ir/third_party/mocha/mocha.js:5990:10) at file:///b/s/w/ir/third_party/mocha/mocha.js:6108:12", source: chrome://resources/js/assert.m.js (34) [9313:9313:0615/094609.364579:ERROR:CONSOLE(49)] "Mocha test failed: discards CompareTabDiscardsInfo Error: Assertion failed: Unsupported sort key: canFreeze at assert (chrome://resources/js/assert.m.js:26:19) at assertNotReached (chrome://resources/js/assert.m.js:64:3) at compareTabDiscardsInfos (chrome://discards/discards_tab.js:73:3) at chrome://test/discards/discards_test.js:42:22 at Array.forEach (<anonymous>) at Context.<anonymous> (chrome://test/discards/discards_test.js:41:10) ", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (49) Original change's description: > Remove support for Tab Freezing > > This feature has been abandoned. > > Bug: 844426 > Change-Id: I777dcb72edd7941778374cc2fbff1e2c966bdac1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239374 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#778280} TBR=avi@chromium.org,kenrb@chromium.org,fdoray@chromium.org,asvitkine@chromium.org,wfh@chromium.org,sebmarchand@chromium.org Change-Id: I3dafddea7f11bffea171cd8a80ea51368943dd83 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246920Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#778411}
-
Mansi Awasthi authored
This CL refactors PdfAccessibilityTree::AddPageContent() by moving out the object node creation logic to the new helper class PdfAccessibilityTreeBuilder. Bug: 1030242 Change-Id: Ic8cc356fa9445de1e6f4c599d6375d721e025198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241191Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#778410} -
Brandon Wylie authored
Bitmap capturing is enabled in ActivityTabProvider.ActivityTabTabObserver methods: - onUrlUpdated (called when the URL is updated) - onShown (called when a tab is selected from the tab switcher) These methods aren't called when returning to a tab from a theme change. If the URL isn't updated and the tab isn't selected through the tab switcher, the bitmap capturing won't be enabled. This change supports bitmap capture when swiping through tabs after changing the theme. Bug: 1091643 Change-Id: Ife285cac48c20c3db4f7450800bba7cec2d27db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236070 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#778409}
-
Ian Prest authored
This is a re-land of https://codereview.chromium.org/1754143002 that was reverted for causing a performance regression in Blink's "layout/character_fallback.html" test. After discussion, we've concluded that the benefits of switching fonts outweigh the performance impact. Original description follows: Following the change for Japanese in crrev.com/379189, this patch changes Chinese system font fallback list for Windows to prefer more modern, post-ClearType era fonts. This change improves font rendering of generic font families and system fallback on Windows for Chinese characters, both simplified and traditional. Results of Win10 failures where this change affects are reviewed. All these failures on Win10 are due to changes in fonts and rebaseline should fix them. Their failure expectations are removed in this patch. (Edit: Tests rebaselined with "rebaseline-cl" in this re-land.) Change-Id: Ie2916f31f5518f087afe8060fe042a49e87715b5 Bug: 579842, 587072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241858Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#778408}
-
John Williams authored
Bug: b/158102244 Change-Id: Ide4ddfe7b45dcd26dcfd072c1725aa931f91d0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241933 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#778407}
-
Kristian Kirs authored
GCC complains about it Change-Id: I4c5ffcc66225c895efde77a77c83342d6794b5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246170Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#778406}
-
evliu authored
This CL integrates the WebRTC audio renderer with the live captioning pipeline, allowing the Chrome browser to automatically generate captions from the audio rendered by the WebRTCAudioRenderer. The high-level design document for the Live Caption feature can be found at: go/chrome-live-caption. Bug: 1093096 Change-Id: Ieda2fd157828cdb50a89edc694db58a0958de189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238992 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#778405}
-
Stephen McGruer authored
Bug: None Change-Id: Ic6f6068da5df1336bac63524489eeccd8ff8ed12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246619Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#778404}
-
Nektarios Paisios authored
In https://crrev.com/c/2082360, AXPosition's AtStart/EndOfLine algorithms were modified so that positions would never be marked as being at start of line when they were at the end of their text span. For example, a position at the end of a text field, even when there is some white space at the end of that text field, would never be marked as at start of line because the text field creates some kind of text boundary. The same for any white space at the end of a static text object. On the contrary, if some white space only object is not connected to the next line via kNextOnLineId, and that white space is in the middle of a text span, e.g. in the middle of a static text object, then that white space always represents a soft line break. While writing the above patch, it was noticed that there existed the possibility of an infinite loop between AXPosition::AtStartOfLine -> AXPosition::CreateParentPosition -> AXPosition::AtStartOfLine ... To prevent such an infinite loop, a seamingly redundant condition was added to AXPosition::AtStartOfLine, around line 540, which would ensure that a position was AtEndOfAnchor() in addition to it not being ATEndOfTextSpan(), before deciding that the position was pointing to after some white space that had caused a soft line break during layout. Unfortunately, due to the order of evaluating these conditions, the infinite loop was being caused before AtEndOfAnchor() had a chance to execute. R=dmazzoni@chromium.org Bug: 1085138 Change-Id: I7e4262f9996407e52de12e731a900bb8f765c0cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245611Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#778403}
-
Akihiro Ota authored
This is a reland of http://crrev.com/c/2194345. The original change was causing build errors, which are document in the following bug: crbug.com/1093048 These issues were fixed by the following change, which makes it safe to reland this: http://crrev.com/c/2242193 TBR=dmazzoni@chromium.org, dtseng@chromium.org Original change's description: > Prototype for ChromeVox tutorial. > > This change does the following: > 1. Adds an interactive tutorial polymer component > 2. Adds a lesson polymer component > 3. Adds html files used to define the test areas for interactive > lessons. > 4. Ports over some content from the existing tutorial into the new > one. > 5. Connects the interactive tutorial to the ChromeVox panel. > 6. Wait to send commands to the panel until the panel has loaded. > Connecting the tutorial to the panel was increasing the panel load > time, which was causing us to fail panel-related tests. > 7. Compiles ChromeVox using ES_NEXT rule to support async panel > command behavior; errors were fired when trying to compile using ES6. > > Bug: 1075752 > AX-Relnotes: N/A > > Change-Id: I7589a1d81185cba93242a1e419da4bd466351f9b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194345 > Commit-Queue: Akihiro Ota <akihiroota@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776153} Bug: 1075752 Change-Id: I6aa5c7ca695ab2b80cf4b0c3285e5ec00db46bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246544 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#778402}
-
gogerald authored
Screenshot: https://drive.google.com/file/d/1_g3SYeCLpNEYzpbWOmw4H1MUguUf5n86/view?usp=sharing Bug: 1091986 Change-Id: Ic4b0d4042af97eab5fa922e8b308c32dcf8ee4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240958 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#778401}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id0467e2fbbe92f0fea30b7f1e0e25ff3f4b8c938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246627Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778400}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/efb5e1e501fe..2c6b51469688 2020-06-15 zhin@chromium.org Add ChainExpression to ESTreeWalker 2020-06-15 pfaffe@chromium.org [wasm debugging] Fix lookup of llvm-lit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083214 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibd9fed4c0ef6472926cd610422d7fbb2ae0a7446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246779Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778399}
-
Koji Ishii authored
Following bot results are included. 2416 2419 2420 2422 2423 2426 2427 2428 2432 2437 2438 2439 2440 2441 2445 2446 2447 2449 2451 2452 2453 2454 2455 2456 2460 2462 2466 2467 2468 2470 2472 2473 2474 2475 2476 2477 2478 2479 2480 2481 2482 2483 2484 2485 2486 2487 2488 2489 2492 2493 2494 68 lines were removed and 9 lines were deflaked by consecutive results since 2477. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Iddfd384fe6546f94274ff40e25c5f9ff24abdb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228743Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#778398}
-
Devlin Cronin authored
The Extensions Menu doesn't support highlighting mode. This is currently not used when the menu is turned on. Add a NOTREACHED() to provide extra coverage, and document that it's not supported. Bug: None Change-Id: I5fae8ff584b61bb1eb73c993d104a38f65f0fd53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240314Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#778397}
-
Tao Bai authored
The AutofillPopup is used for displaying the datalist options only. The most of implementation was copied from AwAutofillClient, we intentionally used the same UI as AwAutofillClient to avoid any new UI change for WebView. The integration test was added to verify the popup work. The ForTesting method isn't called in production code, per discussion on https://chromium-review.googlesource.com/c/chromium/src/+/2244459 Using No-Try to bypass the android-binary-size check failure Bug:949555 hange-Id: Id8537b6232edca09e243e807cf8f20e5a3bfc5f3 Change-Id: Id8537b6232edca09e243e807cf8f20e5a3bfc5f3 No-Try: True Change-Id: Id8537b6232edca09e243e807cf8f20e5a3bfc5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242209 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#778396}
-
Becca Hughes authored
We already check the feed items against Safe Search but we should also check the feed itself so we can avoid fetching the feed if it is unsafe. BUG=1085095 Change-Id: I8546c372e6915512c7bb5ddde8ce379cb8cd14c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220275Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#778395}
-
Ben Pastene authored
Without this, a normal Linux task has a chance of running on arm bots: https://chromium-swarm.appspot.com/task?id=4cd1d72b8cf8ff10 With this, the same task is pinned to x86 bots: https://chromium-swarm.appspot.com/task?id=4cd1db29a5e74c10 Bug: None Change-Id: I81af787d1533f0e97970ee14d56efc7a07c4ecb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244038 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#778394}
-
Lijin Shen authored
Very flaky on builder "android-pie-arm64-rel". TBR=elklm@chromium.org, andypaicu@chromium.org Bug: 1094934 Change-Id: Iefa01b59a799caafd407d48bc62453c1f9a09e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246741Reviewed-by:
Lijin Shen <lazzzis@google.com> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#778393}
-
Thomas Anderson authored
This reverts commit 9b8d92b3. Reason for revert: Regresses keyboard input Original change's description: > [XProto] Implement event reading > > This CL implements a parser from wire events to XProto events. Nothing > is currently done with the events; this will be done in followups. > > BUG=1066670 > R=nickdiego,sky > CC=msisov > > Change-Id: Ica0982298bf84e6a3ddbed77a5a6f6a3288bcaf7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233610 > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Nick Yamane <nickdiego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#778344} TBR=sky@chromium.org,thomasanderson@chromium.org,nickdiego@igalia.com Change-Id: I0fef1ee54c9d139ed499f090e39bc52a2c904b96 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246827Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#778392}
-
Victor Hugo Vianna Silva authored
This CL replaces the instances of this string in documentation with "account-scoped password storage", for consistency with other pieces of documentation. TBR=stevenjb@chromium.org TBR=mamir@chromium.org Bug: None Change-Id: Idf39b6f2a74578446d7b9ad99bd91fc3eae19781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246681 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#778391}
-
Nigel Tao authored
The base::JSONReader::Read method is a static method. AX-Relnotes: n/a Bug: 1070409 Change-Id: I4fd621bf3cb26e4d080631559042b6ba8a712ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244771 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#778390}
-
Maks Orlovich authored
Haven't gotten the chance to fix the remaining inconsistencies yet, though there is a testcases that may help now. Bug: 1089019 Change-Id: I5f048e7ad376fa8aa0ed6a60f8f0dbed15848d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246549Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#778389}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7a675165..99e196c0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I24f6043f888a5fad72dc5fa1abbf14eca1f4ce79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246396Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778388}
-
Nina Satragno authored
Remove device/fido files from the android build that aren't being used. This will improve compile and test times in android. This also required moving the implementation of cable_discovery_data into its own cc file and #ifdef'ing GetWebAuthenticationRequestDelegate. Fixed: 1091868 Change-Id: I94b43b083cd719db5cdbdff47c7067f9dde5f2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238350 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#778387}
-
Nick Diego Yamane authored
This CL simplifies a bit the pointer focus handling API and implementation, so focused window is not required to "clear pointer focus", since it is not always available in some cases, e.g: context menus or when handling focus changes in window moving sessions (i.e: data device events) that should be sent soon. Bug: 896640 Change-Id: Ica19980e510981a2d06723575f58fa30ffad7175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242679 Commit-Queue: Maksim Sisov <msisov@igalia.com> Auto-Submit: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#778386}
-
Nicolas Arciniega authored
The CPU Info part of the UA string was recently accidentally changed from "(Windows NT)" to "(Windows NT; )" on Windows architectures where we don't have a CPU type. This change fixes that and adds some UA string unit tests to help detect similar changes in the future. Bug: 1093636 Change-Id: I4fb62cb00256936d0cb8d480b7f7297c65735e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242083Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Cr-Commit-Position: refs/heads/master@{#778385}
-
Robert Ogden authored
Uses the isolated network context with the connect proxy for requests that go through the proxying url loader factory during a NSP. Resources on origins with cookies are disabled from using the cache. Note that this is not yet tested because there's no logic to use the cached resources after the user clicks on a prefetched link. Bug: 1082505 Change-Id: I631fd58bbf6a31f96b9fe545383538cebe6e1c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236757Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#778384}
-
Kai Ninomiya authored
Bug: 498797 Change-Id: I78f40e1c78bd339b99b466d72dbe051e56f7dfaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243440 Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#778383}
-
Sylvain Defresne authored
Instead of using a int64_t to pass the output of base::Time::ToTimeT, pass a proper typed base::Time value to InitializeFirebase. Bug: none Change-Id: Idfb4dcf3ba9e54daaf882f5bbcad9bda61e4e739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246582 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#778382}
-
Numfor Mbiziwo-Tiapo authored
This adds a put test for indexedDB that inserts records into 2 different object stores. Each record contains values that vary in size. Change-Id: Iac672ea57ccca3ed628ffee2368b8174453526df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240875Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#778381}
-
Kristian Kirs authored
Otherwise assertation fails in ui/gfx/x/BUILD.gn //ui/gfx/x dependency has already been added under appropriate condition Change-Id: I5b2efa28b31b88b53ca31035e358bf9bdd4331eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246164Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#778380}
-
Katie D authored
DomDistillerViewerSourceBrowserTest::UISetsPrefs is flaky. In the previous reland of this test, a base::RunLoop()::RunUntilIdle() was removed. This adds that back in. See crrev.com/c/2207750/1..7/ Also some clean-up of an unused var, with no no impact in DistillerJsRenderFrameObserver. AX-Relnotes: N/A Bug: 1064776 Change-Id: I990417bac8ff2af948dd9b27f05269cd3d036086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240010 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#778379}
-
Robert Flack authored
This reverts commit a53560e3. Reason for revert: Suspect this caused marker elements in blink expectations to disappear First failing build: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/15587 Blink web test failures: https://test-results.appspot.com/data/layout_results/WebKit_Linux_Leak/15587/blink_web_tests/layout-test-results/results.html Original change's description: > [css-pseudo] Set default ::marker styles in a real UA sheet > > Before this patch, default styles for ::marker were assigned manually > when resolving the style. The problem was that, since the rules didn't > actually exist in any stylesheet, they were not exposed in devtools. > Also, devtools assume that if a pseudo-element exists, it must have some > rule. This could not hold for ::marker, and then trying to add styles > to it would fail. > > This patch fixes that by making the styles actual UA rules. However, > adding a '::marker' selector directly to the UA sheet for elements would > be bad: it would match every single element (even non-list-items) due to > the universal selector, and then it would set an internal bit for the > marker. So HasAnyPseudoElementStyles() would return true, which means > extra work when handling style changes. > > Therefore, this patch adds a new UA sheet just for pseudo-elements. This > sheet is not used for elements, ensuring that HasAnyPseudoElementStyles > is still false if there are no author styles for a pseudo-element. > > The selector parser was treating ::marker as invalid if the runtime flag > CSSMarkerPseudoElement was disabled. But now it's accepted in that case > for UA styles. > > There already was a kHasMarkerPseudoElement counter to track how widely > used is ::marker on the web. Now this counter will only be incremented > for author rules. > > Bug: 457718, 1082377 > > TEST=blink_unittests --gtest_filter=StyleResolverTest.CSSMarkerPseudoElement > TEST=blink_unittests --gtest_filter=UseCounterHelperTest.CSSMarkerPseudoElementUA > TEST=blink_unittests --gtest_filter=UseCounterHelperTest.CSSMarkerPseudoElementAuthor > TEST=http/tests/devtools/elements/styles-2/pseudo-elements.js > > Change-Id: Ib5583dc1952bfec2cce8f33fe8332cc39016c34a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239579 > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Oriol Brufau <obrufau@igalia.com> > Cr-Commit-Position: refs/heads/master@{#778303} TBR=mkwst@chromium.org,futhark@chromium.org,andruud@chromium.org,obrufau@igalia.com,yoavweiss@chromium.org Change-Id: I372feba40cccb0a6e028c5480cd81ec421fa7a57 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 457718, 1082377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246860Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#778378}
-
Eric Roman authored
Change-Id: Iff347963479a62f511947f334dafe064d6cd8523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242743Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#778377}
-