- 02 Aug, 2017 40 commits
-
-
Stanislav Chiknavaryan authored
This applies only to code running under D3DVsync experiment. My experiments show that increasing the GPU V-sync worker thread priority has a noticeable impact on latency on the GPU process side, even before the v-sync signal is sent over IPC to the browser. The tables below show the deltas (in us) between the adjusted DWM v-blank timestamp and the now() time when on the thread wakeup on v-blank. This was tested on a consumer grade DELL XPS laptop with 4 cores. With the current DISPLAY priority the distribution looks like this: < 0 9.8% 0-99 78.7% 100-199 4.8% 200-499 1.7% 500-999 2.2% 1000-1999 1.4% 2000-4999 1.0% 5000-9999 0.4% 10000+ <0.1% With the higher REALTIME_AUDIO priority the distribution looks much improved with a much steeper drop after 200 us: < 0 8.6% 0-99 82.4% 100-199 8.5% 200-499 0.2% 500-999 0.2% 1000-1999 <0.1% Bug: 751340 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I082d4561e6b27fc23e2242a9023c19d6787492fd Reviewed-on: https://chromium-review.googlesource.com/596625Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Stanislav Chiknavaryan <stanisc@chromium.org> Cr-Commit-Position: refs/heads/master@{#491528}
-
Raymond Toy authored
When firing the completion event make sure the document exists before we try to get the rendered buffer that needs to be returned. Bug: 751377 Change-Id: Id956f5a287b6b91b7bad04d85b6c8f3c32c9470d Reviewed-on: https://chromium-review.googlesource.com/598727Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#491527}
-
Hiroshige Hayashizaki authored
This CL moves SubresourceIntegrity calls to Resource, just before CheckNotify(), where Resource::Data() is always available. This makes - SubresourceIntegrity always checked if integrity metadata is set, and - SubresourceIntegrity and ResourceIntegrityDisposition control not depend on ResourceClients (ClassicPendingScript and LinkStyle). This removes Resource::SetIntegrityDisposition(), and and unblocks https://chromium-review.googlesource.com/c/562859/. This CL also makes Resource cache SubresourceIntegrity::ReportInfo in Resource, and thus outputs SRI console error messages and update UseCounters for every classic script and stylesheet that shares a Resource, not only for the first use (Issue 585267). Bug: 746115, 701943, 585267, 653502 Change-Id: I03e7c22319980bd297cb5d9fb58589966a0b2f71 Reviewed-on: https://chromium-review.googlesource.com/576950Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#491526}
-
Wez authored
BUG=750917 Change-Id: Ia6a2f446a6ae8ec0228c12f587756561df0e6051 Reviewed-on: https://chromium-review.googlesource.com/597376 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#491525}
-
Tim Song authored
BUG=751783 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifefe73dbc4039201f32fef25fa48f04541d6af20 Reviewed-on: https://chromium-review.googlesource.com/598436Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#491524}
-
Tom Anderson authored
BUG=751812 R=thestig@chromium.org Change-Id: Ied009e9839bffced122137616b6bc3bcc7b337f0 Reviewed-on: https://chromium-review.googlesource.com/598945 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#491523}
-
Devlin Cronin authored
Update the ExtensionDownloader class to use the new task scheduling API, as well as the dedicated Extensions-related file task runner. Bug: 689520 Bug: 750122 Change-Id: I201adece7ae5d5f7a24f535faa86958d4fcff632 Reviewed-on: https://chromium-review.googlesource.com/594833Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491522}
-
James Cook authored
This reverts commit 875aa3d7b80dd3d6a2f0a265d4ca1875b502abc6. Reason for revert: Breaks the M61 branch build cc -o obj/ash/ash/voice_interaction_overlay.o ../../ash/shelf/voice_interaction_overlay.cc:170:43: error: no member named 'since_origin' in 'base::TimeTicks' uint64_t now = base::TimeTicks::Now().since_origin().InMilliseconds(); Original change's description: > Add animated voice interaction icon. > > BUG=b:62276007 > TEST=build flash locally, see animation as spec > TBR=xiaohuic@google.com > > (cherry picked from commit cc92f7ae) > > Change-Id: I5542b68e084fe465c2f8b424b521c8faef51f686 > Reviewed-on: https://chromium-review.googlesource.com/585245 > Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#490447} > Reviewed-on: https://chromium-review.googlesource.com/595143 > Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> > Cr-Commit-Position: refs/branch-heads/3163@{#198} > Cr-Branched-From: ff259bab-refs/heads/master@{#488528} TBR=kaznacheev@chromium.org,oshima@chromium.org,xiaohuic@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:62276007 Change-Id: Ie8e554ca79f054e0e4d18621402123455950aa9c Reviewed-on: https://chromium-review.googlesource.com/597071Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3163@{#229} Cr-Original-Branched-From: ff259bab-refs/heads/master@{#488528}(cherry picked from commit 020cdf35035e30942aa34ca571fce561bff18cf6) Reviewed-on: https://chromium-review.googlesource.com/598507 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#491521}
-
Dominic Mazzoni authored
This is part of the TaskScheduler migration, see the linked bug and various messages on chromium-dev for context. Bug: 689520 Test: flashed to Chromebook, plugged in braille display. Change-Id: Id7f196ba58d5e013c516e63266d47f9307e4d2d1 Reviewed-on: https://chromium-review.googlesource.com/589776 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#491520}
-
Yuwei Huang authored
When rotating the screen on iPad with the keyboard showing, for some reason the host view will become improperly laid out. Part of the view gets overlaid by the keyboard. My suspicion is the view frame becomes inconsistent when the rotation happens. This CL fixes the problem by reworking the keyboard layout using constraints. It also makes GLRenderer cache the view size before the canvas is created. Bug: 751273 Change-Id: I5146ff6bf602eef1857259e5e50ca6be1d952a68 Reviewed-on: https://chromium-review.googlesource.com/596913 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#491519}
-
Scott Violet authored
Currently creation of DiscardableSharedMemoryManager is controlled by whether the ServiceManager is remote. Rather than have content make this decision this patch adds a parameter that lets the consumer of content control if DiscardableSharedMemoryManager should be created. This control is important for a config of ChromeOS where we want content to create DiscardableSharedMemoryManager. This is needed to avoid shutdown races as the implementation details of DiscardableSharedMemoryManager assume DiscardableSharedMemoryManager is shutdown shortly before process exit. I'm doing this as a precursor to having ServiceManager run in process in a config of ChromeOS (ash and chrome in same process), but this is the source of some existing flakiness. BUG=750390 TEST=covered by tests Change-Id: Ia16e27b2cf85e7129819602e5acb889a21ac0a46 Reviewed-on: https://chromium-review.googlesource.com/595209 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#491518}
-
Tom Anderson authored
BUG=598931 R=thestig@chromium.org Change-Id: I0469f7a8e047556d23e387bd7193a4c529195b20 Reviewed-on: https://chromium-review.googlesource.com/598941 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#491517}
-
Brett Wilson authored
TBR=ajwong@chromium.org Change-Id: I9e4ea0a25c9dbf39dce5e07148b177aea8dd64b9 Reviewed-on: https://chromium-review.googlesource.com/598736 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#491516}
-
Devlin Cronin authored
Update the echoPrivate API to use the new task scheduling API, as well as the dedicated Extensions-related file task runner. Bug: 689520 Bug: 750122 Change-Id: Ie6d403cb700c71bc9faabd828b2f40f0826f85bd Reviewed-on: https://chromium-review.googlesource.com/598464 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#491515}
-
sunxd authored
We do not compute a mask layer's draw transform because the target is amubiguous for a mask layer. However when we compute mask layer's occlusion in PictureLayerImpl::AppendQuads, the code treats mask layer as a normal picture layer and uses default transform instead of the real transform. This CL makes PictureLayerImpl::AppendQuads use mask layer's render target's draw transform when computing occlusion. Bug: 747883 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idc0de7674084df04df1f77e8726d3753f6877bf9 Reviewed-on: https://chromium-review.googlesource.com/594680Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#491514}
-
Bret Sepulveda authored
This patch removes all references to BrowserThread::FILE and updates the tests to handle the fact that the shortcut manager is now truly multithreaded. Bug: 689520 Change-Id: I31d145c6ac1685b150a57523d2268796a351f238 Reviewed-on: https://chromium-review.googlesource.com/582367Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#491513}
-
Sammie Quon authored
This CL does: 1) Keeps the confirm button disabled until something has been entered. 2) Enables the confirm button after a new digit has been pressed after a wrong PIN has been entered. 3) Focuses and highlights the wrong PIN after one has been entered. Test: browser_tests "CrSettingsPeoplePageSetupPinDialogTest.*" Bug: 751079,751312 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ife71bc02f6955a819cbb65f9d937eb6dd4a78863 Reviewed-on: https://chromium-review.googlesource.com/596922Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#491512}
-
Eric Stevenson authored
Bug: 683256 Change-Id: I3371e15bb4b0396c56ab4a4963c0c820d33674cf Reviewed-on: https://chromium-review.googlesource.com/590495 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#491511}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/aea80dcc0abc..b4fee4d5d471 $ git log aea80dcc0..b4fee4d5d --date=short --no-merges --format='%ad %ae %s' 2017-08-01 thestig Add CFFL_TextField class. 2017-08-02 rharrison Rewrite how string Insert() methods handle out of bound indices 2017-08-01 thestig Pass a CPDF_ImageObject* into CPDF_ImageRenderer::Start(). 2017-08-01 thestig Remove unused CPDF_FlateEncoder ctor. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Iff28e841bf4468ee842f2ba268cb96f353f6c203 Reviewed-on: https://chromium-review.googlesource.com/598927 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491510}
-
Weiliang Chen authored
When copying DrawQuad to a RenderPass, the SharedQuadState should already be on that RenderPass. Do not take SharedQuadState* as input parameter for copying DrawQuad, use the last SharedQuadState on the RenderPass instead. This not only avoids invalid SharedQuadState* being passed in, but also reinforce that SharedQuadState and DrawQuad are appended in order so it satisifies assumption for future implementation of iterator after SharedQuadState id. R=danakj@chromium.org Bug: 739429 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I63fc2ca7a250fb8f6f9056473e0c6ab046652018 Reviewed-on: https://chromium-review.googlesource.com/597228Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#491509}
-
Elliot Glaysher authored
Bug: 750642 Change-Id: Ib2b7167048a75a3b97e7df80ea21d1ca30ae5b1a Reviewed-on: https://chromium-review.googlesource.com/598459Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491508}
-
Brian White authored
When memory blocks are found by iteration, it is synchronized. When the blocks are passed directly by reference, those references need acquire/release semantics. Bug: 749328 Change-Id: I87c8888cc2153ab027ee51791fd64d095b1d59e8 Reviewed-on: https://chromium-review.googlesource.com/596273Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#491507}
-
Tom Anderson authored
This CL fixes: * Parsing the release file to obtain the desired SHA256 sum when there are multiple hash algorithms listed in different orders. * Removes a list of directories to relativize symlinks and replaces it with a direct check on the directory nesting. BUG=751812 R=thestig@chromium.org Change-Id: If3692f0633ba7ad059ab3c7d0945f4b7ef11786e Reviewed-on: https://chromium-review.googlesource.com/598931Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#491506}
-
Vadim Tryshev authored
Entering guns&roses currently searches for "guns" only because &roses is treated as another query param. Now escaping the query value. I had to convert the query to UTF8 so that I could pass it to the escaping function. I checked that Unicode characters are not lost, and searching for 猫 still finds a cat. Bug=712331 Change-Id: I1b8359e9cb24efb00e1d38322e0ef4c20747cf93 Reviewed-on: https://chromium-review.googlesource.com/595160Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Vadim Tryshev <vadimt@chromium.org> Cr-Commit-Position: refs/heads/master@{#491505}
-
Emily Stark authored
As of https://codereview.chromium.org/2926803002, when navigating to an existing entry, the new navigation's SSLStatus remains unchanged from the existing entry. This is incorrect for content status flags, which depend on the content of the page; navigating to an existing entry does not mean that the content on the page is the same as it was when we navigated away from the existing entry. For this reason, this CL clears content status flags when a navigation commits. Any content status flags that do apply to the new navigation should be re-added as the content on the page loads. Bug: 750649 Change-Id: I41441c90ddeb85b6cbf35e4b102ce322cffb7db9 Reviewed-on: https://chromium-review.googlesource.com/597488Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#491504}
-
Yuke Liao authored
testRotation, testOmnibox and testScrollToolbar fail on iPhone 6 Plus, iOS 10, and this CL disables them on iOS 11 to unblock running the test case on iPhone 6 Plus, iOS 11. Bug: 751803 Change-Id: Ibcda582e2f86617b1fcea89a5296dde182b9b81c Reviewed-on: https://chromium-review.googlesource.com/598646Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#491503}
-
Brian White authored
There are checks inside the PMA that limit any passed size to whatever was defined when the memory segment was created. But that could be wrong if the segment is corrupted. Bug: 749223 Change-Id: Ib0f5416e4c43b597b15e2cb05b3787677e5c0ea1 Reviewed-on: https://chromium-review.googlesource.com/596487 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#491502}
-
Will Chen authored
F/u from https://chromium-review.googlesource.com/c/595238 Bug: 667560 Change-Id: I4e387fae79ab4de0965f84a045c4fd04631b9e7d Reviewed-on: https://chromium-review.googlesource.com/597312 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491501}
-
Yuzhu Shen authored
BUG=699569 Change-Id: I0697f40e286a3ea7fbcccff3c02a605abc7bd8c5 Reviewed-on: https://chromium-review.googlesource.com/592280Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491500}
-
erikchen authored
This is a reland of f5345de1. The problem with blink trybots was fixed: https://bugs.chromium.org/p/chromium/issues/detail?id=669240#c45 Original change's description: > Bump macOS SDK to 10.12. > > Bug: 669240 > Change-Id: I97cf582b97fac7aec2aa92bbdda02f5c17482c1d > Reviewed-on: https://chromium-review.googlesource.com/570459 > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491060} Bug: 669240 Change-Id: I73b54eedbd0eab105adecfb6e817de8aa2b968ef TBR: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/598670Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491499}
-
erikchen authored
Users who specify an 'ios' solution in .gclient will pull the iOS toolchain. This is used by 'ios' bots to pull the toolchain. But macOS developers who happen to specify an 'ios' solution will also pull the iOS toolchain. This CL is a temporary hack to work around this: if the machine appears to be a corp machine, always pull the macOS toolchain. Bug: 742527 Change-Id: Ic49785078f0e15c06f44f61a0daab54dd552ec9e Reviewed-on: https://chromium-review.googlesource.com/598776Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491498}
-
David Bokan authored
Th eoverlay scrollbar fade delay determines how long a period without scrolling will cause the scrollbars to fade out. It also determines how long the mouse must hover over the scrollbar area before it fades in. The fade delay is currently set to 1000ms. In practice, this feels a little long and difficult to discover that the scrollbars appear when the mouse hovers near the page edge. Reducing it to 500ms to see how= that feels Bug: 307091 Change-Id: I463b086fc17c5166e009f2440258e1e1fdf808f9 Reviewed-on: https://chromium-review.googlesource.com/598116Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491497}
-
Wez authored
TBR: dcheng Change-Id: I3865d168844f7abc94ceb2ee9c07171d4da690a8 Reviewed-on: https://chromium-review.googlesource.com/597470 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491496}
-
Hiroshige Hayashizaki authored
This makes PrepareScript() return true (previously returning false) for a classic inline script blocked due to CSP (*). This causes |script_element_ = nullptr| only in XMLDocumentParser::EndElementNs() and thus no behavior changes, because this return value is only used in EndElementNs(), and ReadyToBeParserExecuted() and WillBeParserExecuted() are false in such (*) cases. Bug: 686281 Change-Id: If9bb3f9dc89ba46efd6c24a24fc8727a0174c403 Reviewed-on: https://chromium-review.googlesource.com/564200Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#491495}
-
Will Chen authored
Bug: 667560 Change-Id: I1e41ec9991ef0c1aff5acb3ccc177318fd2c79bd Reviewed-on: https://chromium-review.googlesource.com/595238Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#491494}
-
Scott Nichols authored
Change-Id: Ifcb9b811b00bf009a202196623430a9d30d25c65 Reviewed-on: https://chromium-review.googlesource.com/596609 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#491493}
-
Hiroshige Hayashizaki authored
To make it clearer that ExecuteScriptBlock() is the single entry point of script execution by removing the similarly-named ExecuteScript(), which is now only called from ExecuteScriptBlock(). No behavior changes. Bug: 686281 Change-Id: I0e2bcdcf05cc9c3141398a3a465fa6fb268b0913 Reviewed-on: https://chromium-review.googlesource.com/564301Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#491492}
-
chaopeng authored
Revert of Disable hover state change for touch event on page with viewport meta and mobile. (patchset #5 id:80001 of https://codereview.chromium.org/2931433002/ ) Reason for revert: Revert for some website break. Original issue's description: > Disable hover state change for touch event on page with viewport meta and mobile. > > This patch prevent hover state change for touch event on mobile. > > We have 2 checks for this: > 1. Event is from touch. > 2. Viewport enabled (on mobile). > 3. Page with viewport meta. > > BUG=369044 > Review-Url: https://codereview.chromium.org/2931433002 > Cr-Commit-Position: refs/heads/master@{#478777} > Committed: https://chromium.googlesource.com/chromium/src/+/876bb220728d85b1c8a8fe93a0a95bafcf448cd6 TBR=bokan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=369044 Review-Url: https://codereview.chromium.org/2991253002 Cr-Commit-Position: refs/heads/master@{#491491}
-
Chong Zhang authored
According to the latest spec we should filter non-glyph modifiers if the produced characters are part of Unicode 'Other, Control' General Category. e.g. http://www.fileformat.info/info/unicode/category/Cc/list.htm This patch changes implementation to match spec and fixes issues on 'Dvorak - QWERTY Command' layout. Spec: https://w3c.github.io/uievents-key/#selecting-key-attribute-values Bug: 747358 Change-Id: I792b472132ea6deb4213206593136343a2050ccd Reviewed-on: https://chromium-review.googlesource.com/585638Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491490}
-
Jun Cai authored
This is a follow-up CL for: https://chromium-review.googlesource.com/c/591467 This CL updates documentation for LINEAR_ACCELEROMETER on Windows. Bug: 741315 Change-Id: Id79a4fd5292dc084a2c373daa1b86650b00714cf Reviewed-on: https://chromium-review.googlesource.com/598637Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#491489}
-