1. 31 Oct, 2017 27 commits
    • Aaron Leventhal's avatar
      Table column headers not exposed appropriately in Mac accessibility · e30fa136
      Aaron Leventhal authored
      - On existing column headers, we should expose nothing for
      AXColumnHeaderUIElements.
      - For cells, we should expose only the column headers that are used for that cell,
      not all of them as we currently do.
      - The children of a column should be exposed (this is what actually fixes the VoiceOver issue in the bug).
      - The children and visibleChildren should be the same.
      
      Bug: 775167
      Change-Id: Ief4d1ee80cd759250041e78e95e643030c14b361
      Reviewed-on: https://chromium-review.googlesource.com/721420
      Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
      Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
      Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512707}
      e30fa136
    • Ken Rockot's avatar
      Reland "Always send subresource ULF on navigation" · e60ebbd1
      Ken Rockot authored
      This is a reland of bba21f27
      Original change's description:
      > Always send subresource ULF on navigation
      > 
      > This changes the Network Service-enabled browser-side navigation path
      > to always send a default subresource URLLoaderFactory to the render
      > frame on navigation commit.
      > 
      > In addition to sending a default ULF, we also send one for blobs.
      > Ultimately the idea here is to have the browser, at navigation time,
      > send a frame everything it will need to request any accessible
      > subresources, making it easier to reason about what subresource
      > capabilities any given frame has.
      > 
      > This set of capabilities is encapsulated by a new
      > URLLoaderFactoryBundle type, which can be serialized over mojom and is
      > now passed in new-document navigation commit messages.
      > 
      > Follow-up usage of URLLoaderFactoryBundle will support loading things
      > like file:// and chrome-extension:// subresources when appropriate.
      > 
      > Note that this does not yet change how workers acquire ULFs for their
      > own resource requests.
      > 
      > Bug: 721414,759230
      > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
      > Change-Id: I47b0897c7c012292633d5f08c874a18cc0fb1dcb
      > Reviewed-on: https://chromium-review.googlesource.com/740904
      > Commit-Queue: Ken Rockot <rockot@chromium.org>
      > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
      > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#512459}
      
      Bug: 721414, 759230
      Change-Id: Ie13bcd97b7a5af8dbe4263a70239ba124205da15
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
      
      TBR=dcheng@chromium.org
      
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
      Change-Id: Ie13bcd97b7a5af8dbe4263a70239ba124205da15
      Reviewed-on: https://chromium-review.googlesource.com/744222
      Commit-Queue: Ken Rockot <rockot@chromium.org>
      Reviewed-by: default avatarKen Rockot <rockot@chromium.org>
      Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
      Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512706}
      e60ebbd1
    • Hiroshige Hayashizaki's avatar
      Support integrity attribute for module scripts · 214d1683
      Hiroshige Hayashizaki authored
      This CL enables subresource integrity check for module scripts, by
      - Clearing ScriptFetchOptions' integrity for descendant module
        scripts in ModuleTreeLinker.cpp, as specced,
      - Setting FetchParameters' integrity according to ScriptFetchOptions
        in ModuleScriptLoader::Fetch(), and
      - Checking the integrity check result in WasModuleLoadSuccessful()
        and reports console messages if any.
        For this, SubresourceIntegrityHelper::GetConsoleMessages() is
        introduced.
      
      Bug: 771486, 772100
      Change-Id: I3f01fd018dad625de9440fe4ab7e1d9ee7feb5ab
      Reviewed-on: https://chromium-review.googlesource.com/738221
      Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
      Reviewed-by: default avatarKouhei Ueno <kouhei@chromium.org>
      Reviewed-by: default avatarHiroki Nakagawa <nhiroki@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512705}
      214d1683
    • Trent Apted's avatar
      Fix LabelButtonTest.ButtonStyleIsDefaultStyle,HighlightedButtonStyle · c7cb3e90
      Trent Apted authored
      Since r478352 SecondaryUI buttons on Mac have all been MdTextButtons,
      so we don't really care how regular LabelButtons look on Mac.
      
      Remove some mac-specific logic from PlatformStyle and the
      label_button_unittest.cc to make these tests pass. Some tests
      currently fail just because the text color changes from solid
      black/white to something different under MD due to logic in
      ui::NativeTheme
      
      Bug: 713030
      Change-Id: I3b925918024d6c260da007ceb96900a2afb557a4
      Reviewed-on: https://chromium-review.googlesource.com/741401Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
      Commit-Queue: Trent Apted <tapted@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512704}
      c7cb3e90
    • Emircan Uysaler's avatar
      media::VideoFrame::CreateFrame should support any pixel format · 4417837d
      Emircan Uysaler authored
      This CL extends coverage of this method such that it isn't only creating YUV
      planar frames.
      
      Bug: 555909
      Change-Id: I6be8f31a15ba2942feb24ecce5e5d94bb672ad43
      Reviewed-on: https://chromium-review.googlesource.com/743022Reviewed-by: default avatarYuri Wiitala <miu@chromium.org>
      Reviewed-by: default avatarEmircan Uysaler <emircan@chromium.org>
      Reviewed-by: default avatarDan Sanders <sandersd@chromium.org>
      Commit-Queue: Emircan Uysaler <emircan@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512703}
      4417837d
    • Stefan Zager's avatar
      [root layer scrolls] New test expectations · b7b9f2e6
      Stefan Zager authored
      First patch set has the old non-RLS expectations copied into
      flag-specific/root-layer-scrolls, for comparison.
      
      BUG=711468
      R=pdr@chromium.org,skobes@chromium.org
      
      Change-Id: Iaaaf6a31b37e80289c8265d53f18973b4eb8018c
      Reviewed-on: https://chromium-review.googlesource.com/743710Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
      Commit-Queue: Stefan Zager <szager@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512702}
      b7b9f2e6
    • v8-autoroll's avatar
      Update V8 to version 6.4.169. · 65bc0f7b
      v8-autoroll authored
      Summary of changes available at:
      https://chromium.googlesource.com/v8/v8/+log/d7dba58e..34cad05e
      
      Please follow these instructions for assigning/CC'ing issues:
      https://github.com/v8/v8/wiki/Triaging%20issues
      
      Please close rolling in case of a roll revert:
      https://v8-roll.appspot.com/
      This only works with a Google account.
      
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
      
      TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org
      
      Change-Id: I74299ab9eeea3cf1ad8b2c749dd56dfd316f6bc3
      Reviewed-on: https://chromium-review.googlesource.com/744923Reviewed-by: default avatarv8 autoroll <v8-autoroll@chromium.org>
      Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512701}
      65bc0f7b
    • Erik Luo's avatar
      DevTools: fix cursor style and disabled state for TextPrompt · daa563b5
      Erik Luo authored
      - Hovering cursor over placeholder text now has correct 'I-beam' style.
      - Disabled TextPrompts now look visually different, more transparent,
        consistent with the disabled style on disabled ToolbarButtons.
      
      Screenshot: https://imgur.com/a/FgN8w
      
      Bug: 773964
      Change-Id: I87de99d01ac95653dba3eb62299a27ea2ff19de4
      Reviewed-on: https://chromium-review.googlesource.com/744725Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
      Commit-Queue: Erik Luo <luoe@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512700}
      daa563b5
    • Dominick Ng's avatar
      Deduplicate WebApkUpdateManager and GeolocationHeader test file names. · 3ac8827a
      Dominick Ng authored
      This CL also runs git cl format on the test files.
      
      BUG=778442
      
      Change-Id: If823c7f0dc2c26485102c74223d1c1c6a946f0bb
      Reviewed-on: https://chromium-review.googlesource.com/743162
      Commit-Queue: Dominick Ng <dominickn@chromium.org>
      Reviewed-by: default avatarPeter Kotwicz <pkotwicz@chromium.org>
      Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
      Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512699}
      3ac8827a
    • Peter Collingbourne's avatar
      Android: Determine search path by taking the address of a function instead of a variable. · eb412d96
      Peter Collingbourne authored
      The GetCrazyContext function calls the
      crazy_context_add_search_path_for_address function to add the directory
      where the crazy linker library was loaded from to the search path.
      This function works by reading /proc/self/maps to discover the path
      of the file from which the address passed as the second argument is
      mapped, which is expected to be the crazy linker library.
      
      However, there is no guarantee that the address of a static variable
      such as s_crazy_context will be mapped; the linker may allocate them
      into an unmapped region of the r/w segment.  This happens to be what
      lld does with this variable. Because the address was not mapped,
      we ended up failing to determine the search path, which led to a
      failure to load libchrome.so in pre-modern APKs.
      
      We can more reasonably rely on functions being memory mapped, so this
      change causes us to take the address of a function instead.
      
      Bug: 779185
      Change-Id: I83cd882567c48a2cca443b7f5781c50ebc1b9bb4
      Reviewed-on: https://chromium-review.googlesource.com/745201Reviewed-by: default avataragrieve <agrieve@chromium.org>
      Commit-Queue: Peter Collingbourne <pcc@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512698}
      eb412d96
    • Erik Luo's avatar
      DevTools: do not group JS-source error messages · 387fe823
      Erik Luo authored
      Errors from JS such as Promise.reject() or TypeError/SyntaxError from
      should not be grouped.
      
      Bug: 774694
      Change-Id: I791617939a6fd01f963d907e87f87f22031438c4
      Reviewed-on: https://chromium-review.googlesource.com/742202Reviewed-by: default avatarPavel Feldman <pfeldman@chromium.org>
      Commit-Queue: Erik Luo <luoe@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512697}
      387fe823
    • Troy Hildebrandt's avatar
      [Home] Fix bottom nav crash initializing menu color. · 78247732
      Troy Hildebrandt authored
      Removes a needless call to setMenuBackgroundColor that relied on the tab
      model selector being initialized, causing an NPE if that wasn't the
      case. We already call setMenuBackgroundColor in updateVisuals, which is
      called at the appropriate times.
      
      Bug: 779472
      Change-Id: Id87722088da11e178b92c4495eb0113faf454418
      Reviewed-on: https://chromium-review.googlesource.com/744322Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
      Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512696}
      78247732
    • Khushal's avatar
      blink: Don't defer image invalidations resulting from data update. · 206544e6
      Khushal authored
      The optimization to defer invalidations for offscreen animated images
      also defers the invalidation resulting from a data update. Since
      updating the data for an image results in creating a new generator,
      this can create the following scenario.
      
      If multiple elements have the same image and only one of them is
      onscreen, the cached DisplayList for only the onscreen element is
      invalidated. If the offscreen elements are in the interest rect, the
      recordings committed to the compositor will have PaintImages with
      different generators, holding different lengths of encoded data.
      
      The above scenario breaks the assumption in cc that all PaintImages
      received in a commit should share the same generator and be able to
      display the same frame. If one of the images does not have the
      selected frame, because it is holding stale data from a cached
      recording, this results in a crash when rasterizing this recording.
      
      This change fixes that by plumbing whether the invalidation for an
      ImageChanged notification can be deferred. This disallows defering
      of the invalidation if it resulted from a data update to the Image.
      
      Note that since an invalidation here also includes raster invalidation,
      this will result in more prepaint invalidations during image load. But
      this is already the case with static images, and avoiding this requires
      a larger change in how image updates are pushed to the compositor.
      
      R=chrishtr@chromium.org
      
      Bug: 775558
      Change-Id: I9a6e166bf9f8db61758cac18040cca4612fc259a
      Reviewed-on: https://chromium-review.googlesource.com/738622Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
      Reviewed-by: default avatarHiroshige Hayashizaki <hiroshige@chromium.org>
      Commit-Queue: Khushal <khushalsagar@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512695}
      206544e6
    • Menglu Huang's avatar
      Revert "[ios] Moves setWebUsageEnabled to BrowsingDataRemovalController" · 32835644
      Menglu Huang authored
      This reverts commit c75ea588.
      
      Reason for revert: <INSERT REASONING HERE>
      This CL breaks SettingsTestCase/testClearCookies and ExternalURLSSLTestCase 
      Link:
      https://build.chromium.org/p/chromium.mac/builders/ios-simulator-full-configs/builds/67
      https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone10-simulator/builds/8446
      
      Original change's description:
      > [ios] Moves setWebUsageEnabled to BrowsingDataRemovalController
      > 
      > Moves setWebUsageEnabled to BrowsingDataRemovalController from
      > MainController. This is an intermediate step in order to remove Clear
      > browsing data code from MainController.
      > 
      > 
      > Bug: 
      > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
      > Change-Id: I06074b01635d655fb4acad8cb53795a8296b36ee
      > Reviewed-on: https://chromium-review.googlesource.com/679014
      > Commit-Queue: Sergio Collazos <sczs@chromium.org>
      > Reviewed-by: Mark Cogan <marq@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#512648}
      
      TBR=marq@chromium.org,sdefresne@chromium.org,sczs@chromium.org
      
      Change-Id: I665265a6669b4941aac5e79dbc309bc65dba5447
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
      Reviewed-on: https://chromium-review.googlesource.com/745423Reviewed-by: default avatarMenglu Huang <huangml@chromium.org>
      Commit-Queue: Menglu Huang <huangml@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512694}
      32835644
    • Makoto Shimazu's avatar
      Revert "Servicifying ShellHandlerWin." · c52f5bd4
      Makoto Shimazu authored
      This reverts commit 8232f416.
      
      Reason for revert: Google Chrome Win builder failed.
      shell_handler_win.mojom.h is still included by shell_integration_win.cc which was renamed by the original CL.
      I'm wondering why the trybots missed this.
      
      Original change's description:
      > Servicifying ShellHandlerWin.
      > 
      > As part of the effort to deprecate UtilityProcessMojoClient, changing
      > ShellHandlerWin to a service and consumers to bind the service through
      > the service manager.
      > Renamed the interface from ShellHandlerWin to WinShellUtil.
      > 
      > Bug: 777032
      > Change-Id: I71a45a38a5fd0d5d02a8a0bccabf6a7e140acbd7
      > Reviewed-on: https://chromium-review.googlesource.com/736147
      > Commit-Queue: Jay Civelli <jcivelli@chromium.org>
      > Reviewed-by: Scott Violet <sky@chromium.org>
      > Reviewed-by: Tom Sepez <tsepez@chromium.org>
      > Reviewed-by: Patrick Monette <pmonette@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#512682}
      
      TBR=sky@chromium.org,thestig@chromium.org,jcivelli@chromium.org,noel@chromium.org,tsepez@chromium.org,pmonette@chromium.org
      
      Change-Id: I03bb3ac7bfa0e9e98fc63034d7e81a62fcdfd21a
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 777032
      Reviewed-on: https://chromium-review.googlesource.com/745461Reviewed-by: default avatarMakoto Shimazu <shimazu@chromium.org>
      Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512693}
      c52f5bd4
    • Manuel Rego Casasnovas's avatar
      [css-grid] Remove unneeded code in FreeSpaceForStretchAutoTracksStep() · f2061c44
      Manuel Rego Casasnovas authored
      This is a follow up after r510461. In that patch we added a TODO in
      IndefiniteSizeStrategy::FreeSpaceForStretchAutoTracksStep().
      This was related to how preferred widths were computed,
      that could be missing the min-width information.
      
      However after r511451 removing some wrong code
      in LayoutGrid::UpdateBlockLayout(), that was trying to compute
      the preferred widths, we can avoid doing any special calculation
      for the columns case, as that's already managed
      by LayoutBlock::ComputePreferredLogicalWidths().
      
      Basically GridTrackSizing provides a min and max logical widths
      that ignore min-width. But that's not an issue as LayoutGrid only
      overrides ComputeIntrinsicLogicalWidths(),
      then ComputePreferredLogicalWidths() will use that information
      together with the min-size and properly compute the preferred widths.
      
      For this reason in FreeSpaceForStretchAutoTracksStep() we don't need
      any special computation for columns, the same that happens
      in RecomputeUsedFlexFractionIfNeeded().
      
      Added two unit tests to verify that the preferred widths are right
      in both cases (auto and flexible tracks with min-width).
      
      Bug=773625
      
      Change-Id: I69efeb064fa03685c3e77bca33d294df3e1db79d
      Reviewed-on: https://chromium-review.googlesource.com/741505Reviewed-by: default avatarJavier Fernandez <jfernandez@igalia.com>
      Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
      Cr-Commit-Position: refs/heads/master@{#512692}
      f2061c44
    • angle-deps-roller@chromium.org's avatar
      Roll src/third_party/angle/ e7c5f4f05..163965d5c (1 commit) · 4605f2dd
      angle-deps-roller@chromium.org authored
      https://chromium.googlesource.com/angle/angle.git/+log/e7c5f4f05c87..163965d5ce2b
      
      $ git log e7c5f4f05..163965d5c --date=short --no-merges --format='%ad %ae %s'
      2017-10-11 cwallez BUILD.gn: prepare dEQP test support on Mac
      
      Created with:
        roll-dep src/third_party/angle
      
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      If the roll is causing failures, see:
      http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls
      
      
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.angle:android_angle_rel_ng,android_angle_deqp_rel_ng,linux_angle_rel_ng,linux_angle_dbg_ng,linux_angle_deqp_rel_ng,linux_angle_ozone_rel_ng,mac_angle_rel_ng,mac_angle_dbg_ng,win_angle_rel_ng,win_angle_dbg_ng,win_angle_x64_rel_ng,win_angle_x64_dbg_ng,win_angle_deqp_rel_ng,win_angle_x64_deqp_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      TBR=cwallez@chromium.org
      
      Change-Id: If105bad8635efef8c27bc54145eaa862836f5912
      Reviewed-on: https://chromium-review.googlesource.com/744972Reviewed-by: default avatarangle-deps-roller . <angle-deps-roller@chromium.org>
      Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512691}
      4605f2dd
    • Shubhie Panicker's avatar
      Decouple Stopped in bg signal from stop loading experiment. · 9ffd6254
      Shubhie Panicker authored
      Make triggering of Stopped in bg signal more generic, it should not be
      tied to the experiment to stop loading.
      A future CL will trigger a JS callback to indicate stopped to the app. 
      
      Bug: 763573
      Change-Id: I439e70fab824d2e243ebfa731d5f27464dc629ff
      Reviewed-on: https://chromium-review.googlesource.com/736903
      Commit-Queue: Shubhie Panicker <panicker@chromium.org>
      Reviewed-by: default avatarSami Kyöstilä <skyostil@chromium.org>
      Reviewed-by: default avatarFadi Meawad <fmeawad@chromium.org>
      Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512690}
      9ffd6254
    • Charles Harrison's avatar
      AbusiveExperienceEnforce: add end to end safe browsing test · 890f8aa0
      Charles Harrison authored
      This CL adds a new harness to the safe browsing triggered popup
      blocker browser test which mocks HTTP responses from the safe browsing
      server.
      
      It also tweaks the ScopedLoggingObserver to stop listening (globally)
      on messages when it is destroyed, and it only considers messages that
      have come in since it is instantiated.
      
      Bug: 756009,756089
      Change-Id: I2ad8bcebbdaf09252fa323e9de49c0de943e372b
      Reviewed-on: https://chromium-review.googlesource.com/731406
      Commit-Queue: Charlie Harrison <csharrison@chromium.org>
      Reviewed-by: default avatarShivani Sharma <shivanisha@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512689}
      890f8aa0
    • Lucas Garron's avatar
      Create a --committed-interstitials Chrome flag. · b9539b73
      Lucas Garron authored
      The flag is exposed in chrome://flags
      
      Also deny requests that encounter certificate errors in
      ChromeContentBrowserClientAllow::CertificateError, causing them to appear like
      net errors with ERR_INSECURE_RESPONSE. Subsequent CLs will make them behave more
      and more like old interstitials.
      
      Bug: 778857
      Change-Id: Ie50f8475db5ae0f6b98f17e17128587fc8553848
      Reviewed-on: https://chromium-review.googlesource.com/742136Reviewed-by: default avatarEmily Stark <estark@chromium.org>
      Commit-Queue: Lucas Garron <lgarron@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512688}
      b9539b73
    • Bo Liu's avatar
      Reset GPU timeout on retry · e1249bf1
      Bo Liu authored
      Only for Android. Right now OnEstablishedOnIO retries on failure
      indefinitely. The main reason this is a problem on android is in
      CompositorImpl, there is a timeout waiting for EstablishChannel. If the
      failure is due to a gpu timeout, then CompositorImpl doesn't known about
      the try and doesn't reset its timeout, thus making it more like to have
      the entire browser be killed.
      
      Move the timeout logic into BrowserGpuChannelHostFactory instead so
      that the timeout can be reset when EstablishGpuChannel is retried.
      
      Bug: 680777
      Change-Id: I47da7d3f2b3ca238c3aec547497adf57dc63a73d
      Reviewed-on: https://chromium-review.googlesource.com/742484
      Commit-Queue: Bo <boliu@chromium.org>
      Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512687}
      e1249bf1
    • Antoine Labour's avatar
      gpu fuzzers: take configuration bits from input data · 72bb2907
      Antoine Labour authored
      Some of the decoder code paths depend on underlying driver (e.g.
      version, extensions, workarounds), and of the client configuration (e.g.
      context type and options). This CL allows the fuzzers to take some bits
      from the input data to configure the decoder in different ways, to allow
      exploring those various code paths and increasing coverage.
      
      Bug: None
      Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      Change-Id: I23a77878414ade4400a267b30d89f979a0ff4374
      Reviewed-on: https://chromium-review.googlesource.com/744735Reviewed-by: default avatarVictor Miura <vmiura@chromium.org>
      Commit-Queue: Antoine Labour <piman@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512686}
      72bb2907
    • Hiroshige Hayashizaki's avatar
      Add IntegrityMetadataSet to ScriptFetchOptions · 17090875
      Hiroshige Hayashizaki authored
      This CL
      - introduces integrity-related members to ScriptFetchOptions,
      - sets them in PrepareScript(), WorkletGlobalScope.cpp and
        DynamicModuleResolver.cpp as specced, and
      - uses them for classic scripts, in ClassicPendingScript::Fetch().
      
      For module scripts, the integrity-related members are not used,
      and are sometimes set incorrectly.
      This will be fixed in a subsequent CL.
      
      Bug: 771486, 772100
      Change-Id: I0983bc6ad02b73472d67bf1b2ce169d2d71c5be3
      Reviewed-on: https://chromium-review.googlesource.com/736721
      Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
      Reviewed-by: default avatarKouhei Ueno <kouhei@chromium.org>
      Reviewed-by: default avatarYutaka Hirano <yhirano@chromium.org>
      Reviewed-by: default avatarHiroki Nakagawa <nhiroki@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512685}
      17090875
    • Ryan Hansberry's avatar
      Remove all screen lock logic from TetherService. · 7ec9bdc8
      Ryan Hansberry authored
      Bug: 779649
      Change-Id: Ic3ffb1886a3d3dae5389aef0d5a52c12c6c31635
      Reviewed-on: https://chromium-review.googlesource.com/744422
      Commit-Queue: Dan Erat <derat@chromium.org>
      Reviewed-by: default avatarJeremy Klein <jlklein@chromium.org>
      Reviewed-by: default avatarSteven Holte <holte@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512684}
      7ec9bdc8
    • lpy's avatar
      Revert "Make resource_coordinator/ strongly typed." · 5d86ecd0
      lpy authored
      This reverts commit 8a3a84dc.
      
      Reason for revert: Unit test failed in Linux Test, see https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests/63991
      
      Original change's description:
      > Make resource_coordinator/ strongly typed.
      > 
      > This patch:
      > 1. Added CU relation manipulation methods in mojo interface and public APIs;
      > 2. Created one type of *ResourceCoordinator for each coordination unit type;
      > 3. Removed generic CoordinationUnit mojo interface and implementation;
      > 4. Replaced every call of SetProperty and SendEvent with new public APIs;
      > 5. Added more tests.
      > 
      > BUG=775691
      > 
      > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
      > Change-Id: I10b5c6a5ce9d8f0fbe3c2c3afef4ee4da7da0757
      > Reviewed-on: https://chromium-review.googlesource.com/736036
      > Commit-Queue: lpy <lpy@chromium.org>
      > Reviewed-by: Peter Beverloo <peter@chromium.org>
      > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
      > Reviewed-by: oysteine <oysteine@chromium.org>
      > Reviewed-by: Zhen Wang <zhenw@chromium.org>
      > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#512654}
      
      TBR=dcheng@chromium.org,kinuko@chromium.org,peter@chromium.org,zhenw@chromium.org,japhet@chromium.org,oysteine@chromium.org,lpy@chromium.org
      
      Change-Id: I0ecfcf6fe272d6be9dacf022e9221db346294abd
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 775691
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
      Reviewed-on: https://chromium-review.googlesource.com/745282Reviewed-by: default avatarlpy <lpy@chromium.org>
      Commit-Queue: lpy <lpy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512683}
      5d86ecd0
    • Jay Civelli's avatar
      Servicifying ShellHandlerWin. · 8232f416
      Jay Civelli authored
      As part of the effort to deprecate UtilityProcessMojoClient, changing
      ShellHandlerWin to a service and consumers to bind the service through
      the service manager.
      Renamed the interface from ShellHandlerWin to WinShellUtil.
      
      Bug: 777032
      Change-Id: I71a45a38a5fd0d5d02a8a0bccabf6a7e140acbd7
      Reviewed-on: https://chromium-review.googlesource.com/736147
      Commit-Queue: Jay Civelli <jcivelli@chromium.org>
      Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Reviewed-by: default avatarTom Sepez <tsepez@chromium.org>
      Reviewed-by: default avatarPatrick Monette <pmonette@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512682}
      8232f416
    • Mohsen Izadi's avatar
      Adjust overscroll thresholds for touchpad · 4ef8db7d
      Mohsen Izadi authored
      To improve touchpad overscroll sensitivity, start and completion
      thresholds for touchpad are increased by 20%. This needed splitting some
      threshold into two separate ones for touchpad and touchscreen.
      
      Also, both vertical and horizontal overscroll now use maximum of screen
      width and screen height to calculate completion threshold. Previously,
      vertical overscroll was using screen height and horizontal overscroll
      was using screen width. This change makes overscroll in both dimensions
      more consistent.
      
      Also, some parameters had different values for vertical vs horizontal
      overscroll. They have been merged into a single parameter.
      
      BUG=772103
      TEST=RenderWidgetHostViewAuraOver*Test.* in content_unittests
      
      Change-Id: Id4efa17b247fffdbd13c0087be5afbec85f81131
      Reviewed-on: https://chromium-review.googlesource.com/740782Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
      Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
      Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#512681}
      4ef8db7d
  2. 30 Oct, 2017 13 commits