GitLab

[20526:20526:0815/151613:1174431576:FATAL:touch_exploration_controller.cc(763)] Check failed: false. tap timer fired in unrecognized state: CORNER_PASSTHROUGH
#0 0x7f485532361e base::debug::StackTrace::StackTrace()
#1 0x7f48553ba882 logging::LogMessage::~LogMessage()
#2 0x7f485314bcfc ui::TouchExplorationController::OnTapTimerFired()
#3 0x7f485314af2b ui::TouchExplorationController::RewriteEvent()
#4 0x7f48531c89a6 ui::EventSource::SendEventToProcessor()
#5 0x0000005f6bc0 ui::EventSourceTestApi::SendEventToProcessor()
#6 0x0000005f396f ui::test::EventGenerator::DoDispatchEvent()
#7 0x0000005f1480 ui::test::EventGenerator::Dispatch()
#8 0x00000051a1a5 ui::TouchExplorationTest::AssertCornerPassthroughWorking()
#9 0x0000005153fb ui::TouchExplorationTest_ActivateLeftCornerPassthrough_Test::TestBody()
#10 0x0000005a49f3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>()
#11 0x00000059005e testing::internal::HandleExceptionsInMethodIfSupported\u003C>()
#12 0x000000583ed5 testing::Test::Run()
#13 0x0000005845db testing::TestInfo::Run()

In ActivateLeftCornerPassthrough, ActivateRightCornerPassthrough, and SingleTapLongPress tests.

> Modified state flow for touch explore released in touch_exploration_controller.
> 
> Now when performing single tap, the tap timer to begin one finger passthrough is not started. This problem originally arose because touch explore released state and single tap released state are treated similarly in the code, but one finger passthrough should be a state reachable only from single tap released.
> 
> Another state change is that if the user presses in single tap/touch explore released and there is no previous touch exploration location, the user is redirected to the wait state.
> 
> TEST=TouchExplorationTest.SingleTapLongPress
> BUG=402544
> 
> Review URL: https://codereview.chromium.org/465543003

TBR=evy@chromium.org

Review URL: https://codereview.chromium.org/483443002

Cr-Commit-Position: refs/heads/master@{#290092}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290092 0039d316-1c4b-4281-b951-d872f2087c98

Track additional timing stats about signing in users

Specifically, track if signin took place during first run, and also
track how long since Chrome Install the signin took place.

BUG=357693

Review URL: https://codereview.chromium.org/466043002

Cr-Commit-Position: refs/heads/master@{#290091}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290091 0039d316-1c4b-4281-b951-d872f2087c98

HTTP auth prompts show a blank interstitial which causes the omnibox to show
 the correct URL and page contents to clear in order to prevent phishing. The
logic for this interstitial currently checks only for the visible URL. This misses
the case where the user navigates directly the URL: The URL of the resource
with HTTP Auth will be the same as the visible entry so no interstitial will be
shown. This patch adds a check to see if the last committed entry is also
different then the URL of the resource with HTTP Auth.

BUG=396961
TEST=LoginPromptBrowserTest.*

Review URL: https://codereview.chromium.org/410373003

Cr-Commit-Position: refs/heads/master@{#290090}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290090 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Rotate screen in response to accelerator or device orientation sensors. (patchset #12 of https://codereview.chromium.org/431183003/)

Reason for revert:
Speculative, athena_unittests and ui_unittests started failing in this build:http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2771

==6568==ERROR: AddressSanitizer: heap-use-after-free on address 0x60700000ba10 at pc 0x00000167d52a bp 0x7fff95f266f0 sp 0x7fff95f266e8
READ of size 8 at 0x60700000ba10 thread T0
    #0 0x167d529 in DeleteInternal base/memory/ref_counted.h:190:44
    #1 0x167d529 in Destruct base/memory/ref_counted.h:153
    #2 0x167d529 in Release base/memory/ref_counted.h:181
    #3 0x167d529 in ~scoped_refptr base/memory/ref_counted.h:289
    #4 0x167d529 in ~SystemUIImpl athena/system/system_ui_impl.cc:27
    #5 0x167d529 in athena::(anonymous namespace)::SystemUIImpl::~SystemUIImpl() athena/system/system_ui_impl.cc:26
    #6 0x167d257 in athena::SystemUI::Shutdown() athena/system/system_ui_impl.cc:49:3
    #7 0x577fa6 in athena::ShutdownAthena() athena/main/athena_launcher.cc:92:3
    #8 0x57645f in athena::test::AthenaTestHelper::TearDown() athena/test/athena_test_helper.cc:98:3
    #9 0x575266 in athena::test::AthenaTestBase::TearDown() athena/test/athena_test_base.cc:53:3
    #10 0x505bc8 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5
    #11 0x506906 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5
    #12 0x51cb85 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11
    #13 0x51c176 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12
    #14 0x51c176 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209
    #15 0xac6fb4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10
    #16 0xac6fb4 in base::TestSuite::Run() base/test/test_suite.cc:227
    #17 0xabe39d in Run base/callback.h:401:12
    #18 0xabe39d in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498
    #19 0xabf0de in base::LaunchUnitTestsSerially(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:564:10
    #20 0x4d7bba in main athena/test/athena_unittests.cc:51:10
    #21 0x7fd394e3476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226
    #22 0x4d795c in _start (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x4d795c)

0x60700000ba10 is located 0 bytes inside of 72-byte region [0x60700000ba10,0x60700000ba58)
freed by thread T0 here:
    #0 0x452fcb in operator delete(void*) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x452fcb)
    #1 0x168323d in DeleteInternal base/memory/ref_counted.h:190:44
    #2 0x168323d in Destruct base/memory/ref_counted.h:153
    #3 0x168323d in Release base/memory/ref_counted.h:181
    #4 0x168323d in ~scoped_refptr base/memory/ref_counted.h:289
    #5 0x168323d in athena::OrientationController::OrientationController(scoped_refptr\u003Cbase::TaskRunner>) athena/system/orientation_controller.cc:66
    #6 0x167cfea in SystemUIImpl athena/system/system_ui_impl.cc:23:61
    #7 0x167cfea in athena::SystemUI::Create(scoped_refptr\u003Cbase::TaskRunner>) athena/system/system_ui_impl.cc:42
    #8 0x577db0 in athena::StartAthena(aura::Window*, athena::ActivityFactory*, athena::AppModelBuilder*) athena/main/athena_launcher.cc:73:3
    #9 0x576159 in athena::test::AthenaTestHelper::SetUp(ui::ContextFactory*) athena/test/athena_test_helper.cc:90:3
    #10 0x503eb1 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12
    #11 0x503eb1 in testing::Test::Run() testing/gtest/src/gtest.cc:2430
    #12 0x505bc8 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5
    #13 0x506906 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5
    #14 0x51cb85 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11
    #15 0x51c176 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12
    #16 0x51c176 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209
    #17 0xac6fb4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10
    #18 0xac6fb4 in base::TestSuite::Run() base/test/test_suite.cc:227
    #19 0xabe39d in Run base/callback.h:401:12
    #20 0xabe39d in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498
    #21 0xabf0de in base::LaunchUnitTestsSerially(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:564:10
    #22 0x4d7bba in main athena/test/athena_unittests.cc:51:10
    #23 0x7fd394e3476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

previously allocated by thread T0 here:
    #0 0x452a8b in operator new(unsigned long) (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x452a8b)
    #1 0x167cfb5 in SystemUIImpl athena/system/system_ui_impl.cc:23:61
    #2 0x167cfb5 in athena::SystemUI::Create(scoped_refptr\u003Cbase::TaskRunner>) athena/system/system_ui_impl.cc:42
    #3 0x577db0 in athena::StartAthena(aura::Window*, athena::ActivityFactory*, athena::AppModelBuilder*) athena/main/athena_launcher.cc:73:3
    #4 0x576159 in athena::test::AthenaTestHelper::SetUp(ui::ContextFactory*) athena/test/athena_test_helper.cc:90:3
    #5 0x503eb1 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12
    #6 0x503eb1 in testing::Test::Run() testing/gtest/src/gtest.cc:2430
    #7 0x505bc8 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5
    #8 0x506906 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5
    #9 0x51cb85 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11
    #10 0x51c176 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12
    #11 0x51c176 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209
    #12 0xac6fb4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10
    #13 0xac6fb4 in base::TestSuite::Run() base/test/test_suite.cc:227
    #14 0xabe39d in Run base/callback.h:401:12
    #15 0xabe39d in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498
    #16 0xabf0de in base::LaunchUnitTestsSerially(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:564:10
    #17 0x4d7bba in main athena/test/athena_unittests.cc:51:10
    #18 0x7fd394e3476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

TBR=oshima
NOTRY=true
NOTREECHECKS=true

Original issue's description:
> Rotate screen in response to accelerator or device orientation sensors.
> 
> BUG=385295
> TEST=Press Ctrl+Shift+F3, screen rotates.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290007

Review URL: https://codereview.chromium.org/475533008

Cr-Commit-Position: refs/heads/master@{#290089}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290089 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=achaulk@chromium.org

Review URL: https://codereview.chromium.org/468633003

Cr-Commit-Position: refs/heads/master@{#290086}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290086 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#290085}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290085 0039d316-1c4b-4281-b951-d872f2087c98

R=iannucci@chromium.org
BUG=399054
NOTRY=true

Review URL: https://codereview.chromium.org/478843002

Cr-Commit-Position: refs/heads/master@{#290083}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290083 0039d316-1c4b-4281-b951-d872f2087c98

Perform NaCl initialization during app_shell's startup path similar to
how Chrome initializes it.
* Refactor some of the lazy background page impulse code into ProcessManager so it can be shared with Chrome

BUG=400577
TEST=manual tests of app_shell, existing ProcessManager unit tests and browser tests

Review URL: https://codereview.chromium.org/437503004

Cr-Commit-Position: refs/heads/master@{#290082}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290082 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399067

Review URL: https://codereview.chromium.org/472733002

Cr-Commit-Position: refs/heads/master@{#290081}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290081 0039d316-1c4b-4281-b951-d872f2087c98

--scripts-require-action flag is on. The flag requirement is because we haven't
confirmed this is safe, but we need something like it for testing the flag.

BUG=404243
R=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/475333006

Cr-Commit-Position: refs/heads/master@{#290080}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290080 0039d316-1c4b-4281-b951-d872f2087c98

BUG=404252

TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/467133004

Cr-Commit-Position: refs/heads/master@{#290079}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290079 0039d316-1c4b-4281-b951-d872f2087c98

R=byungchul@chromium.org,lcwu@chromium.org
BUG=403966

Review URL: https://codereview.chromium.org/469023004

Cr-Commit-Position: refs/heads/master@{#290078}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290078 0039d316-1c4b-4281-b951-d872f2087c98

Building blink events requires more data than we currently pass through
mojo::EventPtr. That data is available on the side that has the
base::NativeEvent, so we now send both the view relative location and
the system location through. This also lets us drop a DEPS on "ui/events"
from the html viewer.

Eventually, we'll want our own event types, but this works for now.

BUG=403514

Review URL: https://codereview.chromium.org/478523002

Cr-Commit-Position: refs/heads/master@{#290077}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290077 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384635

Review URL: https://codereview.chromium.org/402293002

Cr-Commit-Position: refs/heads/master@{#290076}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290076 0039d316-1c4b-4281-b951-d872f2087c98

Remove a non-const pass-by-reference while we are at it.

Review URL: https://codereview.chromium.org/470693003

Cr-Commit-Position: refs/heads/master@{#290075}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290075 0039d316-1c4b-4281-b951-d872f2087c98

R=vmpstr@chromium.org, enne@chromium.org, danakj@chromium.org
BUG=403829

Review URL: https://codereview.chromium.org/478723002

Cr-Commit-Position: refs/heads/master@{#290074}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290074 0039d316-1c4b-4281-b951-d872f2087c98

1. stack the link and button in the upgrade tutorial card
2. limit the width of the title label to accomodate long names.
3. increase the height of signin view
4. adds missing 'x' button

BUG=403572, 399663, 403105
R=asvitkine@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/465313003

Cr-Commit-Position: refs/heads/master@{#290073}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290073 0039d316-1c4b-4281-b951-d872f2087c98

This is an output surface that displays the content using
overlays and render-to-FBO, instead of the usual system-managed
framebuffer. Implementation to follow in another CL.

BUG=380861
TBR=stevenjb

Review URL: https://codereview.chromium.org/433543002

Cr-Commit-Position: refs/heads/master@{#290072}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332205
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/476213002

Cr-Commit-Position: refs/heads/master@{#290071}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290071 0039d316-1c4b-4281-b951-d872f2087c98

This change closed the build tree for Linux and ChromiumOS bots due to
failing interactive_ui_tests:

http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=12979

> Omnibox: Prevent Asynchronous Suggestions from Changing Default Match
> 
> Calls to the suggest server may normally result in a new inline
> autocompletion.  This can be disruptive because it means pressing enter
> may bring the user to different places depending on how long he/she
> waits after typing the last key.
> 
> This change prevents new suggestions from becoming the default match.
> In other words, the default match is only allowed to change on a
> keystroke, not due to a reply coming back from the server.
> 
> The consequence of this change is that if previously we'd show an
> inline suggestion on a server reply, now we only show it one keystroke
> later.  I think this trade-off (one keystroke versus inconsistent
> omnibox behavior) is a good one to make.
> 
> We still end up with default matches (inline autocompletions within
> the omnibox) from the suggest server after this change.  Here's an
> example of why:
> 
> User types "facebo"
> We send a suggest server request.
> Server asynchronously returns "facebook" as a top suggestion,
>   beating the server-provided verbatim score for "facebo".
> We decide not to show it within the omnibox.  It's instead shown
>   somewhere in the dropdown.
> User types "o".
> We send a suggest server request.
> We reuse our cached suggestions and suggestion scores.  <<< THE KEY
> We show "facebook" as an inline suggestion because it beats
>   the default verbatim score that gets assigned to "faceboo".
>   (This is the score that we assign by default without having
>   yet received the most recent suggest server response.)
> We receive the response, which includes "facebook" as a top
>   suggestion, beating the server-provided verbatim score
>   for "faceboo".
> We show "facebook" as an inline suggestion.  i.e., we decide
>   not to demote it because it was already being shown inline
> 
> TESTED:
> unit tests plus interactive tests (facebook.com/l, google.com/a)
> 
> BUG=398135
> R=msw@chromium.org
> 
> Review URL: https://codereview.chromium.org/471673002

TBR=mpearson@chromium.org

Review URL: https://codereview.chromium.org/477293002

Cr-Commit-Position: refs/heads/master@{#290070}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290070 0039d316-1c4b-4281-b951-d872f2087c98

(either ones blocking guest mode in particular or guest mode).

Follow-up to the CL http://codereview.chromium.org/385073008

CL is currently blocked on crbug.com/394413. No more, it landed!

BUG=306322

Review URL: https://codereview.chromium.org/471973003

Cr-Commit-Position: refs/heads/master@{#290069}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290069 0039d316-1c4b-4281-b951-d872f2087c98

Removing as bug http://crbug.com/284662 is fixed.

BUG=284662

Review URL: https://codereview.chromium.org/469213008

Cr-Commit-Position: refs/heads/master@{#290068}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290068 0039d316-1c4b-4281-b951-d872f2087c98

Undoes some previous work towards encryption support.  That approach
suffered from some subtle deadlock issues that could not be easily
worked around.  The new approach involves less sharing and less locks.

Gives the ModelTypeSyncWorker its own copy of the Cryptographer.  By
passing around copies, it no longer needs to worry about acquiring locks
in order to access the Directory's cryptographer.  This required
a rewrite of some changes to the way the ModelTypeSyncWorker detects the
current encryption state.  Most notably, its Cryptographer is NULL if
encryption is not enabled for its model type.

Makes the ModelTypeSyncRegistry responsible for observing changes
emitted by the SyncEncryptionHandler and forwarding them to the
ModelTypeSyncWorkers.  It should receive callbacks from the
SyncEncryptionHandler during startup, so it does not need to cache or
query any new data.

Removes the CryptographerProviders.  Since the ModelTypeSyncWorker no
longer need to access the directory's cryptographer, it's no longer
necessary.

BUG=351005

Review URL: https://codereview.chromium.org/452283003

Cr-Commit-Position: refs/heads/master@{#290067}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290067 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#290066}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290066 0039d316-1c4b-4281-b951-d872f2087c98

643ccb5: (thestig) system_api: Remove deprecated mtpd method constants.
dce25dd: (pstew) Add property for WakeOnLan
e59913e: (chirantan) dbus: Add signal and methods for dark resume

BUG=397346
Signed-off-by: Chirantan Ekbote <chirantan@chromium.org>

Review URL: https://codereview.chromium.org/474333002

Cr-Commit-Position: refs/heads/master@{#290065}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=aarya@google.com, mbarbella@chromium.org

Review URL: https://codereview.chromium.org/465403004

Cr-Commit-Position: refs/heads/master@{#290064}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290064 0039d316-1c4b-4281-b951-d872f2087c98

This add an window.testRunner API that sends do-nothing IPC message
roundtrip. This API can be used to build IPC benchmark using
JavaScript.

TEST=none (Will add blink-side LayoutTest once this is landed)
BUG=402185
R=darin@chromium.org, jam@chromim.org, jochen@chromium.org

Review URL: https://codereview.chromium.org/478483005

Cr-Commit-Position: refs/heads/master@{#290063}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290063 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=build

Review URL: https://codereview.chromium.org/471163004

Cr-Commit-Position: refs/heads/master@{#290062}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290062 0039d316-1c4b-4281-b951-d872f2087c98

With the recent device polling changes
(https://codereview.chromium.org/424093004/), any failure in enumerating
devices/services prevents the background polling task from reporting
changes (to avoid reporting inconsistent configuration). However, when
devices are offline and polling is done in "discovery" mode,
enumerating services fails because the underlying SDP request fails.
The workaround if to ask for cached services only instead, so that at
least the services already previously known are returned and the
polling operation can succeed.

BUG=396337

Review URL: https://codereview.chromium.org/476823003

Cr-Commit-Position: refs/heads/master@{#290061}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290061 0039d316-1c4b-4281-b951-d872f2087c98

normalization was not working properly.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/468653003

Cr-Commit-Position: refs/heads/master@{#290060}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290060 0039d316-1c4b-4281-b951-d872f2087c98

Calls to the suggest server may normally result in a new inline
autocompletion.  This can be disruptive because it means pressing enter
may bring the user to different places depending on how long he/she
waits after typing the last key.

This change prevents new suggestions from becoming the default match.
In other words, the default match is only allowed to change on a
keystroke, not due to a reply coming back from the server.

The consequence of this change is that if previously we'd show an
inline suggestion on a server reply, now we only show it one keystroke
later.  I think this trade-off (one keystroke versus inconsistent
omnibox behavior) is a good one to make.

We still end up with default matches (inline autocompletions within
the omnibox) from the suggest server after this change.  Here's an
example of why:

User types "facebo"
We send a suggest server request.
Server asynchronously returns "facebook" as a top suggestion,
  beating the server-provided verbatim score for "facebo".
We decide not to show it within the omnibox.  It's instead shown
  somewhere in the dropdown.
User types "o".
We send a suggest server request.
We reuse our cached suggestions and suggestion scores.  <<< THE KEY
We show "facebook" as an inline suggestion because it beats
  the default verbatim score that gets assigned to "faceboo".
  (This is the score that we assign by default without having
  yet received the most recent suggest server response.)
We receive the response, which includes "facebook" as a top
  suggestion, beating the server-provided verbatim score
  for "faceboo".
We show "facebook" as an inline suggestion.  i.e., we decide
  not to demote it because it was already being shown inline

TESTED:
unit tests plus interactive tests (facebook.com/l, google.com/a)

BUG=398135
R=msw@chromium.org

Review URL: https://codereview.chromium.org/471673002

Cr-Commit-Position: refs/heads/master@{#290058}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290058 0039d316-1c4b-4281-b951-d872f2087c98

By default there is no change in behavior, but autofilling can now be disabled
for the sync credential entirely or just disabled for reauth pages that support
transactional reauth.

Note that this also changes GetSyncUsername() to not return the username if
password sync is disabled if it is possible to determine. This makes GetSyncUsername() a little inconsistent depending on the state of sync setup, but it's important to be as specific as possible when disabling autofilling, since it's a
usability hit.

BUG=386692
R=isherman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290030

Review URL: https://codereview.chromium.org/451853003

Cr-Commit-Position: refs/heads/master@{#290057}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290057 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401834

Review URL: https://codereview.chromium.org/471703002

Cr-Commit-Position: refs/heads/master@{#290055}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290055 0039d316-1c4b-4281-b951-d872f2087c98

Use it to log error type in BypassOneNetworkError UMA.
This fixes DataReductionProxy.BypassOnNetworkError UMA recording bug.

BUG=395769

Review URL: https://codereview.chromium.org/473513002

Cr-Commit-Position: refs/heads/master@{#290054}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290054 0039d316-1c4b-4281-b951-d872f2087c98

added in r288784 but the schema missed out.

BUG=388164
R=jsbell@chromium.org

Review URL: https://codereview.chromium.org/476243003

Cr-Commit-Position: refs/heads/master@{#290053}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290053 0039d316-1c4b-4281-b951-d872f2087c98

Add an overscroll effect implementation that mimics that of Android L. The
primary differences are the use of a single rasterized arc layer and the
inclusion of motion orthogonal to overscroll in computing the effect offset.

BUG=389744

Review URL: https://codereview.chromium.org/367173003

Cr-Commit-Position: refs/heads/master@{#290052}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290052 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/482433002

Cr-Commit-Position: refs/heads/master@{#290051}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290051 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Battery Status API: implementation for Windows. (patchset #5 of https://codereview.chromium.org/447853002/)

Reason for revert:
breaking XP

Original issue's description:
> Battery Status API: implementation for Windows.
> 
> Implementation of the Battery Status API for the Windows platform.
> Implementation uses a message window to receive battery notifications.
> On versions prior to Vista there is limited support as the
> RegisterPowerSettingNotification function is not available.
> 
> BUG=122593
> TEST=http://jsbin.com/battery-status-test (manual)
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289634

TBR=mvanouwerkerk@chromium.org,mlamouri@chromium.org,scottmg@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=122593

Review URL: https://codereview.chromium.org/481493002

Cr-Commit-Position: refs/heads/master@{#290050}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290050 0039d316-1c4b-4281-b951-d872f2087c98

BrowserOptionsOverlayWebUITest.testNavigationInBackground fails on DrMemory
bots:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%20%28DrMemory%20full%29%20%2811%29/builds/476

This changes the test to wait if it detects that the appropriate message has not yet been
sent to the uber page. This ensures that we are only testing the finalized state of the
page.  If the test times out, that would indicate that the problem lies elsewhere.

BUG=403627
R=estade@chromium.org

Review URL: https://codereview.chromium.org/476573002

Cr-Commit-Position: refs/heads/master@{#290049}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290049 0039d316-1c4b-4281-b951-d872f2087c98

We need input methods "config" object to switch between IME states.

This CL also fixed issue with incorrect input method after
screen unlock in multiprofile mode.

BUG=292774,399129
TEST=manual

TBR=nona@chromium.org,asargent@chromium.org,davemoore@chromium.org

Review URL: https://codereview.chromium.org/419293002

Cr-Commit-Position: refs/heads/master@{#290048}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290048 0039d316-1c4b-4281-b951-d872f2087c98