- 14 Apr, 2020 40 commits
-
-
Ahmed Mehfooz authored
Bug: 1035647 Change-Id: I8fa699b0dcb7ecae115d90377ab1f384cdd78859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148169Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#758993}
-
Brian Salomon authored
Bug: skia:10139 Change-Id: Id2b5d6beeddeb12fcc2f2e1ce0f7c1ad3c9ca4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149628 Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#758992}
-
Alexei Svitkine authored
This matches the CHECK in chrome/app/chrome_main_delegate.cc with the same message. These errors are not recoverable, and currently result in a CHECK being hit later in VariationsService::EnsureLocaleEquals(), which is trying to guard for locale mismatch issues. Also expands header comments to mention the empty string return value being the failure case. See ResourceBundle::LoadLocaleResources() implementation for the failure details (i.e. if empty string was returned, we either didn't load the pack file at all, or got an error loading it). Bug: 1022934 Change-Id: I4cc670cf669ed824c3b2073586941931fd38e364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141010Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#758991}
-
Sujie Zhu authored
Replace NetworkAndLastFourDigits() with NicknameOrNetworkAndLastFourDigits() in CreditCard::LabelPiece(). The LabelPiece is used to set CreditCardEntry.metadata.summaryLabel value for the creditCardLabel (display text) in settings page. Changes of the creditCardLabel in the settings page's credit card list: Before: "Network ****2345" After: "Nickname ****2345" More details (googlers only): https://docs.google.com/document/d/1SfrBduc3gJrouT4zLmQHWtUPtcE-9JbkBGLHYgFLTFc/edit?ts=5e50549a#bookmark=id.g3yosdii8zfn Bug: 1059087 Change-Id: Iad062d727f0f0a88fd6e61d0903faf6864b8d889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148274 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#758990}
-
Mohamed Amir Yosef authored
This table will carry the user ids for the users who prefers not to move this credential to their account store within the context of Butter 4 Passwords. Bug: 1032992 Change-Id: Id26eff2ed6f709ff4b9236b47888e6ad7fb2d288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126293 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#758989}
-
John Z Wu authored
Change-Id: Ic7bbe6dfa0bb8322b76bf674cc336fd83f2383bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145562Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#758988}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/1926de0638b6..a10a0b33493e git log 1926de0638b6..a10a0b33493e --date=short --first-parent --format='%ad %ae %s' 2020-04-14 rharrison@google.com Add warning signs about unsupported downloads (#1041) 2020-04-14 rharrison@google.com Rolling 5 dependencies and updating expectations (#1044) Created with: gclient setdep -r src/third_party/shaderc/src@a10a0b33493e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: Ia78ae597b9c7fd48aab6d93916a276f4b3b5e2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149607Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758987}
-
Raymond Toy authored
The node already correctly handles k-rate inputs to the two AudioParams. Thus, we just add a test for this. Bug: 1015760 Test: k-rate-audiobuffersource-connections.html Change-Id: I5ef616692ba5ba836906c39cf8593624fe782728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145701Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#758986}
-
Albert Chaulk authored
Chromecast is seeing issues when the active layer releases its resources, disabling the memory pressure listener fixes it. It is possible that because chromecast devices set critical memory pressure to very low amounts (<30MB) coupled with the gpu driver not being able to actually free memory until existing rendering commands have completed, the memory pressure handler freeing things that then get reallocated right away for the next frame can actually increase memory pressure, triggering an actual OOM condition on device Bug: b/118774931 Test: None Change-Id: Iff393de370b7250ebe5c4ec21a1f225e3887c0f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140608 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758985}
-
Robbie McElrath authored
This CL moves favicon loading into SiteSettingsClient so uses of the currently uncomponentized FaviconHelper can be encapsulated in ChromeSiteSettingsClient. The SiteSettingsClient method defined here may change or go away in the future depending on how we componentize FaviconHelper. Bug: 1058597 Change-Id: I27f8ec33e18942a55e15865d4fd21280c187e4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136283 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#758984}
-
David Van Cleve authored
This is part of a sequence of CLs implementing data removal logic for Trust Tokens [*], a prototype feature that enables annotating requests with some lightweight cryptographic state. The internal storage stores the results of these cryptographic operations, including some state necessary for maintaining privacy invariants. The first CL in the series expanded the Trust Tokens storage system to satisfy deletion requests parameterized by a network::mojom::ClearDataFilter. This CL extends NetworkContext with a Trust Tokens deletion interface and adds a call to this interface in BrowsingDataRemoverImpl. The control flow is quite similar to that for clearing reporting data (which is also scoped per-NetworkContext and deleted from BrowsingDataRemoverImpl whenever cookies are cleared). [*] https://docs.google.com/document/u/1/d/1TNnya6B8pyomDK2F1R9CL3dY10OAmqWlnCxsWyOBDVQ/edit R=csharrison Bug: 1064747 Change-Id: I989790c932d1fff2f2fe6245b9c66b456f07b31b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120102Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#758983}
-
Aran Gilman authored
Change-Id: I60ac5aebc117aa4282536ae4ada54f847f8c04ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128589Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#758982}
-
David Black authored
Previously, the STOP button would cause the timer to stop ringing. This was sufficient because we only showed a notification for ringing timers. Since we will now show notifications for ticking timers, the STOP button needs to actually remove the associated timer. This CL: - Removes the StopRinging API as it is no longer needed, and there is no need for it anytime soon (to my knowledge). - Adds a RemoveAlarmTimer API. - Updates DeepLinkUtil to reflect changes in possible AlarmTimerActions. - Updates unittests and creates a new browsertest verifying changes. Note that this CL adds assistant_timers_browsertest as assistant_browsertest is growing large. A follow up CL will migrate existing timer browsertests to the new location. Also note that this CL removes support for in-Assistant notification types since it was the sole user of the StopRinging API and there is no plan to launch the feature following standalone UI deprecation. The pipeline to support notifications of multiple types has *not* been removed at this time as it may prove useful later. Bug: b:149570650 Change-Id: I4cbf0da246237f8402b075ace0f0e1c98348e296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132622 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#758981}
-
danakj authored
The enableUseZoomForDSF method is not used in tests. The check for it being enabled does not need to go through WebTestDelegate anymore. R=avi@chromium.org Bug: 866140 Change-Id: I19d23b5e0835d2f2428fa88ae5c35bc0fa035b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148816Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#758980}
-
chrome://discardsSigurdur Asgeirsson authored
Special-casing the 'Discards' tab to the empty tab makes the initial page load navigation entry consistent with entry on back navigation. Bug: 1070554 Change-Id: Ib1d6f271e12d97db31cd03708f89b41a26009e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148539 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#758979}
-
Jesse Schettler authored
CHECKs were added to investigate the cause of the crashes occurring in the PrintRenderFrameHelper when OnPrintPreviewDialogClosed() is called. Remove these CHECKs now that they are no longer needed for the investigation. Bug: 1019847 Change-Id: I38b8c2ff4d7b467871a076d0f19a96665f163858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149284Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#758978}
-
Mark Schillaci authored
This CL modifies the implementation of the ACTION_IME_ENTER action on Android to now use the EditorInfo.IME_ACTION_UNSPECIFIED value as the editor action to perform. Previously this was set to IME_ACTION_NEXT and in some cases was preventing the form from being submitted. Bug: 1057254 Change-Id: I7c429224bc7a1597ca347f079eaef463aacaea84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145959Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#758977}
-
David Bertoni authored
The HistoryApiTest.MiscSearch and HistoryApiTest.TimedSearch tests are no longer flaky. This CL also removes an obsolete test and some broken retry code that is not exercised. Bug: 119505 Change-Id: I21640126da76c61a23558f89c6728f41e1a34fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147681Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758976}
-
Harald Alvestrand authored
On that system (only), there is occasionally "Content-type: text/plain" printed ahead of the test output. Bug: chromium:1069714 Change-Id: Ibd7242c7f7064135de9ede87b7ca366899893599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146539Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#758975}
-
Pavel Feldman authored
See https://chromium-review.googlesource.com/c/chromium/src/+/2148315 for details. Change-Id: I2d1d738ff265505344a394f99a9990429cb96f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149375 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#758974}
-
Jeff Yoon authored
Steps: - Introduced the xcode cache x11e146 in //infra/config/lib/builders.star - The default xcode cache is set in //lib/ci.star under fyi_ios_builder definition, but we only want to roll ios13-sdk-simulator. Check that cache param is overridable, and override it with the newly introduced xcode_cache.x11e146. Update the properties so that the builder uses this too. - 11e146 needs Mac OS 10.15. This definition did not support overriding the default OS, so OS param was introduced into fyi_ios_builder. Set OS for the builder to os.MAC_10_15. - Trybot for ios13-sdk-sim is under //infra/config/buckets/try.star. - the definition is under //infra/lib/try.star, and didn't support overriding the default variables, so they've been included into the parameters. - //infra/config/buckets/try.star was missing the xcode_cache import, so this was appended. - same w/ the ci definition, adding the property too. - Creating variants with 13.4 and updating all sim version usage for this bot from 13.3 to 13.4. 12.4 should be fat bundled. - Updating xcode and xcode cache version for this bot by creating xcode_11e146 in mixins.pyl and apply that in waterfalls.pyl. Bug: 1065456 Change-Id: I54e720efddc05a55ab69f485b9ceb55c1deafa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134940 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#758973}
-
Cliff Smolinsky authored
If the one and only tab in a session is an auto-closed tab, such as a facebook login host, then subsequent launches will restore that tab and immediately close. While this can be worked around by launching to another tab, many users could get lost and frustrated and not know what to do. To fix this, we can detect the situation and force commit the tab close. Bug: 1052096 Change-Id: I7372e2a0a13922abb7f2245b8c4a2edf7514fe95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057627 Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#758972}
-
Elly Fong-Jones authored
Also, replace an existing use of CHROME_VERSION with _MAJOR. Bug: None Change-Id: I838874595dd5e4f11df3c2902745b4d3763b9596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149402Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#758971}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/95e8d00d85d0..8ab5356c195c git log 95e8d00d85d0..8ab5356c195c --date=short --first-parent --format='%ad %ae %s' 2020-04-14 simonmacm@google.com Merge "Add some aggregate values about screen to the battery metrics." Created with: gclient setdep -r src/third_party/perfetto@8ab5356c195c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0991bfca125ea2f4da0fe8926395534f5c037c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148891Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758970}
-
Avi Drissman authored
This was partially removed in r256400; finish the job. Bug: 111652, 350118 Change-Id: I1080786d704b52662aa4d25d24d0ac44d51d09c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149404 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#758969}
-
John Lee authored
This CL continues the work to use cr-row on all pages. This CL attempts to also make pages look a bit more consistent by replacing one-off styles with existing classes, and removes extraneous use of settings-box. Bug: 973674 Change-Id: I1a4fa82b5a8dbfaf06a4fad79fb279ab5b9b2b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148280Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#758968}
-
Matt Menke authored
We should probably not have these requests follow cross-origin redirects anyways, but in the off case they do redirect to the original site, they should not be sending SameSite cookies to it. Fixed: 1070232 Bug: 1060631 Change-Id: Id1e5b700c779f7b20aeba9bd372178aeb83c755f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147924 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#758967}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e52e2dbcdf9d..efca5651464d git log e52e2dbcdf9d..efca5651464d --date=short --first-parent --format='%ad %ae %s' 2020-04-14 bclayton@google.com Device: Rename RoutineCacheT to RoutineCache 2020-04-14 bclayton@google.com Device: Don't inherit [Vertex,Setup,Pixel]Processor. Created with: gclient setdep -r src/third_party/swiftshader@efca5651464d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id589d840907aec481bc032b3aaca8fa6b7788606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148889Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758966}
-
Sam Bowen authored
See this part of the media feeds spec: https://wicg.github.io/media-feeds/#play-next-tv-episodes Some refactoring was necessary also. This is still missing the duration on TV episode and the live details. Because those require changes to the mojo structs, I will do them in a different CL. The general process is: 1) Find all episodes in the Item and get them as EpisodeCandidate 2) Pick main and play next episodes from list of EpisodeCandidate 3) If main episode is present, validate and store it on item->tv_episode 4) If play next is present, validate and store it on item->play_next_candidate It's OK for a TV series to have no EpisodeCandidates, but any it has should be valid. We should perhaps break this up into multiple files. Open to suggestions on that. Bug: 1068751 Change-Id: I37260ee8a905be347e764667921794bb845a4b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146072Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#758965}
-
Alex Moshchuk authored
Bug: 1005895 Change-Id: Ib94a49e4712cf7ff5a5f289f83f653dd8cce7745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147920Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#758964}
-
Raymond Toy authored
This node already supports inputs for the k-rate delayTime AudioParam. Just add a test for this. Bug: 1015760 Test: k-rate-delay-connections.html Change-Id: I0b1a2c5be2b04ca1e960670c82009c343d5699e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148152Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#758963}
-
Elly Fong-Jones authored
This cancel override is essentially a no-op now. There is no cancel button on this dialog so the only call path is via CloseDialog, which always stops the timer before calling into Cancel, so Cancel was always returning true. This change removes the Cancel override and the explicit stop of the timer, which is no longer needed. Bug: 1011446 Change-Id: Ifa6d42591ebcb4063aae05aa959199f407e50df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148678Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#758962}
-
Chris Cunningham authored
Many DB operations are user visible. Blocking DB read can delay the start of site video. Blocking DB clear can delay clearing history. Blocking DB initialize can delay both. UMAs indicate some DB operations take a long while. Hopefully this is the root of the issue. Bug: 1040098 Change-Id: I29c5173cf6d8795990664af0d4584edf6568a794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148120 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#758961}
-
danakj authored
Previously the events were expected to be absolute coordinates relative to the screen, but that made for awkward js in tests, having to pass around frame offsets. In that world it was impossible to find the right value in an OOPIF since the OOPIF can get its frame's position in the *document* from the parent frame, and can see where its frame is on the screen, but doesn't know the size of the browser window, or the position of the parent frame in the screen. This made for some hacky constants in tests. Now we give mouseMoveTo() coordinates relative to the current frame, which works identically in all frames, in process or out. This means that OOPIF tests with input events work in headless mode (as before) but now also work correctly in non-headless mode! Secondly, input events come from come from the browser in physical pixels when UseZoomForDSF is enabled. Similarly EventSender in web tests should scale events to physical pixels so that our events look the same. Web tests are written with device-scale-independent coordinates (which is good, js is this way), but the C++ code all expects physical pixels now when UseZoomForDSF is enabled. So we scale them at the earliest point possible. Fixes drag-drop-to-data-url.html to actually move the mouse onto the target location. It was using an undefined value and moving the mouse to NaN. Fixes tests that were trying to compute global coordinates to just use the element's local position in the frame. R=nasko@chromium.org Bug: 866140, 1069111 Change-Id: I08cd3802d21df25a96ab3adce9f16c256b0785aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141006Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#758960}
-
Brandon Jones authored
Recently added to the AR module, described here: https://immersive-web.github.io/webxr-ar-module/#xrinteractionmode-enum AR module intent to ship here: https://groups.google.com/a/chromium.org/g/blink-dev/c/BXxS2U5EaN0 Bug: 1066237 Change-Id: Iefd898c7bd65593812c3063874687fc3eff4efef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140779Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#758959}
-
Jeff Yoon authored
Official GOMA enabled PGO phase 1 MB configs for PGO builders set under chromium.pgo. Bug: 1068818 Change-Id: Ifceaad778b6bdb929a8ca4a14b2abcab8cce5149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145256Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#758958}
-
Gil Dekel authored
Migrating the supported release branch for PrivacyScreenEnabled and DeviceLoginScreenPrivacyScreenEnabled into M83, instead of referencing to the defunct M82 release. BYPASS_POLICY_COMPATIBILITY_CHECK=tested on M83 Change-Id: I56c1cb918396f3c76030215458be56ebef1a8029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148842Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#758957}
-
Joshua Peraza authored
d9c1ca1216fc [ios] Bring up first draft system snapshot and iOS data collector faae6470cf89 [ios] Bring up first draft exceptions snapshot d3859d91fde0 mac: kern.nx is not present in 10.14.4 et seq, but NX is always enabled af62d7fcf61d Correct use of -[NSString UTF8String] 61a4f3d7d6f6 mac: kern.nx is not present in 10.14.5 et seq, but NX is always enabled e39aacbd66c7 Roll crashpad/third_party/mini_chromium/mini_chromium/ c426ff98e..731e08f06 (1 commit) 194e23910c13 Change for loops to use const references where they did not previously 9da2573ca993 linux: Patch for capget syscall error c4cc4e6ac92d android: initialize signal dispositions de5bc33b8b45 fuchsia: Include reference to zx library b2fd7d5307b0 [ios] Bring up first half of UncaughtExceptionHandler b71a4f1ca8f9 doc: Update buildbot URL 054f45724e68 Revert "fuchsia: Include reference to zx library" 380f2108dfb0 Roll crashpad/third_party/gtest/gtest/ eb78ee170..e3f0319d8 (232 commits) e621aaa13228 Make “gn check” pass 3c44556cf11e Replace ScopedClearErrno with ScopedClearLastError e5dbfa336351 Disable fuzzing without use_fuzzing_engine de43cd37232e Fix Chromium Roll b49dcdc48fd9 Mark static const class/struct members as constexpr Change-Id: I2253529764e48dcf15007ccd2caf9749940c03d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148966 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#758956}
-
Donn Denman authored
Speculative fix for the ContextualSearchManagerTest suite due to omnibox focus issue. Hoping OMNIBOX_SEARCH_ENGINE_LOGO is what's causing the trouble. BUG=1058362, 1063203, 1058663, 1058297 Change-Id: I1d71db509cfd858c0cc6f3733af64b61750ecb97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134852Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#758955}
-
Mustaq Ahmed authored
Also enable regression notification (through issues). Change-Id: I3fe73831a5ceb1ee52df296b5a71349935b3be72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144898Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#758954}
-