- 28 Jul, 2020 40 commits
-
-
Robbie Gibson authored
This reverts commit 42e67c12. Reason for revert: Changed API to use one method to get all content types. Original change's description: > Add async methods to ClipboardRecentContent for URLs > > Bug: 1098722 > Change-Id: Icd9da0e758c288a44716fb6f5a505267a76f42b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302756 > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789987} TBR=olivierrobin@chromium.org,rkgibson@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1098722 Change-Id: I12f08509596dbf534072296dd03b977a57f9ee48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323682Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#792307}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I93642fbd37fda8939c84124d5e68d70db3716b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321576Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792306}
-
Boris Sazonov authored
Replace ChromeSigninController in TabSuggestionsServerFetcher with IdentityManager.hasPrimaryAccount(). This is safe to do, because the native side is already loaded - isSignedIn is only called from isEnabled that uses ChromeFeatureList via isServerFetcherFlagEnabled. Bug: 1046412 Change-Id: I98a119f1e37ca49247e7d8533f532bf2c80f9e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316082Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#792305}
-
Eric Ye authored
display::ConfigureCallback's signature changed in go/cr-rev/2237653 Update call sites that use it. TEST=Build BUG=b/156411764 Change-Id: Ic7981d373aa048d80f5c754e160f7fac0f01c6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322077 Commit-Queue: Eric Ye <ericye@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#792304}
-
Andy Lu authored
Now the Chromium shortcuts should work properly in iOS14. Fixed the issue by checking the widget box in intentdefinition file. This widget box only appears in Xcode 12. Also have confirmed that the changes in Intentdefinition is backward compatible with Xcode 11.5. Bug: 1105446 Change-Id: Iff37a8e4caa74ceea577153803b0f115c13751b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311825Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Commit-Queue: Andy Lu <andyhylu@google.com> Cr-Commit-Position: refs/heads/master@{#792303}
-
John Abd-El-Malek authored
The browsertests should live beside the code they test. Also move the test helpers to be in weblayer/browser so they have access to implementation code. This is a followup to r790896. Change-Id: I8fd1d69308b0780300d641f43d694866f3d2fba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321723Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#792302}
-
Chris Hamilton authored
This makes FrameTokens consistent with WorkerTokens. A further CL will migrate usage of base::UnguessableToken to FrameToken. BUG=1096617 Change-Id: If29b4e50b17b4ead953b378339df214afd619ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314276 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792301}
-
Omer Katz authored
In practice the bailout is need just for when we trace a backing store. A lot of the bailout calls are no longer needed. Bailout calls remaining after this CL are only for HeapHashTableBacking, HeapVectorBacking and tracing inline buffers of vectors. Bug: 986235 Change-Id: I7909dd01559ca7bda3dea43e8f05ab8cabae7912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317190 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#792300}
-
Elly Fong-Jones authored
At pbos@' suggestion :) Bug: None Change-Id: I1e953cfc7ca79cb9eab0e0de448be5e3897c6d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323133 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#792299}
-
evliu authored
This CL removes the registration of the SODA component for builds with the enable_soda build flag disabled. Bug: 1110086 Change-Id: I9b55fde2de20ca24909fcc8bca5de65141128ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321516Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#792298}
-
K. Moon authored
Adds a new Graphics interface to abstract away Pepper-specific calls to pp::Graphics2D. Also introduces a supporting Image class to allow callers to pass either a pp::ImageData or SkBitmap to Graphics. (The caller is responsible for passing the correct type of image.) The interface only has a Pepper backend currently. A future change will add an implementation backed by an SkSurface. Bug: 1099020 Change-Id: I609e13b4b1abff45814feba04ea1c2522b47444d Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310907Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#792297}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/43f111af3540..6df0243a1173 2020-07-28 fmayer@google.com Merge "Relax contract of heapprofd_register_heap." 2020-07-28 treehugger-gerrit@google.com Merge "perfetto-ui: Fix search NaN" 2020-07-28 treehugger-gerrit@google.com Merge "Make TSAN happy about WaitableTestEvent." 2020-07-28 treehugger-gerrit@google.com Merge "Remove unnecessary TEST_SKIP." 2020-07-28 khokhlov@google.com Merge "trace_processor: Lower priority for thread names from metadata events" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4d0a671d9cf108d3f8c5fdef890bae1abe0cd908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322593Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792296}
-
Chris Hamilton authored
This adorns SharedWorkerScope with the SharedWorkerToken generated by the browser. BUG=1085129, 1096617 Change-Id: Ib335d7f509e8f9fd5b33e5deca6083f4932fa8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317851 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#792295}
-
Scott Violet authored
onNavigationStarted() was mentioned twice. The second should be onNavigationRedirected. BUG=none TEST=comment only change Change-Id: I0a6b23a1877256ab09532d4adc8c105345a89a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323708 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#792294}
-
Mohamed Heikal authored
A special case rename was added previously because of a rollback of the protobuf runtime. The protobuf runtime has since been rolled forward and thus the special case in BuildConfigGenerator.groovy is no longer needed. Change-Id: Idb392d0fe1aca25e365ae4f53e14e71ba85cbddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323588 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#792293}
-
Maksim Sisov authored
Don't follow Ozone path if the OzonePlatform feature is disabled. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how th finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: Ie9bb59c67d5b5aafadd142675e0b568928b5ca5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316198Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#792292}
-
Ian Kilpatrick authored
TBR: dgrogan@chromium.org Bug: 1110253 Change-Id: Ia4c6c8314ccf6c2228df3025c6740e8c28d9b286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323584Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#792291}
-
Andreea Bacanu authored
Metrics added: - TabManager.TimeSinceTabClosedUntilRestored: records the time from when a tab was closed until the Reopen Closed Tab button was clicked or Ctrl+Shift+T/ Command+Shift+T was pressed. - TabManager.TimeSinceWindowClosedUntilRestored: records the time from when a window was closed until the Reopen Closed Window button was clicked or Ctrl+Shift+T/ Command+Shift+T was pressed. altimin: histograms.xml sky: session_restore_browsertest.cc, tab_restore_service_helper.cc BUG=1100946 Change-Id: Ic6d3196abd8907cda5be12cdc32ce83a82e97060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294090 Commit-Queue: Andreea Bacanu <aebacanu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#792290}
-
Alex Ilin authored
TabGridDialogTest#testRenderDialog_3Tabs_Landscape__NightModeEnabled is flaky both on CI bots and on CQ bots. TBR=yusufo@chromium.org Bug: 1110099 Change-Id: I8428cc3a585b3e7f2ff5515f699c071defd87298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323291Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792289}
-
Joshua Pawlicki authored
Bug: 1099779 Change-Id: I877767ccc0fc7fad10cd2da9120413fd5db65a6a Fixed: 1099779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323781 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792288}
-
Victor Hugo Vianna Silva authored
TBR=treib@chromium.org Bug: None Change-Id: I4b11408d8e341bf817b0ffb0a5bb52d12bf43f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323332Reviewed-by:
Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#792287}
-
Tarun Bansal authored
Change-Id: Ia41e86c6a4122da1091ee78297e921cd327f3e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321396Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#792286}
-
ckitagawa authored
This CL adds a framework and a basic test for displaying multiple- frames for the Player Test. This allows us to exercise and test much more of the functionality of the player and help avoid regressions. Follow-up CLs will add a test for - Scrolling subframes - Scaling with subframes - Link clicks of subframes - And possibly render tests Bug: 1106035 Change-Id: Iada1df0ce929bde2b38907a38725efd1edcd5a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316407Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#792285}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I816483446ccb065e7ebe20c0581f30c7a9192ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323248Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792284}
-
Sharon Yang authored
When the SemanticTree disconnects because of an invalid update, the corresponding web.Frame will be closed and destroyed. Test: AccessibilityBridgeTest.Disconnect Bug: fuchsia:53033 Change-Id: Ic209714d54276e1b13ce81467a18fbe44b3d09b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285321 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792283}
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/41a6263fd0..d39fe6cd6f Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/41a6263fd0..d39fe6cd6f Bug: None Change-Id: Ifc9f505e30b3b1453efecf5ecc24f8b53987e2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322806Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#792282}
-
Antonio Sartori authored
This CL fixes the fallback behaviour of the Content Security Policy script-src to default-src with regards to blocking eval in iframes and, under certain conditions, when navigating to a new page. Bug: 1107824 Change-Id: Ia5cbe82188fde25cec8ccb5a09322e598a419434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316105 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#792281}
-
Mohamed Heikal authored
Vulnerability reports are not meant for checking in but just for local viewing. Change-Id: If0f7d6eb905564542a0d365053e8adecf12dcab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323502 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#792280}
-
Liquan (Max) Gu authored
Changes: * Move updateAppModifiedTotals into PaymentUIsManager * Since the method include mModifiers, refactor getModifiers() to make it less error-prone. The refactoring includes renaming it getUnmodifiableModifiers() to make it explicit that the modifiers is unmodifiable (although the name is funny) and implicates that it's not just returning mModifiers itself. * Since mModifiers now can be null and be empty, which is redundant and thus error-prone, this CL make it not nullable. Bug: 1102522 Change-Id: I26229494eb39e3f8c4629f711607c7d199fe3b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316321 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792279}
-
Hazem Ashmawy authored
Fixed: 1108421 Test: None Change-Id: I61340349ac26d619bf65fcc488d225d5a1a9641c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323333 Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#792278}
-
sauski authored
The SettingsPrivateEventRouter is written such that it expects to be shutdown before the GeneratedPrefs service, this CL makes this expectation explicit by declaring a dependency in the service factory. Bug: 1110305 Change-Id: Ica1844daa151d1f1fd161e155a313c66e066f325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323370Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#792277}
-
Ioana Pandele authored
The PasswordCheckBridge needs to signal its C++ counterpart when it's no longer needed in order to free up memory. Since the C++ bridge gets destructed, we need to destroy the entire PasswordCheck component, so that we don't end up with a partially initialized object. The object responsible for the tear-down is the last object to need the component. Possible cases are: MainSettings > PasswordSettings > PasswordCheck -> MainSettings should call destroy PasswordSettings > PasswordCheck -> PasswordSettings should call destroy MainSettings > SafetyCheck > PasswordCheck -> MainSettings should call destroy PasswordCheck (launched from the leak dialog) -> PasswordCheck should call destroy Bug:1102025, 1101256 Change-Id: I6706ab489049da2192ccb8c03632cc5a7fe38609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297504 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#792276}
-
Saurabh Nijhara authored
We get CRX_FETCH_URL_EMPTY failure reason with check status as noupdate and empty info field when the extension being requested is no longer being served by the Chrome Web Store and this can be considered as an admin side misconfiguration. Bug: 1063031 Change-Id: I61f2beca94ea38faa32b1539bff42318fce7a6a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306044 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#792275}
-
Chris Hamilton authored
This replaces the use of SharedWorkerId. Further CLs will plumb the generated token into the renderer process where it will be used to adorn the associated WorkerOrWorkletGlobalScope. BUG=1096617 Change-Id: If23756e40ccbdf02f72a173d32addd5247f544bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313102 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#792274}
-
Anastasiia N authored
Currently ProfileOAuth2TokenServiceDelegateChromeOS doesn't remove cached errors on account removal. GetAuthError() should return GoogleServiceAuthError::AuthErrorNone() if account is not present in Account Manager. Change-Id: I8d9e7ab0328c9eb6f4eb79d4e46c2138cd74cbf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302634 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#792273}
-
Tomasz Wiszkowski authored
This change corrects the delimiter used for subtype logging from previously used . to a correct i. There are no functional changes included in this CL. Bug: 1110104 Change-Id: Ie2b8b4b7fe764d85e5e936853a42bf8057b0e73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321512Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Ender
💬 =🕐 (ping me for faster reviews) <ender@google.com> Cr-Commit-Position: refs/heads/master@{#792272} -
My Nguyen authored
Track user retention for assistive features. Bug: 1108251 Change-Id: I2986c193194c35e0b502cc9d8f8384b292a4582d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311986 Commit-Queue: My Nguyen <myy@google.com> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#792271}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f31e5f45..e8188f21 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7f934280fc258d0f36c556a8e08190da0f0ff880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321450Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792270}
-
Stephen Martinis authored
This CL modifies the PRESUBMIT.py files in directories which are likely to affect the Chromium CQ. It changes it to require a git footer in CLs which touch them, and adds an error message if the footer isn't present. See the linked bug for more details on the production freeze. No-Try: true Ignore-CQ-Freeze: Implementing CQ Freeze Bug: 1109980 Change-Id: Ibfd41a2a0cf7a8f3f0e6a1ad930e3e2e6b8407d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320992Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#792269}
-
dpapad authored
Specifically: - bookmarks_test - material_elements_test - params_parser_test Bug: 1000989 Change-Id: Ife9caa747482afe05eed471f4a70f85fa77e7cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321243 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#792268}
-