- 20 Jul, 2018 40 commits
-
-
Peter Collingbourne authored
With this change we use the same serialization regardless of whether we are targeting a 32-bit or a 64-bit machine. Bug: 865796 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7a9f0a3b5d25569693bb5efec73c3f5cd256c39b Reviewed-on: https://chromium-review.googlesource.com/1139106Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#577038}
-
Vladimir Levin authored
R=pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I03184eb50cd70b737c31244aa0e4b2681c0892ee Reviewed-on: https://chromium-review.googlesource.com/1145789 Commit-Queue: vmpstr <vmpstr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577037}
-
Clark DuVall authored
Previously, if a request was made before any web request listeners or rules were added, the URLLoaderFactory would not be proxied through the browser process to run the WebRequest code. Now, if it is detected that WebRequest listeners/rules are added, we reset the bindings so they will be recreated and proxied through the browser process. Observers were added for a few classes so WebRequestAPI can listen to rule changes. Changes in URLLoaderFactoryGetter were needed due to crbug.com/613371. Bug: 857577 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I7805be86512545b496e30b9693374981fdc2633e Reviewed-on: https://chromium-review.googlesource.com/1139048 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#577036}
-
Jonathan Metzman authored
Change protobuf_library to compile everything for the full protobuf runtime when use_libfuzzer=true is passed to GN. Bug: 860750,861746 Change-Id: I43d4c51f686895fc8aafb8bdae368815aee4ace2 Reviewed-on: https://chromium-review.googlesource.com/1128249Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577035}
-
Xu Xing authored
gpu::Scheduler executes task in the main thread. No need to call base::ThreadTaskRunnerHandle::Get. BUG=None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I4ef0ba6c6a7ebeffdb721eaaec7b6d0a82e6cfde Reviewed-on: https://chromium-review.googlesource.com/1144790Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#577034}
-
Moe Ahmadi authored
Prior to this change form data were being discarded after a dynamic form submission. This was because the dynamically changed form was being added to the cache with its user entered/autofilled values. At the time of submission, form data were being discarded as they were thought to be the initial values of the fields at page load. This CL changes AutofillHandler::OnFormsSeen (which is called on dynamic form changes) to attempt to find a previously cached version of the form first. Prior to addition to the cache, form values are overridden by the cached values. This prevents those values from getting confused with the initial form values at the time of submission. Bug: 863954 Change-Id: Iba4771ee87b9777e66a6b10b6b369379dc123a46 Reviewed-on: https://chromium-review.googlesource.com/1137021 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#577033}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I8bf0d6f701acacab271a44dd23f80ff6ac303de0 Reviewed-on: https://chromium-review.googlesource.com/1145043Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#577032}
-
Bin Wu authored
Remove QuicPerConnectionPacketWriter code, it's only used in tests/tools, not in production. Not protected. QuicPerConnectionPacketWriter serves one purpose: allow multiple connections to share the same underlying writer, without destroying the writer when individual connection is destroyed. This can be achieved by setting the connections' writers to the same underlying writer and set owns_writer to false. If a server needs to create a per connection writer with special behavior(anything other than pass through), the server can overwrite the CreateQuicSession method and create whatever per connection writer it wants. Merge internal change: 205438337 R=rch@chromium.org Change-Id: Iebb33163dceef61c501441d4f708eb21a512cf4a Reviewed-on: https://chromium-review.googlesource.com/1145494Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#577031}
-
Manuel Rego Casasnovas authored
An element with "contain: layout" should be the containing block of any absolutely or fixed positioned descendants. The spec is very clear regarding this (https://drafts.csswg.org/css-contain/#containment-layout): "The element acts as a containing block for absolutely positioned and fixed positioned descendants." This was already implemented in r559045 but it was reverted temporary as some sites (like YouTube on mobile) got broken. For that reason we added a use counter, that is now in lower numbers since YouTube has been updated to follow the new behavior. The WPT test suite already has tests covering this, so this patch just removes them from TestExpectations file. BUG=785212 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I381af403bba1b6976e88ac02a462b28c424aa3af Reviewed-on: https://chromium-review.googlesource.com/1144939 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#577030}
-
akaba authored
A follow up CL to https://chromium.googlesource.com/chromium/src.git/+/ebc96c6441c8c03dfde6ddd04b0b8465a83c858e to make DelegatedFrameHost::EvictDelegatedFrame consistant with DelegatedFrameHostAndroid::EvictDelegatedFrame. Bug: 861764 Change-Id: I71b5e3a4c34f08f911bc0022d2b2dcb08427bb5a Reviewed-on: https://chromium-review.googlesource.com/1141991Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Andre Kaba <akaba@google.com> Cr-Commit-Position: refs/heads/master@{#577029}
-
Eric Karl authored
Shader::DoCompile is a source of frequent watchdog hangs (it involves both ANGLE shader translation, as well as driver compilation steps). Adding ExitCommandProcessingEarly after any calls to Shader::DoCompile. Bug: 844780 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I58eae185384db7859f9ab451496e25da7c556c9c Reviewed-on: https://chromium-review.googlesource.com/1144530Reviewed-by:
-
Kyle Horimoto authored
Some Proto messages are sent to Apiary endpoints, which translate Proto enums to strings instead of leaving them as enums. Though this doesn't interact normally with Protos, this behavior has been present in Apiary from the beginning and is not considered a bug. See this change for details: https://critique.corp.google.com/#review/187680679. Thus, when communicating with those endpoints, the proto values should be converted from enums to strings when send messages to Apiary and should be converted from strings to enumsm when receiving messages from Apiary. This CL adds these conversion functions and integrates them throughout CryptAuth. Bug: 824568 Change-Id: Icc2367a6a325fe9da42905f9456d2b2103c5eb25 Reviewed-on: https://chromium-review.googlesource.com/1145588 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#577027}
-
sczs authored
Bug: 865507 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I68feba19be76ca9e7b185073ac51111fe954e7ad Reviewed-on: https://chromium-review.googlesource.com/1145684Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#577026}
-
Oksana Zhuravlova authored
Bug: 855308 Change-Id: I8c8ab5d3787dda1be5e7b075eb34f35555231201 Reviewed-on: https://chromium-review.googlesource.com/1145583Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#577025}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c68109a2dac3..fda907f4ac7e git log c68109a2dac3..fda907f4ac7e --date=short --no-merges --format='%ad %ae %s' 2018-07-20 tsepez@chromium.org Replace downcasts in cxfa_node to checked conversion methods. Created with: gclient setdep -r src/third_party/pdfium@fda907f4ac7e The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I16ae7ef80a9bbb581d0eb1746bb270cfd4e56b5d Reviewed-on: https://chromium-review.googlesource.com/1145409Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577024}
-
Marton Hunyady authored
Add a new rollback icon (vertically flipped update icon) and use it in the rollback notification. Screenshot: https://screenshot.googleplex.com/UebqEykm9P7.png Bug: 863088 Change-Id: I45dea5daac43469349a0cccd166a6338532ce55f Reviewed-on: https://chromium-review.googlesource.com/1145071Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Marton Hunyady <hunyadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#577023}
-
Jun Mukai authored
This CL introduces the support of text-input-unstable protocol defined in wayland-protocols repository. This CL will be the first one for a series of CLs for supporting this protocol and lacks some parts surrounding text. BUG=826614 TEST=manually, exo_unittests Change-Id: I4f4e335ed26c51beea9f25479acc63e11f09f777 Reviewed-on: https://chromium-review.googlesource.com/1132332 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#577022}
-
Michael Warres authored
Disable PreSharedKey(Mismatch|NoClient|NoServer) tests modified in merge of 204151972, until we have a way to reduce their execution time. https://chromium-review.googlesource.com/c/chromium/src/+/1144723 Remove flag protected CHECKs for oob access into sent packet manager's unacked_packets, and deprecate FLAGS_quic_reloadable_flag_quic_extra_checks_in_ack_processing. (This is an automated g4 rollback of changelist 200621124.) Merge internal change: 204780431 https://chromium-review.googlesource.com/c/chromium/src/+/1144721 Move EXPECT_QUIC_BUG from quic_test_utils.h to quic_expect_bug.h. Merge internal change: 204379034 https://chromium-review.googlesource.com/c/chromium/src/+/1144720 Deprecate FLAGS_quic_reloadable_flag_quic_deprecate_scoped_scheduler2. Merge internal change: 204335685 https://chromium-review.googlesource.com/c/chromium/src/+/1144499 Deflake PreSharedKey(Mismatch|NoClient|NoServer) tests in net/third_party/quic/core/end_to_end_test.cc. Test only, not protected. Merge internal change: 204151972 https://chromium-review.googlesource.com/c/chromium/src/+/1144497 Make QuicStreamTest no longer depend on SPDY code. Merge internal change: 203996363 https://chromium-review.googlesource.com/c/chromium/src/+/1144495 Enable time-based loss detection for Quartc (connection option TIME). Merge internal change: 203982907 https://chromium-review.googlesource.com/c/chromium/src/+/1144493 Add a BBQ5 QUIC connection option that expires ack aggregation measurements when the bandwidth has increased by 25% in STARTUP. Protected by FLAGS_quic_reloadable_flag_quic_bbr_slower_startup4. Merge internal change: 203819207 https://chromium-review.googlesource.com/c/chromium/src/+/1144490 Default QUIC's time based loss detection to 1/8 RTT instead of 1/4 RTT, as specified in the current IETF recovery draft. Protected by FLAGS_quic_reloadable_flag_quic_eighth_rtt_loss_detection. Merge internal change: 203780344 https://chromium-review.googlesource.com/c/chromium/src/+/1144489 Deprecate FLAGS_quic_reloadable_flag_quic_export_connection_write_packet_results. Merge internal change: 203765741 https://chromium-review.googlesource.com/c/chromium/src/+/1144488 R=rch@chromium.org Change-Id: Id20a1cfa76dc12942361cf9b64e88be9e7e1e4e1 Reviewed-on: https://chromium-review.googlesource.com/1145700Reviewed-by:
-
Etienne Pierre-doray authored
This CL refactors ukm debug page. The new version uses WebUI and is implemented in HTML/JS. Bug: 843181 Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I593518d10df17bb3c49961cb2ab590788b4d8efc Reviewed-on: https://chromium-review.googlesource.com/1142481 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#577020}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c03be1848479..ddcfa34d6ad4 git log c03be1848479..ddcfa34d6ad4 --date=short --no-merges --format='%ad %ae %s' 2018-07-20 jbudorick@chromium.org telemetry: check that android external storage is writable. Created with: gclient setdep -r src/third_party/catapult@ddcfa34d6ad4 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:862106 TBR=sullivan@chromium.org Change-Id: Id77919ecdb9d2fb43a952dd52247a4245c786403 Reviewed-on: https://chromium-review.googlesource.com/1145405Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577019}
-
David Black authored
Similar pattern to AssistantInteractionSubscriber and AssistantNotificationSubscriber. Pipeline will be used to pass screen context events. The first event (implemented here) delivers contextual card HTML. A follow up CL will render this HTML in a WebContents in the same way that we currently do for non-contextual card HTML. Bug: b:111008970 Change-Id: I0cab9491f8525ed17fea8c72bd005b3ef2bce9ed Reviewed-on: https://chromium-review.googlesource.com/1142741 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#577018}
-
Martin Kreichgauer authored
This extends the scope of these checks to cover non-device authenticators (like Touch ID). The following checks are moved from MakeAssertionTask into MakeAssertionRequestHandler: - |CheckRpIdHash| to verify the RP ID of the request matches the returned credential. The following checks are moved from GetAssertionTask into MakeAssertionRequestHandler: - |CheckRpIdHash| to verify the RP ID of the request matches the returned credential. - |CheckRequirementsOnReturnedUserEntities| to check constraints on the optional UserEntity response field. - |CheckRequirementsOnReturnedCredentialId| to check whether the returned credential id was in the allow list (except for resident keys). Also fixes the following bugs in |CheckRequirementsOnReturnedCredentialId|: - Responses with resident key support should still have their response checked against the allow list if one was provided. - For allow lists of size 1, the credential id may be omitted in the reponse; but if it is not, it must be checked against the allow list. Corresponding unit tests are moved accordingly. Bug: 863988, 678128 Change-Id: If7b76e7ecac45d96914a62661da9979c62895a25 Reviewed-on: https://chromium-review.googlesource.com/1144403 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577017}
-
Wenzhao Zang authored
TBR=cpu@chromium.org Bug: b/110114882 Change-Id: I79e81cc4e02aedee55bb9d2e63d849eecb75e516 Reviewed-on: https://chromium-review.googlesource.com/1145790Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#577016}
-
Quan Nguyen authored
Correctly handle powerwash dialog cancellation. Bug: 837501, 838876 Change-Id: I2cabd6d4d8e87444e93b0fdf69ac0e688201cdf0 Reviewed-on: https://chromium-review.googlesource.com/1144531Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577015}
-
jimmy authored
Correctly capitalize smb->SMB in smb_file_system.h comments. Bug: chromium:757625 Change-Id: I8d708c2ef8a29bc9f752fe50177b0a726191b974 Reviewed-on: https://chromium-review.googlesource.com/1144130Reviewed-by:
-
Findit authored
This reverts commit e61ec2a1. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 576882 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2U2MWVjMmExMmIxMTQ0MDgyZjc2ZjM3MTQ0MjUwYTRkNGRkNmJmMTgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/10896 Sample Failed Step: network_service_content_browsertests Original change's description: > Complete the plumbing of CanvasResource through CanvasResourceDispatcher > > This CL completes the the last link of plumbing allowing CanvasResource > objects of any type to be pushed all the way through to the compositor. > > BUG=788439 > TBR=fserb@chromium.org > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I08c9775b0e62e5dd7fd3a9cb73d0b6dba0e43ccc > Reviewed-on: https://chromium-review.googlesource.com/1144602 > Commit-Queue: Justin Novosad <junov@chromium.org> > Reviewed-by: Justin Novosad <junov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576882} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=788439 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I42ef501b5c4b1e11e2de9a0524241f72f4ea54fa Reviewed-on: https://chromium-review.googlesource.com/1145202 Cr-Commit-Position: refs/heads/master@{#577013}
-
Tibor Goldschwendt authored
This prepares for synchronized proguarding and allows us to configure the base modules differently than the Chrome APKs. + Stop making an APK if building a module. Bug: 862696 Change-Id: I28b245888241e3519454c8957fcf0e460925f459 Reviewed-on: https://chromium-review.googlesource.com/1138870 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#577012}
-
mark a. foltz authored
PresentationServiceImpl::OnConnectionMessages is not defined or used. TBR=takumif@chromium.org Change-Id: I82d405c62731b2d0097b7074bfddac594796fcae Reviewed-on: https://chromium-review.googlesource.com/1145739 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577011}
-
Daniel Murphy authored
This is a reland of 1bd58466. I want to get this feature back on in Canary so I can continue to see crashes in the wild - there are still no crashes reproduced in tests or reports. TBR=jam@chromium.org TBR=mek@chromium.org Original change's description: > [SessionStorageS13N] Enabling mojo SessionStorage by default > > Bug: 716490 > Change-Id: I08c9bc35d1e9f8f86adc6c88fb7ab8069bcf7e8f > Reviewed-on: https://chromium-review.googlesource.com/1072918 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563169} Bug: 716490 Change-Id: I6c91ffb8302ea9bead0809ef293f9a007edd608c Reviewed-on: https://chromium-review.googlesource.com/1145201 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#577010}
-
Weiyong Yao authored
use a "randomly generated device ID" scheme, like that employed by the desktop capture API. Bug: 163100, 831722 Change-Id: Idcf46dad59bc822c2a5115418420e22775269068 Reviewed-on: https://chromium-review.googlesource.com/1093439Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#577009}
-
Daniele Castagna authored
Change-Id: Icae076f5703922c087ba4da030e5ed7350981e50 Reviewed-on: https://chromium-review.googlesource.com/1145704Reviewed-by:
-
Allen Bauer authored
Bug: 865898 Change-Id: I4c25a2900927b979f697f426eb92da2d68ecff7b Reviewed-on: https://chromium-review.googlesource.com/1145722Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#577007}
-
Vladimir Levin authored
This patch ensures that we don't reschedule an image loading microtask if there is one pending already. This is important to ensure that image decode microtasks see the image data (ie the image loading microtask runs first) if there are no other changes only insertion into a document. The existing tests that were added for this still pass (from crrev.com/cdd15633) http/tests/misc/image-blocked-src-change.html http/tests/misc/image-blocked-src-no-change.html http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded.html The new test fails without the change and passes with. R=chrishtr@chromium.org Bug: 864306 Change-Id: I1d3d2ed4c12b53fab931e55a85c4f5cd18fe1cc4 Reviewed-on: https://chromium-review.googlesource.com/1141121Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577006}
-
Kenneth Russell authored
Patch from dansnyder@. Negative times are being seen on certain platforms (the Android P preview and some Cast devices, in particular). Handle them gracefully rather than asserting. Bug: 856858 Tbr: jochen@chromium.org Change-Id: Ib05cb8534bec9e6a95df2f989a9d65fedfeece0b Reviewed-on: https://chromium-review.googlesource.com/1142238 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#577005}
-
Daniel Bratell authored
Three files had their own logging glCompileShader wrapper named CompileShader and in jumbo build experiments those clashed. This makes that helper function shared, makes the logging a little more accepting of long error messages, but loses a little bit of information about where the code was called from. Bug: 864986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If7e518cc993e165c2f51c4b32a7f1df96d31ad5d Reviewed-on: https://chromium-review.googlesource.com/1143266Reviewed-by:
-
sczs authored
TextItemColorBlack was being used as the default color even if textColor was not being set. This was causing the item label to skip the styler textColor for the label. This CL fixes that problem and introduces some unit_tests to check this. Bug: 865808 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic9e7d368d4acb5cab8f2585762c69363c1143749 Reviewed-on: https://chromium-review.googlesource.com/1145584Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/807abf149a5d..60b9b6fb9147 git log 807abf149a5d..60b9b6fb9147 --date=short --no-merges --format='%ad %ae %s' 2018-07-20 ehmaldonado@chromium.org git_hyper_blame_test: Fix pylint issue. 2018-07-20 vapier@chromium.org pylint: reland upgrade to 1.5.6 2018-07-20 ehmaldonado@chromium.org gclient: Report project url if it's a known project. Created with: gclient setdep -r src/third_party/depot_tools@60b9b6fb9147 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:863669,chromium:863669,chromium:832386 TBR=agable@chromium.org Change-Id: I822581246815ddb4c1c4a6a8edd0b93a97dac033 Reviewed-on: https://chromium-review.googlesource.com/1145407Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577002}
-
Chris Harrelson authored
The refactoring aspect re-landed earlier; this is a re-land of the core logic in [1] with a bugfix for the case when a lifecycle update to PrePaintClean intervened after property tree dirty bit mutation. [1] https://chromium.googlesource.com/chromium/src/+/cdea59c0db145f8e85ea00e9f6d31642929e2397 Bug: 831762 Change-Id: I3cea18ee7b6ef8865e8db6733de90197451f9589 Reviewed-on: https://chromium-review.googlesource.com/1144630 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577001}
-
Jonathan Ross authored
Some tests which were in general failing for Viz have been fixed. However it was missed re-enabling them on the Android filter. This updates the filter accordingly. TBR=fsamuel@chromium.org TEST=viz_content_browsertests SitePerProcessHitTestBrowserTest.CrossProcessMouseEnterAndLeaveTest* SitePerProcessHitTestBrowserTest.CrossProcessMouseCapture* SitePerProcessHitTestBrowserTest.HitTestStaleDataDeletedView* SitePerProcessHitTestBrowserTest.RootConsumesScrollDuringOverscrollGesture* Bug:849746 Change-Id: I9b487e0699284b5b61265ffcfb3b6a664a2f5f08 Reviewed-on: https://chromium-review.googlesource.com/1145410Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#577000}
-
Ian Clelland authored
Bug: 703703 Change-Id: I4ab576d16835e13ad618e4e2794132be1a80f845 Reviewed-on: https://chromium-review.googlesource.com/1144274Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#576999}
-
