GitLab

This fixes the failing policy_prefs_ui tests testTogglePolicyTogglesBanner and testPoliciesShowBanner and re-enables these tests.

BUG=102546
TEST=policy_prefs_ui

Review URL: http://codereview.chromium.org/8423031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108230 0039d316-1c4b-4281-b951-d872f2087c98

Be sure it is disabled or enabled as expected.

Be sure it is using the same basic function as TimeTicks.

r=rtenneti
Review URL: http://codereview.chromium.org/8437018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108228 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101407


Review URL: http://codereview.chromium.org/8437026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108227 0039d316-1c4b-4281-b951-d872f2087c98

Textures and Renderbuffers are now cleared at the
last possible moment. This allows them to be cleared
only when absolutely necessary.

TEST=unit tests
BUG=99554


Review URL: http://codereview.chromium.org/8341128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108226 0039d316-1c4b-4281-b951-d872f2087c98

1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs.
2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available.
3. Correctly handle the adding and removing of page title words when a URL change is detected.
4. Other small cleanups.

BUG=96731, 92718
TEST=Unit tests updated.
TBR=atwilson (for profile_sync_service_typed_url_unittest.cc)
Review URL: http://codereview.chromium.org/8384024

TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/8437035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108224 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20053
TEST=see bug
R=sky@chromium.org

Review URL: http://codereview.chromium.org/8372038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108219 0039d316-1c4b-4281-b951-d872f2087c98

Disallow wildcards from matching top-level registry controlled domains during cert validation.

BUG=100442
TEST=net_unittests:X509CertificateNameVerifyTest.*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107075

Review URL: http://codereview.chromium.org/8362023

TBR=rsleevi@chromium.org
Review URL: http://codereview.chromium.org/8438024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108216 0039d316-1c4b-4281-b951-d872f2087c98

WebRange::fromDocumentRange() can return a null range. I don't
know when this happens in practice, but there are crash reports
for it.

BUG=100884
TEST=none


Review URL: http://codereview.chromium.org/8423022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108214 0039d316-1c4b-4281-b951-d872f2087c98

dchecks because it tries to post a task to the file thread, but chrome is shutting down so post fails

This makes startup tests flaky.

BUG=none
TEST=startup tests do not crash, ask nsylvain.

Review URL: http://codereview.chromium.org/8438017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108213 0039d316-1c4b-4281-b951-d872f2087c98

- This modifies the way we build the browser accessibility tree in CreateAccessibilityTree. We still build the parent child links while recursing depth first through the WebAccessibility structure, but this patch changes the initialization of a node to occur *after* the children have been fully populated into the subtree of any given node.
- implements IAccessibleHypertext on a BrowserAccessibilityWin. Adds:
-- a string for the hypertext which contains the text of the static text children concatinated together along with the embedded characters for the non-text children.
-- map from the character offset within the hypertext to a hyperlink index.
-- a collection of children that are hyperlinks (basically nodes that are not static texts).
- adds no-op implementations of IAccessibleHyperlink and IAccessibleAction as required by the usage and interface inheritance of IAccessibleHyperlink.

BUG=99629

TEST=manually tested with NVDA.

Review URL: http://codereview.chromium.org/8416034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108211 0039d316-1c4b-4281-b951-d872f2087c98

1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs.
2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available.
3. Correctly handle the adding and removing of page title words when a URL change is detected.
4. Other small cleanups.

BUG=96731, 92718
TEST=Unit tests updated.
TBR=atwilson (for profile_sync_service_typed_url_unittest.cc)
Review URL: http://codereview.chromium.org/8384024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108207 0039d316-1c4b-4281-b951-d872f2087c98

- Move TabFirstRenderWatcher out of chromeos and combine the logic with HTMLDialgoView.
- Update HtmlDialogBrowserTest.TestStateTransition and move state transition test into TabFirstRenderWatcherTest.TestStateTransition;
- HtmlDialogBrowserTest.TestStateTransition -> WebContentRendered as it only tests OnTabMainFrameFirstRender is callled now;
- Conslidate two TestHtmlDialogUIDelegate into one;

Will share it with the auro app list window to avoid initial jankiness.

BUG=98308,86059
TEST=Hold until all app list changes are in.


Review URL: http://codereview.chromium.org/8417005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108206 0039d316-1c4b-4281-b951-d872f2087c98

This also fixes views::TextButton so that the focus rect is drawn
with an appropriate inset.

TEST=Trigger an infobar (Translate, Save Password, etc.), type Ctrl+L to focus location bar, press Tab to focus controls in info bar.

Review URL: http://codereview.chromium.org/8439015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108202 0039d316-1c4b-4281-b951-d872f2087c98

TEST=should be enabled by default and disablable in about:flags
BUG=none
Review URL: http://codereview.chromium.org/8387060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108200 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108199 0039d316-1c4b-4281-b951-d872f2087c98

TBR=caseq
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8438019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108198 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: No need to dynamically allocate a couple class members in mime_util_xdg.cc. Also convert a dynamically allocated class member to a scoper.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8372047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108197 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102584
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/8351058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108196 0039d316-1c4b-4281-b951-d872f2087c98

UnzipEvil and UnzipEvil2 check that we don't extract files containing ..
in their file names. These tests failed if we had
"levilevilevilevilevilevilevilevilevilevilevilevil" and "evil.txt" in /tmp
on Linux, as we were checking the existence of these files from a temporary
directory like /tmp/.org.chromium.Chromium.aXW1Gx.

We should create a directory one level deeper to fix the subtle issue.

TEST=touch /tmp/levilevilevilevilevilevilevilevilevilevilevilevil /tmp/evil.txt; out/Release/unit_tests --gtest_filter=ZipTest.*
BUG=chromium-os:22351


Review URL: http://codereview.chromium.org/8437016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108195 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8438010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108194 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/8423025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108193 0039d316-1c4b-4281-b951-d872f2087c98

 With this CL, window is now correctly maximized/fullscreen'ed on aura desktop.

* Added OnPropertyChanged to WindowObserver
* Added Get/Set IntProperty to simplify handling int value properties.
* Remove IsOrContainsFullscreen. Added Workspace::ContainsFullscreen instead. We need this to autohide launcher.

BUG=97257,97259
TEST=new test for property change notification. existing tests are updated, except maximized/fullscreen drag test. I'll add it to new set of tests that verifies window dragging within workspace.

Review URL: http://codereview.chromium.org/8400063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108192 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92254
TEST=AudioRendererBaseTest::Underflow_EndOfStream


Review URL: http://codereview.chromium.org/8430015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108191 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8439019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108190 0039d316-1c4b-4281-b951-d872f2087c98

use of legacy callbacks and generally simplifies the implementation. Also migrate one instance
of NewRunnableMethod to base::Bind().

BUG=98478
Review URL: http://codereview.chromium.org/8390018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108189 0039d316-1c4b-4281-b951-d872f2087c98

Updated TypedUrlChangeProcessor to handle ADDs and UPDATEs in the sync DB identically.

Also removed our code that explicitly sets the title in the history DB as that
should not be necessary (it's already set by UpdateURLRow).

Finally, removed our code that was setting last_visit_time since that is also
updated automatically by the history code when we add/remove visits. We still
set it when we initially add the URL to the DB, but that's only because the
history code requires it - we technically don't need to since we always manually
add visits immediately afterward.

BUG=101633
TEST=existing tests suffice


Review URL: http://codereview.chromium.org/8414043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108188 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8440018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108187 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102408
TEST=See bug

Review URL: http://codereview.chromium.org/8372036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108186 0039d316-1c4b-4281-b951-d872f2087c98

Linux: Use the existing desktop environment detection code in mime_util_xdg.cc instead of its own version. Also fix a case where we look up bad icon names.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8431018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108185 0039d316-1c4b-4281-b951-d872f2087c98

Also adds some extra error logging.

BUG=None
TEST=Go into curtain mode on 10.7 and then disconnect the session.


Review URL: http://codereview.chromium.org/8384011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108184 0039d316-1c4b-4281-b951-d872f2087c98

notifications.NotificationsTest.testOriginPrefsNotSavedInIncognito

BUG=chromium:102549
TEST=None

Review URL: http://codereview.chromium.org/8438018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100928
TEST=see bug


Review URL: http://codereview.chromium.org/8423018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108182 0039d316-1c4b-4281-b951-d872f2087c98

The NAT traversal default for all platforms is now true.


BUG=97689
TEST=None


Review URL: http://codereview.chromium.org/8423020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108181 0039d316-1c4b-4281-b951-d872f2087c98

R=groby@chromium.org
BUG=None
TEST=*Intent*.*


Review URL: http://codereview.chromium.org/8417043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108180 0039d316-1c4b-4281-b951-d872f2087c98

is needed for bubbles.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8351042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108179 0039d316-1c4b-4281-b951-d872f2087c98

Previously callbackees had to remember to store the buffer in a scoped_refptr<>.

Review URL: http://codereview.chromium.org/8351045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108178 0039d316-1c4b-4281-b951-d872f2087c98

Specifically, catch it when MessageLoop is not running.

BUG=96847
TEST=none


Review URL: http://codereview.chromium.org/8343033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108177 0039d316-1c4b-4281-b951-d872f2087c98

my last patch r108172 uninentionally reverted r107999 (due to my own fumbilng with git). So this re-applies it.

TBR=erg

Review URL: http://codereview.chromium.org/8372046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108176 0039d316-1c4b-4281-b951-d872f2087c98

No need, we delayload now

BUG=none
TEST=chrome runs on XP

Review URL: http://codereview.chromium.org/8386011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108175 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8440008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108174 0039d316-1c4b-4281-b951-d872f2087c98