- 24 Nov, 2020 40 commits
-
-
Egor Pasko authored
The mWaitForSharedRelros is not used. Deeper code inspection with lizeb@ reveals that it does not cause immediate problems to ignore the state of this member. For future improvements we should consider sending an empty bundle with an empty LibInfo and consuming it as usual, instead of guessing whether to expect this bundle. Bug: 979638 Change-Id: I1c3369e7bbb818c88da4b64239c918da3c1cda1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555120 Auto-Submit: Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#830552}
-
Denis Kuznetsov authored
Bug: None Change-Id: I5c9bec776b6850d76f92b4bfd46215bd93f068cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554918 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830551}
-
Curt Clemens authored
The file preview icon on the discovery page and confirmation page needs to be grey whenever those pages are in an error state. This CL adds a |disabled| property to nearby-preview that when true applies a css class that makes the icon grey. Bug: b/163036847 Change-Id: I4a0f24a1ed9f013d499eb2dff9bf24064f0898e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554901Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#830550}
-
Nicolás Peña Moreno authored
Currently, AddLongTaskTiming()'s last 3 parameters are String instead of AtomicString. However, the values are ultimately stored as AtomicString and the parameters passed are already AtomicString. Looking at the impl of AtomicString, it is not a String, which means that we have to convert the AtomicString to String and then back to AtomicString. This CL fixes this. Bug: 1141632 Change-Id: I72db0b0bc2ca96f2b831e8faf195c22acb4be0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555562Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#830549}
-
Harald Alvestrand authored
Bug: chromium:1151946 Change-Id: Ia11d3abdc9d11842995f74cfd5db6bb34fbac6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555011Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#830548}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/35df41dad885..084b862ba31b 2020-11-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a41860e8 to 013c962f (389 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I4c7945e26e09225625e8d0959e5fad2fd9e82d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557535Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830547}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d840c8fb5dc4..47a03e8743c9 2020-11-24 jakobi@webrtc.org Default enable sending transport sequence numbers on audio packets. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic05cb403db2ed4428007b608de5753dd09f6e844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557531Reviewed-by:
-
Egor Pasko authored
This reverts commit 37b4a2bf. Reason for revert: http://crbug.com/1152413 (new failures on the bfcache bot) Original change's description: > Reland Introduce BaseActivityTestRule to handle Activity starting/finishing > > Introduces a BaseActivityTestRule that allows tests to control whether > or not the Activity is finished after the test runs. > Also fixes some issues with Android's ActivityTestRule, like it not > handling LauncherActivities, and unnecessarily inheriting > UiThreadTestRule. > > Bug: 1146574 > Bug: 1151237 > Bug: 1151190 > Bug: 1151160 > Change-Id: I420939b0050c5abeb08bc554ee3d7e5976a32fda > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552249 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830388} TBR=yfriedman@chromium.org,mthiesse@chromium.org Change-Id: I17892fbff84811a93584dda385cbaee0faf1ee25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146574 Bug: 1151237 Bug: 1151190 Bug: 1151160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556844Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830545}
-
Irem Uğuz authored
This cl adds name field to CertProfile and updates the tests and serializer accordingly. Certificate name field will be necessary to show it on the UI for the associated bug. Bug: 1137523 Change-Id: Iefbe3f167a1e65ada7cfda7af858355a1e27c134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543146 Commit-Queue: Irem Uğuz <iremuguz@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830544}
-
Jianhui Dai authored
The constrain is not needed, as the method to detect supported hardware encoder profiles is implemented. Bug: 1119636 Change-Id: Ic3fe4f1ea319f9adc1391d6e0a2203c09264bbf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551624Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#830543}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8fb8d59ba581..c983c977f266 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC orphis@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: orphis@google.com Change-Id: Ibddbdee515a240bbb563ef89e312e9ef13fc0cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557532Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830542}
-
Glen Robertson authored
Bug: 1149277 Change-Id: I1611c7f01d885d54c7e9722311c9f9a44994c209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554578 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#830541}
-
Philip Pfaffe authored
A DevTools change changes exported events causing the test to time out. R=szuend@chromium.org Bug: chromium:1152362 Change-Id: I6cb3f17519ad32615893639b93983c82c1a33947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556862Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/master@{#830540}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ic783c5ab75e16c283bd4acb990ffb1cebe60560b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556584Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830539}
-
Ulan Degenbaev authored
This also brings IDL definitions in sync with the spec. To make the transition simpler, the CL temporarily disables the support for workers and cross-origin iframes. It will be re-enabled once the implementation switches fully to PerformanceManager. Bug: 1085129 Change-Id: I23a36f76bea69f2d4685b0a847909190e1ba0036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552393Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830538}
-
Monica Basta authored
This CL moves some of the features behind 'kProfilesUiRevamp' to either 'kNewProfilePicker' or 'kDiceWebSigninInterceptionFeature' feature flags. Fixed: 1151943 Change-Id: I00dee6bc2085d757da90522f731569a8898b7a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555059 Commit-Queue: Monica Basta <msalama@chromium.org> Auto-Submit: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#830537}
-
Mathias Bynens authored
Context: go/navigator-webdriver-legacyunforgeable Change-Id: I2f874fc5ed34d7d8c1a03e55965ccb5a11773cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556519Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#830536}
-
Wojciech Dzierżanowski authored
Bug: 985303 Change-Id: I53790b1d5f2dc7375b5b9362ea7b07db981d664f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556860 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Auto-Submit: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#830535}
-
Francois Beaufort authored
This CL is simply about updating the Web NFC spec URL to "convert NDEFRecord.data bytes" in a comment. Bug: 520391 Change-Id: I3bf63d79f49493f62e13323d62682cf5b81a5385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556959 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#830534}
-
Gyuyoung Kim authored
This CL replaces all uses of base::PowerObserver::DeviceThermalState with blink::mojom::DeviceThermalState to reduce type conversion between them in blink. Bug: 919392 Change-Id: Icc95ee10137af7e44549397f7e07cf12f277929d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554718Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#830533}
-
Jan Wilken Dörrie authored
This change adds operator-> and operator* to base::StrongAlias. These dereference operators are customary for wrapper types like StrongAlias, allow for more convenience and allow passing StrongAlias to generic APIs like base::invoke. Bug: 954080 Change-Id: I2e2e8da600f20fa9947c615cb2e016a50160d8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553428Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#830532}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6396316ea2ff5e778e2c247ee653b23bacd80f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557520Reviewed-by:
-
Simon Zünd authored
This CL adds a new "TrustTokenOperationResult" mojo structure that is emitted in a new NetworkServiceClient event. The structure is used to convey the exact operation status as well as additional operation-dependent data to DevTools to allow better Trust Token debugging. Follow up CLs will pipe the event all the way through to the DevTools network handler and instrument the redemption and signing operations. R=davidvc@chromium.org Bug: chromium:1126824 Change-Id: I04dd881a74221b3f96a9eea74e39b2d50c9ee20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513593 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#830530}
-
Friedrich Horschig authored
Right now, the all passwords show saving exceptions as chips but it should ignore them entirely. In addition, it should not show the option if only saving exceptions are stored. Bug: 1150851 Change-Id: I4a7a707ab1e1dade7655af6e722c802785ad12ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550818 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#830529}
-
Mikhail Khokhlov authored
This CL enables collecting Chrome events through perfetto system tracing in the power.mobile benchmark. Bug: 1151840 Change-Id: Iac07d6f9705d264867738e741ad743c7949f29a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553426Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#830528}
-
Oriol Brufau authored
A Shadow DOM V0 insertion point can't participate in the flat tree, so attempting to convert a Position with such an anchor node into a PositionInFlatTree used to produce a DCHECK failure. This patch makes ToPositionInFlatTree use a position with the parent node, if the given one is a V0 insertion point. Bug: 1151536 Test=PositionTest.ToPositionInFlatTreeWithV0InsertionPoint1 Test=PositionTest.ToPositionInFlatTreeWithV0InsertionPoint2 Test=PositionTest.ToPositionInFlatTreeWithV0InsertionPoint3 Change-Id: I2d823294ed092ceb7dca4cd708fd75eca5a55f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551131 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830527}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/19526a69c763..d840c8fb5dc4 2020-11-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d375f99a..acfa5a01 (830370:830473) 2020-11-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 45755197..d375f99a (830233:830370) 2020-11-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ef9a6dff..45755197 (830132:830233) 2020-11-23 mbonadei@webrtc.org Fix perf results upload. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icde44d3fa88816bfb9f622d208d46e564f0246d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557527Reviewed-by:
-
Yuzu Saijo authored
This CL makes normal load deferring (i.e. pausing, frozen background etc) and bfcache load deferring different. This is to avoid bfcache specific calls all the time, such as eviction. Also this allows to set memory limit / time limit for network requests only for bfcache, without changing normal deferring behavior. Bug: 1137682 Change-Id: I6b9f082ad0c4ebb959730106381673e1aae8bb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549023 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1b413197a6d7..35df41dad885 2020-11-24 ynovikov@chromium.org Skip more tests on Linux AMD RX 5500 XT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1004356,chromium:1097750 Tbr: jmadill@google.com Change-Id: I3899eea2e3062389480213e240ca4e02ad488ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557518Reviewed-by:
-
Yoshifumi Inoue authored
This patch makes "reconfiguring_encooder.html" to ignore linux_layout_tests_layout_ng_disabled bot because required web codec is not installed on the bot. TBR=eugene@chromium.org Bug: 591099 Change-Id: I8e40737e62b7600e2c7b67fbbc4c0ee76dc4d065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557282Reviewed-by:
-
Bartek Nowierski authored
BackupRefPtr has better security features and its performance is in the same ballpark, so we decided to go that route instead. Bug: 1073933 Change-Id: I1481e8a8ab143b9b7b17e37a6a6156bcd7fc72a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557121Reviewed-by:
-
David Roger authored
This is a tentative fix, as I could not repro the issue. It is theoritically possible that the call to TriggerCookieJarUpdate() does nothing. The scenario would look like this: - Reconcilor starts - Reconcilor does a ListAccounts - At this point DiceInterceptedSessionStartupHelper calls TriggerCookieJarUpdate, but this is a no-op because a ListAccount is already running. - Reconcilor finishes running and adds the account, but OnAccountsInCookieUpdated is never called (because bug 1051864) - this results in a timeout of DiceInterceptedSessionStartupHelper The CL also adds an histogram to track reconcilor errors, as they would explain the timeout as well. Bug: 1151313 Change-Id: I5082ffa377c3c3c4e605d75ae79545811593ac3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550814Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#830521}
-
Sigurd Schneider authored
If multiple CDP clients were attached, only the first would get a valid ClientSecurityState. Bug: chromium:1128885 Change-Id: I6a54a1943b81dd1011288716d12e291b1ef315e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554545 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#830520}
-
Nico Weber authored
We don't seem to use it, and it makes it easier to implement these scripts without subprocess calls using just plistlib once on Py3. Bug: 1147069 Change-Id: Iac7464b7767b2c221f3a63bf79708aa211147249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554781Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#830519}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I634d9bd6f351f2961255b318774bbdbbeac41c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557517Reviewed-by:
-
Yoshifumi Inoue authored
Introduce Synthetic Vertical Oblique by Font::DrawBlob This patch implements limited version of "font-style oblique <angle>" when <angle> is negative, text-orientation is upright, and writing mode is vertical, e.g. "font-style: oblique -15deg", for simulating "tts:fontShear"[1] in vertical writing mode, e.g. video caption for Japanese title. This patch does two things: 1. Draw font glyph with affine transform skew y-axis -15deg, aka synthetic oblique. 2. Select normal slant font when using synthetic vertical oblique[2]. Note: "Meriryo" has italic font and other Japanese fonts are slant by font manager. [1] https://www.w3.org/TR/2018/REC-ttml2-20181108/#style-attribute-fontShear [2] http://crbug.com/918475: Chrome does not distinguish `italic` and `oblique` Bug: 1112923 Change-Id: I5c14bb705fcdd01893be7cc0734bfc2440cb381d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537733 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#830517}
-
Reid Kleckner authored
The closing paren and opening square bracket apparently must be joined for these links to be recognized as markdown links. R=hans@chromium.org Change-Id: I7a3e42c6c6e0ade18a1305e0ae6ed8e48e50bb9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555540 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#830516}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/260eb0f662b4..b35dd76cd5f6 2020-11-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I3526605f02c4399d5daf47e0b21e6e8d8f01d376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557457Reviewed-by:
-
Austin Tankiang authored
This test was failing as it was timing out when waiting for the file handler extension's background page to close. Override the page's idle time to ensure it closes before the test times out. Bug: 1150689 Change-Id: Iff3970c65149f322ebfe014d773abc646a8cc503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557280 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#830514}
-
Yuki Yamada authored
I've disabled some tests for all the platforms, but they had problems only with specific platforms. This is a follow-up for these CLs: https://crrev.com/c/2556621 https://crrev.com/c/2557065 https://crrev.com/c/2557279 TBR=dpapad@chromium.org,bugsnash@chromium.org,rohitrao@chromium.org No-Try: true Bug: 1152287, 1152318, 1152289 Change-Id: If24633596f23ae8f53447b02b2232dd44eed9761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557284Reviewed-by:
Yuki Yamada <yukiy@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#830513}
-
