- 17 Apr, 2020 40 commits
-
-
Nazerke authored
InfobarManagerAppInterface and PerfTestWithBVC. This Cl removes unused properties for TabModel in PerfTestWithBVC and removes the use of TabModel for getting the WebStateList in CWTWebDriverAppInterface and InfobarManagerAppInterface and uses a browser instead. Bug: 1045575, 1050138, 1050135 Change-Id: I1d8d5b5e54c1ad636d14e80726dbc12067d17642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149646Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#760010}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d8d981721371..e68c05a72371 git log d8d981721371..e68c05a72371 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 skyostil@chromium.org telemetry: Capture logs when symbolization fails Created with: gclient setdep -r src/third_party/catapult@e68c05a72371 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: I1f77bd843342bee7f28d81e6a90a24059097848e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154546Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760009}
-
Ewann authored
Bug: 1038919 Change-Id: I67d84abf0c78626af7ebc56a4ccffbe3c08c9117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152790Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#760008}
-
Rainhard Findling authored
* Allows reusing time-based logic for when safety check ran (e.g. string construction) to be reused across platforms. Bug: 1015841 Change-Id: I6db5be39619d510f1a6c95d16767275146477c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144090 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#760007}
-
Julian Pastarmov authored
This reverts commit a2086c05. Reason for revert: There is an issue with this check if the admin has configured maximal number of unsuccessful login attempts. Original change's description: > Reland "Check if user has password in security connect API" > > This is reland for https://chromium-review.googlesource.com/c/chromium/src/+/2039631 > The code is updated to match the latest SecureConnect native host > update. > > Check if user has password in security connect API > In chrome.enterprise.reportingPrivate.getDeviceInfo API, screen lock > > secured flag now check if user has password on Windows. > > The code behavior matches SecureConnect native host: 291830502 > > Bug: 1047785 > Change-Id: Ib6ce74d4b10b50616057042e0e2c30a2336522d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078674 > Commit-Queue: Owen Min <zmin@chromium.org> > Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745516} TBR=pastarmovj@chromium.org,sacomoto@chromium.org,zmin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1047785 Change-Id: Ic43c11792fd48119b7aba86ac766038986ebdd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153031Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#760006}
-
Harald Alvestrand authored
Bug: chromium:1071327 Change-Id: I902cf55c0463e05c64f8ec0e90f2aaa826e31ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152810 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#760005}
-
Roman Sorokin authored
Bug: 1068314 Change-Id: I5189e4dd76f6e168d9d17b2bd1bdfceeada68bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138072Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760004}
-
Koji Ishii authored
This patch extracts |NGTextType| from an inner enum of |NGPhysicalTextFragment| to an enum class. This is part of preparations to avoid creating intermediate |NGPhysicalTextFragment| when |NGFragmentItem| is enabled. This patch has no behavior changes. Bug: 982194 Change-Id: Id079dbf8afb6f14c322e92f6f5d58c6c280078df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153464 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760003}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f93cc8bda48d..c090ea78b262 git log f93cc8bda48d..c090ea78b262 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 3682237cb326..50eaecd721a2 (1 commits) 2020-04-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src e01f13e1f777..382bf3de06fc (1 commits) 2020-04-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 2430d665d3f2..d25ce8725224 (18 commits) 2020-04-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 0d4857ea576a..454ab259c1b8 (1 commits) Created with: gclient setdep -r src/third_party/angle@c090ea78b262 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ia03221e56ac1da55d4910c6d2e33af156ba4549d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153681Reviewed-by:
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/Eheze.....POv5E... Created with: gclient setdep -r src/third_party/aemu-linux-x64@POv5E... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: Ic5924efa16c248a1c786a2a9e42994c17b780234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153678Reviewed-by:
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 767015, 1063749 Change-Id: Ibd15ce759845f954dea022aa9fca97dfbc89406f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152827 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#760000}
-
Mohamed Amir Yosef authored
This reverts commit ba7954e5. Reason for revert: This probably caused the failure in DevToolsBeforeUnloadTest.TestUndockedDevToolsClose https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8882815412590626512/+/steps/browser_tests_on_Windows-10-15063/0/logs/Deterministic_failure:_DevToolsBeforeUnloadTest.TestUndockedDevToolsClose__status_FAILURE_/0 Original change's description: > bluetooth: add BluetoothAdapter::IsPeripheralRoleSupported() > > It appears that on Windows, Bluetooth hardware does not generally > support the BLE peripheral role (i.e. BLE advertisements). Add a method > to BluetoothAdapter that returns the > BluetoothAdapter.IsPeripheralRoleSupported property [0] on WinRT and > true everywhere else, so that client code can detect these cases. > > [0] > https://docs.microsoft.com/en-us/uwp/api/windows.devices.bluetooth.bluetoothadapter.isperipheralrolesupported > > Bug: 1069140 > Change-Id: If8f2f448f30db6aaf720c10e00391dea3f65944e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152892 > Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759836} TBR=reillyg@chromium.org,martinkr@chromium.org Change-Id: I993fe1e58bf4704977cd07b18cf61aba04f402ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1069140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153434Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#759999}
-
Alex Rudenko authored
This change adds the accessible name, role and whether an element is focusable using keyboard to the overlay shown when you inspect elements. The attributes show up together with the contrast information at the bottom part of the overlay in a new section called Accessibility. Screenshot: https://i.imgur.com/Ax5nkeX.png Design doc: https://goo.gle/devtools-a11y-popover Fixed: 1040025 Change-Id: I411a79d2fedd04680f2efc0237f6c8272d922893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149356Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#759998}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I375710146b28f9c023f4a225bf4c556088ed1f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154355Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#759997}
-
Colin Blundell authored
This CL augments WebLayer with closing of tabs when the external intent launching code asks to do so (namely, when an initial navigation in a Tab results in the launch of an external intent). To do so we invoke BrowserImpl#destroyTab(). As clients < 84 are not necessarily expecting the last tab to be closed by the WebLayer implementation, we do this only when the client is 84+. As part of this CL we looked at hardening WebLayer against the case where the client calls Browser#destroyTab() from within TabListCallback#onTabRemoved() (which itself is received after the Tab destruction process has started in the implementation). It turns out that WebLayer will already fail fast in this case: Browser#onTabRemoved() sets the removed Tab's Browser to null, and Browser#destroyTab() raises an exception if the passed-in Tab's Browser is not equal to |this|. This is a reland with a minor fix to update for changes in the parent CL (fix shown between PS1, which contains the original CL, and PS4): BrowserImpl#destroyTab() no longer throws RemoteException, so InterceptNavigationDelegateClientImpl#closeTab() doesn't need to catch it. TBR=sky@chromium.org Bug: 1031465 Change-Id: Id61177d1f4aa0ae6058322d5cb044c12b47f4d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152833Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#759996}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 767015, 1063749 Change-Id: I105f12a6e5b5ea414fdca1b9b127ba859d8c47af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153145 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Koji Ishii authored
This patch removes |shape_options_| from |NGInlineItem|. The bit field is not used currently. Also reorders more frequently used multi-bits bit fields to lower bits. This is part of preparations to avoid creating intermediate |NGPhysicalTextFragment| when |NGFragmentItem| is enabled. This patch has no behavior changes. Bug: 982194 Change-Id: I4e921add325f051101bec0557034e7bd203e6826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154425 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 767015, 1063749 Change-Id: I4d4ba98c67f82e5d82da46b3aa783c264c5a35c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153026 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates CustomTabsConnection class. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781 Change-Id: I9975720d600ac22910d3971eb2e244eb86c30b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144089Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#759992}
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/css3/masking/ and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I135e674c15312795acdf4fa02b54553cd6fda69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143796Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#759991}
-
Gyuyoung Kim authored
This CL updates the title and assert slightly to be aligned with flex-sizing-rows-min-max-height-001.html. Bug: 1063749 Change-Id: Ie16502fa396475e402a7649a74f1cfced215f478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153177Reviewed-by:
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 767015, 1063749 Change-Id: Ia38587567a787bf9b625c64fe3422fca82a6603e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152826 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Yoav Weiss authored
This reverts commit 907d2dd1. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1071454 Original change's description: > Enable 'revert' for stable > > I2S: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/tOHolEkBeY8/jX0jvQqkBAAJ > Bug: 579788 > Change-Id: I7282552f4b8339adc63ffc262cfb59cda2c3f7f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146908 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> > Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759563} TBR=yoav@yoav.ws,futhark@chromium.org,andruud@chromium.org,yoavweiss@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 579788 Change-Id: I0492d6d1022fc3995873ed2cc8eeb05771fb78b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153431Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#759988}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 767015, 1063749 Change-Id: Id6caed5736d59505cf4144e4fcf55e8669383a6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153065 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2985b49c. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 2780c65f "[css-filters] Move effect-reference-turbulence-invalid.html to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ic0d3de8c8aa66b77aa41db4a9836f575d4c2faf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154446Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759986}
-
Rob Buis authored
Add buckets for MathML and SVG UA default style rules in order to reduce overhead of universal selector matching for HTML elements. SVG UA sheet only has one universal selector but MathML plans on adding more than one. Note that this adds buckets for visual style rules but printing is unchanged as performance is less crucial there. Bug: 1071357 Change-Id: I3a0a3280dc4e7ca818a9cb05711fd9553ce737b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150425 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#759985}
-
sreejakshetty@chromium.org authored
This CL fixes the flakiness caused by the RenderDocumentHostUserData::FailedNavigation test case. Bug: 1065495 Change-Id: I9a37af49bd9549587d9df6e2855277c488efe9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132137Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#759984}
-
Robbie Gibson authored
Because the name was incorrect here, when Finch sends a config for this Feature, both the gws_id from Finch and the gws_id defined in about_flags were sent back to gws. If an enabled and a disabled ID are sent to gws, the disabled id is the one that takes affect, so the feature ends up disabled. Bug: 1071078 Change-Id: Ic67f1d5415ac5895a84ee41adc8b2c98d1c38456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153106Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#759983}
-
Yoshifumi Inoue authored
This patch changes |NGBoxFragmentPainter::NodeAtPoint()| to set offset in containing block instead of offset in underlying element for inline element as legacy layout to make hit testing on inline element with ::after pseudo class with adapting |PositionForPoint()|. The document[1] contains investigation notes of this CL. [1] https://bit.ly/2REZ7P9 Hit Test with ::after Bug: 1043471 Change-Id: I81ada0ccd7bff31a84ce4746785ea83eb175937c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151775 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759982}
-
Nikita Podguzov authored
Bug: 1015690 Change-Id: Ia80de70a421e39515060a873a1ddb77c4c77eeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138071 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#759981}
-
Swapnil authored
installed but not loaded According to the current UMA statistics, some of the force installed extensions are installed successfully but failed to load due to some reasons. To investigate this, we report disable reasons for forced installed extensions. When extension is disabled due to several reasons, only one is reported. Following histogram is added: Extensions.ForceInstalledNotLoadedDisableReason Bug: 1063024 Change-Id: If384aa15c5f2ec56dcb4d0510ef6a1a610a8ea6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139760Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#759980}
-
Jérôme Lebel authored
When the coordinator is interrupted, the ChromeIdentityInteractionManager needs to be dismissed. Once it is dismissed, the manager can be set to nil. Bug: 971989 Change-Id: I0da58b71e3e151d71e76fce5d9a8f53c00e66b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154185Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#759979}
-
Koji Ishii authored
As a preparation to add |NGTextType| to |NGInlineItem|. This patch has no behavior changes. Bug: 982194 Change-Id: Iec07f6606458fe16a1fe2d3f0e16a2069944af46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153459Reviewed-by:
-
Alice Wang authored
This CL extracts an interface for AccountManagerFacade to decouple the dependency to the AccountManagerFacade implementation in most places. Bug: 1063869 Change-Id: I97496438cecd571b36b212ee510c408f8b4af702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144193Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759977}
-
Colin Blundell authored
This reverts commit 0c7bb0a0. Reason for revert: Broke the build Original change's description: > WebLayer: Close tabs on launching external intents when instructed > > This CL augments WebLayer with closing of tabs when the external > intent launching code asks to do so (namely, when an initial navigation > in a Tab results in the launch of an external intent). To do so we > invoke BrowserImpl#destroyTab(). As clients < 84 are not necessarily > expecting the last tab to be closed by the WebLayer implementation, we > do this only when the client is 84+. > > As part of this CL we looked at hardening WebLayer against the case > where the client calls Browser#destroyTab() from within > TabListCallback#onTabRemoved() (which itself is received after the Tab > destruction process has started in the implementation). It turns out > that WebLayer will already fail fast in this case: > Browser#onTabRemoved() sets the removed Tab's Browser to null, and > Browser#destroyTab() raises an exception if the passed-in Tab's Browser > is not equal to |this|. > > Bug: 1031465 > Change-Id: I87e1464d3be4b0fe138ab7aa14fe700b8b930722 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144120 > Commit-Queue: Colin Blundell <blundell@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759969} TBR=sky@chromium.org,boliu@chromium.org,blundell@chromium.org Change-Id: Icf90ed217d0586b22fe3f55452c0ab6878d57118 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152809Reviewed-by:
-
Denis Kuznetsov authored
After changes in issue 1058022 the tests are much less likely to time out on dgb/*san bots. If tests will flake again, please disable them indvidually rather then by reverting this CL. Bug: 1049789, 1025926, 990362 Bug: 1058022 Change-Id: I5f20659b798ad1604d82df4b028453bfe93811e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152586Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#759975}
-
Andrei Salavei authored
Add missing else in if-else statement in HTTP error handling Change-Id: I1da56170c43948af598a03ac9876f4a9ba257196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151510Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Andrei Salavei <solovey@google.com> Cr-Commit-Position: refs/heads/master@{#759974}
-
Rainhard Findling authored
* This is done as preparation for a subsequent refactoring of the safety check WebUi code. It moves the source of truth for the safety check parent status from the JS side to the C++ side. This removes some of the interdependencies of parent to children (and vice versa), and allows for a subsequent splitting of parent and children into individual parts on the WebUi side. * This CL is part 2 of the change and updates the WebUi to use the parent state received from the backend, instead of holding and computing its own. Bug: 1015841 Change-Id: I3a6f1c1bb195c6c050e14b31564316d4a9e2323d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150429 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
-
Alex Rudenko authored
Documents how to use lldb to debug Chromium processes Change-Id: I39beec3addc5c9360a0120e4d8d1f4e9e46a390a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153074 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#759972}
-
Wanming Lin authored
This CL only classifies existing tests to subfolders (motion, orientation) respectively. Bug: 816462 Change-Id: If4b3a41466d51ed4a044502683303b413344b262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147008Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#759971}
-
