- 17 Oct, 2020 39 commits
-
-
Mike Wittman authored
Moves the registration before the early-out on Android based on kUmaBackgroundSessions, to ensure that it's always recorded on startup. Bug: 1004855 Change-Id: Iacf1bb315fe79d59eb7b5d6d8c73e3feaa964312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472341 Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#818209}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ibc083284453b168cfc840e53840dabb3ab8ef8e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482204Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818208}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c12c8877aee..24bbfbb1f544 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Icc6a5d552452d7f29fe072a33dd6eb81466e5c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482384Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818207}
-
dpapad authored
The latest version has support (among others) for Dynamic JS modules and BigInt. Fixed: 1139102 Change-Id: I70c0b30f3d5ef622a6d382d811ad774b6b9d3748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478884 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#818206}
-
Ryan Heise authored
Bug: chromium:1138953 Change-Id: I8dbe67cf62348217be1f9e441c020e33fc563b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480819Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Auto-Submit: Ryan Heise <heiserya@google.com> Commit-Queue: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#818205}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fba124a48346..088a6f219279 2020-10-16 deadbeef@webrtc.org Fix possible deadlock when handling SCTP_SEND_FAILED_EVENT notification. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137936 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I493b5226600435440abde4e557dd37b0533c13b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482386Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818204}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602870879-71fddc22f2ceb12188759a1d8869c82a8b2155fa.profdata to chrome-linux-master-1602892676-bf21d7ac84386f5c5d5b8c904987f5e8c042ca52.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id678b144907c744c73f902f95dcde429024e8daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481732Reviewed-by:
-
Mike Wittman authored
The use of SIGURG conflicts with the sampling profiler, which is already using that signal to drive stack sampling on Android. SIGWINCH appears to be otherwise unused in ART, bionic, and Chrome. Bug: 1136547 Change-Id: Iadecaebd383e4b39ba547c8a9cd5d0ebf6ae640a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469459Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/51ff0d0509b6..37c400146e59 2020-10-16 timvp@google.com Revert "Vulkan: Fold deferred clears into current clears" 2020-10-16 cnorthrop@google.com FrameCapture: Move shader and program source to shared cache If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: PUBG MEC Change-Id: I2df1c6300dbb6430bf233415719a03dcd8da11a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482383Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1cf32d03..64886a69 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I332fea194e87ca451e966c7933e21cd52c882124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482362Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818200}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602870879-c4d95eb6e866d4e52485aa00dae385a889389fa8.profdata to chrome-mac-master-1602892676-2e67f7ade6fea6d137ea5d86faa841297fe18fa8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibb906b69e3674420894a450ae30e2de10c2bb5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482385Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602838722-3d3847c86317a9aa85069273b7be64c1533b4e7a.profdata to chrome-win32-master-1602860364-832acf5629dcf54dc1d765b5c65780fd100e8b4a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4773c7bb86b709f898afe705d37bec15ebcd145c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481411Reviewed-by:
-
Ian Prest authored
This change eliminates the usage of the deprecated SkFontLCDConfig, which stores font-related monitor properties in some global variables. Chromium is the only client of this deprecated API, and the Skia team has wanted to remove it for some time. Unfortunately, the use is fairly widespread within Chromium: 1. The globals are set directly in a handful of places via calls to SkFontLCDConfig functions. 2. The globals are used (indirectly) whenever an SkSurfaceProps is initialized with the kLegacyFontHost_InitType flag, and also when an SkCanvas or SkSurface are created without specifying the props. The correct long-term plan would be to retrieve the values from the Display (ideally per-monitor values) and pass them along as needed. But given the extensive usage, the only reasonable short-term approach is to lift the globals out of Skia and bring them "in-house" into Chromium. To that end: -- Undefines SK_LEGACY_SURFACE_PROPS. -- New globals and APIs in /skia/ext/legacy_display_globals.* -- Replaced "SkSurfaceProps(kLegacyFontHost_InitType)" with calls to new API: skia::LegacyDisplayGlobals::GetSkSurfaceProps() -- Found places where SkCanvas and SkSurface were created and props weren't already specified; passing the LegacyDisplayGlobals in most cases, but `nullptr` (or empty SkSurfaceProps) if it was clear without doing much analysis that no text was being drawn. This gets us closer to the end-goal by allowing Skia to fully remove the deprecated APIs, and also surfacing a lot of places where the use of the globals was hidden by indirect usage. Change-Id: I8fffaee4933c03ee828d2ffab858f53d92c59f4d Bug: 1126992, skia:3934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378763Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818197}
-
Charlene Yan authored
Bug: 1116118 Change-Id: I25c9ef0647a98464badb5642b2c7c567d8ba4bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481069Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#818196}
-
Varun Khaneja authored
Fixed: 1138405 Change-Id: I2f6b74468f61b7f13fec47b58598536d47067832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476909 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#818195}
-
Wenbin Zhang authored
After argument was updated in crrev/c/2479565, it is not populated to the shard map to take effect. Adding it in this CL. Bug: chromium:1136900 Change-Id: I5b165a8b925addf1dbf9f11de1b093b5109f54b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482343 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#818194}
-
Becca Hughes authored
Change-Id: I28592a8cd09e89c2d980b55cb2e495d789a2ca1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480714Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#818193}
-
Rebekah Potter authored
This reverts commit 0397ac4e. Reason for revert: Two tests that had expectations updated in this CL are failing consistently on Win7 Tests, see https://bugs.chromium.org/p/chromium/issues/detail?id=1139546 Original change's description: > [Controls Refresh] Update controls styles for dark mode > > This CL updates the dark mode styles for the following controls: > 1. <meter> - border color. > 2. multi-select - foreground text color. > 3. Button: Dark mode button design has no border and has unique fill > color. Thus, a specific set of color enums is created for only > buttons. Button's border color is styled to match its fill color > in order to give the appearance of no borders and keep its > dimensions unchanged. This impacts: button, file, and color > controls. > > > Bug: 1107290, 1099624 > Change-Id: I141c199f93acac2b950b8af7195e863f811c2f4c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469357 > Commit-Queue: Yu Han <yuzhehan@google.com> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818119} TBR=ellyjones@chromium.org,masonfreed@chromium.org,yuzhehan@google.com,yuzhehan@chromium.org Change-Id: I9eee08b77da1bf2887b72e1990bf9e76d6334c59 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1107290 Bug: 1099624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482166Reviewed-by:
-
Brian Sheedy authored
Adds the 1 pixel ignored border argument to the GPU video pixel tests that use Sobel filters and didn't have it already. This should hopefully allow some flakes I've been seeing on the ARM-based Mac DTKs to be auto-triaged. Bug: 1105656 Change-Id: I8b317335492e6eb025b151ba4a575c27c342ae07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482086 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#818191}
-
Brian Sheedy authored
Adds an additional failure suppression for the WebGL2 conformance tests on the ARM-based Mac DTKs for deqp/functional/gles3/framebufferblit/default_framebuffer_00.html. TBR=ynovikov@chromium.org Bug: 1130118 Change-Id: I98e2856c47c5256388d6a061b4041c56436d8482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481953Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#818190}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9cee07983fc9..fba124a48346 2020-10-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e7588486..2aa0b3d2 (817908:818053) 2020-10-16 joedow@google.com Fixing ASAN container-overflow error in DxgiOutputDuplicator 2020-10-16 hta@webrtc.org Deprecate GetRemoteAudioSSLCertificate If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1138446 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If173831dc9addf52127f4f37482cbc5154db4486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481936 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d77d4ca4c542..0a749cf45c8c 2020-10-16 jalyn@microsoft.com Settings: Add Keyboard Shortcuts Docs Link If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic073f147340416c9dfd109302d7ae02e98581e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481728Reviewed-by:
-
Victor Hugo Vianna Silva authored
The method is unused. SyncEnums::ENCRYPTION_COMPLETE also becomes unused and is deprecated. Bug: 1033040 Change-Id: I100ed858d43151d437076947c1cf5fcf5831af3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479164 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818187}
-
Greg Thompson authored
It doesn't provide any additional signal over other data sources. BUG=1138415 R=chromium-metrics-reviews@google.com Change-Id: I56185e4be8055ff49c72cb3f8016dc943cdbc397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479562 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Yann Dago <ydago@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/426436686c95..3c12c8877aee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rbpotter@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091475,chromium:1138953 Tbr: rbpotter@google.com Change-Id: I1587b38184a10a8f521f38e09298f127972516a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482164Reviewed-by:
-
Stefan Zager authored
Speculative fix for crasher. Root cause is most likely one of these: https://chromium-review.googlesource.com/c/chromium/src/+/2220868 https://chromium-review.googlesource.com/c/chromium/src/+/2113390 On further reflection, it really doesn't make sense to force the root GraphicsLayer of a throttled frame to get hooked up into the layer tree. We can dispense with DisableCompositingQueryAsserts, because the call to CanBeComposited will already check for throttling. If that call comes back 'true', then the child frame *better* have advanced its lifecycle far enough to allow compositing state queries. BUG=1133662 Change-Id: Ie3be72c7ccc9837d15268e6e6fe39e39227dfd5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482047Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#818184}
-
Aya ElAttar authored
Changed "*.company.com" to "company.com" to avoid confusion with blacklist-url-patterns Change-Id: Ica9df34c04da6ba09786f5b9f8372d93dd87ec62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467863Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#818183}
-
Michael Crouse authored
The DataUse.BytesReceived histogram does not cover larger reports from the OS and makes it difficult to measure changes in data use. Bug: 1132481 Change-Id: I2a0df744f0178ce16aad75cf024c86f28b0d11aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459792 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#818182}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //ui/webui. Bug: 1113033 Change-Id: I9d5c935d025198d732be6dfaa135c1c59abd7107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477520 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#818181}
-
Xing Liu authored
If require_lite_mode is set to true, download later dialog will show only when lite mode(data saver) is enabled. Bug: 1137925 Change-Id: I8655750cac482fa65cd848b4a688fe97366f634e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469457Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#818180}
-
Mario Bianucci authored
Currently, if no point in |points_| has the same timestamp as |metadata_|, everything in the map is erased. However, this sometimes results in some points that have timestamps later than the metadata's being erased. Particularly, this can occur when the API is first used, since the point used to make the metadata wasn't sent to viz by the browser process, since it didn't know to send them yet. However, if it then sends points before this metadata makes it to viz, those points would be erased since none match metadata's timestamp. This could cause future trails to not be drawn too. This change fixes that by only removing points that have timestamps earlier than metadata's timestamp. Bug: 1132043 Change-Id: I1da7b4ca7de8e816cebb67dece7a2bb1743cddf7 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429963 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#818179}
-
Aleks Totic authored
HasNonCollapsedBorderDecoration is a LayoutObject flag used in painting. If flag is set, fragment participates in BorderDecoration painting. Setting this flag in a way compatible with LayoutNG was problematic: In Legacy, flag got reset every time style changed, and manually set in Legacy table layout. Because collapsed_borders is a property of Table, Cell needed its table to set the flag properly. Table was not available to cell when SetStyle was initially called, so flag had to be manually set in LayoutNGTableRow::AddChild. This patch adds HasNonCollapsedBorderDecoration flag to table cells. The flag has to be passed from LayoutNGTableRow through ConstraintSpace. Bug: 958381 Change-Id: I7800d0c918ff78139df6748bed8a95c64cb19395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473806 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#818178}
-
Jesse Schettler authored
Add temporary text to display when an unsupported file type is selected. The text will be removed once all available file types are supported. Bug: 1059779 Change-Id: Ib4cb062439cbcb732b565a88f92a992794f7768d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480730Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#818177}
-
Vincent Boisselle authored
Other related changes: > Added a gate for the feature in the action manager that would have prevented the problem on not spreading on clients that don't have the feature enabled > Added test coverage. Bug: 1139394 Change-Id: Ib9105b038f506e897fdca7fb99a987bd473e1a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481302Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#818176}
-
Josiah K authored
Focus following should work in more cases than handled previously, since we're now listening for all high-level chrome.automation focus updates, instead of low-level views::View AXEvent and related focus updates. AX-Relnotes: New Javascript-based magnifier focus following behind flag - focus following should work in more cases than handled previously. Bug: 1131153 Change-Id: I1e34255000a320df942462690c6a7ea1b6d0612e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466622 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#818175}
-
Matt Wolenetz authored
Includes implementation of CrossThreadMediaSourceAttachment (CTMSA) and updates to MediaSource and SourceBuffer to use it. CTMSA owns a lock that it takes on most operations. It also provides a utility method (RunExclusively()), which is used by the MSE API to take that same lock during most operations on the API. The same thread attachment provides a basic version of the same, though no lock is used. CTMSA understands whether or not it is attached, has ever started closing, and whether or not either of the attached contexts has ever destructed. It conditions cross-thread operations to safely behave when one or both contexts is being destructed. MediaSource is given its own small lock that it uses to guard its reference to the attachment instance, when attached. This is required because attachment start is synchronous on the main thread, even if the MediaSource is owned by worker context. CTMSA and MediaSource cooperate to ensure mutex and safety of the two-stage attachment start. In MediaSource::ContextDestroyed(), further care is taken to prevent attachment start success when worker context destruction is possibly racing the main thread's attempt to start attachment. `context_already_destroyed_`, protected by MediaSource's lock, is used to prevent that start from succeeding. MediaSource's context destruction can no longer always assume that accessing the demuxer via the WebMediaSource (and WebSourceBuffers) is safe. The worker version of MediaSource context destruction uses the attachment's RunExclusively() to safely know if it can cleanly Close the underlying demuxer, or if instead it must do a simpler shutdown. Future specification work will likely determine some signal to the media element when the worker-owned MediaSource's context is shutdown, yet the element itself is still alive. For now, sane results are returned by the attachment (nothing buffered nor seekable), with no other error provided. Possible app workarounds might include main and worker watchdogs and being careful about when the main thread explicitly terminates the worker. This experimental implementation attempts to retain BackgroundVideoOptimization, even for MSE-in-Workers, but does not support AudioVideoTracks in the worker MediaSource or SourceBuffer. Plumbing of appropriately-identified track metadata parsed from initialization segment in the worker is used to populate (and remove) media element AudioVideoTracks that should agree with the track id's used internally in WebMediaPlayerImpl to accomplish BackgroundVideoOptimization. As a simplification, CTMSA assumes it can be used for at most one attachment. Effectively, this assumes that the currently on-by-default MediaSourceRevokeObjectURLOnAttach feature behavior will be always-on soon. If CTMSA is not unregistered automatically after successful attachment start (e.g., if that feature is disabled) and if the app attempts to re-use the corresponding object URL for a later attachment, that attachment will be rejected by CTMSA. Note that the same-thread attachment would still allow such re-use when that feature is disabled. Updated web-test: mediasource-worker-attach.html changed to ...-play.html and fixed New web-test: mediasource-worker-play-terminate-worker.html Manual test: page refreshing while running mediasource-worker-play*.html BUG=878133 Change-Id: I21f6542b90d51bdc28096500fb1441d202ab4ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459431 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#818174}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f9c7b2803461..be8004d2fb6c 2020-10-16 bsalomon@google.com Revert "New variant of SkImage::MakeFromYUVATextures." 2020-10-16 mtklein@google.com switch SkTPin impl to pin NaN to lo 2020-10-16 tdenniston@google.com Don't run SVG tests on tsan bots for now 2020-10-16 bsalomon@google.com New variant of SkImage::MakeFromYUVATextures. 2020-10-16 mtklein@google.com impl SkTPin with std::{min,max} If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: Ia45b648f97c4969da3a1ddfb88062beaf4435a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481937Reviewed-by:
-
Daniel Classon authored
The "Ok Google" tags should show up all the time, not just when Ok Google is enabled. While this fixed the bug with the tags not showing up, the search tag priority is still really low. In my testing, "Hey goog" and "Okay goog" led to the search results being shown, but as soon as Google is added, other Google related search items take precedence. Fix this by changing search priority from Low to Medium. Fixed: 1136629 Change-Id: Id13ae98b5a699a0853382413730c8079cdf658fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476521 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
-
Dale Curtis authored
NVIDIA has indicated that they don't expect overlays to work properly prior to the 455 driver. Confusingly, 456.38 appears to be the first r455 driver. R=zmo Bug: 1113893, 1056267 Change-Id: I7db3a1332628b64a9e480543b2b4d5434c91fd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481065 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#818171}
-
- 16 Oct, 2020 1 commit
-
-
Sky Malice authored
TBR: fhorschig@chromium.org Bug: 1139520 Change-Id: I762bf5cdbc6237b03faac49597ef1cf61e2e29b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481939Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#818170}
-
