- 24 Jul, 2019 40 commits
-
-
Emil A Eklund authored
Bug: 785230 Tbr: drott@chromium.org Change-Id: I1c258d841a667749e25f4c55bcf278da9f00a52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717198Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#680572}
-
Simeon Anfinrud authored
This will print the keys of validators that were not properly unregistered before the DeviceCapabilitiesImpl destructor on debug builds. Bug: Internal b/138262808 Test: cast_shell_browsertests Change-Id: Ifda5d7f37844dceebc43902fabac0da86212e95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715552Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680571}
-
Nektarios Paisios authored
Accessibility selection returns tree positions that are adjusted taking into account ignored children. However, some ignored children are now included in the accessibility tree, and ax selection doesn't account for those. This is just a workaround to avoid crashes and unblock users from using GSuite until a re-write of the selection calculations in IA2 hypertext is undertaken using AXPosition. R=aleventhal@chromium.org Change-Id: I94287b344d0f8a6a0459ca0f769b9921a332d033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715752Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#680570}
-
Nicolas Ouellet-Payeur authored
This reverts commit d9dbade3. Reason for revert: python_script backend fails on waterfall, making the bots red (crbug/949382) Original change's description: > [Traffic Annotations] Run extractor.py on waterfall > > linux-annotator-rel and win-annotator-rel will now test traffic > annotations with extractor.py, as well as the clang tool. > > Also updates a traffic annotation in management_ui_handler.cc, since > extractor.py doesn't understand #ifdefs. As a workaround, this > CrOS-specific annotation is moved to a CrOS-only file. > > TESTED= > Ran traffic_annotation_auditor_tests.py locally, excluding the > --no-filtering configs. > > Bug: 966883 > Change-Id: I7848877f67635b50d8ce2a841019e49136a33b11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692970 > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675994} TBR=hcarmona@chromium.org,rhalavati@chromium.org,nicolaso@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 966883 Change-Id: Ic283e1ba2cd5720cfbb85553f2f1a482cbf28a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715896Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#680569}
-
Jamie Madill authored
These are related to missing support in ANGLE. Bug: 987228 Tbr: piman@chromium.org Change-Id: I508b0bb9a27419d83520505eb39086c21764859c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715311Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#680568}
-
Doug Arnett authored
Creates and populates new UKM PreviewsDeferAllScript event to report the count of scripts force deferred in the mainframe. Bug: 978568 Change-Id: I7e7d87d0a181559832e1a4c6a1682db543790434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715109Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#680567}
-
Martin Kreichgauer authored
The Security Key settings subpage currently has a single monolithic browser proxy and associated message handler for three sets of logically independent functionality (PIN, credential management and reset). This change, splits them into three individual parts. This is a structural change only. No functional/behavior changes intended. Change-Id: Ie167ed58b4bd293764d6e784d80f922a43296551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688206 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#680566}
-
Findit authored
This reverts commit fdd7489f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 680383 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmRkNzQ4OWYxZjk1YTk4NDM3MWMwM2UxMThmZjE3YTQ2MGM2NTlmOAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29/55141 Sample Failed Step: content_browsertests Sample Flaky Test: BackForwardCacheBrowserTest.LoadingSubframeDoesNotPreventCaching Original change's description: > [bfcache] Don't cache pages that are still loading. > > To avoid the complexity of caching and restoring still-loading pages, > for now simply don't cache pages that haven't finished loading. > > Long term this logic will probably need to be extended to be more > complicated/permissive, to increase back-forward cache coverage. > > Change-Id: Ic06d9b3d425d3df95b8d09bea1561c000a96acc4 > Bug: 976697 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692414 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Commit-Queue: Lowell Manners <lowell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680383} Change-Id: Iedaebe0c40be92b34e2ad8d6ea650eb06044e2f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715263 Cr-Commit-Position: refs/heads/master@{#680565}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/42937674ae09..87259987f65e Created with: gclient setdep -r src-internal@87259987f65e The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ifaff179d53a64a5448b110fec75b705d1c7e586f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717101Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680564}
-
Ella Ge authored
The test was failing in wpt because it passing non-integer value to test driver. This CL changes it to use "origin" instead. This CL rewrites the test to makes it cleaner, instead of adding event listener inside event listener. This CL also changes the test to send the "move" events after receiving pointerlockchange. Bug: 986277 Change-Id: I0f51523c3c90791339877b2e51afa8e9a4cc9d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717195Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#680563}
-
yilkal authored
Bug: 945082, 945934 Change-Id: Ic11d227ba8de9929b6ff4803ad582346a132dd74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560466 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#680562}
-
Ce Chen authored
The instance of this class is accessed as an NoDestructor by the model component installer to notify the corresponding provider when model update is finished, to replace the current polling mechanism over DIR_ON_DEVICE_HEAD_SUGGEST in the provider. Consequently remove DIR_ON_DEVICE_HEAD_SUGGEST since it is no longer needed. May remove component updater from omnibox later if it is not needed neither. New component updater ID was previously approved in https://crrev.com/c/1710827. Tested on Nexus 5X for both new model download and pre installed model discovery. Note I cannot test on iOS, as looks like the Component needs to be registered at ios/chrome/app/main_controller.mm rather than chrome/browser/chrome_browser_main.cc for iOS (though I'm not sure what is the best way to register the component in iOS as chrome/browser/component_updater is currently not visible in ios/chrome/app/). However if I register at main_controller.mm, my dev app will crash at ComponentUnpacker::BeginUnzipping() when calling unzipper_->Unzip(...) before ComponentUnpacker::EndUnzipping(), with error http://screenshot/NqFrd299dnq and http://screenshot/g9RjyC34NaQ. Bug: 925072 Change-Id: I99f0baf2bef23a7927847d93467f4be8878931dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711030Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#680561}
-
Reilly Grant authored
This change creates a new class, BarcodeDetectorStatics, which owns the connection to BarcodeDetectionProvider. This allows it to implement the static methods on BarcodeDetector such as getSupportedFormats() without needing to create an instance of BarcodeDetector. This fixes an issue where getSupportedFormats() would reject when BarcodeDetection is unimplemented even if a successful connection to BarcodeDetectionProvider is made. It also avoids recreating the provider connection for every new BarcodeDetector. Bug: 983910 Change-Id: I7c7ea7df84f68bbed9b2bfc600852e4f4e5356cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706893 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#680560}
-
Karan Bhatia authored
This CL marks the Extensions.DeclarativeWebRequest.WebViewRequestDeclarativeRules obsolete. We do not have any plans to do an explicit deprecation of the declarativeWebRequest API for webviews as of now. BUG=984304 Change-Id: I9eb9c92339511c295c01270d01bb74442ba56b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716227Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680559}
-
Sam Goto authored
Bug: 670299 Change-Id: I3aebfce7baf6e25fb07ead2a74951a051bdb91cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715915 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#680558}
-
Chris Hall authored
R=aboxhall,akihiroota Change-Id: Ie1cdf843655a7c0bea7fc162ffbd51b0ff53d755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682678 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Auto-Submit: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#680557}
-
rajendrant authored
This CL marks "loading" attribute support as experimental, so that WPT tests run with this attribute supported. Bug: 937986 Change-Id: I797a6e467e784c1740bdd77750f7b6a3460ca58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700651Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#680556}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/8944f0205b04..fde94905fec0 git log 8944f0205b04..fde94905fec0 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 enga@chromium.org Factor EncodingContext out of CommandEncoderBase. Created with: gclient setdep -r src/third_party/dawn@fde94905fec0 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I7a9ecca7f0564ea2e015181ffda10f8889118ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680555}
-
Richard Knoll authored
We want to show an illustration if there are no devices and no default apps available to choose from in the Click to Call dialog. Bug: 972059 Change-Id: I7b94662f1721f32c53278b3db2d0678824efc9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715196Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#680554}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c8b0c582..776f729a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I89f34156535d2b3df88392478dd6f27b70e0590a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715895Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680553}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/361d65fd752e..a76f3b0bce96 git log 361d65fd752e..a76f3b0bce96 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 treehugger-gerrit@google.com Merge "Demote some error logs" 2019-07-24 rsavitski@google.com Merge "traced_probes ftrace: switch back to single-threaded, nonblocking read(2)-only approach" 2019-07-24 eseckler@google.com Merge changes I5ba92202,I41f1d117 Created with: gclient setdep -r src/third_party/perfetto@a76f3b0bce96 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I0e6cae8629cfb90ede22a3c73604fa25985b42a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717092Reviewed-by:
-
Ken Rockot authored
Instead of using Service Manager to manage instances of this service, a new LaunchUtilWinServiceInstance() function is provided in browser code. This allows any thread to launch a new service process for the Windows utility service and own remote interface to control it. For background and motivation see https://docs.google.com/document/d/1M0-K0gi1xXO0f_-YKSH2LFVh4RJY-xe9T9VaGFOSXb0/edit Bug: 977637 Change-Id: I0f01cde82ee04ab9d988498b73327bb9fd060891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710187 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#680551}
-
Joe Mason authored
This puts the directory name back the way it was before https://crrev.com/c/1699778. The change in directory name has side effects in an internal repo that are awkward to deal with. This directory is slated for deletion so let's just leave it with the deprecated name until that happens. R=rockot@chromium.org Bug: 806965 Change-Id: Ic20789d3b331e7f432d707afda7818e9c3e97ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712957Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#680550}
-
Robbie Gibson authored
This mostly consists of replacing the old blue and red with our new blue/red semantic colors. Bug: 976668 Change-Id: I25f5bdc99140d4fa2ea7a6d4a09ffebecacb7996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713635Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#680549}
-
chrome://webapksckitagawa authored
If a WebAPK isn't backed the browser visiting chrome://webapks then manually triggered updates will not work. To mitigate confusion, the package name of the browser that owns the WebAPK is now displayed. Additionally, an alternate update status message is provided indicating to the user that Chrome doesn't own said WebAPK. Bug: 918898 Change-Id: I6edd05b49e67b01e56caaee6f22d93ae748ba650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710272Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#680548}
-
Ryan Hansberry authored
When scanning begins, a yellow icon with the tooltip "cannot connect..." briefly pops up and is then replaced again by the spinner. This CL prevents that visual jank by making sure |is_performing_initial_scan_| is set to true before fetching lock screen state. Bug: 890047, 921766 Change-Id: Ib41d4744f1eddcb510497b303a8a220716123f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716156 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680547}
-
Vlad Tsyrklevich authored
This is a reland of 5bbaab09 with crashpad_tests disabled on the Linux CFI bots. Original change's description: > Add crashpad_tests to the Linux bots > > crashpad_tests should work on Linux and will help keep MSan, among > other tests, from regressing. > > Bug: 932205 > Change-Id: I488a0c6e0f3c1d51021b4ed7312ab703c53bae92 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684301 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> > Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678539} Bug: 932205 Change-Id: I65f42743372e9d3e25d95dfe2e52aef28e862a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716951Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#680546}
-
Guillaume Jenkins authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/1706574 introduced a crash by missing a null check in the case where the OS fails to construct the native spellchecker object. This CL adds null checks in 2 places: 1) Where the null pointer was being dereferenced, to future-proof the method where the crash was actually happening. 2) In the telemetry code path before attempting to use the native spellchecker, since there's no point trying to record native spellchecker data if the native spellchecker doesn't exist. Bug: 987025 Change-Id: I80d289f9299d951a7951a321237a48399587b89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715600Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#680545}
-
sczs authored
- Uses NamedGuides on SnackBarCoordinator to calculate the bottomOffset to present a Snackbar. - Changes the Bookmark Added snackbar so it uses the SnackBarCoordinator and doesn't call MDCSnackbarManager showMessage directly anymore. - As a followup CL I'll make all instances of direct calls to showMessage to use the SnackBarCoordinator. Screenshot: https://drive.google.com/open?id=1EaVLsAfuKuwzB7n2uqJ31-d0_7TJiFh7 Bug: 804656 Change-Id: I3fc50e460b4ddce2157e6215f8d7b19bb8efb071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710857Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#680544}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f640b87f1c64..97321b687b38 git log f640b87f1c64..97321b687b38 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 srte@webrtc.org Adds test for experimental remote estimate SDP negotiation. 2019-07-24 orphis@webrtc.org Don't crash when simulcast layer count is different from RID count 2019-07-24 alessiob@webrtc.org Fix rtp_analyzer tool 2019-07-24 eshr@google.com Report congestion window updates on GoogCC time updates 2019-07-24 orphis@webrtc.org Add a field trial for older applications to reduce the simulcast layer count Created with: gclient setdep -r src/third_party/webrtc@97321b687b38 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I89ed008e12ab07e5098a4e83af57fbec20442c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716596Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fdf4bfe6d389..fb9acba203f7 git log fdf4bfe6d389..fb9acba203f7 --date=short --no-merges --format='%ad %ae %s' 2019-07-24 brianosman@google.com Skip compositing_images benches on GTX660 and Nexus5x Vulkan Perf bots 2019-07-24 halcanary@google.com experimental/editor: Find nearest possible cursor position when click in whitespace Created with: gclient setdep -r src/third_party/skia@fb9acba203f7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: I00dfb3937472509280da92c464051e845a8d98ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715162Reviewed-by:
-
Tanmoy Mollik authored
Update "No Thanks" to "No thanks" per Android UXW style. Bug: 986687 Change-Id: I43bf4a607147423d04873e2aa55a3b9135a3507a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715277Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#680541}
-
Vincent Boisselle authored
Summary of changes: * Piped demographic metrics provider with chrome browser (iOS + others). * Expose user demographics from DemographicMetricsProvider. TBR=treib@chromium.org Bug: 979371 Change-Id: Ib0d1eff9b767cf121fe768a9a46a3ff1fb57dd27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687019 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#680540}
-
Wojciech Dzierżanowski authored
Change-Id: I352b0f8bf7f5206fc5846268dcb580b921d4f8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712566 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#680539}
-
Joel Einbinder authored
Local network overrides was turning off automapping, but automapping is needed for snippets to work. Bug: 980083 Change-Id: I90b7043eb7a0ca7e1b8a280e3a5c569d527d2b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713464 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#680538}
-
Simeon Anfinrud authored
This avoids a crash-on-first-boot on some emulators. Bug: Internal b/138228866 Test: install apk on N emulator Change-Id: Ieaf74fffcda20d96ffbc30c1180a137e0a970bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715587Reviewed-by:
-
Nick Burris authored
Only activate the text fragment anchor if the navigation was initiated by the user or browser. This adds a is_browser_initiated bit to CommitNavigationParams to plumb the browser_initiated_ state from the browser to the renderer. Also added TextFragmentAnchorBrowserTests, testing that both user and browser initiated navigations can activate the feature. Bug: 924966 Change-Id: Id262eb6967e0109a06739a27b012466031bbd74b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638288Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#680536}
-
Sinan Sahin authored
Bug: 971514 Change-Id: I33ea4ae13e30a6a7e8b25f488d71141c7e8bde7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704855 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#680535}
-
Jordy Greenblatt authored
The enum for the WebUI.Settings.PathVisited histogram recording the visit count for each settings route had two major issues: (1) Almost all of the site settings routes were labelled incorrectly (2) It didn't include several recently added routes, in particular those added as part of the browser/OS settings split (bug 950007). To deal with (1), I replaced all the incorrectly labelled site settings routes with the correct labelling. Generally this meant appending the string '/content' to the beginning of the label because the old label ignored Route.createChild() method's handling of paths that do not start with a slash [1] (the labels just added a slash at the beginning). I dealt with (2) by searching as described in the bug [2] for a comprehensive audit of relevant routes. The search turned up three routes that I believe came from changes that have been migrated away: (1) /help/management (2) /manageAccessibility/tts/googleTtsEngine (3) /parentalControls Because there is little cost to adding a couple unused values, I added them in Patchset 3 in case they are relevant for some edge case. If we need. to remove them again, I can revert it to the state of the CL in Patchset 2. NOTE: The hashes came from following the instructions in [4], following the approach of [5]. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/route.js?rcl=9e4613082bd9a9972a6f5d21cb10f729fe1210bb&l=169 [2] https://bugs.chromium.org/p/chromium/issues/detail?id=952472#c9 [3] https://uma.googleplex.com/p/chrome/histograms/?sid=7c5a1f5262a2ec196167d4546f6448af [4] https://gist.github.com/danbeam/d5fe7b1bcfebc9a94d60c9975b842e97 [5] https://chromium-review.googlesource.com/c/chromium/src/+/1089716/ Bug: 952472, 950007 Change-Id: Iea237f3f7285e520a3ed96f12abeed24911d653b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716215Reviewed-by:May Lippert <maybelle@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/46593a3742be..42937674ae09 Created with: gclient setdep -r src-internal@42937674ae09 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: None Change-Id: If5639b7a1e0442635eed348541f3ee02f39a1dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716597Reviewed-by:
-
