- 03 Aug, 2017 40 commits
-
-
gambard authored
When the user opens a Reading List page, it should not be taken into account for the computation of the Most Visited tiles. Bug: 734067 Change-Id: Iec28e8086051777ab4c43a2e53778c7bab3d54b1 Reviewed-on: https://chromium-review.googlesource.com/596367 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#491689}
-
Jia authored
For marker property, CSSPropertyInvalid was used as the "current_shorthand" in the old/non-API parsing method because it's not used. In its API, we use CSSPropertyMarker just to avoid confusion. There is no real difference. Bug: 668012 Change-Id: I528f7da64d6dc6537a248e8b6a08b3940c0f3b90 Reviewed-on: https://chromium-review.googlesource.com/597092 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#491688}
-
Jean-François Geyelin authored
Follow up to https://chromium-review.googlesource.com/c/589927 Bug: 738881 Change-Id: I8234c93e7557fea982cf6f98fce45a5a6e2bf5c4 Reviewed-on: https://chromium-review.googlesource.com/593649 Commit-Queue: Jean-François Geyelin <jif@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#491687}
-
Kent Tamura authored
Change-Id: If1e1ad4b48d3b97a209c8fe3727d885c64fdc8bd Reviewed-on: https://chromium-review.googlesource.com/599136 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#491686}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/43bd6d3f..19f1033a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ib0623cadd4349df94d0d1743d11c8e75df73a288 Reviewed-on: https://chromium-review.googlesource.com/599375Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491685}
-
Steven Holte authored
Sorry, I reverted wrong cl. BUG: 751948 TBR=bcwhite@chromium.org,holte@chromium.org,olivierrobin@chromium.org This is a reland of 433d6917 Original change's description: > Make MetricsLog not need a PrefService. > > Move system profile persistence to MetricsService. > > Bug: > Change-Id: I5c31dc53de267dd9699a83af926f8a575bab18a0 > Reviewed-on: https://chromium-review.googlesource.com/592689 > Commit-Queue: Steven Holte <holte@chromium.org> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491573} Change-Id: Iea3ebc29e92f3e12fc56f7b7ba767c531f216041 Reviewed-on: https://chromium-review.googlesource.com/598759 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#491684}
-
Tsuyoshi Horo authored
This reverts commit 44e59041. Reason for revert: Caused LayoutTest failures on ASAN bot. BUG:752013 Original change's description: > Introduce SelectionForUndoStep > > This patch introduces |SelectionForUndoStep| to hold selection for undo/redo > instead of |VisibleSelection| and avoid dirty |VisibleSelection|[1] for > improving code health. > > Before this patch, we hold selection as |VisibleSelection| in |UndoStep| and > recompute "visible selection" by |CorrectedSelectionAfterCommand()| at undo/redo > time, DOM tree can be different when we save |VisibleSelection| in |UndoStep|. > > After this patch, we use |SelectionForUndoStep| to hold selection at command > execution and change |EndingVisibleSelection()| to compute visible selection > before we used. > > This patch looks large, but most of them are replacing > |EndingVisibleSelection()| to |EndingSelection()| to use |SelectionInUndoStep| > instead of updated |VisibleSelection|. > > Essential part of this change is > * "CompositeEditCommand.{cpp,h}": holding starting and ending selection in > |SelectionInUndoStep| > > * "TypginCommand.{cpp,h}": Computing |SelectionInUndoStep| other than > |FrameSelection|. > * "SelectionInUndoStep.{cpp.h}": The implementation > * "UndoStep.{cpp,h}": holding staring and ending seleciton in > |SelectionInUndoStep| > > Just for reference, there is another attempt in the patch: > - http://crrev.com/2457523004: Introduce SelectionForUndoStep > - http://crrev.com/c/582724 Introduce SelectionForUndoStep > > [1] Dirty VisibleSelection: |VisibleSelection| holds canonicalized base and > extent positions by using layout tree. Once layout tree is updated, e.g. by > DOM change or style change, |VisibleSelection| may not be canonicalized. In > other words, once we get |VisibleSelection|, it is valid only until layout tree > updated. > > Bug: 747795 > Change-Id: I2da864e03fbd2e06f5150072eafe133430dcbfcb > Reviewed-on: https://chromium-review.googlesource.com/588874 > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491667} TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org Change-Id: I84188673f225161fc65da6ad1693a1721d2d8f5a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 747795 Reviewed-on: https://chromium-review.googlesource.com/599667Reviewed-by:
-
Chung-yih Wang authored
As the benchmark page_cycler_v2 is located under src/tools/perf/contrib/cros_benchmarks, the patch fixes the failure of deps searching for page_cycler_v2.typical_25 by adding the benchmarks directory 'src/tools/perf/contrib' into search path. BUG=728973 TEST=python src/tools/perf/fetch_benchmark_deps.py page_cycler_v2.typical_25 --platform=cros Signed-off-by:
Chung-yih Wang <cywang@chromium.org> Change-Id: Id9e31488cba07bb433551b768ddaaa99e70a2b9d Reviewed-on: https://chromium-review.googlesource.com/598127Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#491682}
-
Doug Turner authored
See "Print Is A Function". Bug: 742592 Change-Id: Ic2744a01a4149a466dab9a7c1208d36238206008 Reviewed-on: https://chromium-review.googlesource.com/599567Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#491681}
-
gaschler authored
Add a section to chrome://snippets-internals to allow testing and fetching contextual suggestions. The section is only shown when flag ContextualSuggestionsCarousel is on. Bug: 749988 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9cd371973c6871f93996515a1ac0eab5d3067343 Reviewed-on: https://chromium-review.googlesource.com/595974 Commit-Queue: Andre Gaschler <gaschler@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#491680}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/255607f094da..fba26ea9b7fc $ git log 255607f09..fba26ea9b --date=short --no-merges --format='%ad %ae %s' 2017-08-03 mtklein exclude SkJumper_stages_8bit.cpp from Google3 build Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I2b65dcaa75c9f107c9b68b6d091c2b529e904232 Reviewed-on: https://chromium-review.googlesource.com/598672Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491679}
-
Elodie Banel authored
The next CL will use the real data to update the UI. See screenshots linked below for what it looks like with this CL and test data. https://drive.google.com/a/chromium.org/file/d/0BxrfNSu8yqJqZG9reWl3T0FCclE/view?usp=sharing https://drive.google.com/a/chromium.org/file/d/0BxrfNSu8yqJqUkNUVlFlYW5Uckk/view?usp=sharing Bug: 622743 Change-Id: Icf8072513c202f9a0909d246c1476e2e2a55a705 Reviewed-on: https://chromium-review.googlesource.com/594052 Commit-Queue: Elodie Banel <lod@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
TBR: hanxi Bug: 751907 Change-Id: I231934d8e83384687d837e140f25e9d553c774ab Reviewed-on: https://chromium-review.googlesource.com/599249Reviewed-by:
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/38bdf22bfe68..7e50824288fa $ git log 38bdf22bf..7e5082428 --date=short --no-merges --format='%ad %ae %s' 2017-08-01 wl * src/truetype/ttgxvar.c (TT_Get_MM_Var): Fix thinko. 2017-08-01 wl Update CHANGES file. 2017-08-01 behdad [truetype] Fix loading of named instances. 2017-08-01 wl [sfnt, truetype] Minor adjustments for OpenType 1.8.2. 2017-07-26 wl [cff] Integer overflow. Created with: roll-dep src/third_party/freetype/src R=wangxianzhu@chromium.org,michaelbai@chromium.org,bungeman@chromium.org,drott@chromium.org BUG=chromium:738343 Change-Id: If5ac9de7dce76fdf808cfb1d7c95125784831708 Reviewed-on: https://chromium-review.googlesource.com/598118 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#491676}
-
Matt Falkenhagen authored
This test doesn't timeout anymore. It fails reliably. Add an expected file for it. As this was the final test linking to bug 658997, we can finally close the bug. TBR=shimazu Bug: 658997, 751959 Change-Id: I8acb6812a9c9c7824aa14d606a63ffbf7478f23e Reviewed-on: https://chromium-review.googlesource.com/598661Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#491675}
-
Nicholas Verne authored
Delete the empty and unused files in web/. Bug: 712963 Change-Id: If0b2f20834e2474ae8ebf23259079045a85601ec Reviewed-on: https://chromium-review.googlesource.com/599139 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#491674}
-
Tsuyoshi Horo authored
This reverts commit 293a6765. Reason for revert: I think this CL caused telemetry_unittests failures. BUG:751967 Original change's description: > Roll SwiftShader 4d3efed..8aa0768 > > https://swiftshader.googlesource.com/SwiftShader.git/+log/4d3efed..8aa0768 > > BUG= > > TBR=kbr@chromium.org > > TEST=bots > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > Change-Id: I1f88e9213f4387e38b4b9d1059d7ee9a419d755f > Reviewed-on: https://chromium-review.googlesource.com/599015 > Reviewed-by: Alexis Hétu <sugoi@chromium.org> > Commit-Queue: Alexis Hétu <sugoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491572} TBR=sugoi@chromium.org,kbr@chromium.org Change-Id: If0463d4bc1a2036feb1317a04c910dc33891755a No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel, linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/599174Reviewed-by:
-
Khushal authored
The GPU cache expects an unref for an empty decode as well (returned in the case of a decode failure). Bug: 751444 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie3875f20a5d5126ae0277520bb032f22eb4e0779 Reviewed-on: https://chromium-review.googlesource.com/598488Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#491672}
-
Chandan Padhi authored
If the requesting renderer is not allowed access to the given origin, browser reports GenerateStream and OpenDevice failures to the renderer. This CL also adds a OnDeviceOpenFailed() method MediaStreamDispatcher mojom interface, equivalent to legacy MediaStreamMsg_DeviceOpenFailed IPC message. Bug: 742682 Change-Id: I6ff2516dd22281cf4c1fad40b56257352f2bdec7 Reviewed-on: https://chromium-review.googlesource.com/597475 Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#491671}
-
Alexandre Courbot authored
This reverts commit dd536442. Reason for revert: prevents Chrome to start on ChromeOS/Eve, as evidenced by git bisect. Original change's description: > Remove unnecessary SetUpContext usage > > It's no longer necessary to use SetUpContext to compensate for > individual field accessors being called twice, as they are no > longer called twice. > > This removes all such uses of SetUpContext/TearDownContext. > > BUG=None > > Change-Id: I1162f095bc40fd73b2f06323c4f78ed5025e0ee6 > Reviewed-on: https://chromium-review.googlesource.com/596497 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491488} TBR=sky@chromium.org,dcheng@chromium.org,jam@chromium.org,rockot@chromium.org Change-Id: I98675b0de0477babfb46ab568c9e20fd127a9365 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/598760Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#491670}
-
Tsuyoshi Horo authored
This reverts commit 3553b1fe. Reason for revert: Caused browser_tests failures. * ProcessMemoryMetricsEmitterTest.FetchDuringTrace * ProcessMemoryMetricsEmitterTest.FetchAndEmitMetrics * ProcessMemoryMetricsEmitterTest.FetchThreeTimes Bug:751948 Original change's description: > Enable Finch Trial Test for MacV2Sandbox. > > Bug: 749839 > Change-Id: Ie95fc3c6574377e278474c1709b7270847016b44 > Reviewed-on: https://chromium-review.googlesource.com/596422 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491576} TBR=jwd@chromium.org,kerrnel@chromium.org Change-Id: I6e96580d4e0cd7f2d810187a9f4864748e9997d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 749839 Reviewed-on: https://chromium-review.googlesource.com/599173Reviewed-by:
-
Raymes Khoury authored
In https://codereview.chromium.org/2969393002 per-file OWNERS were added for PermissionContextBase subclasses, as they would benefit from approval by permissions owners. In https://codereview.chromium.org/2791623004/#msg148 jochen raised the concern that set no-parent would interfere with large-scale refactorings. Remove set no-parent declarations for now until we figure out what the best way forward is. Change-Id: I13b0fdec6b259e5db3bebf9dda425497b885af6f Tbr: jochen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/598662 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#491668}
-
Yoshifumi Inoue authored
This patch introduces |SelectionForUndoStep| to hold selection for undo/redo instead of |VisibleSelection| and avoid dirty |VisibleSelection|[1] for improving code health. Before this patch, we hold selection as |VisibleSelection| in |UndoStep| and recompute "visible selection" by |CorrectedSelectionAfterCommand()| at undo/redo time, DOM tree can be different when we save |VisibleSelection| in |UndoStep|. After this patch, we use |SelectionForUndoStep| to hold selection at command execution and change |EndingVisibleSelection()| to compute visible selection before we used. This patch looks large, but most of them are replacing |EndingVisibleSelection()| to |EndingSelection()| to use |SelectionInUndoStep| instead of updated |VisibleSelection|. Essential part of this change is * "CompositeEditCommand.{cpp,h}": holding starting and ending selection in |SelectionInUndoStep| * "TypginCommand.{cpp,h}": Computing |SelectionInUndoStep| other than |FrameSelection|. * "SelectionInUndoStep.{cpp.h}": The implementation * "UndoStep.{cpp,h}": holding staring and ending seleciton in |SelectionInUndoStep| Just for reference, there is another attempt in the patch: - http://crrev.com/2457523004: Introduce SelectionForUndoStep - http://crrev.com/c/582724 Introduce SelectionForUndoStep [1] Dirty VisibleSelection: |VisibleSelection| holds canonicalized base and extent positions by using layout tree. Once layout tree is updated, e.g. by DOM change or style change, |VisibleSelection| may not be canonicalized. In other words, once we get |VisibleSelection|, it is valid only until layout tree updated. Bug: 747795 Change-Id: I2da864e03fbd2e06f5150072eafe133430dcbfcb Reviewed-on: https://chromium-review.googlesource.com/588874 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#491667}
-
Timothy Loh authored
Change-Id: I7725654a919fa77f2a83199775cba2efeb1dcbb3 Reviewed-on: https://chromium-review.googlesource.com/599172Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#491666}
-
Alexander Alekseev authored
Bug: 705566 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I664ac7f84cf422e7a1947566b6fe23a47c576bb1 Reviewed-on: https://chromium-review.googlesource.com/598509Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#491665}
-
Tsuyoshi Horo authored
This reverts commit 24f0eb87. Reason for revert: net_unittests fails on msan bot NtlmClientTest.Type2MessageWithTargetName NtlmClientTest.NoTargetNameOverflowFromLength https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests/builds/3002 Original change's description: > Add a functionally equivalent NTLMv1 implementation. > > - Replacement NTLMv1 implementation. > - In preparation for new NTLMv2 implementation. > - Passes all unit tests and has the same behavior. > - Adds fuzzer for NtlmClient. > - Code is still not live. > > BUG=chromium:22532 > TEST=All unit tests pass. > > Change-Id: Idae533312805d21d49943fd634d54af3a93a7c00 > Reviewed-on: https://chromium-review.googlesource.com/598307 > Commit-Queue: Zentaro Kavanagh <zentaro@google.com> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491611} TBR=rsleevi@chromium.org,mmenke@chromium.org,zentaro@google.com,asanka@chromium.org Change-Id: I21057e6a0cc43aca6249153debe47e3630df82c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:22532 Reviewed-on: https://chromium-review.googlesource.com/599140Reviewed-by:
-
Xiangjun Zhang authored
Bug: 714717 Change-Id: If707c50a569b1c9ebbed6568c2a6631e55bc1e95 Reviewed-on: https://chromium-review.googlesource.com/584632 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Anton Vayvod <avayvod@chromium.org> Cr-Commit-Position: refs/heads/master@{#491663}
-
Tsuyoshi Horo authored
This reverts commit aecc33fc. Reason for revert: BookmarkAppUrlRedirectorBrowserTest.InAppNavigation fails BUG:751958 Original change's description: > desktop-pwas: Open Bookmark app when link is within scope > > The DesktopPWAWindowing feature must be on in order for this to work. > > Makes it so that, once a user has installed a Bookmark App for a website, all > navigations to that website will open the installed Bookmark App. This includes > typing the address in the omnibox, clicking any links to an in-scope url, and > opening any links to an in-scope url from the context menu. Future patches > will change some of these so that the result is more intuitive. > > For example, if the user has installed https://www.foo.com through > "Add to shelf" and the site's manifest defines scope as "/scope" and then the > user visits https://www.foo.com/scope/test.html, a new app window to > https://www.foo.com/scope/test.html will open. If the user > navigated to https://www.foo.com/index.html, we would not open a new app > window since the address is not in-scope as defined by the site's manifest. > > Three changes: > > 1. Use 'scope' in the site's manifest to create a url handler for > the bookmark app. > 2. Allow Hosted Apps that are Bookmark apps to use url handlers. > This means that any non-bookmark hosted app that has url handlers > will fail to load. > 3. When handling a url that a Bookmark app could handle open the > the bookmark app with the specified url. > > Bug: 740783 > Change-Id: Iac69b13dc33be9ecd7336f24ae9021d5dd0161d0 > Reviewed-on: https://chromium-review.googlesource.com/566199 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491644} TBR=benwells@chromium.org,calamity@chromium.org,mgiuca@chromium.org,ortuno@chromium.org,skym@chromium.org,jochen@chromium.org Change-Id: I5e4bf4899d56fd2ffc1755b6cd5db0aa9c0c02d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 740783 Reviewed-on: https://chromium-review.googlesource.com/599090Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/b4fee4d5d471..d1a8458e6390 $ git log b4fee4d5d..d1a8458e6 --date=short --no-merges --format='%ad %ae %s' 2017-08-02 thestig Avoid a redundant header offset check in CPDF_Parser. 2017-08-02 hnakashima Replace CFX_ByteTextBuf with ostringstream in cfx_psrenderer.cpp. 2017-08-02 hnakashima Replace CFX_ByteTextBuf from cpdf_security_handler.cpp with std::vector 2017-08-02 rharrison Remove unused FromUnicode method 2017-08-02 art-snake Unify parsing of cross refs v4 2017-08-02 rharrison Remove parameter from GetID 2017-08-02 rharrison Remove support for out of bounds params in Delete Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I633fc2cb7101cc1fcb0f8dc57be00c8f54f3c55c Reviewed-on: https://chromium-review.googlesource.com/599392 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491661}
-
Yoshifumi Inoue authored
This patch moves |is_handle_visible_| to |FrameSelection| from |SelectionTemplate| since handle visibility is used only for setting |FrameSelection|, hence it is a redundant member variable of |SelectionTemplate|. Bug: 742093 Change-Id: I3add4da3844fb40be34dcb4d4b46b5fa6fed1d7e Reviewed-on: https://chromium-review.googlesource.com/595389 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#491660}
-
Tsuyoshi Horo authored
Bug: 751906 Change-Id: I7f43cc71da5557ebf396280cf295f76ed04e9e91 TBR: chenwilliam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/599138Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/45ad6a02..43bd6d3f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ia552de41f9306dcbeefc8beb04a48252db18df00 Reviewed-on: https://chromium-review.googlesource.com/599157Reviewed-by:
-
Tsuyoshi Horo authored
TBR: reillyg@chromium.org Bug: 751955 Change-Id: Iac23c3c3df62e4dbccaaf80192297dbbb52a48e8 Reviewed-on: https://chromium-review.googlesource.com/599137Reviewed-by:
-
Michael Moss authored
This reverts commit b567cf95. Reason for revert: breaking official.continuous builders BUG=751954 Original change's description: > Add a "buildbucket" subcommand to mb. > > This subcommand prints the trybot configuration in the > buildbucket.config format expected by gerrit. This should hopefully > make it a little easier to maintain the buildbucket.config file. > > Bug: > Change-Id: I7d956efb6c08128ae0ceaa6b68bcc9001296549c > Reviewed-on: https://chromium-review.googlesource.com/568666 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491647} TBR=agable@chromium.org,dpranke@chromium.org,pcc@chromium.org Change-Id: I2cc5f086b9787723337795c3c2323c3bafdc89f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/599393Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#491656}
-
Christopher Cameron authored
This logic was incorrectly inverted. Bug: 735613 Change-Id: Ib07302612c02e860c006f0cc2e9929a04f5de009 Reviewed-on: https://chromium-review.googlesource.com/596710 Commit-Queue: ccameron chromium <ccameron@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#491655}
-
Michael Montvelishsky authored
This reverts commit a34be8ec. Reason for revert: http://eureka-internal-review.git/c/81685 Original change's description: > Make audio frame chunk_size a factor of 4 > > BUG=internal b/63390317 > > Change-Id: Ia1c11717aea70bdda8e5542fea89b0e7c7c0a46b > Reviewed-on: https://chromium-review.googlesource.com/588470 > Reviewed-by: Le-Chun Wu <lcwu@chromium.org> > Commit-Queue: Michael Montvelishsky <mont@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490290} TBR=lcwu@chromium.org,slan@chromium.org,halliwell@chromium.org,wzhong@chromium.org,jyw@chromium.org,kmackay@chromium.org,bshaya@google.com,alokp@chromium.org,mont@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: internal b/63390317 Change-Id: I09c7154a5f065e320ca440583aebbd3495c6cc33 Reviewed-on: https://chromium-review.googlesource.com/598387Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Michael Montvelishsky <mont@chromium.org> Cr-Commit-Position: refs/heads/master@{#491654}
-
Patti authored
Make the Site Details web UI update permission values when they change without needing to reload the Site Details page. Manual test - With #enable-site-details on, open https://permission.site. Open the Page Info bubble, click "Site settings", and drag the Site Details tab out into a new window so that the https://permission.site and the Site Details windows are viewable at the same time. On https://permission.site, open the Page Info bubble and change a permission there. It should automatically update to show the same permission in the Site Details page. Bug: 656758 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If1b28afbed3317a7ac43ada1d8ca02424137b50d Reviewed-on: https://chromium-review.googlesource.com/595299 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#491653}
-
Tsuyoshi Horo authored
TBR: chenwilliam@chromium.org,dgozman@chromium.org Bug: 751906 Change-Id: I44c2496307f32343b5120884ed58a9b4e0933722 Reviewed-on: https://chromium-review.googlesource.com/599135Reviewed-by:
-
Matt Falkenhagen authored
Bug: 748416 Change-Id: I37d13c799e61fff05bc75675a888ce2630995aa0 Reviewed-on: https://chromium-review.googlesource.com/597576 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491651}
-
Eliot Courtney authored
We had tried filtering noisy ARC processes out, using their ProcessState. However, ideally the task manager should summarise the total resource usage and not completely hide processes. Further, there were some hard to resolve issues about processes that ought to definitely be shown being hidden (see linked bug for context). So, until we have a better solution for noisy ARC processes, remove this filter. BUG=738651 Change-Id: Icf9d246e053185af5c5d7b20f90245fcd169ecc8 Reviewed-on: https://chromium-review.googlesource.com/582265Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#491650}
-
