- 22 Oct, 2020 40 commits
-
-
minch authored
Collapse button use kUnifiedMenuExpandIcon now, remove the old one. And update the function name from OnEnabledChanged to UpdateVectorIcon. Bug: 1131543 Change-Id: I5d42a7941b07255da1ccc267bc5b44934dc4f492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486661 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#819927}
-
Jack Lynch authored
This CL increases the maximum enum size accepted by DevToolsUIBindings::RecordEnumeratedHistogram from 100 to 1000. Bug: 1140386 Change-Id: I72ca6b48825cb4e3e681322cd6107d729a817578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488561Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819926}
-
Moe Ahmadi authored
Fixed: 1141138 Change-Id: Ic99a4259b1a0eb35fac38625a309256352d7d380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490861Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#819925}
-
Vasiliy Telezhnikov authored
This CL adds UseGles2ForOopR to devui to help debug issues that might be related to this feature. Change-Id: I171d4c61d2269b83969d1aab0f1140a857f53a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490989Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#819924}
-
Lukasz Anforowicz authored
Bug: 1141446 Change-Id: I93f6873b97cda1bf34b28fd4fefb6d55036eb215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492541Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#819923}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3ec9833e881..f15a598ab083 2020-10-22 egdaniel@google.com Revert "Reland "Create a basic IRNode pooling system."" 2020-10-22 egdaniel@google.com Revert "Add pooling support on iOS." 2020-10-22 brianosman@google.com Add much better SkTHashMap visualization to Skia.natvis 2020-10-22 kjlubick@google.com [fuzz] Copy crashing outputs before failing 2020-10-22 johnstiles@google.com Add pooling support on iOS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: Iec71905e256ae973c14bd7596c9f6ecc746a2e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491668Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819922}
-
Willie Koomson authored
Since these metrics currently represent all of the OOM kills and low memory kills on the system, use Memory prefix instead of Arc. Also updates histograms to use functions instead of macros, since they aren't on a critical path. BUG=b:165194376 BUG=916757 TEST=Build success and MemoryKillsMonitorTest. Expect UMA results with new prefix Change-Id: Ie4492feada24349a72bc8cec64e32f45ca6dae53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488397 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Kuo-Hsin Yang <vovoy@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#819921}
-
Sammie Quon authored
App list was closing because activating a new window closes the app list. This CL addresses that by only activating windows on desk switch, if the current active window is in the mru list (is a app window). If the current active window is not an app, such as the app list, then we switch desks without activating the mru window on the new desk. This would also work on other windows built similarly, but the only one I'm aware of is the app list. Test: manual, added test Change-Id: I31314800a4fd5c774d23148875e851377ef89f20 Fixed: 1138982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485566Reviewed-by:
-
Sorin Jianu authored
This is renaming the out-of-process artifacts as `proxy`, to indicate that they are communicating via RPC with the rest of the system. The in-process entities are renamed as `impl`, to suggest that they are implementations of functionality provided by the corresponding interfaces. Bug: 1121297 Change-Id: I50a62fb19d56e455cd9e001b7642cef85f114e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490677Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819919}
-
David Dorwin authored
These are no longer necessary now that run-test-component exposes both fuchsia.logger.LogSink and fuchsia.logger.Log by default. Bug: 1139161 Change-Id: I66f6e91d22965a2a6984c1560f56cef0c8cef2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476732Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819918}
-
Mark Yacoub authored
Modeset no longer goes through HardwareDisplayPlaneManager::Commit overload that currently handles page flip only. Remove the should_modeset flag as it's no longer needed. BUG=1082882 TEST=modeset is performed. HardwareDisplayPlaneManagerTest.* Change-Id: I6804de8aa06ca382bc0800bc5c646060bba964e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492720Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#819917}
-
Xianzhu Wang authored
When we skip a GraphicsLayer subtree for painting because the subtree is throttled or display locked, previously we left stale paint data in the GraphicsLayers. These data referenced old paint artifacts, causing them not removed until the GraphicsLayers are removed or repainted. Now when painting GraphicsLayer tree, walk into the skipped subtree and clear old paint data. Bug: 1132717 Change-Id: I4639546c5391941fda85b1f1225e5367fb9f1841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482167 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#819916}
-
Cattalyya Nuengsigkapian authored
- Show edit and delete buttons for screenshot preview notification. - Show only an edit button for video preview notification. # Testing - Screen recording shows expected buttons in preview notification for image and video, and correct behaviors when pressing each button. https://drive.google.com/file/d/10KUoHfGgNk3hzZACNz2WOSZmkYGY4Cl9/view?usp=sharing Bug: 1136666 Change-Id: Ia6efe6ce5862dc2be1163b994f5ef74966ee6c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488365 Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/377d9b3b2b65..c1aeb6318c47 2020-10-22 vidorteg@microsoft.com Reland "Localization: Migrating Settings Folder" 2020-10-22 alexrudenko@chromium.org Improvements for the Icon component 2020-10-22 jacktfranklin@chromium.org Fix flickering in emulation mode 2020-10-22 janscheffler@chromium.org Remove verbose logging in e2e tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1135482,chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0d976bdc4a046040cb27054348c117dfb36c1f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491316Reviewed-by:
-
Dave Tapuska authored
The widget can ask the browser to start a close on the widget's behalf. BUG=1097816 Change-Id: I8f1094c6efbb0f4e553e6763d32cd7d1cdcb6744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472425Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#819913}
-
Xianzhu Wang authored
The conditions were in CompositingReasonFinder controlling compositing reasons. To prevent CompositorAnimations from starting composited transform animation for the element, we needed to disable compositing. Now move the conditions into CompositorAnimations. We'll still composite the elements with transform animation even if the animation can't be started on compositor. Compositing will still benefit to main thread animations, and we'll respect other compositing triggers. Bug: 1134652 Change-Id: Idc341a2a428f8911f98f7742169db506ab677c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490747 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#819912}
-
Matt Jones authored
This patch removes the roundabout way of setting the ResourceManager in LayerTitleCache in favor of setting it directly in the constructor. The initialization path no longer has to pass through CompositorView. Bug: 1070281 Change-Id: I9a622a4c19c8e11d72ee159583b1916c46b0e5c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481469Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#819911}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7b6f13473709..3065fbe8b1b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC robertocn@google.com,mmentovai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1091475 Tbr: robertocn@google.com,mmentovai@google.com Change-Id: I10645fe157e3420045c62e7be547b764825a3370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492164Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819910}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1603335567-5b7ae75a80b56b2c3e08e562ca96c9be42987f9c.profdata to chrome-win64-master-1603357187-4783767f29971847246b39ba5f03512056047f0d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I67a2da59d10ad62e66cfefda53219350989e2901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491809Reviewed-by:
-
Matt Jones authored
Because of the way touch events are routed in the layout system, it is possible for the gesture detectors to occacionally miss events. This patch checks that events captured by the AreaGestureEventFilter have a valid down event prior to processing. Bug: 1026139 Change-Id: I37c26dcc49c36c61290aba7586bdc962238a06eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490321 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
minch authored
See recorded video at https://drive.google.com/file/d/13kAPw4I16KbMgqXjx5juVMADNSzJF6K2/view?usp=sharing Bug: 1131543 Change-Id: I25071e7f5576c1c425373164007389167bd4946f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489322 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
Tom Sepez authored
The FPDF_PageToDevice() API does not guarantee specific out-parameter values when failure is indicated, so avoid using them in subsequent calculations. Although this can't happen in the currently shipping chrome, future changes in PDFium to support XFA might make this possible. Bug: 1141256 Change-Id: Ib0b9b40ab419b2ea698e0dc6172343fea0ef989c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491978Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#819906}
-
Dominique Fauteux-Chapleau authored
This moves and renames classes from chrome/browser/safe_browsing/cloud_content_scanning/ to chrome/browser/enterprise/connectors/ when they are only used by Connectors, leaving code shared by APP/SafeBrowsing/Connectors in cloud_content_scanning. This is only a refactor and should not affect the behaviour of APP, Safe Browsing or Connectors. Bug: 1109244 Change-Id: I2bf3439b7baa48bc0e662aa0a73e23dd896780cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468898Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#819905}
-
Azeem Arshad authored
This CL fixes issue with mobile data toggle screen-reader callouts not being descriptive about how the toggle can be enabled. Fixed this by adding a description about enabling bluetooth. Screenshot: https://screenshot.googleplex.com/w8Sw5qbeq9C3oy7.png Fixed: 1111853 Change-Id: I64b32b14e20dda610f7f2d33a197289140181eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482082 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#819904}
-
Jeffrey Young authored
Use global UserActivityDetector to check for ambient mode timeouts. Handle ET_SCROLL and ET_MOUSEWHEEL events. BUG=b:170217692 BUG=b:170892408 TEST=move mousewheel or two finger scroll on lock screen to exit ambient mode Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I043233979ea7cbae205b9dbbcc932b45f333d059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476582 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#819903}
-
Harry Cutts authored
Bug: none Test: change a preference and check chrome://histograms shows the sample Change-Id: I7746b17bbe84864be03954c664b3263204a040b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491985 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#819902}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f80cfd667638..0ce7bcc8e296 2020-10-22 ihf@chromium.org [licenses_lib] Remove pepper-flash handling. 2020-10-22 edcourtney@google.com paygen: Use CreateTarball for stateful.tgz. 2020-10-22 ctmcnamara@chromium.org retry_util: Force curl to use HTTP 1.1 2020-10-21 seanabraham@chromium.org commands: include suite details in "Suite failed." error If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Idd59082ccab706cd608f7a27a3a09fc2c30a505d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491610Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ibaf213fdebb4c06d6d0bec4ea733de35ba504fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491356Reviewed-by:
-
Xianzhu Wang authored
This combines the following two LayoutView full paint invalidation methods: SetShouldDoFullPaintInvalidationForViewAndAllDescendants() InvalidatePaintForViewAndCompositedLayers() The new method is named InvalidatePaintForViewAndDescendants() Change-Id: If49dabc2759ccd940788c1db5e4e4f019155f7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489673 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#819899}
-
Peter E Conn authored
This CL is a refactoring that should contain no behavioural changes. It splits parts of the DigitalGoodsConverter into two additional classes, the GetDetailsConverter and the AcknowledgeConverter, and it deduplicates some of the logic in the DigitalGoodsAdapter. This should put the code in a slightly nicer state to add the new method call, ListPurchases. Change-Id: I6e56a5dc2077371a8de8bbb16eb0799bdb971a31 Bug: 1139795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487087Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#819898}
-
Aaron Leventhal authored
- Lengthen crash key strings and shorten data. 64 characters was not enough, especially when the crash key name uses some of that. - Temporarily remove the illegal reparenting dumps, as they are currently too noisy. TBR=dmazzoni@chromium.org AX-Relnotes: n/a Bug: 1141441 Change-Id: Ibaa6c91f2b17f04db1d724b49251a9fc3440545a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490115 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819897}
-
Nate Chapin authored
Change-Id: I8c19316f71a74160d470cbc9cd0fd5073b25435b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491001 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#819896}
-
Ryan Daum authored
* Relanding of functionality in chromium/2422501 * With fixes to register the IME observer in OnVisible instead of AttachTo, and breaks the observer out into its own source unit. * Registers and watch for text input focus events within webview content. * Defines a new gRPC payload for said events, and broadcasts them. Bug: internal b/161811385 Test: on device & manually with wayland client tool Change-Id: I3d264f5a76931becae2e83c35ae18dceb13b84d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490359Reviewed-by:Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#819895}
-
Ryan Sturm authored
The rate limiting is based on the number of attempted prefetches in the last minute (technically, it is the number of prefetches in the caching limit that were not served). Bug: 1138650 Change-Id: I0ed6108a8f065c2fb7acc5a90521d978dca0f830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490551Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#819894}
-
Emily Stark authored
This reverts commit f11131a3. Reason for revert: We want to take a more cautious approach that doesn't immediately re-enable elision for existing extension users. Original change's description: > Remove unelide feature from Suspicious Site Reporter extension > > Since there is now a context menu option to show full URLs, this > feature is no longer needed in the Chrome extension. This allows > more flexibility, since users can now use the extension and keep > simplified domain display. > > Change-Id: I4e8a3b7baeca34983ee2bff82535bd332c1087cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435960 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Commit-Queue: Livvie Lin <livvielin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812155} TBR=ellyjones@chromium.org,meacer@chromium.org,vakh@chromium.org,livvielin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib4e8b4c155df78a44bf281c1a4e207cdc4b29e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491976Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#819893}
-
James Cook authored
platform_util contains utilities for showing a file in a file explorer and opening a URL with an external protocol handler. These will need to be plumbed from lacros to ash via crosapi. Introduce a stub file for lacros. Rename the existing _chromeos file to _ash to match our naming scheme. No functional changes. Bug: 1139128, 1140585 Change-Id: I51d50f3687010f8397c8ea584cce21caccbe6982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488084 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#819892}
-
Jan Wilken Dörrie authored
This change adds a feature flag that allows treating heuristics to find new_password fields as reliable. This increases the number of password forms on which password generation can be offered, but might lead to false positives. Bug: 1140493 Change-Id: Ie7083a14664b811d2bac87c4dac302e35575a79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490116Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#819891}
-
Ryan Sturm authored
Search pages are considered stale after 60 seconds (finch param that probably won't be set). This CL adds a OneShot Timer map entry match the prefetch entry and removes them in sync as well. The Timer triggers removal if it has not already occurred. Bug: 1138639 Change-Id: I5442eba3fb6855aa4edcf0e0d51fcec8db8b4f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490984Reviewed-by:
-
sandromaggi authored
Bug: 1140957 Change-Id: I620da71cea62a553eba7a756065aac0e2d47cfe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489989 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#819889}
-
minch authored
FloatingMenuButton only reuses little logic of TopShortcutButton. e.g, set the tooltip. And TopShortcutButton named as the top shortcut button at the system tray menu. Make FloatingMenuButton as ImageButton instead. And AutoclickScrollCloseButton to be a FloatingMenuButton to reuse its logic. Then simplify TopShortcutButton to have only one constructor. Bug: 1131543 Change-Id: I68bc2ed7e535b45319c47271c2dfc4cd8f0e2626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485563 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
