- 20 Nov, 2018 12 commits
-
-
Andrey Kosyakov authored
Bug: 899437 Change-Id: I4d6167d30a7b7014c17393960fce3ecb1470b80e Reviewed-on: https://chromium-review.googlesource.com/c/1342778 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#609526}
-
Alex Newcomer authored
More cleanups, this is just within ash, not within app_list or shelf. Bug: 906684 Change-Id: I42b6a0b6765481685a1ec5e612b4d849f8f3f0ff Reviewed-on: https://chromium-review.googlesource.com/c/1342766Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#609525}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/26fa18517532..739d7c2cc952 Created with: gclient setdep -r src-internal@739d7c2cc952 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5c7c5f663099d2f1d25bad9ffb663307531387b1 Reviewed-on: https://chromium-review.googlesource.com/c/1342944Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609524}
-
Maks Orlovich authored
Bug: 900608 Change-Id: Ic1647bbcc227f8ac497b01a05a4ca4fcefe3b9ae Reviewed-on: https://chromium-review.googlesource.com/c/1340829 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#609523}
-
Zhenyao Mo authored
Some Linux drivers do not seem to recover well after OUT_OF_MEM and context lost. BUG=893117 TEST=bots R=piman@chromium.org Change-Id: I55faefe2d631f3a682dd0b441d2a835836b792a6 Reviewed-on: https://chromium-review.googlesource.com/c/1343102Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#609522}
-
Yves Arrouye authored
Bug: chromium:905702 Test: manual, unit tests Change-Id: I8e6902706a67eaa1e712c6c1147c4cc696b67fb2 Reviewed-on: https://chromium-review.googlesource.com/c/1338170 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#609521}
-
John Abd-El-Malek authored
NetworkContext::domain_reliability_monitor_ was being destroyed before the URLLoaders that are owned by NetworkContext::url_loader_factories_ because of the declaration order. Reset domain_reliability_monitor_ in the destructor so that it's not used later (since we null-check it before use). Bug: 906452 Change-Id: Ib4ec198953142672a3991a4c62436733bd8da171 Reviewed-on: https://chromium-review.googlesource.com/c/1343337 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#609520}
-
Darren Shen authored
Bug: 876901 Change-Id: Ic8a37a79fe8bd41606f6be2ef5e5e2e6bc268e7e Reviewed-on: https://chromium-review.googlesource.com/c/1341738Reviewed-by:
-
Hirokazu Honda authored
GenericDmaBufVideoFrameValidator swaps U plane and V plane addresses so that VideoFrameValidator is able to libyuv::I420Copy in the order Y, U and V. This is a wrong design, meaning VideoFrameMapper does not only map but also does something. VideoFrameMapper caller should expect the address acquired by VideoFrame::data(UPlane) is V plane's and one by VideoFrame::data(VPlane) is U plane's in the case of YV12 VideoFrame. BUG=chromium:895230, chromium:856562 TEST=VDA unittest on hana with --frame_validator=check TEST=VEA unittest on hana with --native_input Change-Id: Ibf5e5685d95634fe6720f07dc154fd01907516d8 Reviewed-on: https://chromium-review.googlesource.com/c/1341783Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#609518}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0ce5f96e. With Chromium commits locally applied on WPT: 5ee777f6 "Fix test exclusion logic of wpt/referrer-policy test generator warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 1920 and retry the command." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I90af7441279da10c77821cd8bd343d11f5c41cd9 Reviewed-on: https://chromium-review.googlesource.com/c/1343252 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609517}
-
chrome://proximity-authKyle Horimoto authored
This CL fixes a regression which replaced feature names on this page with numbers representing the features. The regression was caused by erroneous removal of the #include containing the operator<<() function which prints the enum names. Bug: 906836 Change-Id: Idb35e491ff379cc0ea97e63b57b4078a85efd0af Reviewed-on: https://chromium-review.googlesource.com/c/1343350Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#609516}
-
Alice Boxhall authored
Bug: 835455 Change-Id: If3f4eacb975a8ee50a66bb787a55d257633cfb1e Reviewed-on: https://chromium-review.googlesource.com/c/1242572 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#609515}
-
- 19 Nov, 2018 28 commits
-
-
Robert Sesek authored
This enables the views version of the message_center, in preparation for removing the Cocoa implementation. Fixes: - Use an EventGenerator in tests, rather than manually synthesizing events. - NotificationInputContainerMD::HandleKeyEvent() now explicitly clears the text input field when handling VKEY_RETURN, as the test expects this. - Disabling notifications is no longer handled in NotificationViewMD::ButtonPressed(), since it wasn't the button Listener for the block_all_button_ (the NotificationControlButtonsView is). Disabling is now handled in ToggleInlineSettings() instead. - The SlideOut tests are disabled on Mac because the test framework doesn't support synthesizing gesture scroll events. Bug: 739386 Change-Id: Id841779233662111f52d491ba78e5315422003b4 Reviewed-on: https://chromium-review.googlesource.com/c/1341091 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#609514}
-
Abhishek Arya authored
R=rouslan@chromium.org Bug: 900477 Change-Id: I48e0221d6df217863427316967a166174c0acf04 Reviewed-on: https://chromium-review.googlesource.com/c/1342760 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#609513}
-
Kyle Horimoto authored
This CL expands upon [1], which was a quick fix to fix a crash in the M-71 branch. This follow-up CL makes the class more robust by ensuring that if connection priority is updated before a connection attempt is made, the connection will be made with the updated priority when it is performed. Additionally, this CL adds a test for this functionality. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1338322 Change-Id: I9a881c67276c5f571b9119c27d899762b9c5f02f Reviewed-on: https://chromium-review.googlesource.com/c/1340977Reviewed-by:
-
Ethan Xu authored
This is the first CL of web share target V2. The goal of this CL is to add support for three new fields: method, enctype, and fields. This is in reference to the new web share target spec. https://pr-preview.s3.amazonaws.com/ewilligers/web-share-target/pull/53.html#share_target-member The purposes of each field are as follows: method: the HTTP method used for launching the web share target. Can be either GET or POST. enctype: the encoding method used for launching a POST request web share target. Can be either application/x-www-form-urlencoded or multipart/form-data. files: a sequence of files each containing a name and an accepted sequence of mime types. Note that this can only be populated if the method is POST and the enctype is multipart/form-data. Logic checks are performed in manifest_parser.cc to determine if the web share target has a valid combination of fields. Bug: 885308 Change-Id: I277fef7e1402620385cb28909a078eb09676c1fc Reviewed-on: https://chromium-review.googlesource.com/c/1240867 Commit-Queue: Ethan Xu <xuethan@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#609511}
-
Gauthier Ambard authored
This CL changes how the computation of the content insets of the scroll view displaying the PDF is done on iOS 11. Bug: 903635 Change-Id: I5dc8d69b4fbf0a6e68db1481f1991c9bdbc0b43b Reviewed-on: https://chromium-review.googlesource.com/c/1341988 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#609510}
-
Charlie Andrews authored
The current comment suggests that it does, but it seems worthwhile to make it explicit given that the name of the event might suggest otherwise. Change-Id: Ie0ab5a95a462e9e493336644fa1d7f4ecd5edc42 Reviewed-on: https://chromium-review.googlesource.com/c/1340859Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#609509}
-
Corentin Wallez authored
BUG=chromium:901830 Change-Id: I491fa83b4fe6e817e9bfb285ed81ce3b4356088f Reviewed-on: https://chromium-review.googlesource.com/c/1341843Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#609508}
-
Donn Denman authored
Conditionally disables this test due to flakiness on this configuration. BUG=906788 TBR=twellington@chromium.org Change-Id: Ief4f08ae1d9f8c73b3055d136af655498a97892f Reviewed-on: https://chromium-review.googlesource.com/c/1343361Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#609507}
-
James Zern authored
lossless encoder speedups and memory reduction when decoding corrupt images Bug: 905157 Change-Id: I0122578ae12a3654ddb2b9dead13ef3823fddc19 Reviewed-on: https://chromium-review.googlesource.com/c/1337378Reviewed-by:
Urvang Joshi <urvang@chromium.org> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#609506}
-
Jonathan Metzman authored
TBR=mmoroz@chromium.org Change-Id: Ida8773dbc2d4d13a04dc96b2afc84e1a8d0c94f4 Bug: 904877 Reviewed-on: https://chromium-review.googlesource.com/c/1343245Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609505}
-
Steven Valdez authored
Bug: 630147 Change-Id: I20541f77c7e9e8d5a0085452d2a883e24563083c Reviewed-on: https://chromium-review.googlesource.com/c/1330069 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#609504}
-
Sidney San Martín authored
This'll make it easier for me to delete surrounding code, and I can't find any references to it so I suspect that it's safe to prune. Bug: 868398 Change-Id: Ib62d77f87df261200c6e6c1b821f99ed707041b9 Reviewed-on: https://chromium-review.googlesource.com/c/1343058 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
David Benjamin authored
I noticed this going through apache error_log.txt trying to diagnose other failures (perl warns about uninitialized value). $STATUS_TEXTS is a reference to a hash, so it should be accessed via $STATUS_TEXTS->{$REDIRECT_CODE}. $STATUS_TEXTS{$REDIRECT_CODE} means it is accessing %STATUS_TEXTS. Switch to the latter. Bug: none Change-Id: I177105deb451e88e8f21ca4a7e0cce7b21727991 Reviewed-on: https://chromium-review.googlesource.com/c/1340561Reviewed-by: -
Manu Cornet authored
Bug: 904231 Change-Id: I0eeb3131339da7d9c3cbeb308e7df50acd85220d Reviewed-on: https://chromium-review.googlesource.com/c/1341648Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Sorin Jianu authored
With this change, the configurator code injects both values. extra_info_["testrequest"] = "1"; extra_info_["testsource"] = "dev"; Bug: 906641 Change-Id: I4cd3f68b9b292f2d76b95d3678bd6df0cd437e73 Reviewed-on: https://chromium-review.googlesource.com/c/1343294Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#609500}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5913160a7d40..1e54003639e3 git log 5913160a7d40..1e54003639e3 --date=short --no-merges --format='%ad %ae %s' 2018-11-19 crouleau@chromium.org Fix help for --also-run-disabled-tests flag. Created with: gclient setdep -r src/third_party/catapult@1e54003639e3 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3ae7ab6c2d755ac83bf8536bde51f15f33bd476e Reviewed-on: https://chromium-review.googlesource.com/c/1342781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609499}
-
Robbie McElrath authored
This fixes 2 tests that were flaky on the waterfall. Diff patchsets 1 and 2 to see what changed. Original change's description: > Get NetworkChangeNotifier working on ChromeOS with network service. > > The current NetworkChangeNotifierChromeOS implementation won't work > with the network service enabled because it listens for network changes > from Shill, which only supports a single client. The browser process > has other dependencies on Shill, so it has to be the client for the time > being, meaning the network service can't directly listen for network > changes and has to be notified of them from the browser process. > > This CL splits the NetworkChangeNotifierChromeOS into two parts; > the first will live in the browser process and listen to Shill, while > the second is the actual NetworkChangeNotifierChromeOS implementation > which will have an instance in both the browser and network processes. > Since NetworkChangeNotifierChromeOS can't actually listen for network > changes itself, it just gets notified of changes from part 1 via a new > method in NetworkChangeManager. When the thing listening to Shill sees > a network change, it notifies its local NetworkChangeNotifierChromeOS > instance, and calls the new NetworkChangeManager method, the > implementation of which then notifies the network service's > NetworkChangeNotifierChromeOS instance. > > Bug: 882610 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414 > Reviewed-on: https://chromium-review.googlesource.com/c/1274445 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606665} Bug: 882610 Change-Id: I5547353ed5f944620548109c40eeb149fd85a710 Reviewed-on: https://chromium-review.googlesource.com/c/1338493 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#609498}
-
Roger McFarlane authored
Bug: 860285 Change-Id: I00282340aa8c16918237d1dbd5c69a9a5e0cb595 Reviewed-on: https://chromium-review.googlesource.com/c/1336550Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#609497}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dac70cc74650..21f7091b9a09 git log dac70cc74650..21f7091b9a09 --date=short --no-merges --format='%ad %ae %s' 2018-11-19 yueherngl@google.com hatch: add new paladin Created with: gclient setdep -r src/third_party/chromite@21f7091b9a09 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I720089d83fb6df897a48af8aa7aa5590f0bf7423 Reviewed-on: https://chromium-review.googlesource.com/c/1343181Reviewed-by:
-
rbpotter authored
The scroller is now focusable due to Blink changes at r608013. Remove the outline and take it out of the tab order. Bug: 905604 Change-Id: Ib8154c691e1240b27118288950c8efdf46c803b6 Reviewed-on: https://chromium-review.googlesource.com/c/1343285Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#609495}
-
Jun Choi authored
This reverts commit 7b0f2bb8. Reason for revert: Fails multiple IOS builds including Builder ios-slimnav <https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-slimnav/191> Link to sample failure logs : https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8929398908718170816/+/steps/ios_chrome_unittests__iPhone_6s_iOS_12.1_/0/logs/TextToSpeechListenerTest.ValidAudioDataTest/0 Original change's description: > Add web::NavigationContext::IsPlaceholderNavigation > > This is a step in multistep refactoring. The next steps will be: > > 1.) web::NavigationContext::URL is never set to placeholder > URL and always represents navigation URL > 2.) Same web::NavigationContext will be reused for placeholder > navigation to extend it's lifetime. > 3.) WebStateObserver::DidFinishNavigation will be caller after > placeholder navigation is finished and will use original > web::NavigationContext passed to WebStateObserver::DidStartNavigation > > This will partially fix crbug.com/903497 and will call > WebStateObserver::DidFinishNavigation after committed URL actually > changed. > > Bug: 903497 > Change-Id: Ib6ba96d664ac352d038787aa74ac844d07282789 > Reviewed-on: https://chromium-review.googlesource.com/c/1331044 > Reviewed-by: Danyao Wang <danyao@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609398} TBR=eugenebut@chromium.org,danyao@chromium.org Change-Id: I8d7c9b66d752a792761d95ccf348f045eaa9de03 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 903497 Reviewed-on: https://chromium-review.googlesource.com/c/1343351Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#609494}
-
Saman Sami authored
We only need to call this method during main frame navigation. TBR=apacible@chromium.org Bug: 893850 Change-Id: Id78fb02440f646c07de9bec3460cbb64809781f1 Reviewed-on: https://chromium-review.googlesource.com/c/1340702 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#609493}
-
Antoine Labour authored
GL_REQUIRED_TEXTURE_IMAGE_UNITS_OES is a "get"-only enum, so even though it may be accepted by the texture_paramter validator (which has both "set" and "get" enums, as they are mostly the same), we need to handle it in Texture::SetParameter* and return GL_INVALID_ENUM. Some enums (e.g. GL_TEXTURE_SRGB_DECODE_EXT) were only handled in Texture::SetParameteri, so rework this a bit so that SetParameterf always delegates everything (including error cases) to SetParameteri, except for float params (which are only a handful), to avoid most of the duplication. Bug: 877754 Change-Id: I15c52f81e62544f90a15b914113c5c4816530cdb Reviewed-on: https://chromium-review.googlesource.com/c/1343357Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609492}
-
Quan Nguyen authored
This puts the method name more in line with Google C++ style, since snake_case should only be used with simple getters. Bug: 906676 Change-Id: I045aa7c8ac641b37854b38cf0934890ebbd88ca0 Reviewed-on: https://chromium-review.googlesource.com/c/1343250Reviewed-by:
-
Changwan Ryu authored
When you use custom-schemed URLs across XHR, you will see an error saying that you cannot send an XHR from 'null' origin. This CL adds tests to compare the behavior between HTTP-schemed URL and custom-schemed URL such that the actual fix can pick it up. Bug: 898589, 900528, 896059 Change-Id: I43b4748a6595298d4ac6fdb216c8db1738719adf Reviewed-on: https://chromium-review.googlesource.com/c/1340999Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#609490}
-
Ken Rockot authored
Migrates the unzip and patch services away from deprecated ServiceContext & EmbeddedServiceInfo stuff, instead using ServiceBinding with explicit Service instance construction where needed. Bug: 891780 Change-Id: I6382857974cf7f20f25ff16dd9ef21270e85d4d7 Reviewed-on: https://chromium-review.googlesource.com/c/1316442Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4065d45d2de1..a63cf8e80aa5 git log 4065d45d2de1..a63cf8e80aa5 --date=short --no-merges --format='%ad %ae %s' 2018-11-19 rmistry@google.com Revert "Temporarily remove Android compile bot from CQ" 2018-11-19 csmartdalton@google.com Fix handling of dynamic state in GrAAFillRRectOp 2018-11-19 caryclark@skia.org fix pathops fuzzer timeout 2018-11-19 csmartdalton@google.com Add a dedicated Op for analytic round rects 2018-11-19 caryclark@skia.org font doc Created with: gclient setdep -r src/third_party/skia@a63cf8e80aa5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:906360,chromium:860021 TBR=csmartdalton@chromium.org Change-Id: I3c1331d3b9337150cdbf5a8e4d01a679231b2a6d Reviewed-on: https://chromium-review.googlesource.com/c/1343180Reviewed-by:
-
Noel Gordon authored
- use let and const and add doc comment annotations. - update LoadTimeData fake to include DRIVE_OFFLINE_COLLECTION_LABEL and DRIVE_SHARED_WITH_ME_COLLECTION_LABEL to avoid JS exceptions about them being missing / undefined when running the unittest. - rm duplicate NOT_MOUNTED_SINGLE_PROVIDING_EXTENSION definition. - use VolumeManagerCommon.Source types rather than bare strings. - create & install mock chrome.fileManagerPrivate. - create & install mock VolumeManager. - run JS formatter over the code. Bug: 905933 Change-Id: I7dabbb8ff72f79d290eaeffcb941280715f93660 Reviewed-on: https://chromium-review.googlesource.com/c/1343397 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609487}
-
