- 13 Jul, 2018 40 commits
-
-
Kim Paulhamus authored
TBR: ellyjones@chromium.org Bug: 863296 Change-Id: Idf257bcc95b35aceaaa2288f50d6f7cc9cf72f12 Reviewed-on: https://chromium-review.googlesource.com/1136719Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#574970}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/754b096de220..a738c2067f78 git log 754b096de220..a738c2067f78 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 wangge@google.com Added python script for download chrome for major milestones Created with: gclient setdep -r src/third_party/catapult@a738c2067f78 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ifd0442fe0c5e01381084b89fb2e808c1336f8a33 Reviewed-on: https://chromium-review.googlesource.com/1136397Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574969}
-
Aga Wronska authored
This allows for easier customization and showing of network dialog from different parts of OOBE flow. The corresponding OOBE screen will be added in a following change. Bug: 862445 Test: manually Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ibdf039d1b0b43bb704b3f4daf3f8cb2d0b0eff40 Reviewed-on: https://chromium-review.googlesource.com/1132552Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#574968}
-
erikchen authored
Change-Id: Ia38e827130b7cbb553a3954c5b5df58f506a7e70 Reviewed-on: https://chromium-review.googlesource.com/1136515Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574967}
-
Nick Burris authored
Follow-up to http://go/chromium-review/1135194 - extension_names() was unintuitive as it was not filled until FetchExtensionNames was called. Instead, FetchExtensionNames now takes a set to fill with extension names using the given profile. - Forward extension names to UI by calling FetchExtensionNames in chrome_cleanup_handler. This completes the CLs adding extension IDs to the cleaner page, which I've confirmed by having a local cleaner build report extension IDs and confirmed that their names appear in the items list. Bug: 853339 Change-Id: I8d0c34fabb6c261c7e9b48c82a59a8fdb139674c Reviewed-on: https://chromium-review.googlesource.com/1135121Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Nick Burris <nburris@google.com> Cr-Commit-Position: refs/heads/master@{#574966}
-
Greg Kraynov authored
It was missed from BUILD.gn during the move from //cc. Three tests are broken and were disabled, see bug for details. Bug: 863422 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I83381ee2063b3c826a9923db98a5802eb6130db2 Reviewed-on: https://chromium-review.googlesource.com/1136548Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#574965}
-
Sammie Quon authored
Currently if the bubble is open, you cannot focus the items in the bubble using the keyboard. Also, if there are for example 4 items in the bubble and the bubble is closed, you have to tab 4 times to get from the last item on the main shelf to the first item. This cl makes the overflow bubble activatable, and focuses it when the index is out of visible bounds on the main shelf. The main shelf regains focus when the index is out of visible bounds on the overflow shelf. This cl also fixes when the overflow bubble is closed, there will not be need to press tab extra to loop back to the beginning. Test: add tests Bug: 854313 Change-Id: Ib36939952488ae23300062300bdc43a7b2a1e5fc Reviewed-on: https://chromium-review.googlesource.com/1125317Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#574964}
-
Christian Fremerey authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1120856 This CL is a pure refactoring and has no intended function change. This CL is part of a series, see Design Doc at https://docs.google.com/document/d/1ihGDZloUGdDpZ5XfmiI3AcqsSxOP9kOe5GxXOTqpHW4/edit?usp=sharing Test: capture_unittests with physical camera attached Bug: 768887 Change-Id: Ia9bb5c832066d43d3a2295e9a6c97a31ebc266ed Reviewed-on: https://chromium-review.googlesource.com/1121239Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#574963}
-
proberge authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1133300 I changed how the padding of settings_toggle_button is calculated. This caused some issues in cases where clicking the row creates a button whose height is greater than the text's height, causing the entire row to expand vertically. This change applies the padding modifications to the text label instead of the entire outerRow, preventing the padding from applying based on the button's height instead of the text height. Bug: 862916 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I489f8e38d022452e448ab452def29ca02aa0a1cb Reviewed-on: https://chromium-review.googlesource.com/1135594 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#574962}
-
glevin authored
As per crbug.com/788024 Comment 10 and other observations: - Make error text darker (#D93025) - Dialog width = 448 (for reals this time) - Remove X (Close) button from upper right Bug: 788024 Test: Get yourself into some kinda pin-needin' situation and confirm the Harmonious nature of the pin-requestin' dialog. Change-Id: I7da3bffa3ff91434f651dd316a245cdf8d3f91a1 Reviewed-on: https://chromium-review.googlesource.com/1118609Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574961}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d8df8c35a463..3a83fe5cf6cf git log d8df8c35a463..3a83fe5cf6cf --date=short --no-merges --format='%ad %ae %s' 2018-07-13 thestig@chromium.org Fix FPDF_ImportNPagesToOne() documentation. Created with: gclient setdep -r src/third_party/pdfium@3a83fe5cf6cf The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I78b31f5a0bffca9600b7733c90bf1f5d8d430347 Reviewed-on: https://chromium-review.googlesource.com/1136396Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574960}
-
David Black authored
Deep link launches Chrome OS feedback. Known issues: - Feedback UI launches behind Assistant UI. - Feedback does not attach Assistant server logs. See bug for demo. Bug: b:111222894 Change-Id: I6424cfdf633c1dfdfec1e91663259c2c04d810b5 Reviewed-on: https://chromium-review.googlesource.com/1134470 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#574959}
-
Johann authored
https://aomedia.googlesource.com/aom.git/+log/1c2430a2e13a..6eecfe927de9 $ git log 1c2430a2e..6eecfe927 --date=short --no-merges --format='%ad %ae %s' 2018-07-09 ddvfinite Add obmc add avx2 code 2018-07-12 debargha Fix build for CONFIG_COLLECT_RD_STATS option 2018-07-12 debargha Ensure rd_stats skip flag is set only if rate = 0 2018-07-10 weitinglin Adjust parameters of the customized GF structure 2018-07-10 weitinglin Add a new backward reference update rule 2018-07-10 weitinglin Replacing BWDREFs with ARFs (for GF=4 only) 2018-07-02 weitinglin Allow to fix the length of GF group. 2018-07-12 wtc Delete an obsolete TODO comment. 2018-07-11 kylesiefring x86 Jnt Subpel Variance: Handle Loads Correctly 2018-07-02 weitinglin Remove the dependency of using refresh_alt2_ref for rdctrl 2018-06-27 weitinglin Refactor: Clear the logic of buffer updates 2018-06-29 yunqingwang Add automated lightfield testing 2018-07-10 deepa.kg Move the setjmp into a function by itself 2018-07-09 debargha Fix sse computation for frame edge blocks 2018-07-09 debargha Use dist/sse_norm inst. of variance in nn-rd model 2018-07-11 wtc Clear cm->width and cm->height on alloc failure. 2018-07-11 tomfinegan rtcd.pl: Simplify parse of aom_config.h. 2018-07-09 yunqingwang Refactor read_and_decode_one_tile_list() 2018-07-09 yunqingwang Advance the image iterator correctly 2018-07-11 debargha Handle rd model for high-bitdepth correctly (...) Created with: roll-dep src/third_party/libaom/source/libaom Change-Id: I7403f9bc352afecd5988011642e8c939567cce51 Reviewed-on: https://chromium-review.googlesource.com/1136577Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#574958}
-
Aldo Culquicondor authored
VR input devices behave like laser pointers, leading to movements with lower precision as opposed to a mouse or a touchpad, due to natural shakiness of users. This change increases the slop when on VR browsing, as a factor of the platform's slop. Bug: 860321 Change-Id: I47906921ab41e69b7bc4e427ebbd327ae8f7d9bf Reviewed-on: https://chromium-review.googlesource.com/1134088 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#574957}
-
Wez authored
Bug: 844016 Change-Id: I5b4a92b25ae7f02c3d298241f283345a4ac58b4e Reviewed-on: https://chromium-review.googlesource.com/1136657Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#574956}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4a17501f5bbd..7651c1611e6c git log 4a17501f5bbd..7651c1611e6c --date=short --no-merges --format='%ad %ae %s' 2018-07-13 caryclark@skia.org refresh generated includes 2018-07-13 caryclark@skia.org fix bookmaker Created with: gclient setdep -r src/third_party/skia@7651c1611e6c The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Id9e88aa43427f7ec3e730192f9f30d7be3cba193 Reviewed-on: https://chromium-review.googlesource.com/1136394Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574955}
-
Xiangjun Zhang authored
This CL adds the implementation to check the preference of enabling/disabling media remoting. The remoting dialog is only shown when user has not set the preference. The preference can be set through the remoting dialog. Though this CL doesn't clear the preference once it is set. This will be done in a later CL. Bug: 849020 Change-Id: I89c4ed6b71a2e51bd81fae919531d15b53664b18 Reviewed-on: https://chromium-review.googlesource.com/1125355 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#574954}
-
Jialiu Lin authored
Google login page allows users to input their Gmail prefix or input the full gmail email address for sign-in. For example, user's gmail is user@gmail.com, then on https://accounts.google.com..., typing "user" or "user@gmail.com" as username have the same effect. However, current HashPasswordManager treats them as two separate accounts when saving password hashes. This CL improves the canonicalization of username by appending "@gmail.com" to PasswordHashData.username if it is a Gmail email prefix. Note that Dasher account always require full email as username. Bug: 858865 Change-Id: I9ddf23f54ee67bd73bd754953a3b80758e062ef3 Reviewed-on: https://chromium-review.googlesource.com/1135906Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#574953}
-
Tom Anderson authored
bootstrap.py does not exist in the gn.googlesource.com repo. The script gen/build.py is used instead. However, there are some differences to bootstrap.py: one obvious one is the name and location. This breaks chromium packagers relying on bootstrap.py, so this change adds the script back. In the long-term, it should forward to gen.py. BUG=859536,863459,863460 Change-Id: I59ff81acb7f409d1975f99bcf0676e6103b2d7b9 Reviewed-on: https://chromium-review.googlesource.com/1136656 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574952}
-
Robert Sesek authored
In Mojave, apps should provide a reason string that will be shown in the OS-mediated permission prompt for protected resources (e.g., camera, microphone, location). This adds the reason string and places it in the InfoPlist.strings files. Bug: 850175 Change-Id: I1b5c250aa50a2b4086e95c34521a82fae2405ea1 Reviewed-on: https://chromium-review.googlesource.com/1135114Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#574951}
-
Sammie Quon authored
Test: manual Bug: 833443 Change-Id: Iaf64e0c4edea2ae444d6d55a6103f922c5f33ffb Reviewed-on: https://chromium-review.googlesource.com/1132476 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#574950}
-
Majid Valipour authored
Formalize the concept of local time and use it internally where we would have done a one-off calculations before. In this process I noticed and documented issues how pause time is being applied. In particular pause time incorrectly include offset_time_ and excludes total_paused_duration_. I suspect these issues flew under the radar mainly because pausing is only ever used for simple test cases not involving animations with start delays or multiple pause/unpause cycles. I plan to fix this issues in a follow up patch. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I02030dbd5ef0656b2738353a6e468b81c9b259a8 Reviewed-on: https://chromium-review.googlesource.com/1037635 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#574949}
-
Justin Cohen authored
As opposed to sharding between swarming bots, sharding within a swarming bot seems to be broken over 50% of the time, and is causing flake. Since when this type of sharding fails, it re-runs without sharding, disabling sharding here shouldn't increase cycle time. Change-Id: I80dc3b6360dc829fc34e9f3f35247c70b10642ee Reviewed-on: https://chromium-review.googlesource.com/1136636Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#574948}
-
David Tseng authored
This makes it so we don't: - report text edit events while touch exploring other items on the screen - don't go into gestures for editable text while exploring elsewhere Test: manual Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ifc5c9256dc71e7a65d929d2b53a7cde28bd2ec0b Reviewed-on: https://chromium-review.googlesource.com/1135993Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#574947}
-
Moe Ahmadi authored
It allows using WaitUntilConditionOrTimeout in the iOS components code Bug: 784735 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie370a3562c6774a24b0faa4838d05da3f379c201 Reviewed-on: https://chromium-review.googlesource.com/1132301 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#574946}
-
Henrik Boström authored
WebRTCRtpTransceiver added for surfacing transceivers in future CLs. Implementation added in content and test coverage added. The content::RTCRtpTransceiver is implemented with a similar design as content::RTCRtp[Sender/Receiver]: - It has an "internal" ref counted class, allowing multiple WebRTCRtpTransceivers to represent the same webrtc layer transceiver. - The "state" is in a separate class, allowing surfacing transceiver state information separately from implementation, and use of TransceiverStateSurfacer. Stop(), blink-layer RTCRtpTransceiver and Unified Plan usage will be added in follow-up CLs. This CL also removes all dependencies on webrtc_media_stream_adapter_map.[h/cc] unblocking its deletion. Bug: 777617 Change-Id: Icbc4a6b53ef57df8da6bc10e9e432644368ba5dd Reviewed-on: https://chromium-review.googlesource.com/1131475Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#574945}
-
James Darpinian authored
SubprocessMetricsProviderTest.SnapshotMetrics has been flaky for a while but it is suddenly much worse now and I don't see an obvious culprit. Disabling until someone can investigate. Tbr: asvitkine@chromium.org Bug: 863262 Change-Id: I33d62b866c00f7fd9386cb274773547a3815bb20 Reviewed-on: https://chromium-review.googlesource.com/1136051 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#574944}
-
Wez authored
This ensures deterministic failure if the setsockopt() implementation tries to make use of otherwise uninitialized fields. Bug: 862189 Change-Id: I0be1dd6c9b830babf0911dc0d78910a20cbd0813 Reviewed-on: https://chromium-review.googlesource.com/1136374Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#574943}
-
Kim Paulhamus authored
TBR: jam@chromium.org Bug: 863166 Change-Id: I9e31154c0ba8cdc5fff7af5130c8a06029a4bdaa Reviewed-on: https://chromium-review.googlesource.com/1136029 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#574942}
-
Torne (Richard Coles) authored
Returning in a finally block causes exceptions to be discarded. There's no reason to log a UMA stat for the performance of a startup that threw an exception (since we're going to crash the app anyway), so just take it entirely outside the finally block and invert the condition to only record the UMA stat if mFactory.hasStarted(). Also adjust another place that had the same pattern without the "return" to match, as again there's no need to log the UMA stat when there's an exception. Bug: 862662 Change-Id: Ie6d24cee5bb9342016c364244256c8b73a8184f7 Reviewed-on: https://chromium-review.googlesource.com/1133332 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#574941}
-
Alexander Timin authored
Add Scheduler.Experimental.Renderer.CPUTimePerThreadType.{Tracked,NonTracked} histograms to measure and report cpu time not captured by the scheduler. BUG=852314 R=rkaplow@chromium.org,alexclarke@chromium.org TBR=gab@chromium.org Change-Id: I4ebdb22fac455ee1887abdc3b739162a970aa900 Reviewed-on: https://chromium-review.googlesource.com/1133258Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#574940}
-
Luciano Pacheco authored
This CL reverses the value of the feature flag to mean enabled, and fixes all tests to pass with the new My Files on navigation menu. Change MyFiles tests to not append the flag anymore, because when the flag is provided it now disables "My Files" :) Fix navigation_list_model_unittest.js to pass flag true/false on NavigationListModel with the desired flag state. Stop calling "notifyEntriesChanged" on DirectoryTree.updateSharedStatusIcon, because this causes the cache invalidation, which was causing some metadata model to be invalidated before being displayed on file list, in particular the modificationTime column on file list. crbug.com/857343 tracks further investigation if this call was really still needed. Change folder_shortcuts.js to account to new My Files on directory tree, because it changes the keyboard shortcut to select top-level directories. Also fix and improve some comments. Change tab_index.js to account to My Files on breadcrumbs being focused during tab cycle. This requires adding an id on breadcrumbs. Bug: 857335, 862897 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iddb2545772e62c0e8adebd8b278bd3a5765f5040 Reviewed-on: https://chromium-review.googlesource.com/1131025Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#574939}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/47b0a995..0551e649 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib4888827f33c1d973045f5fd57f9f1783447fbb0 Reviewed-on: https://chromium-review.googlesource.com/1136382Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574938}
-
Kinuko Yasuda authored
This patch makes the ResourceLoadScheduler show a console message on receiving a network request when running requests reach to the limit. This will help users to understand what is happening around the background tab throttling. Change from the original change (crrev.com/c/1057969): - Rebase - Not to show the message for kStopped (i.e. when a frame is paused) The latter can be added when the owners of frame-pausing/stopping want to add that later. Bug: 837771 Change-Id: Ie17bb21a7172d2108d9cd10c4f3bde8b066b6fdb Reviewed-on: https://chromium-review.googlesource.com/1136167 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#574937}
-
Bo authored
This reverts commit f4924c30. Reason for revert: Done with experiment. Original change's description: > android: Disable binding mangement for site isolation > > This is a speculative experiment (since it's a simple change) to see if > it has any effect on the rate of sad tabs when site isolation is > enabled. > > This should be reverted before M69 branch point, and definitely before > site isolation actually ships to beta. > > Bug: 855037 > Bug: 859208 > Change-Id: I90c7cce4a03603d8bd9772ead804eeabb4114bad > Reviewed-on: https://chromium-review.googlesource.com/1120864 > Commit-Queue: Bo <boliu@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571660} TBR=boliu@chromium.org,alexmos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 855037, 859208 Change-Id: I70917a54a7f3a4c02baa95ddba5016ce7c8948ad Reviewed-on: https://chromium-review.googlesource.com/1136611Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#574936}
-
Javier Ernesto Flores Robles authored
Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibe6443cfdb658cce9caf351171f2c23cbff492ed Reviewed-on: https://chromium-review.googlesource.com/1136634Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#574935}
-
Samuel Huang authored
concurrent.BulkForkAndCall(func, arg_tuples) calls |func()| with arguments given by |arg_tuples|, which stores arguments over independent forked calls as a list of tuples. Previously this requires common parameters (e.g., tool_prefix) to be present in each tuple, and decreases flexibility for |arg_tuples| preparation code. This CL adds |kwargs| parameter to BulkForkAndCall(), thereby allowing common parameters to be given once. As seen in the test changes, a minor caveat is that |func()| will need to make common parameters appear at end of argument list. Bug: 723798 Change-Id: I9aa91b6081b8fe8fa9c87a9ae1cb959d3f17e9df Reviewed-on: https://chromium-review.googlesource.com/1135204 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#574934}
-
Fernando Serboncini authored
TBR=drott@chromium.org Change-Id: I9c026944acad5c4783bbed7dcbea262479fbd707 Reviewed-on: https://chromium-review.googlesource.com/1136388 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#574933}
-
Greg Kraynov authored
Bug: 863350 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I7f4ade68fd7d504d06f276660e66ee7c01f20806 Reviewed-on: https://chromium-review.googlesource.com/1136549Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#574932}
-
Sandra Sun authored
This reverts commit 043b97ce. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "Correctly initialize and test SnapContainerData in cc." > > This reverts commit 0fc70abb. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "Correctly initialize and test SnapContainerData in cc." > > > > This reverts commit 37061f87. > > > > Reason for revert: > > The layout tests added by this CL is failing on the CL: > > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804 > > > > Original change's description: > > > Correctly initialize and test SnapContainerData in cc. > > > > > > This patch initializes the rect_ field in SnapContainerData in copy > > > constructor and move constructor. Fixing a snapping issue in the > > > composited pages. > > > > > > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded > > > test suite so that they are tested with the composited cases. > > > > > > snap-at-user-scroll-end-manual-automation.js calls > > > mouseClickInTarget() of pointerevent_common_input.js. That method > > > invokes programmatic scrolls. The test was written before programmatic > > > scroll snapping was implemented so it worked at that time. However, > > > with programmatic scroll snapping implemented, it will always snap > > > in mouseClickIntarget() and cannot test whether the user scroll snaps. > > > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget > > > to avoid invoking programmatic scrolls in the test. > > > > > > This patch also checks nullptr for layout_box in > > > ScrollManager::SnapAtGestureScrollEnd() to fix a crash. > > > > > > Bug: 862406, 862571 > > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > > > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e > > > Reviewed-on: https://chromium-review.googlesource.com/1132386 > > > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > > > Reviewed-by: Majid Valipour <majidvp@chromium.org> > > > Reviewed-by: Robert Flack <flackr@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#574781} > > > > TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org > > > > Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 862406, 862571 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > > Reviewed-on: https://chromium-review.googlesource.com/1136171 > > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#574825} > > TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,tzik@chromium.org > > Change-Id: I4a9480b68c15e0dfcfd13df6ed6c0e6b8ab5a8e3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 862406, 862571 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1136671 > Reviewed-by: Sandra Sun <sunyunjia@chromium.org> > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574926} TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,tzik@chromium.org Change-Id: If9d1e6f73393a7dddc9f8f418606946f070b45be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862406, 862571 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1136612Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#574931}
-