GitLab

Before TrayBluetoothHelper would get notified of any changes to devices.
This caused problems in busy environments because TrayBluetoothHelper
would get notified hundreds or even thousands of times per second of
devices changes.

This CL changes to a "pull" pattern where TrayBluetootHelper queries
for devices every second. The devices are then cached so that clients
of TrayBluetoothHelper can access them synchronously.

TrayBluetoothHelper queries for devices as long as the state is
kPoweredOn. If the state changes, the device list is cleared.

Bug: 882346

TEST=The following actions should be performed:

1. Turn bluetooth on and off in system tray.
2. Open device list in system menu.
3. Connect to a device.
4. See that the pod feature button in the system tray indicates a
   device is connected when connected to a device.

Change-Id: Id9028546a627f260527aa737f51c032f74a447ec
Reviewed-on: https://chromium-review.googlesource.com/c/1347638
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611069}

The old scrolling scrolled the entire footer; since the
progress-center-open-view is always present, but below the fold, this
allowed the progress-center-open-view to be scrolled off the top of the
footer element. Avoid this by only allowing scrolling on the
progress-center-open-view element. Additionally, restrict its height to
40% of the window so the directory tree can remain usable while the
progress center is expanded.

Slightly improve the position of notification dismiss buttons: align
them to flex-start instead of flex-end and use display: none for the
cancel button when hidden.

Bug: 627371
No-try: true
Change-Id: I2180eb8382c37c1fc03ec32b4894f449f4c7a681
Reviewed-on: https://chromium-review.googlesource.com/c/1351202
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611068}

This cl changes when training should start.
1. Previously, training will only start after user has been inactive for a
certain amount of time (the training delay), and also if there are at least
certain number of training points. A training point is created when a user
makes a brightness adjustment.

2. Now, training can still be delayed, but if the delay is 0, we will start
training immediately after a training point is received. We no longer need
to accumulate data points before training.
- We run the training job and also disk-writing job (for writing trained curves)
in a non-UI thread, hence it's non-blocking.

Bug: 881215
Change-Id: Ifcb0714bd74d278722d1c718f57ca82dd16aed1b
Reviewed-on: https://chromium-review.googlesource.com/c/1350020Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611067}

Everything is first clamped to [INT_MIN, INT_MAX]. Then, if the value is
negative, it will be negated to become positive. This won't work if the
value is exactly INT_MIN, though, since INT_MIN (MSB set to 1; all other
bits set to 0) has no positive counterpart. So handle this manually.

Adding a non-exportable web test for this, since the behavior for such
numbers is only defined between -9999 and 9999 [1].

[1] https://www.w3.org/TR/css-counter-styles-3/#complex-cjk

Bug: 893954
Change-Id: I9f3bfad6e73623c27f2e1e427a96c45ad81d6265
Reviewed-on: https://chromium-review.googlesource.com/c/1350949Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611066}

 - update the comments to match what the actually code does
 - check progress center item state like other unittests do

No change in test behavior.

Bug: 907964
Tbr: slangley
No-try: true
Change-Id: I8f307b699d5005cbdefe346d838088610c9f88cf
Reviewed-on: https://chromium-review.googlesource.com/c/1352072Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611065}

ArcVideoEncoder has two patterns to encode:
1.) I420 buffer (OMX_COLOR_FormatYUV420Planar)
2.) several formats, including YV12, NV12, ARGB (OMX_COLOR_FormatAndroidOpaque)
In the latter case, no detail about pixel format of video frame to be encoded is
provided in initialization. We always configure I420 in initializing and perform
pixel format conversion in ArcVideoEncoder using libyuv.

One of the most common encoder use case is video capture. It is the latter case.
The pixel format of video frame is dependent on platform, YV12 on mediatek
devices, and NV12 on others. Furtheremore, video frame is provided as DmaBuf. If
no pixel format conversion is done anywhere, we can pass video frame to VDA as
DmaBuf without any mapping.

Our design is we configure flexible format on Initialize() if
OMX_COLOR_FormatAndroidOpaque is configured in ArcVideoEncoder. Thereafter, if
the different pixel format is provided on Encode(), we convert pixel format on
GpuArcVEA. We can have a chance to use Image Processor with HW Acceleration like
V4L2 Image Processor.

This is the first step for this task, attach format information on Encode() and
split GpuArcVideoEncoder::Encode() to EncodeSharedMemory() (I420 case) and
EncodeDmabuf() (Flexible format case). EncodeDmaBuf() is not implemented yet.

BUG=chromium:895230, b:118544836
TEST=CtsMediaTestCases

Change-Id: Ia12447b93f71fb2af579a9e27a1055b43e81cc2a
Reviewed-on: https://chromium-review.googlesource.com/c/1343593
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611064}

Convert S* class allocations from new to MakeGarbageCollected

Bug: 757708
Change-Id: I20c9b11fdfb83621083bda1d3434ba23679e0a5a
Reviewed-on: https://chromium-review.googlesource.com/c/1351196Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611063}

Remove a few whitelist entries for the "Windows deterministic" and "Deterministic Linux (dbg)" bots.

These are no longer nondeterministic following
https://chromium-review.googlesource.com/c/chromium/src/+/1351492

Bug: 899438
Change-Id: I2f72531111fdc62c340032df610fcd256e524504
Reviewed-on: https://chromium-review.googlesource.com/c/1351721
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611062}

:dev suffixed features will only be available if the device is
userdebug. This makes it possible to develop support library changes in
multiple steps, and then expose the feature with a final CL that removes
the suffix, without running the risk that applications will
inadvertently release code depending on the behaviour of an in-progress
implementation of a feature.

Bug: 908648
Change-Id: Iae98386992eb113356cf74be3eda125af10d867a
Reviewed-on: https://chromium-review.googlesource.com/c/1349327
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611061}

https://dawn.googlesource.com/dawn.git/+log/63997221d7d8..0da9494a4fe9

$ git log 63997221d..0da9494a4 --date=short --no-merges --format='%ad %ae %s'
2018-11-21 cwallez Run mac-dawn-rel on the CQ
2018-11-21 cwallez Suppress failing tests on Metal Intel.
2018-11-21 cwallez CommandBuffer/PassEncoders: Correctly validate we can record
2018-11-21 cwallez BindGroupLayout: Fix off-by-one kMaxBindingsPerGroup validation
2018-11-21 jiawei.shao Fix missing validations and Vulkan flags on cube map texture views

Created with:
  roll-dep src/third_party/dawn

TBR=kainino@chromium.org

Change-Id: Icfa9db045ccb1eac01da1ab4b84aae3cb0a97f22
Reviewed-on: https://chromium-review.googlesource.com/c/1350918Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611060}

According to our perf test on linux this shaves off ~0.1 us/task or
about 10% of our current overhead.

Bug: 897751
Change-Id: I79d6cf6bacd2b62be68b7ee028bf6749bec1ff57
Reviewed-on: https://chromium-review.googlesource.com/c/1348097
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611059}

Change the soon to be deprecated API calls to use the alternate
non-deprecated versions in set_icon_natives.cc

Bug: v8:8238
Change-Id: I5b2365fe09bb89dcce5a52979823faee141c5070
Reviewed-on: https://chromium-review.googlesource.com/c/1349696Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611058}

https://pdfium.googlesource.com/pdfium.git/+log/cf927b1f0823..b4c95fe2ded4


git log cf927b1f0823..b4c95fe2ded4 --date=short --no-merges --format='%ad %ae %s'
2018-11-27 tsepez@chromium.org Rename WideString::{UTF8,UTF16LE}_Encode() to To{UTF8,UTF16LE}().
2018-11-27 tsepez@chromium.org Rename WideString::FromLocal() to FromDefANSI().
2018-11-27 tsepez@chromium.org XFA: Do not use UnownedPtr between CXFA_Nodes.
2018-11-27 tsepez@chromium.org Use checked downcasts between CFXA_LayoutItem and CXFA_FFWidget.
2018-11-26 tsepez@chromium.org Break circular dependence between {Byte,Wide}String


Created with:
  gclient setdep -r src/third_party/pdfium@b4c95fe2ded4

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:907427,chromium:907430
TBR=dsinclair@chromium.org

Change-Id: I25a82288ee6ebf33c7fad0e1688c1d416bb8dbff
Reviewed-on: https://chromium-review.googlesource.com/c/1351883Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611057}

This CL implements support for specifying a default value for
font-display for @font-face rules which do not provide a font-display
descriptor. See spec [1]. The implementation is currently behind a flag
which is off by default (not tested, not in experimental).

For intent-to-implement, see [4].

There is a question if we should mix descriptors with @-rules in
@font-feature-values because an unrecognized descriptor would be seen as
part of the following rule as the start of a qualified ruled which means
forward-compatibility could break. Also, there is a question if this is a
font feature value and should be added to that @-rule at all. Both these
issue are discussed/mentioned in [2].

Since using a descriptor directly in @font-feature values is not
compatible with Gecko, we're wrapping the font-display descriptor in a
block with no prelude for now.

Note that the default font-display cannot currently apply to fonts loaded
by FontFace.load() because the dictionary passed to FontFace have default
values which effectively overrides any @font-feature-values
descriptors[3].


[1] https://drafts.csswg.org/css-fonts-4/#font-display-font-feature-values
[2] https://github.com/w3c/csswg-drafts/issues/2973
[3] https://github.com/w3c/csswg-drafts/issues/3188
[4] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/C6taiCkYayU

Bug: 777846

Change-Id: I290f23e7489afeef64812d7604417268c2464455
Reviewed-on: https://chromium-review.googlesource.com/c/1222966Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611056}

- In web_tests, we mapped the keyword "file:///tmp/LayoutTests/" to
  the actual web_tests directory.  This CL updates the keyword to
  "file:///tmp/web_tests".

- In image decoder tests, we mapped the keyword "LayoutTests/" to
  the actual web_tests directory.  This CL updates the keyword to
  "web_tests/".

Bug: 843412
Change-Id: I6f4ef498a9052a701aa2211a180d87781f45d8dc
Reviewed-on: https://chromium-review.googlesource.com/c/1351195Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611055}

Parallel requests are initiated when an intent is dispatched to a CustomTabs
activity. At that point, native is not guaranteed to be initialized, but the
request needs the browser to be initialized, not merely the native library to be
loaded. In this case, delay the call until this condition is fullfilled.

To that end, add a delayed task mechanism to ChromeBrowserInitializer. Add tests
to this class, and while in the neighborhood, convert Runnable to lambdas.

Note that this is not exposed to clients yet, as enabling the feature still
requires the browser to be initialized. This first CL introduces the mechanism
and ensures that existing behavior is preserved.

Bug: 901835
Change-Id: I184e1da5ae974458d19f6a88a3f26ba6c443cb57
Reviewed-on: https://chromium-review.googlesource.com/c/1349227Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611054}

Since BooleanValue cannot actually throw, the Maybe version of the
function is now deprecated.

Bug: v8:7279, v8:8238
Change-Id: Ic7fc9ff21d4cee2fe65de19cb800e76bce3d10bf
Reviewed-on: https://chromium-review.googlesource.com/c/1350916Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611053}

Use MaybeLocal version of GetFunction in SandboxStatusExtension as
original function is deprecated. Since the original code DCHECKs that
other failure can't happen, I've used the same pattern rather than
ToLocalChecked.

Bug: v8:7295, v8:8238
Change-Id: I29178794660dc7c5cf6d6bba0c617dfbbb37757d
Reviewed-on: https://chromium-review.googlesource.com/c/1348047Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611052}

The test currently passes by accident: it fails to check that a metric
has a value.

It also has two issues: one is mixing null and non-null drivers, and
the other is calling old-parser-only ProvisionallySavePassword instead
of OnPasswordFormSubmitted, while at the same time using the new
parser.

This CL fixes the test:
* Activates the check, and
* Fixes the issues, so that the test passes.

Bug: 907794
Change-Id: Ia24518aa2bae3c0a25db7722c89eb59f70c61ef1
Reviewed-on: https://chromium-review.googlesource.com/c/1350898
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611051}

This CL creates the AutofillEditItem to replace the
LegacyAutofillEditItem in UITableView.
The support for Dynamic Type will be done later to keep this close to
the legacy implementation.

Bug: 894791
Change-Id: I9e0e9ab81498dbafe5357487a7249f23c7620df5
Reviewed-on: https://chromium-review.googlesource.com/c/1344062Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611050}

Fix error message by making it a proper sentence.

Bug: 803774
Change-Id: I30feb2f5b9aa92653793db92556aaf29371673ec
Reviewed-on: https://chromium-review.googlesource.com/c/1350962Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#611049}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/344c43de..483d8219

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

Passing a NOTRY because the mac_chromium_rel_ng and mac_optional_gpu_tests_rel
bots experience an infra failure, see https://crbug.com/908729.
All the others are green.

NOTRY=true

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I330e6614a7d71247b3ee3bb16166209400a72bcb
Reviewed-on: https://chromium-review.googlesource.com/c/1351797
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611048}

Bug: 806868
Change-Id: I69bdb935ea8029e64fa05172762262e2167659ec
Reviewed-on: https://chromium-review.googlesource.com/c/1347280Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611047}

Bug: v8:7281
Change-Id: I51a26bd0d91e70abb77f5179b8b90aaff69b4a41
Reviewed-on: https://chromium-review.googlesource.com/c/1349343Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611046}

There are two tests that test this, but they are currently failing
in Legacy too.
virtual/android/url-bar/bottom-and-top-fixed-sticks-to-top.html
virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html

I've confirment manually that position:fixed, bottom:0 Elements
stick to bottom on scrolling.

There is one remaining problem.
While scrolling is active, position:fixed, bottom:0 element does
not stick to the bottom of the viewport. It gets positioned correctly
after scrolling stops. Bug #906516

Bug: 870008
Change-Id: Ibe597141869794978865809caa3991cd4c2bd8a6
Reviewed-on: https://chromium-review.googlesource.com/c/1341127
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611045}

Move away from OAuth2TokenService and SigninManagerBase by implementing
IdentityManager::Observer and using Identity Service's APIs only (i.e.
IdentityManager, PrimaryAccessTokenFetcher).

Bug: 905689
Change-Id: I68e971ddf8a23987abfdadb8e2daf7b17a4a6ddb
Reviewed-on: https://chromium-review.googlesource.com/c/1340315Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#611044}

Experiment discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hE2B1iItPDk

Bug: 908272
Change-Id: I97a5d26996469d33b75afa4babf40e54eb830e6a
Reviewed-on: https://chromium-review.googlesource.com/c/1350174
Commit-Queue: Ruslan Burakov <kuddai@google.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611043}

Introduce blink::WritableStream which is a ScriptWrappable.

There are some compatibility issues:
 - Function lengths (e.g., WritableStream.prototype.abort.length)
   change.
   (external/wpt/streams/writable-streams/properties*)
 - attribute @@toStringTag is added to ReadableStream and
   TransformStream. (*global-interface-listing*)

Bug: 894357, 888165, 902633
Change-Id: I93762fec72a4654759a7fbe4e80b4704befac2c3
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1337220
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611042}

GWP-ASan is a debug allocator intended to find memory errors in the
wild. In order to detect as many as bugs as possible, it should start as
early as possible, e.g. soon after it's dependency, FeatureList, has
been initialized. Since content/ doesn't call into ChromeMainDelegate
for child processes after FeatureList has been initialized, create a new
delegate method for post-FeatureList initialization and enable GWP-ASan
at that point.

Bug: 896019
Change-Id: I9c081602cd32a71d5d9eb774bd9818757d9b7e95
Reviewed-on: https://chromium-review.googlesource.com/c/1343347Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611041}

Don't run dirRenameWithoutChangingCurrent with MyFilesVolume flag, since
it was flaky crbug.com/908352.

Add RootPaths.DOWNLOADS_PATH which sets the full path to Downloads
folder: "" when MyFilesVolume is disabled, which means Downloads is the
root; "/Downloads" when MyFilesVolume is enabled, which means that
Downloads it's a folder at root.

Change tests that uses entry.fullPath to prefix with
RootPaths.DOWNLOADS_PATH so the tests passes with/without the flag
MyFilesVolume.

Enable some tests to run with flag MyFilesVolumeEnabled which were
failing before this CL.

NOTE: RootPaths.DOWNLOADS_PATH will be removed and the full path with
/Downloads will be in-lined when MyFiles as Volume is fully rolled out.

--gtest_filter="DirectoryTreeContextMenu/FilesAppBrowserTest*"
--gtest_filter="CreateNewFolder/FilesAppBrowserTest*"

Test: browser_tests
Bug: 873539, 908352
Change-Id: Iaac6c8bd51c2bc8dc31e1c395f2f74d8533f4f9c
No-try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1351341
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611040}

Checking for values in UKM metrics is a lot of boilerplate in the
password manager unittest, so this CL adds two helper methods for
brevity.

Bug: 907794
Change-Id: Iecf86eb564f9f0f239e7b337725a9666f59d56d4
Reviewed-on: https://chromium-review.googlesource.com/c/1350959
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611039}

Add helper to count the number of items on the MockProgressCenter. Use
it in drive_sync_handler_unittest as an example, to remove a shed-load
of closure compiler complaints about the following code:

   Object.keys(progressCenter.items)

Move that code into the MockProgressCenter helper: getItemCount(), and
the Closure compiler will be a happy koala.

No change in test behavior, no new tests.

Bug: 907964
No-try: true
Change-Id: I3da5fda8226a64a0cad27dcb57b84fac6c7a43be
Reviewed-on: https://chromium-review.googlesource.com/c/1351201
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611038}

Transient downloads shouldn't show up on download home and hence should
be filtered out.

Bug: 908670
Change-Id: Ic7ff12a36a7c46a6d7f7e63fe0faede8173488e1
Reviewed-on: https://chromium-review.googlesource.com/c/1351717Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611037}

With https://github.com/web-platform-tests/wpt/pull/14172 wpt streams
tests now use the standard *.any.js format for multi-platform tests. As
a result all the test filenames have changed and there are a large
number of obsolete *-expected.txt files left behind. Delete them.

Change-Id: Ia5ce3b89e3866745d19bd1d521c7fb731342e024
Reviewed-on: https://chromium-review.googlesource.com/c/1350552Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611036}

This fixes the GCC build after fdf95b6b ("CacheStorage: Refactor handle
ref-counting"):

    ../../content/browser/background_fetch/storage/match_requests_task.cc: In constructor ‘content::background_fetch::MatchRequestsTask::MatchRequestsTask(content::background_fetch::DatabaseTaskHost*, content::BackgroundFetchRegistrationId, std::unique_ptr<content::BackgroundFetchRequestMatchParams>, content::background_fetch::MatchRequestsTask::SettledFetchesCallback)’:
    ../../content/browser/background_fetch/storage/match_requests_task.cc:29:25: error: use of deleted function ‘content::CacheStorageRef<TargetType>::CacheStorageRef() [with TargetType = content::CacheStorageCache]’
           weak_factory_(this) {}
                             ^

With GCC, having that noexcept marker would require all members to be
marked with noexcept themselves (in this case, base::WeakPtr and its
hierarchy). While that could also be possible, the style guide only
explicitly mentions move constructors/assignment operators, and it is not
clear if having a noexcept default constructor brings any benefits.

clang is fine because we pass -fno-exceptions and it disables the same error
there, while GCC continues to raise it (bug 843143 and its corresponding CL
have a longer discussion on this issue).

Bug: 819294
Change-Id: I726cbc8d9e0d624c530a835373c0dbad32279b78
Reviewed-on: https://chromium-review.googlesource.com/c/1350954Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#611035}

Before this CL we didn't bundle WebRequestProxyingURLLoaderFactory
to the default URLLoaderFactory for service worker. This means that
fetches from service worker didn't go through webRequest extension
API when NetworkService is enabled. Bundle the factory so that
fetches from service worker go through extensions.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iabcc00674c8b62c9eae97e83f067d7a838a3d0fd
Bug: 897060
Reviewed-on: https://chromium-review.googlesource.com/c/1333173Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611034}

After a GWP-ASan exception occurs, a crash handler hook (e.g. a crashpad
UserStreamDataSource) is responsible for looking at the crash and
1) determining if the exception was related to GWP-ASan, and 2) adding
additional debug information to the minidump if so.

The crash handler hook determines if the exception was related to
GWP-ASan by finding the AllocatorState address (using a crash key),
reading the allocator state and seeing if the exception occurred in the
bounds of the allocator region. If it did, we extract debug information
about that allocation and report it in the minidump.

CQ-DEPEND=CL:1339246

Bug: 896019
Change-Id: I63d12b5137098b20ec946e3bddbdcabaf20e430a
Reviewed-on: https://chromium-review.googlesource.com/c/1330283Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611033}

Bug: v8:8503,821764
Change-Id: I0b541e06f0326f8270e14e0b7a685cab3c288882
Reviewed-on: https://chromium-review.googlesource.com/c/1350177Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611032}

This is useful in debugging to attribute what a window is.

BUG=none
TEST=none

Change-Id: If996333847d83c5102ddd81e4ecff25691c09eca
Reviewed-on: https://chromium-review.googlesource.com/c/1351099
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611031}

The crasher happens when the session is connected/disconnected. The code
registers/unregisters RemoteMediaClient callback upon
connecting/disconnecting. However it should check the availability of
RemoteMediaClient of the current session.

Bug: 711860
Change-Id: Ie4b29f507a0044ac8649b52b37f1541e4dc9b4ee
Reviewed-on: https://chromium-review.googlesource.com/c/1350211
Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611030}