GitLab

Prior to this CL, clicking cancel on the connecting dialog simply
returns the user to the home screen, without disconnecting the session or
cleaning up any related resources.

This CL provides a cleaner way to cancel a session with by implementing
remoting.ConnectingDialog which calls stop() on the activity.

BUG=477522

Review URL: https://codereview.chromium.org/1101613003

Cr-Commit-Position: refs/heads/master@{#326926}

We want to change activate so that rejecting the waitUntil promise
is the same as resolving it. Adding UMA to get an idea of the impact
of the change. It could be useful to have this data anyway, so also
adding it for Install.

BUG=480050

Review URL: https://codereview.chromium.org/1098953005

Cr-Commit-Position: refs/heads/master@{#326925}

Replace them with CapturedNetLogEntry.

BUG=none
TBR=bengr@chromium.org

Review URL: https://codereview.chromium.org/1109473003

Cr-Commit-Position: refs/heads/master@{#326924}

This adds SERVICE_WORKER_ERROR_DISK_CACHE to indicate
failure to read from the disk cache. It also re-enables
logging of StartWorker for redundant workers. This was
previously disabled because we got a lot of "failed" spam
for updates that get aborted when there is no script change,
so I've changed StartWorker to fail with SW_ERROR_EXISTS in
that case.

This patch is a step in the direction of evicting a SW
that can't be read from disk cache.

BUG=448003

Review URL: https://codereview.chromium.org/1054033004

Cr-Commit-Position: refs/heads/master@{#326923}

TBR=dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1098253006

Cr-Commit-Position: refs/heads/master@{#326922}

BUG=481210
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/1090863005

Cr-Commit-Position: refs/heads/master@{#326921}

Tags "q" and "cite" were invisible in dark theme.

BUG=480646

Review URL: https://codereview.chromium.org/1054503003

Cr-Commit-Position: refs/heads/master@{#326920}

To bring in layout fix to display layer debug info in frame viewer tracing.

Summary of changes available at:
https://chromium.googlesource.com/external/trace-viewer/+log/f8f4efb..bd416ea

bd416ea  More min-height fixes
3e04994  Move RAIL scoring to rail_socre.html
35c48d0  Change pre-commit hooks to pre-submit hooks
6675831  Aggregate MemoryDumpAllocator attributes
4bf2eab  Update memory_dumps.json to use generic attributes
957fe59  Allow generic attributes of MemoryAllocatorDump objects
cbde6af  Quick fix for #930
a74372e  More min-height flexbox changes
38be559  Click & drag down from ruler to draw guide line and generate nav string
24e160f  Infer implicit ancestor memory allocator dumps in TraceEventImporter
078b908  tquery: Don't use polymer for non-visual classes

Size decrease for resources.pak:
60627 bytes (16666772 -> 16606145)

BUG=480554

Review URL: https://codereview.chromium.org/1086873006

Cr-Commit-Position: refs/heads/master@{#326919}

TBR=dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1051763008

Cr-Commit-Position: refs/heads/master@{#326918}

This custom polymer element shows a list of media-router-sink elements. It is styled after the current cast extension's sinks.

BUG=464222

Review URL: https://codereview.chromium.org/1099723003

Cr-Commit-Position: refs/heads/master@{#326917}

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1095333004

Cr-Commit-Position: refs/heads/master@{#326916}

Debugging some tests that were unblocked by codereview.chromium.org/1084793002, I found that waiting for the password field to disappear sometimes fails. We need to wait for the OOBE page to disappear before continuing to the test logic.

BUG=480571

Review URL: https://codereview.chromium.org/1063853008

Cr-Commit-Position: refs/heads/master@{#326915}

Revert of [Android] Add an out-of-app instrumentation driver APK. (patchset #15 id:280001 of https://codereview.chromium.org/1034053002/)

Reason for revert:
Broke the "Android" bot:

http://build.chromium.org/p/chromium/builders/Android/builds/38661

Original issue's description:
> [Android] Add an out-of-app instrumentation driver APK.
>
> BUG=444049
>
> Committed: https://crrev.com/79d22ed2b74d0ff1082f6febfd3fd93c0574d130
> Cr-Commit-Position: refs/heads/master@{#326900}

TBR=tedchoc@chromium.org,klundberg@chromium.org,yfriedman@chromium.org,thestig@chromium.org,cjhopman@chromium.org,torne@chromium.org,jbudorick@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444049

Review URL: https://codereview.chromium.org/1094903008

Cr-Commit-Position: refs/heads/master@{#326914}

Depend on https://codereview.chromium.org/999243003/.

BUG=466867

Review URL: https://codereview.chromium.org/1061133002

Cr-Commit-Position: refs/heads/master@{#326913}

This cleans up some of the damage rects code by converting the SkRegion
to a cc::Region, allowing use of gfx::Rects. It moves the recursion
over the Layer tree out to Compositor instead of on Layer.

And we keep the damaged_region_ valid until the layer is painted. This
will allow us to pass that damaged_region_ to the painting code with
impl-side slimming paint, because with impl-side painting, the paint
clip rect can be larger than the invalidations (as large as the whole
layer).

R=piman@chromium.org, sky
BUG=466426

Committed: https://crrev.com/a5e585868e16ce53c990f764d4943592f11749aa
Cr-Commit-Position: refs/heads/master@{#326547}

Review URL: https://codereview.chromium.org/1080633009

Cr-Commit-Position: refs/heads/master@{#326912}

TBR=dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1104703004

Cr-Commit-Position: refs/heads/master@{#326911}

BUG=479831

Review URL: https://codereview.chromium.org/1103913002

Cr-Commit-Position: refs/heads/master@{#326910}

It is not implemented yet. So all InstanceID***Functions are just placeholders.

BUG=477084
TEST=none

Review URL: https://codereview.chromium.org/1088593004

Cr-Commit-Position: refs/heads/master@{#326909}

This should no longer be required, causes a warning on chrome://extensions and may prevent CWS upload.

Review URL: https://codereview.chromium.org/1088213004

Cr-Commit-Position: refs/heads/master@{#326908}

To implement various kinds of re-initialization conditions more easily,
this CL subsumes responsibility for handling frame size changes directly
in the VideoToolbox encoder.

The design is very similar to the previous one with a proxy encoder.
Instead of proxying the entire encoder, only the video frame factory is
proxied. Both the encoder and the proxy own a ref-counted reference to
the factory, which in turn owns a weak back-reference to the encoder and
a ref-counted reference to the current pixel buffer pool.

When a frame size change is detected either by the encoder or by the
video frame factory, the internal compression session is reset. This is
done synchronously when executing on the Cast main thread, and by
posting a task to the cast main thread when not.

The code to re-initialize the compression session will be re-used in
upcoming work where additional conditions, such as backgrounding, need
to be monitored for session reinitialization.

This new CL fixes the cast unit tests by modifying the tests to handle
encoders that do not have a frame delay when changing the video size.

R=dcaiafa@chromium.org, miu@chromium.org
BUG=477895

Review URL: https://codereview.chromium.org/1100643002

Cr-Commit-Position: refs/heads/master@{#326907}

These files are now generated in the out/ directory.

Review URL: https://codereview.chromium.org/1076293007

Cr-Commit-Position: refs/heads/master@{#326906}

R=mdempsky@chromium.org
BUG=468851

Review URL: https://codereview.chromium.org/1106003002

Cr-Commit-Position: refs/heads/master@{#326905}

BUG=429756
R=droger

Review URL: https://codereview.chromium.org/1102833003

Cr-Commit-Position: refs/heads/master@{#326904}

This adds a LayerImpl::ValidateQuadResources() that each layer can
call on quads that it appends. This function is empty when DCHECKs are
off, which means it should be cheap/free in release builds.

R=piman@chromium.org
BUG=475894

Review URL: https://codereview.chromium.org/1096703006

Cr-Commit-Position: refs/heads/master@{#326903}

This pulls in the following Native Client changes:

0b3aba1: (jvoung@chromium.org) Add configure/CMake flags for conditionally building subzero targets.
d68a86e: (dschuff@chromium.org) Update revision for PNaCl
353db96: (mcgrathr@chromium.org) Implement a standard ELF loader in untrusted code, to be used by glibc
a5ef853: (jvoung@chromium.org) PNaCl: Update Subzero revision in pnacl/COMPONENT_REVISIONS
16212bd: (tfarina@chromium.org) Cleanup: Remove is_android_webview_build flag from NaCL gn config.
3a6e2fa: (dschuff@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
25152f5: (dschuff@chromium.org) Remove 2 torture test known failures for nacl-clang
dcd22d4: (mcgrathr@chromium.org) toolchain_build: Build glibc-flavored gcc_libs and sdk_libs
87d5dd9: (mcgrathr@chromium.org) toolchain_build: Include glibc-flavored gcc_libs in package-version upload

Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/efe1c643770e76a1c4747e4c5bf9338e5a0ef945..87d5dd90911a0657c27574f78e86b7dfc4ad8b29

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/1106023002

Cr-Commit-Position: refs/heads/master@{#326902}

BUG=477065
TEST=Likely no behavior change; maybe eliminate a crash.

Review URL: https://codereview.chromium.org/1071413004

Cr-Commit-Position: refs/heads/master@{#326901}

BUG=444049

Review URL: https://codereview.chromium.org/1034053002

Cr-Commit-Position: refs/heads/master@{#326900}

Revert of Remove special theming for CardUnmaskPrompt since it's now automatic (patchset #2 id:20001 of https://codereview.chromium.org/1096263005/)

Reason for revert:
automatic alert dialog styling was reverted, so revert this as well for now.

Original issue's description:
> Remove special theming for CardUnmaskPrompt since it's now automatic
> for all alert dialogs.
>
> BUG=463576
>
> Committed: https://crrev.com/d9456757bec482f2b27cf75ef7fa2109af0500a6
> Cr-Commit-Position: refs/heads/master@{#326869}

TBR=newt@chromium.org,aurimas@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463576

Review URL: https://codereview.chromium.org/1097263003

Cr-Commit-Position: refs/heads/master@{#326899}

Fixes an error on my Windows build:
d:\src\chrome-git\src\components\html_viewer\web_url_loader_impl.cc(254) : error C2220: warning treated as error - no 'object' file generated
d:\src\chrome-git\src\components\html_viewer\web_url_loader_impl.cc(254) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data

BUG=NONE
TEST=Windows html_viewer build succeeds.
R=erg@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1096243004

Cr-Commit-Position: refs/heads/master@{#326898}

Currently, when a poster image is specified that's 404 Not Found, or
too small, the placeholder can become too small and unclickable.

This change forces the placeholder HTML to expand to the size of the
WebViewPlugin.

BUG=475653

Review URL: https://codereview.chromium.org/1085993003

Cr-Commit-Position: refs/heads/master@{#326897}

This will also be enabled on Aura when Aura and Android touch selection flows
finally unified. I also plan to have at least one more experimental strategy
implmenented.

Prerequisite CL: https://codereview.chromium.org/988023005/

BUG=451255

Review URL: https://codereview.chromium.org/1096773002

Cr-Commit-Position: refs/heads/master@{#326896}

refresh token.

This change is necessary because, if the host daemon attempts to
retrieve an email address for an auth code from GCD, the request
fails, causing the host daemon to report failure and not return a
refresh token.

BUG=471928

Review URL: https://codereview.chromium.org/1076093003

Cr-Commit-Position: refs/heads/master@{#326895}

The parent_offset currently stored at each transform tree node sometimes
depends on the transform between some other node (which happens to
correspond to node's owning layer's parent's transform node) and the node's
parent. When this transform changes and the transform tree isn't rebuilt,
the parent_offset becomes stale. This CL replaces parent_offset with
source_offset, which is the portion of parent_offset that doesn't depend on
a transform between tree nodes, and adds a source_node_id to each node
so that the transform between nodes (when needed) can be recomputed
when the transform tree is updated.

BUG=480589

Review URL: https://codereview.chromium.org/1106013002

Cr-Commit-Position: refs/heads/master@{#326894}

Reland: Introduce sys_sigprocmask and sys_sigaction. (patchset #4 id:80001 of https://codereview.chromium.org/1092153005/)

The last version was broken for x86_64 DEBUG build.
On x86_64, it is necessary to set sa_restorer appropriately,
if not specified. What we need in the function is just invoking
the rt_sigreturn system call. However, it is special system call
which touches user land stack, so that a function prologue will
break the program.
In RELEASE build, that prologue is gone (including syscall() invocation)
by optimization. However, in DEBUG build, there is the prologue.
Unfortunately, all CQ and trybot do not run DEBUG tests so that it
was not catched.

Also, it turned out that MSAN does not work with direct sigaction syscall, unfortunately. (In more precise, it does not work if we *mix* direct sigaction syscall and sigaction() in libc).

This version fixes them.

TEST=Ran sandbox_linux_tests with DEBUG build locally. Ran msan tests, too. Ran trybots including 64 debug bot and msan ones.
BUG=358465
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_trusty32_rel,linux_arm,linux_chromium_trusty_dbg,linux_chromium_dbg_ng,linux_chromium_msan_rel_ng

Review URL: https://codereview.chromium.org/1099263003

Cr-Commit-Position: refs/heads/master@{#326893}

If the underlying call to 'gn gen' (or gyp_chromium) failed,
mb was swallowing the error.

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1078913003

Cr-Commit-Position: refs/heads/master@{#326892}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9d9725c..d96fd0c

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/1102833005

Cr-Commit-Position: refs/heads/master@{#326891}

This cherry-picks two mojo changes past e7270700, namely:

mojo.gni fix: https://chromium.googlesource.com/external/mojo/+/c88997f930c71b7e6748948263c4c01d7e10bc75
generated C++ interface definition fix: https://chromium.googlesource.com/external/mojo/+/6f41dc4d98fc17a447cd48837cc8ff7edf8df465

Finally this CL also adds a default TaskTracker to the
chromium mojo environment.

BUG=
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1101303002

Cr-Commit-Position: refs/heads/master@{#326890}

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1101323003

Cr-Commit-Position: refs/heads/master@{#326889}

The out-of-bounds access leads to a test failure under DrMemory.

BUG=480650
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/1109533003

Cr-Commit-Position: refs/heads/master@{#326888}

BUG=none
TEST=none
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/1107613003

Cr-Commit-Position: refs/heads/master@{#326887}